Module Name:src
Committed By: riastradh
Date: Sat Apr 22 15:32:49 UTC 2023
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: KNF. No functional change intended.
To generate a diff of this commit:
cvs rdiff -u -r1.217 -r1.218
Module Name:src
Committed By: riastradh
Date: Sat Apr 22 15:32:49 UTC 2023
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: KNF. No functional change intended.
To generate a diff of this commit:
cvs rdiff -u -r1.217 -r1.218
Module Name:src
Committed By: hannken
Date: Sat Apr 22 14:30:17 UTC 2023
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c specdev.h
Log Message:
Remove unused specdev member sd_rdev.
Ride 10.99.4
To generate a diff of this commit:
cvs rdiff -u -r1.216 -r1.217
Module Name:src
Committed By: hannken
Date: Sat Apr 22 14:30:17 UTC 2023
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c specdev.h
Log Message:
Remove unused specdev member sd_rdev.
Ride 10.99.4
To generate a diff of this commit:
cvs rdiff -u -r1.216 -r1.217
Module Name:src
Committed By: riastradh
Date: Sat Oct 15 15:20:46 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs(9): Attribute blame by stack trace for write to r/o medium.
To generate a diff of this commit:
cvs rdiff -u -r1.215 -r1.216
Module Name:src
Committed By: riastradh
Date: Sat Oct 15 15:20:46 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs(9): Attribute blame by stack trace for write to r/o medium.
To generate a diff of this commit:
cvs rdiff -u -r1.215 -r1.216
Module Name:src
Committed By: riastradh
Date: Wed Sep 21 10:59:10 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs(9): XXX comment: what if read downgrades lock?
To generate a diff of this commit:
cvs rdiff -u -r1.214 -r1.215
Module Name:src
Committed By: riastradh
Date: Wed Sep 21 10:59:10 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs(9): XXX comment: what if read downgrades lock?
To generate a diff of this commit:
cvs rdiff -u -r1.214 -r1.215
Module Name:src
Committed By: riastradh
Date: Fri Aug 12 21:25:39 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Refuse to open a closing-in-progress block device.
We could wait for close to complete, but if this happened ever so
Module Name:src
Committed By: riastradh
Date: Fri Aug 12 21:25:39 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Refuse to open a closing-in-progress block device.
We could wait for close to complete, but if this happened ever so
Module Name:src
Committed By: riastradh
Date: Fri Aug 12 17:06:01 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Assert !closing on successful open.
- If there's a prior concurrent close, it must have interrupted this
open.
- If
Module Name:src
Committed By: riastradh
Date: Fri Aug 12 17:06:01 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Assert !closing on successful open.
- If there's a prior concurrent close, it must have interrupted this
open.
- If
Module Name:src
Committed By: riastradh
Date: Fri Aug 12 17:05:49 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Assert opencnt>0 on successful open.
To generate a diff of this commit:
cvs rdiff -u -r1.211 -r1.212
Module Name:src
Committed By: riastradh
Date: Fri Aug 12 17:05:49 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Assert opencnt>0 on successful open.
To generate a diff of this commit:
cvs rdiff -u -r1.211 -r1.212
Module Name:src
Committed By: riastradh
Date: Thu Aug 11 12:52:24 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Sprinkle opencnt/opened/closing assertions.
There seems to be a bug here but I'm not sure what it is yet:
Module Name:src
Committed By: riastradh
Date: Thu Aug 11 12:52:24 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Sprinkle opencnt/opened/closing assertions.
There seems to be a bug here but I'm not sure what it is yet:
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:38:04 UTC 2022
Modified Files:
src/sys/miscfs/specfs: specdev.h
Log Message:
specfs: Reorder struct specnode members to save padding.
Shrinks from 40 bytes to 32 bytes on LP64 systems this way.
To generate a
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:38:04 UTC 2022
Modified Files:
src/sys/miscfs/specfs: specdev.h
Log Message:
specfs: Reorder struct specnode members to save padding.
Shrinks from 40 bytes to 32 bytes on LP64 systems this way.
To generate a
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:37:35 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Assert opencnt is nonzero before decrementing.
To generate a diff of this commit:
cvs rdiff -u -r1.206 -r1.207
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:37:35 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Assert opencnt is nonzero before decrementing.
To generate a diff of this commit:
cvs rdiff -u -r1.206 -r1.207
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:37:27 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Take an I/O reference across bdev/cdev_open.
- Revoke is used to invalidate all prior access control checks when
device
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:37:27 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Take an I/O reference across bdev/cdev_open.
- Revoke is used to invalidate all prior access control checks when
device
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:37:18 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Wait for last close in spec_node_revoke.
Otherwise, revoke -- and vdevgone, in the detach path of removable
devices -- may
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:37:18 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Wait for last close in spec_node_revoke.
Otherwise, revoke -- and vdevgone, in the detach path of removable
devices -- may
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:37:09 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c specdev.h
Log Message:
specfs: Prevent new opens while close is waiting to drain.
Otherwise, bdev/cdev_close could have cancelled all _existing_
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:37:09 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c specdev.h
Log Message:
specfs: Prevent new opens while close is waiting to drain.
Otherwise, bdev/cdev_close could have cancelled all _existing_
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:37:01 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Take an I/O reference in spec_node_setmountedfs.
This is not quite correct. We _should_ require the caller to hold a
vnode
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:37:01 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Take an I/O reference in spec_node_setmountedfs.
This is not quite correct. We _should_ require the caller to hold a
vnode
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:36:51 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c specdev.h
Log Message:
specfs: Drain all I/O operations after last .d_close call.
New kind of I/O reference on specdevs, sd_iocnt. This could
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:36:51 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c specdev.h
Log Message:
specfs: Drain all I/O operations after last .d_close call.
New kind of I/O reference on specdevs, sd_iocnt. This could
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:36:42 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c specdev.h
Log Message:
specfs: Resolve a race between close and a failing reopen.
To generate a diff of this commit:
cvs rdiff -u -r1.200
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:36:42 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c specdev.h
Log Message:
specfs: Resolve a race between close and a failing reopen.
To generate a diff of this commit:
cvs rdiff -u -r1.200
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:36:34 UTC 2022
Modified Files:
src/sys/miscfs/specfs: specdev.h
Log Message:
specfs: Document sn_opencnt, sd_opencnt, sd_refcnt.
To generate a diff of this commit:
cvs rdiff -u -r1.46 -r1.47
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:36:34 UTC 2022
Modified Files:
src/sys/miscfs/specfs: specdev.h
Log Message:
specfs: Document sn_opencnt, sd_opencnt, sd_refcnt.
To generate a diff of this commit:
cvs rdiff -u -r1.46 -r1.47
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:36:27 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Paranoia: Assert opencnt is zero on reclaim.
To generate a diff of this commit:
cvs rdiff -u -r1.199 -r1.200
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:36:27 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Paranoia: Assert opencnt is zero on reclaim.
To generate a diff of this commit:
cvs rdiff -u -r1.199 -r1.200
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:36:18 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Omit needless vdead_check in spec_fdiscard.
The vnode lock is held, so the vnode cannot be revoked without also
changing
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:36:18 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Omit needless vdead_check in spec_fdiscard.
The vnode lock is held, so the vnode cannot be revoked without also
changing
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:36:09 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Add a comment and assertion to spec_close about refcnts.
To generate a diff of this commit:
cvs rdiff -u -r1.197 -r1.198
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:36:09 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Add a comment and assertion to spec_close about refcnts.
To generate a diff of this commit:
cvs rdiff -u -r1.197 -r1.198
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:36:01 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: If sd_opencnt is zero, sn_opencnt had better be zero.
To generate a diff of this commit:
cvs rdiff -u -r1.196 -r1.197
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:36:01 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: If sd_opencnt is zero, sn_opencnt had better be zero.
To generate a diff of this commit:
cvs rdiff -u -r1.196 -r1.197
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:35:52 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Factor KASSERT out of switch in spec_open.
No functional change.
To generate a diff of this commit:
cvs rdiff -u -r1.195
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:35:52 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Factor KASSERT out of switch in spec_open.
No functional change.
To generate a diff of this commit:
cvs rdiff -u -r1.195
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:35:44 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: sn_gone cannot be set while we hold the vnode lock.
Revoke runs with the vnode lock too, which is exclusive. Add an
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:35:44 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: sn_gone cannot be set while we hold the vnode lock.
Revoke runs with the vnode lock too, which is exclusive. Add an
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:35:35 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Reorganize D_DISK tail of spec_open and explain what's up.
No functional change intended.
To generate a diff of this
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:35:35 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Reorganize D_DISK tail of spec_open and explain what's up.
No functional change intended.
To generate a diff of this
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:35:26 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Factor VOP_UNLOCK/vn_lock out of switch for clarity.
No functional change.
To generate a diff of this commit:
cvs rdiff
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:35:26 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Factor VOP_UNLOCK/vn_lock out of switch for clarity.
No functional change.
To generate a diff of this commit:
cvs rdiff
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:35:17 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Factor common device_lock out of switch for clarity.
No functional change.
To generate a diff of this commit:
cvs rdiff
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:35:17 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Factor common device_lock out of switch for clarity.
No functional change.
To generate a diff of this commit:
cvs rdiff
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:35:08 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Delete bogus comment about .d_open/.d_close at same time.
Annoying as it is that .d_open and .d_close can run at the same
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:35:08 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Delete bogus comment about .d_open/.d_close at same time.
Annoying as it is that .d_open and .d_close can run at the same
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:34:59 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Split spec_open switch into three sections.
The sections are now:
1. Acquire open reference.
1a (intermezzo). Set
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:34:59 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Split spec_open switch into three sections.
The sections are now:
1. Acquire open reference.
1a (intermezzo). Set
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:34:51 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Factor common kauth check out of switch in spec_open.
No functional change.
To generate a diff of this commit:
cvs rdiff
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:34:51 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Factor common kauth check out of switch in spec_open.
No functional change.
To generate a diff of this commit:
cvs rdiff
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:34:42 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Assert v_type is VBLK or VCHR in spec_open.
Nothing else makes sense. Prune dead branches (and replace default
case by
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:34:42 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Assert v_type is VBLK or VCHR in spec_open.
Nothing else makes sense. Prune dead branches (and replace default
case by
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:34:34 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Call bdev_open without the vnode lock.
There is no need for it to serialize opens, because they are already
serialized by
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:34:34 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Call bdev_open without the vnode lock.
There is no need for it to serialize opens, because they are already
serialized by
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:34:26 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Note lock order for vnode lock, device_lock, v_interlock.
To generate a diff of this commit:
cvs rdiff -u -r1.185 -r1.186
Module Name:src
Committed By: riastradh
Date: Mon Mar 28 12:34:26 UTC 2022
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
specfs: Note lock order for vnode lock, device_lock, v_interlock.
To generate a diff of this commit:
cvs rdiff -u -r1.185 -r1.186
On Thu, 8 Sep 2016, matthew green wrote:
"Paul Goyette" writes:
Module Name:src
Committed By: pgoyette
Date: Thu Sep 8 00:07:48 UTC 2016
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
if_config processing wants to auto-load modules named with an if_
"Paul Goyette" writes:
> Module Name: src
> Committed By: pgoyette
> Date: Thu Sep 8 00:07:48 UTC 2016
>
> Modified Files:
> src/sys/miscfs/specfs: spec_vnops.c
>
> Log Message:
> if_config processing wants to auto-load modules named with an if_ prefix,
> while specfc wants to
In article <2015135437.b205bf...@cvs.netbsd.org>,
Paul Goyette wrote:
>-=-=-=-=-=-
>
>Module Name: src
>Committed By: pgoyette
>Date: Tue Dec 22 23:54:37 UTC 2015
>
>Modified Files:
> src/sys/miscfs/specfs: spec_vnops.c
>
>Log Message:
>If we
On Wed, 23 Dec 2015, Christos Zoulas wrote:
In article <2015135437.b205bf...@cvs.netbsd.org>,
Paul Goyette wrote:
-=-=-=-=-=-
Module Name:src
Committed By: pgoyette
Date: Tue Dec 22 23:54:37 UTC 2015
Modified Files:
On 29 Jun 2015, at 18:47, David Holland dholland-sourcechan...@netbsd.org
wrote:
On Mon, Jun 29, 2015 at 12:25:49PM -0400, Christos Zoulas wrote:
Module Name: src
Committed By:christos
Date:Mon Jun 29 16:25:49 UTC 2015
Modified Files:
src/sys/miscfs/specfs:
On Mon, Jun 29, 2015 at 12:25:49PM -0400, Christos Zoulas wrote:
Module Name: src
Committed By:christos
Date:Mon Jun 29 16:25:49 UTC 2015
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
Revert previous, and explain why.
Hrm,
On Tue Apr 13 2010 at 01:15:56 +, Adam Hoka wrote:
Module Name: src
Committed By: ahoka
Date: Tue Apr 13 01:15:56 UTC 2010
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log Message:
Autoload modules with any class.
This fixes autoloading of pf, zfs and
On Tue, Apr 13, 2010 at 10:47:51AM +0300, Antti Kantee wrote:
On Tue Apr 13 2010 at 01:15:56 +, Adam Hoka wrote:
Module Name:src
Committed By: ahoka
Date: Tue Apr 13 01:15:56 UTC 2010
Modified Files:
src/sys/miscfs/specfs: spec_vnops.c
Log
On Tue, Apr 13, 2010 at 03:27:11PM +0300, Antti Kantee wrote:
On Tue Apr 13 2010 at 12:18:38 +, Andrew Doran wrote:
On Tue, Apr 13, 2010 at 10:47:51AM +0300, Antti Kantee wrote:
On Tue Apr 13 2010 at 01:15:56 +, Adam Hoka wrote:
Module Name:src
Committed By: ahoka
On Tue Apr 13 2010 at 12:32:38 +, Andrew Doran wrote:
So the kernel of the problem is namespace collisions, correct?
Mostly. Though I still think it's not expected that opening a /dev
node will load e.g. an exec package or secmodel even if that's what some
programmer wants.
Would you
On Tue, Apr 13, 2010 at 03:40:24PM +0300, Antti Kantee wrote:
On Tue Apr 13 2010 at 12:32:38 +, Andrew Doran wrote:
So the kernel of the problem is namespace collisions, correct?
Mostly. Though I still think it's not expected that opening a /dev
node will load e.g. an exec package or
On Tue Apr 13 2010 at 13:25:24 +, Andrew Doran wrote:
So the result of our teeth-pulling so far is:
1. You are concerned about namespace conflicts. I am too.
2. I would be happy to see these managed through documentation and
a straightforward approval process for adding modules.
On Tue, Apr 13, 2010 at 10:47 PM, Antti Kantee po...@cs.hut.fi wrote:
On Tue Apr 13 2010 at 13:25:24 +, Andrew Doran wrote:
So the result of our teeth-pulling so far is:
1. You are concerned about namespace conflicts. I am too.
2. I would be happy to see these managed through
77 matches
Mail list logo