Re: CVS commit: src/sys/netinet

2021-02-16 Thread Martin Husemann
On Tue, Feb 16, 2021 at 09:29:15AM +, Roy Marples wrote: > In my testing on aarch64 and octeon (both of which I think are strict > alignment) neither need pullups nor copyups as the mbuf already has enough > and arphrd is aligned correctly already. Ah, we asserted too much alignment - indeed,

Re: CVS commit: src/sys/netinet

2021-02-16 Thread Roy Marples
On 16/02/2021 09:20, Martin Husemann wrote: On Tue, Feb 16, 2021 at 08:26:40AM +, Roy Marples wrote: Is that because ARP_HDR_ALIGNMENT is forcing 4 byte alignment? The KASSERT a few lines below triggerd, we need to be consistent. For the purposes of using just the header we define I'm

Re: CVS commit: src/sys/netinet

2021-02-16 Thread Martin Husemann
On Tue, Feb 16, 2021 at 08:26:40AM +, Roy Marples wrote: > Is that because ARP_HDR_ALIGNMENT is forcing 4 byte alignment? The KASSERT a few lines below triggerd, we need to be consistent. > For the purposes of using just the header we define I'm pretty sure we can > use 2 byte alignment and

Re: CVS commit: src/sys/netinet

2021-02-16 Thread Roy Marples
On 16/02/2021 05:44, Martin Husemann wrote: Module Name:src Committed By: martin Date: Tue Feb 16 05:44:14 UTC 2021 Modified Files: src/sys/netinet: if_arp.c Log Message: Undo previous backout: alignment is needed here. The reason for the previous backout was a

Re: CVS commit: src/sys/netinet

2020-12-04 Thread Jason Thorpe
> On Dec 4, 2020, at 8:57 AM, Christos Zoulas wrote: > > In article <20201204004439.90c25f...@cvs.netbsd.org>, > Jason R Thorpe wrote: >> -=-=-=-=-=- >> >> Module Name: src >> Committed By:thorpej >> Date:Fri Dec 4 00:44:39 UTC 2020 >> >> Modified Files: >>

Re: CVS commit: src/sys/netinet

2020-12-04 Thread Christos Zoulas
In article <20201204004439.90c25f...@cvs.netbsd.org>, Jason R Thorpe wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: thorpej >Date: Fri Dec 4 00:44:39 UTC 2020 > >Modified Files: > src/sys/netinet: files.ipfilter > >Log Message: >Build ip_sync.c with -Wno-error to avoid

CVS commit: src/sys/netinet

2019-11-17 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sun Nov 17 08:21:25 UTC 2019 Modified Files: src/sys/netinet: tcp_output.c Log Message: Don't allow zero sized segments that will panic the stack. Reported-by: syzbot+5542516fa4afe7a10...@syzkaller.appspotmail.com To generate

CVS commit: src/sys/netinet

2019-11-17 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sun Nov 17 08:21:25 UTC 2019 Modified Files: src/sys/netinet: tcp_output.c Log Message: Don't allow zero sized segments that will panic the stack. Reported-by: syzbot+5542516fa4afe7a10...@syzkaller.appspotmail.com To generate

CVS commit: src/sys/netinet

2019-11-16 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Nov 16 10:15:10 UTC 2019 Modified Files: src/sys/netinet: tcp_input.c Log Message: Call rtcache_unref() only when the checks succeed, instead of relying on another NULL check in rtcache_unref(). Because, in order to resolve

CVS commit: src/sys/netinet

2019-11-16 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Nov 16 10:15:10 UTC 2019 Modified Files: src/sys/netinet: tcp_input.c Log Message: Call rtcache_unref() only when the checks succeed, instead of relying on another NULL check in rtcache_unref(). Because, in order to resolve

CVS commit: src/sys/netinet

2019-11-01 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Fri Nov 1 13:54:59 UTC 2019 Modified Files: src/sys/netinet: tcp.h Log Message: Add comments to the tcp flags. To generate a diff of this commit: cvs rdiff -u -r1.33 -r1.34 src/sys/netinet/tcp.h Please note that diffs are

CVS commit: src/sys/netinet

2019-11-01 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Fri Nov 1 13:54:59 UTC 2019 Modified Files: src/sys/netinet: tcp.h Log Message: Add comments to the tcp flags. To generate a diff of this commit: cvs rdiff -u -r1.33 -r1.34 src/sys/netinet/tcp.h Please note that diffs are

CVS commit: src/sys/netinet

2019-10-11 Thread Roy Marples
Module Name:src Committed By: roy Date: Fri Oct 11 13:32:46 UTC 2019 Modified Files: src/sys/netinet: if_arp.c Log Message: ARP: Don't defend ARP probes. We should let the nature of ARP takes it's course here when our address is neither tentative nor duplicated. This

CVS commit: src/sys/netinet

2019-10-11 Thread Roy Marples
Module Name:src Committed By: roy Date: Fri Oct 11 13:32:46 UTC 2019 Modified Files: src/sys/netinet: if_arp.c Log Message: ARP: Don't defend ARP probes. We should let the nature of ARP takes it's course here when our address is neither tentative nor duplicated. This

CVS commit: src/sys/netinet

2019-10-08 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Wed Oct 9 05:29:18 UTC 2019 Modified Files: src/sys/netinet: tcp_congctl.c Log Message: All of snd_wnd, snd_cwnd and snd_ssthresh in stuct tcpcb are u_long, so use u_long and ulmin() instead of u_int and uimin(). Found by lgtm

CVS commit: src/sys/netinet

2019-10-08 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Wed Oct 9 05:29:18 UTC 2019 Modified Files: src/sys/netinet: tcp_congctl.c Log Message: All of snd_wnd, snd_cwnd and snd_ssthresh in stuct tcpcb are u_long, so use u_long and ulmin() instead of u_int and uimin(). Found by lgtm

CVS commit: src/sys/netinet

2019-09-25 Thread John Nemeth
Module Name:src Committed By: jnemeth Date: Wed Sep 25 19:06:30 UTC 2019 Modified Files: src/sys/netinet: tcp_input.c Log Message: PR/54572 - Edgar Fu� -- error in comment To generate a diff of this commit: cvs rdiff -u -r1.415 -r1.416 src/sys/netinet/tcp_input.c

CVS commit: src/sys/netinet

2019-09-25 Thread John Nemeth
Module Name:src Committed By: jnemeth Date: Wed Sep 25 19:06:30 UTC 2019 Modified Files: src/sys/netinet: tcp_input.c Log Message: PR/54572 - Edgar Fu� -- error in comment To generate a diff of this commit: cvs rdiff -u -r1.415 -r1.416 src/sys/netinet/tcp_input.c

CVS commit: src/sys/netinet

2019-09-18 Thread Ryota Ozaki
Module Name:src Committed By: ozaki-r Date: Thu Sep 19 04:09:34 UTC 2019 Modified Files: src/sys/netinet: wqinput.c Log Message: wqinput: avoid having struct wqinput_worklist directly in a percpu storage percpu(9) has a certain memory storage for each CPU and provides it

CVS commit: src/sys/netinet

2019-09-18 Thread Ryota Ozaki
Module Name:src Committed By: ozaki-r Date: Thu Sep 19 04:09:34 UTC 2019 Modified Files: src/sys/netinet: wqinput.c Log Message: wqinput: avoid having struct wqinput_worklist directly in a percpu storage percpu(9) has a certain memory storage for each CPU and provides it

CVS commit: src/sys/netinet

2019-09-01 Thread Roy Marples
Module Name:src Committed By: roy Date: Sun Sep 1 22:09:02 UTC 2019 Modified Files: src/sys/netinet: if_arp.c Log Message: inet: Send RTM_MISS when we fail to resolve an address. Takes the same approach as when adding a new address - we no longer announce the new lladdr

CVS commit: src/sys/netinet

2019-09-01 Thread Roy Marples
Module Name:src Committed By: roy Date: Sun Sep 1 22:09:02 UTC 2019 Modified Files: src/sys/netinet: if_arp.c Log Message: inet: Send RTM_MISS when we fail to resolve an address. Takes the same approach as when adding a new address - we no longer announce the new lladdr

CVS commit: src/sys/netinet

2019-08-30 Thread Roy Marples
Module Name:src Committed By: roy Date: Fri Aug 30 18:52:00 UTC 2019 Modified Files: src/sys/netinet: if_arp.c Log Message: ARP: change default sysctl entry log_movements to 0 IP address sharing is a thing and shouldn't cause needless diagnostics by default. To

CVS commit: src/sys/netinet

2019-08-30 Thread Roy Marples
Module Name:src Committed By: roy Date: Fri Aug 30 18:52:00 UTC 2019 Modified Files: src/sys/netinet: if_arp.c Log Message: ARP: change default sysctl entry log_movements to 0 IP address sharing is a thing and shouldn't cause needless diagnostics by default. To

CVS commit: src/sys/netinet

2019-08-30 Thread Roy Marples
Module Name:src Committed By: roy Date: Fri Aug 30 18:48:34 UTC 2019 Modified Files: src/sys/netinet: if_arp.c Log Message: ARP: remove unused sysctl entry log_unknown_network To generate a diff of this commit: cvs rdiff -u -r1.284 -r1.285 src/sys/netinet/if_arp.c

CVS commit: src/sys/netinet

2019-08-30 Thread Roy Marples
Module Name:src Committed By: roy Date: Fri Aug 30 18:48:34 UTC 2019 Modified Files: src/sys/netinet: if_arp.c Log Message: ARP: remove unused sysctl entry log_unknown_network To generate a diff of this commit: cvs rdiff -u -r1.284 -r1.285 src/sys/netinet/if_arp.c

CVS commit: src/sys/netinet

2019-08-13 Thread Robert Swindells
Module Name:src Committed By: rjs Date: Tue Aug 13 19:55:40 UTC 2019 Modified Files: src/sys/netinet: sctp_crc32.c sctp_crc32.h sctputil.c Log Message: Remove unused checksum code. To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/sys/netinet/sctp_crc32.c

CVS commit: src/sys/netinet

2019-08-13 Thread Robert Swindells
Module Name:src Committed By: rjs Date: Tue Aug 13 19:55:40 UTC 2019 Modified Files: src/sys/netinet: sctp_crc32.c sctp_crc32.h sctputil.c Log Message: Remove unused checksum code. To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/sys/netinet/sctp_crc32.c

CVS commit: src/sys/netinet

2019-08-06 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Aug 6 15:48:19 UTC 2019 Modified Files: src/sys/netinet: tcp_input.c tcp_subr.c tcp_timer.h tcp_usrreq.c Log Message: Clamp tcp timer quantities to reasonable ranges. Reported-by:

CVS commit: src/sys/netinet

2019-08-06 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Aug 6 15:48:19 UTC 2019 Modified Files: src/sys/netinet: tcp_input.c tcp_subr.c tcp_timer.h tcp_usrreq.c Log Message: Clamp tcp timer quantities to reasonable ranges. Reported-by:

CVS commit: src/sys/netinet

2019-06-08 Thread Robert Swindells
Module Name:src Committed By: rjs Date: Sat Jun 8 23:23:34 UTC 2019 Modified Files: src/sys/netinet: sctp_asconf.h sctp_pcb.h Log Message: Don't need 'extern' for function prototypes. To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3

CVS commit: src/sys/netinet

2019-06-08 Thread Robert Swindells
Module Name:src Committed By: rjs Date: Sat Jun 8 23:23:34 UTC 2019 Modified Files: src/sys/netinet: sctp_asconf.h sctp_pcb.h Log Message: Don't need 'extern' for function prototypes. To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3

CVS commit: src/sys/netinet

2019-06-04 Thread Kengo NAKAHARA
Module Name:src Committed By: knakahara Date: Wed Jun 5 01:31:05 UTC 2019 Modified Files: src/sys/netinet: ip_output.c Log Message: The packets which will be esp-fragmented should not be applied pfil. Pointed out by ohishi@IIJ, thanks. To generate a diff of this

CVS commit: src/sys/netinet

2019-06-04 Thread Kengo NAKAHARA
Module Name:src Committed By: knakahara Date: Wed Jun 5 01:31:05 UTC 2019 Modified Files: src/sys/netinet: ip_output.c Log Message: The packets which will be esp-fragmented should not be applied pfil. Pointed out by ohishi@IIJ, thanks. To generate a diff of this

CVS commit: src/sys/netinet

2019-06-04 Thread Kengo NAKAHARA
Module Name:src Committed By: knakahara Date: Wed Jun 5 01:27:20 UTC 2019 Modified Files: src/sys/netinet: ip_output.c Log Message: Fix rtcache cannot be released once an esp-fragmented packet is sent. Pointed out by ohishi@IIJ, thanks. To generate a diff of this

CVS commit: src/sys/netinet

2019-06-04 Thread Kengo NAKAHARA
Module Name:src Committed By: knakahara Date: Wed Jun 5 01:27:20 UTC 2019 Modified Files: src/sys/netinet: ip_output.c Log Message: Fix rtcache cannot be released once an esp-fragmented packet is sent. Pointed out by ohishi@IIJ, thanks. To generate a diff of this

CVS commit: src/sys/netinet

2019-06-01 Thread Joerg Sonnenberger
Module Name:src Committed By: joerg Date: Sat Jun 1 19:13:41 UTC 2019 Modified Files: src/sys/netinet: ip_carp.c Log Message: Define carp6_cksum only when it is used, that is under INET6 To generate a diff of this commit: cvs rdiff -u -r1.102 -r1.103

CVS commit: src/sys/netinet

2019-06-01 Thread Joerg Sonnenberger
Module Name:src Committed By: joerg Date: Sat Jun 1 19:13:41 UTC 2019 Modified Files: src/sys/netinet: ip_carp.c Log Message: Define carp6_cksum only when it is used, that is under INET6 To generate a diff of this commit: cvs rdiff -u -r1.102 -r1.103

CVS commit: src/sys/netinet

2019-06-01 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat Jun 1 15:18:42 UTC 2019 Modified Files: src/sys/netinet: tcp_input.c Log Message: Replace potentially misaligned pointer dereference + htonl() with be32dec() Reported by kUBSan. To generate a diff of this commit: cvs rdiff

CVS commit: src/sys/netinet

2019-06-01 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat Jun 1 15:18:42 UTC 2019 Modified Files: src/sys/netinet: tcp_input.c Log Message: Replace potentially misaligned pointer dereference + htonl() with be32dec() Reported by kUBSan. To generate a diff of this commit: cvs rdiff

CVS commit: src/sys/netinet

2019-05-14 Thread Kengo NAKAHARA
Module Name:src Committed By: knakahara Date: Wed May 15 03:33:41 UTC 2019 Modified Files: src/sys/netinet: ip_encap.c Log Message: Fix build failure when INET6 is disabled. Pointed out by ozaki-r@n.o, thanks. To generate a diff of this commit: cvs rdiff -u -r1.70

CVS commit: src/sys/netinet

2019-05-14 Thread Kengo NAKAHARA
Module Name:src Committed By: knakahara Date: Wed May 15 03:33:41 UTC 2019 Modified Files: src/sys/netinet: ip_encap.c Log Message: Fix build failure when INET6 is disabled. Pointed out by ozaki-r@n.o, thanks. To generate a diff of this commit: cvs rdiff -u -r1.70

Re: CVS commit: src/sys/netinet

2019-02-25 Thread Martin Husemann
On Mon, Feb 25, 2019 at 11:35:35AM +0100, Kamil Rytarowski wrote: > This is right, SCTP build wasn't tested and I got it enabled locally. > I propose to build ALL by default as we now depend on external services > to have functional 24/7 build with sanitizers (syzkaller). Yes, it needs to be part

Re: CVS commit: src/sys/netinet

2019-02-25 Thread Kamil Rytarowski
On 25.02.2019 11:23, Martin Husemann wrote: > On Mon, Feb 25, 2019 at 01:19:02PM +0300, Valery Ushakov wrote: >> On Mon, Feb 25, 2019 at 06:23:33 +0100, Martin Husemann wrote: >> >>> On Sun, Feb 24, 2019 at 09:43:52PM +0100, Kamil Rytarowski wrote: I consider that this is just GCC specific

Re: CVS commit: src/sys/netinet

2019-02-25 Thread Martin Husemann
On Mon, Feb 25, 2019 at 01:19:02PM +0300, Valery Ushakov wrote: > On Mon, Feb 25, 2019 at 06:23:33 +0100, Martin Husemann wrote: > > > On Sun, Feb 24, 2019 at 09:43:52PM +0100, Kamil Rytarowski wrote: > > > I consider that this is just GCC specific behavior to make some warnings > > > fatal

Re: CVS commit: src/sys/netinet

2019-02-25 Thread Valery Ushakov
On Mon, Feb 25, 2019 at 06:23:33 +0100, Martin Husemann wrote: > On Sun, Feb 24, 2019 at 09:43:52PM +0100, Kamil Rytarowski wrote: > > I consider that this is just GCC specific behavior to make some warnings > > fatal depending on driver configuration. This is typical behavior of GCC > > that we

re: CVS commit: src/sys/netinet

2019-02-24 Thread matthew green
> If you think that this is better and it works, please go for it. please, no. don't duplicate prototypes in a way that changes won't be detected. ie, if the real sctp code changes, today the compat caller will fail to build until updated. with this change, it will build and be entirely wrong.

Re: CVS commit: src/sys/netinet

2019-02-24 Thread Kamil Rytarowski
On 24.02.2019 23:55, Robert Swindells wrote: > > Kamil Rytarowski wrote: >> Module Name:src >> Committed By: kamil >> Date: Sun Feb 24 17:01:52 UTC 2019 >> >> Modified Files: >>src/sys/netinet: sctp_asconf.h >> >> Log Message: >> Appease GCC7 in sctp_asconf.h >> >> Do not

Re: CVS commit: src/sys/netinet

2019-02-24 Thread Robert Swindells
Kamil Rytarowski wrote: >Module Name:src >Committed By: kamil >Date: Sun Feb 24 17:01:52 UTC 2019 > >Modified Files: >src/sys/netinet: sctp_asconf.h > >Log Message: >Appease GCC7 in sctp_asconf.h > >Do not declare types inside function parameter list. >Add decklarations

Re: CVS commit: src/sys/netinet

2019-02-24 Thread Martin Husemann
On Sun, Feb 24, 2019 at 09:43:52PM +0100, Kamil Rytarowski wrote: > I consider that this is just GCC specific behavior to make some warnings > fatal depending on driver configuration. This is typical behavior of GCC > that we keep observing all over again. No, this is very different to optimizer

Re: CVS commit: src/sys/netinet

2019-02-24 Thread Kamil Rytarowski
On 24.02.2019 21:38, Martin Husemann wrote: > On Sun, Feb 24, 2019 at 09:36:55PM +0100, Kamil Rytarowski wrote: >> My only specific change was NetBSD/i386 kernel=GENERIC with kUBSan and >> KCOV enabled. > > This does not answer the question. What does enabling kUBSan/KCOV break > to make this

Re: CVS commit: src/sys/netinet

2019-02-24 Thread Kamil Rytarowski
On 24.02.2019 21:43, Kamil Rytarowski wrote: > On 24.02.2019 21:38, Martin Husemann wrote: >> On Sun, Feb 24, 2019 at 09:36:55PM +0100, Kamil Rytarowski wrote: >>> My only specific change was NetBSD/i386 kernel=GENERIC with kUBSan and >>> KCOV enabled. >> >> This does not answer the question. What

Re: CVS commit: src/sys/netinet

2019-02-24 Thread Martin Husemann
On Sun, Feb 24, 2019 at 09:36:55PM +0100, Kamil Rytarowski wrote: > My only specific change was NetBSD/i386 kernel=GENERIC with kUBSan and > KCOV enabled. This does not answer the question. What does enabling kUBSan/KCOV break to make this error show up in your compilation, but not in our default

Re: CVS commit: src/sys/netinet

2019-02-24 Thread Kamil Rytarowski
On 24.02.2019 20:39, Martin Husemann wrote: > On Sun, Feb 24, 2019 at 07:20:10PM +0100, Kamil Rytarowski wrote: >> On 24.02.2019 19:15, David Holland wrote: >>> On Sun, Feb 24, 2019 at 05:01:52PM +, Kamil Rytarowski wrote: >>> > Modified Files: >>> > src/sys/netinet: sctp_asconf.h >>> >

Re: CVS commit: src/sys/netinet

2019-02-24 Thread Martin Husemann
On Sun, Feb 24, 2019 at 07:20:10PM +0100, Kamil Rytarowski wrote: > On 24.02.2019 19:15, David Holland wrote: > > On Sun, Feb 24, 2019 at 05:01:52PM +, Kamil Rytarowski wrote: > > > Modified Files: > > > src/sys/netinet: sctp_asconf.h > > > > > > Log Message: > > > Appease GCC7 in

Re: CVS commit: src/sys/netinet

2019-02-24 Thread Kamil Rytarowski
On 24.02.2019 19:15, David Holland wrote: > On Sun, Feb 24, 2019 at 05:01:52PM +, Kamil Rytarowski wrote: > > Modified Files: > >src/sys/netinet: sctp_asconf.h > > > > Log Message: > > Appease GCC7 in sctp_asconf.h > > > > Do not declare types inside function parameter list. > >

Re: CVS commit: src/sys/netinet

2019-02-24 Thread David Holland
On Sun, Feb 24, 2019 at 05:01:52PM +, Kamil Rytarowski wrote: > Modified Files: > src/sys/netinet: sctp_asconf.h > > Log Message: > Appease GCC7 in sctp_asconf.h > > Do not declare types inside function parameter list. > Add decklarations of types before these function

Re: CVS commit: src/sys/netinet

2019-02-15 Thread Robert Swindells
Rin Okuyama wrote: >Ping? Can I insert "break" here? Sorry, yes you are correct that it should be a break. Will commit it now. Robert Swindells

Re: CVS commit: src/sys/netinet

2019-02-15 Thread Rin Okuyama
On 2019/02/15 23:04, Robert Swindells wrote: Rin Okuyama wrote: Ping? Can I insert "break" here? Sorry, yes you are correct that it should be a break. Will commit it now. Robert Swindells Thanks! rin

Re: CVS commit: src/sys/netinet

2019-02-15 Thread Rin Okuyama
Ping? Can I insert "break" here? Thanks, rin On 2019/02/12 23:59, Rin Okuyama wrote: Hi, On 2019/02/12 23:40, Robert Swindells wrote: Module Name:    src Committed By:    rjs Date:    Tue Feb 12 14:40:38 UTC 2019 Modified Files: src/sys/netinet: sctp_input.c sctp_usrreq.c Log

Re: CVS commit: src/sys/netinet

2019-02-12 Thread Rin Okuyama
Hi, On 2019/02/12 23:40, Robert Swindells wrote: Module Name:src Committed By: rjs Date: Tue Feb 12 14:40:38 UTC 2019 Modified Files: src/sys/netinet: sctp_input.c sctp_usrreq.c Log Message: Add some fallthrough annotations. ... Index: src/sys/netinet/sctp_usrreq.c

Re: CVS commit: src/sys/netinet

2018-04-29 Thread Maxime Villard
Le 29/04/2018 à 16:24, Christos Zoulas a écrit : In article <20180429121242.6ca71f...@cvs.netbsd.org>, Maxime Villard wrote: -=-=-=-=-=- Module Name:src Committed By: maxv Date: Sun Apr 29 12:12:42 UTC 2018 Modified Files: src/sys/netinet:

Re: CVS commit: src/sys/netinet

2018-04-29 Thread Christos Zoulas
In article <20180429121242.6ca71f...@cvs.netbsd.org>, Maxime Villard wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: maxv >Date: Sun Apr 29 12:12:42 UTC 2018 > >Modified Files: > src/sys/netinet: tcp_var.h tcpip.h > >Log Message: >Move struct

Re: CVS commit: src/sys/netinet

2018-04-06 Thread Ryota Ozaki
On Fri, Apr 6, 2018 at 8:02 PM Roy Marples wrote: > On 06/04/2018 11:59, Ryota Ozaki wrote: > > On Fri, Apr 6, 2018 at 7:45 PM, Ryota Ozaki wrote: > >> On Fri, Apr 6, 2018 at 7:04 PM, Roy Marples wrote: > >>> On 06/04/2018 10:19, Ryota

Re: CVS commit: src/sys/netinet

2018-04-06 Thread Roy Marples
On 06/04/2018 11:59, Ryota Ozaki wrote: On Fri, Apr 6, 2018 at 7:45 PM, Ryota Ozaki wrote: On Fri, Apr 6, 2018 at 7:04 PM, Roy Marples wrote: On 06/04/2018 10:19, Ryota Ozaki wrote: Module Name:src Committed By: ozaki-r Date: Fri Apr

Re: CVS commit: src/sys/netinet

2018-04-06 Thread Ryota Ozaki
On Fri, Apr 6, 2018 at 7:45 PM, Ryota Ozaki wrote: > On Fri, Apr 6, 2018 at 7:04 PM, Roy Marples wrote: >> On 06/04/2018 10:19, Ryota Ozaki wrote: >>> >>> Module Name:src >>> Committed By: ozaki-r >>> Date: Fri Apr 6 09:19:16 UTC 2018 >>>

Re: CVS commit: src/sys/netinet

2018-04-06 Thread Ryota Ozaki
On Fri, Apr 6, 2018 at 7:04 PM, Roy Marples wrote: > On 06/04/2018 10:19, Ryota Ozaki wrote: >> >> Module Name:src >> Committed By: ozaki-r >> Date: Fri Apr 6 09:19:16 UTC 2018 >> >> Modified Files: >> src/sys/netinet: in.c >> >> Log Message: >>

Re: CVS commit: src/sys/netinet

2018-04-06 Thread Roy Marples
On 06/04/2018 10:19, Ryota Ozaki wrote: Module Name:src Committed By: ozaki-r Date: Fri Apr 6 09:19:16 UTC 2018 Modified Files: src/sys/netinet: in.c Log Message: Simplify; clear then set flags to ia4_flags (NFCI) This change is not right. You are clearing the flags

Re: CVS commit: src/sys/netinet

2018-03-31 Thread Robert Elz
Date:Sat, 31 Mar 2018 15:33:30 +0100 From:Alexander Nasonov Message-ID: <20180331143330.GB22190@neva> | After looking at email archives I see that many active developers | are "guilty" of committing 'hi dev@' messages. It used to be common.

Re: CVS commit: src/sys/netinet

2018-03-31 Thread Taylor R Campbell
> Date: Sat, 31 Mar 2018 14:53:36 +0100 > From: Alexander Nasonov > > Taylor R Campbell wrote: > > One connotation of `hi dev@' may be `dev@ is an idiot'; it can be > > offputting -- and it's not really necessary to call them out publicly. > > Sometimes dev@ has a rapport with

Re: CVS commit: src/sys/netinet

2018-03-31 Thread Alexander Nasonov
Robert Elz wrote: > I totally agree with this - and it is worse when included in commit logs > wherte it will remain, visible, and actually viewed, forever (unlike even > in a mailing list, which while archived forever, somewhere, usually > falls quickly out of view.) Searching for archived email

Re: CVS commit: src/sys/netinet

2018-03-31 Thread Alexander Nasonov
Taylor R Campbell wrote: > They mean different things. > > `hi dev@' means `FYI, dev@, you broke this, so I'm fixing it'. > > `ok dev@' means `dev@ reviewed and approved this change'. I'm well aware they mean different things. > One connotation of `hi dev@' may be `dev@ is an idiot'; it can be

Re: CVS commit: src/sys/netinet

2018-03-30 Thread Robert Elz
Date:Sat, 31 Mar 2018 03:07:29 + From:Taylor R Campbell Message-ID: <20180331030950.2325d60...@jupiter.mumble.net> | but a passive observer can't tell the difference between | one colleague joshing another and

Re: CVS commit: src/sys/netinet

2018-03-30 Thread Taylor R Campbell
> Date: Thu, 29 Mar 2018 23:53:42 +0100 > From: Alexander Nasonov > > m...@netbsd.org wrote: > > I seem to recall a discussion about wanting to avoid this type > > of commit message (hi dev-name), as it can be seen as excessively > > hostile. > > 'ok rmind@' would definitely be

Re: CVS commit: src/sys/netinet

2018-03-30 Thread Christos Zoulas
In article , Maxime Villard wrote: >Le 30/03/2018 à 00:34, m...@netbsd.org a écrit : >> On Thu, Mar 29, 2018 at 09:40:53PM +, Mindaugas Rasiukevicius wrote: >>> Module Name:src >>> Committed By: rmind >>>

Re: CVS commit: src/sys/netinet

2018-03-30 Thread Maxime Villard
Le 30/03/2018 à 00:34, m...@netbsd.org a écrit : On Thu, Mar 29, 2018 at 09:40:53PM +, Mindaugas Rasiukevicius wrote: Module Name:src Committed By: rmind Date: Thu Mar 29 21:40:53 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: tcp_urp_drop: fix

Re: CVS commit: src/sys/netinet

2018-03-29 Thread Maxime Villard
Le 29/03/2018 à 23:40, Mindaugas Rasiukevicius a écrit : Module Name:src Committed By: rmind Date: Thu Mar 29 21:40:53 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: tcp_urp_drop: fix a bug introduced in 1.390 rev (hi maxv@). To generate a diff of

Re: CVS commit: src/sys/netinet

2018-03-29 Thread Alexander Nasonov
m...@netbsd.org wrote: > I seem to recall a discussion about wanting to avoid this type > of commit message (hi dev-name), as it can be seen as excessively > hostile. 'ok rmind@' would definitely be better than 'hi maxv@'. Hostile? I don't think so. I personally quite like it. -- Alex

Re: CVS commit: src/sys/netinet

2018-03-29 Thread maya
On Thu, Mar 29, 2018 at 09:40:53PM +, Mindaugas Rasiukevicius wrote: > Module Name: src > Committed By: rmind > Date: Thu Mar 29 21:40:53 UTC 2018 > > Modified Files: > src/sys/netinet: tcp_input.c > > Log Message: > tcp_urp_drop: fix a bug introduced in 1.390 rev (hi maxv@).

Re: CVS commit: src/sys/netinet

2018-02-13 Thread Maxime Villard
I've reverted the change, I'll re-investigate this later. Maxime Le 13/02/2018 à 18:40, Frank Kardel a écrit : This must be revisited - IKE/racoon breaks with 1.240. racoon listens on port 500. packets for port 500 arrive at the interface (tcpdump sees them), but racoon NEVER receives any

Re: CVS commit: src/sys/netinet

2018-02-13 Thread Frank Kardel
This must be revisited - IKE/racoon breaks with 1.240. racoon listens on port 500. packets for port 500 arrive at the interface (tcpdump sees them), but racoon NEVER receives any packets for port 500 (debug/ktuss sees nothing). Frank On 02/10/18 09:17, Maxime Villard wrote: Module Name:

Fwd: Re: CVS commit: src/sys/netinet

2018-02-10 Thread Maxime Villard
Le 10/02/2018 à 23:49, David H. Gutteridge a écrit : On Mon, 05 Feb 2018, at 13:23:11 +, Maxime Villard wrote: Module Name:src Committed By: maxv Date: Mon Feb 5 13:23:11 UTC 2018 Modified Files: src/sys/netinet: ip_input.c Log Message: Disable ip_allowsrcrt and

Re: CVS commit: src/sys/netinet

2018-02-10 Thread David H. Gutteridge
On Mon, 05 Feb 2018, at 13:23:11 +, Maxime Villard wrote: >Module Name:src >Committed By: maxv >Date: Mon Feb 5 13:23:11 UTC 2018 > >Modified Files: >src/sys/netinet: ip_input.c > >Log Message: >Disable ip_allowsrcrt and ip_forwsrcrt. Enabling them by default was a

Re: CVS commit: src/sys/netinet

2018-01-10 Thread Ryota Ozaki
On Thu, Jan 11, 2018 at 3:51 AM, Christos Zoulas wrote: > Module Name:src > Committed By: christos > Date: Wed Jan 10 18:51:31 UTC 2018 > > Modified Files: > src/sys/netinet: ip_output.c > > Log Message: > from ozaki-r: use the proper ifp. > XXX:

Re: CVS commit: src/sys/netinet

2017-12-30 Thread Tom Ivar Helbekkmo
Ryota Ozaki writes: > Yeah, so I hoped a better fix. For now, I'm running with yours, and it seems to have solved the problem. If a more correct solution is in place, I'm looking forward to testing that on my susceptible system, but it'll take a few days before I can: I'm

Re: CVS commit: src/sys/netinet

2017-12-30 Thread Ryota Ozaki
On Fri, Dec 29, 2017 at 4:37 AM, Chuck Silvers wrote: > On Thu, Dec 28, 2017 at 05:34:27PM +0900, Ryota Ozaki wrote: >> On Thu, Dec 28, 2017 at 5:05 PM, Tom Ivar Helbekkmo >> wrote: >> > Ryota Ozaki writes: >> > >> >> I think the below

Re: CVS commit: src/sys/netinet

2017-12-28 Thread Chuck Silvers
On Thu, Dec 28, 2017 at 05:34:27PM +0900, Ryota Ozaki wrote: > On Thu, Dec 28, 2017 at 5:05 PM, Tom Ivar Helbekkmo > wrote: > > Ryota Ozaki writes: > > > >> I think the below patch fixes the above issue, but probably > >> there is a better solution. > >

Re: CVS commit: src/sys/netinet

2017-12-28 Thread Tom Ivar Helbekkmo
Ryota Ozaki writes: > Oh, my patch failed to keep SPL at IPL_VM because mutex_exit > tries to restore an SPL where mutex_enter is called. So I had to > put splvm before mutex_enter. Could you try the 2nd patch: > http://www.netbsd.org/~ozaki-r/fix-pool_catchup.diff Will

Re: CVS commit: src/sys/netinet

2017-12-28 Thread Ryota Ozaki
On Thu, Dec 28, 2017 at 5:05 PM, Tom Ivar Helbekkmo wrote: > Ryota Ozaki writes: > >> I think the below patch fixes the above issue, but probably >> there is a better solution. > > Looks like didn't -- it just changed it a little bit. Just like the >

Re: CVS commit: src/sys/netinet

2017-12-28 Thread Tom Ivar Helbekkmo
Ryota Ozaki writes: > I think the below patch fixes the above issue, but probably > there is a better solution. Looks like didn't -- it just changed it a little bit. Just like the last time, the hang happened while reading email over IMAP, which exercises disk and network

Re: CVS commit: src/sys/netinet

2017-12-27 Thread Ryota Ozaki
On Wed, Dec 27, 2017 at 7:11 PM, Tom Ivar Helbekkmo wrote: > Ryota Ozaki writes: > >> I think the below patch fixes the above issue, but probably >> there is a better solution. > > Thanks! I'm now running a fully up-to-date system (from just a half >

Re: CVS commit: src/sys/netinet

2017-12-27 Thread Tom Ivar Helbekkmo
Ryota Ozaki writes: > I think the below patch fixes the above issue, but probably > there is a better solution. Thanks! I'm now running a fully up-to-date system (from just a half hour ago), with this patch added. I'll push it hard over the next 24h, with a mix of disk and

Re: CVS commit: src/sys/netinet

2017-12-26 Thread Ryota Ozaki
On Tue, Dec 26, 2017 at 5:23 PM, Ryota Ozaki wrote: > On Tue, Dec 26, 2017 at 4:50 PM, Tom Ivar Helbekkmo > wrote: >> Ryota Ozaki writes: >> >>> One possible fix has been committed. >>> >>> Can you update the source code and try a

Re: CVS commit: src/sys/netinet

2017-12-26 Thread Ryota Ozaki
On Tue, Dec 26, 2017 at 4:50 PM, Tom Ivar Helbekkmo wrote: > Ryota Ozaki writes: > >> One possible fix has been committed. >> >> Can you update the source code and try a new kernel? > > Will do. Thanks. > > Meanwhile, before I got around to building

Re: CVS commit: src/sys/netinet

2017-12-25 Thread Tom Ivar Helbekkmo
Ryota Ozaki writes: > One possible fix has been committed. > > Can you update the source code and try a new kernel? Will do. Meanwhile, before I got around to building a kernel with debug options enabled, I had another hang. Got it into DDB successfully, but then I

Re: CVS commit: src/sys/netinet

2017-12-25 Thread Ryota Ozaki
One possible fix has been committed. Can you update the source code and try a new kernel? Thanks, ozaki-r On Tue, Dec 26, 2017 at 1:00 AM, Ryota Ozaki wrote: > On Mon, Dec 25, 2017 at 8:31 PM, Tom Ivar Helbekkmo > wrote: >> Martin Husemann

Re: CVS commit: src/sys/netinet

2017-12-25 Thread Ryota Ozaki
On Mon, Dec 25, 2017 at 8:31 PM, Tom Ivar Helbekkmo wrote: > Martin Husemann writes: > >> The sparc64 hang happened with: >> >> $NetBSD: ip_output.c,v 1.288 2017/12/22 11:22:37 ozaki-r Exp $ > > My amd64 that experienced hangs has: > >

Re: CVS commit: src/sys/netinet

2017-12-25 Thread Ryota Ozaki
On Mon, Dec 25, 2017 at 8:16 PM, Martin Husemann wrote: > On Mon, Dec 25, 2017 at 12:05:28PM +0900, Ryota Ozaki wrote: >> Anyway I annoy that we often cannot have suspect commits because of cvs >> (you know the kernel version doesn't work at all for the purpose). I wish >> we

Re: CVS commit: src/sys/netinet

2017-12-25 Thread Tom Ivar Helbekkmo
Martin Husemann writes: > The sparc64 hang happened with: > > $NetBSD: ip_output.c,v 1.288 2017/12/22 11:22:37 ozaki-r Exp $ My amd64 that experienced hangs has: $NetBSD: ip_output.c,v 1.287 2017/12/15 04:03:46 ozaki-r Exp $ ...and was last updated from CVS on

Re: CVS commit: src/sys/netinet

2017-12-25 Thread Martin Husemann
On Mon, Dec 25, 2017 at 12:05:28PM +0900, Ryota Ozaki wrote: > Anyway I annoy that we often cannot have suspect commits because of cvs > (you know the kernel version doesn't work at all for the purpose). I wish > we had revision IDs of svn or commit IDs of git to know them. The sparc64 hang

  1   2   >