CVS commit: src/sys/netinet

2022-09-20 Thread Ryota Ozaki
Module Name:src Committed By: ozaki-r Date: Tue Sep 20 10:12:18 UTC 2022 Modified Files: src/sys/netinet: tcp_syncache.c tcp_syncache.h Log Message: syncache: make some functions static To generate a diff of this commit: cvs rdiff -u -r1.1 -r1.2

CVS commit: src/sys/netinet

2022-09-20 Thread Ryota Ozaki
Module Name:src Committed By: ozaki-r Date: Tue Sep 20 10:12:18 UTC 2022 Modified Files: src/sys/netinet: tcp_syncache.c tcp_syncache.h Log Message: syncache: make some functions static To generate a diff of this commit: cvs rdiff -u -r1.1 -r1.2

CVS commit: src/sys/netinet

2022-06-27 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Jun 28 01:44:19 UTC 2022 Modified Files: src/sys/netinet: tcp_usrreq.c Log Message: tcp(4): Bail early on sendoob if not connected. XXX Not sure if testing tp->t_template is the right way to discern this -- I just reached

CVS commit: src/sys/netinet

2022-06-27 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Jun 28 01:44:19 UTC 2022 Modified Files: src/sys/netinet: tcp_usrreq.c Log Message: tcp(4): Bail early on sendoob if not connected. XXX Not sure if testing tp->t_template is the right way to discern this -- I just reached

CVS commit: src/sys/netinet

2022-06-26 Thread Kengo NAKAHARA
Module Name:src Committed By: knakahara Date: Mon Jun 27 01:29:51 UTC 2022 Modified Files: src/sys/netinet: tcp_subr.c Log Message: Remove confusable comment. The comment was added in tcp_subr.c:r1.124 (2002/03/15). tcp_drain() is called from softint context only, now.

CVS commit: src/sys/netinet

2022-06-26 Thread Kengo NAKAHARA
Module Name:src Committed By: knakahara Date: Mon Jun 27 01:29:51 UTC 2022 Modified Files: src/sys/netinet: tcp_subr.c Log Message: Remove confusable comment. The comment was added in tcp_subr.c:r1.124 (2002/03/15). tcp_drain() is called from softint context only, now.

CVS commit: src/sys/netinet

2022-06-13 Thread Kengo NAKAHARA
Module Name:src Committed By: knakahara Date: Mon Jun 13 09:23:23 UTC 2022 Modified Files: src/sys/netinet: raw_ip.c Log Message: Refactor like in_pcb.c:r1.187 and in6_pcb.c:r1.168. Use TAILQ_FOREACH instead of TAILQ_FOREACH_SAFE about inpt_queue. rip_pcbnotify() doesn't

CVS commit: src/sys/netinet

2022-06-13 Thread Kengo NAKAHARA
Module Name:src Committed By: knakahara Date: Mon Jun 13 09:23:23 UTC 2022 Modified Files: src/sys/netinet: raw_ip.c Log Message: Refactor like in_pcb.c:r1.187 and in6_pcb.c:r1.168. Use TAILQ_FOREACH instead of TAILQ_FOREACH_SAFE about inpt_queue. rip_pcbnotify() doesn't

CVS commit: src/sys/netinet

2022-06-10 Thread Kengo NAKAHARA
Module Name:src Committed By: knakahara Date: Fri Jun 10 09:54:54 UTC 2022 Modified Files: src/sys/netinet: in_pcb.h Log Message: "inp_hash" is not used now. To generate a diff of this commit: cvs rdiff -u -r1.69 -r1.70 src/sys/netinet/in_pcb.h Please note that diffs

CVS commit: src/sys/netinet

2022-06-10 Thread Kengo NAKAHARA
Module Name:src Committed By: knakahara Date: Fri Jun 10 09:54:54 UTC 2022 Modified Files: src/sys/netinet: in_pcb.h Log Message: "inp_hash" is not used now. To generate a diff of this commit: cvs rdiff -u -r1.69 -r1.70 src/sys/netinet/in_pcb.h Please note that diffs

CVS commit: src/sys/netinet

2022-06-10 Thread Kengo NAKAHARA
Module Name:src Committed By: knakahara Date: Fri Jun 10 09:51:11 UTC 2022 Modified Files: src/sys/netinet: in_pcb.c Log Message: Use LIST_FOREACH macro. To generate a diff of this commit: cvs rdiff -u -r1.187 -r1.188 src/sys/netinet/in_pcb.c Please note that diffs are

CVS commit: src/sys/netinet

2022-06-10 Thread Kengo NAKAHARA
Module Name:src Committed By: knakahara Date: Fri Jun 10 09:51:11 UTC 2022 Modified Files: src/sys/netinet: in_pcb.c Log Message: Use LIST_FOREACH macro. To generate a diff of this commit: cvs rdiff -u -r1.187 -r1.188 src/sys/netinet/in_pcb.c Please note that diffs are

CVS commit: src/sys/netinet

2022-05-18 Thread Andrius Varanavicius
Module Name:src Committed By: andvar Date: Wed May 18 13:37:52 UTC 2022 Modified Files: src/sys/netinet: sctp_constants.h Log Message: s/yeild/yield/ To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 src/sys/netinet/sctp_constants.h Please note that diffs are

CVS commit: src/sys/netinet

2022-05-18 Thread Andrius Varanavicius
Module Name:src Committed By: andvar Date: Wed May 18 13:37:52 UTC 2022 Modified Files: src/sys/netinet: sctp_constants.h Log Message: s/yeild/yield/ To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 src/sys/netinet/sctp_constants.h Please note that diffs are

CVS commit: src/sys/netinet

2022-03-15 Thread Andrius Varanavicius
Module Name:src Committed By: andvar Date: Tue Mar 15 21:40:00 UTC 2022 Modified Files: src/sys/netinet: ip_mroute.c Log Message: s/heaader/header/ To generate a diff of this commit: cvs rdiff -u -r1.164 -r1.165 src/sys/netinet/ip_mroute.c Please note that diffs are

CVS commit: src/sys/netinet

2022-03-15 Thread Andrius Varanavicius
Module Name:src Committed By: andvar Date: Tue Mar 15 21:40:00 UTC 2022 Modified Files: src/sys/netinet: ip_mroute.c Log Message: s/heaader/header/ To generate a diff of this commit: cvs rdiff -u -r1.164 -r1.165 src/sys/netinet/ip_mroute.c Please note that diffs are

CVS commit: src/sys/netinet

2022-01-01 Thread Andrius Varanavicius
Module Name:src Committed By: andvar Date: Sat Jan 1 13:18:43 UTC 2022 Modified Files: src/sys/netinet: accept_filter.h Log Message: s/creting/creating/ To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/sys/netinet/accept_filter.h Please note that diffs

CVS commit: src/sys/netinet

2022-01-01 Thread Andrius Varanavicius
Module Name:src Committed By: andvar Date: Sat Jan 1 13:18:43 UTC 2022 Modified Files: src/sys/netinet: accept_filter.h Log Message: s/creting/creating/ To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/sys/netinet/accept_filter.h Please note that diffs

CVS commit: src/sys/netinet

2021-12-30 Thread Andrius Varanavicius
Module Name:src Committed By: andvar Date: Thu Dec 30 23:03:44 UTC 2021 Modified Files: src/sys/netinet: tcp_output.c Log Message: s/bandwith/bandwidth/ To generate a diff of this commit: cvs rdiff -u -r1.213 -r1.214 src/sys/netinet/tcp_output.c Please note that diffs

CVS commit: src/sys/netinet

2021-12-30 Thread Andrius Varanavicius
Module Name:src Committed By: andvar Date: Thu Dec 30 23:03:44 UTC 2021 Modified Files: src/sys/netinet: tcp_output.c Log Message: s/bandwith/bandwidth/ To generate a diff of this commit: cvs rdiff -u -r1.213 -r1.214 src/sys/netinet/tcp_output.c Please note that diffs

CVS commit: src/sys/netinet

2021-12-04 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Sun Dec 5 03:08:20 UTC 2021 Modified Files: src/sys/netinet: sctp_output.c sctputil.c Log Message: s/measurment/measurement/ in comment. To generate a diff of this commit: cvs rdiff -u -r1.26 -r1.27

CVS commit: src/sys/netinet

2021-12-04 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Sun Dec 5 03:08:20 UTC 2021 Modified Files: src/sys/netinet: sctp_output.c sctputil.c Log Message: s/measurment/measurement/ in comment. To generate a diff of this commit: cvs rdiff -u -r1.26 -r1.27

CVS commit: src/sys/netinet

2021-10-19 Thread Roy Marples
Module Name:src Committed By: roy Date: Tue Oct 19 20:01:09 UTC 2021 Modified Files: src/sys/netinet: in_pcb.c Log Message: netinet: Allow binding the unspecified address when no addresses exist You should always be able to bind to the unspecified address even if no

CVS commit: src/sys/netinet

2021-10-19 Thread Roy Marples
Module Name:src Committed By: roy Date: Tue Oct 19 20:01:09 UTC 2021 Modified Files: src/sys/netinet: in_pcb.c Log Message: netinet: Allow binding the unspecified address when no addresses exist You should always be able to bind to the unspecified address even if no

CVS commit: src/sys/netinet

2021-09-21 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Tue Sep 21 15:05:41 UTC 2021 Modified Files: src/sys/netinet: in.c Log Message: don't opencode kauth_cred_get() To generate a diff of this commit: cvs rdiff -u -r1.241 -r1.242 src/sys/netinet/in.c Please note that diffs are

CVS commit: src/sys/netinet

2021-09-21 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Tue Sep 21 15:05:41 UTC 2021 Modified Files: src/sys/netinet: in.c Log Message: don't opencode kauth_cred_get() To generate a diff of this commit: cvs rdiff -u -r1.241 -r1.242 src/sys/netinet/in.c Please note that diffs are

Re: CVS commit: src/sys/netinet

2021-02-16 Thread Martin Husemann
On Tue, Feb 16, 2021 at 09:29:15AM +, Roy Marples wrote: > In my testing on aarch64 and octeon (both of which I think are strict > alignment) neither need pullups nor copyups as the mbuf already has enough > and arphrd is aligned correctly already. Ah, we asserted too much alignment - indeed,

Re: CVS commit: src/sys/netinet

2021-02-16 Thread Roy Marples
On 16/02/2021 09:20, Martin Husemann wrote: On Tue, Feb 16, 2021 at 08:26:40AM +, Roy Marples wrote: Is that because ARP_HDR_ALIGNMENT is forcing 4 byte alignment? The KASSERT a few lines below triggerd, we need to be consistent. For the purposes of using just the header we define I'm

Re: CVS commit: src/sys/netinet

2021-02-16 Thread Martin Husemann
On Tue, Feb 16, 2021 at 08:26:40AM +, Roy Marples wrote: > Is that because ARP_HDR_ALIGNMENT is forcing 4 byte alignment? The KASSERT a few lines below triggerd, we need to be consistent. > For the purposes of using just the header we define I'm pretty sure we can > use 2 byte alignment and

Re: CVS commit: src/sys/netinet

2021-02-16 Thread Roy Marples
On 16/02/2021 05:44, Martin Husemann wrote: Module Name:src Committed By: martin Date: Tue Feb 16 05:44:14 UTC 2021 Modified Files: src/sys/netinet: if_arp.c Log Message: Undo previous backout: alignment is needed here. The reason for the previous backout was a

Re: CVS commit: src/sys/netinet

2020-12-04 Thread Jason Thorpe
> On Dec 4, 2020, at 8:57 AM, Christos Zoulas wrote: > > In article <20201204004439.90c25f...@cvs.netbsd.org>, > Jason R Thorpe wrote: >> -=-=-=-=-=- >> >> Module Name: src >> Committed By:thorpej >> Date:Fri Dec 4 00:44:39 UTC 2020 >> >> Modified Files: >>

Re: CVS commit: src/sys/netinet

2020-12-04 Thread Christos Zoulas
In article <20201204004439.90c25f...@cvs.netbsd.org>, Jason R Thorpe wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: thorpej >Date: Fri Dec 4 00:44:39 UTC 2020 > >Modified Files: > src/sys/netinet: files.ipfilter > >Log Message: >Build ip_sync.c with -Wno-error to avoid

CVS commit: src/sys/netinet

2019-11-17 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sun Nov 17 08:21:25 UTC 2019 Modified Files: src/sys/netinet: tcp_output.c Log Message: Don't allow zero sized segments that will panic the stack. Reported-by: syzbot+5542516fa4afe7a10...@syzkaller.appspotmail.com To generate

CVS commit: src/sys/netinet

2019-11-17 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sun Nov 17 08:21:25 UTC 2019 Modified Files: src/sys/netinet: tcp_output.c Log Message: Don't allow zero sized segments that will panic the stack. Reported-by: syzbot+5542516fa4afe7a10...@syzkaller.appspotmail.com To generate

CVS commit: src/sys/netinet

2019-11-16 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Nov 16 10:15:10 UTC 2019 Modified Files: src/sys/netinet: tcp_input.c Log Message: Call rtcache_unref() only when the checks succeed, instead of relying on another NULL check in rtcache_unref(). Because, in order to resolve

CVS commit: src/sys/netinet

2019-11-16 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Nov 16 10:15:10 UTC 2019 Modified Files: src/sys/netinet: tcp_input.c Log Message: Call rtcache_unref() only when the checks succeed, instead of relying on another NULL check in rtcache_unref(). Because, in order to resolve

CVS commit: src/sys/netinet

2019-11-01 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Fri Nov 1 13:54:59 UTC 2019 Modified Files: src/sys/netinet: tcp.h Log Message: Add comments to the tcp flags. To generate a diff of this commit: cvs rdiff -u -r1.33 -r1.34 src/sys/netinet/tcp.h Please note that diffs are

CVS commit: src/sys/netinet

2019-11-01 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Fri Nov 1 13:54:59 UTC 2019 Modified Files: src/sys/netinet: tcp.h Log Message: Add comments to the tcp flags. To generate a diff of this commit: cvs rdiff -u -r1.33 -r1.34 src/sys/netinet/tcp.h Please note that diffs are

CVS commit: src/sys/netinet

2019-10-11 Thread Roy Marples
Module Name:src Committed By: roy Date: Fri Oct 11 13:32:46 UTC 2019 Modified Files: src/sys/netinet: if_arp.c Log Message: ARP: Don't defend ARP probes. We should let the nature of ARP takes it's course here when our address is neither tentative nor duplicated. This

CVS commit: src/sys/netinet

2019-10-11 Thread Roy Marples
Module Name:src Committed By: roy Date: Fri Oct 11 13:32:46 UTC 2019 Modified Files: src/sys/netinet: if_arp.c Log Message: ARP: Don't defend ARP probes. We should let the nature of ARP takes it's course here when our address is neither tentative nor duplicated. This

CVS commit: src/sys/netinet

2019-10-08 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Wed Oct 9 05:29:18 UTC 2019 Modified Files: src/sys/netinet: tcp_congctl.c Log Message: All of snd_wnd, snd_cwnd and snd_ssthresh in stuct tcpcb are u_long, so use u_long and ulmin() instead of u_int and uimin(). Found by lgtm

CVS commit: src/sys/netinet

2019-10-08 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Wed Oct 9 05:29:18 UTC 2019 Modified Files: src/sys/netinet: tcp_congctl.c Log Message: All of snd_wnd, snd_cwnd and snd_ssthresh in stuct tcpcb are u_long, so use u_long and ulmin() instead of u_int and uimin(). Found by lgtm

CVS commit: src/sys/netinet

2019-09-25 Thread John Nemeth
Module Name:src Committed By: jnemeth Date: Wed Sep 25 19:06:30 UTC 2019 Modified Files: src/sys/netinet: tcp_input.c Log Message: PR/54572 - Edgar Fu� -- error in comment To generate a diff of this commit: cvs rdiff -u -r1.415 -r1.416 src/sys/netinet/tcp_input.c

CVS commit: src/sys/netinet

2019-09-25 Thread John Nemeth
Module Name:src Committed By: jnemeth Date: Wed Sep 25 19:06:30 UTC 2019 Modified Files: src/sys/netinet: tcp_input.c Log Message: PR/54572 - Edgar Fu� -- error in comment To generate a diff of this commit: cvs rdiff -u -r1.415 -r1.416 src/sys/netinet/tcp_input.c

CVS commit: src/sys/netinet

2019-09-18 Thread Ryota Ozaki
Module Name:src Committed By: ozaki-r Date: Thu Sep 19 04:09:34 UTC 2019 Modified Files: src/sys/netinet: wqinput.c Log Message: wqinput: avoid having struct wqinput_worklist directly in a percpu storage percpu(9) has a certain memory storage for each CPU and provides it

CVS commit: src/sys/netinet

2019-09-18 Thread Ryota Ozaki
Module Name:src Committed By: ozaki-r Date: Thu Sep 19 04:09:34 UTC 2019 Modified Files: src/sys/netinet: wqinput.c Log Message: wqinput: avoid having struct wqinput_worklist directly in a percpu storage percpu(9) has a certain memory storage for each CPU and provides it

CVS commit: src/sys/netinet

2019-09-01 Thread Roy Marples
Module Name:src Committed By: roy Date: Sun Sep 1 22:09:02 UTC 2019 Modified Files: src/sys/netinet: if_arp.c Log Message: inet: Send RTM_MISS when we fail to resolve an address. Takes the same approach as when adding a new address - we no longer announce the new lladdr

CVS commit: src/sys/netinet

2019-09-01 Thread Roy Marples
Module Name:src Committed By: roy Date: Sun Sep 1 22:09:02 UTC 2019 Modified Files: src/sys/netinet: if_arp.c Log Message: inet: Send RTM_MISS when we fail to resolve an address. Takes the same approach as when adding a new address - we no longer announce the new lladdr

CVS commit: src/sys/netinet

2019-08-30 Thread Roy Marples
Module Name:src Committed By: roy Date: Fri Aug 30 18:52:00 UTC 2019 Modified Files: src/sys/netinet: if_arp.c Log Message: ARP: change default sysctl entry log_movements to 0 IP address sharing is a thing and shouldn't cause needless diagnostics by default. To

CVS commit: src/sys/netinet

2019-08-30 Thread Roy Marples
Module Name:src Committed By: roy Date: Fri Aug 30 18:52:00 UTC 2019 Modified Files: src/sys/netinet: if_arp.c Log Message: ARP: change default sysctl entry log_movements to 0 IP address sharing is a thing and shouldn't cause needless diagnostics by default. To

CVS commit: src/sys/netinet

2019-08-30 Thread Roy Marples
Module Name:src Committed By: roy Date: Fri Aug 30 18:48:34 UTC 2019 Modified Files: src/sys/netinet: if_arp.c Log Message: ARP: remove unused sysctl entry log_unknown_network To generate a diff of this commit: cvs rdiff -u -r1.284 -r1.285 src/sys/netinet/if_arp.c

CVS commit: src/sys/netinet

2019-08-30 Thread Roy Marples
Module Name:src Committed By: roy Date: Fri Aug 30 18:48:34 UTC 2019 Modified Files: src/sys/netinet: if_arp.c Log Message: ARP: remove unused sysctl entry log_unknown_network To generate a diff of this commit: cvs rdiff -u -r1.284 -r1.285 src/sys/netinet/if_arp.c

CVS commit: src/sys/netinet

2019-08-13 Thread Robert Swindells
Module Name:src Committed By: rjs Date: Tue Aug 13 19:55:40 UTC 2019 Modified Files: src/sys/netinet: sctp_crc32.c sctp_crc32.h sctputil.c Log Message: Remove unused checksum code. To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/sys/netinet/sctp_crc32.c

CVS commit: src/sys/netinet

2019-08-13 Thread Robert Swindells
Module Name:src Committed By: rjs Date: Tue Aug 13 19:55:40 UTC 2019 Modified Files: src/sys/netinet: sctp_crc32.c sctp_crc32.h sctputil.c Log Message: Remove unused checksum code. To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/sys/netinet/sctp_crc32.c

CVS commit: src/sys/netinet

2019-08-06 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Aug 6 15:48:19 UTC 2019 Modified Files: src/sys/netinet: tcp_input.c tcp_subr.c tcp_timer.h tcp_usrreq.c Log Message: Clamp tcp timer quantities to reasonable ranges. Reported-by:

CVS commit: src/sys/netinet

2019-08-06 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Aug 6 15:48:19 UTC 2019 Modified Files: src/sys/netinet: tcp_input.c tcp_subr.c tcp_timer.h tcp_usrreq.c Log Message: Clamp tcp timer quantities to reasonable ranges. Reported-by:

CVS commit: src/sys/netinet

2019-06-08 Thread Robert Swindells
Module Name:src Committed By: rjs Date: Sat Jun 8 23:23:34 UTC 2019 Modified Files: src/sys/netinet: sctp_asconf.h sctp_pcb.h Log Message: Don't need 'extern' for function prototypes. To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3

CVS commit: src/sys/netinet

2019-06-08 Thread Robert Swindells
Module Name:src Committed By: rjs Date: Sat Jun 8 23:23:34 UTC 2019 Modified Files: src/sys/netinet: sctp_asconf.h sctp_pcb.h Log Message: Don't need 'extern' for function prototypes. To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3

CVS commit: src/sys/netinet

2019-06-04 Thread Kengo NAKAHARA
Module Name:src Committed By: knakahara Date: Wed Jun 5 01:31:05 UTC 2019 Modified Files: src/sys/netinet: ip_output.c Log Message: The packets which will be esp-fragmented should not be applied pfil. Pointed out by ohishi@IIJ, thanks. To generate a diff of this

CVS commit: src/sys/netinet

2019-06-04 Thread Kengo NAKAHARA
Module Name:src Committed By: knakahara Date: Wed Jun 5 01:31:05 UTC 2019 Modified Files: src/sys/netinet: ip_output.c Log Message: The packets which will be esp-fragmented should not be applied pfil. Pointed out by ohishi@IIJ, thanks. To generate a diff of this

CVS commit: src/sys/netinet

2019-06-04 Thread Kengo NAKAHARA
Module Name:src Committed By: knakahara Date: Wed Jun 5 01:27:20 UTC 2019 Modified Files: src/sys/netinet: ip_output.c Log Message: Fix rtcache cannot be released once an esp-fragmented packet is sent. Pointed out by ohishi@IIJ, thanks. To generate a diff of this

CVS commit: src/sys/netinet

2019-06-04 Thread Kengo NAKAHARA
Module Name:src Committed By: knakahara Date: Wed Jun 5 01:27:20 UTC 2019 Modified Files: src/sys/netinet: ip_output.c Log Message: Fix rtcache cannot be released once an esp-fragmented packet is sent. Pointed out by ohishi@IIJ, thanks. To generate a diff of this

CVS commit: src/sys/netinet

2019-06-01 Thread Joerg Sonnenberger
Module Name:src Committed By: joerg Date: Sat Jun 1 19:13:41 UTC 2019 Modified Files: src/sys/netinet: ip_carp.c Log Message: Define carp6_cksum only when it is used, that is under INET6 To generate a diff of this commit: cvs rdiff -u -r1.102 -r1.103

CVS commit: src/sys/netinet

2019-06-01 Thread Joerg Sonnenberger
Module Name:src Committed By: joerg Date: Sat Jun 1 19:13:41 UTC 2019 Modified Files: src/sys/netinet: ip_carp.c Log Message: Define carp6_cksum only when it is used, that is under INET6 To generate a diff of this commit: cvs rdiff -u -r1.102 -r1.103

CVS commit: src/sys/netinet

2019-06-01 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat Jun 1 15:18:42 UTC 2019 Modified Files: src/sys/netinet: tcp_input.c Log Message: Replace potentially misaligned pointer dereference + htonl() with be32dec() Reported by kUBSan. To generate a diff of this commit: cvs rdiff

CVS commit: src/sys/netinet

2019-06-01 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat Jun 1 15:18:42 UTC 2019 Modified Files: src/sys/netinet: tcp_input.c Log Message: Replace potentially misaligned pointer dereference + htonl() with be32dec() Reported by kUBSan. To generate a diff of this commit: cvs rdiff

CVS commit: src/sys/netinet

2019-05-14 Thread Kengo NAKAHARA
Module Name:src Committed By: knakahara Date: Wed May 15 03:33:41 UTC 2019 Modified Files: src/sys/netinet: ip_encap.c Log Message: Fix build failure when INET6 is disabled. Pointed out by ozaki-r@n.o, thanks. To generate a diff of this commit: cvs rdiff -u -r1.70

CVS commit: src/sys/netinet

2019-05-14 Thread Kengo NAKAHARA
Module Name:src Committed By: knakahara Date: Wed May 15 03:33:41 UTC 2019 Modified Files: src/sys/netinet: ip_encap.c Log Message: Fix build failure when INET6 is disabled. Pointed out by ozaki-r@n.o, thanks. To generate a diff of this commit: cvs rdiff -u -r1.70

Re: CVS commit: src/sys/netinet

2019-02-25 Thread Martin Husemann
On Mon, Feb 25, 2019 at 11:35:35AM +0100, Kamil Rytarowski wrote: > This is right, SCTP build wasn't tested and I got it enabled locally. > I propose to build ALL by default as we now depend on external services > to have functional 24/7 build with sanitizers (syzkaller). Yes, it needs to be part

Re: CVS commit: src/sys/netinet

2019-02-25 Thread Kamil Rytarowski
On 25.02.2019 11:23, Martin Husemann wrote: > On Mon, Feb 25, 2019 at 01:19:02PM +0300, Valery Ushakov wrote: >> On Mon, Feb 25, 2019 at 06:23:33 +0100, Martin Husemann wrote: >> >>> On Sun, Feb 24, 2019 at 09:43:52PM +0100, Kamil Rytarowski wrote: I consider that this is just GCC specific

Re: CVS commit: src/sys/netinet

2019-02-25 Thread Martin Husemann
On Mon, Feb 25, 2019 at 01:19:02PM +0300, Valery Ushakov wrote: > On Mon, Feb 25, 2019 at 06:23:33 +0100, Martin Husemann wrote: > > > On Sun, Feb 24, 2019 at 09:43:52PM +0100, Kamil Rytarowski wrote: > > > I consider that this is just GCC specific behavior to make some warnings > > > fatal

Re: CVS commit: src/sys/netinet

2019-02-25 Thread Valery Ushakov
On Mon, Feb 25, 2019 at 06:23:33 +0100, Martin Husemann wrote: > On Sun, Feb 24, 2019 at 09:43:52PM +0100, Kamil Rytarowski wrote: > > I consider that this is just GCC specific behavior to make some warnings > > fatal depending on driver configuration. This is typical behavior of GCC > > that we

re: CVS commit: src/sys/netinet

2019-02-24 Thread matthew green
> If you think that this is better and it works, please go for it. please, no. don't duplicate prototypes in a way that changes won't be detected. ie, if the real sctp code changes, today the compat caller will fail to build until updated. with this change, it will build and be entirely wrong.

Re: CVS commit: src/sys/netinet

2019-02-24 Thread Kamil Rytarowski
On 24.02.2019 23:55, Robert Swindells wrote: > > Kamil Rytarowski wrote: >> Module Name:src >> Committed By: kamil >> Date: Sun Feb 24 17:01:52 UTC 2019 >> >> Modified Files: >>src/sys/netinet: sctp_asconf.h >> >> Log Message: >> Appease GCC7 in sctp_asconf.h >> >> Do not

Re: CVS commit: src/sys/netinet

2019-02-24 Thread Robert Swindells
Kamil Rytarowski wrote: >Module Name:src >Committed By: kamil >Date: Sun Feb 24 17:01:52 UTC 2019 > >Modified Files: >src/sys/netinet: sctp_asconf.h > >Log Message: >Appease GCC7 in sctp_asconf.h > >Do not declare types inside function parameter list. >Add decklarations

Re: CVS commit: src/sys/netinet

2019-02-24 Thread Martin Husemann
On Sun, Feb 24, 2019 at 09:43:52PM +0100, Kamil Rytarowski wrote: > I consider that this is just GCC specific behavior to make some warnings > fatal depending on driver configuration. This is typical behavior of GCC > that we keep observing all over again. No, this is very different to optimizer

Re: CVS commit: src/sys/netinet

2019-02-24 Thread Kamil Rytarowski
On 24.02.2019 21:38, Martin Husemann wrote: > On Sun, Feb 24, 2019 at 09:36:55PM +0100, Kamil Rytarowski wrote: >> My only specific change was NetBSD/i386 kernel=GENERIC with kUBSan and >> KCOV enabled. > > This does not answer the question. What does enabling kUBSan/KCOV break > to make this

Re: CVS commit: src/sys/netinet

2019-02-24 Thread Kamil Rytarowski
On 24.02.2019 21:43, Kamil Rytarowski wrote: > On 24.02.2019 21:38, Martin Husemann wrote: >> On Sun, Feb 24, 2019 at 09:36:55PM +0100, Kamil Rytarowski wrote: >>> My only specific change was NetBSD/i386 kernel=GENERIC with kUBSan and >>> KCOV enabled. >> >> This does not answer the question. What

Re: CVS commit: src/sys/netinet

2019-02-24 Thread Martin Husemann
On Sun, Feb 24, 2019 at 09:36:55PM +0100, Kamil Rytarowski wrote: > My only specific change was NetBSD/i386 kernel=GENERIC with kUBSan and > KCOV enabled. This does not answer the question. What does enabling kUBSan/KCOV break to make this error show up in your compilation, but not in our default

Re: CVS commit: src/sys/netinet

2019-02-24 Thread Kamil Rytarowski
On 24.02.2019 20:39, Martin Husemann wrote: > On Sun, Feb 24, 2019 at 07:20:10PM +0100, Kamil Rytarowski wrote: >> On 24.02.2019 19:15, David Holland wrote: >>> On Sun, Feb 24, 2019 at 05:01:52PM +, Kamil Rytarowski wrote: >>> > Modified Files: >>> > src/sys/netinet: sctp_asconf.h >>> >

Re: CVS commit: src/sys/netinet

2019-02-24 Thread Martin Husemann
On Sun, Feb 24, 2019 at 07:20:10PM +0100, Kamil Rytarowski wrote: > On 24.02.2019 19:15, David Holland wrote: > > On Sun, Feb 24, 2019 at 05:01:52PM +, Kamil Rytarowski wrote: > > > Modified Files: > > > src/sys/netinet: sctp_asconf.h > > > > > > Log Message: > > > Appease GCC7 in

Re: CVS commit: src/sys/netinet

2019-02-24 Thread Kamil Rytarowski
On 24.02.2019 19:15, David Holland wrote: > On Sun, Feb 24, 2019 at 05:01:52PM +, Kamil Rytarowski wrote: > > Modified Files: > >src/sys/netinet: sctp_asconf.h > > > > Log Message: > > Appease GCC7 in sctp_asconf.h > > > > Do not declare types inside function parameter list. > >

Re: CVS commit: src/sys/netinet

2019-02-24 Thread David Holland
On Sun, Feb 24, 2019 at 05:01:52PM +, Kamil Rytarowski wrote: > Modified Files: > src/sys/netinet: sctp_asconf.h > > Log Message: > Appease GCC7 in sctp_asconf.h > > Do not declare types inside function parameter list. > Add decklarations of types before these function

Re: CVS commit: src/sys/netinet

2019-02-15 Thread Robert Swindells
Rin Okuyama wrote: >Ping? Can I insert "break" here? Sorry, yes you are correct that it should be a break. Will commit it now. Robert Swindells

Re: CVS commit: src/sys/netinet

2019-02-15 Thread Rin Okuyama
On 2019/02/15 23:04, Robert Swindells wrote: Rin Okuyama wrote: Ping? Can I insert "break" here? Sorry, yes you are correct that it should be a break. Will commit it now. Robert Swindells Thanks! rin

Re: CVS commit: src/sys/netinet

2019-02-15 Thread Rin Okuyama
Ping? Can I insert "break" here? Thanks, rin On 2019/02/12 23:59, Rin Okuyama wrote: Hi, On 2019/02/12 23:40, Robert Swindells wrote: Module Name:    src Committed By:    rjs Date:    Tue Feb 12 14:40:38 UTC 2019 Modified Files: src/sys/netinet: sctp_input.c sctp_usrreq.c Log

Re: CVS commit: src/sys/netinet

2019-02-12 Thread Rin Okuyama
Hi, On 2019/02/12 23:40, Robert Swindells wrote: Module Name:src Committed By: rjs Date: Tue Feb 12 14:40:38 UTC 2019 Modified Files: src/sys/netinet: sctp_input.c sctp_usrreq.c Log Message: Add some fallthrough annotations. ... Index: src/sys/netinet/sctp_usrreq.c

Re: CVS commit: src/sys/netinet

2018-04-29 Thread Maxime Villard
Le 29/04/2018 à 16:24, Christos Zoulas a écrit : In article <20180429121242.6ca71f...@cvs.netbsd.org>, Maxime Villard wrote: -=-=-=-=-=- Module Name:src Committed By: maxv Date: Sun Apr 29 12:12:42 UTC 2018 Modified Files: src/sys/netinet:

Re: CVS commit: src/sys/netinet

2018-04-29 Thread Christos Zoulas
In article <20180429121242.6ca71f...@cvs.netbsd.org>, Maxime Villard wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: maxv >Date: Sun Apr 29 12:12:42 UTC 2018 > >Modified Files: > src/sys/netinet: tcp_var.h tcpip.h > >Log Message: >Move struct

Re: CVS commit: src/sys/netinet

2018-04-06 Thread Ryota Ozaki
On Fri, Apr 6, 2018 at 8:02 PM Roy Marples wrote: > On 06/04/2018 11:59, Ryota Ozaki wrote: > > On Fri, Apr 6, 2018 at 7:45 PM, Ryota Ozaki wrote: > >> On Fri, Apr 6, 2018 at 7:04 PM, Roy Marples wrote: > >>> On 06/04/2018 10:19, Ryota

Re: CVS commit: src/sys/netinet

2018-04-06 Thread Roy Marples
On 06/04/2018 11:59, Ryota Ozaki wrote: On Fri, Apr 6, 2018 at 7:45 PM, Ryota Ozaki wrote: On Fri, Apr 6, 2018 at 7:04 PM, Roy Marples wrote: On 06/04/2018 10:19, Ryota Ozaki wrote: Module Name:src Committed By: ozaki-r Date: Fri Apr

Re: CVS commit: src/sys/netinet

2018-04-06 Thread Ryota Ozaki
On Fri, Apr 6, 2018 at 7:45 PM, Ryota Ozaki wrote: > On Fri, Apr 6, 2018 at 7:04 PM, Roy Marples wrote: >> On 06/04/2018 10:19, Ryota Ozaki wrote: >>> >>> Module Name:src >>> Committed By: ozaki-r >>> Date: Fri Apr 6 09:19:16 UTC 2018 >>>

Re: CVS commit: src/sys/netinet

2018-04-06 Thread Ryota Ozaki
On Fri, Apr 6, 2018 at 7:04 PM, Roy Marples wrote: > On 06/04/2018 10:19, Ryota Ozaki wrote: >> >> Module Name:src >> Committed By: ozaki-r >> Date: Fri Apr 6 09:19:16 UTC 2018 >> >> Modified Files: >> src/sys/netinet: in.c >> >> Log Message: >>

Re: CVS commit: src/sys/netinet

2018-04-06 Thread Roy Marples
On 06/04/2018 10:19, Ryota Ozaki wrote: Module Name:src Committed By: ozaki-r Date: Fri Apr 6 09:19:16 UTC 2018 Modified Files: src/sys/netinet: in.c Log Message: Simplify; clear then set flags to ia4_flags (NFCI) This change is not right. You are clearing the flags

Re: CVS commit: src/sys/netinet

2018-03-31 Thread Robert Elz
Date:Sat, 31 Mar 2018 15:33:30 +0100 From:Alexander Nasonov Message-ID: <20180331143330.GB22190@neva> | After looking at email archives I see that many active developers | are "guilty" of committing 'hi dev@' messages. It used to be common.

Re: CVS commit: src/sys/netinet

2018-03-31 Thread Taylor R Campbell
> Date: Sat, 31 Mar 2018 14:53:36 +0100 > From: Alexander Nasonov > > Taylor R Campbell wrote: > > One connotation of `hi dev@' may be `dev@ is an idiot'; it can be > > offputting -- and it's not really necessary to call them out publicly. > > Sometimes dev@ has a rapport with

Re: CVS commit: src/sys/netinet

2018-03-31 Thread Alexander Nasonov
Robert Elz wrote: > I totally agree with this - and it is worse when included in commit logs > wherte it will remain, visible, and actually viewed, forever (unlike even > in a mailing list, which while archived forever, somewhere, usually > falls quickly out of view.) Searching for archived email

Re: CVS commit: src/sys/netinet

2018-03-31 Thread Alexander Nasonov
Taylor R Campbell wrote: > They mean different things. > > `hi dev@' means `FYI, dev@, you broke this, so I'm fixing it'. > > `ok dev@' means `dev@ reviewed and approved this change'. I'm well aware they mean different things. > One connotation of `hi dev@' may be `dev@ is an idiot'; it can be

Re: CVS commit: src/sys/netinet

2018-03-30 Thread Robert Elz
Date:Sat, 31 Mar 2018 03:07:29 + From:Taylor R Campbell Message-ID: <20180331030950.2325d60...@jupiter.mumble.net> | but a passive observer can't tell the difference between | one colleague joshing another and

Re: CVS commit: src/sys/netinet

2018-03-30 Thread Taylor R Campbell
> Date: Thu, 29 Mar 2018 23:53:42 +0100 > From: Alexander Nasonov > > m...@netbsd.org wrote: > > I seem to recall a discussion about wanting to avoid this type > > of commit message (hi dev-name), as it can be seen as excessively > > hostile. > > 'ok rmind@' would definitely be

  1   2   >