CVS commit: src/tests/lib/csu/arch/riscv
Module Name:src
Committed By: rin
Date: Thu Aug 24 05:51:55 UTC 2023
Modified Files:
src/tests/lib/csu/arch/riscv: h_initfini_align.S
Log Message:
riscv: tests/lib/csu: Fix typo in check_stack_alignment()
Now, all tests in tests/lib/csu successfully pass for riscv64.
To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 src/tests/lib/csu/arch/riscv/h_initfini_align.S
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/tests/lib/csu/arch/riscv/h_initfini_align.S
diff -u src/tests/lib/csu/arch/riscv/h_initfini_align.S:1.1 src/tests/lib/csu/arch/riscv/h_initfini_align.S:1.2
--- src/tests/lib/csu/arch/riscv/h_initfini_align.S:1.1 Sun May 7 12:41:49 2023
+++ src/tests/lib/csu/arch/riscv/h_initfini_align.S Thu Aug 24 05:51:55 2023
@@ -1,15 +1,15 @@
-/* $NetBSD: h_initfini_align.S,v 1.1 2023/05/07 12:41:49 skrll Exp $ */
+/* $NetBSD: h_initfini_align.S,v 1.2 2023/08/24 05:51:55 rin Exp $ */
#include
-RCSID("$NetBSD: h_initfini_align.S,v 1.1 2023/05/07 12:41:49 skrll Exp $")
+RCSID("$NetBSD: h_initfini_align.S,v 1.2 2023/08/24 05:51:55 rin Exp $")
/*
* LINTSTUB: bool check_stack_alignment(void);
*/
ENTRY_NP(check_stack_alignment)
-andia0, a0, 15
+andia0, sp, 15
seqza0, a0
ret
END(check_stack_alignment)
CVS commit: src/tests/lib/csu/arch/riscv
Module Name:src Committed By: rin Date: Thu Aug 24 05:51:55 UTC 2023 Modified Files: src/tests/lib/csu/arch/riscv: h_initfini_align.S Log Message: riscv: tests/lib/csu: Fix typo in check_stack_alignment() Now, all tests in tests/lib/csu successfully pass for riscv64. To generate a diff of this commit: cvs rdiff -u -r1.1 -r1.2 src/tests/lib/csu/arch/riscv/h_initfini_align.S Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/tests/lib/csu
Module Name:src Committed By: wiz Date: Wed Jun 22 21:11:41 UTC 2022 Modified Files: src/tests/lib/csu: t_ifunc_static.sh Log Message: test: fix typo and improve wording To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 src/tests/lib/csu/t_ifunc_static.sh Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/tests/lib/csu/t_ifunc_static.sh diff -u src/tests/lib/csu/t_ifunc_static.sh:1.3 src/tests/lib/csu/t_ifunc_static.sh:1.4 --- src/tests/lib/csu/t_ifunc_static.sh:1.3 Tue Jun 21 06:52:17 2022 +++ src/tests/lib/csu/t_ifunc_static.sh Wed Jun 22 21:11:41 2022 @@ -1,4 +1,4 @@ -# $NetBSD: t_ifunc_static.sh,v 1.3 2022/06/21 06:52:17 skrll Exp $ +# $NetBSD: t_ifunc_static.sh,v 1.4 2022/06/22 21:11:41 wiz Exp $ # # Copyright (c) 2018 The NetBSD Foundation, Inc. # All rights reserved. @@ -36,7 +36,7 @@ ifunc_static_body() i386|x86_64|powerpc|*sparc*|*arm*|*aarch64*) ;; *) - atf_skip "ifunc is supposed only on AARCH64, ARM, i386, PowerPC, SPARC and x86-64" + atf_skip "ifunc is only supported on AARCH64, ARM, i386, PowerPC, SPARC and x86-64" ;; esac
CVS commit: src/tests/lib/csu
Module Name:src Committed By: wiz Date: Wed Jun 22 21:11:41 UTC 2022 Modified Files: src/tests/lib/csu: t_ifunc_static.sh Log Message: test: fix typo and improve wording To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 src/tests/lib/csu/t_ifunc_static.sh Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/tests/lib/csu
Module Name:src Committed By: martin Date: Mon Jun 13 12:55:06 UTC 2022 Modified Files: src/tests/lib/csu: h_ifunc_static.c Log Message: Restore arm in the list of architectures supporting ifunc, accidently lost in the OABI removal. To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/tests/lib/csu/h_ifunc_static.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/tests/lib/csu/h_ifunc_static.c diff -u src/tests/lib/csu/h_ifunc_static.c:1.4 src/tests/lib/csu/h_ifunc_static.c:1.5 --- src/tests/lib/csu/h_ifunc_static.c:1.4 Mon Jun 7 17:11:17 2021 +++ src/tests/lib/csu/h_ifunc_static.c Mon Jun 13 12:55:06 2022 @@ -1,4 +1,4 @@ -/* $NetBSD: h_ifunc_static.c,v 1.4 2021/06/07 17:11:17 christos Exp $ */ +/* $NetBSD: h_ifunc_static.c,v 1.5 2022/06/13 12:55:06 martin Exp $ */ /*- * Copyright (c) 2018 The NetBSD Foundation, Inc. @@ -29,7 +29,8 @@ * POSSIBILITY OF SUCH DAMAGE. */ -#if defined(__i386__) || defined(__x86_64__) || defined(__powerpc__) || defined(__sparc__) +#if defined(__arm__) || defined(__i386__) || \ + defined(__x86_64__) || defined(__powerpc__) || defined(__sparc__) #include #include
CVS commit: src/tests/lib/csu
Module Name:src Committed By: martin Date: Mon Jun 13 12:55:06 UTC 2022 Modified Files: src/tests/lib/csu: h_ifunc_static.c Log Message: Restore arm in the list of architectures supporting ifunc, accidently lost in the OABI removal. To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/tests/lib/csu/h_ifunc_static.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
re: CVS commit: src/tests/lib/csu
Christos Zoulas writes: > In article , Joerg Sonnenberger > wrote: > >On Fri, Jun 04, 2021 at 10:20:24PM -, Christos Zoulas wrote: > >> In article , Joerg Sonnenberger > > wrote: > >> >On Thu, Jun 03, 2021 at 04:17:37PM -0400, Christos Zoulas wrote: > >> >> Module Name:src > >> >> Committed By: christos > >> >> Date: Thu Jun 3 20:17:37 UTC 2021 > >> >> > >> >> Modified Files: > >> >> src/tests/lib/csu: h_ifunc_static.c > >> >> > >> >> Log Message: > >> >> PR/56230: Jan-Benedict Glaw: arm oabi does not and will not have ifunc > >> >support. > >> > > >> >As I mentioned elsewhere, I disagree with this change. OABI is dead and > >> >only really support for legacy compatibility. All the OABI build > >> >variants should be removed and this is strongly a step in the wrong > >> >direction. > >> > >> I think it is better to do it after the 10 branch. It is not just removing > >> the build.sh targets, we need to remove the compat glue and fix the sets, > >> and perhaps something else I am missing. I will revert the two changes > >> once we remove all oabi support. > > > >I don't see how that's related. I'm not talking about removing the > >compat layer right now. Remove the build.sh targets and call it a day. > > CC:ed tech-toolchain. Does everyone agree to remove the oabi build targets? AFAICT, GCC removed the basic oabi targets recently, which is why they weren't updated. we have some dead code in our gcc/arm port in the GCC 10 tree. you can still target oabi with compiler options, but there are no configurations that default to it any more. at this point i'm also wanting to turn off the compat libs for everyone entirely -- if you have old oabi apps, you're welcome to use old libs to run them, same as eg, when we switched from a.out to ELF originally. this is *not* the kernel support to run these apps. ie, remove it from build.sh and share/mk/ ASAP -- before the netbsd 10 branch. .mrg.
Re: CVS commit: src/tests/lib/csu
In article , Joerg Sonnenberger wrote: >On Fri, Jun 04, 2021 at 10:20:24PM -, Christos Zoulas wrote: >> In article , Joerg Sonnenberger > wrote: >> >On Thu, Jun 03, 2021 at 04:17:37PM -0400, Christos Zoulas wrote: >> >> Module Name: src >> >> Committed By: christos >> >> Date: Thu Jun 3 20:17:37 UTC 2021 >> >> >> >> Modified Files: >> >> src/tests/lib/csu: h_ifunc_static.c >> >> >> >> Log Message: >> >> PR/56230: Jan-Benedict Glaw: arm oabi does not and will not have ifunc >> >support. >> > >> >As I mentioned elsewhere, I disagree with this change. OABI is dead and >> >only really support for legacy compatibility. All the OABI build >> >variants should be removed and this is strongly a step in the wrong >> >direction. >> >> I think it is better to do it after the 10 branch. It is not just removing >> the build.sh targets, we need to remove the compat glue and fix the sets, >> and perhaps something else I am missing. I will revert the two changes >> once we remove all oabi support. > >I don't see how that's related. I'm not talking about removing the >compat layer right now. Remove the build.sh targets and call it a day. CC:ed tech-toolchain. Does everyone agree to remove the oabi build targets? christos
Re: CVS commit: src/tests/lib/csu
On Fri, Jun 04, 2021 at 10:20:24PM -, Christos Zoulas wrote: > In article , Joerg Sonnenberger > wrote: > >On Thu, Jun 03, 2021 at 04:17:37PM -0400, Christos Zoulas wrote: > >> Module Name: src > >> Committed By: christos > >> Date: Thu Jun 3 20:17:37 UTC 2021 > >> > >> Modified Files: > >>src/tests/lib/csu: h_ifunc_static.c > >> > >> Log Message: > >> PR/56230: Jan-Benedict Glaw: arm oabi does not and will not have ifunc > >support. > > > >As I mentioned elsewhere, I disagree with this change. OABI is dead and > >only really support for legacy compatibility. All the OABI build > >variants should be removed and this is strongly a step in the wrong > >direction. > > I think it is better to do it after the 10 branch. It is not just removing > the build.sh targets, we need to remove the compat glue and fix the sets, > and perhaps something else I am missing. I will revert the two changes > once we remove all oabi support. I don't see how that's related. I'm not talking about removing the compat layer right now. Remove the build.sh targets and call it a day. Joerg
Re: CVS commit: src/tests/lib/csu
In article , Joerg Sonnenberger wrote: >On Thu, Jun 03, 2021 at 04:17:37PM -0400, Christos Zoulas wrote: >> Module Name: src >> Committed By:christos >> Date:Thu Jun 3 20:17:37 UTC 2021 >> >> Modified Files: >> src/tests/lib/csu: h_ifunc_static.c >> >> Log Message: >> PR/56230: Jan-Benedict Glaw: arm oabi does not and will not have ifunc >support. > >As I mentioned elsewhere, I disagree with this change. OABI is dead and >only really support for legacy compatibility. All the OABI build >variants should be removed and this is strongly a step in the wrong >direction. I think it is better to do it after the 10 branch. It is not just removing the build.sh targets, we need to remove the compat glue and fix the sets, and perhaps something else I am missing. I will revert the two changes once we remove all oabi support. christos
Re: CVS commit: src/tests/lib/csu
On Thu, Jun 03, 2021 at 04:17:37PM -0400, Christos Zoulas wrote: > Module Name: src > Committed By: christos > Date: Thu Jun 3 20:17:37 UTC 2021 > > Modified Files: > src/tests/lib/csu: h_ifunc_static.c > > Log Message: > PR/56230: Jan-Benedict Glaw: arm oabi does not and will not have ifunc > support. As I mentioned elsewhere, I disagree with this change. OABI is dead and only really support for legacy compatibility. All the OABI build variants should be removed and this is strongly a step in the wrong direction. Joerg
