CVS commit: src/usr.bin/make

2021-10-17 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 17 18:40:15 UTC 2021 Modified Files: src/usr.bin/make: var.c Log Message: make: fix order of parameters in function comments No functional change. To generate a diff of this commit: cvs rdiff -u -r1.952 -r1.953

CVS commit: src/usr.bin/make

2021-10-17 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 17 18:40:15 UTC 2021 Modified Files: src/usr.bin/make: var.c Log Message: make: fix order of parameters in function comments No functional change. To generate a diff of this commit: cvs rdiff -u -r1.952 -r1.953

CVS commit: src/usr.bin/make

2021-09-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Sep 26 03:23:06 UTC 2021 Modified Files: src/usr.bin/make: cond.c Log Message: make: fix lint warning on i386 cond.c(800): warning: argument #3 is converted from 'unsigned char' to 'unsigned int' due to prototype [259]

CVS commit: src/usr.bin/make

2021-09-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Sep 26 03:23:06 UTC 2021 Modified Files: src/usr.bin/make: cond.c Log Message: make: fix lint warning on i386 cond.c(800): warning: argument #3 is converted from 'unsigned char' to 'unsigned int' due to prototype [259]

CVS commit: src/usr.bin/make

2021-09-23 Thread Roland Illig
Module Name:src Committed By: rillig Date: Thu Sep 23 22:54:09 UTC 2021 Modified Files: src/usr.bin/make: var.c Log Message: make: fix memory leak in error case of the ':?' modifier To generate a diff of this commit: cvs rdiff -u -r1.951 -r1.952 src/usr.bin/make/var.c

CVS commit: src/usr.bin/make

2021-09-23 Thread Roland Illig
Module Name:src Committed By: rillig Date: Thu Sep 23 22:54:09 UTC 2021 Modified Files: src/usr.bin/make: var.c Log Message: make: fix memory leak in error case of the ':?' modifier To generate a diff of this commit: cvs rdiff -u -r1.951 -r1.952 src/usr.bin/make/var.c

CVS commit: src/usr.bin/make

2021-09-21 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Sep 21 23:06:18 UTC 2021 Modified Files: src/usr.bin/make: cond.c parse.c trace.c var.c Log Message: make: reduce relocations, thereby reducing .text size No functional change. To generate a diff of this commit: cvs rdiff

CVS commit: src/usr.bin/make

2021-09-21 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Sep 21 23:06:18 UTC 2021 Modified Files: src/usr.bin/make: cond.c parse.c trace.c var.c Log Message: make: reduce relocations, thereby reducing .text size No functional change. To generate a diff of this commit: cvs rdiff

CVS commit: src/usr.bin/make

2021-09-21 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Sep 21 22:53:35 UTC 2021 Modified Files: src/usr.bin/make: cond.c Log Message: make: reduce relocations and thereby .text size, make opname const No functional change. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/usr.bin/make

2021-09-21 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Sep 21 22:53:35 UTC 2021 Modified Files: src/usr.bin/make: cond.c Log Message: make: reduce relocations and thereby .text size, make opname const No functional change. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/usr.bin/make

2021-09-21 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Sep 21 22:48:04 UTC 2021 Modified Files: src/usr.bin/make: cond.c Log Message: make: rename and invert CondParser.lhsStrict to leftUnquotedOK The new name is easier to grasp than the rather abstract word 'strict'. No

CVS commit: src/usr.bin/make

2021-09-21 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Sep 21 22:48:04 UTC 2021 Modified Files: src/usr.bin/make: cond.c Log Message: make: rename and invert CondParser.lhsStrict to leftUnquotedOK The new name is easier to grasp than the rather abstract word 'strict'. No

CVS commit: src/usr.bin/make

2021-09-21 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Sep 21 22:38:25 UTC 2021 Modified Files: src/usr.bin/make: cond.c src/usr.bin/make/unit-tests: cond-token-plain.exp cond-token-plain.mk Log Message: make: do not allow unquoted 'left == right' after modifier ':?'

CVS commit: src/usr.bin/make

2021-09-21 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Sep 21 22:38:25 UTC 2021 Modified Files: src/usr.bin/make: cond.c src/usr.bin/make/unit-tests: cond-token-plain.exp cond-token-plain.mk Log Message: make: do not allow unquoted 'left == right' after modifier ':?'

CVS commit: src/usr.bin/make/unit-tests

2021-09-21 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Sep 21 21:59:56 UTC 2021 Modified Files: src/usr.bin/make/unit-tests: cond-token-plain.exp cond-token-plain.mk Log Message: tests/make: demonstrate unintended unquoted string in conditions To generate a diff of this commit:

CVS commit: src/usr.bin/make/unit-tests

2021-09-21 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Sep 21 21:59:56 UTC 2021 Modified Files: src/usr.bin/make/unit-tests: cond-token-plain.exp cond-token-plain.mk Log Message: tests/make: demonstrate unintended unquoted string in conditions To generate a diff of this commit:

CVS commit: src/usr.bin/make

2021-09-21 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Sep 21 21:43:32 UTC 2021 Modified Files: src/usr.bin/make: cond.c Log Message: make: remove unnecessary negation from CondParser_StringExpr No functional change. To generate a diff of this commit: cvs rdiff -u -r1.274

CVS commit: src/usr.bin/make

2021-09-21 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Sep 21 21:43:32 UTC 2021 Modified Files: src/usr.bin/make: cond.c Log Message: make: remove unnecessary negation from CondParser_StringExpr No functional change. To generate a diff of this commit: cvs rdiff -u -r1.274

CVS commit: src/usr.bin/make

2021-09-21 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Sep 21 21:39:32 UTC 2021 Modified Files: src/usr.bin/make: cond.c dir.c parse.c Log Message: make: remove unnecessary const from parameters These were leftovers from earlier refactorings, when extracting code to separate

CVS commit: src/usr.bin/make

2021-09-21 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Sep 21 21:39:32 UTC 2021 Modified Files: src/usr.bin/make: cond.c dir.c parse.c Log Message: make: remove unnecessary const from parameters These were leftovers from earlier refactorings, when extracting code to separate

CVS commit: src/usr.bin/make

2021-09-21 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Sep 21 21:03:36 UTC 2021 Modified Files: src/usr.bin/make: cond.c Log Message: make: fix out-of-bounds memory read (since previous commit) To generate a diff of this commit: cvs rdiff -u -r1.272 -r1.273

CVS commit: src/usr.bin/make

2021-09-21 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Sep 21 21:03:36 UTC 2021 Modified Files: src/usr.bin/make: cond.c Log Message: make: fix out-of-bounds memory read (since previous commit) To generate a diff of this commit: cvs rdiff -u -r1.272 -r1.273

CVS commit: src/usr.bin/make

2021-09-21 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Sep 21 20:54:42 UTC 2021 Modified Files: src/usr.bin/make: cond.c Log Message: make: reduce indentation in CondParser_FuncCall No functional change. To generate a diff of this commit: cvs rdiff -u -r1.271 -r1.272

CVS commit: src/usr.bin/make

2021-09-21 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Sep 21 20:54:42 UTC 2021 Modified Files: src/usr.bin/make: cond.c Log Message: make: reduce indentation in CondParser_FuncCall No functional change. To generate a diff of this commit: cvs rdiff -u -r1.271 -r1.272

CVS commit: src/usr.bin/make

2021-09-21 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Sep 21 20:51:39 UTC 2021 Modified Files: src/usr.bin/make: cond.c Log Message: make: fix documentation about operator associativity in conditions To generate a diff of this commit: cvs rdiff -u -r1.270 -r1.271

CVS commit: src/usr.bin/make

2021-09-21 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Sep 21 20:51:39 UTC 2021 Modified Files: src/usr.bin/make: cond.c Log Message: make: fix documentation about operator associativity in conditions To generate a diff of this commit: cvs rdiff -u -r1.270 -r1.271

CVS commit: src/usr.bin/make

2021-09-12 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Sep 12 10:28:40 UTC 2021 Modified Files: src/usr.bin/make: test-variants.sh Log Message: tests/make: allow to only test selected variants Testing all variants takes several minutes, so make it possible to test a single or a

CVS commit: src/usr.bin/make

2021-09-12 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Sep 12 10:28:40 UTC 2021 Modified Files: src/usr.bin/make: test-variants.sh Log Message: tests/make: allow to only test selected variants Testing all variants takes several minutes, so make it possible to test a single or a

CVS commit: src/usr.bin/make/unit-tests

2021-09-12 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Sep 12 10:26:49 UTC 2021 Modified Files: src/usr.bin/make/unit-tests: job-output-null.exp job-output-null.mk Log Message: tests/make: make output of test job-output-null clearer Having 5 times the word 'hello' in the output

CVS commit: src/usr.bin/make/unit-tests

2021-09-12 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Sep 12 10:26:49 UTC 2021 Modified Files: src/usr.bin/make/unit-tests: job-output-null.exp job-output-null.mk Log Message: tests/make: make output of test job-output-null clearer Having 5 times the word 'hello' in the output

CVS commit: src/usr.bin/make

2021-09-12 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Sep 12 09:51:14 UTC 2021 Modified Files: src/usr.bin/make: make.h test-variants.sh Log Message: make: error out if a pre-C99 platform defines bool in some cases On NetBSD/amd64 9.99.88, when compiling make in C90 mode,

CVS commit: src/usr.bin/make

2021-09-12 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Sep 12 09:51:14 UTC 2021 Modified Files: src/usr.bin/make: make.h test-variants.sh Log Message: make: error out if a pre-C99 platform defines bool in some cases On NetBSD/amd64 9.99.88, when compiling make in C90 mode,

CVS commit: src/usr.bin/make

2021-09-12 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Sep 12 08:36:15 UTC 2021 Modified Files: src/usr.bin/make: hash.c Log Message: make: fix build for DEBUG_HASH_LOOKUP To generate a diff of this commit: cvs rdiff -u -r1.64 -r1.65 src/usr.bin/make/hash.c Please note that

CVS commit: src/usr.bin/make

2021-09-12 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Sep 12 08:36:15 UTC 2021 Modified Files: src/usr.bin/make: hash.c Log Message: make: fix build for DEBUG_HASH_LOOKUP To generate a diff of this commit: cvs rdiff -u -r1.64 -r1.65 src/usr.bin/make/hash.c Please note that

CVS commit: src/usr.bin/make

2021-09-12 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Sep 12 08:32:23 UTC 2021 Modified Files: src/usr.bin/make: targ.c Log Message: make: reduce number of relocations in Targ_PrintType On x86_64, this saves 120 bytes of .text. No functional change. To generate a diff of

CVS commit: src/usr.bin/make

2021-09-12 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Sep 12 08:32:23 UTC 2021 Modified Files: src/usr.bin/make: targ.c Log Message: make: reduce number of relocations in Targ_PrintType On x86_64, this saves 120 bytes of .text. No functional change. To generate a diff of

CVS commit: src/usr.bin/make

2021-09-12 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Sep 12 08:03:49 UTC 2021 Modified Files: src/usr.bin/make: nonints.h targ.c Log Message: make: fix lint warnings for strict bool mode In strict bool mode, lint does not consider 'x & y' as having type bool, if x and y have

CVS commit: src/usr.bin/make

2021-09-12 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Sep 12 08:03:49 UTC 2021 Modified Files: src/usr.bin/make: nonints.h targ.c Log Message: make: fix lint warnings for strict bool mode In strict bool mode, lint does not consider 'x & y' as having type bool, if x and y have

CVS commit: src/usr.bin/make

2021-09-12 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Sep 12 07:52:21 UTC 2021 Modified Files: src/usr.bin/make: targ.c Log Message: make: fix Targ_PrintType for pre-C99 compilers To generate a diff of this commit: cvs rdiff -u -r1.169 -r1.170 src/usr.bin/make/targ.c Please

CVS commit: src/usr.bin/make

2021-09-12 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Sep 12 07:52:21 UTC 2021 Modified Files: src/usr.bin/make: targ.c Log Message: make: fix Targ_PrintType for pre-C99 compilers To generate a diff of this commit: cvs rdiff -u -r1.169 -r1.170 src/usr.bin/make/targ.c Please

CVS commit: src/usr.bin/make

2021-09-12 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Sep 12 07:50:45 UTC 2021 Modified Files: src/usr.bin/make: targ.c Log Message: make: make Targ_PrintType simpler No functional change. To generate a diff of this commit: cvs rdiff -u -r1.168 -r1.169 src/usr.bin/make/targ.c

CVS commit: src/usr.bin/make

2021-09-12 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Sep 12 07:50:45 UTC 2021 Modified Files: src/usr.bin/make: targ.c Log Message: make: make Targ_PrintType simpler No functional change. To generate a diff of this commit: cvs rdiff -u -r1.168 -r1.169 src/usr.bin/make/targ.c

CVS commit: src/usr.bin/make

2021-09-11 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Sep 11 09:16:14 UTC 2021 Modified Files: src/usr.bin/make: var.c Log Message: make: eliminate a few common subexpressions This commit contains only changes that don't increase the code size on x86_64. Replacing the

CVS commit: src/usr.bin/make

2021-09-11 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Sep 11 09:16:14 UTC 2021 Modified Files: src/usr.bin/make: var.c Log Message: make: eliminate a few common subexpressions This commit contains only changes that don't increase the code size on x86_64. Replacing the

CVS commit: src/usr.bin/make/unit-tests

2021-09-07 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Sep 7 20:41:58 UTC 2021 Modified Files: src/usr.bin/make/unit-tests: cond-short.mk var-eval-short.exp var-eval-short.mk Log Message: tests/make: expand on the history of unnecessary evaluation To generate a

CVS commit: src/usr.bin/make/unit-tests

2021-09-07 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Sep 7 20:41:58 UTC 2021 Modified Files: src/usr.bin/make/unit-tests: cond-short.mk var-eval-short.exp var-eval-short.mk Log Message: tests/make: expand on the history of unnecessary evaluation To generate a

CVS commit: src/usr.bin/make/unit-tests

2021-09-06 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Sep 6 21:18:55 UTC 2021 Modified Files: src/usr.bin/make/unit-tests: varmod-subst.mk Log Message: tests/make: test modifier ':S' with replacement '&' Before 2020-08-30, OpenBSD make incorrectly copied the anchors '^' and

CVS commit: src/usr.bin/make/unit-tests

2021-09-06 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Sep 6 21:18:55 UTC 2021 Modified Files: src/usr.bin/make/unit-tests: varmod-subst.mk Log Message: tests/make: test modifier ':S' with replacement '&' Before 2020-08-30, OpenBSD make incorrectly copied the anchors '^' and

CVS commit: src/usr.bin/make

2021-09-06 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Sep 6 19:38:30 UTC 2021 Modified Files: src/usr.bin/make: var.c src/usr.bin/make/unit-tests: var-eval-short.mk Log Message: make: fix typos in comments To generate a diff of this commit: cvs rdiff -u -r1.948

CVS commit: src/usr.bin/make

2021-09-06 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Sep 6 19:38:30 UTC 2021 Modified Files: src/usr.bin/make: var.c src/usr.bin/make/unit-tests: var-eval-short.mk Log Message: make: fix typos in comments To generate a diff of this commit: cvs rdiff -u -r1.948

CVS commit: src/usr.bin/make

2021-09-02 Thread Roland Illig
Module Name:src Committed By: rillig Date: Thu Sep 2 07:02:08 UTC 2021 Modified Files: src/usr.bin/make: for.c src/usr.bin/make/unit-tests: directive-for-escape.exp directive-for-escape.mk Log Message: make: rename for_var_len to ExprLen The text

CVS commit: src/usr.bin/make

2021-09-02 Thread Roland Illig
Module Name:src Committed By: rillig Date: Thu Sep 2 07:02:08 UTC 2021 Modified Files: src/usr.bin/make: for.c src/usr.bin/make/unit-tests: directive-for-escape.exp directive-for-escape.mk Log Message: make: rename for_var_len to ExprLen The text

CVS commit: src/usr.bin/make

2021-09-02 Thread Roland Illig
Module Name:src Committed By: rillig Date: Thu Sep 2 06:29:56 UTC 2021 Modified Files: src/usr.bin/make: for.c Log Message: make: inline strchr call, make ForLoop_SubstBody clearer In ForLoop_SubstBody, GCC already merged the common subexpressions p[1] and p[-1], but

CVS commit: src/usr.bin/make

2021-09-02 Thread Roland Illig
Module Name:src Committed By: rillig Date: Thu Sep 2 06:29:56 UTC 2021 Modified Files: src/usr.bin/make: for.c Log Message: make: inline strchr call, make ForLoop_SubstBody clearer In ForLoop_SubstBody, GCC already merged the common subexpressions p[1] and p[-1], but

CVS commit: src/usr.bin/make

2021-09-01 Thread Roland Illig
Module Name:src Committed By: rillig Date: Wed Sep 1 23:07:41 UTC 2021 Modified Files: src/usr.bin/make: for.c Log Message: make: remove optimization for single-letter .for variables Most .for loops have a single iteration variable. For these loops, the difference

CVS commit: src/usr.bin/make

2021-09-01 Thread Roland Illig
Module Name:src Committed By: rillig Date: Wed Sep 1 23:07:41 UTC 2021 Modified Files: src/usr.bin/make: for.c Log Message: make: remove optimization for single-letter .for variables Most .for loops have a single iteration variable. For these loops, the difference

CVS commit: src/usr.bin/make/unit-tests

2021-09-01 Thread Roland Illig
Module Name:src Committed By: rillig Date: Wed Sep 1 22:44:50 UTC 2021 Modified Files: src/usr.bin/make/unit-tests: directive-for-if.exp Log Message: tests/make: fix test directive-for-if The additional lines 'VAR1' and 'VAR3' were supposed to be there from the

CVS commit: src/usr.bin/make/unit-tests

2021-09-01 Thread Roland Illig
Module Name:src Committed By: rillig Date: Wed Sep 1 22:44:50 UTC 2021 Modified Files: src/usr.bin/make/unit-tests: directive-for-if.exp Log Message: tests/make: fix test directive-for-if The additional lines 'VAR1' and 'VAR3' were supposed to be there from the

CVS commit: src/usr.bin/make

2021-08-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Wed Aug 25 22:14:38 UTC 2021 Modified Files: src/usr.bin/make: arch.c var.c Log Message: make: fix lint warnings on ilp32 platforms The warnings in arch.c were about conversions from int to long. The warnings in var.c were

CVS commit: src/usr.bin/make

2021-08-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Wed Aug 25 22:14:38 UTC 2021 Modified Files: src/usr.bin/make: arch.c var.c Log Message: make: fix lint warnings on ilp32 platforms The warnings in arch.c were about conversions from int to long. The warnings in var.c were

CVS commit: src/usr.bin/make

2021-08-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Thu Aug 19 15:50:30 UTC 2021 Modified Files: src/usr.bin/make: meta.c Log Message: make: fix lint warning about strrchr discarding 'const' No functional change. To generate a diff of this commit: cvs rdiff -u -r1.182 -r1.183

CVS commit: src/usr.bin/make

2021-08-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Thu Aug 19 15:50:30 UTC 2021 Modified Files: src/usr.bin/make: meta.c Log Message: make: fix lint warning about strrchr discarding 'const' No functional change. To generate a diff of this commit: cvs rdiff -u -r1.182 -r1.183

Re: CVS commit: src/usr.bin/make

2021-01-29 Thread Roland Illig
On 27.01.2021 20:54, Reinoud Zandijk wrote: Hi, On Tue, Jan 26, 2021 at 11:44:56PM +, Roland Illig wrote: Module Name:src Committed By: rillig Date: Tue Jan 26 23:44:56 UTC 2021 Modified Files: src/usr.bin/make: parse.c src/usr.bin/make/unit-tests:

Re: CVS commit: src/usr.bin/make

2021-01-27 Thread Reinoud Zandijk
Hi, On Tue, Jan 26, 2021 at 11:44:56PM +, Roland Illig wrote: > Module Name: src > Committed By: rillig > Date: Tue Jan 26 23:44:56 UTC 2021 > > Modified Files: > src/usr.bin/make: parse.c > src/usr.bin/make/unit-tests: include-main.exp include-subsub.mk > > Log

Re: CVS commit: src/usr.bin/make

2021-01-26 Thread Martin Husemann
On Tue, Jan 26, 2021 at 11:39:52PM +0100, Roland Illig wrote: > The code of usr.bin/make gets distributed to a wider audience by Simon's > bmake distribution (http://www.crufty.net/help/sjg/bmake.html), that's > where the requirement of supporting C89 compilers comes from. At the > time I

Re: CVS commit: src/usr.bin/make

2021-01-26 Thread Roland Illig
On 26.01.2021 21:04, Christos Zoulas wrote: Yes, and I did not push for it for the exact reasons stated below: There was only a handful of cases and those can be handled with casts or a macro for now. I am questioning though the utility of maintaining compatibility with platforms that do not

Re: CVS commit: src/usr.bin/make

2021-01-26 Thread Christos Zoulas
Yes, and I did not push for it for the exact reasons stated below: There was only a handful of cases and those can be handled with casts or a macro for now. I am questioning though the utility of maintaining compatibility with platforms that do not support C99 20 years later, vs. using %u and

Re: CVS commit: src/usr.bin/make

2021-01-26 Thread Roland Illig
On 26.01.2021 11:19, Rin Okuyama wrote: Ping? I don't think this is correct fix either. Can you please revert this commit? Sorry, I didn't get the first mail from Christos back in December, that's why I didn't take any action. Why shouldn't the fix I did be correct? I carefully checked the

Re: CVS commit: src/usr.bin/make

2021-01-26 Thread Rin Okuyama
Ping? I don't think this is correct fix either. Can you please revert this commit? Thanks, rin On 2020/12/15 7:57, Christos Zoulas wrote: In article <20201213212746.3cfc3f...@cvs.netbsd.org>, Roland Illig wrote: -=-=-=-=-=- Module Name:src Committed By: rillig Date: Sun Dec

re: CVS commit: src/usr.bin/make

2020-12-22 Thread matthew green
"Roland Illig" writes: > Module Name: src > Committed By: rillig > Date: Tue Dec 22 08:10:39 UTC 2020 > > Modified Files: > src/usr.bin/make: parse.c i'm not sure which change did it (but before this one for sure), but my builds crash early now (still trying to bootstrap nbmake):

Re: CVS commit: src/usr.bin/make

2020-12-14 Thread Christos Zoulas
In article <20201213212746.3cfc3f...@cvs.netbsd.org>, Roland Illig wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: rillig >Date: Sun Dec 13 21:27:46 UTC 2020 > >Modified Files: > src/usr.bin/make: for.c meta.c parse.c var.c > >Log Message: >make(1): replace %zu with %u in

Re: CVS commit: src/usr.bin/make

2020-10-26 Thread David Holland
On Sun, Oct 25, 2020 at 05:37:36PM +, Simon J. Gerraty wrote: > Modified Files: > src/usr.bin/make: main.c > src/usr.bin/make/unit-tests: varmod-match-escape.exp > > Log Message: > Skip reading .MAKE.DEPENDFILE if set to > "/dev/null" or anything starting with "no". > >

Re: CVS commit: src/usr.bin/make

2020-09-24 Thread Roland Illig
On 24.09.2020 18:02, Jonathan A. Kollasch wrote: cvs rdiff -u -r1.65 -r1.66 src/usr.bin/make/lst.h breaks build on Debian 9: In file included from /local/jakllsch/netbsd/src/usr.bin/make/make.h:158:0, from /local/jakllsch/netbsd/src/usr.bin/make/arch.c:130:

Re: CVS commit: src/usr.bin/make

2020-09-24 Thread Jonathan A. Kollasch
> cvs rdiff -u -r1.65 -r1.66 src/usr.bin/make/lst.h breaks build on Debian 9: In file included from /local/jakllsch/netbsd/src/usr.bin/make/make.h:158:0, from /local/jakllsch/netbsd/src/usr.bin/make/arch.c:130: /local/jakllsch/netbsd/src/usr.bin/make/lst.h:92:5: error: unknown

Re: CVS commit: src/usr.bin/make

2020-09-14 Thread Roland Illig
On 14.09.2020 21:05, Robert Elz wrote: Date:Mon, 14 Sep 2020 16:16:52 + From:"Roland Illig" Message-ID: <20200914161652.d4eb5f...@cvs.netbsd.org> | make(1): inline LPAREN in parse.c | | It's shorter and more readable, and the other characters don't

Re: CVS commit: src/usr.bin/make

2020-09-14 Thread Robert Elz
Date:Mon, 14 Sep 2020 16:16:52 + From:"Roland Illig" Message-ID: <20200914161652.d4eb5f...@cvs.netbsd.org> | make(1): inline LPAREN in parse.c | | It's shorter and more readable, and the other characters don't have | named constants as well. Most likely

Re: CVS commit: src/usr.bin/make

2020-08-02 Thread Roland Illig
On 02.08.2020 13:06, Simon Burge wrote: > "Roland Illig" wrote: > >> Module Name: src >> Committed By:rillig >> Date:Sun Aug 2 09:43:22 UTC 2020 >> >> Modified Files: >> >> src/usr.bin/make: var.c >> >> Log Message: >> >> make(1): use shorter local variable names >>

Re: CVS commit: src/usr.bin/make

2020-08-02 Thread Simon Burge
"Roland Illig" wrote: > Module Name: src > Committed By: rillig > Date: Sun Aug 2 09:43:22 UTC 2020 > > Modified Files: > > src/usr.bin/make: var.c > > Log Message: > > make(1): use shorter local variable names > > The c in cp was redundant since the context makes it obvious that

Re: CVS commit: src/usr.bin/make

2020-08-02 Thread Jared McNeill
On Sun, 2 Aug 2020, Roland Illig wrote: Module Name:src Committed By: rillig Date: Sun Aug 2 09:43:22 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): use shorter local variable names The c in cp was redundant since the context makes it obvious

Re: CVS commit: src/usr.bin/make

2020-07-26 Thread Christos Zoulas
In article <20200726200457.f2522f...@cvs.netbsd.org>, Roland Illig wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: rillig >Date: Sun Jul 26 20:04:57 UTC 2020 > >Modified Files: > src/usr.bin/make: Makefile > >Log Message: >make(1): explicitly add dependencies on headers >

re: CVS commit: src/usr.bin/make

2020-07-26 Thread matthew green
> In a follow-up commit, I adjusted the build scripts, and I'm doing a > full build right now. I'm pretty confident that everything works now > again, and if not, I'll fix it immediately. thanks! .mrg.

Re: CVS commit: src/usr.bin/make

2020-07-26 Thread Roland Illig
On 26.07.2020 10:29, matthew green wrote: > "Roland Illig" writes: >> Module Name: src >> Committed By:rillig >> Date:Sun Jul 26 07:15:26 UTC 2020 >> >> Modified Files: >> src/usr.bin/make: Makefile >> Added Files: >> src/usr.bin/make: lst.c >> Removed Files: >>

re: CVS commit: src/usr.bin/make

2020-07-26 Thread matthew green
"Roland Illig" writes: > Module Name: src > Committed By: rillig > Date: Sun Jul 26 07:15:26 UTC 2020 > > Modified Files: > src/usr.bin/make: Makefile > Added Files: > src/usr.bin/make: lst.c > Removed Files: > src/usr.bin/make/lst.lib: Makefile lstAppend.c lstAtEnd.c

Re: CVS commit: src/usr.bin/make

2020-07-19 Thread Izumi Tsutsui
kardel@ wrote: > nbmake currently fails to build the tree. > > config.status: creating buildmake.sh > compile arch.c > compile buf.c > compile compat.c > compile cond.c > compile dir.c > compile for.c > compile hash.c > compile job.c > compile

Re: CVS commit: src/usr.bin/make

2020-07-19 Thread Frank Kardel
nbmake currently fails to build the tree. config.status: creating buildmake.sh compile arch.c compile buf.c compile compat.c compile cond.c compile dir.c compile for.c compile hash.c compile job.c compile main.c compile make.c compile

Re: CVS commit: src/usr.bin/make

2020-07-04 Thread Joerg Sonnenberger
On Sat, Jul 04, 2020 at 03:44:07PM +, Roland Illig wrote: > Module Name: src > Committed By: rillig > Date: Sat Jul 4 15:44:07 UTC 2020 > > Modified Files: > src/usr.bin/make: var.c > > Log Message: > make(1): fix :hash modifier on 16-bit platforms > > On platforms where int

CVS commit: src/usr.bin/make/unit-tests

2019-11-29 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Nov 30 03:53:45 UTC 2019 Modified Files: src/usr.bin/make/unit-tests: varmod-edge.exp varmod-edge.mk Log Message: Demonstrate some more edge cases for the :M modifier To generate a diff of this commit: cvs rdiff -u -r1.2

CVS commit: src/usr.bin/make/unit-tests

2019-11-29 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Nov 30 03:53:45 UTC 2019 Modified Files: src/usr.bin/make/unit-tests: varmod-edge.exp varmod-edge.mk Log Message: Demonstrate some more edge cases for the :M modifier To generate a diff of this commit: cvs rdiff -u -r1.2

CVS commit: src/usr.bin/make/unit-tests

2019-11-29 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Nov 30 02:55:47 UTC 2019 Modified Files: src/usr.bin/make/unit-tests: varmod-edge.mk Log Message: Fix unit test for edge case in :M modifier To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3

CVS commit: src/usr.bin/make/unit-tests

2019-11-29 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Nov 30 02:55:47 UTC 2019 Modified Files: src/usr.bin/make/unit-tests: varmod-edge.mk Log Message: Fix unit test for edge case in :M modifier To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3

CVS commit: src/usr.bin/make/unit-tests

2019-11-29 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Nov 30 02:35:28 UTC 2019 Added Files: src/usr.bin/make/unit-tests: .cvsignore Log Message: Ignore temporary files from running the unit tests To generate a diff of this commit: cvs rdiff -u -r0 -r1.1

CVS commit: src/usr.bin/make/unit-tests

2019-11-29 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Nov 30 02:35:28 UTC 2019 Added Files: src/usr.bin/make/unit-tests: .cvsignore Log Message: Ignore temporary files from running the unit tests To generate a diff of this commit: cvs rdiff -u -r0 -r1.1

CVS commit: src/usr.bin/make/unit-tests

2019-11-29 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Nov 30 02:31:19 UTC 2019 Modified Files: src/usr.bin/make/unit-tests: varmod-edge.exp varmod-edge.mk Log Message: Add another unit test for the :M modifier To generate a diff of this commit: cvs rdiff -u -r1.1 -r1.2

CVS commit: src/usr.bin/make/unit-tests

2019-11-29 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Nov 30 02:31:19 UTC 2019 Modified Files: src/usr.bin/make/unit-tests: varmod-edge.exp varmod-edge.mk Log Message: Add another unit test for the :M modifier To generate a diff of this commit: cvs rdiff -u -r1.1 -r1.2

CVS commit: src/usr.bin/make/unit-tests

2019-11-29 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Nov 30 00:38:51 UTC 2019 Modified Files: src/usr.bin/make/unit-tests: Makefile Added Files: src/usr.bin/make/unit-tests: varmod-edge.exp varmod-edge.mk Log Message: Add unit tests for variable modifiers like :M and :N

CVS commit: src/usr.bin/make/unit-tests

2019-11-29 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Nov 30 00:38:51 UTC 2019 Modified Files: src/usr.bin/make/unit-tests: Makefile Added Files: src/usr.bin/make/unit-tests: varmod-edge.exp varmod-edge.mk Log Message: Add unit tests for variable modifiers like :M and :N

CVS commit: src/usr.bin/make

2019-09-26 Thread Simon J. Gerraty
Module Name:src Committed By: sjg Date: Thu Sep 26 21:09:55 UTC 2019 Modified Files: src/usr.bin/make: parse.c Log Message: Do not assume safe to pass NULL to realpath(3). PR: 54574 Reviewed by: buhrow To generate a diff of this commit: cvs rdiff -u -r1.232 -r1.233

CVS commit: src/usr.bin/make

2019-09-26 Thread Simon J. Gerraty
Module Name:src Committed By: sjg Date: Thu Sep 26 21:09:55 UTC 2019 Modified Files: src/usr.bin/make: parse.c Log Message: Do not assume safe to pass NULL to realpath(3). PR: 54574 Reviewed by: buhrow To generate a diff of this commit: cvs rdiff -u -r1.232 -r1.233

Re: CVS commit: src/usr.bin/make

2018-05-13 Thread Simon J. Gerraty
J. Hannken-Illjes wrote: > After this commit parallel builds take much longer. Building > amd64 release with -j16 for example goes from 45 to 380 minutes. Interesting. Removing the sleep would help there - the busy waiting issue isn't new anyway.

Re: CVS commit: src/usr.bin/make

2018-05-13 Thread J. Hannken-Illjes
> On 12. May 2018, at 20:17, Simon J. Gerraty wrote: > > Module Name: src > Committed By: sjg > Date: Sat May 12 18:17:04 UTC 2018 > > Modified Files: > src/usr.bin/make: job.c > > Log Message: > Skip setting wantToken. > > polling the job token pipe adds a

  1   2   >