Re: CVS commit: src/usr.bin/make

2020-10-26 Thread David Holland
On Sun, Oct 25, 2020 at 05:37:36PM +, Simon J. Gerraty wrote: > Modified Files: > src/usr.bin/make: main.c > src/usr.bin/make/unit-tests: varmod-match-escape.exp > > Log Message: > Skip reading .MAKE.DEPENDFILE if set to > "/dev/null" or anything starting with "no". > >

Re: CVS commit: src/usr.bin/make

2020-09-24 Thread Roland Illig
On 24.09.2020 18:02, Jonathan A. Kollasch wrote: cvs rdiff -u -r1.65 -r1.66 src/usr.bin/make/lst.h breaks build on Debian 9: In file included from /local/jakllsch/netbsd/src/usr.bin/make/make.h:158:0, from /local/jakllsch/netbsd/src/usr.bin/make/arch.c:130:

Re: CVS commit: src/usr.bin/make

2020-09-24 Thread Jonathan A. Kollasch
> cvs rdiff -u -r1.65 -r1.66 src/usr.bin/make/lst.h breaks build on Debian 9: In file included from /local/jakllsch/netbsd/src/usr.bin/make/make.h:158:0, from /local/jakllsch/netbsd/src/usr.bin/make/arch.c:130: /local/jakllsch/netbsd/src/usr.bin/make/lst.h:92:5: error: unknown

Re: CVS commit: src/usr.bin/make

2020-09-14 Thread Roland Illig
On 14.09.2020 21:05, Robert Elz wrote: Date:Mon, 14 Sep 2020 16:16:52 + From:"Roland Illig" Message-ID: <20200914161652.d4eb5f...@cvs.netbsd.org> | make(1): inline LPAREN in parse.c | | It's shorter and more readable, and the other characters don't

Re: CVS commit: src/usr.bin/make

2020-09-14 Thread Robert Elz
Date:Mon, 14 Sep 2020 16:16:52 + From:"Roland Illig" Message-ID: <20200914161652.d4eb5f...@cvs.netbsd.org> | make(1): inline LPAREN in parse.c | | It's shorter and more readable, and the other characters don't have | named constants as well. Most likely

Re: CVS commit: src/usr.bin/make

2020-08-02 Thread Roland Illig
On 02.08.2020 13:06, Simon Burge wrote: > "Roland Illig" wrote: > >> Module Name: src >> Committed By:rillig >> Date:Sun Aug 2 09:43:22 UTC 2020 >> >> Modified Files: >> >> src/usr.bin/make: var.c >> >> Log Message: >> >> make(1): use shorter local variable names >>

Re: CVS commit: src/usr.bin/make

2020-08-02 Thread Simon Burge
"Roland Illig" wrote: > Module Name: src > Committed By: rillig > Date: Sun Aug 2 09:43:22 UTC 2020 > > Modified Files: > > src/usr.bin/make: var.c > > Log Message: > > make(1): use shorter local variable names > > The c in cp was redundant since the context makes it obvious that

Re: CVS commit: src/usr.bin/make

2020-08-02 Thread Jared McNeill
On Sun, 2 Aug 2020, Roland Illig wrote: Module Name:src Committed By: rillig Date: Sun Aug 2 09:43:22 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): use shorter local variable names The c in cp was redundant since the context makes it obvious

Re: CVS commit: src/usr.bin/make

2020-07-26 Thread Christos Zoulas
In article <20200726200457.f2522f...@cvs.netbsd.org>, Roland Illig wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: rillig >Date: Sun Jul 26 20:04:57 UTC 2020 > >Modified Files: > src/usr.bin/make: Makefile > >Log Message: >make(1): explicitly add dependencies on headers >

re: CVS commit: src/usr.bin/make

2020-07-26 Thread matthew green
> In a follow-up commit, I adjusted the build scripts, and I'm doing a > full build right now. I'm pretty confident that everything works now > again, and if not, I'll fix it immediately. thanks! .mrg.

Re: CVS commit: src/usr.bin/make

2020-07-26 Thread Roland Illig
On 26.07.2020 10:29, matthew green wrote: > "Roland Illig" writes: >> Module Name: src >> Committed By:rillig >> Date:Sun Jul 26 07:15:26 UTC 2020 >> >> Modified Files: >> src/usr.bin/make: Makefile >> Added Files: >> src/usr.bin/make: lst.c >> Removed Files: >>

re: CVS commit: src/usr.bin/make

2020-07-26 Thread matthew green
"Roland Illig" writes: > Module Name: src > Committed By: rillig > Date: Sun Jul 26 07:15:26 UTC 2020 > > Modified Files: > src/usr.bin/make: Makefile > Added Files: > src/usr.bin/make: lst.c > Removed Files: > src/usr.bin/make/lst.lib: Makefile lstAppend.c lstAtEnd.c

Re: CVS commit: src/usr.bin/make

2020-07-19 Thread Izumi Tsutsui
kardel@ wrote: > nbmake currently fails to build the tree. > > config.status: creating buildmake.sh > compile arch.c > compile buf.c > compile compat.c > compile cond.c > compile dir.c > compile for.c > compile hash.c > compile job.c > compile

Re: CVS commit: src/usr.bin/make

2020-07-19 Thread Frank Kardel
nbmake currently fails to build the tree. config.status: creating buildmake.sh compile arch.c compile buf.c compile compat.c compile cond.c compile dir.c compile for.c compile hash.c compile job.c compile main.c compile make.c compile

Re: CVS commit: src/usr.bin/make

2020-07-04 Thread Joerg Sonnenberger
On Sat, Jul 04, 2020 at 03:44:07PM +, Roland Illig wrote: > Module Name: src > Committed By: rillig > Date: Sat Jul 4 15:44:07 UTC 2020 > > Modified Files: > src/usr.bin/make: var.c > > Log Message: > make(1): fix :hash modifier on 16-bit platforms > > On platforms where int

CVS commit: src/usr.bin/make/unit-tests

2019-11-29 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Nov 30 03:53:45 UTC 2019 Modified Files: src/usr.bin/make/unit-tests: varmod-edge.exp varmod-edge.mk Log Message: Demonstrate some more edge cases for the :M modifier To generate a diff of this commit: cvs rdiff -u -r1.2

CVS commit: src/usr.bin/make/unit-tests

2019-11-29 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Nov 30 03:53:45 UTC 2019 Modified Files: src/usr.bin/make/unit-tests: varmod-edge.exp varmod-edge.mk Log Message: Demonstrate some more edge cases for the :M modifier To generate a diff of this commit: cvs rdiff -u -r1.2

CVS commit: src/usr.bin/make/unit-tests

2019-11-29 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Nov 30 02:55:47 UTC 2019 Modified Files: src/usr.bin/make/unit-tests: varmod-edge.mk Log Message: Fix unit test for edge case in :M modifier To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3

CVS commit: src/usr.bin/make/unit-tests

2019-11-29 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Nov 30 02:55:47 UTC 2019 Modified Files: src/usr.bin/make/unit-tests: varmod-edge.mk Log Message: Fix unit test for edge case in :M modifier To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3

CVS commit: src/usr.bin/make/unit-tests

2019-11-29 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Nov 30 02:35:28 UTC 2019 Added Files: src/usr.bin/make/unit-tests: .cvsignore Log Message: Ignore temporary files from running the unit tests To generate a diff of this commit: cvs rdiff -u -r0 -r1.1

CVS commit: src/usr.bin/make/unit-tests

2019-11-29 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Nov 30 02:35:28 UTC 2019 Added Files: src/usr.bin/make/unit-tests: .cvsignore Log Message: Ignore temporary files from running the unit tests To generate a diff of this commit: cvs rdiff -u -r0 -r1.1

CVS commit: src/usr.bin/make/unit-tests

2019-11-29 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Nov 30 02:31:19 UTC 2019 Modified Files: src/usr.bin/make/unit-tests: varmod-edge.exp varmod-edge.mk Log Message: Add another unit test for the :M modifier To generate a diff of this commit: cvs rdiff -u -r1.1 -r1.2

CVS commit: src/usr.bin/make/unit-tests

2019-11-29 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Nov 30 02:31:19 UTC 2019 Modified Files: src/usr.bin/make/unit-tests: varmod-edge.exp varmod-edge.mk Log Message: Add another unit test for the :M modifier To generate a diff of this commit: cvs rdiff -u -r1.1 -r1.2

CVS commit: src/usr.bin/make/unit-tests

2019-11-29 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Nov 30 00:38:51 UTC 2019 Modified Files: src/usr.bin/make/unit-tests: Makefile Added Files: src/usr.bin/make/unit-tests: varmod-edge.exp varmod-edge.mk Log Message: Add unit tests for variable modifiers like :M and :N

CVS commit: src/usr.bin/make/unit-tests

2019-11-29 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Nov 30 00:38:51 UTC 2019 Modified Files: src/usr.bin/make/unit-tests: Makefile Added Files: src/usr.bin/make/unit-tests: varmod-edge.exp varmod-edge.mk Log Message: Add unit tests for variable modifiers like :M and :N

CVS commit: src/usr.bin/make

2019-09-26 Thread Simon J. Gerraty
Module Name:src Committed By: sjg Date: Thu Sep 26 21:09:55 UTC 2019 Modified Files: src/usr.bin/make: parse.c Log Message: Do not assume safe to pass NULL to realpath(3). PR: 54574 Reviewed by: buhrow To generate a diff of this commit: cvs rdiff -u -r1.232 -r1.233

CVS commit: src/usr.bin/make

2019-09-26 Thread Simon J. Gerraty
Module Name:src Committed By: sjg Date: Thu Sep 26 21:09:55 UTC 2019 Modified Files: src/usr.bin/make: parse.c Log Message: Do not assume safe to pass NULL to realpath(3). PR: 54574 Reviewed by: buhrow To generate a diff of this commit: cvs rdiff -u -r1.232 -r1.233

Re: CVS commit: src/usr.bin/make

2018-05-13 Thread Simon J. Gerraty
J. Hannken-Illjes wrote: > After this commit parallel builds take much longer. Building > amd64 release with -j16 for example goes from 45 to 380 minutes. Interesting. Removing the sleep would help there - the busy waiting issue isn't new anyway.

Re: CVS commit: src/usr.bin/make

2018-05-13 Thread J. Hannken-Illjes
> On 12. May 2018, at 20:17, Simon J. Gerraty wrote: > > Module Name: src > Committed By: sjg > Date: Sat May 12 18:17:04 UTC 2018 > > Modified Files: > src/usr.bin/make: job.c > > Log Message: > Skip setting wantToken. > > polling the job token pipe adds a

Re: CVS commit: src/usr.bin/make

2018-04-05 Thread David Holland
On Wed, Apr 04, 2018 at 08:31:11PM -0400, Christos Zoulas wrote: > Module Name: src > Committed By:christos > Date:Thu Apr 5 00:31:11 UTC 2018 > > Modified Files: > src/usr.bin/make: parse.c > > Log Message: > Be more selective about detecting a SYSV

re: CVS commit: src/usr.bin/make

2017-06-21 Thread matthew green
> > And it still does. You cannot use -VV because of getopt(3). You can use > > a different letter. The complexity is when I get this long string instead > > of the evaluated variable. > > Please do not unilaterally change behavior. Especially if it has been > discussed in the past. This is rude

Re: CVS commit: src/usr.bin/make

2017-06-19 Thread Christos Zoulas
On Jun 19, 6:58am, mar...@duskware.de (Martin Husemann) wrote: -- Subject: Re: CVS commit: src/usr.bin/make | On Sun, Jun 18, 2017 at 04:26:38PM -0400, Christos Zoulas wrote: | > As I said above "reasons other than debugging", and you can still | > get the previous "debug

Re: CVS commit: src/usr.bin/make

2017-06-19 Thread Christos Zoulas
On Jun 19, 6:58am, mar...@duskware.de (Martin Husemann) wrote: -- Subject: Re: CVS commit: src/usr.bin/make | There was a discussion way back, exactly about what the default | behaviour should be: | | http://mail-index.netbsd.org/tech-toolchain/2012/08/06/msg001900.html | | If we now want

Re: CVS commit: src/usr.bin/make

2017-06-18 Thread Martin Husemann
On Sun, Jun 18, 2017 at 02:21:42PM -0400, Christos Zoulas wrote: > 1. What needs the intermediate representation, and how it can be used? For debuging makefiles. Martin

Re: CVS commit: src/usr.bin/make

2017-06-18 Thread Christos Zoulas
On Jun 18, 7:01pm, jo...@bec.de (Joerg Sonnenberger) wrote: -- Subject: Re: CVS commit: src/usr.bin/make | On Sat, Jun 17, 2017 at 10:40:25PM -0400, Christos Zoulas wrote: | > On Jun 18, 12:36am, jo...@bec.de (Joerg Sonnenberger) wrote: | > -- Subject: Re: CVS commit: src/usr.bi

Re: CVS commit: src/usr.bin/make

2017-06-17 Thread Christos Zoulas
On Jun 18, 12:36am, jo...@bec.de (Joerg Sonnenberger) wrote: -- Subject: Re: CVS commit: src/usr.bin/make | Please do not unilaterally change behavior. Especially if it has been | discussed in the past. This is rude at best and not everyone shares your | opinion. Please explain the use case

Re: CVS commit: src/usr.bin/make

2017-06-17 Thread Joerg Sonnenberger
On Sun, Jun 18, 2017 at 12:40:20AM +0200, Kamil Rytarowski wrote: > Can we reuse show-var from pkgsrc? > > $ make show-var VARNAME=MACHINE_CPU > x86_64 It's no better than just using -V '${expr}' directly. Joerg

Re: CVS commit: src/usr.bin/make

2017-06-17 Thread Kamil Rytarowski
;>>> In article <20170617213136.ga21...@britannica.bec.de>, >>>> Joerg Sonnenberger <jo...@bec.de> wrote: >>>>> On Sat, Jun 17, 2017 at 05:28:07PM -0400, Christos Zoulas wrote: >>>>>> On Jun 17, 9:38pm, jo...@bec.de (Joerg Sonnenbe

Re: CVS commit: src/usr.bin/make

2017-06-17 Thread Christos Zoulas
.bec.de>, >> > Joerg Sonnenberger <jo...@bec.de> wrote: >> >> On Sat, Jun 17, 2017 at 05:28:07PM -0400, Christos Zoulas wrote: >> >>> On Jun 17, 9:38pm, jo...@bec.de (Joerg Sonnenberger) wrote: >> >>> -- Subject: Re: CVS commit: src/u

Re: CVS commit: src/usr.bin/make

2017-06-17 Thread Kamil Rytarowski
berger) wrote: >>> -- Subject: Re: CVS commit: src/usr.bin/make >>> >>> | Agreed, please revert. This was discussed at the time and FreeBSD >>> | behavior you have now implemented is much less useful. >>> >>> You can get the original with -V '

Re: CVS commit: src/usr.bin/make

2017-06-17 Thread Christos Zoulas
In article <20170617213136.ga21...@britannica.bec.de>, Joerg Sonnenberger <jo...@bec.de> wrote: >On Sat, Jun 17, 2017 at 05:28:07PM -0400, Christos Zoulas wrote: >> On Jun 17, 9:38pm, jo...@bec.de (Joerg Sonnenberger) wrote: >> -- Subject: Re: CVS commit: src/usr.bin/m

Re: CVS commit: src/usr.bin/make

2017-06-17 Thread Joerg Sonnenberger
On Sat, Jun 17, 2017 at 05:28:07PM -0400, Christos Zoulas wrote: > On Jun 17, 9:38pm, jo...@bec.de (Joerg Sonnenberger) wrote: > -- Subject: Re: CVS commit: src/usr.bin/make > > | Agreed, please revert. This was discussed at the time and FreeBSD > | behavior you have now implement

Re: CVS commit: src/usr.bin/make

2017-06-17 Thread Christos Zoulas
On Jun 17, 9:38pm, jo...@bec.de (Joerg Sonnenberger) wrote: -- Subject: Re: CVS commit: src/usr.bin/make | Agreed, please revert. This was discussed at the time and FreeBSD | behavior you have now implemented is much less useful. You can get the original with -V '\VAR' christos

re: CVS commit: src/usr.bin/make

2017-06-17 Thread matthew green
"Christos Zoulas" writes: > Module Name: src > Committed By: christos > Date: Sat Jun 17 15:49:56 UTC 2017 > > Modified Files: > src/usr.bin/make: main.c > > Log Message: > -V: try to expand the variable again if the value contains a variable. how do i get the original behaviour?

Re: CVS commit: src/usr.bin/make

2017-04-21 Thread Christos Zoulas
In article <20170421221544.6b4eaf...@cvs.netbsd.org>, Simon J. Gerraty wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: sjg >Date: Fri Apr 21 22:15:44 UTC 2017 > >Modified Files: > src/usr.bin/make: str.c > src/usr.bin/make/unit-tests:

Re: CVS commit: src/usr.bin/make

2017-04-21 Thread Simon J. Gerraty
Simon J. Gerraty wrote: > wrote: > > > On Tue, Apr 11, 2017 at 05:30:13PM +, Simon J. Gerraty wrote: > > > Log Message: > > > Str_Match: allow [^a-z] to behave as expected. > > > > % env A=NetBSD-7-x86_64 make -V '${A:MNetBSD-[^0-1]-i386}' > >

Re: CVS commit: src/usr.bin/make

2017-04-21 Thread Simon J. Gerraty
wrote: > On Tue, Apr 11, 2017 at 05:30:13PM +, Simon J. Gerraty wrote: > > Log Message: > > Str_Match: allow [^a-z] to behave as expected. > > % env A=NetBSD-7-x86_64 make -V '${A:MNetBSD-[^0-1]-i386}' > NetBSD-7-x86_64 Well that's interesting - thanks...

Re: CVS commit: src/usr.bin/make

2017-04-21 Thread coypu
On Tue, Apr 11, 2017 at 05:30:13PM +, Simon J. Gerraty wrote: > Log Message: > Str_Match: allow [^a-z] to behave as expected. % env A=NetBSD-7-x86_64 make -V '${A:MNetBSD-[^0-1]-i386}' NetBSD-7-x86_64

Re: CVS commit: src/usr.bin/make

2017-04-20 Thread Christos Zoulas
In article <20170420035727.ba900f...@cvs.netbsd.org>, Simon J. Gerraty wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: sjg >Date: Thu Apr 20 03:57:27 UTC 2017 > >Modified Files: > src/usr.bin/make: main.c > >Log Message: >We cannot tollerate

Re: CVS commit: src/usr.bin/make

2017-01-31 Thread Christos Zoulas
In article <20170131065424.246a2f...@cvs.netbsd.org>, Simon J. Gerraty wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: sjg >Date: Tue Jan 31 06:54:24 UTC 2017 > >Modified Files: > src/usr.bin/make: dir.c main.c > >Log Message: >Partially

Re: CVS commit: src/usr.bin/make

2017-01-14 Thread Paul Goyette
Module Name:src Committed By: sjg Date: Sat Jan 14 22:58:04 UTC 2017 Modified Files: src/usr.bin/make: make.1 var.c src/usr.bin/make/unit-tests: varmisc.exp varmisc.mk Log Message: Allow providing a utc value to :{gm,local}time Reviewed by: christos The

Re: CVS commit: src/usr.bin/make

2016-06-04 Thread Simon J. Gerraty
Joerg Sonnenberger wrote: > > This improves the worst case performance (eg examining libc with > > nothing to do) by a factor of 4. > > ...except now build.sh on !NetBSD fails immediately due to missing > strlcpy. Should be fixed... Don't know if you want to get carried away with

Re: CVS commit: src/usr.bin/make

2016-06-04 Thread Simon J. Gerraty
Joerg Sonnenberger wrote: > > This improves the worst case performance (eg examining libc with > > nothing to do) by a factor of 4. > > ...except now build.sh on !NetBSD fails immediately due to missing > strlcpy. Gah, bmake provides strlcpy... sorry about that.

Re: CVS commit: src/usr.bin/make

2016-06-03 Thread Joerg Sonnenberger
On Fri, Jun 03, 2016 at 01:21:59AM +, Simon J. Gerraty wrote: > Module Name: src > Committed By: sjg > Date: Fri Jun 3 01:21:59 UTC 2016 > > Modified Files: > src/usr.bin/make: main.c make.h meta.c nonints.h var.c > > Log Message: > Add cached_realpath() > > realpath(3) is

Re: CVS commit: src/usr.bin/make

2016-06-03 Thread Christos Zoulas
In article <20160603012159.a51b6f...@cvs.netbsd.org>, Simon J. Gerraty wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: sjg >Date: Fri Jun 3 01:21:59 UTC 2016 > >Modified Files: > src/usr.bin/make: main.c make.h meta.c nonints.h var.c > >Log

Re: CVS commit: src/usr.bin/make

2016-01-16 Thread Joerg Sonnenberger
On Sat, Jan 16, 2016 at 04:15:21PM -0800, Simon J. Gerraty wrote: > Joerg Sonnenberger wrote: > > I suspect this change broke editors/xemacs-current, which is now failing > > with: > > > > make[1]: make[1]: don't know how to make insert-data-in-exec. Stop > > I'm

Re: CVS commit: src/usr.bin/make

2016-01-16 Thread Simon J. Gerraty
Joerg Sonnenberger wrote: > I suspect this change broke editors/xemacs-current, which is now failing > with: > > make[1]: make[1]: don't know how to make insert-data-in-exec. Stop I'm guessing you are talking about a makefile that comes with emacs? I don't see anything

Re: CVS commit: src/usr.bin/make

2016-01-16 Thread Joerg Sonnenberger
On Sun, Dec 20, 2015 at 10:44:10PM +, Simon J. Gerraty wrote: > Module Name: src > Committed By: sjg > Date: Sun Dec 20 22:44:10 UTC 2015 > > Modified Files: > src/usr.bin/make: suff.c > > Log Message: > Suff_ClearSuffixes() needs to re-initialize suffNull, > otherwise its

Re: CVS commit: src/usr.bin/make

2015-12-01 Thread Joerg Sonnenberger
On Tue, Dec 01, 2015 at 07:26:08AM +, Simon J. Gerraty wrote: > Module Name: src > Committed By: sjg > Date: Tue Dec 1 07:26:08 UTC 2015 > > Modified Files: > src/usr.bin/make: var.c > > Log Message: > Avoid calling brk_string() and hence Var_Export1() on > empty strings.

Re: CVS commit: src/usr.bin/make

2015-12-01 Thread Simon J. Gerraty
Joerg Sonnenberger wrote: > > Log Message: > > Avoid calling brk_string() and hence Var_Export1() on > > empty strings. > > I'm not sure which change, but now I get fallout in the clang builds > from constructs like: Shouldn't this one since only affects exporting of

Re: CVS commit: src/usr.bin/make

2015-10-20 Thread Simon J. Gerraty
Thanks - fixed. > /work/src/usr.bin/make/var.c:2772:7: error: variable 'emsg' is used > uninitialized whenever 'if' condition is false > [-Werror,-Wsometimes-uninitialized] > if (wantit) > /work/src/usr.bin/make/var.c:2777:7: note: uninitialized use occurs here > if (emsg)

Re: CVS commit: src/usr.bin/make

2015-10-16 Thread Tobias Nygren
On Mon, 12 Oct 2015 16:48:13 + "Simon J. Gerraty" wrote: > Module Name: src > Committed By: sjg > Date: Mon Oct 12 16:48:13 UTC 2015 > > Modified Files: > src/usr.bin/make: var.c > > Log Message: > The conditional expressions used with ':?' can be expensive

Re: CVS commit: src/usr.bin/make

2015-10-06 Thread Marc Balmer
> Am 06.10.2015 um 19:36 schrieb Christos Zoulas : > > Module Name: src > Committed By: christos > Date: Tue Oct 6 17:36:25 UTC 2015 > > Modified Files: > src/usr.bin/make: var.c > > Log Message: > don't check for NULL before free() (Tilman Sauerbeck) > >

Re: CVS commit: src/usr.bin/make

2015-10-06 Thread Christos Zoulas
In article <3c6cf536-97db-4dae-966e-a3c02c505...@msys.ch>, Marc Balmer wrote: >>v->name, delim); >> -if (*freePtr) { >> -free(*freePtr); >> -*freePtr = NULL; >> -} >> +free(*freePtr); >> +*freePtr = NULL; > >is this sentinel, setting *freePtr to

Re: CVS commit: src/usr.bin/make

2014-09-09 Thread Joerg Sonnenberger
On Tue, Sep 09, 2014 at 06:18:17AM +, David A. Holland wrote: Module Name: src Committed By: dholland Date: Tue Sep 9 06:18:17 UTC 2014 Modified Files: src/usr.bin/make: main.c Log Message: Restore apb's 20140820 commit (-r1.228 of main.c): It should not be an error

Re: CVS commit: src/usr.bin/make

2014-09-09 Thread David Holland
On Tue, Sep 09, 2014 at 02:19:02PM +0200, Joerg Sonnenberger wrote: Log Message: Restore apb's 20140820 commit (-r1.228 of main.c): It should not be an error to have VAR != command that prints no output Joerg reverted a bit too enthusiastically. Thanks. I will go over the

Re: CVS commit: src/usr.bin/make

2014-09-07 Thread Christos Zoulas
In article 20140907205534.98d4...@cvs.netbsd.org, Joerg Sonnenberger source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By: joerg Date: Sun Sep 7 20:55:34 UTC 2014 Modified Files: src/usr.bin/make: compat.c lst.h main.c make.c make.h nonints.h parse.c

Re: CVS commit: src/usr.bin/make

2014-08-31 Thread Christos Zoulas
On Aug 31, 12:36am, u...@stderr.spb.ru (Valery Ushakov) wrote: -- Subject: Re: CVS commit: src/usr.bin/make | On Fri, Aug 29, 2014 at 05:27:44 -0400, Christos Zoulas wrote: | | Module Name:src | Committed By: christos | Date: Fri Aug 29 09:27:44 UTC 2014

Re: CVS commit: src/usr.bin/make

2014-08-30 Thread Valery Ushakov
On Fri, Aug 29, 2014 at 05:27:44 -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Fri Aug 29 09:27:44 UTC 2014 Modified Files: src/usr.bin/make: parse.c Log Message: undo eating the trailing backslash now that the shell has been fixed. IIRC,

Re: CVS commit: src/usr.bin/make

2013-09-04 Thread David Holland
On Tue, Sep 03, 2013 at 09:58:55PM +0200, Alan Barrett wrote: On Mon, 02 Sep 2013, Simon J. Gerraty wrote: Modified Files: src/usr.bin/make: compat.c Log Message: Do not apply shellErrFlag unless errCheck is true. To generate a diff of this commit: cvs rdiff -u -r1.92

Re: CVS commit: src/usr.bin/make

2013-09-03 Thread Alan Barrett
On Mon, 02 Sep 2013, Simon J. Gerraty wrote: Modified Files: src/usr.bin/make: compat.c Log Message: Do not apply shellErrFlag unless errCheck is true. To generate a diff of this commit: cvs rdiff -u -r1.92 -r1.93 src/usr.bin/make/compat.c Will this fix PR 45356? --apb (Alan

Re: CVS commit: src/usr.bin/make

2013-07-16 Thread Ryo ONODERA
Hi, From: Christos Zoulas chris...@netbsd.org, Date: Tue, 16 Jul 2013 10:00:53 -0400 Module Name: src Committed By: christos Date: Tue Jul 16 14:00:53 UTC 2013 Modified Files: src/usr.bin/make: main.c make.1 var.c Log Message: More gmake compatibility: 1. add -w flag

Re: CVS commit: src/usr.bin/make

2013-07-16 Thread Christos Zoulas
On Jul 16, 11:20pm, ryo...@yk.rim.or.jp (Ryo ONODERA) wrote: -- Subject: Re: CVS commit: src/usr.bin/make | With this change, I have gotten following errors. | I think -lutil is needed. No, I fixed it... I was supposed to use bmake_foo() not efoo(). christos

Re: CVS commit: src/usr.bin/make

2013-07-16 Thread Ryo ONODERA
From: chris...@zoulas.com (Christos Zoulas), Date: Tue, 16 Jul 2013 10:23:04 -0400 On Jul 16, 11:20pm, ryo...@yk.rim.or.jp (Ryo ONODERA) wrote: -- Subject: Re: CVS commit: src/usr.bin/make | With this change, I have gotten following errors. | I think -lutil is needed. No, I fixed

Re: CVS commit: src/usr.bin/make

2013-07-16 Thread David Holland
On Tue, Jul 16, 2013 at 08:00:56PM +, Simon J. Gerraty wrote: Modified Files: src/usr.bin/make: var.c Log Message: When a var is set in the CMD context, it prevents the same name being set in GLOBAL context. We should also delete any such variable in GLOBAL context, else

Re: CVS commit: src/usr.bin/make

2013-07-10 Thread Christos Zoulas
In article krbu04$2j1$1...@ger.gmane.org, Christos Zoulas chris...@astron.com wrote: Module Name: src Committed By: sjg Date: Sat Jul 6 18:19:17 UTC 2013 Modified Files: src/usr.bin/make: main.c var.c Log Message: If using gmake's MAKELEVEL; use it the same way Now you put it

Re: CVS commit: src/usr.bin/make

2013-07-10 Thread Ryo ONODERA
From: chris...@astron.com (Christos Zoulas), Date: Wed, 10 Jul 2013 13:08:49 + (UTC) In article krbu04$2j1$1...@ger.gmane.org, Christos Zoulas chris...@astron.com wrote: Module Name: src Committed By:sjg Date:Sat Jul 6 18:19:17 UTC 2013 Modified Files:

Re: CVS commit: src/usr.bin/make

2013-07-10 Thread Christos Zoulas
In article 20130710.232445.202823964487691297.ryo...@yk.rim.or.jp, Ryo ONODERA ryo...@yk.rim.or.jp wrote: From: chris...@astron.com (Christos Zoulas), Date: Wed, 10 Jul 2013 13:08:49 + (UTC) In article krbu04$2j1$1...@ger.gmane.org, Christos Zoulas chris...@astron.com wrote: Module Name:

Re: CVS commit: src/usr.bin/make

2013-07-10 Thread Ryo ONODERA
From: chris...@astron.com (Christos Zoulas), Date: Wed, 10 Jul 2013 15:08:39 + (UTC) In article 20130710.232445.202823964487691297.ryo...@yk.rim.or.jp, Ryo ONODERA ryo...@yk.rim.or.jp wrote: From: chris...@astron.com (Christos Zoulas), Date: Wed, 10 Jul 2013 13:08:49 + (UTC) In

Re: CVS commit: src/usr.bin/make

2013-07-07 Thread Christos Zoulas
Module Name: src Committed By: sjg Date: Sat Jul 6 18:19:17 UTC 2013 Modified Files: src/usr.bin/make: main.c var.c Log Message: If using gmake's MAKELEVEL; use it the same way Now you put it back the way it was before which is wrong. Gmake does not behave this way. Before

Re: CVS commit: src/usr.bin/make

2013-06-18 Thread Christos Zoulas
In article 20130618200609.a234...@cvs.netbsd.org, Simon J. Gerraty source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By: sjg Date: Tue Jun 18 20:06:09 UTC 2013 Modified Files: src/usr.bin/make: main.c make.h var.c Log Message: Use a #define for the

Re: CVS commit: src/usr.bin/make

2013-03-08 Thread Christos Zoulas
On Mar 8, 5:21pm, lu...@netbsd.org (Luke Mewburn) wrote: -- Subject: Re: CVS commit: src/usr.bin/make | Removing the source files would be an epic, | if brutal, method of fixing the problem. :-) I think it is still possible to do this with the code I added :-) christos

Re: CVS commit: src/usr.bin/make

2013-03-07 Thread Luke Mewburn
On Tue, Mar 05, 2013 at 08:35:42PM +, Christos Zoulas wrote: | In article CADbF7eeV2AcmiVZJzuxsN8gvwQHfMLYVN63gRdXpv8-jV=x...@mail.gmail.com, | Masao Uebayashi uebay...@gmail.com wrote: | -=-=-=-=-=- | | I like make(1) to exit when stale depend is found. | | I was thinking of

Re: CVS commit: src/usr.bin/make

2013-03-06 Thread Christos Zoulas
In article 20130306073342.gg4...@apb-laptoy.apb.alt.za, Alan Barrett a...@cequrux.com wrote: On Tue, 05 Mar 2013, Christos Zoulas wrote: Modified Files: src/usr.bin/make: dir.c job.c job.h make.1 parse.c Log Message: Add a .STALE special target that gets invoked when dependency files

Re: CVS commit: src/usr.bin/make

2013-03-05 Thread Masao Uebayashi
I like make(1) to exit when stale depend is found. On Tue, Mar 5, 2013 at 11:04 AM, Christos Zoulas chris...@netbsd.orgwrote: Module Name:src Committed By: christos Date: Tue Mar 5 02:04:11 UTC 2013 Modified Files: src/usr.bin/make: dir.c job.c parse.c Log

Re: CVS commit: src/usr.bin/make

2013-03-05 Thread Christos Zoulas
In article CADbF7eeV2AcmiVZJzuxsN8gvwQHfMLYVN63gRdXpv8-jV=x...@mail.gmail.com, Masao Uebayashi uebay...@gmail.com wrote: -=-=-=-=-=- I like make(1) to exit when stale depend is found. I was thinking of adding a .STALE target, so you can do what you like, for example: .STALE: rm -f

Re: CVS commit: src/usr.bin/make

2013-03-05 Thread Alan Barrett
On Tue, 05 Mar 2013, Christos Zoulas wrote: Modified Files: src/usr.bin/make: dir.c job.c job.h make.1 parse.c Log Message: Add a .STALE special target that gets invoked when dependency files contain stail entries. Please discuss this sort of thing first. There may be a way to solve

Re: CVS commit: src/usr.bin/make

2013-01-26 Thread David Laight
On Sat, Jan 26, 2013 at 10:53:00AM -0500, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Sat Jan 26 15:53:00 UTC 2013 Modified Files: src/usr.bin/make: job.c main.c Log Message: Check read and write errors to avoid warnings from linux. XXX: Should

Re: CVS commit: src/usr.bin/make

2013-01-26 Thread Christos Zoulas
In article 20130126205325.gd28...@snowdrop.l8s.co.uk, David Laight da...@l8s.co.uk wrote: I'd have been tempted to do: int stupid_glibc_wont_let_us_ignore_the_result_of_write(int fd, const void *buf, size_t len) { return write(fd, buf, len); } It is the linux headers :-) I'm not sure,

re: CVS commit: src/usr.bin/make

2013-01-26 Thread matthew green
Not much point writing an error is you'vejust failed to write to stderr! i disagree -- ktrace sees it and thus it is not entirely lost :)

Re: CVS commit: src/usr.bin/make

2012-11-03 Thread David Laight
On Sat, Nov 03, 2012 at 02:25:14AM +, Simon J. Gerraty wrote: Module Name: src Committed By: sjg Date: Sat Nov 3 02:25:13 UTC 2012 Modified Files: src/usr.bin/make: cond.c Log Message: Allow cond_state[] to grow. The need is rare, but real. 128 nested conditional

Re: CVS commit: src/usr.bin/make

2012-08-31 Thread Christos Zoulas
In article 20120831070037.6fb7a17...@cvs.netbsd.org, Simon J. Gerraty source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By: sjg Date: Fri Aug 31 07:00:36 UTC 2012 Modified Files: src/usr.bin/make: main.c Log Message: Cast sizeof() to int, which is

Re: CVS commit: src/usr.bin/make

2011-06-10 Thread Matt Thomas
On Jun 10, 2011, at 4:57 PM, Simon J. Gerraty wrote: Module Name: src Committed By: sjg Date: Fri Jun 10 23:57:39 UTC 2011 Modified Files: src/usr.bin/make: meta.c Log Message: size_t on amd64 doesn't like %u, use a cast. why not use %zu?

Re: CVS commit: src/usr.bin/make

2011-06-10 Thread Jukka Ruohonen
On Fri, Jun 10, 2011 at 11:57:39PM +, Simon J. Gerraty wrote: Module Name: src Committed By: sjg Date: Fri Jun 10 23:57:39 UTC 2011 Modified Files: src/usr.bin/make: meta.c Log Message: size_t on amd64 doesn't like %u, use a cast. %zu? - Jukka.

re: CVS commit: src/usr.bin/make

2011-06-10 Thread matthew green
On Fri, Jun 10, 2011 at 11:57:39PM +, Simon J. Gerraty wrote: Module Name:src Committed By: sjg Date: Fri Jun 10 23:57:39 UTC 2011 Modified Files: src/usr.bin/make: meta.c Log Message: size_t on amd64 doesn't like %u, use a cast. %zu?

Re: CVS commit: src/usr.bin/make

2011-05-18 Thread David Laight
On Wed, May 18, 2011 at 02:43:03AM +, David Holland wrote: On Tue, May 17, 2011 at 09:56:52PM +, David Laight wrote: cvs rdiff -u -r1.51 -r1.52 src/usr.bin/make/Makefile uh, did you mean to commit that? No - I've changed it back. David -- David Laight: da...@l8s.co.uk

Re: CVS commit: src/usr.bin/make

2011-05-17 Thread David Holland
On Tue, May 17, 2011 at 09:56:52PM +, David Laight wrote: cvs rdiff -u -r1.51 -r1.52 src/usr.bin/make/Makefile uh, did you mean to commit that? -- David A. Holland dholl...@netbsd.org

Re: CVS commit: src/usr.bin/make

2011-04-06 Thread Mindaugas Rasiukevicius
Joerg Sonnenberger jo...@netbsd.org wrote: Module Name: src Committed By: joerg Date: Thu Apr 7 01:40:02 UTC 2011 Modified Files: src/usr.bin/make: make.1 var.c src/usr.bin/make/unit-tests: Makefile test.exp Added Files: src/usr.bin/make/unit-tests: hash

Re: CVS commit: src/usr.bin/make

2011-04-06 Thread Joerg Sonnenberger
On Thu, Apr 07, 2011 at 02:49:31AM +0100, Mindaugas Rasiukevicius wrote: Joerg Sonnenberger jo...@netbsd.org wrote: Module Name:src Committed By: joerg Date: Thu Apr 7 01:40:02 UTC 2011 Modified Files: src/usr.bin/make: make.1 var.c

Re: CVS commit: src/usr.bin/make

2010-11-26 Thread Martin Husemann
On Thu, Nov 25, 2010 at 04:31:10PM -0500, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Thu Nov 25 21:31:09 UTC 2010 Modified Files: src/usr.bin/make: arch.c compat.c make.c make.h targ.c Log Message: Instead of keeping around the mtime of the

  1   2   >