CVS commit: src/usr.bin/who
Module Name:src
Committed By: mrg
Date: Fri Oct 4 11:43:07 UTC 2019
Modified Files:
src/usr.bin/who: utmpentry.c
Log Message:
revert previous; i meant to test first and if you read the comment
immediately above, you can see it is done safely and on purpose.
To generate a diff of this commit:
cvs rdiff -u -r1.19 -r1.20 src/usr.bin/who/utmpentry.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/usr.bin/who/utmpentry.c
diff -u src/usr.bin/who/utmpentry.c:1.19 src/usr.bin/who/utmpentry.c:1.20
--- src/usr.bin/who/utmpentry.c:1.19 Fri Oct 4 11:40:43 2019
+++ src/usr.bin/who/utmpentry.c Fri Oct 4 11:43:07 2019
@@ -1,4 +1,4 @@
-/* $NetBSD: utmpentry.c,v 1.19 2019/10/04 11:40:43 mrg Exp $ */
+/* $NetBSD: utmpentry.c,v 1.20 2019/10/04 11:43:07 mrg Exp $ */
/*-
* Copyright (c) 2002 The NetBSD Foundation, Inc.
@@ -31,7 +31,7 @@
#include
#ifndef lint
-__RCSID("$NetBSD: utmpentry.c,v 1.19 2019/10/04 11:40:43 mrg Exp $");
+__RCSID("$NetBSD: utmpentry.c,v 1.20 2019/10/04 11:43:07 mrg Exp $");
#endif
#include
@@ -283,9 +283,9 @@ getentry(struct utmpentry *e, struct utm
* reason we use the size of the _source_ as the length
* argument.
*/
- (void)strncpy(e->name, up->ut_name, sizeof(e->name));
- (void)strncpy(e->line, up->ut_line, sizeof(e->line));
- (void)strncpy(e->host, up->ut_host, sizeof(e->host));
+ (void)strncpy(e->name, up->ut_name, sizeof(up->ut_name));
+ (void)strncpy(e->line, up->ut_line, sizeof(up->ut_line));
+ (void)strncpy(e->host, up->ut_host, sizeof(up->ut_host));
e->tv.tv_sec = up->ut_time;
e->tv.tv_usec = 0;
@@ -314,9 +314,9 @@ getentryx(struct utmpentry *e, struct ut
* reason we use the size of the _source_ as the length
* argument.
*/
- (void)strncpy(e->name, up->ut_name, sizeof(e->name));
- (void)strncpy(e->line, up->ut_line, sizeof(e->line));
- (void)strncpy(e->host, up->ut_host, sizeof(e->host));
+ (void)strncpy(e->name, up->ut_name, sizeof(up->ut_name));
+ (void)strncpy(e->line, up->ut_line, sizeof(up->ut_line));
+ (void)strncpy(e->host, up->ut_host, sizeof(up->ut_host));
e->tv = up->ut_tv;
e->pid = up->ut_pid;
CVS commit: src/usr.bin/who
Module Name:src Committed By: mrg Date: Fri Oct 4 11:43:07 UTC 2019 Modified Files: src/usr.bin/who: utmpentry.c Log Message: revert previous; i meant to test first and if you read the comment immediately above, you can see it is done safely and on purpose. To generate a diff of this commit: cvs rdiff -u -r1.19 -r1.20 src/usr.bin/who/utmpentry.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/who
Module Name:src Committed By: mrg Date: Fri Oct 4 11:40:43 UTC 2019 Modified Files: src/usr.bin/who: utmpentry.c Log Message: use destination buffer size not source buffer size for strncpy len. To generate a diff of this commit: cvs rdiff -u -r1.18 -r1.19 src/usr.bin/who/utmpentry.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/who
Module Name:src
Committed By: mrg
Date: Fri Oct 4 11:40:43 UTC 2019
Modified Files:
src/usr.bin/who: utmpentry.c
Log Message:
use destination buffer size not source buffer size for strncpy len.
To generate a diff of this commit:
cvs rdiff -u -r1.18 -r1.19 src/usr.bin/who/utmpentry.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/usr.bin/who/utmpentry.c
diff -u src/usr.bin/who/utmpentry.c:1.18 src/usr.bin/who/utmpentry.c:1.19
--- src/usr.bin/who/utmpentry.c:1.18 Sat Nov 21 15:01:43 2015
+++ src/usr.bin/who/utmpentry.c Fri Oct 4 11:40:43 2019
@@ -1,4 +1,4 @@
-/* $NetBSD: utmpentry.c,v 1.18 2015/11/21 15:01:43 christos Exp $ */
+/* $NetBSD: utmpentry.c,v 1.19 2019/10/04 11:40:43 mrg Exp $ */
/*-
* Copyright (c) 2002 The NetBSD Foundation, Inc.
@@ -31,7 +31,7 @@
#include
#ifndef lint
-__RCSID("$NetBSD: utmpentry.c,v 1.18 2015/11/21 15:01:43 christos Exp $");
+__RCSID("$NetBSD: utmpentry.c,v 1.19 2019/10/04 11:40:43 mrg Exp $");
#endif
#include
@@ -283,9 +283,9 @@ getentry(struct utmpentry *e, struct utm
* reason we use the size of the _source_ as the length
* argument.
*/
- (void)strncpy(e->name, up->ut_name, sizeof(up->ut_name));
- (void)strncpy(e->line, up->ut_line, sizeof(up->ut_line));
- (void)strncpy(e->host, up->ut_host, sizeof(up->ut_host));
+ (void)strncpy(e->name, up->ut_name, sizeof(e->name));
+ (void)strncpy(e->line, up->ut_line, sizeof(e->line));
+ (void)strncpy(e->host, up->ut_host, sizeof(e->host));
e->tv.tv_sec = up->ut_time;
e->tv.tv_usec = 0;
@@ -314,9 +314,9 @@ getentryx(struct utmpentry *e, struct ut
* reason we use the size of the _source_ as the length
* argument.
*/
- (void)strncpy(e->name, up->ut_name, sizeof(up->ut_name));
- (void)strncpy(e->line, up->ut_line, sizeof(up->ut_line));
- (void)strncpy(e->host, up->ut_host, sizeof(up->ut_host));
+ (void)strncpy(e->name, up->ut_name, sizeof(e->name));
+ (void)strncpy(e->line, up->ut_line, sizeof(e->line));
+ (void)strncpy(e->host, up->ut_host, sizeof(e->host));
e->tv = up->ut_tv;
e->pid = up->ut_pid;
CVS commit: src/usr.bin/who
Module Name:src Committed By: sevan Date: Sun Sep 1 18:46:22 UTC 2019 Modified Files: src/usr.bin/who: who.1 Log Message: Update URL To generate a diff of this commit: cvs rdiff -u -r1.24 -r1.25 src/usr.bin/who/who.1 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/usr.bin/who
Module Name:src Committed By: sevan Date: Sun Sep 1 18:46:22 UTC 2019 Modified Files: src/usr.bin/who: who.1 Log Message: Update URL To generate a diff of this commit: cvs rdiff -u -r1.24 -r1.25 src/usr.bin/who/who.1 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/usr.bin/who/who.1 diff -u src/usr.bin/who/who.1:1.24 src/usr.bin/who/who.1:1.25 --- src/usr.bin/who/who.1:1.24 Fri May 11 16:36:57 2018 +++ src/usr.bin/who/who.1 Sun Sep 1 18:46:22 2019 @@ -1,4 +1,4 @@ -.\" $NetBSD: who.1,v 1.24 2018/05/11 16:36:57 sevan Exp $ +.\" $NetBSD: who.1,v 1.25 2019/09/01 18:46:22 sevan Exp $ .\" .\" Copyright (c) 1986, 1991, 1993 .\" The Regents of the University of California. All rights reserved. @@ -29,7 +29,7 @@ .\" .\" @(#)who.1 8.2 (Berkeley) 12/30/93 .\" -.Dd May 11, 2018 +.Dd September 1, 2019 .Dt WHO 1 .Os .Sh NAME @@ -194,4 +194,4 @@ A .Nm utility appeared in .At v1 : -.Lk http://cm.bell-labs.com/cm/cs/who/dmr/pdfs/man14.pdf +.Lk https://www.bell-labs.com/usr/dmr/www/man14.pdf
