Re: Detecting typos in makefiles (was: Re: CVS commit: src/share/mk)

2023-01-15 Thread Simon Gerraty
On Sun, 15 Jan 2023 19:14:14 +0100, Roland Illig writes: >It is really unfortunate that make didn't catch this typo by itself. > >.if ${MACHINE_ARCH} =3D=3D "x86_64" || \ > ${MACHINE_ARCH} =3D=3D "i386" || \ > ${MACHINE_ARCH} =3D=3D "alpha" || \\ > !empty(MACHINE_ARCH:Maarch64*) || \ >

Detecting typos in makefiles (was: Re: CVS commit: src/share/mk)

2023-01-15 Thread Roland Illig
Am 15.01.2023 um 11:51 schrieb Nick Hudson: Module Name:src Committed By: skrll Date: Sun Jan 15 10:51:04 UTC 2023 Modified Files: src/share/mk: bsd.own.mk Log Message: Really switch aarch64 and sparc binutils to 2.39 To generate a diff of this commit: cvs rdiff -u

Re: Detecting typos in makefiles (was: Re: CVS commit: src/share/mk)

2023-01-15 Thread Christos Zoulas
That's very funny. Yes I think we should warn. I don't think that \\ should be a valid variable name. Best, christos > On Jan 15, 2023, at 1:14 PM, Roland Illig wrote: > > Am 15.01.2023 um 11:51 schrieb Nick Hudson: >> Module Name: src >> Committed By:skrll >> Date:Sun