On Fri, Aug 19, 2011 at 07:49:55PM +1000, matthew green wrote:
If it helped, then it would also be fine to change
const char * format = %s;
to
const char * const format = %s;
but it doesn't help.
martin discovered that this one works:
const char fmt[] = ...;
Which is
On Fri, 19 Aug 2011, David Holland wrote:
I think we should make no changes to appease the compiler in
this case. [...]
I would lean towards fixing the ones that can be fixed
noninvasively; [...]
The compiler is being really stupid, and I don't like making
invasive changes to appease it.
On Fri, Aug 19, 2011 at 08:07:11AM +0200, Alan Barrett wrote:
If it helped, then it would also be fine to change
const char * format = %s;
to
const char * const format = %s;
but it doesn't help.
but:
const char format[] =%s;
works just fine.
Martin
On Fri, 19 Aug 2011, David Holland wrote:
I think we should make no changes to appease the compiler in
this case. [...]
I would lean towards fixing the ones that can be fixed
noninvasively; [...]
The compiler is being really stupid, and I don't like making
invasive changes to
Module Name:src
Committed By: christos
Date: Thu Aug 18 17:02:49 UTC 2011
Modified Files:
src/sys/modules/spdmem: Makefile
Log Message:
document non-literal string format
Rather than sweeping the issue under the rug, wouldn't it be better to
actually fix the problem?
On Thu, Aug 18, 2011 at 11:11:20AM -0700, Paul Goyette wrote:
Module Name:src
Committed By: christos
Date: Thu Aug 18 17:02:49 UTC 2011
Modified Files:
src/sys/modules/spdmem: Makefile
Log Message:
document non-literal string format
Rather than sweeping the
On Thu, Aug 18, 2011 at 01:51:33PM -0500, David Young wrote:
Rather than sweeping the issue under the rug, wouldn't it be better to
actually fix the problem?
See attached diff which replaces the variable format with a
literal #define string ...
I think we should make no
