Re: Wrong PR e-mails
From: Thomas Klausner t...@giga.or.at, Date: Thu, 14 May 2015 22:45:27 +0200 On Thu, May 14, 2015 at 07:53:23PM +0200, Thomas Klausner wrote: On Wed, May 13, 2015 at 02:16:00PM +, Christos Zoulas wrote: No, I feel sorry for you. Perhaps we should modify the script so that if it finds more than 2 PR matches it makes the commit fail, or it does not add anymore... I suggest the attached patch (with more than 3 PRs, but you can easily change it to more than 2). Ok, this is committed now. Thank you very much. I will help me (and other developers). -- Ryo ONODERA // ryo...@yk.rim.or.jp PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB FD1B F404 27FA C7D1 15F3
Re: Wrong PR e-mails
On Wed, May 13, 2015 at 02:16:00PM +, Christos Zoulas wrote:
No, I feel sorry for you. Perhaps we should modify the script so that
if it finds more than 2 PR matches it makes the commit fail, or it does
not add anymore...
I suggest the attached patch (with more than 3 PRs, but you can
easily change it to more than 2).
Thomas
Index: log_accum
===
RCS file: /cvsroot/CVSROOT/log_accum,v
retrieving revision 1.112
diff -u -r1.112 log_accum
--- log_accum 21 Oct 2014 13:21:08 - 1.112
+++ log_accum 14 May 2015 17:52:23 -
@@ -433,6 +433,8 @@
@prs = map { if (!$last || $last ne $_) { $last = $_ ; } else { () } }
sort @prs;
# discard PR numbers below 1 because they are probably accidents like
github pull-requests
@prs = grep { $_ 1 } @prs;
+# if more than 3 PRs are cited, assume it's an accident like a pkgsrc
changelog
+@prs = () if (@prs 3);
return @prs;
}
Re: Wrong PR e-mails
In article 20150514175323.gg5...@danbala.tuwien.ac.at, Thomas Klausner t...@giga.or.at wrote: -=-=-=-=-=- On Wed, May 13, 2015 at 02:16:00PM +, Christos Zoulas wrote: No, I feel sorry for you. Perhaps we should modify the script so that if it finds more than 2 PR matches it makes the commit fail, or it does not add anymore... I suggest the attached patch (with more than 3 PRs, but you can easily change it to more than 2). maybe also 10 :-) christos
Re: Wrong PR e-mails
In article mj2phg$ckp$1...@ger.gmane.org, Christos Zoulas chris...@astron.com wrote: In article 20150514175323.gg5...@danbala.tuwien.ac.at, Thomas Klausner t...@giga.or.at wrote: -=-=-=-=-=- On Wed, May 13, 2015 at 02:16:00PM +, Christos Zoulas wrote: No, I feel sorry for you. Perhaps we should modify the script so that if it finds more than 2 PR matches it makes the commit fail, or it does not add anymore... I suggest the attached patch (with more than 3 PRs, but you can easily change it to more than 2). maybe also 10 :-) Meaning not accept PR numbers 10 christos
Re: Wrong PR e-mails
On Thu, May 14, 2015 at 07:53:23PM +0200, Thomas Klausner wrote: On Wed, May 13, 2015 at 02:16:00PM +, Christos Zoulas wrote: No, I feel sorry for you. Perhaps we should modify the script so that if it finds more than 2 PR matches it makes the commit fail, or it does not add anymore... I suggest the attached patch (with more than 3 PRs, but you can easily change it to more than 2). Ok, this is committed now. Thomas
Re: Wrong PR e-mails
From: chris...@astron.com (Christos Zoulas), Date: Wed, 13 May 2015 14:16:00 + (UTC) In article 20150513.225456.981040990877913520.ryo...@yk.rim.or.jp, Ryo ONODERA ryo...@yk.rim.or.jp wrote: Hi, Sorry for my wrong PR e-mails. I have removed all my bads from gnats. Sorry again. No, I feel sorry for you. Perhaps we should modify the script so that if it finds more than 2 PR matches it makes the commit fail, or it does not add anymore... Thanks for your support. Such script may help me. Thank you very much. christos -- Ryo ONODERA // ryo...@yk.rim.or.jp PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB FD1B F404 27FA C7D1 15F3
Wrong PR e-mails
Hi, Sorry for my wrong PR e-mails. I have removed all my bads from gnats. Sorry again. -- Ryo ONODERA // ryo...@yk.rim.or.jp PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB FD1B F404 27FA C7D1 15F3
Re: Wrong PR e-mails
In article 20150513.225456.981040990877913520.ryo...@yk.rim.or.jp, Ryo ONODERA ryo...@yk.rim.or.jp wrote: Hi, Sorry for my wrong PR e-mails. I have removed all my bads from gnats. Sorry again. No, I feel sorry for you. Perhaps we should modify the script so that if it finds more than 2 PR matches it makes the commit fail, or it does not add anymore... christos
