re: CVS commit: src/external/mpl/bind/dist
> I think this is a misunderstanding. indeed. sorry for the noise and mis-request. .mrg.
Re: CVS commit: src/external/mpl/bind/dist
06.04.2021 20:55:54 matthew green : >> Module Name: src >> Committed By: rillig >> Date: Mon Apr 5 11:27:04 UTC 2021 >> >> Modified Files: >> src/external/mpl/bind/dist/bin/check: check-tool.c named-checkconf.c >> named-checkzone.c > [ ... ] >> src/external/mpl/bind/dist/lib/ns/tests: nstest.h >> >> Log Message: >> bind: remove unnecessary CONSTCOND comments >> >> Since lint1/tree.c 1.202 from 2021-01-31, lint no longer needs the >> /*CONSTCOND*/ for do-while-0 "loops". >> >> No functional change. > > please do not make such changes to upstream code. it should > be obvious why.. > > please revert this and all following changes. I think this is a misunderstanding. My recent commits made our local copy as similar to the upstream code as possible. Before my changes, our copy differed because we had inserted the /*CONSTCOND*/ comments, plus a few workarounds for bugs in lint. Since these bugs have been fixed a few days ago, we no longer need these comments and workarounds, therefore I removed them. When I wrote the commit message, I didn't mention these details since in that very moment they were obvious to me. In that moment I didn't think about this possible misunderstanding. Roland
Re: CVS commit: src/external/mpl/bind/dist
In article <9374.1617735...@splode.eterna.com.au>, matthew green wrote: >> Module Name: src >> Committed By:rillig >> Date:Mon Apr 5 11:27:04 UTC 2021 >> >> Modified Files: >> src/external/mpl/bind/dist/bin/check: check-tool.c named-checkconf.c >> named-checkzone.c >[ ... ] >> src/external/mpl/bind/dist/lib/ns/tests: nstest.h >> >> Log Message: >> bind: remove unnecessary CONSTCOND comments >> >> Since lint1/tree.c 1.202 from 2021-01-31, lint no longer needs the >> /*CONSTCOND*/ for do-while-0 "loops". >> >> No functional change. > >please do not make such changes to upstream code. it should >be obvious why.. > >please revert this and all following changes. This is reversion of our local changes to match upstream. So those patches actually do what you are asking :-) christos
re: CVS commit: src/external/mpl/bind/dist
> Module Name: src > Committed By: rillig > Date: Mon Apr 5 11:27:04 UTC 2021 > > Modified Files: > src/external/mpl/bind/dist/bin/check: check-tool.c named-checkconf.c > named-checkzone.c [ ... ] > src/external/mpl/bind/dist/lib/ns/tests: nstest.h > > Log Message: > bind: remove unnecessary CONSTCOND comments > > Since lint1/tree.c 1.202 from 2021-01-31, lint no longer needs the > /*CONSTCOND*/ for do-while-0 "loops". > > No functional change. please do not make such changes to upstream code. it should be obvious why.. please revert this and all following changes. .mrg.
