Re: CVS commit: src/sys/dev/pci

2020-10-16 Thread SAITOH Masanobu
On 2020/10/16 14:53, SAITOH Masanobu wrote: Module Name:src Committed By: msaitoh Date: Fri Oct 16 05:53:40 UTC 2020 Modified Files: src/sys/dev/pci: if_wm.c Log Message: Fixes a problem that the attach function reported "wm_gmii_setup_phytype: Unknown PHY model.

Re: CVS commit: src/sys/dev/pci

2020-10-12 Thread Michael
Hello, On Sun, 11 Oct 2020 21:41:57 + "Julian Coleman" wrote: > Module Name: src > Committed By: jdc > Date: Sun Oct 11 21:41:57 UTC 2020 > > Modified Files: > src/sys/dev/pci: radeonfb.c > > Log Message: ... > don't ignore the bottom 200 lines of the display (for no

Re: CVS commit: src/sys/dev/pci

2020-07-17 Thread Jaromír Doleček
One of the things which need to be done is calling the if_ioctl always with the IFNET_LOCK() held. Right now it sometimes is, and other times it is not, so it's not possible to rely on it and KASSERT(). As for bnx(4) I did just some basic fixes around making it work with MSI(-X), since I don't

Re: CVS commit: src/sys/dev/pci

2020-07-17 Thread Jason Thorpe
> On Jul 17, 2020, at 3:50 PM, matthew green wrote: > > any chance you can look at NET_MPSAFE here etc? :) I have a bunch of local changes for this in one of my trees, and I hope to get back to it after netbsd-10 branches. -- thorpej

re: CVS commit: src/sys/dev/pci

2020-07-17 Thread matthew green
"Jaromir Dolecek" writes: > Module Name: src > Committed By: jdolecek > Date: Fri Jul 17 09:48:21 UTC 2020 > > Modified Files: > src/sys/dev/pci: if_bnx.c > > Log Message: > re-enable MSI/MSI-X, the TX timeouts were caused by the IFF_OACTIVE handling, > which was fixed in previous

Re: [virtio] Re: CVS commit: src/sys/dev/pci

2020-05-31 Thread Maxime Villard
Le 01/06/2020 à 03:23, Shoichi Yamaguchi a écrit : Hi, On Wed, May 27, 2020 at 8:47 PM Shoichi Yamaguchi wrote: I modified virtio(4) not to allocate unused memory. I guess it fixes the issue. Could you check this? I confirmed your closing the report on syzbot.

Re: [virtio] Re: CVS commit: src/sys/dev/pci

2020-05-31 Thread Shoichi Yamaguchi
Hi, On Wed, May 27, 2020 at 8:47 PM Shoichi Yamaguchi wrote: > > I modified virtio(4) not to allocate unused memory. > I guess it fixes the issue. > > Could you check this? I confirmed your closing the report on syzbot.

Re: [virtio] Re: CVS commit: src/sys/dev/pci

2020-05-27 Thread Shoichi Yamaguchi
Hi, On Wed, May 27, 2020 at 2:20 AM Maxime Villard wrote: > > Hi, > I don't know if this is related to your changes, but kMSan detected one uninit > variable in virtio 3h ago: > > https://syzkaller.appspot.com/text?tag=CrashReport=12084ef610 > > [ 153.4370851] panic: MSan:

[virtio] Re: CVS commit: src/sys/dev/pci

2020-05-26 Thread Maxime Villard
Hi, I don't know if this is related to your changes, but kMSan detected one uninit variable in virtio 3h ago: https://syzkaller.appspot.com/text?tag=CrashReport=12084ef610 [ 153.4370851] panic: MSan: Uninitialized Kmem Memory From virtio_pci_setup_interrupts() [

Re: CVS commit: src/sys/dev/pci

2020-05-20 Thread Sevan Janiyan
On 20/05/2020 21:18, Sevan Janiyan wrote: > Bump rcs tag which was missed in r1.9 That should've been r1.10 Sevan

Re: CVS commit: src/sys/dev/pci

2020-01-14 Thread Masanobu SAITOH
On 2020/01/10 15:59, Jason Thorpe wrote: > > >> On Jan 9, 2020, at 9:02 PM, Masanobu SAITOH wrote: >> >> The reason why I moved stge_softc to if_stgereg.h was that ipgphy.c >> required to check stge's chip revision. So, if there is no any objection, >> I'll make new if_stgevar.h and share it

Re: CVS commit: src/sys/dev/pci

2020-01-09 Thread Jason Thorpe
> On Jan 9, 2020, at 9:02 PM, Masanobu SAITOH wrote: > > The reason why I moved stge_softc to if_stgereg.h was that ipgphy.c > required to check stge's chip revision. So, if there is no any objection, > I'll make new if_stgevar.h and share it with if_stge.c and ipgphy.c. That seems fine.

Re: CVS commit: src/sys/dev/pci

2020-01-09 Thread Masanobu SAITOH
On 2020/01/10 13:13, Jason Thorpe wrote: > > >> On Jan 9, 2020, at 6:11 PM, Masanobu SAITOH wrote: >> >> >> Before my change, struct stge_softc is already in if_stgereg.h, >> so I had thought it would be OK to move to it. > > Ah, I don't think I would have put it there when I wrote the driver

Re: CVS commit: src/sys/dev/pci

2020-01-09 Thread Jason Thorpe
> On Jan 9, 2020, at 6:11 PM, Masanobu SAITOH wrote: > > > Before my change, struct stge_softc is already in if_stgereg.h, > so I had thought it would be OK to move to it. Ah, I don't think I would have put it there when I wrote the driver originally, so it must have been moved there at

re: CVS commit: src/sys/dev/pci

2020-01-09 Thread matthew green
> Two options: > > a) Move some structs (including struct stge_softc) and defines > to if_stge.c > > b) Move them to new if_stgevar.h i've always preferred: - fooreg.h and foovar.h exist only when more than 1 file use them - fooreg.h ONLY has hardware constructs - foovar.h

Re: CVS commit: src/sys/dev/pci

2020-01-09 Thread Masanobu SAITOH
On 2020/01/09 23:08, Jason Thorpe wrote: > > >> On Jan 9, 2020, at 2:54 AM, SAITOH Masanobu wrote: >> >> Module Name: src >> Committed By:msaitoh >> Date:Thu Jan 9 10:54:16 UTC 2020 >> >> Modified Files: >> src/sys/dev/pci: if_stge.c if_stgereg.h >> >> Log Message:

Re: CVS commit: src/sys/dev/pci

2020-01-09 Thread Jason Thorpe
> On Jan 9, 2020, at 2:54 AM, SAITOH Masanobu wrote: > > Module Name: src > Committed By: msaitoh > Date: Thu Jan 9 10:54:16 UTC 2020 > > Modified Files: > src/sys/dev/pci: if_stge.c if_stgereg.h > > Log Message: > Reduce diff against OpenBSD. No functional change. > > -

Re: CVS commit: src/sys/dev/pci

2019-11-17 Thread Kimihiro Nonaka
It only prevent null pointer dereference. On Mon, Nov 18, 2019 at 3:18 PM wrote: > > On Mon, Nov 18, 2019 at 06:15:27AM +, m...@netbsd.org wrote: > > > Modified files: > > > > > > Index: src/sys/dev/pci/if_mcx.c > > > diff -u src/sys/dev/pci/if_mcx.c:1.5 src/sys/dev/pci/if_mcx.c:1.6 > > >

Re: CVS commit: src/sys/dev/pci

2019-11-17 Thread maya
> Modified files: > > Index: src/sys/dev/pci/if_mcx.c > diff -u src/sys/dev/pci/if_mcx.c:1.5 src/sys/dev/pci/if_mcx.c:1.6 > --- src/sys/dev/pci/if_mcx.c:1.5 Thu Oct 17 15:57:56 2019 > +++ src/sys/dev/pci/if_mcx.c Mon Nov 18 04:40:05 2019 > @@ -1,4 +1,4 @@ > -/* $NetBSD: if_mcx.c,v 1.5

Re: CVS commit: src/sys/dev/pci

2019-10-19 Thread Tom Ivar Helbekkmo
Tobias Nygren writes: > Yep, MSI works now. According to the PCI Express Base Specification, > Revision 3.0, table 7-3, having the bus master bit set to 0 disables > MSI. Asmedia chip seems to have a bug which makes DMA work regardless ... Yup - it works just fine! Well done! :) ahcisata0:

Re: CVS commit: src/sys/dev/pci

2019-10-18 Thread Tobias Nygren
On Fri, 18 Oct 2019 20:32:53 +0200 Tom Ivar Helbekkmo wrote: > Tobias Nygren writes: > > > Module Name:src > > Committed By: tnn > > Date: Fri Oct 18 17:16:50 UTC 2019 > > > > Modified Files: > > src/sys/dev/pci: ahcisata_pci.c > > > > Log Message: > > ahcisata:

Re: CVS commit: src/sys/dev/pci

2019-10-18 Thread Tom Ivar Helbekkmo
Tobias Nygren writes: > Module Name: src > Committed By: tnn > Date: Fri Oct 18 17:16:50 UTC 2019 > > Modified Files: > src/sys/dev/pci: ahcisata_pci.c > > Log Message: > ahcisata: make sure bus mastering and memory space are actually enabled > > This makes the "ROCKPro64 PCI-e to

Re: CVS commit: src/sys/dev/pci/ixgbe

2019-06-27 Thread Masanobu SAITOH
On 2019/06/27 18:56, SAITOH Masanobu wrote: > Module Name: src > Committed By: msaitoh > Date: Thu Jun 27 09:56:39 UTC 2019 > > Modified Files: > src/sys/dev/pci/ixgbe: ixv.c > > Log Message: > Don't call set_vfta() if any VLAN is attached. s/is/is not/ > XXX pullup-8. > > >

Re: CVS commit: src/sys/dev/pci

2019-05-08 Thread Constantine A. Murenin
Hi, Has there been any progress on this since 2017-12-03? I've noticed that ips(4) is missing the man-page, only has a single revision on ips.c, and is not connected to the build (neither to ALL nor GENERIC). Is it intentional for this driver to remain in tree? (Does it even still

Re: CVS commit: src/sys/dev/pci

2019-03-22 Thread Michael
Hello, On Fri, 22 Mar 2019 17:07:10 + m...@netbsd.org wrote: > On Fri, Mar 22, 2019 at 07:41:41AM +, Martin Husemann wrote: > > @@ -1402,6 +1402,9 @@ radeonfb_loadbios(struct radeonfb_softc > > pci_find_rom(pa, romt, romh, romsz, PCI_ROM_CODE_TYPE_X86, , > > >sc_biossz); > >

Re: CVS commit: src/sys/dev/pci

2019-03-22 Thread maya
On Fri, Mar 22, 2019 at 07:41:41AM +, Martin Husemann wrote: > @@ -1402,6 +1402,9 @@ radeonfb_loadbios(struct radeonfb_softc > pci_find_rom(pa, romt, romh, romsz, PCI_ROM_CODE_TYPE_X86, , > >sc_biossz); > > + if (sc->sc_biossz == 0 || sc->sc_bios == NULL) > +

re: CVS commit: src/sys/dev/pci

2019-03-21 Thread matthew green
"Michael Lorenz" writes: > Module Name: src > Committed By: macallan > Date: Wed Mar 20 23:05:19 UTC 2019 > > Modified Files: > src/sys/dev/pci: radeonfb.c > > Log Message: > add code to read disabled ROMs, adapted from xf86-video-radeon > With this radeonfb does The Right

Re: CVS commit: src/sys/dev/pci/ixgbe

2019-03-13 Thread Masanobu SAITOH
On 2019/03/13 19:02, SAITOH Masanobu wrote: Module Name:src Committed By: msaitoh Date: Wed Mar 13 10:02:13 UTC 2019 Modified Files: src/sys/dev/pci/ixgbe: ixgbe.c Log Message: - Fix a bug that the VLAN HW filter function is not correctly disabled s/VLAN HW

Re: CVS commit: src/sys/dev/pci

2019-02-06 Thread Masanobu SAITOH
On 2019/02/07 13:03, SAITOH Masanobu wrote: Module Name:src Committed By: msaitoh Date: Thu Feb 7 04:03:25 UTC 2019 Modified Files: src/sys/dev/pci: if_wm.c Log Message: Fix a bug that WOL didn't work on some chips since if_wm.c rev. 1.60. s/1.60/1.610/ Set

Re: CVS commit: src/sys/dev/pci

2019-01-29 Thread Christoph Badura
On Tue, Jan 29, 2019 at 04:16:30PM +0900, Masanobu SAITOH wrote: > On 2019/01/29 2:51, Christoph Badura wrote: > >Wouldn't it be better to prevent this kind of bug in the future by putting > >the decision which method to use into a switch-statement and have the > >compiler worry about ordering?

Re: CVS commit: src/sys/dev/pci

2019-01-29 Thread Masanobu SAITOH
On 2019/01/28 15:33, Jason Thorpe wrote: On Jan 28, 2019, at 8:11 AM, Masanobu SAITOH wrote: On 2019/01/28 15:07, Jason Thorpe wrote: Doesn’t it seem a little dangerous to just blindly enable? You mean it should be enable only when the secondary bridge is configured correctly? Both

Re: CVS commit: src/sys/dev/pci

2019-01-28 Thread Masanobu SAITOH
On 2019/01/29 2:51, Christoph Badura wrote: On Fri, Jan 25, 2019 at 08:04:07AM +, SAITOH Masanobu wrote: Modified Files: src/sys/dev/pci: if_wm.c Log Message: 80003's SERDES is not the same as 82575's but the same as legacy devices. Use the old methods on 80003. XXX The reason

Re: CVS commit: src/sys/dev/pci

2019-01-28 Thread Christoph Badura
On Fri, Jan 25, 2019 at 08:04:07AM +, SAITOH Masanobu wrote: > Modified Files: > src/sys/dev/pci: if_wm.c > > Log Message: > 80003's SERDES is not the same as 82575's but the same as legacy devices. > Use the old methods on 80003. > > XXX The reason why this bug existed is that our

Re: CVS commit: src/sys/dev/pci

2019-01-27 Thread Frank Kardel
Hi! Great, that did it - no more immediately visible device deficiencies. com* work wm1 works radeon still spits errors [10.941427] kern error: [drm:(/src/NetBSD/cur/src/sys/external/bsd/drm2/dist/drm/radeon/radeon_uvd_v1_0.c:345)uvd_v1_0_start] *ERROR* UVD not responding, trying to

Re: CVS commit: src/sys/dev/pci

2019-01-27 Thread Jason Thorpe
> On Jan 28, 2019, at 8:11 AM, Masanobu SAITOH wrote: > > On 2019/01/28 15:07, Jason Thorpe wrote: >> Doesn’t it seem a little dangerous to just blindly enable? > > You mean it should be enable only when the secondary bridge is configured > correctly? > > Both FreeBSD and OpenBSD blindly

Re: CVS commit: src/sys/dev/pci

2019-01-27 Thread Masanobu SAITOH
On 2019/01/28 15:07, Jason Thorpe wrote: Doesn’t it seem a little dangerous to just blindly enable? You mean it should be enable only when the secondary bridge is configured correctly? Both FreeBSD and OpenBSD blindly enabled it. One of the difference between NetBSD and others is that they

Re: CVS commit: src/sys/dev/pci

2019-01-27 Thread Jason Thorpe
Doesn’t it seem a little dangerous to just blindly enable? -- thorpej Sent from my iPhone. > On Jan 28, 2019, at 6:09 AM, SAITOH Masanobu wrote: > > Module Name:src > Committed By:msaitoh > Date:Mon Jan 28 04:09:51 UTC 2019 > > Modified Files: >src/sys/dev/pci: ppb.c > >

Re: CVS commit: src/sys/dev/pci

2019-01-27 Thread Masanobu SAITOH
Hi. On 2019/01/28 4:05, Frank Kardel wrote: Hi, that made all devices being recognized during boot with UEFI - good. We seem closer, but not there yet (for my main board at least). There is still an issue with interrupts (or dma - see missing bus master in pci differences). It seems

Re: CVS commit: src/sys/dev/pci

2019-01-27 Thread Frank Kardel
Hi, that made all devices being recognized during boot with UEFI - good. We seem closer, but not there yet (for my main board at least). There is still an issue with interrupts (or dma - see missing bus master in pci differences). It seems device interrupts via ioapic don't get

Re: CVS commit: src/sys/dev/pci

2019-01-25 Thread Christos Zoulas
In article , Masanobu SAITOH wrote: > > I didn't know it! I've changed with it now. > > Thanks. Thank you! christos

Re: CVS commit: src/sys/dev/pci

2019-01-24 Thread Masanobu SAITOH
On 2019/01/25 3:08, Christos Zoulas wrote: In article <20190124045004.c9f48f...@cvs.netbsd.org>, SAITOH Masanobu wrote: -=-=-=-=-=- Module Name:src Committed By: msaitoh Date: Thu Jan 24 04:50:04 UTC 2019 Modified Files: src/sys/dev/pci: if_wm.c Log Message: No

Re: CVS commit: src/sys/dev/pci

2019-01-24 Thread Christos Zoulas
In article <20190124045004.c9f48f...@cvs.netbsd.org>, SAITOH Masanobu wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: msaitoh >Date: Thu Jan 24 04:50:04 UTC 2019 > >Modified Files: > src/sys/dev/pci: if_wm.c > >Log Message: >No functional change intended: >- Use "do {}

Re: CVS commit: src/sys/dev/pci

2018-11-30 Thread Nick Hudson
On 30/11/2018 17:47, Jaromir Dolecek wrote: Module Name:src Committed By: jdolecek Date: Fri Nov 30 17:47:54 UTC 2018 Modified Files: src/sys/dev/pci: ahcisata_pci.c xhci_pci.c Log Message: simplify intr establish code - rely on pci_intr_alloc() to allow also MSI-X, and

Re: CVS commit: src/sys/dev/pci

2018-11-02 Thread Masanobu SAITOH
On 2018/11/02 17:16, SAITOH Masanobu wrote: Module Name:src Committed By: msaitoh Date: Fri Nov 2 08:16:49 UTC 2018 Modified Files: src/sys/dev/pci: if_wm.c Log Message: - Add missing wm_gate_hw_phy_config_ich8lan(false) in wm_phy_post_reset() on PCH2.

Re: CVS commit: src/sys/dev/pci

2018-11-02 Thread Masanobu SAITOH
On 2018/11/02 17:04, SAITOH Masanobu wrote: Module Name:src Committed By: msaitoh Date: Fri Nov 2 08:04:42 UTC 2018 Modified Files: src/sys/dev/pci: if_wm.c Log Message: Fix a PCH2 specific bug that wrong register value can be read when boot. When a wrong value is

Re: CVS commit: src/sys/dev/pci

2018-10-31 Thread Masanobu SAITOH
On 2018/11/01 1:11, Jared D. McNeill wrote: Module Name:src Committed By: jmcneill Date: Wed Oct 31 16:11:29 UTC 2018 Modified Files: src/sys/dev/pci: xhci_pci.c Log Message: Add MSI-X support. Some xHCI chips support multi-vector MSI or MSI-X. Each vector can be

Re: CVS commit: src/sys/dev/pci

2018-09-14 Thread Jonathan A. Kollasch
On Fri, Sep 14, 2018 at 06:46:47PM +, Jonathan A. Kollasch wrote: > Module Name: src > Committed By: jakllsch > Date: Fri Sep 14 18:46:47 UTC 2018 > > Modified Files: > src/sys/dev/pci: if_msk.c if_mskvar.h if_skreg.h > > Log Message: > msk(4): add 64-bit DMA support > > >

Re: CVS commit: src/sys/dev/pci/ixgbe

2018-07-03 Thread Masanobu SAITOH
On 2018/07/03 13:02, SAITOH Masanobu wrote: Module Name:src Committed By: msaitoh Date: Tue Jul 3 04:02:07 UTC 2018 Modified Files: src/sys/dev/pci/ixgbe: ixgbe.c Log Message: Remove nmbclusters check. A big problem is that the number of RX descriptor unexpectedly

Re: CVS commit: src/sys/dev/pci

2018-06-08 Thread Ryo ONODERA
Hi, From: Kengo NAKAHARA , Date: Fri, 8 Jun 2018 20:20:03 +0900 > Hi, > > Sorry, I checked it fixed panic only. iwm.c:r1.81 and r1.82 fix this problem > at my environment. > > Could you try latest kernel with these commits? Thank you very much for your quick fix. It works fine now. >

Re: CVS commit: src/sys/dev/pci

2018-06-08 Thread Kengo NAKAHARA
Hi, Sorry, I checked it fixed panic only. iwm.c:r1.81 and r1.82 fix this problem at my environment. Could you try latest kernel with these commits? Thanks, On 2018/06/09 3:14, Ryo ONODERA wrote: > Hi, > > This change causes the following error and I cannot use iwm(4) device > anymore. >

Re: CVS commit: src/sys/dev/pci

2018-06-08 Thread Ryo ONODERA
Hi, This change causes the following error and I cannot use iwm(4) device anymore. Could you take a look at my problem? $ ifconfig iwm0 ifconfig: SIOCGIFFLAGS iwm0: Device not configured dmesg is here: (snip) iwm0 at pci2 dev 0 function 0: vendor 8086 product 24fd (rev. 0x78) iwm0: interrupting

Re: CVS commit: src/sys/dev/pci/ixgbe

2018-05-07 Thread Masanobu SAITOH
On 2018/05/07 16:56, Masanobu SAITOH wrote: Hi. On 2018/05/03 17:38, Frank Kardel wrote: Hi, I am now seeing that packet reception stops. tcpdump will only show outgoing packets and no incoming packets. ifconfig ixgX down ifconfig ixgX up gets things going again. Code from 2018-02-24 was

Re: CVS commit: src/sys/dev/pci/ixgbe

2018-05-07 Thread Masanobu SAITOH
Hi. On 2018/05/03 17:38, Frank Kardel wrote: Hi, I am now seeing that packet reception stops. tcpdump will only show outgoing packets and no incoming packets. ifconfig ixgX down ifconfig ixgX up gets things going again. Code from 2018-02-24 was fine and I think even code shortly before

Re: CVS commit: src/sys/dev/pci/ixgbe

2018-05-03 Thread Frank Kardel
Hi, I am now seeing that packet reception stops. tcpdump will only show outgoing packets and no incoming packets. ifconfig ixgX down ifconfig ixgX up gets things going again. Code from 2018-02-24 was fine and I think even code shortly before this commit was fine, but there was the mbuf

Re: CVS commit: src/sys/dev/pci/ixgbe

2018-05-03 Thread Frank Kardel
Hi, I am now seeing that packet reception stops. tcpdump will only show outgoing packets and no incoming packets. ifconfig ixgX down ifconfig ixgX up gets things going again. Code from 2018-02-24 was fine and I think even code shortly before this commit was fine, but there was the mbuf

Re: CVS commit: src/sys/dev/pci/ixgbe

2018-04-04 Thread Masanobu SAITOH
On 2018/04/04 17:13, SAITOH Masanobu wrote: Module Name:src Committed By: msaitoh Date: Wed Apr 4 08:13:07 UTC 2018 Modified Files: src/sys/dev/pci/ixgbe: if_bypass.c if_fdir.c if_sriov.c ix_txrx.c ixgbe.c ixgbe.h ixgbe_82598.c ixgbe_82598.h ixgbe_82599.c

Re: CVS commit: src/sys/dev/pci

2018-01-16 Thread maya
Hi maxv, there is a similar code fragment in ic/bwfm.c:bwfm_scan_node. I am not sure what I'm looking at. Could it be wrong too? Thanks. On Tue, Jan 16, 2018 at 07:05:25AM +, Maxime Villard wrote: > Module Name: src > Committed By: maxv > Date: Tue Jan 16 07:05:25 UTC 2018 > >

Re: CVS commit: src/sys/dev/pci

2017-11-30 Thread Masanobu SAITOH
On 2017/11/30 12:53, SAITOH Masanobu wrote: Module Name:src Committed By: msaitoh Date: Thu Nov 30 03:53:24 UTC 2017 Modified Files: src/sys/dev/pci: if_wm.c Log Message: Don't allocate MSI-X interrupt on 82583. 82583 chip has a MSI-X capability in the PCI

Re: CVS commit: src/sys/dev/pci/ixgbe

2017-11-23 Thread Masanobu SAITOH
On 2017/11/23 0:15, SAITOH Masanobu wrote: Module Name:src Committed By: msaitoh Date: Wed Nov 22 15:15:09 UTC 2017 Modified Files: src/sys/dev/pci/ixgbe: if_bypass.c ixgbe.c ixgbe.h Log Message: Fix a bug that bypass adapter's sysctls aren't set. Tested with

Re: CVS commit: src/sys/dev/pci/ixgbe

2017-06-27 Thread Masanobu SAITOH
On 2017/06/27 19:33, SAITOH Masanobu wrote: Module Name:src Committed By: msaitoh Date: Tue Jun 27 10:33:09 UTC 2017 Modified Files: src/sys/dev/pci/ixgbe: ixgbe.c Log Message: Fix a bug of ixg(4)'s media setting. Before: ifconfig ixg0 media 100baseTX -> advertise

Re: CVS commit: src/sys/dev/pci

2017-02-01 Thread Taylor R Campbell
> Date: Thu, 2 Feb 2017 03:57:21 + > From: co...@sdf.org > > On Thu, Feb 02, 2017 at 03:41:22AM +, Jonathan A. Kollasch wrote: > > @@ -432,6 +433,10 @@ wpi_detach(device_t self, int flags __un > > pci_intr_disestablish(sc->sc_pct, sc->sc_ih); > > sc->sc_ih = NULL;

Re: CVS commit: src/sys/dev/pci

2017-02-01 Thread coypu
On Thu, Feb 02, 2017 at 03:41:22AM +, Jonathan A. Kollasch wrote: > @@ -432,6 +433,10 @@ wpi_detach(device_t self, int flags __un > pci_intr_disestablish(sc->sc_pct, sc->sc_ih); > sc->sc_ih = NULL; > } > + if (sc->sc_pihp != NULL) { > +

Re: CVS commit: src/sys/dev/pci

2016-12-15 Thread Christos Zoulas
In article <58524a1b.5060...@netbsd.org>, Nick Hudson wrote: >On 12/14/16 22:21, Christos Zoulas wrote: >> Module Name: src >> Committed By:christos >> Date:Wed Dec 14 22:21:13 UTC 2016 >> >> Modified Files: >> src/sys/dev/pci: if_sk.c >> >> Log

Re: CVS commit: src/sys/dev/pci

2016-12-14 Thread Nick Hudson
On 12/14/16 22:21, Christos Zoulas wrote: Module Name:src Committed By: christos Date: Wed Dec 14 22:21:13 UTC 2016 Modified Files: src/sys/dev/pci: if_sk.c Log Message: Tidy up and make it look like the other drivers. Isn't ether_ioctl and an ifflags_cb (see

Re: CVS commit: src/sys/dev/pci

2016-11-27 Thread Masanobu SAITOH
On 2016/11/28 11:23, SAITOH Masanobu wrote: Module Name:src Committed By: msaitoh Date: Mon Nov 28 02:23:33 UTC 2016 Modified Files: src/sys/dev/pci: files.pci src/sys/dev/pci/ixgbe: ixgbe.c ixgbe.h Added Files: src/sys/dev/pci/ixgbe: ix_txrx.c Log

Re: CVS commit: src/sys/dev/pci

2016-11-26 Thread coypu
On Sun, Nov 27, 2016 at 12:15:56AM +0900, Kimihiro Nonaka wrote: > Hi, > > 2016-11-26 17:29 GMT+09:00 : > > > This strangely causes fallpoint for sandpoint because: > > sandpoint/include/pci_machdep.h:38:#define __HAVE_PCI_MSI_MSIX > > Does it really? > > fixed > >

Re: CVS commit: src/sys/dev/pci

2016-11-26 Thread Kimihiro Nonaka
Hi, 2016-11-26 17:29 GMT+09:00 : > This strangely causes fallpoint for sandpoint because: > sandpoint/include/pci_machdep.h:38:#define __HAVE_PCI_MSI_MSIX > Does it really? fixed http://mail-index.netbsd.org/source-changes/2016/11/26/msg079370.html regards, -- Kimihiro

Re: CVS commit: src/sys/dev/pci

2016-11-26 Thread coypu
This strangely causes fallpoint for sandpoint because: sandpoint/include/pci_machdep.h:38:#define __HAVE_PCI_MSI_MSIX Does it really? Failure at http://releng.netbsd.org/builds/HEAD/201611252110Z/sandpoint.build.failed if_re_pci.o: In function `re_pci_detach': if_re_pci.c:(.text+0x70):

Re: CVS commit: src/sys/dev/pci

2016-11-16 Thread Michael
On Wed, 16 Nov 2016 22:05:19 + "Michael Lorenz" wrote: > Module Name: src > Committed By: macallan > Date: Wed Nov 16 22:05:19 UTC 2016 > > Modified Files: > src/sys/dev/pci: voyager.c > > Log Message: > add more plumbing to pass a clockframe around so

Re: CVS commit: src/sys/dev/pci

2016-11-01 Thread Christos Zoulas
On Nov 2, 9:02am, p...@whooppee.com (Paul Goyette) wrote: -- Subject: Re: CVS commit: src/sys/dev/pci | Even in the non-overflow case, if you write x-1 chars (not including the | trailing NUL) to a buffer of size x, the updated value of len will be 1 | (and dest would point to the last valid

Re: CVS commit: src/sys/dev/pci

2016-11-01 Thread Paul Goyette
On Tue, 1 Nov 2016, Christos Zoulas wrote: On Nov 2, 8:49am, p...@whooppee.com (Paul Goyette) wrote: -- Subject: Re: CVS commit: src/sys/dev/pci | > Why *len = 1 here? Shouldn't it be 0 since there is no more room left? | | No. :) | | The maximum number of characters actually writ

Re: CVS commit: src/sys/dev/pci

2016-11-01 Thread Christos Zoulas
On Nov 2, 8:49am, p...@whooppee.com (Paul Goyette) wrote: -- Subject: Re: CVS commit: src/sys/dev/pci | > Why *len = 1 here? Shouldn't it be 0 since there is no more room left? | | No. :) | | The maximum number of characters actually written by vsnprintf() will | never exceed (len - 1).

Re: CVS commit: src/sys/dev/pci

2016-11-01 Thread Paul Goyette
On Wed, 2 Nov 2016, Christos Zoulas wrote: In article <20161102003956.35d12f...@cvs.netbsd.org>, Paul Goyette wrote: -=-=-=-=-=- + /* Handle overflow */ + if ((size_t)count >= *len) { + *dest += *len - 1; + *len = 1; Why

Re: CVS commit: src/sys/dev/pci

2016-11-01 Thread Christos Zoulas
In article <20161102003956.35d12f...@cvs.netbsd.org>, Paul Goyette wrote: >-=-=-=-=-=- > >+ /* Handle overflow */ >+ if ((size_t)count >= *len) { >+ *dest += *len - 1; >+ *len = 1; Why *len = 1 here? Shouldn't it be 0 since there

Re: CVS commit: src/sys/dev/pci

2016-10-30 Thread Christos Zoulas
On Oct 30, 6:24pm, p...@whooppee.com (Paul Goyette) wrote: -- Subject: Re: CVS commit: src/sys/dev/pci | One more revision. This one updates the length parameter as well as the | dest pointer, so the caller doesn't need to recalculate on each call. | | I've also changed it to return an int

Re: CVS commit: src/sys/dev/pci

2016-10-30 Thread Paul Goyette
On Fri, 28 Oct 2016, Paul Goyette wrote: Attached is a revised patch, which has a prototype/signature much more similar to snprintf(), more appropriate variable types, and improved comments/documentation. I'll plan on committing this sometime late next week... One more revision. This one

Re: CVS commit: src/sys/dev/pci

2016-10-28 Thread Christos Zoulas
On Oct 28, 1:18pm, p...@whooppee.com (Paul Goyette) wrote: -- Subject: Re: CVS commit: src/sys/dev/pci | snappendprintf() seemed a rather unwieldly function name, so I called it | snappendf()! :-) I read this like snapper at first. | The attached diffs implement this function and use

Re: CVS commit: src/sys/dev/pci

2016-10-28 Thread Paul Goyette
... or write a function that appends and moves the pointer, like snappendprintf(char **dest, const char *end, fmt, ...) snappendprintf() seemed a rather unwieldly function name, so I called it snappendf()! The attached diffs implement this function and use in throughout pci_devinfo().

Re: CVS commit: src/sys/dev/pci

2016-10-27 Thread Paul Goyette
... I think that perhaps a variant that returns the number of characters appended would be more useful. like if (len >= max) dest = end; else dest += len; but, I would leave the whole thing alone instead :-) or write a function that appends and moves the pointer, like

Re: CVS commit: src/sys/dev/pci

2016-10-26 Thread Paul Goyette
On Wed, 26 Oct 2016, Paul Goyette wrote: HOWEVER, Looking at dev_untokenstring() it would appear that there is a potential problem there! We have cp = buf + strlcat(buf, words + *token, len - 2); cp[0] = ' '; cp[1] = '\0'; Since strlcat(3)

Re: CVS commit: src/sys/dev/pci

2016-10-25 Thread Paul Goyette
On Wed, 26 Oct 2016, Christos Zoulas wrote: In article , Paul Goyette wrote: On Wed, 26 Oct 2016, matthew green wrote: i think you're right that the 'cp' manipulation is the problem. snprintf() will return the

Re: CVS commit: src/sys/dev/pci

2016-10-25 Thread Taylor R Campbell
Date: Wed, 26 Oct 2016 06:10:39 +0800 (PHT) From: Paul Goyette There's only 9 snprintf() calls. I could simply provide a macro: #define ADD_TEXT(dest, end, format, ...) \ {\

Re: CVS commit: src/sys/dev/pci

2016-10-25 Thread Christos Zoulas
In article , Paul Goyette wrote: >On Wed, 26 Oct 2016, matthew green wrote: > >> i think you're right that the 'cp' manipulation is the problem. >> snprintf() will return the "desired" size, so upon the first >> attempted

re: CVS commit: src/sys/dev/pci

2016-10-25 Thread Paul Goyette
On Wed, 26 Oct 2016, matthew green wrote: i think you're right that the 'cp' manipulation is the problem. snprintf() will return the "desired" size, so upon the first attempted overflow the 'cp' is moved beyond 'ep', and then the next snprintf() gets a negative aka extremely massive value for

re: CVS commit: src/sys/dev/pci

2016-10-25 Thread Paul Goyette
On Wed, 26 Oct 2016, matthew green wrote: "Paul Goyette" writes: Module Name:src Committed By: pgoyette Date: Tue Oct 25 05:43:40 UTC 2016 Modified Files: src/sys/dev/pci: pci_verbose.h Log Message: Increase max string length for PCI Product names. Affects only

re: CVS commit: src/sys/dev/pci

2016-10-25 Thread matthew green
> We currently have a few product names that exceed the old limit, and > this is triggering an SSP check in pci_devinfo(). This commit doesn't > directly address the SSP issue, but pushes the can down the road... i think you're right that the 'cp' manipulation is the problem. snprintf() will

re: CVS commit: src/sys/dev/pci

2016-10-25 Thread matthew green
"Paul Goyette" writes: > Module Name: src > Committed By: pgoyette > Date: Tue Oct 25 05:43:40 UTC 2016 > > Modified Files: > src/sys/dev/pci: pci_verbose.h > > Log Message: > Increase max string length for PCI Product names. Affects only kernels > with PCIVERBOSE (or

Re: CVS commit: src/sys/dev/pci

2016-06-19 Thread David Holland
On Sun, Jun 19, 2016 at 06:58:17AM +, David A. Holland wrote: > Modified Files: > src/sys/dev/pci: arcmsr.c > > Log Message: > Broaden the #if NBIO > 0 block. Should fix broken emips build. Erm: "evbppc" -- David A. Holland dholl...@netbsd.org

Re: CVS commit: src/sys/dev/pci

2015-11-06 Thread NONAKA Kimihiro
2015-11-07 7:11 GMT+09:00 matthew green : > "NONAKA Kimihiro" writes: >> Module Name: src >> Committed By: nonaka >> Date: Fri Nov 6 14:22:17 UTC 2015 >> >> Modified Files: >> src/sys/dev/pci: if_iwm.c if_iwmvar.h if_rtwn.c if_rtwnreg.h rtsx_pci.c >> >> Log

re: CVS commit: src/sys/dev/pci

2015-11-06 Thread matthew green
"NONAKA Kimihiro" writes: > Module Name: src > Committed By: nonaka > Date: Fri Nov 6 14:22:17 UTC 2015 > > Modified Files: > src/sys/dev/pci: if_iwm.c if_iwmvar.h if_rtwn.c if_rtwnreg.h rtsx_pci.c > > Log Message: > Always use pci_intr_alloc(9)/pci_intr_release(9). doesn't this

Re: CVS commit: src/sys/dev/pci

2015-11-06 Thread Taylor R Campbell
Date: Sat, 07 Nov 2015 09:11:23 +1100 from: matthew green "NONAKA Kimihiro" writes: > Modified Files: >src/sys/dev/pci: if_iwm.c if_iwmvar.h if_rtwn.c if_rtwnreg.h rtsx_pci.c > > Log Message: > Always use pci_intr_alloc(9)/pci_intr_release(9).

Re: CVS commit: src/sys/dev/pci

2015-08-25 Thread Antti Kantee
On 25/08/15 06:54, matthew green wrote: Antti Kantee writes: Module Name:src Committed By: pooka Date: Mon Aug 24 23:52:18 UTC 2015 Modified Files: src/sys/dev/pci: if_iwn.c Log Message: Remove #ifdef INET code. Por que? Because opt_inet.h was not included and #ifdef

re: CVS commit: src/sys/dev/pci

2015-08-25 Thread matthew green
Antti Kantee writes: Module Name: src Committed By: pooka Date: Mon Aug 24 23:52:18 UTC 2015 Modified Files: src/sys/dev/pci: if_iwn.c Log Message: Remove #ifdef INET code. Por que? Because opt_inet.h was not included and #ifdef INET was just a fancy way of saying

Re: CVS commit: src/sys/dev/pci

2015-06-15 Thread Christos Zoulas
In article 557e89ae.8070...@execsw.org, Masanobu SAITOH msai...@execsw.org wrote: I thought it's not required to wait API was fixed and committed. I think is better to wait or ask before committing when there is doubt. To support only MSI is easy, but MSI-X is not. This commit includes not

Re: CVS commit: src/sys/dev/pci

2015-06-15 Thread Masanobu SAITOH
On 2015/06/14 5:42, Christos Zoulas wrote: In article 20150613154758.6971...@cvs.netbsd.org, SAITOH Masanobu source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By:msaitoh Date:Sat Jun 13 15:47:58 UTC 2015 Modified Files:

Re: CVS commit: src/sys/dev/pci

2015-06-13 Thread Christos Zoulas
In article 20150613154758.6971...@cvs.netbsd.org, SAITOH Masanobu source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By: msaitoh Date: Sat Jun 13 15:47:58 UTC 2015 Modified Files: src/sys/dev/pci: if_wm.c if_wmreg.h Log Message: Add MSI/MSI-X support

Re: CVS commit: src/sys/dev/pci

2015-05-01 Thread Masanobu SAITOH
On 2015/05/01 1:09, SAITOH Masanobu wrote: Module Name:src Committed By: msaitoh Date: Thu Apr 30 16:09:06 UTC 2015 Modified Files: src/sys/dev/pci: if_bge.c if_bgereg.h Log Message: Use another firmware command in bge_asf_driver_up(). This change fixes a bug that

Re: CVS commit: src/sys/dev/pci

2015-04-14 Thread Martin Husemann
Ooops, I accidently didn't cc the list: - Forwarded message from Martin Husemann mar...@duskware.de - Date: Tue, 7 Apr 2015 22:30:23 +0200 From: Martin Husemann mar...@duskware.de To: Masanobu SAITOH msai...@execsw.org Subject: Re: CVS commit: src/sys/dev/pci In-Reply-To: 5523b0f9.6000

Re: CVS commit: src/sys/dev/pci

2015-04-07 Thread Masanobu SAITOH
Hi, Martin. On 2015/04/06 16:38, Martin Husemann wrote: Module Name:src Committed By: martin Date: Mon Apr 6 07:38:17 UTC 2015 Modified Files: src/sys/dev/pci: if_bge.c Log Message: Make sure to halt (not just stop) the bge_tick callout during detach. To generate a

Re: CVS commit: src/sys/dev/pci

2015-02-24 Thread Christos Zoulas
On Feb 24, 11:28am, nona...@gmail.com (NONAKA Kimihiro) wrote: -- Subject: Re: CVS commit: src/sys/dev/pci | 2015-02-24 0:25 GMT+09:00 Christos Zoulas chris...@zoulas.com: | | Please revert the fix then, or check the coverity website for the | explanation why it thinks that the index can be 15

  1   2   3   >