Re: CVS commit: src/sys/kern

2021-09-22 Thread Rin Okuyama
On 2021/09/22 14:42, Rin Okuyama wrote: Module Name:src Committed By: rin Date: Wed Sep 22 05:42:19 UTC 2021 Modified Files: src/sys/kern: kern_ksyms.c Log Message: ksymsmmap: Add missing uao_reference(9) call for ks->ks_uobj. Fix failure for savecore(8) and subsequent

Re: CVS commit: src/sys/kern

2021-08-18 Thread Michael van Elst
On Tue, Aug 17, 2021 at 11:39:26PM +, Taylor R Campbell wrote: > > > > Log Message: > > skip symbol tables that were unloaded again to avoid EFAULT when reading > > ksyms. > > > > also restore TAILQ_FOREACH idiom. > > This change isn't quite right: Reading past st = ksyms_last_snapshot > in

Re: CVS commit: src/sys/kern

2021-08-17 Thread Taylor R Campbell
> Module Name:src > Committed By: mlelstv > Date: Sun Jul 18 06:57:28 UTC 2021 > > Modified Files: > src/sys/kern: kern_ksyms.c > > Log Message: > skip symbol tables that were unloaded again to avoid EFAULT when reading > ksyms. > > also restore TAILQ_FOREACH idiom.

Re: CVS commit: src/sys/kern

2021-06-30 Thread David Holland
On Thu, Jul 01, 2021 at 12:25:51AM -0400, Christos Zoulas wrote: > Modified Files: > src/sys/kern: vfs_vnops.c > > Log Message: > don't clear the error before we use it to determine if we are moving or > duping. oh ffs... *goes to soak head* -- David A. Holland dholl...@netbsd.org

Re: CVS commit: src/sys/kern

2021-06-02 Thread Rin Okuyama
Hmm, misleading commit log (code itself is correct). More precisely: s/the last element of ksyms_symtabs/ksyms_last_snapshot/ Anyway, does this help you to reintroduce "ksyms(4): Don't skip symbol tables that are soon to be freed."? That KASSERT does not fire anymore for aarch64, as far as I

Re: CVS commit: src/sys/kern

2021-06-02 Thread Taylor R Campbell
> Date: Wed, 2 Jun 2021 17:33:39 +0900 > From: Rin Okuyama > > On 2021/06/02 6:11, Taylor R Campbell wrote: > > - KASSERT(filepos <= sizeof(struct ksyms_hdr) + > > + KASSERT(filepos == sizeof(struct ksyms_hdr) + > > ksyms_hdr.kh_shdr[SYMTAB].sh_size); > ... > > This KASSERT fires at

Re: CVS commit: src/sys/kern

2021-06-02 Thread Rin Okuyama
Hi, On 2021/06/02 6:11, Taylor R Campbell wrote: Module Name:src Committed By: riastradh Date: Tue Jun 1 21:11:52 UTC 2021 Modified Files: src/sys/kern: kern_ksyms.c Log Message: ksyms(4): Don't skip symbol tables that are soon to be freed. They will not actually be

Re: CVS commit: src/sys/kern (kern_event.c)

2021-01-22 Thread Paul Goyette
On Fri, 22 Jan 2021, Paul Goyette wrote: On Thu, 21 Jan 2021, Paul Goyette wrote: Ooopppsss ignore me - looks like this was already fixed and my update missed it. I'll retry. OK, I built and installed a new kernel+userland. Most everything works, and syslogd seems to work fine (at least,

Re: CVS commit: src/sys/kern (kern_event.c)

2021-01-22 Thread Paul Goyette
On Thu, 21 Jan 2021, Paul Goyette wrote: Ooopppsss ignore me - looks like this was already fixed and my update missed it. I'll retry. OK, I built and installed a new kernel+userland. Most everything works, and syslogd seems to work fine (at least, it no longer panics during startup).

Re: CVS commit: src/sys/kern (kern_event.c)

2021-01-21 Thread Paul Goyette
Ooopppsss ignore me - looks like this was already fixed and my update missed it. I'll retry. On Thu, 21 Jan 2021, Paul Goyette wrote: This change seems to break everything! As soon as I try to start syslogd I hit the panic() that you added [ 28.0253983] panic: kqueue_scan,1491:

Re: CVS commit: src/sys/kern (kern_event.c)

2021-01-21 Thread Paul Goyette
This change seems to break everything! As soon as I try to start syslogd I hit the panic() that you added [ 28.0253983] panic: kqueue_scan,1491: kq=0xdc13890bc4c0 kq->kq_count(1) != count(0), nmarker=1 [ 28.0253983] cpu0: Begin traceback... [ 28.0253983] vpanic() at

Re: CVS commit: src/sys/kern

2021-01-21 Thread Tom Spindler (moof)
I believe it's this change that's made my vbox image panic at the drop of a hat; while it occasionally panics before it even hits single user, it also consistently panics when starting syslogd (even from single-user): panic: kqueue_scan,1491: kq=0xc779aeff6dc0 kq->kq_count(1) != count(0),

Re: CVS commit: src/sys/kern

2020-11-05 Thread Rin Okuyama
On 2020/11/05 2:45, Paul Goyette wrote: On Wed, 4 Nov 2020, Rin Okuyama wrote: On 2020/11/04 22:52, Paul Goyette wrote: On Wed, 4 Nov 2020, Rin Okuyama wrote: ptrace_common_{init,fini} are called from the ptrace_common module's modcmd routine in kern/sys_ptrace_common.c.  The modcmd routine

Re: CVS commit: src/sys/kern

2020-11-04 Thread Paul Goyette
OK, this is my mistake. When I change the calls in the ptrace_common modcmd, I should also have renamed the functions (including their entries in sys/ptrace.h). I will commit this shortly, before I leave. Thanks for the "recipe" for reproducing the problem - I will try it later when I return.

Re: CVS commit: src/sys/kern

2020-11-04 Thread Paul Goyette
On Wed, 4 Nov 2020, Rin Okuyama wrote: On 2020/11/04 22:52, Paul Goyette wrote: On Wed, 4 Nov 2020, Rin Okuyama wrote: ptrace_common_{init,fini} are called from the ptrace_common module's modcmd routine in kern/sys_ptrace_common.c. The modcmd routine in turn is called at module

Re: CVS commit: src/sys/kern

2020-11-04 Thread Rin Okuyama
On 2020/11/04 22:52, Paul Goyette wrote: On Wed, 4 Nov 2020, Rin Okuyama wrote: ptrace_common_{init,fini} are called from the ptrace_common module's modcmd routine in kern/sys_ptrace_common.c. The modcmd routine in turn is called at module initialization time. In the case of a built-in

Re: CVS commit: src/sys/kern

2020-11-04 Thread Paul Goyette
On Wed, 4 Nov 2020, Rin Okuyama wrote: ptrace_common_{init,fini} are called from the ptrace_common module's modcmd routine in kern/sys_ptrace_common.c.  The modcmd routine in turn is called at module initialization time.  In the case of a built-in module, it will be called by module_init via

Re: CVS commit: src/sys/kern

2020-11-04 Thread Rin Okuyama
On 2020/11/04 22:31, Paul Goyette wrote: On Wed, 4 Nov 2020, Rin Okuyama wrote: Hi, On 2020/10/26 0:55, Paul Goyette wrote: Module Name:    src Committed By:    pgoyette Date:    Sun Oct 25 15:55:37 UTC 2020 Modified Files: src/sys/kern: sys_ptrace_common.c Log Message:

Re: CVS commit: src/sys/kern

2020-11-04 Thread Paul Goyette
On Wed, 4 Nov 2020, Rin Okuyama wrote: Hi, On 2020/10/26 0:55, Paul Goyette wrote: Module Name:src Committed By: pgoyette Date: Sun Oct 25 15:55:37 UTC 2020 Modified Files: src/sys/kern: sys_ptrace_common.c Log Message: ptrace_Common is a module unto itself. Don't

Re: CVS commit: src/sys/kern

2020-11-03 Thread Rin Okuyama
Hi, On 2020/10/26 0:55, Paul Goyette wrote: Module Name:src Committed By: pgoyette Date: Sun Oct 25 15:55:37 UTC 2020 Modified Files: src/sys/kern: sys_ptrace_common.c Log Message: ptrace_Common is a module unto itself. Don't use the ptrace module's init/fini

Re: CVS commit: src/sys/kern

2020-10-19 Thread Christos Zoulas
In article <20201019144701.a6d3bf...@cvs.netbsd.org>, Kamil Rytarowski wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: kamil >Date: Mon Oct 19 14:47:01 UTC 2020 > >Modified Files: > src/sys/kern: sys_ptrace.c sys_ptrace_common.c > >Log Message: >Remove obsolete references

re: CVS commit: src/sys/kern

2020-10-08 Thread David H. Gutteridge
On Mon, 07 Sep 2020 at 20:47:25 +1000, matthew green wrote: "Jason R Thorpe" writes: Module Name:src Committed By: thorpej Date: Mon Sep 7 03:50:41 UTC 2020 Modified Files: src/sys/kern: files.kern init_main.c Log Message: Add the ability to set an alternate cnmagic

re: CVS commit: src/sys/kern

2020-09-07 Thread matthew green
"Jason R Thorpe" writes: > Module Name: src > Committed By: thorpej > Date: Mon Sep 7 03:50:41 UTC 2020 > > Modified Files: > src/sys/kern: files.kern init_main.c > > Log Message: > Add the ability to set an alternate cnmagic in the kernel config > file, e.g.: > > options

Re: CVS commit: src/sys/kern

2020-08-02 Thread Kamil Rytarowski
On 02.08.2020 17:50, Taylor R Campbell wrote: >> Date: Sun, 2 Aug 2020 17:35:06 +0200 >> From: Kamil Rytarowski >> >> On 02.08.2020 16:44, Taylor R Campbell wrote: Date: Sun, 2 Aug 2020 16:04:15 +0200 From: Kamil Rytarowski On 02.08.2020 15:57, Taylor R Campbell wrote: >

Re: CVS commit: src/sys/kern

2020-08-02 Thread Taylor R Campbell
> Date: Sun, 2 Aug 2020 17:35:06 +0200 > From: Kamil Rytarowski > > On 02.08.2020 16:44, Taylor R Campbell wrote: > >> Date: Sun, 2 Aug 2020 16:04:15 +0200 > >> From: Kamil Rytarowski > >> > >> On 02.08.2020 15:57, Taylor R Campbell wrote: > >>> But it sounds like the original motivation is

Re: CVS commit: src/sys/kern

2020-08-02 Thread Kamil Rytarowski
On 02.08.2020 16:44, Taylor R Campbell wrote: >> Date: Sun, 2 Aug 2020 16:04:15 +0200 >> From: Kamil Rytarowski >> >> On 02.08.2020 15:57, Taylor R Campbell wrote: >>> But it sounds like the original motivation is that it triggered >>> -Wvla...which frankly strikes me as a compiler bug since

Re: CVS commit: src/sys/kern

2020-08-02 Thread Jaromír Doleček
Le dim. 2 août 2020 à 15:57, Taylor R Campbell a écrit : > Why does it improve readability? Certainly using cringe language features does not help readability. > What else does -Wvla choke on in src/sys? Some drm drivers, and uvm, particularly uvm_bio.c. I'd like to work towards enabling -Wvla

Re: CVS commit: src/sys/kern

2020-08-02 Thread Taylor R Campbell
> Date: Sun, 2 Aug 2020 16:04:15 +0200 > From: Kamil Rytarowski > > On 02.08.2020 15:57, Taylor R Campbell wrote: > > But it sounds like the original motivation is that it triggered > > -Wvla...which frankly strikes me as a compiler bug since there's > > obviously no actual VLA created in

Re: CVS commit: src/sys/kern

2020-08-02 Thread Joerg Sonnenberger
On Sun, Aug 02, 2020 at 01:57:11PM +, Taylor R Campbell wrote: > But it sounds like the original motivation is that it triggered > -Wvla...which frankly strikes me as a compiler bug since there's > obviously no actual VLA created in sizeof; as far as I can tell > there's no semantic difference

Re: CVS commit: src/sys/kern

2020-08-02 Thread Kamil Rytarowski
On 02.08.2020 16:25, Paul Goyette wrote: > On Sun, 2 Aug 2020, Kamil Rytarowski wrote: > >> On 02.08.2020 15:57, Taylor R Campbell wrote: >>> But it sounds like the original motivation is that it triggered >>> -Wvla...which frankly strikes me as a compiler bug since there's >>> obviously no

Re: CVS commit: src/sys/kern

2020-08-02 Thread Paul Goyette
On Sun, 2 Aug 2020, Kamil Rytarowski wrote: On 02.08.2020 15:57, Taylor R Campbell wrote: But it sounds like the original motivation is that it triggered -Wvla...which frankly strikes me as a compiler bug since there's obviously no actual VLA created in sizeof; as far as I can tell there's no

Re: CVS commit: src/sys/kern

2020-08-02 Thread Kamil Rytarowski
On 02.08.2020 15:57, Taylor R Campbell wrote: > But it sounds like the original motivation is that it triggered > -Wvla...which frankly strikes me as a compiler bug since there's > obviously no actual VLA created in sizeof; as far as I can tell > there's no semantic difference between

Re: CVS commit: src/sys/kern

2020-08-02 Thread Taylor R Campbell
> Date: Sun, 2 Aug 2020 10:47:21 +0200 > From: Jarom�r Dole ek > > Readability first and foremost in this case. > > I was exploring if I can disable VLAs for the kernel altogether, this > can't be done for now. Nevertheless, this change looked like it would > be useful to make anyway. Why does

Re: CVS commit: src/sys/kern

2020-08-02 Thread Jaromír Doleček
Readability first and foremost in this case. I was exploring if I can disable VLAs for the kernel altogether, this can't be done for now. Nevertheless, this change looked like it would be useful to make anyway. Le dim. 2 août 2020 à 01:15, Taylor R Campbell a écrit : > > > Module Name:src >

Re: CVS commit: src/sys/kern

2020-08-01 Thread Taylor R Campbell
> Module Name:src > Committed By: jdolecek > Date: Sat Aug 1 11:18:26 UTC 2020 > > Modified Files: > src/sys/kern: subr_autoconf.c > > Log Message: > avoid VLA for the sizeof() calculations Why?

Re: [sctp fix] Re: CVS commit: src/sys/kern

2020-07-18 Thread Maxime Villard
Le 28/04/2020 à 09:16, Luke Mewburn a écrit : On 20-04-26 18:15, Maxime Villard wrote: | - There was no demonstrated use-case justifying importing it. In addition, |major OSes like Windows and macOS do not implement SCTP. There just is no |demand for SCTP on the market; and on

Re: CVS commit: src/sys/kern

2020-06-01 Thread Rin Okuyama
On 2020/06/02 2:08, Joerg Sonnenberger wrote: On Sun, May 31, 2020 at 11:24:20PM +, Rin Okuyama wrote: Module Name:src Committed By: rin Date: Sun May 31 23:24:20 UTC 2020 Modified Files: src/sys/kern: kern_timeout.c Log Message: Stop allocating buffers dynamically

Re: CVS commit: src/sys/kern

2020-06-01 Thread Joerg Sonnenberger
On Sun, May 31, 2020 at 11:24:20PM +, Rin Okuyama wrote: > Module Name: src > Committed By: rin > Date: Sun May 31 23:24:20 UTC 2020 > > Modified Files: > src/sys/kern: kern_timeout.c > > Log Message: > Stop allocating buffers dynamically in a DDB session, in order not to >

re: CVS commit: src/sys/kern

2020-05-31 Thread matthew green
"Rin Okuyama" writes: > Module Name: src > Committed By: rin > Date: Sun May 31 08:33:48 UTC 2020 > > Modified Files: > src/sys/kern: kern_timeout.c > > Log Message: > db_show_callout(): struct callout_cpu and cpu_info are too much for stack. > > XXX > DDB can be running in the

Re: CVS commit: src/sys/kern

2020-05-31 Thread Jason Thorpe
> On May 31, 2020, at 1:33 AM, Rin Okuyama wrote: > > db_show_callout(): struct callout_cpu and cpu_info are too much for stack. > > XXX > DDB can be running in the interrupt context, e.g., when activated from > console. Therefore, use kmem_intr_alloc(9) instead of kmem_alloc(9). > > Frame

Re: CVS commit: src/sys/kern

2020-05-07 Thread Kamil Rytarowski
On 07.05.2020 07:46, Michael van Elst wrote: > On Wed, May 06, 2020 at 12:39:21PM +0200, Kamil Rytarowski wrote: > > Hi Kamil, > >> If I revert the pipe(2) changes on top of NetBSD-current, the test is no >> longer racy again. > > I tried 9.99.60 with and without my bugfix. The test always

Re: CVS commit: src/sys/kern

2020-05-06 Thread Michael van Elst
On Wed, May 06, 2020 at 12:39:21PM +0200, Kamil Rytarowski wrote: Hi Kamil, > If I revert the pipe(2) changes on top of NetBSD-current, the test is no > longer racy again. I tried 9.99.60 with and without my bugfix. The test always failed after some time with exactly that error. If the change

Re: CVS commit: src/sys/kern

2020-05-06 Thread Kamil Rytarowski
This caused regressions in t_ptrace_wait* tests and random hangs/timeouts/failures. If I revert the pipe(2) changes on top of NetBSD-current, the test is no longer racy again. http://netbsd.org/~kamil/patch-00249-pipe-revert.txt Reproducer: cd /usr/tests/lib/libc/sys ./t_ptrace_waitpid

Re: [sctp fix] Re: CVS commit: src/sys/kern

2020-05-02 Thread maya
On Fri, May 01, 2020 at 04:46:36PM +, m...@netbsd.org wrote: > We can setup an equivalence: put as much effort into the SCTP removal > proposal as there was for the SCTP introduction proposal. > > Since SCTP was just dropped in src without any prior discussion, I don't > think we need any

Re: [sctp fix] Re: CVS commit: src/sys/kern

2020-05-01 Thread maya
We can setup an equivalence: put as much effort into the SCTP removal proposal as there was for the SCTP introduction proposal. Since SCTP was just dropped in src without any prior discussion, I don't think we need any discussion for removing it.

Re: [sctp fix] Re: CVS commit: src/sys/kern

2020-04-28 Thread Luke Mewburn
On 20-04-26 18:15, Maxime Villard wrote: | - There was no demonstrated use-case justifying importing it. In addition, |major OSes like Windows and macOS do not implement SCTP. There just is no |demand for SCTP on the market; and on NetBSD, proportionally even less. SCTP is used in

Re: CVS commit: src/sys/kern

2020-04-26 Thread Jason Thorpe
> On Apr 26, 2020, at 2:04 PM, Michael van Elst wrote: > > Log Message: > fix DIAGNOSTIC build non-DIAGNOSTIC you mean? -- thorpej

[sctp fix] Re: CVS commit: src/sys/kern

2020-04-26 Thread Maxime Villard
Le 26/04/2020 à 16:21, Jonathan A. Kollasch a écrit : > Module Name: src > Committed By: jakllsch > Date: Sun Apr 26 14:21:14 UTC 2020 > > Modified Files: > src/sys/kern: uipc_socket.c > > Log Message: > Implement SCTP bug fixes found by maxv@. > > Adding these seems to improve

Re: CVS commit: src/sys/kern

2020-04-13 Thread Andrew Doran
On Mon, Apr 13, 2020 at 04:34:48PM +0100, Roy Marples wrote: > On 13/04/2020 16:31, Andrew Doran wrote: > > Hi Roy. > > > > On Sat, Apr 11, 2020 at 02:13:06AM +0100, Roy Marples wrote: > > > On 10/04/2020 23:34, Andrew Doran wrote: > > > > Module Name:src > > > > Committed By: ad > > > >

Re: CVS commit: src/sys/kern

2020-04-13 Thread Roy Marples
On 13/04/2020 16:31, Andrew Doran wrote: Hi Roy. On Sat, Apr 11, 2020 at 02:13:06AM +0100, Roy Marples wrote: On 10/04/2020 23:34, Andrew Doran wrote: Module Name:src Committed By: ad Date: Fri Apr 10 22:34:36 UTC 2020 Modified Files: src/sys/kern: vfs_mount.c Log

Re: CVS commit: src/sys/kern

2020-04-13 Thread Andrew Doran
Hi Roy. On Sat, Apr 11, 2020 at 02:13:06AM +0100, Roy Marples wrote: > On 10/04/2020 23:34, Andrew Doran wrote: > > Module Name:src > > Committed By: ad > > Date: Fri Apr 10 22:34:36 UTC 2020 > > > > Modified Files: > > src/sys/kern: vfs_mount.c > > > > Log

Re: CVS commit: src/sys/kern

2020-04-10 Thread Roy Marples
On 10/04/2020 23:34, Andrew Doran wrote: Module Name:src Committed By: ad Date: Fri Apr 10 22:34:36 UTC 2020 Modified Files: src/sys/kern: vfs_mount.c Log Message: vfs_mountroot(): don't needlessly grab a second reference to the root vnode (the kernel never chdirs) nor

Re: [vfs_cache] Re: CVS commit: src/sys/kern

2020-04-05 Thread Andrew Doran
On Sun, Mar 29, 2020 at 11:41:23AM +0200, Maxime Villard wrote: > Le 23/03/2020 ? 21:02, Andrew Doran a ?crit?: > > Module Name:src > > Committed By: ad > > Date: Mon Mar 23 20:02:14 UTC 2020 > > > > Modified Files: > > src/sys/kern: vfs_cache.c > > > > Log

[vfs_cache] Re: CVS commit: src/sys/kern

2020-03-29 Thread Maxime Villard
Le 23/03/2020 à 21:02, Andrew Doran a écrit : > Module Name: src > Committed By: ad > Date: Mon Mar 23 20:02:14 UTC 2020 > > Modified Files: > src/sys/kern: vfs_cache.c > > Log Message: > cache_remove(): remove from the vnode list first, so cache_revlookup() > doesn't try to

Re: CVS commit: src/sys/kern

2020-03-09 Thread Maxime Villard
Le 08/03/2020 à 21:41, Andrew Doran a écrit : > On Sun, Mar 08, 2020 at 08:34:29AM +0100, Maxime Villard wrote: >> Le 08/03/2020 ? 01:31, Andrew Doran a ?crit?: >>> Module Name:src >>> Committed By: ad >>> Date: Sun Mar 8 00:31:19 UTC 2020 >>> >>> Modified Files: >>>

Re: CVS commit: src/sys/kern

2020-03-08 Thread Andrew Doran
On Sun, Mar 08, 2020 at 08:34:29AM +0100, Maxime Villard wrote: > Le 08/03/2020 ? 01:31, Andrew Doran a ?crit?: > > Module Name:src > > Committed By: ad > > Date: Sun Mar 8 00:31:19 UTC 2020 > > > > Modified Files: > > src/sys/kern: subr_kmem.c > > > > Log

Re: CVS commit: src/sys/kern

2020-03-07 Thread Maxime Villard
Le 08/03/2020 à 01:31, Andrew Doran a écrit : > Module Name: src > Committed By: ad > Date: Sun Mar 8 00:31:19 UTC 2020 > > Modified Files: > src/sys/kern: subr_kmem.c > > Log Message: > KMEM_SIZE: append the size_t to the allocated buffer, rather than > prepending, so it doesn't

Re: CVS commit: src/sys/kern

2020-03-03 Thread Andrew Doran
On Tue, Mar 03, 2020 at 02:55:16PM -0500, Christos Zoulas wrote: > Module Name: src > Committed By: christos > Date: Tue Mar 3 19:55:16 UTC 2020 > > Modified Files: > src/sys/kern: vfs_syscalls.c > > Log Message: > don't skip the rdir check for the lazy case; breaks chroot df(1)

Re: CVS commit: src/sys/kern

2020-03-02 Thread Taylor R Campbell
> Date: Tue, 3 Mar 2020 12:41:32 +0900 > From: Rin Okuyama > > On 2020/03/03 1:00, Taylor R Campbell wrote: > > Include kern_crashme.c in non-DEBUG kernels. > > > > This is useful for simulating crashes in production to test failover. > > I like this. > > Could you please send pullup request

Re: CVS commit: src/sys/kern

2020-03-02 Thread Rin Okuyama
Hi, On 2020/03/03 1:00, Taylor R Campbell wrote: Module Name:src Committed By: riastradh Date: Mon Mar 2 16:00:54 UTC 2020 Modified Files: src/sys/kern: files.kern Log Message: Include kern_crashme.c in non-DEBUG kernels. This is useful for simulating crashes in

Re: CVS commit: src/sys/kern

2020-02-25 Thread Kamil Rytarowski
On 24.02.2020 21:47, Jaromir Dolecek wrote: > Module Name: src > Committed By: jdolecek > Date: Mon Feb 24 20:47:47 UTC 2020 > > Modified Files: > src/sys/kern: init_main.c > > Log Message: > move config_init_mi() call before vfsinit(), which can trigger loading > of VFS modules >

re: CVS commit: src/sys/kern

2020-02-23 Thread matthew green
"Andrew Doran" writes: > Module Name: src > Committed By: ad > Date: Sun Feb 23 20:08:35 UTC 2020 > > Modified Files: > src/sys/kern: kern_pmf.c > > Log Message: > shutdown_all: take kernel_lock now that kern_reboot() doesn't. ah, i am now guessing that having the kernel lock

re: CVS commit: src/sys/kern

2020-02-23 Thread matthew green
"Andrew Doran" writes: > Module Name: src > Committed By: ad > Date: Sun Feb 23 20:06:30 UTC 2020 > > Modified Files: > src/sys/kern: kern_reboot.c > > Log Message: > - If concurrent calls to kern_reboot(), only let the first do the deed. > - Don't need kernel_lock for this

Re: CVS commit: src/sys/kern

2020-02-21 Thread Kamil Rytarowski
On 20.02.2020 22:14, Jaromir Dolecek wrote: > Module Name: src > Committed By: jdolecek > Date: Thu Feb 20 21:14:23 UTC 2020 > > Modified Files: > src/sys/kern: subr_autoconf.c > > Log Message: > protect deferred lists' manipulation by config_misc_lock, same as > config_pending

Re: CVS commit: src/sys/kern

2020-02-18 Thread J. Hannken-Illjes
> On Feb 17, 2020, at 11:19 PM, Andrew Doran wrote: > > Hi, > > On Thu, Feb 06, 2020 at 06:33:55PM +0100, J. Hannken-Illjes wrote: > >>> On 12. Jan 2020, at 18:49, Andrew Doran wrote: >>> >>> Module Name:src >>> Committed By: ad >>> Date: Sun Jan 12 17:49:17 UTC

Re: CVS commit: src/sys/kern

2020-02-17 Thread Andrew Doran
Hi, On Thu, Feb 06, 2020 at 06:33:55PM +0100, J. Hannken-Illjes wrote: > > On 12. Jan 2020, at 18:49, Andrew Doran wrote: > > > > Module Name:src > > Committed By: ad > > Date: Sun Jan 12 17:49:17 UTC 2020 > > > > Modified Files: > > src/sys/kern: vfs_vnode.c >

Re: CVS commit: src/sys/kern

2020-02-06 Thread J. Hannken-Illjes
> On 12. Jan 2020, at 18:49, Andrew Doran wrote: > > Module Name: src > Committed By: ad > Date: Sun Jan 12 17:49:17 UTC 2020 > > Modified Files: > src/sys/kern: vfs_vnode.c > > Log Message: > vput(): don't drop the vnode lock, carry the hold over into vrelel() which > might

Re: CVS commit: src/sys/kern

2020-01-21 Thread Simon Burge
"Christos Zoulas" wrote: > Log Message: > > Don't crash if we are on a hippie trail, head full of zombie +1 for any Australian references in a commit message :) Cheers, Simon.

re: CVS commit: src/sys/kern

2019-12-12 Thread matthew green
> Therefore, I wouldn't bother adding kcov.h headers, and rolling back to the > previous version of in_interrupt for now is fine, considering that kcov > currently has no use outside of amd64. if you want to put code in sys/kern please make it portable. adding more MD code in MI places is the

Re: CVS commit: src/sys/kern

2019-12-12 Thread Maxime Villard
Le 08/12/2019 à 14:22, Martin Husemann a écrit : On Sun, Dec 08, 2019 at 12:58:20PM +0100, Maxime Villard wrote: kMSan has special constraints which, in this specific case, come down to: each function called from a KCOV instrumentation callback must be a static inline tagged with __nomsan.

re: CVS commit: src/sys/kern

2019-12-10 Thread matthew green
> > > Log Message: > > > Expunge the panicstr checks, we don't need them. > > > > can you explain why? > > Sure, [ .. ] ah, wow. i didn't realise it had such a bad effect on cpus before they actually go properly down. we should probably work hard to make them go down faster if possible,

Re: CVS commit: src/sys/kern

2019-12-10 Thread Andrew Doran
On Wed, Dec 11, 2019 at 09:06:33AM +1100, matthew green wrote: > "Andrew Doran" writes: > > Module Name:src > > Committed By: ad > > Date: Mon Dec 9 21:02:10 UTC 2019 > > > > Modified Files: > > src/sys/kern: kern_rwlock.c > > > > Log Message: > > Expunge the

re: CVS commit: src/sys/kern

2019-12-10 Thread matthew green
"Andrew Doran" writes: > Module Name: src > Committed By: ad > Date: Mon Dec 9 21:02:10 UTC 2019 > > Modified Files: > src/sys/kern: kern_rwlock.c > > Log Message: > Expunge the panicstr checks, we don't need them. can you explain why? what sort of crash-time testing did you

Re: CVS commit: src/sys/kern

2019-12-09 Thread Jason Thorpe
> On Dec 9, 2019, at 1:08 PM, Paul Goyette wrote: > > On Mon, 9 Dec 2019, Andrew Doran wrote: > >> Module Name: src >> Committed By:ad >> Date:Mon Dec 9 21:05:23 UTC 2019 >> >> Modified Files: >> src/sys/kern: kern_mutex.c >> >> Log Message: >> - Add a

Re: CVS commit: src/sys/kern

2019-12-09 Thread Paul Goyette
On Mon, 9 Dec 2019, Andrew Doran wrote: Module Name:src Committed By: ad Date: Mon Dec 9 21:05:23 UTC 2019 Modified Files: src/sys/kern: kern_mutex.c Log Message: - Add a mutex_owner_running() for the benefit of the pagedaemon, which needs help with locking things in

Re: CVS commit: src/sys/kern

2019-12-08 Thread Martin Husemann
On Sun, Dec 08, 2019 at 12:58:20PM +0100, Maxime Villard wrote: > kMSan has special constraints which, in this specific case, come down to: each > function called from a KCOV instrumentation callback must be a static inline > tagged with __nomsan. > > This was not the case with the updated

Re: CVS commit: src/sys/kern

2019-12-08 Thread Maxime Villard
Le 08/12/2019 à 00:51, Kamil Rytarowski a écrit : On 08.12.2019 00:35, matthew green wrote: Module Name:src Committed By: kamil Date: Sat Dec 7 19:50:34 UTC 2019 Modified Files: src/sys/kern: subr_kcov.c Log Message: Revert the in_interrupt() change to use again the

Re: CVS commit: src/sys/kern

2019-12-07 Thread Kamil Rytarowski
On 08.12.2019 00:35, matthew green wrote: >> Module Name: src >> Committed By:kamil >> Date:Sat Dec 7 19:50:34 UTC 2019 >> >> Modified Files: >> src/sys/kern: subr_kcov.c >> >> Log Message: >> Revert the in_interrupt() change to use again the x86 specific code >> >>

re: CVS commit: src/sys/kern

2019-12-07 Thread matthew green
> Module Name: src > Committed By: kamil > Date: Sat Dec 7 19:50:34 UTC 2019 > > Modified Files: > src/sys/kern: subr_kcov.c > > Log Message: > Revert the in_interrupt() change to use again the x86 specific code > > This is prerequisite for kMSan and upcoming kernel changes. >

Re: CVS commit: src/sys/kern [change in kern_lwp.c]

2019-12-03 Thread Maxime Villard
Le 01/12/2019 à 16:27, Andrew Doran a écrit : Module Name:src Committed By: ad Date: Sun Dec 1 15:27:58 UTC 2019 Modified Files: src/sys/kern: kern_lwp.c Log Message: Fix a longstanding problem with LWP limits. When changing the user's LWP count, we must use the

Re: CVS commit: src/sys/kern

2019-11-30 Thread Rin Okuyama
On 2019/11/30 23:35, Andrew Doran wrote: Hmm, it works fine on amd64 and looks OK but me, but I have backed it out for the time being. Thanks! Also thank you for working on this area! rin

Re: CVS commit: src/sys/kern

2019-11-30 Thread Andrew Doran
Hi, On Sat, Nov 30, 2019 at 04:52:38PM +0900, Rin Okuyama wrote: > On 2019/11/30 5:50, Andrew Doran wrote: > > Module Name:src > > Committed By: ad > > Date: Fri Nov 29 20:50:54 UTC 2019 > > > > Modified Files: > > src/sys/kern: kern_rwlock.c > > > > Log Message:

Re: CVS commit: src/sys/kern

2019-11-29 Thread Rin Okuyama
On 2019/11/30 5:50, Andrew Doran wrote: Module Name:src Committed By: ad Date: Fri Nov 29 20:50:54 UTC 2019 Modified Files: src/sys/kern: kern_rwlock.c Log Message: A couple more tweaks to avoid reading the lock word. To generate a diff of this commit: cvs rdiff -u

Re: CVS commit: src/sys/kern

2019-11-07 Thread Christos Zoulas
On Nov 7, 6:08pm, n...@gmx.com (Kamil Rytarowski) wrote: -- Subject: Re: CVS commit: src/sys/kern | Please review: | | http://netbsd.org/~kamil/patch-00194-disklabel-alignment.txt | | This patch works for me. | | Patch inspired by: | | Avoid misaligned access in disklabel(8) in find_label

Re: CVS commit: src/sys/kern

2019-11-07 Thread Valery Ushakov
On Thu, Nov 07, 2019 at 19:06:29 +0100, Martin Husemann wrote: > OK, why is it 8 byte aligned? Checking > > > revision 1.108 > > date: 2011-01-18 20:52:24 +0100; author: matt; state: Exp; lines: +2 -1; > > Make struct disklabel 8 byte aligned. This increases its size by 4 bytes > > on

Re: CVS commit: src/sys/kern

2019-11-07 Thread Kamil Rytarowski
On 07.11.2019 19:32, Valery Ushakov wrote: > On Thu, Nov 07, 2019 at 18:08:40 +0100, Kamil Rytarowski wrote: > >> On 07.11.2019 16:45, Kamil Rytarowski wrote: >>> On 07.11.2019 16:26, Martin Husemann wrote: On Thu, Nov 07, 2019 at 02:53:08PM +0100, Kamil Rytarowski wrote: > On 07.11.2019

Re: CVS commit: src/sys/kern

2019-11-07 Thread Valery Ushakov
On Thu, Nov 07, 2019 at 18:08:40 +0100, Kamil Rytarowski wrote: > On 07.11.2019 16:45, Kamil Rytarowski wrote: > > On 07.11.2019 16:26, Martin Husemann wrote: > >> On Thu, Nov 07, 2019 at 02:53:08PM +0100, Kamil Rytarowski wrote: > >>> On 07.11.2019 14:25, Valery Ushakov wrote: > If the

Re: CVS commit: src/sys/kern

2019-11-07 Thread Martin Husemann
On Thu, Nov 07, 2019 at 06:46:48PM +0100, Kamil Rytarowski wrote: > member access within misaligned address 0x942d3de8c03c for type > 'const struct disklabel' which requires 8 byte alignment OK, why is it 8 byte aligned? Checking > revision 1.108 > date: 2011-01-18 20:52:24 +0100;

Re: CVS commit: src/sys/kern

2019-11-07 Thread Kamil Rytarowski
On 07.11.2019 18:20, Martin Husemann wrote: > On Thu, Nov 07, 2019 at 06:08:40PM +0100, Kamil Rytarowski wrote: >> Please review: >> >> http://netbsd.org/~kamil/patch-00194-disklabel-alignment.txt >> >> This patch works for me. > > Yes, I believe that it does - but why is it needed? > syzbot

Re: CVS commit: src/sys/kern

2019-11-07 Thread Martin Husemann
On Thu, Nov 07, 2019 at 06:08:40PM +0100, Kamil Rytarowski wrote: > Please review: > > http://netbsd.org/~kamil/patch-00194-disklabel-alignment.txt > > This patch works for me. Yes, I believe that it does - but why is it needed? dlp = (void *)a->bp->b_data; Here we can assume that

Re: CVS commit: src/sys/kern

2019-11-07 Thread Kamil Rytarowski
On 07.11.2019 16:45, Kamil Rytarowski wrote: > On 07.11.2019 16:26, Martin Husemann wrote: >> On Thu, Nov 07, 2019 at 02:53:08PM +0100, Kamil Rytarowski wrote: >>> On 07.11.2019 14:25, Valery Ushakov wrote: If the sanitizer does complain about other uses, there is little point in fixing

Re: CVS commit: src/sys/kern

2019-11-07 Thread Steffen Nurpmeso
David Young wrote in <20191107155806.gl1...@pobox.com>: |On Thu, Nov 07, 2019 at 04:26:51PM +0100, Martin Husemann wrote: |> On Thu, Nov 07, 2019 at 02:53:08PM +0100, Kamil Rytarowski wrote: |>> On 07.11.2019 14:25, Valery Ushakov wrote: .. |I think the problem is that if you have the series

Re: CVS commit: src/sys/kern

2019-11-07 Thread Kamil Rytarowski
On 07.11.2019 17:20, Kamil Rytarowski wrote: > On 07.11.2019 17:08, Martin Husemann wrote: >> On Thu, Nov 07, 2019 at 04:56:16PM +0100, Kamil Rytarowski wrote: >>> 6.3.2.1 C11 >>> >>> 'An lvalue is an expression (with an object type other than void) that >>> potentially designates an object' >>>

Re: CVS commit: src/sys/kern

2019-11-07 Thread Valery Ushakov
On Thu, Nov 07, 2019 at 09:58:06 -0600, David Young wrote: > On Thu, Nov 07, 2019 at 04:26:51PM +0100, Martin Husemann wrote: > > On Thu, Nov 07, 2019 at 02:53:08PM +0100, Kamil Rytarowski wrote: > > > On 07.11.2019 14:25, Valery Ushakov wrote: > > > > If the sanitizer does complain about other

Re: CVS commit: src/sys/kern

2019-11-07 Thread Kamil Rytarowski
On 07.11.2019 17:09, Martin Husemann wrote: > On Thu, Nov 07, 2019 at 09:58:06AM -0600, David Young wrote: >> I think the problem is that if you have the series of statements, >> >> element_t *e = >element; >> >> if (s == NULL) >> return; > > Note that this example

Re: CVS commit: src/sys/kern

2019-11-07 Thread Kamil Rytarowski
On 07.11.2019 17:08, Martin Husemann wrote: > On Thu, Nov 07, 2019 at 04:56:16PM +0100, Kamil Rytarowski wrote: >> 6.3.2.1 C11 >> >> 'An lvalue is an expression (with an object type other than void) that >> potentially designates an object' >> >> This means that real dereference is not needed,

Re: CVS commit: src/sys/kern

2019-11-07 Thread Martin Husemann
On Thu, Nov 07, 2019 at 09:58:06AM -0600, David Young wrote: > I think the problem is that if you have the series of statements, > > element_t *e = >element; > > if (s == NULL) > return; Note that this example has *nothing* in common with Kamil's code change. He

Re: CVS commit: src/sys/kern

2019-11-07 Thread Martin Husemann
On Thu, Nov 07, 2019 at 04:56:16PM +0100, Kamil Rytarowski wrote: > 6.3.2.1 C11 > > 'An lvalue is an expression (with an object type other than void) that > potentially designates an object' > > This means that real dereference is not needed, only a potential. And > there are special cases of

Re: CVS commit: src/sys/kern

2019-11-07 Thread David Young
On Thu, Nov 07, 2019 at 04:26:51PM +0100, Martin Husemann wrote: > On Thu, Nov 07, 2019 at 02:53:08PM +0100, Kamil Rytarowski wrote: > > On 07.11.2019 14:25, Valery Ushakov wrote: > > > If the sanitizer does complain about other uses, there is little point > > > in fixing one instance and not the

Re: CVS commit: src/sys/kern

2019-11-07 Thread Kamil Rytarowski
On 07.11.2019 16:49, Martin Husemann wrote: > On Thu, Nov 07, 2019 at 04:45:31PM +0100, Kamil Rytarowski wrote: >> Unfortunately the C committee went into the opposite direction here and >> specified a potential dereference. > > Where? > > Martin > 6.3.2.1 C99 "An lvalue is an expression with

  1   2   3   4   5   6   7   >