Re: CVS commit: src/sys/modules/pf

2018-02-17 Thread Joerg Sonnenberger
On Sat, Feb 17, 2018 at 08:14:37AM +1100, matthew green wrote:
> "Joerg Sonnenberger" writes:
> > Module Name:src
> > Committed By:   joerg
> > Date:   Mon Feb 12 22:18:36 UTC 2018
> > 
> > Modified Files:
> > src/sys/modules/pf: Makefile
> > 
> > Log Message:
> > Simplify and make the GCC check more precise at the same time.
> 
> ! .if ${HAVE_GCC:U0} == "6"
> 
> FWIW, i usually to write these as ">= 6", as these sorts of
> problems tend to not disappear with a newer GCC.

Depends, sometimes they do, sometimes they don't. As least in the past,
we didn't necessarily use good numeric versions either, so the patterns
were more complicated.

Joerg


re: CVS commit: src/sys/modules/pf

2018-02-16 Thread matthew green
"Joerg Sonnenberger" writes:
> Module Name:  src
> Committed By: joerg
> Date: Mon Feb 12 22:18:36 UTC 2018
> 
> Modified Files:
>   src/sys/modules/pf: Makefile
> 
> Log Message:
> Simplify and make the GCC check more precise at the same time.

! .if ${HAVE_GCC:U0} == "6"

FWIW, i usually to write these as ">= 6", as these sorts of
problems tend to not disappear with a newer GCC.


.mrg.


Re: CVS commit: src/sys/modules/pf

2010-04-13 Thread Antti Kantee
On Mon Apr 12 2010 at 14:05:38 +, Adam Hoka wrote:
 Module Name:  src
 Committed By: ahoka
 Date: Mon Apr 12 14:05:38 UTC 2010
 
 Added Files:
   src/sys/modules/pf: Makefile bpfilter.h pf.h pflog.h pfsync.h
 
 Log Message:
 Add new type kernel module for pf (includes pflog, but not pfsync).

bpfilter.h is no longer used, so there is no reason to add it.