Re: CVS commit: src/sys/kern

2009-07-27 Thread Marc Balmer
Am 27.07.2009 um 18:08 schrieb Matthias Drochner: lacom...@gmail.com said: Am I the only one to find that attaching a pseudo-device in main() is not the right way to go ? No. This looks like a case for defpseudodev. You'll find a couple of examples in the tree. (Or I can help if

Re: CVS commit: src/sys/kern

2009-07-27 Thread Marc Balmer
Am 27.07.2009 um 18:36 schrieb Matthias Drochner: lacom...@gmail.com said: config(9) doesn't seem to know anything about 'defpseudodev' config(5) mentions it. (I've written that part. It anyone has suggestions for better wording please tell me.) I'll take care of this issue. If there is

Re: CVS commit: src/sys/kern

2009-07-27 Thread Matthias Drochner
m...@msys.ch said: yes, please mail me some hints, I find it gross myself, but did not yet find a better way. It is pretty easy: -in files.gpio, change the declaration to defpseudodev gpiosim: gpiobus and remove the attach line -in the kernel config, change gpiosim0 at root (or what you have

Re: CVS commit: src/sys/kern

2009-07-27 Thread Matthias Drochner
lacom...@gmail.com said: config(9) doesn't seem to know anything about 'defpseudodev' config(5) mentions it. (I've written that part. It anyone has suggestions for better wording please tell me.) best regards Matthias

Re: CVS commit: src/sys/dev/gpio

2009-07-27 Thread Perry E. Metzger
Arnaud Lacombe lacom...@gmail.com writes: On Sun, Jul 26, 2009 at 5:26 PM, matthew greenm...@eterna.com.au wrote: incidentially, i actually did object to this change on ICB last night but i was off to bed and didn't feel like arguing at the time.  i didn't expect to see it commited straight

Re: CVS commit: src/sys/dev/gpio

2009-07-27 Thread Arnaud Lacombe
Hi Perry, On Mon, Jul 27, 2009 at 1:41 PM, Perry E. Metzgerpe...@piermont.com wrote: And in addition to being less than 24 hours old, the code was his own code. The clear de facto rule is that you can change code you wrote and own with a lot less approval, even for a new developer, than other

Re: CVS commit: src/sys/dev/gpio

2009-07-27 Thread Arnaud Lacombe
On Mon, Jul 27, 2009 at 2:01 PM, Perry E. Metzgerpe...@piermont.com wrote: Eh, if we make it too hard to commit to code under active development, people won't actively develop. Marc has also shown that he's willing to make reasonable changes when improvements are pointed out to him. That's why

Re: CVS commit: src/sys/kern

2009-07-27 Thread Matthias Drochner
m.droch...@fz-juelich.de said: In that function, you can call config_attach_pseudo(9) to attach the actual instances. See eg sys/dev/vnd.c for an example. Forgot to mention that you need to call config_cfattach_attach() before. sys/dev/md.c is a better example. best regards Matthias

Re: CVS commit: src/sys/dev/gpio

2009-07-27 Thread Perry E. Metzger
Arnaud Lacombe lacom...@gmail.com writes: On Mon, Jul 27, 2009 at 1:41 PM, Perry E. Metzgerpe...@piermont.com wrote: And in addition to being less than 24 hours old, the code was his own code. The clear de facto rule is that you can change code you wrote and own with a lot less approval, even