On Fri, 11 Dec 2009, Masao Uebayashi wrote:
Modified Files:
src/usr.bin/ktruss: Makefile
- AWK=${TOOL_AWK:Q} CPP=${CPP:Q} CPPFLAGS=${CPPFLAGS:Q} \
+ ${GENCMD} ${.TARGET} \
+ AWK=${TOOL_AWK:Q} CPP=${CPP:Q} CPPFLAGS=${CPPFLAGS:Q} \
The extra quotes here look wrong. ${VAR:Q}
Have you considered to extend bsd.lib.mk suffix rules? The fact is that it
already build multiple ABIs / signatures (.o / .po / .go / .so). I think
that direction is more straightforward.
I'm considering to extend that for crunch binaries. Crunch object is another
ABI, and *.cro (the one just
On Dec 12, 3:14pm, uebay...@tombi.co.jp (Masao Uebayashi) wrote:
-- Subject: make rule of multiple file generation (was Re: CVS commit: src/sh
| (Moved from source-change...@netbsd.org.)
|
| Actually I am interested. You just did not present your solution in
| tech-whatever so I did not have
On Dec 14, 9:13am, uebay...@tombi.co.jp (Masao Uebayashi) wrote:
-- Subject: Re: make rule of multiple file generation (was Re: CVS commit: sr
| | % cd bin/sh
| | % cvs up -D20091201
| | % nbmake-XXX -n sh
|
| Ok, this is fixed now (in bsd.sys.mk). What else is broken?
|
| %
On Dec 14, 11:40am, uebay...@tombi.co.jp (Masao Uebayashi) wrote:
-- Subject: Re: make rule of multiple file generation (was Re: CVS commit: sr
| This has nothing to do with yacc; the rules in that Makefile are wrong.
|
| instead of:
|
| nodes.h: nodes.c
| nodes.c: mknodes.sh
So this is fixed with an additional dependency to force serialization,
or by fixing the script not to re-use the same temp filenames:
nodes.h: nodes.c
nodes.c nodes.h: mknodes.sh nodetypes nodes.c.pat
${_MKTARGET_CREATE}
${SCRIPT_ENV} ${HOST_SH} ${.ALLSRC:S/^nodes.c$//}
On Dec 14, 12:41pm, uebay...@tombi.co.jp (Masao Uebayashi) wrote:
-- Subject: Re: make rule of multiple file generation (was Re: CVS commit: sr
| So this is fixed with an additional dependency to force serialization,
| or by fixing the script not to re-use the same temp filenames:
|
|
Yes, it adds more explicit rules... My vote is to remove it and fix
the Makefiles/scripts that are broken. It is pretty straight-forward.
Now I'm fine with nuking GENCMD and fix rules using .ORDER:. Please go
for it. It'd be also nice if all instances are rewritten to look an idiom,
like:
On Dec 14, 1:09pm, uebay...@tombi.co.jp (Masao Uebayashi) wrote:
-- Subject: Re: make rule of multiple file generation (was Re: CVS commit: sr
| Yes, it adds more explicit rules... My vote is to remove it and fix
| the Makefiles/scripts that are broken. It is pretty straight-forward.
|
| Now
Yes:
% find * -name Makefile | xargs grep -l GENCMD
usr.bin/ktruss/Makefile
% find * -name '*.mk' | xargs grep -l GENCMD
share/mk/bsd.own.mk
Masao
--
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635
10 matches
Mail list logo
