Re: CVS commit: src/sys/dev/scsipi

2012-04-20 Thread Manuel Bouyer
On Thu, Apr 19, 2012 at 06:39:29PM -0600, Warner Losh wrote: FreeBSD started out with MPSAFE and then went to NEEDS_GIANT as flags for the drivers. I'm with Matthew: patch the drivers that are broken (or not known to be safe) and then you have a convenient thing to grep for when you want to

Re: CVS commit: src/sys/dev/scsipi

2012-04-20 Thread David Holland
On Fri, Apr 20, 2012 at 09:37:00AM +0200, Manuel Bouyer wrote: we've never had autoconfig run with the kernel lock AFAICT, so this assumption has never been true. So this is a bug. The contract was really that spl-locked drivers would continue to work as is when fine-grained locking

Re: CVS commit: src/sys/dev/scsipi

2012-04-20 Thread Manuel Bouyer
On Fri, Apr 20, 2012 at 07:46:35AM +, David Holland wrote: On Fri, Apr 20, 2012 at 09:37:00AM +0200, Manuel Bouyer wrote: we've never had autoconfig run with the kernel lock AFAICT, so this assumption has never been true. So this is a bug. The contract was really that

Re: CVS commit: src/sys/dev/scsipi

2012-04-20 Thread Manuel Bouyer
On Fri, Apr 20, 2012 at 06:06:35PM +1000, matthew green wrote: we've never had autoconfig run with the kernel lock AFAICT, so this assumption has never been true. So this is a bug. The contract was really that spl-locked drivers would continue to work as is when fine-grained locking

Re: CVS commit: src/tests/lib/libc/gen (address alignment)

2012-04-20 Thread Paul Goyette
XXX I would appreciate if someone could test it under a real amd64 host with an up-to-date kernel, so I can reasonably assume that the culprit is Virtual Box and not our amd64 port (my test machine being off line I cannot do it myself). Results from other arches would be a plus too. I just

Re: CVS commit: src/tests/lib/libc/gen (address alignment)

2012-04-20 Thread Paul Goyette
On Fri, 20 Apr 2012, Paul Goyette wrote: The machine did not drop into ddb, it simply rebooted. Unfortunately it did not leave a core dump behind, so I don't have much to look at just yet. When I get home later today, I will try to get more info. BTW, this occurred while running the ATF