Masao Uebayashi writes:
Module Name: src
Committed By: uebayasi
Date: Tue Aug 18 13:46:20 UTC 2015
Modified Files:
src/sys/kern: kern_cpu.c kern_drvctl.c
Log Message:
Convert pseudo attach functions to take no arguments, as some functions
(pppattach(), putterattach(),
Can compilers warn that `variables that should not be used are
mistakenly used'? If not, marking with `__unused' does not prove that
those variables are really unused.
Masao Uebayashi writes:
On Wed, Aug 19, 2015 at 10:27 AM, Paul Goyette p...@vps1.whooppee.com wrote:
(snip)
Wasn't the 'n' parameter supposed to be used to tell the driver how many
instances of the pseudo-device should be instantiated? At least, for those
drivers which do not
Of course I can revert changes but I'd point out that pseudo attach
functions were already inconsistent, and I want to fix that
inconsistency.
Could you list a number of other instances that use `int n'?
On Wed, Aug 19, 2015 at 11:34 AM, matthew green m...@eterna.com.au wrote:
Masao Uebayashi
Masao Uebayashi writes:
Can compilers warn that `variables that should not be used are
mistakenly used'? If not, marking with `__unused' does not prove that
those variables are really unused.
we do not support the use of marking arguments as unused.
just read the code. it's pretty obvious
Masao Uebayashi writes:
Of course I can revert changes but I'd point out that pseudo attach
functions were already inconsistent, and I want to fix that
inconsistency.
can you show me these? if they're not taking an (unused) int
argument, then they're already not consistent, and should be
also:
why did you not bring up this API change on tech-kern?
.mrg.
On Wed, Aug 19, 2015 at 10:27 AM, Paul Goyette p...@vps1.whooppee.com wrote:
(snip)
Wasn't the 'n' parameter supposed to be used to tell the driver how many
instances of the pseudo-device should be instantiated? At least, for those
drivers which do not automatically clone?
Yes.
Have all of
On Wed, Aug 19, 2015 at 5:31 AM, matthew green m...@eterna.com.au wrote:
Masao Uebayashi writes:
Module Name: src
Committed By: uebayasi
Date: Tue Aug 18 13:46:20 UTC 2015
Modified Files:
src/sys/kern: kern_cpu.c kern_drvctl.c
Log Message:
Convert pseudo attach functions
On Wed, 19 Aug 2015, Masao Uebayashi wrote:
On Wed, Aug 19, 2015 at 5:31 AM, matthew green m...@eterna.com.au wrote:
Masao Uebayashi writes:
Module Name: src
Committed By: uebayasi
Date: Tue Aug 18 13:46:20 UTC 2015
Modified Files:
src/sys/kern: kern_cpu.c kern_drvctl.c
Log
raidattach() doesn't seem to use `int num':
http://nxr.netbsd.org/xref/src/sys/dev/raidframe/rf_netbsdkintf.c#395
11 matches
Mail list logo
