Re: CVS commit: src/usr.bin/make

2017-06-17 Thread Joerg Sonnenberger
On Sat, Jun 17, 2017 at 05:28:07PM -0400, Christos Zoulas wrote: > On Jun 17, 9:38pm, jo...@bec.de (Joerg Sonnenberger) wrote: > -- Subject: Re: CVS commit: src/usr.bin/make > > | Agreed, please revert. This was discussed at the time and FreeBSD > | behavior you have now implemented is much less

Re: CVS commit: src/usr.bin/make

2017-06-17 Thread Kamil Rytarowski
On 18.06.2017 00:16, Christos Zoulas wrote: > In article <20170617213136.ga21...@britannica.bec.de>, > Joerg Sonnenberger wrote: >> On Sat, Jun 17, 2017 at 05:28:07PM -0400, Christos Zoulas wrote: >>> On Jun 17, 9:38pm, jo...@bec.de (Joerg Sonnenberger) wrote: >>> -- Subject: Re:

Re: CVS commit: src/usr.bin/make

2017-06-17 Thread Christos Zoulas
In article <20170617222558.ga24...@britannica.bec.de>, Joerg Sonnenberger wrote: >On Sun, Jun 18, 2017 at 12:22:13AM +0200, Kamil Rytarowski wrote: >> On 18.06.2017 00:16, Christos Zoulas wrote: >> > In article <20170617213136.ga21...@britannica.bec.de>, >> > Joerg Sonnenberger

Re: CVS commit: src/usr.bin/make

2017-06-17 Thread Joerg Sonnenberger
On Sun, Jun 18, 2017 at 12:40:20AM +0200, Kamil Rytarowski wrote: > Can we reuse show-var from pkgsrc? > > $ make show-var VARNAME=MACHINE_CPU > x86_64 It's no better than just using -V '${expr}' directly. Joerg

Re: CVS commit: src/usr.bin/make

2017-06-17 Thread Christos Zoulas
On Jun 17, 9:38pm, jo...@bec.de (Joerg Sonnenberger) wrote: -- Subject: Re: CVS commit: src/usr.bin/make | Agreed, please revert. This was discussed at the time and FreeBSD | behavior you have now implemented is much less useful. You can get the original with -V '\VAR' christos

Re: CVS commit: src/usr.bin/make

2017-06-17 Thread Christos Zoulas
In article <20170617213136.ga21...@britannica.bec.de>, Joerg Sonnenberger wrote: >On Sat, Jun 17, 2017 at 05:28:07PM -0400, Christos Zoulas wrote: >> On Jun 17, 9:38pm, jo...@bec.de (Joerg Sonnenberger) wrote: >> -- Subject: Re: CVS commit: src/usr.bin/make >> >> | Agreed, please

Re: CVS commit: src/usr.bin/make

2017-06-17 Thread Kamil Rytarowski
On 18.06.2017 00:31, Christos Zoulas wrote: > In article <20170617222558.ga24...@britannica.bec.de>, > Joerg Sonnenberger wrote: >> On Sun, Jun 18, 2017 at 12:22:13AM +0200, Kamil Rytarowski wrote: >>> On 18.06.2017 00:16, Christos Zoulas wrote: In article

re: CVS commit: src/usr.bin/make

2017-06-17 Thread matthew green
"Christos Zoulas" writes: > Module Name: src > Committed By: christos > Date: Sat Jun 17 15:49:56 UTC 2017 > > Modified Files: > src/usr.bin/make: main.c > > Log Message: > -V: try to expand the variable again if the value contains a variable. how do i get the original behaviour?

Re: CVS commit: [jdolecek-ncq] src/sys/dev

2017-06-17 Thread Jonathan A. Kollasch
On Fri, Jun 16, 2017 at 08:40:49PM +, Jaromir Dolecek wrote: > Module Name: src > Committed By: jdolecek > Date: Fri Jun 16 20:40:49 UTC 2017 > > Modified Files: > src/sys/dev/ata [jdolecek-ncq]: ata.c ata_wdc.c atavar.h wd.c > src/sys/dev/ic [jdolecek-ncq]:

Re: CVS commit: [jdolecek-ncq] src/sys/dev/ata

2017-06-17 Thread Jaromír Doleček
2017-06-17 20:00 GMT+02:00 Jonathan A. Kollasch : > > I really think we need to make ata_xfer_init() private to > ata_queue_alloc(), and use ata_get_xfer() everywhere. That we can > fabricate an xfer on the stack anywhere that will trample all over an > active command slot

Re: CVS commit: src/usr.bin/make

2017-06-17 Thread Christos Zoulas
On Jun 18, 12:36am, jo...@bec.de (Joerg Sonnenberger) wrote: -- Subject: Re: CVS commit: src/usr.bin/make | Please do not unilaterally change behavior. Especially if it has been | discussed in the past. This is rude at best and not everyone shares your | opinion. Please explain the use case