Re: CVS commit: src

2018-12-26 Thread Taylor R Campbell
> Module Name:src > Committed By: thorpej > Date: Mon Dec 24 16:58:54 UTC 2018 > > Add threadpool(9), an abstraction that provides shared pools of kernel > threads running at specific priorities, with support for unbound pools > and per-cpu pools. Cool, thanks for working on

Re: CVS commit: src

2018-12-26 Thread Jason Thorpe
> On Dec 26, 2018, at 4:11 PM, Taylor R Campbell > wrote: > > Caveat: Need to > take care of the lwp name in threadpool_job_done so that we never > point at the job_name of a job in oblivion. Something like this. Index: kern_threadpool.c

Re: CVS commit: src

2018-12-26 Thread Taylor R Campbell
> Date: Wed, 26 Dec 2018 19:47:41 -0800 > From: Jason Thorpe > > > On Dec 26, 2018, at 4:11 PM, Taylor R Campbell > > wrote: > > > > Caveat: Need to > > take care of the lwp name in threadpool_job_done so that we never > > point at the job_name of a job in oblivion. > > Something like

Re: CVS commit: src

2018-12-26 Thread Jason Thorpe
I think this the way to go. I’ll look at it a little later tonight. -- thorpej Sent from my iPhone. > On Dec 26, 2018, at 4:11 PM, Taylor R Campbell > wrote: > > 2. Chuck the job reference count altogether. Just use job_thread as a > proxy for whether it's in use. User must not call >

Re: CVS commit: src

2018-12-26 Thread Jason Thorpe
> On Dec 26, 2018, at 7:52 PM, Taylor R Campbell > wrote: > > Probably wanna dereference job->job_thread _before_ setting it to > NULL! Picky, picky :-) Index: kern_threadpool.c === RCS file:

Re: CVS commit: src

2018-12-26 Thread Taylor R Campbell
> Date: Wed, 26 Dec 2018 20:09:38 -0800 > From: Jason Thorpe > > > On Dec 26, 2018, at 7:52 PM, Taylor R Campbell > > wrote: > > > > Probably wanna dereference job->job_thread _before_ setting it to > > NULL! > > Picky, picky :-) > > Index: kern_threadpool.c >

Re: CVS commit: src

2018-12-26 Thread Jason Thorpe
> On Dec 26, 2018, at 10:04 AM, Taylor R Campbell > wrote: > > Can you use a module initialization routine for this, or call it in > main if you don't want to deal with modules, instead of sprinkling > RUN_ONCE in various places? I thought about using a module initializer, the timing of

Re: CVS commit: src

2018-12-26 Thread Taylor R Campbell
Thanks, looks much nicer, and much easier to diff from my drafts! I agree it would be nice if we had a first-class way in C to mark a struct as opaque outside some module, but that's a nice-to-have rather than something that makes the aliasing hacks and manual ABI analysis worthwhile. Job

Re: CVS commit: src

2018-12-26 Thread Jason Thorpe
> On Dec 26, 2018, at 5:25 PM, Jason Thorpe wrote: > > I think this the way to go. I’ll look at it a little later tonight. > > -- thorpej > Sent from my iPhone. > >> On Dec 26, 2018, at 4:11 PM, Taylor R Campbell >> wrote: >> >> 2. Chuck the job reference count altogether. Just use

Re: CVS commit: src

2018-12-26 Thread Jason Thorpe
> On Dec 26, 2018, at 8:32 PM, Taylor R Campbell > wrote: > > LGTM if it works! Doesn't trip any asserts in the unit tests... I'm going to push this in and then do the ref counting change as a separate commit. -- thorpej

re: CVS commit: src

2018-12-26 Thread matthew green
"Maxime Villard" writes: > Module Name: src > Committed By: maxv > Date: Thu Dec 27 07:22:31 UTC 2018 > > Modified Files: > src/lib/libnvmm: libnvmm.3 libnvmm.c libnvmm_x86.c nvmm.h > src/tests/lib/libnvmm: h_mem_assist.c h_mem_assist_asm.S > > Log Message: > Several