Re: CVS commit: src/lib/libpthread

2020-02-12 Thread Kamil Rytarowski
Please apple workaround (same like in NSPR) for now if fixing is difficult. Such bugs can have security implications. On 12.02.2020 09:49, Ryo ONODERA wrote: > Hi, > > I have two problematic pkgsrc packages at least. > Of course these programs have misuses and/or bugs, however I feel that >

Re: CVS commit: src/lib/libpthread

2020-02-12 Thread Ryo ONODERA
Hi, I have two problematic pkgsrc packages at least. Of course these programs have misuses and/or bugs, however I feel that dealing pt_magic in pthread_equal() is too hasty for pkgsrc. multimedia/handbrake (internal libbluray): The invalid thread pointer is not NULL. pthread_equal t1:

Re: CVS commit: src/lib/libpthread

2020-02-12 Thread Ryo ONODERA
Hi, Kamil Rytarowski writes: > Please apple workaround (same like in NSPR) for now if fixing is difficult. > > Such bugs can have security implications. Adding workarounds will not improve security problems. And I feel that such workarounds will not be accepted by upstream. I will add

Re: CVS commit: src/lib/libpthread

2020-02-12 Thread Kamil Rytarowski
Hello, I will have a look at them. On 12.02.2020 14:02, Ryo ONODERA wrote: > Hi, > > Kamil Rytarowski writes: > >> Please apple workaround (same like in NSPR) for now if fixing is difficult. >> >> Such bugs can have security implications. > > Adding workarounds will not improve security

Re: CVS commit: src/lib/libpthread

2020-02-12 Thread Ryo ONODERA
Hi, Kamil Rytarowski writes: > Hello, > > I will have a look at them. Thank you. Real fix is welcome. And multimedia/handbrake has workaround already. I have workaround patches for lang/mono6 (like your nspr patch). I will commit them after some tests. > On 12.02.2020 14:02, Ryo ONODERA

Re: CVS commit: src/external/bsd/dhcpcd/dist/src

2020-02-12 Thread Robert Elz
Date:Thu, 13 Feb 2020 02:45:44 + From:Roy Marples Message-ID: | My understanding was if it could be promoted to an int it would be. | So it size_t is bigger in bits than uint16_t and int is also bigger then | promotion occurs and we then have signed vs

Re: CVS commit: src/external/bsd/dhcpcd/dist/src

2020-02-12 Thread Roy Marples
On 12/02/2020 23:58, Joerg Sonnenberger wrote: On Mon, Feb 10, 2020 at 04:45:35PM +, Roy Marples wrote: On 09/02/2020 19:21, Joerg Sonnenberger wrote: On Sat, Feb 08, 2020 at 12:17:16PM +, Santhosh Raju wrote: Module Name:src Committed By: fox Date: Sat Feb 8 12:17:16

Re: CVS commit: src/external/bsd/dhcpcd/dist/src

2020-02-12 Thread Roy Marples
On 13/02/2020 02:17, Joerg Sonnenberger wrote: I thought this fell under int promotion and thus became signed vs unsigned? size_t is guaranteed to be at least 16bit. If INT_MAX == 32767, an implicit cast of uint16_t would go to unsigned anyway and in all other cases, any implicit cast must be

Re: CVS commit: src/external/bsd/dhcpcd/dist/src

2020-02-12 Thread Joerg Sonnenberger
On Mon, Feb 10, 2020 at 04:45:35PM +, Roy Marples wrote: > On 09/02/2020 19:21, Joerg Sonnenberger wrote: > > On Sat, Feb 08, 2020 at 12:17:16PM +, Santhosh Raju wrote: > > > Module Name: src > > > Committed By: fox > > > Date: Sat Feb 8 12:17:16 UTC 2020 > > > > > >

Re: CVS commit: src/external/bsd/dhcpcd/dist/src

2020-02-12 Thread Joerg Sonnenberger
On Thu, Feb 13, 2020 at 02:07:23AM +, Roy Marples wrote: > On 12/02/2020 23:58, Joerg Sonnenberger wrote: > > On Mon, Feb 10, 2020 at 04:45:35PM +, Roy Marples wrote: > > > On 09/02/2020 19:21, Joerg Sonnenberger wrote: > > > > On Sat, Feb 08, 2020 at 12:17:16PM +, Santhosh Raju wrote: