Re: CVS commit: src/external/apache2/llvm/config/llvm/Config

2020-02-21 Thread Leonardo Taccari
Kamil Rytarowski writes: > [...] > ./build.sh tools for LLVM is broken when host ships with no terminfo > devel libraries. I tried to disable this superfluous feature for tools > (for colors in a terminal), but it got reverted (breaking TNF rules) here. > [...] Apart possible technical arguments,

Re: CVS commit: src/external/apache2/llvm/config/llvm/Config

2020-02-21 Thread Kamil Rytarowski
On 21.02.2020 09:17, Leonardo Taccari wrote: > Kamil Rytarowski writes: >> [...] >> ./build.sh tools for LLVM is broken when host ships with no terminfo >> devel libraries. I tried to disable this superfluous feature for tools >> (for colors in a terminal), but it got reverted (breaking TNF rules)

Re: CVS commit: src/external/apache2/llvm/config/llvm/Config

2020-02-21 Thread Kamil Rytarowski
On 21.02.2020 07:20, Martin Husemann wrote: > On Fri, Feb 21, 2020 at 03:01:45AM +0100, Kamil Rytarowski wrote: >> I consider calling ncurses-dev essential as a bug. > > My knee jerk reaction was: if a unix compiler needs terminfo (especially > when it only does that to create coloured unreadable

Re: CVS commit: src/sys/kern

2020-02-21 Thread Kamil Rytarowski
On 20.02.2020 22:14, Jaromir Dolecek wrote: > Module Name: src > Committed By: jdolecek > Date: Thu Feb 20 21:14:23 UTC 2020 > > Modified Files: > src/sys/kern: subr_autoconf.c > > Log Message: > protect deferred lists' manipulation by config_misc_lock, same as > config_pending

Re: CVS commit: src

2020-02-21 Thread Kamil Rytarowski
On 22.12.2019 20:47, Andrew Doran wrote: > Module Name: src > Committed By: ad > Date: Sun Dec 22 19:47:35 UTC 2019 > > Modified Files: > src/external/cddl/osnet/dist/uts/common/fs/zfs: zfs_ctldir.c > src/sys/kern: vfs_mount.c vfs_subr.c vfs_syscalls.c >

re: CVS commit: src/tests/lib/libc/gen

2020-02-21 Thread matthew green
> Disable ubsan instrumentation on the operation. +#if defined(__clang__) +__attribute__((no_sanitize("undefined"))) +#else +__attribute__((no_sanitize_undefined)) +#endif can we get a __disable_sanitizer or something i cdefs.h? .mrg.

Re: CVS commit: src/external/apache2/llvm/config/llvm/Config

2020-02-21 Thread Joerg Sonnenberger
On Fri, Feb 21, 2020 at 11:13:24AM +0100, Kamil Rytarowski wrote: > On 21.02.2020 07:20, Martin Husemann wrote: > > On Fri, Feb 21, 2020 at 03:01:45AM +0100, Kamil Rytarowski wrote: > >> I consider calling ncurses-dev essential as a bug. > > > > My knee jerk reaction was: if a unix compiler needs

Re: CVS commit: src/tests/modules

2020-02-21 Thread Paul Goyette
Really, the tests/modules directory should be only used for tests-that- relate-to-module-functionality. It should NOT be used for modules- that-support-tests-of-other-functionality. In the future, please do not put support modules here; put them in the samae place as the tests that they

Re: CVS commit: src/tests/lib/libc/gen

2020-02-21 Thread Kamil Rytarowski
On 21.02.2020 23:53, matthew green wrote: >> Disable ubsan instrumentation on the operation. > > +#if defined(__clang__) > +__attribute__((no_sanitize("undefined"))) > +#else > +__attribute__((no_sanitize_undefined)) > +#endif > > can we get a __disable_sanitizer or something i cdefs.h? > > >

Re: CVS commit: src/tests/modules

2020-02-21 Thread Paul Goyette
OK, I over-reacted and didn't completely read the original commit message. The t_builtin.c stuff is indeed a test-of-module-functionality so it does belong here. But some of the other stuff here does not belong, such as the threadpool, fetchstore, and kcov stuff. As far as I can see, those

Re: CVS commit: src/external/apache2/llvm/config/llvm/Config

2020-02-21 Thread Valery Ushakov
On Fri, Feb 21, 2020 at 11:13:24 +0100, Kamil Rytarowski wrote: > This patch changes cryptic failure in linking to a verbose message: > > http://netbsd.org/~kamil/patch-00231-llvm-terminfo-tools.txt > > Does it look to commit? The "devel library" is linux-specific terminology. There's no need