Re: CVS commit: src

2009-04-25 Thread Mindaugas Rasiukevicius
Module Name:src Committed By: ad Date: Sun Apr 19 14:11:38 UTC 2009 ... x86: - Make intr_establish, intr_disestablish safe to use when !cold. - Distribute hardware interrupts among the CPUs, instead of directing everything to the boot CPU. This is cool! From

Re: CVS commit: src/sys

2009-05-04 Thread Mindaugas Rasiukevicius
Antti Kantee po...@netbsd.org wrote: On Mon, May 04, 2009 at 06:05:19AM +, YAMAMOTO Takashi wrote: Module Name:src Committed By: yamt Date: Mon May 4 06:05:19 UTC 2009 Modified Files: src/sys/kern: vfs_lookup.c src/sys/nfs: nfs_srvsubs.c

Re: CVS commit: src/sys

2009-07-07 Thread Mindaugas Rasiukevicius
David Young dyo...@pobox.com wrote: It seems that pmf_event_inject() is called from interrupt context, from which kmem(9) cannot be used. You probably want to use pool_cache(9), or perhaps avoid allocations at all (since they are not intensive). Are you planning to fix it? It

Re: CVS commit: src

2009-08-03 Thread Mindaugas Rasiukevicius
y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote: Log Message: Unify kmem_alloc/zalloc/free under kmem(9). Links preserved. i intentionally made them separate pages because it's easier to read for me. (ie. no need to search in a man page.) I think we should have a manual per-subsystem:

Re: CVS commit: src

2009-08-03 Thread Mindaugas Rasiukevicius
y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote: - We already have some practices of writing documentation is such way, like mutex(9), rwlock(9), softint(9), vnode(9) and bunch of others. And I would like to keep such consistent structure. vnode(9) and sysctl(9) are good examples

Re: CVS commit: src

2009-08-26 Thread Mindaugas Rasiukevicius
Hello, y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote: hi, what's the status of this? in case it was not clear, i want you revert the changes. It does not change the way how other (and older) section 9 man pages are written, it rather makes our man pages consistent. And I strongly prefer

Re: CVS commit: src

2009-10-21 Thread Mindaugas Rasiukevicius
Thomas Klausner w...@netbsd.org wrote: On Wed, Oct 21, 2009 at 09:12:10PM +, Mindaugas Rasiukevicius wrote: Module Name:src Committed By: rmind Date: Wed Oct 21 21:12:07 UTC 2009 Modified Files: src/bin/ps: keyword.c print.c ps.1 ... src

Re: CVS commit: src

2009-10-22 Thread Mindaugas Rasiukevicius
matthew green m...@eterna.com.au wrote: Module Name: src Committed By: rmind Date: Wed Oct 21 21:28:36 UTC 2009 Modified Files: src/doc: CHANGES src/sys/sys: param.h Log Message: 5.99.21: removed uarea swap-out

Re: CVS commit: src/sys/kern

2009-11-01 Thread Mindaugas Rasiukevicius
Hello, enami tsugutomo tsugutomo.en...@jp.sony.com wrote: The test `if (selpoll)' is unnecessary if scanner function is passed directly instead of the flag. - error = selscan(l, (fd_mask *)(bits + ni * 0), - (fd_mask *)(bits + ni * 3), nd, retval); +

Re: CVS commit: src/sys

2009-11-07 Thread Mindaugas Rasiukevicius
Hello, Module Name:src Committed By: cegger Date: Sat Nov 7 07:27:50 UTC 2009 ... Log Message: Add a flags argument to pmap_kenter_pa(9). Patch showed on tech-kern@ http://mail-index.netbsd.org/tech-kern/2009/11/04/msg006434.html No objections. Since we have flags

Re: CVS commit: src

2009-11-08 Thread Mindaugas Rasiukevicius
y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote: Not sure what do you mean by leak. The first page is unmapped and uarea layout in x86 has not changed (yet). Probably I am missing something? the page in question used to be hanged on the kernel aobj. now you made it wired and there's no

Re: CVS commit: src/sys/fs/tmpfs

2009-11-11 Thread Mindaugas Rasiukevicius
Simon Burge sim...@netbsd.org wrote: Simplify tmpfs_itimes() and use vfs_timestamp(). [ ... ] Was changing from getnanotime() to effectively nanotime() (via vfs_timestamp()) deliberate? The original intention of using getnanotime() for filesystem timestamps was that having a perfect

Re: Subject: CVS commit: src/share/mk

2009-11-11 Thread Mindaugas Rasiukevicius
Hello, Module Name:src Committed By: tron Date: Wed Nov 11 16:35:45 UTC 2009 Modified Files: src/share/mk: bsd.sys.mk bsd.x11.mk Log Message: Enable Stack Smash Protection (SSP) by default for NetBSD/amd64 and NetBSD/i386 as previously discussed on the

Re: CVS commit: src/sys/arch/i386/i386

2009-11-21 Thread Mindaugas Rasiukevicius
Hello, David Laight wrote: Module Name: src Committed By: dsl Date: Sat Nov 21 19:59:51 UTC 2009 Modified Files: src/sys/arch/i386/i386: db_trace.c Log Message: Don't call lwp_getpcb() when not KERNEL. Thanks for working this around, however it is not a right fix. With

Re: CVS commit: src/sys/arch/i386/i386

2009-11-22 Thread Mindaugas Rasiukevicius
David Laight da...@l8s.co.uk wrote: Thanks for working this around, however it is not a right fix. With this patch, build.sh release passes: http://www.netbsd.org/~rmind/crash_pcb.diff It should have been enough to amend the argument of routine exported to userland. Do not you

Re: CVS commit: src/sys

2009-11-29 Thread Mindaugas Rasiukevicius
matthew green m...@eterna.com.au wrote: I've committed a quick fix. However, the problem here is that sys/sysctl.h, sys/proc.h and sys/lwp.h are exposing structures for KVM grovellers to all userspace. Therefore struct kinfo_proc2, sys/proc.h and friends should not even be seen. We

Re: CVS commit: src/sys

2009-12-09 Thread Mindaugas Rasiukevicius
Hello, Module Name:src Committed By: dyoung Date: Thu Nov 12 19:10:31 UTC 2009 Modified Files: src/sys/kern: subr_autoconf.c src/sys/sys: device.h Log Message: Move a device-deactivation pattern that is replicated throughout the system into

Re: CVS commit: src/sys/arch/vax/vax

2009-12-14 Thread Mindaugas Rasiukevicius
Hello, Module Name:src Committed By: martin Date: Sat Dec 12 12:23:29 UTC 2009 Modified Files: src/sys/arch/vax/vax: vm_machdep.c Log Message: Clear new pcb in cpu_lwp_fork, now that this seems to no longer be guaranteed to be zeroed memory after the uarea swap

Re: CVS commit: src/sys/kern

2009-12-14 Thread Mindaugas Rasiukevicius
Hello, Module Name:src Committed By: dsl Date: Sat Dec 12 17:47:05 UTC 2009 Modified Files: src/sys/kern: sys_select.c Log Message: Bounding the 'nfds' arg to poll() at the current process limit for actual open files is rather gross - the poll map isn't

Re: CVS commit: src/sys

2009-12-14 Thread Mindaugas Rasiukevicius
David Young dyo...@pobox.com wrote: - Can you tell what relevant code requires alldevs_mtx to be at IPL_HIGH? This question is still standing. - You have added config_collect_garbage(), which is mostly called before config_alldevs_lock(). How about changing it to be used as/with last

Re: CVS commit: src/sys

2009-12-18 Thread Mindaugas Rasiukevicius
Hello, Alistair Crooks a...@pkgsrc.org wrote: Log Message: Replace few USER_TO_UAREA/UAREA_TO_USER uses, reduce sys/user.h inclusions. Maybe it's just me, but I do find the ... USER_TO_UAREA/UAREA_TO_USER abstractions much more informative, especially at a first glance. Would it be

CVS commit: src/sys/kern

2009-12-30 Thread Mindaugas Rasiukevicius
Module Name:src Committed By: rmind Date: Wed Dec 30 23:31:56 UTC 2009 Modified Files: src/sys/kern: kern_sig.c Log Message: sigactsunshare(): set reference count in a case of new sigacts allocation. Bug (e.g. memory leak) can happen when using clone(2) call. To

CVS commit: src/sys/kern

2009-12-30 Thread Mindaugas Rasiukevicius
Module Name:src Committed By: rmind Date: Wed Dec 30 23:49:59 UTC 2009 Modified Files: src/sys/kern: kern_runq.c Log Message: sched_catchlwp: fix the case when other CPU might see curlwp-l_cpu != curcpu() while LWP is finishing context switch. Should fix PR/42539, tested

CVS commit: src/sys/kern

2009-12-30 Thread Mindaugas Rasiukevicius
Module Name:src Committed By: rmind Date: Wed Dec 30 23:54:30 UTC 2009 Modified Files: src/sys/kern: kern_synch.c Log Message: - nextlwp: do not set l_cpu, it should be returned correct (add assert). - resched_cpu: avoid double set of ci. To generate a diff of this

Re: CVS commit: src/sys/kern

2010-01-05 Thread Mindaugas Rasiukevicius
Michael van Elst mlel...@serpens.de wrote: On Sun, Jan 03, 2010 at 08:58:37AM -0800, Matt Thomas wrote: Log Message: drop __predict micro optimization in pool_init for cleaner code. This change should be backed out. __predict_{true,false} are not only micro optimizations, they also

CVS commit: src/sys/kern

2010-01-08 Thread Mindaugas Rasiukevicius
Module Name:src Committed By: rmind Date: Fri Jan 8 12:07:08 UTC 2010 Modified Files: src/sys/kern: subr_autoconf.c Log Message: Simplify device G/C: use global list and config_alldevs_unlock_gc(). To generate a diff of this commit: cvs rdiff -u -r1.193 -r1.194

CVS commit: src/sys/kern

2010-01-09 Thread Mindaugas Rasiukevicius
Module Name:src Committed By: rmind Date: Sat Jan 9 19:02:18 UTC 2010 Modified Files: src/sys/kern: kern_softint.c Log Message: softint_overlay: disable kernel preemption before curlwp-l_cpu use. To generate a diff of this commit: cvs rdiff -u -r1.30 -r1.31

Re: CVS commit: src/usr.sbin/wake

2010-01-11 Thread Mindaugas Rasiukevicius
chris...@astron.com (Christos Zoulas) wrote: Log Message: remove stupid casts. if lint complains about return values that are ignored, lint should fe fixed, and not code being cluttered. Please explain to me how you propose we fix lint. Or to be more precise, how does the code convey

Re: CVS commit: src/sys/kern

2010-01-11 Thread Mindaugas Rasiukevicius
David Young dyo...@pobox.com wrote: Your code had local a list of devices to G/C - it is redundant. Now there is a global list, and there is still a local list of devices to garbage collect. That is not more redundant? No, because you had local lists all over the place. There is a

Re: CVS commit: src/sys

2010-01-13 Thread Mindaugas Rasiukevicius
y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote: cvs rdiff -u -r1.158 -r1.159 src/sys/kern/kern_proc.c this part of the change looks wrong to me. ... Do you mean KSTACK_CHECK_MAGIC case? It gets included via machine/proc.h . no, the KASSERT part. l_addr !=

CVS commit: src/sys/arch/x86

2010-01-18 Thread Mindaugas Rasiukevicius
Module Name:src Committed By: rmind Date: Mon Jan 18 16:40:18 UTC 2010 Modified Files: src/sys/arch/x86/include: cpu.h src/sys/arch/x86/x86: cpu_topology.c identcpu.c Log Message: x86_cpu_topology, not toplogy. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/arch

2010-01-18 Thread Mindaugas Rasiukevicius
Module Name:src Committed By: rmind Date: Mon Jan 18 22:31:14 UTC 2010 Modified Files: src/sys/arch/amd64/amd64: procfs_machdep.c src/sys/arch/i386/i386: procfs_machdep.c Log Message: Reduce the difference between i386 and amd64 procfs MD code. Prepare for the

CVS commit: src/sys/kern

2010-01-20 Thread Mindaugas Rasiukevicius
Module Name:src Committed By: rmind Date: Wed Jan 20 23:40:42 UTC 2010 Modified Files: src/sys/kern: subr_pool.c Log Message: pool_cache_invalidate: comment out invalidation of per-CPU caches (nobody depends on it, at the moment) until we decide how to fix it (xcall(9)

CVS commit: src

2010-01-22 Thread Mindaugas Rasiukevicius
Module Name:src Committed By: rmind Date: Sat Jan 23 00:03:38 UTC 2010 Modified Files: src/distrib/sets/lists/comp: mi src/share/man/man9: Makefile Added Files: src/share/man/man9: xcall.9 Removed Files: src/share/man/man9: xc.9 Log Message: Rename

CVS commit: src

2010-01-22 Thread Mindaugas Rasiukevicius
Module Name:src Committed By: rmind Date: Sat Jan 23 00:17:07 UTC 2010 Modified Files: src/distrib/sets/lists/comp: mi src/share/man/man9: Makefile percpu.9 xcall.9 Log Message: Remove xc_init_cpu(), percpu_init(), percpu_init_cpu() - they are part of

CVS commit: src/share/man/man9

2010-01-22 Thread Mindaugas Rasiukevicius
Module Name:src Committed By: rmind Date: Sat Jan 23 00:47:04 UTC 2010 Modified Files: src/share/man/man9: xcall.9 Log Message: xcall(9): correct the point about preemption, add NOTES, do not mentioned some implementation details. To generate a diff of this commit: cvs

CVS commit: src/share/man/man9

2010-01-22 Thread Mindaugas Rasiukevicius
Module Name:src Committed By: rmind Date: Sat Jan 23 00:54:43 UTC 2010 Modified Files: src/share/man/man9: kmem.9 percpu.9 pool_cache.9 Log Message: Cross-link a little. To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 src/share/man/man9/kmem.9 cvs rdiff -u

Re: CVS commit: src/sys

2010-02-16 Thread Mindaugas Rasiukevicius
Hello, David Young dyo...@pobox.com wrote: On Sat, Nov 21, 2009 at 03:41:07PM +1100, matthew green wrote: SPLDEBUG is single-purpose. It also has some bugs, which I am happy to describe. But let's keep it until we come up with something better. now you've told me all

Re: CVS commit: src/sys

2010-02-20 Thread Mindaugas Rasiukevicius
Quentin Garnier c...@cubidou.net wrote: On Sun, Feb 21, 2010 at 02:11:40AM +, Darran Hunt wrote: Module Name:src Committed By: darran Date: Sun Feb 21 02:11:40 UTC 2010 Modified Files: src/sys/arch/i386/i386: trap.c vector.S src/sys/kern:

Re: CVS commit: src/sys

2010-02-20 Thread Mindaugas Rasiukevicius
Darran Hunt dar...@netbsd.org wrote: The new code is modular - it has its own kern_dtrace.c module. I'm not sure that replacing the #ifdefs with stub functions is the best idea - won't that make the proc and lwp functions a bit less efficient with calls to the empty functions? Compiler

Re: CVS commit: src/sys

2010-02-22 Thread Mindaugas Rasiukevicius
David Laight da...@l8s.co.uk wrote: Also: + if (dtrace_vtime_active) { + (*dtrace_vtime_switch_func)(newl); + } It is worth to give a separate cache line for dtrace_vtime_active and use __predict_false(). __predict_false() yes, but

CVS commit: src/doc

2010-03-02 Thread Mindaugas Rasiukevicius
Module Name:src Committed By: rmind Date: Wed Mar 3 02:09:51 UTC 2010 Modified Files: src/doc: CHANGES Log Message: Mention support for Gumstix Verdex Pro and SMSC LAN9118 Family Ethernet driver, which were added by kiyoh...@. To generate a diff of this commit: cvs

CVS commit: src/doc

2010-03-02 Thread Mindaugas Rasiukevicius
Module Name:src Committed By: rmind Date: Wed Mar 3 02:09:51 UTC 2010 Modified Files: src/doc: CHANGES Log Message: Mention support for Gumstix Verdex Pro and SMSC LAN9118 Family Ethernet driver, which were added by kiyoh...@. To generate a diff of this commit: cvs

Re: CVS commit: src/sys

2010-03-14 Thread Mindaugas Rasiukevicius
Hi, David Young dyo...@pobox.com wrote: On Sat, Nov 21, 2009 at 03:41:07PM +1100, matthew green wrote: SPLDEBUG is single-purpose. It also has some bugs, which I am happy to describe. But let's keep it until we come up with something better. now you've told me all

Re: CVS commit: src

2010-03-25 Thread Mindaugas Rasiukevicius
David Holland dholland-sourcechan...@netbsd.org wrote: What Joerg said. They are low level kernel implementation details. These belong in a book or article or a wiki page or something, not the manual. We just went around on this like two or three weeks ago on spl internals. On the

Re: CVS commit: src/sys (sched_pstats() + uvm_meter()/uvm_loadav())

2010-04-20 Thread Mindaugas Rasiukevicius
matthew green m...@eterna.com.au wrote: :To generate a diff of this commit: :cvs rdiff -u -r1.280 -r1.281 src/sys/kern/kern_synch.c Something is funny with this new merged load average calculation. % uptime 2:06PM up 33 mins, 1 user, load averages: 11.04,

Re: CVS commit: src/external/cddl/osnet

2010-04-23 Thread Mindaugas Rasiukevicius
chris...@astron.com (Christos Zoulas) wrote: Modified Files: src/external/cddl/osnet/dev/dtrace: dtrace_sysctl.c dtrace_unload.c src/external/cddl/osnet/dev/dtrace/amd64: dtrace_subr.c src/external/cddl/osnet/dev/dtrace/i386: dtrace_subr.c

Re: CVS commit: src/external/cddl/osnet

2010-04-23 Thread Mindaugas Rasiukevicius
chris...@zoulas.com (Christos Zoulas) wrote: | | It is consistent with the code in OpenSolaris, so it should not diverge. This is changed code that would produce a diff in either case. It is more correct, and I don't see propagating a poor choice. OpenSolaris uses NULL for 0 in many

Re: CVS commit: src/external/cddl/osnet

2010-04-23 Thread Mindaugas Rasiukevicius
David Holland dholland-sourcechan...@netbsd.org wrote: That was not an explicit preference, it was just a random choice, so I have corrected it. That is arbitrary. Can we please just stay relatively liberal (up to sane point) about small style differences each developer has?

Re: CVS commit: src/external/cddl/osnet

2010-04-23 Thread Mindaugas Rasiukevicius
chris...@zoulas.com (Christos Zoulas) wrote: | Are you planning to maintain this? That should be something for the | maintainer to decide, since it is not a small and simple code base. What I am saying is that all lines you change, they become diffs. Diffs in our preferred style or theirs

Re: CVS commit: src/lib/libc/stdio

2010-05-05 Thread Mindaugas Rasiukevicius
Jukka Ruohonen jruoho...@iki.fi wrote: On Wed, May 05, 2010 at 12:58:13AM +0700, Robert Elz wrote: | As something like gets() has been standardized for ages, it makes | sense to explicitly note that this may no longer be true (with | respect to POSIX). That's where I disagree, it

Re: CVS commit: src/sys/dev/ieee1394

2010-05-25 Thread Mindaugas Rasiukevicius
chris...@zoulas.com (Christos Zoulas) wrote: | Yes. It knows I was broken, too. However, it worked on my ofppc and | it booted my amd64. Try booting with DIAGNOSTIC. If you make any changes to the kernel you should be really compiling with DIAGNOSTIC. It should be tested both with DEBUG and

Re: CVS commit: src/sys

2010-06-22 Thread Mindaugas Rasiukevicius
Christoph Egger christoph_eg...@gmx.de wrote: Log Message: Replace tmpfs_pool custom allocator code with a simpler layer for memory accounting. Use wired memory (which can be limited) for meta-data, and kmem(9) for string allocations. Close PR/31944. Fix PR/38361 while here. OK

Re: CVS commit: src/sys/rump/librump/rumpkern

2010-06-23 Thread Mindaugas Rasiukevicius
Module Name:src Committed By: pooka Date: Wed Jun 23 08:36:03 UTC 2010 Modified Files: src/sys/rump/librump/rumpkern: emul.c Log Message: As normal, fix breakage from untested commits by rmind. Well, when I tried ./build.sh rumptest, it gave me this: ---

Re: CVS commit: src/sys

2010-06-23 Thread Mindaugas Rasiukevicius
enami tsugutomo tsugutomo.en...@jp.sony.com wrote: cvs rdiff -u -r1.11 -r1.12 src/sys/kern/subr_xcall.c Why XC_PRI_BIT is not placed at LSB instead MSB? Because you would lose the value (note, it is not a pointer). Is cpu state change (from offline to online or vise versa) cared? No,

Re: CVS commit: src/sys

2010-06-23 Thread Mindaugas Rasiukevicius
enami tsugutomo tsugutomo.en...@jp.sony.com wrote: Why XC_PRI_BIT is not placed at LSB instead MSB? Because you would lose the value (note, it is not a pointer). A flag bit at LSB can be preserved by incrementing the counter by 2, can't it? Not really, since it is advancing by CPU

Re: CVS commit: src/sys

2010-07-09 Thread Mindaugas Rasiukevicius
Chuck Silvers c...@chuq.com wrote: ... cvs rdiff -u -r1.150 -r1.151 src/sys/kern/kern_lwp.c cvs rdiff -u -r1.167 -r1.168 src/sys/kern/kern_proc.c ... I have added assert on proc_lock into proc_find(), but not proc_find_raw (), because the later is for special cases, including

Re: CVS commit: src/sys

2010-07-12 Thread Mindaugas Rasiukevicius
enami tsugutomo tsugutomo.en...@jp.sony.com wrote: cvs rdiff -u -r1.22 -r1.23 src/sys/kern/sys_select.c Do you mean ? + if (sel_flag[n] | events) { Yes. Thank you! enami. -- Mindaugas

Re: CVS commit: src/sys/arch

2010-08-17 Thread Mindaugas Rasiukevicius
Christoph Egger christoph_eg...@gmx.de wrote: Hi, Why are any types other than in the pmap different between PAE and !PAE? When this was originally proposed I asked for stuff like paddr_t to be 64 bits no matter what the kernel compile settings where. Interesting to hear

Re: CVS commit: src/sys/kern

2010-08-17 Thread Mindaugas Rasiukevicius
Juergen Hannken-Illjes hann...@eis.cs.tu-bs.de wrote: ... It's not obvious from your commit message what prevents it from gaining a reference after the lock is dropped. The interlock is taken before the freelist lock is dropped and vnodes on the free lists should never

Re: CVS commit: src/sys/dev/ieee1394

2010-08-26 Thread Mindaugas Rasiukevicius
Module Name:src Committed By: cegger Date: Thu Aug 26 12:48:19 UTC 2010 Modified Files: src/sys/dev/ieee1394: fwdev.c Log Message: don't call tsleep() with any mutexes hold To generate a diff of this commit: cvs rdiff -u -r1.23 -r1.24

Re: CVS commit: src/distrib/sets/lists/man

2010-09-01 Thread Mindaugas Rasiukevicius
Havard Eidnes h...@netbsd.org wrote: Module Name: src Committed By: he Date: Wed Sep 1 16:02:40 UTC 2010 Modified Files: src/distrib/sets/lists/man: mi Log Message: Add entries for the ntp.conf man page, html'ized and the two text variants. To generate a diff of

Converting to condvar(9) [Was: Re: CVS commit: src/sys/dev/ieee1394]

2010-09-05 Thread Mindaugas Rasiukevicius
Christoph Egger christoph_eg...@gmx.de wrote: Log Message: don't call tsleep() with any mutexes hold To generate a diff of this commit: cvs rdiff -u -r1.23 -r1.24 src/sys/dev/ieee1394/fwdev.c The right fix would be to use condvar(9). Generally, tsleep(9) should be replaced and

Re: CVS commit: src/sys/netinet

2010-10-05 Thread Mindaugas Rasiukevicius
Christoph Egger christoph_eg...@gmx.de wrote: Re-structure IPv4 reassembly code to make it more MP-friendly and simplify some code fragments while here. Also, use pool_cache(9) and mutex(9). IPv4 reassembly mechanism is MP-safe now. To generate a diff of this commit: cvs

Re: CVS commit: src/sys/netinet

2010-10-06 Thread Mindaugas Rasiukevicius
enami tsugutomo tsugutomo.en...@jp.sony.com wrote: Yes, this patch makes boot with root on nfs work again. Please commit. Just committed. enami. Thank you! -- Mindaugas

Re: CVS commit: src/sys/kern

2010-10-13 Thread Mindaugas Rasiukevicius
Hello, Masaru OKI o...@netbsd.org wrote: Module Name: src Committed By: oki Date: Thu Oct 14 03:07:52 UTC 2010 Modified Files: src/sys/kern: uipc_socket.c Log Message: Wait for freeing mbuf cluster in sosend() causes freeze network stack. Don't wait for it. problem was

Re: CVS commit: src/sys/kern

2010-10-15 Thread Mindaugas Rasiukevicius
o...@netbsd.org wrote: In M_WAIT case, m_reclaim() will run and run until get mbuf cluster if mclpool limit reached. If m_reclaim() repeatedly but cannot to get new mbuf cluster, m_clget() will not return. network stacks using mbufs is use with M_DONTWAIT, but it will failed to get new

Re: CVS commit: src/sys

2010-11-05 Thread Mindaugas Rasiukevicius
Christoph Egger christoph_eg...@gmx.de wrote: Module Name:src Committed By: rmind Date: Fri Nov 5 01:35:58 UTC 2010 Modified Files: src/sys/dist/pf/net: if_pfsync.c pf_norm.c src/sys/netinet: in_var.h ip_id.c ip_input.c Log Message:

Re: CVS commit: src/sys/kern

2010-11-11 Thread Mindaugas Rasiukevicius
y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote: hi, Module Name:src Committed By: rmind Date: Wed Oct 27 02:58:05 UTC 2010 Modified Files: src/sys/kern: sys_descrip.c Log Message: do_posix_fadvise: check for a negative length; truncate the

Re: CVS commit: src/sys/kern

2010-11-23 Thread Mindaugas Rasiukevicius
Hello, Sorry for late reply. y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote: how about the attached patch? Consider offset = (INT64_MAX - PAGE_SIZE) and len = PAGE_SIZE. That would still panic.. heh, right. then, how about: if (round_page(offset)

Re: CVS commit: src/sys/dev

2010-11-23 Thread Mindaugas Rasiukevicius
Hello, Juergen Hannken-Illjes hann...@netbsd.org wrote: Module Name: src Committed By: hannken Date: Tue Nov 23 09:30:43 UTC 2010 Modified Files: src/sys/dev: md.c Log Message: Make md(4) mp-safe. To generate a diff of this commit: cvs rdiff -u -r1.64 -r1.65

Re: CVS commit: src/sys/kern

2010-12-27 Thread Mindaugas Rasiukevicius
Antti Kantee po...@cs.hut.fi wrote: Module Name:src Committed By: rmind Date: Sat Dec 18 01:18:48 UTC 2010 Modified Files: src/sys/kern: sys_descrip.c Log Message: do_posix_fadvise: fix and improve previous change - add a comment with some

Re: CVS commit: src/sys/dev/acpi

2011-01-04 Thread Mindaugas Rasiukevicius
Jukka Ruohonen jruoho...@iki.fi wrote: +/* + * sysmon_task_queue_cancel: + * + * Cancel a scheduled task. + */ +int +sysmon_task_queue_cancel(void (*func)(void *)) +{ + struct sysmon_task *st; + + if (func == NULL) + return EINVAL; + +

Re: CVS commit: src

2011-01-25 Thread Mindaugas Rasiukevicius
Antti Kantee po...@netbsd.org wrote: Add support for the Extensible MIPS (eMIPS) platform. The NetBSD/emips port runs on Xilinx and Beecube FPGA systems and the Giano system simulator. eMIPS is a platform developed at Microsoft Research for researching reconfigurable computing. eMIPS

Re: CVS commit: src/sys

2011-02-18 Thread Mindaugas Rasiukevicius
matthew green m...@eterna.com.au wrote: Add PCU (Per-CPU Unit) - an interface to manage synchronization of any per CPU context tied with an LWP. Main use - lazy FPU handling on SMP. Requested by matt@, will be used on mips64. Note: implementation will be improved to use IPIs before

Re: CVS commit: src/sys/net

2011-02-18 Thread Mindaugas Rasiukevicius
Christos Zoulas chris...@netbsd.org wrote: Module Name: src Committed By: christos Date: Sat Feb 19 01:12:40 UTC 2011 Modified Files: src/sys/net: bpf_filter.c Log Message: Avoid stack memory disclosure by keeping track during filter validation time of initialized

Re: CVS commit: src/sys

2011-02-19 Thread Mindaugas Rasiukevicius
David Laight da...@l8s.co.uk wrote: On Sat, Feb 19, 2011 at 08:19:54PM +, Matt Thomas wrote: Log Message: Default PCU_UNIT_COUNT to 0. If 0, don't compile the contents of subr_pcu.c and don't include the pcu related members into struct lwp. Making a structure layout depend on an

Re: CVS commit: src/sys

2011-02-28 Thread Mindaugas Rasiukevicius
Jukka Ruohonen jru...@netbsd.org wrote: Module Name: src Committed By: jruoho Date: Fri Feb 25 09:16:00 UTC 2011 Modified Files: src/sys/arch/x86/acpi: acpi_cpu_md.c src/sys/dev/acpi: acpi_cpu.h acpi_cpu_pstate.c Log Message: Add preliminary support for the

Re: CVS commit: src/sys/dev/acpi

2011-02-28 Thread Mindaugas Rasiukevicius
Jukka Ruohonen jruoho...@iki.fi wrote: Are there any plans for kernel equivalent to cpuset(3)? Yes, there is kcpuset(9), see kcpuset_create() and friends. I plan to modify it so it could be used early in MD code (when memory allocation is not yet available) and thus unify random MD cpuset

Re: CVS commit: src

2011-02-28 Thread Mindaugas Rasiukevicius
Hello, y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote: Log Message: an implementation of radix tree. the idea from linux. How is that different from ptree? while i'm not familiar with ptree... Patricia/Radix tree added by Matt (see src/common/lib/libc/gen/ptree.c and

Re: CVS commit: src/sys

2011-02-28 Thread Mindaugas Rasiukevicius
Jukka Ruohonen jruoho...@iki.fi wrote: Why interrupts are disabled here? Calling xc_wait() with interrupts disabled is, at minimum, very expensive, and I would say it is wrong. Note that xc_wait(9) does not necessary spin - it can block. Because interrupts must be disabled when APERF and

Re: CVS commit: src/sys

2011-03-22 Thread Mindaugas Rasiukevicius
Antti Kantee po...@netbsd.org wrote: Module Name: src Committed By: pooka Date: Tue Mar 22 15:16:23 UTC 2011 Modified Files: src/sys/kern: subr_pool.c vfs_lookup.c src/sys/rump/librump/rumpkern: rump.c Log Message: pnbuf_cache is used all over the place outside of

Re: CVS commit: src/sys

2011-04-06 Thread Mindaugas Rasiukevicius
Antti, Can you respond, or fix? Thanks. David Holland dholland-sourcechan...@netbsd.org wrote: On Tue, Mar 22, 2011 at 04:10:16PM +, Mindaugas Rasiukevicius wrote: src/sys/kern: subr_pool.c vfs_lookup.c src/sys/rump/librump/rumpkern: rump.c Log Message: pnbuf_cache

Re: CVS commit: src/sys

2011-04-11 Thread Mindaugas Rasiukevicius
Mindaugas Rasiukevicius rm...@netbsd.org wrote: Log Message: Highly rewrite POSIX semaphore. Use file descriptor subsystem, greatly simplify reference counting, and fix various bugs which existed before, e.g. some incorrect locking or mq_unlink() not checking for permissions

Re: CVS commit: src

2011-04-12 Thread Mindaugas Rasiukevicius
Klaus Klein kle...@kleink.org wrote: Log Message: Add a small summary parge for struct tm from time.h. Cf. timeval(3). This exhibits something particularly well that's been bugging me for quite a while about such documentation changes: I think documenting the implementation's structure

Re: CVS commit: src/sys/arch/xen/xen

2011-04-17 Thread Mindaugas Rasiukevicius
Masao Uebayashi uebay...@tombi.co.jp wrote: On Mon, Apr 18, 2011 at 03:04:32AM +, Mindaugas Rasiukevicius wrote: Module Name:src Committed By: rmind Date: Mon Apr 18 03:04:31 UTC 2011 Modified Files: src/sys/arch/xen/xen: balloon.c Log Message

Re: CVS commit: src/sys/arch/xen/xen

2011-04-18 Thread Mindaugas Rasiukevicius
Cherry G. Mathew cherry.g.mat...@gmail.com wrote: On Mon, Apr 18, 2011 at 03:04:32AM +, Mindaugas Rasiukevicius wrote: Module Name:        src Committed By:       rmind Date:               Mon Apr 18 03:04:31 UTC 2011 Modified Files:     src/sys/arch/xen/xen: balloon.c

Re: CVS commit: src/sys/arch/xen/xen

2011-04-18 Thread Mindaugas Rasiukevicius
Jean-Yves Migeon jeanyves.mig...@free.fr wrote: On 18.04.2011 10:35, Mindaugas Rasiukevicius wrote: We used to check the return of big size allocations, when kmem(9) could fail even with KM_SLEEP due to KVA starvation. However, pretty much all kernel does not perform checks for smaller

Re: CVS commit: src/sys/fs/tmpfs

2011-05-14 Thread Mindaugas Rasiukevicius
Masao Uebayashi uebay...@gmail.com wrote: The kernel explicitly allows C99 and actually C99 is encouraged. So that should reverted :) Generally - C99 is encouraged.  However, I disagree that variables should be declared in the middle of context (for a minimum scope), unless there is a

Re: CVS commit: src/sys/arch/xen/xen

2011-05-15 Thread Mindaugas Rasiukevicius
Hello, Jean-Yves Migeon j...@netbsd.org wrote: Module Name: src Committed By: jym Date: Sun May 15 07:24:15 UTC 2011 Modified Files: src/sys/arch/xen/xen: xbdback_xenbus.c Log Message: Use atomic_ops(3) for ref counting. + atomic_dec_uint((xbdip)-xbdi_refcnt);

Re: CVS commit: src/sys

2011-05-16 Thread Mindaugas Rasiukevicius
Martin S. Weber ephae...@gmx.net wrote: On Mon, May 16, 2011 at 08:18:08PM +0200, Martin Husemann wrote: On Mon, May 16, 2011 at 07:29:26PM +0200, Martin S. Weber wrote: Reminds me of http://www.netbsd.org/ports/ -- remember sparc is tier 2 aka Go fix it yourself if you don't hurt

Re: CVS commit: src/sys/uvm

2011-06-17 Thread Mindaugas Rasiukevicius
Hello, Juergen Hannken-Illjes hann...@netbsd.org wrote: Module Name: src Committed By: hannken Date: Fri Jun 17 09:50:52 UTC 2011 Modified Files: src/sys/uvm: uvm_bio.c Log Message: When ubc_alloc() reuses a cached mapping window remove the object from the lists AFTER

Re: CVS commit: src/sys/uvm

2011-06-23 Thread Mindaugas Rasiukevicius
tsugutomo.en...@jp.sony.com wrote: Modified Files: src/sys/uvm: uvm_amap.c Log Message: Clean-up, add asserts, slightly simplify. To generate a diff of this commit: cvs rdiff -u -r1.95 -r1.96 src/sys/uvm/uvm_amap.c In amap_copy(), I guess map entry may be clipped and need

Re: CVS commit: src/sys/uvm

2011-06-23 Thread Mindaugas Rasiukevicius
YAMAMOTO Takashi y...@netbsd.org wrote: Module Name: src Committed By: yamt Date: Fri Jun 24 01:23:05 UTC 2011 Modified Files: src/sys/uvm: uvm_anon.c Log Message: uvm_anon_release: fix a locking error after the rmind-uvmplock merge Thanks a lot! I have been hunting

Re: CVS commit: src/sys/uvm

2011-06-29 Thread Mindaugas Rasiukevicius
y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote: hi, Module Name:src Committed By: hannken Date: Mon Jun 27 15:56:37 UTC 2011 Modified Files: src/sys/uvm: uvm_amap.c Log Message: amap_copy(): Keep the source amap locked until its lock has been

Re: CVS commit: src/sys/arch

2011-07-03 Thread Mindaugas Rasiukevicius
Manuel Bouyer bou...@netbsd.org wrote: Module Name: src Committed By: bouyer Date: Sun Jul 3 10:40:16 UTC 2011 Modified Files: src/sys/arch/amd64/conf: GENERIC src/sys/arch/i386/conf: GENERIC Log Message: Add back DIAGNOSTIC option to x86 GENERIC kernels, as

Re: CVS commit: src/sys/arch

2011-07-03 Thread Mindaugas Rasiukevicius
Manuel Bouyer bou...@antioche.eu.org wrote: On Sun, Jul 03, 2011 at 03:57:25PM +0100, Mindaugas Rasiukevicius wrote: Thanks for enabling this, however you have ignored points raised on tech-kern@. In such case, at least DEBUG DEBUG is not as usefull as DIAGNOSTIC, and is very verbose. My

Re: CVS commit: src/sys/arch

2011-07-03 Thread Mindaugas Rasiukevicius
Manuel Bouyer bou...@antioche.eu.org wrote: On Sun, Jul 03, 2011 at 06:09:10PM +0100, Mindaugas Rasiukevicius wrote: I also don't think we did reach a consensus about this either. Well, I object on adding only DIAGNOSTIC, without DEBUG and DDB trace enabled, as it is counter productive

Re: CVS commit: src/sys/uvm

2011-07-25 Thread Mindaugas Rasiukevicius
y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote: Log Message: amap_copy(): Keep the source amap locked until its lock has been copied. btw, this code seems to assume that uvm_anfree does not release the lock even temporarily while the comment on uvm_anfree1 says the opposite.

Re: CVS commit: src/sys/kern

2011-07-30 Thread Mindaugas Rasiukevicius
Masao Uebayashi uebay...@netbsd.org wrote: Module Name: src Committed By: uebayasi Date: Sat Jul 30 05:24:17 UTC 2011 Modified Files: src/sys/kern: kern_softint.c Log Message: Use kmem(9) to allocate per-cpu softint context. No functional changes. Why? The allocation

  1   2   >