Re: CVS commit: src/sys/arch/xen/xen

2011-04-04 Thread Taylor R Campbell
Date: Sun, 3 Apr 2011 23:21:39 + From: Jean-Yves Migeon j...@netbsd.org Now that pkgsrc-2011Q1 has arrived, and before -6 chimes in, change ifxname for xvif(4) from xvif%d.%d to xvif%d-%d. This is needed to avoid sysctl(9) EINVAL errors when creating interface nodes. This

Re: CVS commit: src/sys/arch/xen/xen

2011-04-06 Thread Taylor R Campbell
Date: Mon, 04 Apr 2011 23:46:19 +0200 From: Jean-Yves Migeon jeanyves.mig...@free.fr The newer scripts for Xen read the interface value from the vifname entry in Xenstore, so changing the name is not that critical. But this should be stabilized sooner than later. Personally, I find

Re: CVS commit: src/sys/fs/tmpfs

2011-08-18 Thread Taylor R Campbell
Forgot to add that this also fixes a space leak in tmpfs_rename, introduced a couple months ago, which nobody reported as far as I know. The leak sometimes caused tmpfs_renamerace_dirs to fail with ENOSPC. The problem was that renaming a directory over an empty directory would fail to decrement

Re: CVS commit: src/lib/libc

2011-10-15 Thread Taylor R Campbell
Module Name:src Committed By: christos Date: Sat Oct 15 23:00:02 UTC 2011 Modified Files: ... src/lib/libc/gen: fstab.c fts.c getcap.c getgrent.c getttyent.c getusershell.c

Re: CVS commit: src/lib/libc

2011-10-16 Thread Taylor R Campbell
Date: Sun, 16 Oct 2011 16:06:57 +1100 From: matthew green m...@eterna.com.au - open + fcntl - open O_CLOEXEC At least fts.c is used in libnbcompat, so this broke the tools build on NetBSD 5 and probably lots of other systems. this should be fixed now. Thanks, the

Re: CVS commit: src/distrib/sets/lists/modules

2012-08-04 Thread Taylor R Campbell
Date: Sat, 4 Aug 2012 12:33:23 + From: Paul Goyette pgoye...@netbsd.org Add distrib entries for new uatp module. Hello, riastradh! Oops, thanks! I had done that locally but forgotten to look at the whole `cvs diff' output on my tree before selecting which files to commit.

Re: CVS commit: src

2012-08-30 Thread Taylor R Campbell
Date: Thu, 30 Aug 2012 18:01:06 + From: David Holland dholland-sourcechan...@netbsd.org On Thu, Aug 30, 2012 at 11:44:41AM -0400, Christos Zoulas wrote: int consttime_memcmp(const void *s1, const void *s2, size_t n) [snip] so, I evidently missed this: what's

Re: CVS commit: src

2012-08-30 Thread Taylor R Campbell
Date: Thu, 30 Aug 2012 11:44:41 -0400 From: chris...@zoulas.com (Christos Zoulas) memcmp() does not promise alphabetical sorting. It just promises to do the byte comparison as unsigned so that the results are consistent. It is not complicated to do this at all, for example: int

Re: CVS commit: src

2012-08-30 Thread Taylor R Campbell
Date: Thu, 30 Aug 2012 18:44:31 + (UTC) From: chris...@astron.com (Christos Zoulas) In article 20120830170609.14dd160...@jupiter.mumble.net, Taylor R Campbell campbell+netbsd-source-change...@mumble.net wrote: Date: Thu, 30 Aug 2012 11:44:41 -0400 From: chris

Re: CVS commit: src

2012-08-30 Thread Taylor R Campbell
Date: Thu, 30 Aug 2012 19:51:13 +0100 From: David Laight da...@l8s.co.uk FWIW which versions of memset() aren't 'constant time' ? Apart from ones that try not to dirty pages. The issue with memset isn't timing attacks, but rather that the C compiler is likely to optimize away the

Re: CVS commit: src/external/bsd/sljit/dist

2012-10-02 Thread Taylor R Campbell
Date: Tue, 2 Oct 2012 09:43:39 +0200 From: Martin Husemann mar...@duskware.de The basic idea of src/external was good - however, the split into various externals (like src/external, src/crypto/external, src/sys/external) makes it a pain. One very painfull example is ipf, it is

Re: CVS commit: src/external/cddl/osnet/dist/uts/common/fs/zfs

2012-10-15 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Oct 15 14:03:06 UTC 2012 Modified Files: src/external/cddl/osnet/dist/uts/common/fs/zfs: zfs_dir.c src/external/cddl/osnet/dist/uts/common/fs/zfs/sys: zfs_znode.h Log

Re: CVS commit: src/external/cddl/osnet/dist/uts/common/fs/zfs

2012-10-16 Thread Taylor R Campbell
Date: Tue, 16 Oct 2012 09:47:32 +0200 From: Alan Barrett a...@cequrux.com On Mon, 15 Oct 2012, Taylor R Campbell wrote: @@ -796,7 +794,11 @@ zfs_link_destroy(zfs_dirlock_t *dl, znod if (zp_is_dir !zfs_dirempty(zp)) { /* dir not empty

Re: CVS commit: src/sys/kern

2012-10-20 Thread Taylor R Campbell
Date: Sat, 20 Oct 2012 04:06:13 + From: David Holland dholland-sourcechan...@netbsd.org On Fri, Oct 19, 2012 at 07:58:34AM +0100, David Laight wrote: Committed By: riastradh Date: Fri Oct 19 02:07:23 UTC 2012 rename(a/b, a/c) and rename(a/c/x,

Re: CVS commit: src/sys

2012-12-27 Thread Taylor R Campbell
From: hann...@netbsd.org Date: Thu, 20 Dec 2012 08:03:46 + --- sys/fs/msdosfs/msdosfs_vnops.c 29 Apr 2012 22:53:59 - 1.83 +++ sys/fs/msdosfs/msdosfs_vnops.c 20 Dec 2012 08:03:42 - 1.84 @@ -527,7 +527,6 @@ msdosfs_read(void *v)

Re: CVS commit: src

2013-06-23 Thread Taylor R Campbell
Date: Sun, 23 Jun 2013 10:22:12 +0200 From: Thomas Klausner w...@netbsd.org On Sun, Jun 23, 2013 at 02:35:24AM +, Taylor R Campbell wrote: rndsink(9): - Simplify API. - Simplify locking scheme. - Add a man page. mdoclint says: rndsink.9:125: trailing Xref

Re: CVS commit: src

2013-06-23 Thread Taylor R Campbell
Date: Sun, 23 Jun 2013 14:31:25 + (UTC) From: chris...@astron.com (Christos Zoulas) In article 20130623142023.6e4c760...@jupiter.mumble.net, Taylor R Campbell riastr...@netbsd.org wrote: We ought to have a man page for explicit_bzero and consttime_bcmp. I didn't realize we

Re: CVS commit: src/lib/libc/string

2013-06-23 Thread Taylor R Campbell
Date: Mon, 24 Jun 2013 01:36:29 + (UTC) From: chris...@astron.com (Christos Zoulas) I've objected many times railroading those in and casting the into stone by adding man pages and making them part of a formal release. I give up :-( Sorry, I didn't mean to stonewall or railroad

Re: CVS commit: src/lib/libc/string

2013-06-23 Thread Taylor R Campbell
Oops, that was silly of me -- the libc symbols actually have a double- underscore prefix, presumably meaning `these are internal; do not use'. Should I move the man pages to section 9, or do we want these exposed in libc, presumably requiring some weak aliasing cruft? Discuss on tech-userlevel?

Re: CVS commit: src

2013-06-24 Thread Taylor R Campbell
Date: Mon, 24 Jun 2013 09:52:14 +0200 From: Alan Barrett a...@cequrux.com I think that the names explicit_memzero() and consttime_memeq() are fine, but I'd expect consttime_memeq() have the opposite polarity from consttime_bcmp(), because it should be answering the question

Re: CVS commit: src

2013-06-24 Thread Taylor R Campbell
Date: Mon, 24 Jun 2013 17:22:34 +0200 From: Thomas Klausner w...@netbsd.org I tried 'make distribution' twice now, second time after completely removing tools and obj dirs, but it doesn't finish for me. I see: --- dependall-client --- /lib/libcrypt.so.1: undefined reference to

Re: CVS commit: src

2013-07-04 Thread Taylor R Campbell
Date: Thu, 04 Jul 2013 08:51:09 +0100 From: Nick Hudson sk...@netbsd.org On 06/23/13 03:35, Taylor R Campbell wrote: + * rndsink_request takes a spin lock at IPL_VM, so we can be no + * higher than that. + */ + KASSERT(ipl = IPL_VM); This isn't always the case

Re: CVS import: src/external/bsd/dhcpcd/dist

2013-07-20 Thread Taylor R Campbell
Date: Sat, 20 Jul 2013 07:20:42 + From: David Holland dholland-sourcechan...@netbsd.org to wit: I just extracted nearly 20,000 uname outputs from gnats, and found around 5500 unique hostnames of which only about 60% contained a dot. Out of curiosity, how many of them were

Re: CVS commit: [riastradh-drm2] src/sys/external/bsd/drm2/include/linux

2013-07-25 Thread Taylor R Campbell
Date: Wed, 24 Jul 2013 08:05:11 +0100 From: David Laight da...@l8s.co.uk On Wed, Jul 24, 2013 at 02:12:29AM +, Taylor R Campbell wrote: Add __le16, __le32, and __le64 to linux/types.h. As far as I'm aware, these aliases are correct, and the type doesn't actually have

Re: CVS commit: [riastradh-drm2] src/sys/external/bsd/drm2/include/linux

2013-07-25 Thread Taylor R Campbell
Date: Wed, 24 Jul 2013 07:34:25 +0100 From: Nick Hudson sk...@netbsd.org Can't we please put these compat stubs somewhere common, e.g. sys/external/bsd/compat/linux No objection here (although I think we should probably add a new top-level sys directory, say sys/shims or

Re: CVS commit: [riastradh-drm2] src/sys/external/bsd/drm2/dist/drm/i915

2013-07-25 Thread Taylor R Campbell
Date: Wed, 24 Jul 2013 08:48:29 +0100 From: David Laight da...@l8s.co.uk On Wed, Jul 24, 2013 at 03:47:07AM +, Taylor R Campbell wrote: Kludge around max as a local variable in intel_panel.c. Possibly adding a #define for max/min before/after including the netbsd header

Re: CVS commit: src/sys/modules/lua

2013-10-18 Thread Taylor R Campbell
From: Marc Balmer mbal...@netbsd.org Date: Wed, 16 Oct 2013 19:44:58 + welcome lua(4), a devide driver that can create and control Lua states inside the kernel Did you get core approval for this? The public discussion is still ongoing, and still lacking in evidence, and there

Re: CVS commit: src/tests/lib/libc/net

2013-10-24 Thread Taylor R Campbell
Date: Thu, 24 Oct 2013 08:01:51 -0700 (PDT) From: Paul Goyette p...@whooppee.com Although my host machine has full connectivity, including IPv6, the tests are run under qemu. The qemu virtual machine has a default nic available, but there is nothing in the test-bed set-up to

Re: CVS commit: src

2013-10-25 Thread Taylor R Campbell
Date: Wed, 23 Oct 2013 18:57:41 + From: Marc Balmer mbal...@netbsd.org use MODULE_CLASS_MISC for Lua modules Please back out all these changes for kernel Lua until you have actually addressed any of the concerns on tech-kern. Dismissing objections and lying about core approval to

Re: CVS commit: src/share/mk

2014-01-23 Thread Taylor R Campbell
Date: Thu, 23 Jan 2014 03:11:14 + From: Taylor R Campbell campbell+netbsd-source-change...@mumble.net Date: Wed, 22 Jan 2014 13:15:44 -0500 From: chris...@zoulas.com (Christos Zoulas) On Jan 22, 7:29am, m...@3am-software.com (Matt Thomas) wrote: -- Subject: Re

Re: CVS commit: src/sys/opencrypto

2014-01-24 Thread Taylor R Campbell
Date: Fri, 24 Jan 2014 17:35:41 + (UTC) From: chris...@astron.com (Christos Zoulas) In article 7458.1390534...@splode.eterna.com.au, matthew green m...@eterna.com.au wrote: Log Message: XXX Also note that there is still a small window where the ref-count can XXX

Re: CVS commit: src/sys/opencrypto

2014-01-26 Thread Taylor R Campbell
Date: Sun, 26 Jan 2014 11:36:32 + From: David Laight da...@l8s.co.uk It also sounds like manual unloads of drivers can happen when the device is open - and that is also bad. A manual unload probably isn't going to race with open or close though. Disallowing unload

Re: CVS commit: [riastradh-drm2] src/sys/external/bsd/drm2/i915drm

2014-01-30 Thread Taylor R Campbell
Date: Thu, 30 Jan 2014 15:28:00 +1100 from: matthew green m...@eterna.com.au Defer i915drm_attach_framebuffer until interrupts are running. The i915 code initialization relies on counting hardclock ticks for a delay (ugh). Not an issue for modules, but it will

Re: CVS commit: [riastradh-drm2] src/sys

2014-01-30 Thread Taylor R Campbell
Date: Thu, 30 Jan 2014 15:29:31 +1100 from: matthew green m...@eterna.com.au The drm2 `drm' device is now called `drmkms' (likewise `i915drmkms', c.) so that it can coexist with the old drm code to reduce diffs from HEAD. (Can't call a device `drm2'.) there's probably a way

Re: CVS commit: src/sys

2014-02-06 Thread Taylor R Campbell
Date: Thu, 6 Feb 2014 10:57:13 + From: Juergen Hannken-Illjes hann...@netbsd.org Move fstrans_start()/fstrans_done() into genfs_insane_rename() to protect the complete rename operation like we do for all other vnode operations. I've always been a little fuzzy on the rules for

Re: CVS commit: xsrc/external/mit/libdrm/dist

2014-03-21 Thread Taylor R Campbell
Date: Fri, 21 Mar 2014 22:51:15 + (UTC) From: chris...@astron.com (Christos Zoulas) +#ifdef __NetBSD__ /* XXX */ That ifdef could just be DRM_IOCTL_MMAP I guess so, but it's only on NetBSD that mmap actually doesn't work and you have to use DRM_IOCTL_MMAP. It's also

Re: CVS commit: src/sys

2014-04-01 Thread Taylor R Campbell
Date: Tue, 1 Apr 2014 17:47:36 + From: Taylor R Campbell riastr...@netbsd.org First draft of drivers for the Apple System Management Controller. I've been sitting on this code for over a year now since I wrote it shortly before my MacBook's disk died and I moved to a different

Re: CVS commit: src/sys/external/bsd/drm2

2014-04-04 Thread Taylor R Campbell
Date: Fri, 04 Apr 2014 11:06:45 +1100 from: matthew green m...@eterna.com.au Taylor R Campbell writes: Enable drm debug output iff boothowto has AB_DEBUG set. does this mean i can only get drm debug output when i turn on all the other debug modules? it would be nice

CVS commit: src/sys/dev/ic

2014-04-07 Thread Taylor R Campbell
Date: Tue, 1 Apr 2014 23:57:54 + From: Brian Buhrow buh...@netbsd.org Modified Files: src/sys/dev/ic: mpt_netbsd.c mpt_netbsd.h Log Message: Checking in changes to improve error handling. Specifically: There are a lot of KNF issues in this change, making it hard

Re: CVS commit: src/sys/external/bsd/drm2/i915drm

2014-04-07 Thread Taylor R Campbell
Date: Mon, 7 Apr 2014 11:36:16 +0900 From: NONAKA Kimihiro nona...@gmail.com PR/48705 is useful for you? Thanks, I will take a look.

Re: CVS commit: src/sys/external/bsd/drm2

2014-04-09 Thread Taylor R Campbell
Date: Wed, 9 Apr 2014 20:30:24 +0300 From: Jukka Ruohonen jruoho...@iki.fi On Fri, Apr 04, 2014 at 11:47:47AM +, Taylor R Campbell wrote: For now, yes. I can make it a sysctl, but do you have a suggestion for how to enable it at boot? We don't have any notion of module

Re: CVS commit: src/sys

2014-04-09 Thread Taylor R Campbell
Date: Thu, 10 Apr 2014 07:22:04 +0300 From: Jukka Ruohonen jruoho...@iki.fi On Tue, Apr 01, 2014 at 05:59:34PM +, Taylor R Campbell wrote: (That code was based on a userland version using i386_iopl, inb, and outb which I did confirm to work; I've just never run it in-kernel

Re: CVS commit: src/sys/dev/ic

2014-04-11 Thread Taylor R Campbell
Date: Thu, 10 Apr 2014 10:22:14 -0700 From: Brian Buhrow buh...@nfbcal.org hello. Yes, if you could be more specific about what you're asking for, I'll be happy to make the fixes. Here are the ones I see. Most of these are indentation issues. I know these all look like

Re: CVS commit: src/sys/kern

2014-04-15 Thread Taylor R Campbell
Date: Tue, 15 Apr 2014 09:50:45 + From: Juergen Hannken-Illjes hann...@netbsd.org Fix a deadlock where one thread exits, enters fstrans_lwp_dtor() and wants fstrans_lock. This thread holds the proc_lock. This sounds fishy. lwp_exit does not hold proc_lock while calling

Re: CVS commit: src

2014-04-20 Thread Taylor R Campbell
From: Maxime Villard m...@netbsd.org Date: Wed, 16 Apr 2014 18:55:20 + An (un)privileged user can easily make the kernel dereference a NULL pointer. The kernel allows 'data' to be NULL; it's the fs's responsibility to ensure that it isn't NULL (if the fs actually needs

Re: CVS commit: src

2014-04-21 Thread Taylor R Campbell
Date: Mon, 21 Apr 2014 08:20:22 +0200 From: Maxime Villard m...@m00nbsd.net Le 21/04/2014 01:46, Taylor R Campbell a écrit : In most cases of the changes you made, there is already a test for the length of the data buffer. Is this not guaranteed to be zero if data is null

Re: CVS commit: src/sys

2014-04-25 Thread Taylor R Campbell
Date: Fri, 25 Apr 2014 23:54:59 + From: Taylor R Campbell riastr...@netbsd.org Modified Files: src/sys/dev/ic: apple_smc.c ... Log Message: Implement Linux dmi_check_system API. Oops, that file was not supposed to be included in this commit. Must have failed

Re: CVS commit: src/lib/libc

2014-06-23 Thread Taylor R Campbell
Date: Mon, 23 Jun 2014 22:29:03 +0200 From: Joerg Sonnenberger jo...@britannica.bec.de On Mon, Jun 23, 2014 at 07:46:15PM +, Taylor R Campbell wrote: Read from /dev/urandom. It scales better in multithreaded programs, avoids fork issues (hanging, duplicate key streams

Re: CVS commit: src/sys/dev/usb

2014-07-17 Thread Taylor R Campbell
Date: Fri, 18 Jul 2014 11:58:33 +1000 from: matthew green m...@eterna.com.au Taylor R Campbell writes: Fix usb task queue locking. why does this take the lock and then use atomic operations? Reading task-queue is not covered by a lock: until you know what it is you don't know

Re: CVS commit: src/sys/arch

2014-07-25 Thread Taylor R Campbell
Date: Fri, 25 Jul 2014 10:23:31 +1000 from: matthew green m...@eterna.com.au Taylor R Campbell writes: Add a FIRST1G page freelist to x86, for old graphics devices. other devices that do this didn't have to change the platform code to do it. see bce(4), which is limited

C++ keyword/scope/c. changes

2014-09-08 Thread Taylor R Campbell
Why the sudden spate of changes in the kernel to change keywords, move struct and enum definitions, insert pointless casts, c.? Was this discussed anywhere?

Re: CVS commit: src/sys/arch/x86/pci

2014-10-20 Thread Taylor R Campbell
Date: Sat, 18 Oct 2014 17:43:10 +0900 From: Masao Uebayashi uebay...@gmail.com On Sat, Oct 18, 2014 at 5:55 AM, Masao Uebayashi uebay...@netbsd.org wrote: Fix another indirect circular dependency (agp_* - (agpbus) - pchb - abp_*). Fixes no agp* build. Reported build-tested by

Re: CVS commit: src/usr.bin/config

2014-10-30 Thread Taylor R Campbell
Date: Fri, 31 Oct 2014 03:36:45 +0900 From: Masao Uebayashi uebay...@gmail.com On Fri, Oct 31, 2014 at 1:49 AM, David Holland dholland-sourcechan...@netbsd.org wrote: On Thu, Oct 30, 2014 at 09:27:06PM +0900, Masao Uebayashi wrote: At this moment, no are evaluated when it's

Re: CVS commit: src/sys/dev

2014-11-05 Thread Taylor R Campbell
Date: Thu, 6 Nov 2014 01:54:12 +0900 From: Masao Uebayashi uebay...@gmail.com For future reference: I think any xxxbus interface attribute (aka bus) should provide xxxbusprint (and xxxbussubmatch if multiple children). I'll probably change config(1) to extend cfiattrdata like:

Re: CVS commit: src/sys/arch/atari/stand/installboot

2014-11-15 Thread Taylor R Campbell
Date: Sat, 15 Nov 2014 13:43:16 +0900 From: Izumi Tsutsui tsut...@ceres.dti.ne.jp -uint16_t sum; +union { +struct bootblock *bbp; +uint16_t *word; /* to fill cksum word */ +} bbsec; ... -sum = 0; -

Re: CVS commit: src/sys/arch/atari/stand/installboot

2014-11-16 Thread Taylor R Campbell
Date: Sun, 16 Nov 2014 12:51:34 +0900 From: Izumi Tsutsui tsut...@ceres.dti.ne.jp My understanding is the strict aliasing rule is referred by compiler for reorder optimization etc. If the access via union is still invalid, why does the strict gcc48 no longer complain against it?

Re: CVS commit: src/sys/arch/atari/stand/installboot

2014-11-16 Thread Taylor R Campbell
Date: Mon, 17 Nov 2014 01:37:37 +0900 From: Izumi Tsutsui tsut...@ceres.dti.ne.jp Changing `*(uint16_t *)p = v' to `memcpy(p, v, 2)' doesn't change any of that. The formar can be easily changed *(uint16_t *)p = htobe16(v); but the latter can't. You might be able to use

Re: CVS commit: src/sys/arch/atari/stand/installboot

2014-11-17 Thread Taylor R Campbell
Date: Mon, 17 Nov 2014 15:55:56 +0100 From: Martin Husemann mar...@duskware.de On Mon, Nov 17, 2014 at 11:48:49PM +0900, Izumi Tsutsui wrote: You don't think consistently using uint16_t assingments is not necessary. I think it's necessary to explicitly describe how cksum should

Re: CVS commit: src/sys/arch/atari/stand/installboot

2014-11-23 Thread Taylor R Campbell
How about we take one of tsutsui@'s earlier suggestions and compile the code in question with -fno-strict-aliasing, and revert to the original code, until someone can go over the whole thing to clean up the strict-aliasing violations? That way, the bad code will work as originally intended and

Re: CVS commit: src/sys/arch/atari/stand/installboot

2014-11-23 Thread Taylor R Campbell
Date: Mon, 24 Nov 2014 03:20:27 +0900 From: Izumi Tsutsui tsut...@ceres.dti.ne.jp riastradh@ wrote: As is, there are obviously violations, but we have papered over them enough that GCC isn't smart enough to warn about them: the void * cast through abcksum I'd like to

Re: CVS commit: src/sys/arch/atari/stand/installboot

2014-11-23 Thread Taylor R Campbell
Date: Mon, 24 Nov 2014 04:46:31 +0900 From: Izumi Tsutsui tsut...@ceres.dti.ne.jp Christos said it is legally converting a void * pointer. http://mail-index.netbsd.org/source-changes-d/2014/11/16/msg007356.html You guys have different opinions. Which is correct? Which C99

Re: CVS commit: src/sys/arch/atari/stand/installboot

2014-11-24 Thread Taylor R Campbell
Date: Mon, 24 Nov 2014 22:39:24 +0900 From: Izumi Tsutsui tsut...@ceres.dti.ne.jp I don't think it's worth because binaries have worked without changes. (if the compiler tries reorder optimization per strict-aliasing rule I guess wrong implementation will be warned at that time)

Re: CVS commit: src/sys/arch/atari/stand/installboot

2014-11-24 Thread Taylor R Campbell
Date: Mon, 24 Nov 2014 23:50:12 +0900 From: Izumi Tsutsui tsut...@ceres.dti.ne.jp If you can confirm current netbsd-7 or netbsd-6 binaries are already broken, please let me know. I can't say without actually scrutinizing the generated code. It would be safer to just set

Re: CVS commit: src/sys/external/bsd/drm2/dist/drm/radeon

2015-03-03 Thread Taylor R Campbell
Date: Wed, 04 Mar 2015 09:24:22 +1100 from: matthew green m...@eterna.com.au Taylor R Campbell writes: Module Name: src Committed By: riastradh Date: Tue Mar 3 13:57:20 UTC 2015 Modified Files: src/sys/external/bsd/drm2/dist/drm/radeon

Re: CVS commit: src/share/misc

2015-04-21 Thread Taylor R Campbell
Date: Mon, 13 Apr 2015 00:39:57 + From: Blue Rats rod...@netbsd.org Welcome to 2015, acronyms. --- src/share/misc/acronyms:1.224 Sun May 25 21:49:29 2014 +++ src/share/misc/acronyms Mon Apr 13 00:39:57 2015 @@ -469,6 +486,7 @@ SWAHBI silly, wild-assed

Re: CVS commit: src/share/man/man9

2015-04-20 Thread Taylor R Campbell
Date: Mon, 20 Apr 2015 16:14:08 +0200 From: Thomas Klausner w...@netbsd.org On Mon, Apr 20, 2015 at 02:09:14PM +, Taylor R Campbell wrote: Module Name: src Committed By: riastradh Date: Mon Apr 20 14:09:14 UTC 2015 Modified Files

Re: CVS commit: src/share/misc

2015-04-23 Thread Taylor R Campbell
Date: Wed, 22 Apr 2015 22:58:41 + From: Blue Rats rod...@netbsd.org Modified Files: src/share/misc: acronyms Log Message: +SJW :) The appropriate course of action in response to the multiple complaints you've had is to apologize for making a hostile environment for

Re: CVS commit: src/sys/dev/sysmon

2015-04-28 Thread Taylor R Campbell
Date: Tue, 28 Apr 2015 17:01:10 +0800 (PHT) From: Paul Goyette p...@vps1.whooppee.com Well, it really is a (pseudo-)device, and even has its own major device number. We cannot avoid all of the device goop, since a non-built-in-module would still have to merge in the devsw.

Re: CVS commit: src/sys/dev/sysmon

2015-04-27 Thread Taylor R Campbell
Date: Thu, 23 Apr 2015 23:22:03 + From: Paul Goyette pgoye...@netbsd.org Modularize sysmon and its components Why does this introduce a sysmon(4) autoconf device? It seems like needless bookkeeping -- you could just make the mutex global, like all the state it protects, and skip

Re: CVS commit: src/external/cddl/osnet

2015-04-11 Thread Taylor R Campbell
Date: Sat, 11 Apr 2015 15:12:01 +1000 from: matthew green m...@eterna.com.au Taylor R Campbell writes: When modifying, double-check that libnvpair.so defines no xdr_* symbols, only _solaris_xdr_*. (XXX Put this note somewhere...) somewhere == doc/HACKS. It's not really

Re: CVS commit: src

2015-05-29 Thread Taylor R Campbell
Date: Fri, 29 May 2015 14:57:16 + From: Emmanuel Dreyfus m...@netbsd.org I have seen that with older libc: setting breackpoints on pthread_key_create() and pthread_setspecific() shows that malloc() calls the later without calling the former, which is a bug. It worked before

Re: libutil shlib_version lossage

2015-08-17 Thread Taylor R Campbell
Date: Fri, 14 Aug 2015 03:23:08 + From: Taylor R Campbell campbell+netbsd-source-change...@mumble.net Something very strange happened recently, which I noticed by tracing the forced update in joerg@'s Git mirror: [...] Whisky tango foxtrot? Did someone botch a cvs admin

Re: CVS commit: src/sys

2015-07-31 Thread Taylor R Campbell
Date: Fri, 31 Jul 2015 20:24:24 +0200 From: Martin Husemann mar...@duskware.de Index: Makefile === RCS file: /cvsroot/src/tests/lib/libc/sys/Makefile,v retrieving revision 1.39 diff -u -r1.39 Makefile ---

libutil shlib_version lossage

2015-08-13 Thread Taylor R Campbell
Something very strange happened recently, which I noticed by tracing the forced update in joerg@'s Git mirror: +Author: christos christos +Date: Sat Apr 7 16:44:39 2012 + + +Bump shlib minor for new function: ereallocarr(3) + +Noted by mrg + diff

Re: CVS commit: src/sys/dev/pci

2015-11-06 Thread Taylor R Campbell
Date: Sat, 07 Nov 2015 09:11:23 +1100 from: matthew green "NONAKA Kimihiro" writes: > Modified Files: >src/sys/dev/pci: if_iwm.c if_iwmvar.h if_rtwn.c if_rtwnreg.h rtsx_pci.c > > Log Message: > Always use pci_intr_alloc(9)/pci_intr_release(9).

Re: CVS commit: src/lib/libc

2015-07-11 Thread Taylor R Campbell
Date: Sun, 12 Jul 2015 01:48:10 +1000 from: matthew green m...@eterna.com.au thanks for doing this. however, i noticed one problem: (3) an ELF global symbol `__foo50' implementing its new signature (yes, `__foo50', not `__foo60'). this is not actually the way we'd

Re: CVS commit: src/bin/sh

2016-01-04 Thread Taylor R Campbell
Date: Mon, 4 Jan 2016 20:06:55 -0500 From: chris...@zoulas.com (Christos Zoulas) On Jan 5, 5:33am, k...@munnari.oz.au (Robert Elz) wrote: -- Subject: Re: CVS commit: src/bin/sh | | Does the exec'ed program know what to do with fd > 2? | | Is it hard-coded, or do we specify

Re: CVS commit: src/share/man/man4

2016-01-06 Thread Taylor R Campbell
Date: Wed, 6 Jan 2016 12:00:32 +0800 (PHT) From: Paul Goyette On Wed, 6 Jan 2016, Paul Goyette wrote: > Hmmm. I'm looking at the filemon_open() code. It seems to have a "fd" > variable that gets set by fd_allocfile(). The value is later passed to >

Re: CVS commit: src

2016-06-15 Thread Taylor R Campbell
Date: Wed, 15 Jun 2016 13:01:16 +0200 From: Joerg Sonnenberger On Wed, Jun 15, 2016 at 05:01:58AM +, matthew green wrote: > replace the previous hack with something that i believe is actually > correct and, more importantly ;), works properly. This is still

Re: CVS commit: src/external/mit/xorg/lib

2016-02-26 Thread Taylor R Campbell
Date: Fri, 26 Feb 2016 23:08:14 +0100 From: Joerg Sonnenberger <jo...@britannica.bec.de> On Fri, Feb 26, 2016 at 09:20:17PM +, Taylor R Campbell wrote: > Disable C++11 warnings about `register' qualifiers in glsl_lexer.cpp. > > glsl_lexer.cpp was gene

Re: CVS commit: src/sys/net

2016-02-15 Thread Taylor R Campbell
Date: Mon, 15 Feb 2016 11:06:52 + From: Roy Marples On 15/02/2016 10:32, Ryota Ozaki wrote: > I think we can fix by returning from if_link_state_change_si > if ifp->if_link_state == ifp->if_old_link_state. Is it correct? Then we're not doing what we

Re: CVS commit: src/sys/net

2016-02-16 Thread Taylor R Campbell
Date: Tue, 16 Feb 2016 16:30:54 +0900 From: Ryota Ozaki <ozak...@netbsd.org> On Tue, Feb 16, 2016 at 6:16 AM, Taylor R Campbell <campbell+netbsd-source-change...@mumble.net> wrote: > void > if_link_state_change(struct ifnet *ifp, int link_state) >

Re: CVS commit: src/sys/net

2016-02-16 Thread Taylor R Campbell
Date: Tue, 16 Feb 2016 13:24:15 + From: Roy Marples I found the time to work on this, here is the patch I've been running for an hour or so upping and downing interfaces. The rule in Roy's patch is that each new state changes kicks out all higher-priority

Re: CVS commit: src/sys/net

2016-02-16 Thread Taylor R Campbell
Date: Wed, 17 Feb 2016 11:49:48 +0900 From: Ryota Ozaki And the priority provides asymmetric event deliveries; when the state repeats up and down, a down event is delivered if the final state is down while a down event and a up event are delivered if the final

Re: CVS commit: src/sys/net

2016-02-16 Thread Taylor R Campbell
Date: Wed, 17 Feb 2016 15:12:31 +0900 From: Ryota Ozaki <ozak...@netbsd.org> On Wed, Feb 17, 2016 at 2:13 PM, Taylor R Campbell <campbell+netbsd-source-change...@mumble.net> wrote: > Note that this queueing takes effect only if the link state changes > mul

Re: CVS commit: src

2016-04-13 Thread Taylor R Campbell
Date: Wed, 13 Apr 2016 16:46:17 +0900 From: Ryota Ozaki I'm trying to apply psref to bridge(4) and it's mostly done (*). Nice! I'll take a look when I have some time. However, I have an issue; I got a KASSERT failure in psref_held with the following output

Re: CVS commit: src/sys/net

2016-04-11 Thread Taylor R Campbell
Date: Mon, 11 Apr 2016 14:33:41 +0900 From: Ryota Ozaki <ozak...@netbsd.org> On Mon, Apr 11, 2016 at 12:31 PM, Taylor R Campbell <campbell+netbsd-source-change...@mumble.net> wrote: > Nice, thanks for doing this! Have you tried subjecting it to load, > with

Re: CVS commit: src/sys/net

2016-04-10 Thread Taylor R Campbell
Date: Mon, 11 Apr 2016 02:04:14 + From: Ryota Ozaki Module Name:src Committed By: ozaki-r Date: Mon Apr 11 02:04:14 UTC 2016 Modified Files: src/sys/net: bridgestp.c if_bridge.c if_bridgevar.h Log Message: Use pslist(9)

Re: CVS commit: src/sys/dev/pci

2017-02-01 Thread Taylor R Campbell
> Date: Thu, 2 Feb 2017 03:57:21 + > From: co...@sdf.org > > On Thu, Feb 02, 2017 at 03:41:22AM +, Jonathan A. Kollasch wrote: > > @@ -432,6 +433,10 @@ wpi_detach(device_t self, int flags __un > > pci_intr_disestablish(sc->sc_pct, sc->sc_ih); > > sc->sc_ih = NULL;

Re: CVS commit: src/sys/dev

2017-02-24 Thread Taylor R Campbell
> Date: Fri, 24 Feb 2017 21:49:12 +0900 (JST) > From: Ryo ONODERA > > panic: LOCKDEBUG: Mutex error: mutex_vector_exit,717: exiting unheld spin > mutex > fatal breakpoint trap in supervisor mode > trap type 1 code 0 rip 80215365 cs 8 rflags 246 cr2 7e01df80e010 >

Re: CVS commit: src/sys/dev/ic

2016-09-19 Thread Taylor R Campbell
Date: Mon, 19 Sep 2016 01:36:14 + From: David Holland On Sun, Sep 18, 2016 at 09:52:37PM +, Jaromir Dolecek wrote: > Modified Files: > src/sys/dev/ic: ld_nvme.c > > Log Message: > must use PR_NOWAIT also during

Re: CVS commit: src/sys/dev/pci

2016-10-25 Thread Taylor R Campbell
Date: Wed, 26 Oct 2016 06:10:39 +0800 (PHT) From: Paul Goyette There's only 9 snprintf() calls. I could simply provide a macro: #define ADD_TEXT(dest, end, format, ...) \ {\

Re: CVS commit: src/tests/lib/libpthread

2016-10-31 Thread Taylor R Campbell
Date: Mon, 31 Oct 2016 18:29:56 +0100 From: Kamil Rytarowski pthread_mutex_timedlock(3) is broken and it does not work at all for me, not as a standard mutex (like pthread_mutex_lock(3), sufficiently lengthy timeout makes it a good approximation) neither as a timed

Re: CVS commit: src/sys

2017-01-04 Thread Taylor R Campbell
Date: Wed, 04 Jan 2017 14:51:01 +0700 From: Robert Elz Date:Wed, 04 Jan 2017 14:23:12 +0700 From:Robert Elz Message-ID: <3987.1483514...@andromeda.noi.kre.to> Ignore this gibberish.. | division into a

Re: CVS commit: src/sys

2017-01-04 Thread Taylor R Campbell
Date: Wed, 04 Jan 2017 10:58:47 +0100 From: Frank Kardel I agree, the decision is whether we want bintime in the export format. Sounds good to me. We should use bintime more often. I have been meaning to add some high-resolution timer-related APIs that use it,

Re: CVS commit: src/sys/kern

2016-12-28 Thread Taylor R Campbell
Date: Wed, 28 Dec 2016 17:36:04 + From: co...@sdf.org On Wed, Dec 28, 2016 at 12:05:58AM +, Roy Marples wrote: > Can you please explain how the security model was broken? intention with securelevel is to do less things kernel-side if it is raised (which, I hope, reduces

Re: CVS commit: src/sys

2016-12-16 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Fri Dec 16 23:35:04 UTC 2016 Modified Files: src/sys/kern: subr_devsw.c src/sys/sys: conf.h Log Message: Fix return value of nommap. Oops. It turns out on closer inspection -- in spite of the

Re: CVS commit: src/lib/libpthread

2017-03-28 Thread Taylor R Campbell
> Date: Tue, 28 Mar 2017 20:10:24 +0200 > From: Joerg Sonnenberger > > On Tue, Mar 28, 2017 at 05:42:53PM +, Maya Rashish wrote: > > Remove outdated CAVEATS. > > > > Not sure everything is standards compliant, but I've been told non-default > > values are supported and pshared

Re: CVS commit: src/sys/net

2017-04-05 Thread Taylor R Campbell
> Date: Wed, 5 Apr 2017 15:46:38 +0800 (+08) > From: Paul Goyette > > @@ -3385,6 +3428,13 @@ if_mcast_op(ifnet_t *ifp, const unsigned > { > int rc; > struct ifreq ifr; > + bool need_unlock = false; > + > + /* XXX if_ioctl_lock may or may not be

Re: CVS commit: src/sbin/fsck_ext2fs

2017-04-21 Thread Taylor R Campbell
> Date: Fri, 21 Apr 2017 17:47:22 + > From: co...@sdf.org > > /home/source/ab/HEAD-llvm/src/sbin/fsck_ext2fs/pass1.c:242:39: warning: > comparison of array 'dp->e2di_blocks' equal to a null pointer is always false > [-Wtautological-pointer-compare] > (EXT2_MAXSYMLINKLEN

  1   2   3   >