Re: CVS commit: src/sys/fs/tmpfs

2009-04-27 Thread YAMAMOTO Takashi
remove/rename operation. because it's what ufs expects. :-) i introduced cache_lookup_raw for nfs, which doesn't want these behaviours. i wanted to replace cache_lookup but some people prefered the current one. YAMAMOTO Takashi

Re: CVS commit: src/sys

2009-05-04 Thread YAMAMOTO Takashi
hi, Antti Kantee po...@netbsd.org wrote: On Mon, May 04, 2009 at 06:05:19AM +, YAMAMOTO Takashi wrote: Module Name: src Committed By: yamt Date: Mon May 4 06:05:19 UTC 2009 Modified Files: src/sys/kern: vfs_lookup.c src/sys/nfs: nfs_srvsubs.c

Re: CVS commit: src/sys/netinet6

2009-05-09 Thread YAMAMOTO Takashi
hi, On Fri, May 8, 2009 at 2:18 AM, YAMAMOTO Takashi y...@mwd.biglobe.ne.jp wrote: hi, have you checked callers and ensure that the change from EACCES to EPERM won't be a problem? Only ipsec_set_policy() returns EPERM instead of EACCES now, and I don't think it should be a problem

Re: CVS commit: src/sys/netinet6

2009-05-10 Thread YAMAMOTO Takashi
hi, On Sun, May 10, 2009 at 8:44 AM, YAMAMOTO Takashi y...@mwd.biglobe.ne.jp wrote: have you checked callers and ensure that the change from EACCES to EPERM won't be a problem? Only ipsec_set_policy() returns EPERM instead of EACCES now, and I don't think it should be a problem. don't

Re: CVS commit: src/sys

2009-05-10 Thread YAMAMOTO Takashi
isn't KAUTH_REQ_NETWORK_SOCKET_RAWSOCK being deprecated in favor of _OPEN? YAMAMOTO Takashi cvs rdiff -u -r1.38 -r1.39 src/sys/netinet6/udp6_output.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.

Re: CVS commit: src/sys/nfs

2009-05-10 Thread YAMAMOTO Takashi
hi, On Sun, May 10, 2009 at 05:18:26AM +, YAMAMOTO Takashi wrote: Module Name: src Committed By: yamt Date: Sun May 10 05:18:26 UTC 2009 Modified Files: src/sys/nfs: nfs_vnops.c Log Message: nfs_lookup: vn_lock the vnode returned

Re: CVS commit: src/sys

2009-05-16 Thread YAMAMOTO Takashi
hi, On Sat, May 16, 2009 at 08:29:54AM +, YAMAMOTO Takashi wrote: Modified Files: src/sys/kern: vfs_subr.c src/sys/sys: vnode.h Log Message: put a flag bit into v_usecount to prevent vtryget during getcleanvnode. this fixes the following deadlock. Thanks! How about

Re: CVS commit: src/sys

2009-05-16 Thread YAMAMOTO Takashi
hi, Hi, do you think it could also help with kern/41417 ? cache_lookup seems also to be involved in this deadlock ... it seems like a different problem. YAMAMOTO Takashi

Re: CVS commit: src/sys/kern

2009-05-16 Thread YAMAMOTO Takashi
hi, On Sat, May 16, 2009 at 12:02:00PM +, YAMAMOTO Takashi wrote: Module Name: src Committed By:yamt Date:Sat May 16 12:02:00 UTC 2009 Modified Files: src/sys/kern: init_sysctl.c Log Message: sysctl_doeproc: - simplify. - KERN_PROC: fix

Re: CVS commit: src/lib/libc/sys

2009-06-09 Thread YAMAMOTO Takashi
hi, On Tue, Jun 09, 2009 at 11:21:34AM +, YAMAMOTO Takashi wrote: Log Message: don't bother to say that some advises are not implemented. ignoring them is a valid implementation. It should not be under BUGS, but it should still be documented. E.g. POSIX_FADV_NOREUSE would be very

Re: CVS commit: [yamt-nfs-mp] src/sys

2009-06-24 Thread YAMAMOTO Takashi
On Wed, Jun 24, 2009 at 02:21:44PM +, YAMAMOTO Takashi wrote: Module Name: src Committed By:yamt Date:Wed Jun 24 14:21:44 UTC 2009 Modified Files: src/sys/kern [yamt-nfs-mp]: vfs_syscalls.c src/sys/nfs [yamt-nfs-mp]: nfs_vfsops.c nfs_vnops.c Log

Re: CVS commit: src

2009-08-03 Thread YAMAMOTO Takashi
kmem_zalloc.9 Log Message: Unify kmem_alloc/zalloc/free under kmem(9). Links preserved. i intentionally made them separate pages because it's easier to read for me. (ie. no need to search in a man page.) YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.1289

Re: CVS commit: src

2009-08-08 Thread YAMAMOTO Takashi
hi, y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote: - We already have some practices of writing documentation is such way, like mutex(9), rwlock(9), softint(9), vnode(9) and bunch of others. And I would like to keep such consistent structure. vnode(9) and sysctl(9) are good

Re: CVS commit: src

2009-08-27 Thread YAMAMOTO Takashi
hi, Hello, y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote: hi, what's the status of this? in case it was not clear, i want you revert the changes. It does not change the way how other (and older) section 9 man pages are written, it rather makes our man pages consistent. And I

Re: CVS commit: src

2009-10-29 Thread YAMAMOTO Takashi
hi, doesn't it leak a page for x86 redzone? YAMAMOTO Takashi Module Name: src Committed By: rmind Date: Wed Oct 21 21:12:07 UTC 2009 Modified Files: src/bin/ps: keyword.c print.c ps.1 src/external/bsd/top/dist/machine: m_netbsd.c src/lib/libkvm: kvm_proc.c

Re: CVS commit: src/sys/fs/tmpfs

2009-11-11 Thread YAMAMOTO Takashi
is important for nfs. freebsd has a knob to switch getnanotime/nanotime for vfs_timestamp for the tradeoff. YAMAMOTO Takashi

Re: CVS commit: src

2009-11-17 Thread YAMAMOTO Takashi
are not appropriate to be described in this page. please revert. adding xrefs to splraiseipl and makeiplcookie instead is probably a good idea. YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.1338 -r1.1339 src/distrib/sets/lists/comp/mi cvs rdiff -u -r1.297 -r1.298 src/share/man

Re: CVS commit: src/sys

2009-11-17 Thread YAMAMOTO Takashi
code like this in kern/. IPL_ values can't be compared with = in MI code. return_address.9 is in man.i386. - there are other places where the spl value is modified. eg. interrupt stubs, lock stubs, etc. - can you explain cpu_index(ci) MAXCPUS and cpu_index(ci) = MAXCPUS ? YAMAMOTO Takashi

Re: CVS commit: src

2009-11-18 Thread YAMAMOTO Takashi
hi, On Wed, Nov 18, 2009 at 01:29:05AM +, YAMAMOTO Takashi wrote: hi, Module Name: src Committed By: dyoung Date: Tue Nov 17 18:36:07 UTC 2009 Modified Files: src/distrib/sets/lists/comp: mi src/share/man/man9: Makefile spl.9 Log Message

Re: CVS commit: src/sys

2009-11-18 Thread YAMAMOTO Takashi
hi, On Wed, Nov 18, 2009 at 03:51:02AM +, YAMAMOTO Takashi wrote: Log Message: Add a kernel configuration flag, SPLDEBUG, that activates a per-CPU log of transitions to IPL_HIGH from lower IPLs. SPLDEBUG is only available on i386 and Xen kernels, today. 'options SPLDEBUG' adds

Re: CVS commit: src/sys/arch/i386/i386

2009-11-26 Thread YAMAMOTO Takashi
it is not a right fix. With this patch, build.sh release passes: http://www.netbsd.org/~rmind/crash_pcb.diff Requesting http://www.netbsd.org/~rmind/crash_pcb.diff ftp: Error retrieving file `404 Not Found' YAMAMOTO Takashi It should have been enough to amend the argument of routine exported

Re: CVS commit: src/usr.sbin/rpc.lockd

2009-11-26 Thread YAMAMOTO Takashi
be in kernel) YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.30 -r1.31 src/usr.sbin/rpc.lockd/lockd_lock.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.

Re: CVS commit: src/sys

2009-12-21 Thread YAMAMOTO Takashi
/sys/kern/kern_proc.c this part of the change looks wrong to me. YAMAMOTO Takashi cvs rdiff -u -r1.44 -r1.45 src/sys/kern/subr_prof.c cvs rdiff -u -r1.152 -r1.153 src/sys/kern/sys_process.c cvs rdiff -u -r1.128 -r1.129 src/sys/uvm/uvm_fault.c cvs rdiff -u -r1.142 -r1.143 src/sys/uvm/uvm_glue.c

Re: CVS commit: src/sys

2010-01-13 Thread YAMAMOTO Takashi
y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote: To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/sys/ddb/db_lwp.c cvs rdiff -u -r1.411 -r1.412 src/sys/kern/init_main.c cvs rdiff -u -r1.136 -r1.137 src/sys/kern/kern_lwp.c cvs rdiff -u -r1.158 -r1.159 src/sys/kern

Re: CVS commit: src/lib/libedit

2010-01-13 Thread YAMAMOTO Takashi
hi, can you please don't hardcode utf-8? YAMAMOTO Takashi Module Name: src Committed By: christos Date: Wed Dec 30 22:37:40 UTC 2009 Modified Files: src/lib/libedit: Makefile chared.c chared.h common.c el.c el.h emacs.c filecomplete.c filecomplete.h hist.c

Re: CVS commit: src/lib/libedit

2010-01-13 Thread YAMAMOTO Takashi
On Jan 13, 8:21am, y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote: -- Subject: Re: CVS commit: src/lib/libedit | hi, | | can you please don't hardcode utf-8? | | YAMAMOTO Takashi Once we verify that it works on non utf-8, sure. what do you mean by verify? YAMAMOTO Takashi

CVS commit: src/sys/nfs

2010-01-19 Thread YAMAMOTO Takashi
Module Name:src Committed By: yamt Date: Tue Jan 19 13:29:40 UTC 2010 Modified Files: src/sys/nfs: nfs.h Log Message: remove unused r_timer member. To generate a diff of this commit: cvs rdiff -u -r1.70 -r1.71 src/sys/nfs/nfs.h Please note that diffs are not public

CVS commit: src/external/bsd/iscsi/dist/src/lib

2010-01-19 Thread YAMAMOTO Takashi
Module Name:src Committed By: yamt Date: Wed Jan 20 00:58:49 UTC 2010 Modified Files: src/external/bsd/iscsi/dist/src/lib: disk.c target.c Log Message: add missing trailing newline chars to some of iscsi_err messages. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/external/bsd/iscsi/dist/src/lib

2010-01-20 Thread YAMAMOTO Takashi
Module Name:src Committed By: yamt Date: Wed Jan 20 10:33:08 UTC 2010 Modified Files: src/external/bsd/iscsi/dist/src/lib: disk.c Log Message: implement REPORT LUNS for non-zero LUNs correctly. To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5

CVS commit: src/external/bsd/iscsi/dist/src/lib

2010-01-20 Thread YAMAMOTO Takashi
Module Name:src Committed By: yamt Date: Wed Jan 20 11:50:29 UTC 2010 Modified Files: src/external/bsd/iscsi/dist/src/lib: target.c Log Message: - remove unnecessary and confusing initialization of sess-d. - add an assertion. To generate a diff of this commit: cvs rdiff

Re: CVS commit: src

2010-01-27 Thread YAMAMOTO Takashi
available for every ports and MI code can use them. dyoung, can you please back the change out? (why tech-pkg, btw?) YAMAMOTO Takashi

Re: CVS commit: src

2010-01-28 Thread YAMAMOTO Takashi
On Thu, Jan 28, 2010 at 06:42:16AM +, YAMAMOTO Takashi wrote: ISTM that section 9 is an appropriate place for both interface and implementation docs. In the (few) cases where we actually have an interface, as opposed to some exposed pieces of the implementation

Re: CVS commit: src

2010-02-01 Thread YAMAMOTO Takashi
On Fri, Jan 29, 2010 at 12:24:56AM +, YAMAMOTO Takashi wrote: let's stop being too generic and go back to the change in question. do you think this man page is an appropriate place for these functions? Given that they exist in several MD implementations and (I think

Re: CVS commit: src/sys

2010-02-16 Thread YAMAMOTO Takashi
hi, can you please add comments on each uvm_fault_* functions you introduced? eg. what uvm_fault_lower1 does is not clear from its name at all. to me, it isn't clear what was the purpose of the mechanical splitting of these functions. YAMAMOTO Takashi

Re: CVS commit: src/sys

2010-02-23 Thread YAMAMOTO Takashi
merge. Give me one week... merge of what? your xip branch? it's better to do it before the merge if you want people review it. YAMAMOTO Takashi Masao

Re: CVS commit: [uebayasi-xip] src/sys/miscfs/genfs

2010-02-23 Thread YAMAMOTO Takashi
and pgo_get_xip? is it allowed to return both of device pages and normal pages mixed for a request? YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.36 -r1.36.2.1 src/sys/miscfs/genfs/genfs_io.c Please note that diffs are not public domain; they are subject to the copyright

Re: CVS commit: [uebayasi-xip] src/sys/uvm

2010-02-23 Thread YAMAMOTO Takashi
)? YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.153.2.7 -r1.153.2.8 src/sys/uvm/uvm_page.c cvs rdiff -u -r1.59.2.5 -r1.59.2.6 src/sys/uvm/uvm_page.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.

CVS commit: src/external/bsd/iscsi/dist

2010-03-02 Thread YAMAMOTO Takashi
Module Name:src Committed By: yamt Date: Wed Mar 3 00:44:52 UTC 2010 Modified Files: src/external/bsd/iscsi/dist/include: iscsiprotocol.h src/external/bsd/iscsi/dist/src/lib: disk.c target.c Log Message: fix multi-thread problems wrt read/write buffer. PR/42651.

CVS commit: src/sys/sys

2010-03-02 Thread YAMAMOTO Takashi
Module Name:src Committed By: yamt Date: Wed Mar 3 00:45:55 UTC 2010 Modified Files: src/sys/sys: proc.h Log Message: comment To generate a diff of this commit: cvs rdiff -u -r1.295 -r1.296 src/sys/sys/proc.h Please note that diffs are not public domain; they are

CVS commit: src/sys/kern

2010-03-02 Thread YAMAMOTO Takashi
Module Name:src Committed By: yamt Date: Wed Mar 3 00:47:31 UTC 2010 Modified Files: src/sys/kern: kern_exit.c kern_ktrace.c kern_resource.c kern_runq.c kern_sig.c kern_synch.c vfs_syscalls.c Log Message: remove redundant checks of PK_MARKER. To generate a

CVS commit: src/sys/kern

2010-03-02 Thread YAMAMOTO Takashi
Module Name:src Committed By: yamt Date: Wed Mar 3 00:47:31 UTC 2010 Modified Files: src/sys/kern: kern_exit.c kern_ktrace.c kern_resource.c kern_runq.c kern_sig.c kern_synch.c vfs_syscalls.c Log Message: remove redundant checks of PK_MARKER. To generate a

Re: CVS commit: [uebayasi-xip] src/sys/miscfs/genfs

2010-03-15 Thread YAMAMOTO Takashi
, which is beyond filesystem's task. it doesn't sound convincing to me, given that you have a separate copy of genfs_getpages for xip. YAMAMOTO Takashi Why not adding pgo_get_xip - because I didn't think it's worth adding it. XIP is transparent to other UVM pagers. (And only used by vnode

Re: CVS commit: src/sys

2010-03-15 Thread YAMAMOTO Takashi
merge of what? your xip branch? it's better to do it before the merge if you want people review it. I clean up it today then. Masao done? YAMAMOTO Takashi

Re: CVS commit: src/sys/dev

2010-04-15 Thread YAMAMOTO Takashi
for the old ioctl size. Detect and error files which are definitely sparse (va_bytes va_size). please revert this part of the change. because: - the check doesn't work for certain filesystems. eg. zfs - sparse files work fine in some cases. eg. read-only usage, nfs YAMAMOTO Takashi

Re: CVS commit: src/sys/net/agr

2010-05-26 Thread YAMAMOTO Takashi
state variables that need it. can you explain why they need to be volatile? aren't they protected by a mutex? btw, i'm not sure why this driver needs this complicate locking. i guess it's better to (re?)design locking protocol for ifioctl before putting this complicity to drivers. YAMAMOTO Takashi

Re: CVS commit: src/sys/kern

2010-11-11 Thread YAMAMOTO Takashi
incorrect and makes putpages panic. note that round_page(INT64_MAX) is negative. how about the attached patch? YAMAMOTO Takashi Thanks to jakllsch@ for debug info. To generate a diff of this commit: cvs rdiff -u -r1.17 -r1.18 src/sys/kern/sys_descrip.c Please note that diffs are not public

Re: CVS commit: src/sys/kern

2010-11-11 Thread YAMAMOTO Takashi
hi, On Thu, Nov 11, 2010 at 02:10:00PM +, YAMAMOTO Takashi wrote: hi, Module Name: src Committed By: rmind Date: Wed Oct 27 02:58:05 UTC 2010 Modified Files: src/sys/kern: sys_descrip.c Log Message: do_posix_fadvise: check for a negative

Re: CVS commit: src/sys/kern

2010-11-11 Thread YAMAMOTO Takashi
hi, y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote: hi, Module Name: src Committed By: rmind Date: Wed Oct 27 02:58:05 UTC 2010 Modified Files: src/sys/kern: sys_descrip.c Log Message: do_posix_fadvise: check for a negative length; truncate

Re: CVS commit: src/sys/kern

2010-11-11 Thread YAMAMOTO Takashi
hi, y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote: hi, Module Name: src Committed By: rmind Date: Wed Oct 27 02:58:05 UTC 2010 Modified Files: src/sys/kern: sys_descrip.c Log Message: do_posix_fadvise: check for a negative length; truncate

Re: CVS commit: src/sys/kern

2010-11-24 Thread YAMAMOTO Takashi
hi, Hello, Sorry for late reply. y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote: how about the attached patch? Consider offset = (INT64_MAX - PAGE_SIZE) and len = PAGE_SIZE. That would still panic.. heh, right. then, how about: if (round_page(offset

Re: CVS commit: src/sys/uvm

2010-11-24 Thread YAMAMOTO Takashi
hi, - what's VM_PHYSSEG_OP_PG? - why *offp calculation is done in _p functions, rather than the caller? YAMAMOTO Takashi Module Name: src Committed By: uebayasi Date: Sun Nov 14 15:06:34 UTC 2010 Modified Files: src/sys/uvm: uvm_page.c uvm_page.h uvm_pglist.c Log

Re: CVS commit: src/sys/uvm

2010-11-24 Thread YAMAMOTO Takashi
hi, Hi, thanks for review. On Thu, Nov 25, 2010 at 01:58:04AM +, YAMAMOTO Takashi wrote: hi, - what's VM_PHYSSEG_OP_PG? It's to lookup vm_physseg by struct vm_page *, relying on that struct vm_page *[] is allocated linearly. It'll be used to remove vm_page::phys_addr as we

Re: CVS commit: src/sys/uvm

2010-11-24 Thread YAMAMOTO Takashi
hi, On Thu, Nov 25, 2010 at 04:18:25AM +, YAMAMOTO Takashi wrote: hi, Hi, thanks for review. On Thu, Nov 25, 2010 at 01:58:04AM +, YAMAMOTO Takashi wrote: hi, - what's VM_PHYSSEG_OP_PG? It's to lookup vm_physseg by struct vm_page *, relying on that struct vm_page

Re: CVS commit: src/sys/uvm

2010-11-25 Thread YAMAMOTO Takashi
[ adding cc: tech-kern@ ] hi, On Wed, Nov 24, 2010 at 11:26:39PM -0800, Matt Thomas wrote: On Nov 24, 2010, at 10:47 PM, Masao Uebayashi wrote: On Thu, Nov 25, 2010 at 05:44:21AM +, YAMAMOTO Takashi wrote: hi, On Thu, Nov 25, 2010 at 04:18:25AM +, YAMAMOTO Takashi wrote

Re: CVS commit: src/sys/kern

2010-12-19 Thread YAMAMOTO Takashi
hi, On Fri Dec 17 2010 at 22:34:04 +, YAMAMOTO Takashi wrote: Module Name: src Committed By:yamt Date:Fri Dec 17 22:34:04 UTC 2010 Modified Files: src/sys/kern: vfs_lookup.c Log Message: - lookup_once: when crossing a mount point, don't keep the parent

Re: CVS commit: src/sys/uvm

2010-12-21 Thread YAMAMOTO Takashi
hi, Could you ack this discussion? sorry for dropping a ball. On Tue, Dec 07, 2010 at 01:19:46AM +0900, Masao Uebayashi wrote: On Thu, Nov 25, 2010 at 11:32:39PM +, YAMAMOTO Takashi wrote: [ adding cc: tech-kern@ ] hi, On Wed, Nov 24, 2010 at 11:26:39PM -0800, Matt Thomas

Re: CVS commit: src/sys/uvm

2011-01-04 Thread YAMAMOTO Takashi
this sentence? (Just in case, have you read my paper?) which paper? i guess no. YAMAMOTO Takashi

Re: CVS commit: src/tests/fs/common

2011-01-05 Thread YAMAMOTO Takashi
is used for open time permission checks, does not have a way to distinguish EROFS and EACCES. ie. EACCES is the expected behaviour in this case. YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.23 -r1.24 src/tests/fs/common/h_fsmacros.h Please note that diffs are not public

Re: CVS commit: src/sys/kern

2011-01-10 Thread YAMAMOTO Takashi
but dangerous for data integrity). From simon a long while back. i don't think this kind of knob should be system global. are they merely for debug? YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.38 -r1.39 src/sys/kern/vfs_wapbl.c Please note that diffs are not public

Re: CVS commit: src/tests/fs/common

2011-01-10 Thread YAMAMOTO Takashi
hi, On Thu, Jan 06, 2011 at 12:53:28AM +, YAMAMOTO Takashi wrote: (one nfsro test currently fails with EROFS vs. EACCES. Hopefully someone else can debate the correct errno) the NFS ACCESS procedure, which is used for open time permission checks, does not have a way

Re: CVS commit: src/sys/uvm

2011-01-16 Thread YAMAMOTO Takashi
hi, (Just in case, have you read my paper?) which paper? i guess no. http://uebayasi.dyndns.org/~uebayasi/tmp/xip.pdf i will put it on my todo list. thanks. YAMAMOTO Takashi

Re: CVS commit: src/sys/uvm

2011-01-20 Thread YAMAMOTO Takashi
hi, do you have any plan to use pg-offset of anon pages, or is it an unnecessary side-effect? YAMAMOTO Takashi Module Name: src Committed By: matt Date: Tue Jan 4 08:26:33 UTC 2011 Modified Files: src/sys/uvm: uvm_extern.h uvm_fault.c uvm_km.c uvm_page.c Log Message

Re: CVS commit: src/share/man/man9

2011-01-25 Thread YAMAMOTO Takashi
hi, How about ABI? KASSERT(9) should preserve ABI IMO. sorry, i'm not sure what you mean. can you explain? YAMAMOTO Takashi

Re: CVS commit: src/lib/libc/time

2011-02-11 Thread YAMAMOTO Takashi
will unfortunately persist, even if later calls to those functions succeed. Move the EOVERFLOW setting to the top level calls. did you forget to update gmtime/gmtime_r/offtime/offtime_r? YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.50 -r1.51 src/lib/libc/time/localtime.c

Re: CVS commit: src/lib/libc/time

2011-02-13 Thread YAMAMOTO Takashi
hi, On Feb 11, 11:47pm, y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote: -- Subject: Re: CVS commit: src/lib/libc/time | hi, | | Module Name: src | Committed By: christos | Date: Thu Jan 6 02:41:34 UTC 2011 | | Modified Files: |src/lib/libc/time

Re: CVS commit: src/lib/librumphijack

2011-02-21 Thread YAMAMOTO Takashi
Thing happened. do you want -fno-optimize-sibling-calls ? YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.31 -r1.32 src/lib/librumphijack/hijack.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.

Re: CVS commit: src/lib/librumphijack

2011-02-22 Thread YAMAMOTO Takashi
On Mon Feb 21 2011 at 23:19:47 +, YAMAMOTO Takashi wrote: Module Name: src Committed By: pooka Date: Mon Feb 7 19:34:39 UTC 2011 Modified Files: src/lib/librumphijack: hijack.c Log Message: Force gcc to generate a stack frame for the call

Re: CVS commit: src

2011-02-22 Thread YAMAMOTO Takashi
hi, On Feb 22, 2011, at 1:31 PM, YAMAMOTO Takashi wrote: Module Name: src Committed By:yamt Date:Tue Feb 22 21:31:16 UTC 2011 Added Files: src/common/lib/libc/gen: radixtree.c src/sys/sys: radixtree.h Log Message: an implementation of radix tree

Re: CVS commit: src

2011-02-23 Thread YAMAMOTO Takashi
hi, On Wed, Feb 23, 2011 at 01:33:05AM +, YAMAMOTO Takashi wrote: hi, On Feb 22, 2011, at 1:31 PM, YAMAMOTO Takashi wrote: Module Name: src Committed By: yamt Date: Tue Feb 22 21:31:16 UTC 2011 Added Files: src/common/lib/libc/gen: radixtree.c

Re: CVS commit: src

2011-02-23 Thread YAMAMOTO Takashi
hi, On Thu, Feb 24, 2011 at 12:12:50AM +, YAMAMOTO Takashi wrote: I wrote: Aren't both ptree and radixtree missing documentation? right. both of them are work-in-progress piece of code. well, at least radixtree is. are you suggesting something? Yes: commit new libraries

Re: CVS commit: src

2011-03-01 Thread YAMAMOTO Takashi
hi, Hello, y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote: Log Message: an implementation of radix tree. the idea from linux. How is that different from ptree? while i'm not familiar with ptree... Patricia/Radix tree added by Matt (see src/common/lib/libc/gen/ptree.c

Re: CVS commit: src/sys/kern

2011-03-15 Thread YAMAMOTO Takashi
hi, On 12.03.11 08:16, YAMAMOTO Takashi wrote: Module Name: src Committed By:yamt Date:Sat Mar 12 07:16:50 UTC 2011 Hi, nice to read/hear you're alive. Christoph thank you. YAMAMOTO Takashi

Re: CVS commit: src/sys/netinet

2011-04-14 Thread YAMAMOTO Takashi
and clear the flag, rather than complicating the code. YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.205 -r1.206 src/sys/netinet/ip_output.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.

Re: CVS commit: src/sys

2011-04-24 Thread YAMAMOTO Takashi
by network card drivers. - who clears the flag? - probably it would be better to have separate flags for tx and rx. (i thought ETHERCAP_VLAN_HWTAGGING was for transmitting, but our tree seems inconsistent.) YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/sys

Re: CVS commit: src/sys/netinet

2011-04-25 Thread YAMAMOTO Takashi
hi, On Thu, Apr 14, 2011 at 07:03:49AM +, YAMAMOTO Takashi wrote: please just weaken the assertion and clear the flag, rather than complicating the code. I'm not quite sure I see exactly what you would like the code to look like. What we have now: /* * We may

Re: CVS commit: src/sys/net

2011-06-23 Thread YAMAMOTO Takashi
smpls_len. First label encountered is BoS. XXX: need to do the same for LSE and this feature needs to be documented. what will use this? (just curious) YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/sys/net/if_mpls.c Please note that diffs

Re: CVS commit: src/sys/uvm

2011-06-27 Thread YAMAMOTO Takashi
the lock even temporarily while the comment on uvm_anfree1 says the opposite. YAMAMOTO Takashi Kernel assertion anon-an_lock == amap-am_lock no longer fails. Ok: Mindaugas Rasiukevicius rm...@netbsd.org To generate a diff of this commit: cvs rdiff -u -r1.99 -r1.100 src/sys/uvm/uvm_amap.c

Re: CVS commit: src/sys/uvm

2011-07-05 Thread YAMAMOTO Takashi
hi, y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote: Module Name: src Committed By: hannken Date: Mon Jun 27 15:56:37 UTC 2011 Modified Files: src/sys/uvm: uvm_amap.c Log Message: amap_copy(): Keep the source amap locked until its lock has been

Re: CVS commit: src/sys/uvm

2011-07-25 Thread YAMAMOTO Takashi
hi, y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote: Log Message: amap_copy(): Keep the source amap locked until its lock has been copied. btw, this code seems to assume that uvm_anfree does not release the lock even temporarily while the comment on uvm_anfree1 says

Re: CVS commit: src/sys/kern

2011-08-09 Thread YAMAMOTO Takashi
). why is this necessary? can't we just let VOP_LOOKUP fail? the v_size == 0 check sounds wrong. does it work for eg. nfs? YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.186 -r1.187 src/sys/kern/vfs_lookup.c Please note that diffs are not public domain

Re: CVS commit: src/sys/kern

2011-08-10 Thread YAMAMOTO Takashi
On Wed, Aug 10, 2011 at 03:10:13AM +, YAMAMOTO Takashi wrote: Log Message: Fail namei immediately if searchdir is unlinked / has been rmdir'd. Do this by checking if v_size == 0. Should fix PR 44658 (and PR 32661). why is this necessary? can't we just let VOP_LOOKUP fail

Re: CVS commit: src

2011-08-10 Thread YAMAMOTO Takashi
. YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.55 -r1.56 src/bin/cp/cp.c cvs rdiff -u -r1.39 -r1.40 src/bin/cp/utils.c cvs rdiff -u -r1.41 -r1.42 src/bin/mv/mv.c cvs rdiff -u -r1.1651 -r1.1652 src/distrib/sets/lists/comp/mi cvs rdiff -u -r1.178 -r1.179 src/lib/libc/gen

Re: CVS commit: src

2011-08-10 Thread YAMAMOTO Takashi
hi, On Wed, Aug 10, 2011 at 08:59:48AM +, YAMAMOTO Takashi wrote: is extattr_namespace_access really necessary? uid-based priviledge check in userland is often a mistake. For now it duplicates the same simple access check as in kernel: system attributes are restricted to root

Re: CVS commit: src/sys/uvm

2011-08-10 Thread YAMAMOTO Takashi
[ moving to tech-kern ] hi, y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote: Here is the updated patch after your changes: http://www.netbsd.org/~rmind/uvm_anon_freelst2.diff As you noted, uvm_anfree() can temporarily release the amap lock - that can happen in amap_copy

Re: CVS commit: src/sys/fs/puffs

2011-09-22 Thread YAMAMOTO Takashi
the filesystem. This avoids deadlocks in the following situations: 1) when memory is low: ioflush waits the fileystem, the fielsystem waits for memory can you explain how it is a problem? YAMAMOTO Takashi 2) when the filesystem does not respond (e.g.: network outage ona distributed

Re: CVS commit: src/sys

2011-09-22 Thread YAMAMOTO Takashi
in this way. please revert. YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.156 -r1.157 src/sys/fs/puffs/puffs_vnops.c cvs rdiff -u -r1.46 -r1.47 src/sys/miscfs/syncfs/sync_subr.c Please note that diffs are not public domain; they are subject to the copyright notices

Re: CVS commit: src/sys/fs/puffs

2011-09-23 Thread YAMAMOTO Takashi
hi, YAMAMOTO Takashi y...@mwd.biglobe.ne.jp wrote: This avoids deadlocks in the following situations: 1) when memory is low: ioflush waits the fileystem, the fielsystem waits for memory can you explain how it is a problem? As I understand, one way to free memory is to flush vnode

Re: CVS commit: src/sys/fs/puffs

2011-09-23 Thread YAMAMOTO Takashi
hi, YAMAMOTO Takashi y...@mwd.biglobe.ne.jp wrote: as i told you a few times, ioflush is not a thread to free memory. pagedaemon is. Sure ioflush do not directly free memory, but vnodes' dirty page use memory, don't they? If ioflush stops working, is pageadaemon able to pageout

Re: CVS commit: src/sys/fs/puffs

2011-10-11 Thread YAMAMOTO Takashi
hi, YAMAMOTO Takashi y...@mwd.biglobe.ne.jp wrote: Sure ioflush do not directly free memory, but vnodes' dirty page use memory, don't they? If ioflush stops working, is pageadaemon able to pageout that kind of memory? pagedaemon flushes dirty pages by itself, yes. So

Re: CVS commit: src/sys/fs/puffs

2011-10-12 Thread YAMAMOTO Takashi
hi, YAMAMOTO Takashi y...@mwd.biglobe.ne.jp wrote: if it trapped forever, it's a bug and should be fixed. my point was that your change didn't fix the bug. blocking ioflush is merely a symptom. The problem with userland filesystems is that we may have little control as theses may

Re: CVS commit: src/sys/net

2011-10-21 Thread YAMAMOTO Takashi
? YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.251 -r1.252 src/sys/net/if.c cvs rdiff -u -r1.151 -r1.152 src/sys/net/if.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.

Re: CVS commit: src/lib/libutil

2011-10-21 Thread YAMAMOTO Takashi
hi, Module Name: src Committed By: christos Date: Fri Oct 21 02:05:36 UTC 2011 Modified Files: src/lib/libutil: Makefile Log Message: Add proc_compare you forgot to commit proc_compare.3? YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.67

Re: CVS commit: src/sys/kern

2011-10-23 Thread YAMAMOTO Takashi
owned by caller (string could be allocated on stack). what needs it? YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.31 -r1.32 src/sys/kern/subr_workqueue.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant

Re: CVS commit: src/sys/arch/m68k

2011-10-30 Thread YAMAMOTO Takashi
hi, is a nointr pool safe for this pmap? iirc x86 pmap allocates pv entries from kmem_map to avoid this kind of recursion. YAMAMOTO Takashi Module Name: src Committed By: tsutsui Date: Sat Oct 29 18:26:20 UTC 2011 Modified Files: src/sys/arch/m68k/include: pmap_motorola.h

Re: CVS commit: src/sys/arch/m68k

2011-10-31 Thread YAMAMOTO Takashi
with this pmap, i think pool_allocator_meta is ok. YAMAMOTO Takashi --- Izumi Tsutsui

Re: CVS commit: src/lib/libterminfo

2011-11-02 Thread YAMAMOTO Takashi
the same file using the -p option, there is no longer a need to store these files in CVS. i guess you need to tweak tools/tic? YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.17 -r1.18 src/lib/libterminfo/Makefile cvs rdiff -u -r1.2 -r0 src/lib/libterminfo

Re: CVS commit: src/sys/net

2011-11-02 Thread YAMAMOTO Takashi
hi, On Thu, Oct 20, 2011 at 06:59:42AM +, YAMAMOTO Takashi wrote: hi, Module Name: src Committed By: dyoung Date: Wed Oct 19 01:34:37 UTC 2011 Modified Files: src/sys/net: if.c if.h Log Message: Start to untangle the ifnet ioctls mess

Re: CVS commit: src/sys/net

2011-11-06 Thread YAMAMOTO Takashi
hi, isn't PR/40516 a problem for this particular usage? YAMAMOTO Takashi Module Name: src Committed By: dyoung Date: Wed Nov 2 01:17:59 UTC 2011 Modified Files: src/sys/net: if_gre.c if_gre.h Log Message: For simplicity's sake, use pcq(9) instead of my own circular

Re: CVS commit: src/sys/net

2011-11-07 Thread YAMAMOTO Takashi
On Sun, Nov 06, 2011 at 11:43:06PM +, YAMAMOTO Takashi wrote: hi, isn't PR/40516 a problem for this particular usage? Probably. Should we use Andrew's version for now? matt, can you take a look? YAMAMOTO Takashi Dave -- David Young OJC Technologies is now Pixo

Re: CVS commit: src/sys/nfs

2011-11-14 Thread YAMAMOTO Takashi
YAMAMOTO Takashi To generate a diff of this commit: cvs rdiff -u -r1.160 -r1.161 src/sys/nfs/nfs_serv.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.

  1   2   >