David Holland writes:
> On Tue, Mar 31, 2009 at 06:54:19AM +0900, Izumi Tsutsui wrote:
> > src/share/misc/style says to insert it:
> > [...]
> > { /* Insert an empty line if the function has no local variables. */
>
> but but but that's clearly stupid! :-)
I feel comfortable while reading c
> Log Message:
> Move common logic in selcommon() and pollcommon() into sel_do_scan().
> Avoids code duplication. XXX: pollsock() should be converted too, except
> it's a bit ugly.
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.16 -r1.17 src/sys/kern/sys_select.c
The test `if (selpoll
> Module Name: src
> Committed By: enami
> Date: Fri Nov 27 02:51:15 UTC 2009
>
> Modified Files:
> src/gnu/dist/gdb6/gdb: bsd-kvm.c
>
> Log Message:
> Lookup lwp0.l_addr instead of proc0paddr to locate PCB.
I wonder if it is better to keep proc0paddr in kernel as a pointer to
PCB
> > i wonder if we can re-add proc0paddr, defined to be = lwp0.l_addr
> > at some point in main, to help this work with older gdb?
> >
> > this seems like a worth-while change since it's part of bsd-kvm.c.
>
> would need to be in md code since L_ADDR needs to come from assym.h.
>
> .glob
> The above is defining a global symbol that referes to the middle of
> a struct, not setting a memory location to the address of the it.
Do you mean lwp0.l_addr may vary during execution?
enami.
Roy Marples writes:
> Module Name: src
> Committed By: roy
> Date: Wed Dec 2 11:14:47 UTC 2009
>
> Modified Files:
> src/lib/libc/stdio: getdelim.c
>
> Log Message:
> Pass lint.
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.10 -r1.11 src/lib/libc/stdio/getdelim.c
> So problems are:
> - why .NOTPARALLEL doesn't work?
Since not a parallel make problem.
enami.
Index: gnu/dist/gdb6/sim/mips/Makefile.in
===
RCS file: /cvsroot/src/gnu/dist/gdb6/sim/mips/Makefile.in,v
retrieving revision 1.1.1.2
di
> Index: gnu/dist/gdb6/sim/mips/Makefile.in
> ===
> RCS file: /cvsroot/src/gnu/dist/gdb6/sim/mips/Makefile.in,v
> retrieving revision 1.1.1.2
> diff -u -r1.1.1.2 Makefile.in
> --- gnu/dist/gdb6/sim/mips/Makefile.in2 Jul 2006 20
matthew green writes:
> Module Name: src
> Committed By: mrg
> Date: Mon Dec 21 20:57:36 UTC 2009
>
> Modified Files:
> src/tools: Makefile
>
> Log Message:
> move the build of pax before libelf. fixes my build of tools/libelf,
> though i didn't look to see why libelf needs pax.
> Module Name: src
> Committed By: matt
> Date: Fri Jan 22 05:17:32 UTC 2010
>
> Modified Files:
> src/sys/uvm [matt-nb5-mips64]: uvm_pglist.c
>
> Log Message:
> Rework the algorithm to allocate contiguous pages to be much much faster.
> (read the comments if you want to know how i
> >> To generate a diff of this commit:
> >> cvs rdiff -u -r1.42 -r1.42.16.1 src/sys/uvm/uvm_pglist.c
> >
> >> /*
> >>* Test both the ending and starting pages to see if =
> they are
> >>* both free. If the ending and starting pages are =
> same page,
Module Name:src
Committed By: enami
Date: Fri Feb 5 21:58:42 UTC 2010
Modified Files:
src/usr.bin/sort: fsort.c msort.c sort.c sort.h
Log Message:
Don't touch past the end of allocated region. It results segmentation
violation.
To generate a diff of this commit:
cvs rd
Module Name:src
Committed By: enami
Date: Thu Mar 4 22:48:31 UTC 2010
Modified Files:
src/lib/libc/stdlib: jemalloc.c
Log Message:
Fix race condition on reallocation of huge category.
We need to remove the old region before mremap() since if it relesae the
old region, ot
Module Name:src
Committed By: enami
Date: Thu Mar 4 22:48:31 UTC 2010
Modified Files:
src/lib/libc/stdlib: jemalloc.c
Log Message:
Fix race condition on reallocation of huge category.
We need to remove the old region before mremap() since if it relesae the
old region, ot
> > Modified Files:
> > src/sys/dev/usb: uyurex.c
> >
> > Log Message:
> > The monitor struct member is gone. Make this compile again.
>
> Hmmm, wonder how I missed that one. Thanks for catching.
Never mind. Since uyurex(4) isn't enabled on any kernel config file,
it's not you fault.
enam
> Modified Files:
> src/lib/libpthread: pthread.c
>
> Log Message:
> fix the pthread pt_lid in the fork callback function that runs in the child=
> instead of a function that may be going away. KNFify
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.114 -r1.115 src/lib/libpthr
> cvs rdiff -u -r1.11 -r1.12 src/sys/kern/subr_xcall.c
Why XC_PRI_BIT is not placed at LSB instead MSB? Is cpu state change
(from offline to online or vise versa) cared?
enami.
> enami tsugutomo wrote:
> > > cvs rdiff -u -r1.11 -r1.12 src/sys/kern/subr_xcall.c
> >
> > Why XC_PRI_BIT is not placed at LSB instead MSB?
>
> Because you would lose the value (note, it is not a pointer).
A flag bit at LSB can be preserved by increment
Mindaugas Rasiukevicius writes:
> cvs rdiff -u -r1.22 -r1.23 src/sys/kern/sys_select.c
Do you mean &?
+ if (sel_flag[n] | events) {
enami.
> -wrong initialization reported in a followup to PR bin/43336
> (looks harmless because it applies to zero-initialized memory, so
> LIST_INIT() is a no-op)
Does malloc(3) return zero-initialized memory?
enami.
> Module Name: src
> Committed By: christos
> Date: Thu Sep 23 16:02:41 UTC 2010
>
> Modified Files:
> src/lib/libc/stdlib: setenv.c
>
> Log Message:
> PR/43899: Nicolas Joly: setenv(3)/unsetenv(3) memory leak.
> Partial fix: Don't allocate a new string if the length is equal to th
In addition to previous, __allocenv() call in unsetenv() isn't
necessary if we check if there exists the bitmap before touching it.
If still want to call it, it must be protected by the lock.
enami.
> > Can you try with a LOCKDEBUG + DEBUG/DIAGNOSTIC kernel?
>
> The kernel has all three options.
Hm, if you have DEBUG enabled, kern_free() might fill free'ed area
with WEIRD_ADDR.
enami.
Index: sys/netinet/ip_reass.c
===
RCS file
> Yes, this patch makes boot with root on nfs work again.
> Please commit.
Just committed.
enami.
> Now the code disagrees with the comment above it. Please fix the comment.
I've changed the comment but feel free to improve it if you have
better one.
enami.
> cvs rdiff -u -r1.25 -r1.26 src/usr.bin/pkill/pkill.c
Looks like -l option is necessary for prenice also.
enami.
=?UTF-8?B?R3LDqWdvaXJlIFN1dHJl?= writes:
> Assume for instance that the boot-loader left us with:
>
> +--+ ++ +--+
> | string table | | kernel | | symbol table |
> +--+ ++ +--+
>
> The new addresses computed
Matt Thomas writes:
> Module Name: src
> Committed By: matt
> Date: Tue Jan 18 21:43:29 UTC 2011
>
> Modified Files:
> src/sys/uvm: uvm_page.h uvm_pglist.c
>
> Log Message:
> Improve the efficiency of searching for a contiguous set of free pages.
>
>
> To generate a diff of thi
Joerg Sonnenberger writes:
> Module Name: src
> Committed By: joerg
> Date: Wed Feb 16 01:31:34 UTC 2011
>
> Modified Files:
> src/usr.bin/grep: Makefile file.c grep.1 grep.c grep.h queue.c util.c
> Added Files:
> src/usr.bin/grep: fastgrep.c
I just did `more fastgrep.c' an
> In which sense?
The meaning of `... + wflag' was to skip 7 chars.
enami.
30 matches
Mail list logo
