Re: CVS commit: src/sys/netinet

2011-04-14 Thread tsugutomo . enami
David Young dyo...@netbsd.org writes: Initialize ipintrq.ifq_maxlen using IFQ_MAXLEN directly instead of using the global ipqmaxlen. Get rid of the global ipqmaxlen. This prevents us from patching the variable, doesn't it? enami.

Re: CVS commit: src/sys/netinet

2011-04-15 Thread tsugutomo . enami
David Young dyo...@pobox.com writes: You can probably still patch the ipintrq, It will be fine then. but is there any reason not to use sysctl? sysctl is available only after booting kernel. enami.

Re: CVS commit: src/lib/libc/stdlib

2011-05-16 Thread tsugutomo . enami
Christos Zoulas chris...@netbsd.org writes: Module Name: src Committed By: christos Date: Fri May 13 23:11:00 UTC 2011 Modified Files: src/lib/libc/stdlib: jemalloc.c malloc.c Log Message: don't let readlink trash errno.; To generate a diff of this commit: cvs rdiff -u

Re: CVS commit: src/lib/libc

2011-05-17 Thread tsugutomo . enami
Thomas Klausner w...@netbsd.org writes: Log Message: Use Pq or Po macro for better output rather than putting raw open paren at the end of line. .Fn ( foo , also works, just like .Fn bar ) . Thomas Which is preferred (or encouraged to use)? enami.

Re: CVS commit: src/sys/kern

2011-05-23 Thread tsugutomo . enami
Mindaugas Rasiukevicius rm...@netbsd.org writes: Module Name: src Committed By: rmind Date: Sat Apr 30 23:41:17 UTC 2011 Modified Files: src/sys/kern: kern_resource.c Log Message: sysctl_proc_corename: improve comments, clean up, move a check for

Re: CVS commit: src/lib/libm/arch/i387

2011-06-19 Thread tsugutomo . enami
Joerg Sonnenberger jo...@netbsd.org writes: Log Message: Switch to SSE code, since our gas supports it now. To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7 src/lib/libm/arch/i387/s_copysign.S cvs rdiff -u -r1.5 -r1.6 src/lib/libm/arch/i387/s_copysignf.S Is the change done in

Re: CVS commit: src/lib/libm/arch/i387

2011-06-20 Thread tsugutomo . enami
Joerg Sonnenberger jo...@britannica.bec.de writes: On Mon, Jun 20, 2011 at 11:25:34AM +0900, tsugutomo.en...@jp.sony.com wrote: Joerg Sonnenberger jo...@netbsd.org writes: Log Message: Switch to SSE code, since our gas supports it now. To generate a diff of this commit: cvs rdiff

Re: CVS commit: src/sys/uvm

2011-06-23 Thread tsugutomo . enami
Mindaugas Rasiukevicius rm...@netbsd.org writes: Module Name: src Committed By: rmind Date: Thu Jun 23 18:15:30 UTC 2011 Modified Files: src/sys/uvm: uvm_amap.c Log Message: Clean-up, add asserts, slightly simplify. To generate a diff of this commit: cvs rdiff -u

Re: CVS commit: src/sbin/newfs_v7fs

2011-07-18 Thread tsugutomo . enami
Matthias Scheler t...@netbsd.org writes: Log Message: Don't use roundup2(9) (which should have been howmany(9) anyway) to fix builds on platforms other than NetBSD. Since usr.sbin/makefs/cd9660.[ch] already uses howmany(), we can use it here too, can't we? enami.

Re: CVS commit: src/sys/kern

2011-08-09 Thread tsugutomo . enami
YAMAMOTO Takashi y...@mwd.biglobe.ne.jp writes: the v_size == 0 check sounds wrong. does it work for eg. nfs? Certainly it doesn't work for layered fs. enami.

Re: CVS commit: src

2011-08-21 Thread tsugutomo . enami
Emmanuel Dreyfus m...@netbsd.org writes: Module Name: src Committed By: manu Date: Wed Aug 17 07:22:35 UTC 2011 Modified Files: src/distrib/sets/lists/comp: mi src/lib/libc/sys: Makefile.inc utimes.2 src/sys/kern: syscalls.master vfs_syscalls.c Log Message:

Re: CVS commit: src

2011-08-22 Thread tsugutomo . enami
Emmanuel Dreyfus m...@netbsd.org writes: I guess something like following change is necessary so that when both tv_nsec is set to UTIME_NOW, 1) to perform same permission check as when NULL is passed to 2nd arg. 2) to set same value for both atime and mtime. I think you

Re: CVS commit: src/lib/libc/gdtoa

2011-11-17 Thread tsugutomo . enami
Christos Zoulas chris...@netbsd.org writes: Modified Files: src/lib/libc/gdtoa: misc.c I've noticed that this code casually enclosing piece of code including return statement with ACQUIRE_LOCK/FREE_LOCK. I guess the lock need to be freed (i.e., unlocked) before return. enami.

Re: CVS commit: src/sys

2011-12-20 Thread tsugutomo . enami
Christos Zoulas chris...@netbsd.org writes: Log Message: - Eliminate so_nbio and turn it into a bit SS_NBIO in so_state. It looks like fstat is using so_pcb offset directly while netstat uses sysctl to get list of pcbs. systat uses so_snd/rcv. I guess it is better not to change the layout of

Re: CVS commit: src/sys/kern

2012-02-20 Thread tsugutomo . enami
Christos Zoulas chris...@netbsd.org writes: To generate a diff of this commit: cvs rdiff -u -r1.341 -r1.342 src/sys/kern/kern_exec.c + kmem_free(fa-fae, sizeof(*fa-fae)); Two bugs here. fa-fae isn't allocated if (original) fa-len is zero. And the size of allocation is `sizeof(*fa-fae) *

Re: CVS commit: src/sys/kern

2012-02-20 Thread tsugutomo . enami
Christos Zoulas chris...@netbsd.org writes: Modified Files: src/sys/kern: kern_exec.c Log Message: fix fae free'ing, from enami. The fa-len in the posix_spawn_fa_free() might no longer be equal to the value used when fa-fae is allocated. So you can't use it as is. That's why I said

Re: CVS commit: src/bin/cat

2012-11-12 Thread tsugutomo . enami
Log Message: Add an option to read with a different buffer size, and document the buffer size we use. This allows us to cat -B 1000 /proc/pid/maps for example which cannot handle seeking. How about to use strsuftoll instead of strtol? enami.

Re: CVS commit: src/sbin/disklabel

2013-05-13 Thread tsugutomo . enami
Modified Files: src/sbin/disklabel: main.c Log Message: CVE 1020933: Prevent integer overflow by using wider type To generate a diff of this commit: cvs rdiff -u -r1.33 -r1.34 src/sbin/disklabel/main.c Since the variable `offset' in find_label() is used to express an offset

Re: CVS commit: src/sbin/disklabel

2013-05-14 Thread tsugutomo . enami
Christos Zoulas chris...@astron.com writes: Are you worried about efficiency here? Yes, you can fix it differently by checking if LABEL_OFFSET fits. I don't worry about efficiency. I've just noticed build failure on i386, and wondering what was wrong. I thought it would be better if warned