Module Name:src
Committed By: rin
Date: Wed Sep 18 22:29:39 UTC 2024
Modified Files:
src/sys/arch/i386/i386: db_interface.c
Log Message:
i386: DDB: Call x86_pause() (`pause` insn) when CPUs are paused
as already done for amd64:
https://mail-index.netbsd.org/source-changes
Module Name:src
Committed By: rin
Date: Wed Sep 18 22:29:39 UTC 2024
Modified Files:
src/sys/arch/i386/i386: db_interface.c
Log Message:
i386: DDB: Call x86_pause() (`pause` insn) when CPUs are paused
as already done for amd64:
https://mail-index.netbsd.org/source-changes
Module Name:src
Committed By: christos
Date: Wed Aug 28 23:20:50 UTC 2024
Modified Files:
src/sys/arch/i386/i386: vector.S
Log Message:
PR/58653: me: Revert btsl of negative value to orl
To generate a diff of this commit:
cvs rdiff -u -r1.89 -r1.90 src/sys/arch/i386/i386
Module Name:src
Committed By: christos
Date: Wed Aug 28 23:20:50 UTC 2024
Modified Files:
src/sys/arch/i386/i386: vector.S
Log Message:
PR/58653: me: Revert btsl of negative value to orl
To generate a diff of this commit:
cvs rdiff -u -r1.89 -r1.90 src/sys/arch/i386/i386
Module Name:src
Committed By: andvar
Date: Mon Apr 22 22:47:00 UTC 2024
Modified Files:
src/sys/arch/i386/i386: i386_mainbus.c
Log Message:
Add (defined(MPBIOS) || NACPICA > 0) check around mp_pci_childdetached().
Fixes the build without MPBIOS or ACPI. Modified patch from
Module Name:src
Committed By: andvar
Date: Mon Apr 22 22:47:00 UTC 2024
Modified Files:
src/sys/arch/i386/i386: i386_mainbus.c
Log Message:
Add (defined(MPBIOS) || NACPICA > 0) check around mp_pci_childdetached().
Fixes the build without MPBIOS or ACPI. Modified patch from
Module Name:src
Committed By: riastradh
Date: Fri Mar 3 14:32:27 UTC 2023
Modified Files:
src/sys/arch/i386/i386: genassym.cf locore.S
Log Message:
Revert "x86: Add kthread_fpu_enter/exit support, take two -- forgot i386 bits."
kthread_fpu_enter/exit changes broke some h
Module Name:src
Committed By: riastradh
Date: Fri Mar 3 14:32:27 UTC 2023
Modified Files:
src/sys/arch/i386/i386: genassym.cf locore.S
Log Message:
Revert "x86: Add kthread_fpu_enter/exit support, take two -- forgot i386 bits."
kthread_fpu_enter/exit changes broke some h
Module Name:src
Committed By: riastradh
Date: Sat Feb 25 18:35:54 UTC 2023
Modified Files:
src/sys/arch/i386/i386: genassym.cf locore.S
Log Message:
x86: Add kthread_fpu_enter/exit support, take two -- forgot i386 bits.
To generate a diff of this commit:
cvs rdiff -u -r1
Module Name:src
Committed By: riastradh
Date: Sat Feb 25 18:35:54 UTC 2023
Modified Files:
src/sys/arch/i386/i386: genassym.cf locore.S
Log Message:
x86: Add kthread_fpu_enter/exit support, take two -- forgot i386 bits.
To generate a diff of this commit:
cvs rdiff -u -r1
Module Name:src
Committed By: riastradh
Date: Sat Feb 25 13:52:09 UTC 2023
Modified Files:
src/sys/arch/i386/i386: bioscall.S
Log Message:
i386/bioscall: Disable preemption while we load the kernel pmap.
Fixes crash on boot in new KASSERT(kpreempt_disabled()) in
cpu_load_
Module Name:src
Committed By: riastradh
Date: Sat Feb 25 13:52:09 UTC 2023
Modified Files:
src/sys/arch/i386/i386: bioscall.S
Log Message:
i386/bioscall: Disable preemption while we load the kernel pmap.
Fixes crash on boot in new KASSERT(kpreempt_disabled()) in
cpu_load_
Module Name:src
Committed By: mlelstv
Date: Fri Feb 3 09:21:58 UTC 2023
Modified Files:
src/sys/arch/i386/i386: locore.S
Log Message:
Make multiboot1 continue with common boot code and not skip CPU type
detection.
Fixes PR 57017 and PR 56935.
To generate a diff of this
Module Name:src
Committed By: mlelstv
Date: Fri Feb 3 09:21:58 UTC 2023
Modified Files:
src/sys/arch/i386/i386: locore.S
Log Message:
Make multiboot1 continue with common boot code and not skip CPU type
detection.
Fixes PR 57017 and PR 56935.
To generate a diff of this
Module Name:src
Committed By: msaitoh
Date: Mon Dec 26 08:59:01 UTC 2022
Modified Files:
src/sys/arch/i386/i386: genassym.cf
Log Message:
Remove duplicated IPL_SCHED. No functional change.
To generate a diff of this commit:
cvs rdiff -u -r1.126 -r1.127 src/sys/arch/i386/
Module Name:src
Committed By: msaitoh
Date: Mon Dec 26 08:59:01 UTC 2022
Modified Files:
src/sys/arch/i386/i386: genassym.cf
Log Message:
Remove duplicated IPL_SCHED. No functional change.
To generate a diff of this commit:
cvs rdiff -u -r1.126 -r1.127 src/sys/arch/i386/
Module Name:src
Committed By: knakahara
Date: Thu Sep 8 06:57:44 UTC 2022
Modified Files:
src/sys/arch/i386/i386: lock_stubs.S spl.S
Log Message:
Fix PR port-i386/57000 (boot failure on qemu).
To generate a diff of this commit:
cvs rdiff -u -r1.37 -r1.38 src/sys/arch/i3
Module Name:src
Committed By: knakahara
Date: Thu Sep 8 06:57:44 UTC 2022
Modified Files:
src/sys/arch/i386/i386: lock_stubs.S spl.S
Log Message:
Fix PR port-i386/57000 (boot failure on qemu).
To generate a diff of this commit:
cvs rdiff -u -r1.37 -r1.38 src/sys/arch/i3
Module Name:src
Committed By: bouyer
Date: Tue May 31 18:04:11 UTC 2022
Modified Files:
src/sys/arch/i386/i386: locore.S machdep.c
Log Message:
For some reason on my system, the guest starts with a pending event in
the shared structure. On i386, this cause hypervisor_callb
Module Name:src
Committed By: bouyer
Date: Tue May 31 18:04:11 UTC 2022
Modified Files:
src/sys/arch/i386/i386: locore.S machdep.c
Log Message:
For some reason on my system, the guest starts with a pending event in
the shared structure. On i386, this cause hypervisor_callb
Module Name:src
Committed By: manu
Date: Fri Oct 18 01:19:00 UTC 2019
Modified Files:
src/sys/arch/i386/i386: multiboot.c
Log Message:
Fix multiboot1 kernel symbol load
ELF_Shdr's sh_type field is a value, not a flag field
To generate a diff of this commit:
cvs rdiff -u
Module Name:src
Committed By: manu
Date: Fri Oct 18 01:19:00 UTC 2019
Modified Files:
src/sys/arch/i386/i386: multiboot.c
Log Message:
Fix multiboot1 kernel symbol load
ELF_Shdr's sh_type field is a value, not a flag field
To generate a diff of this commit:
cvs rdiff -u
Module Name:src
Committed By: maxv
Date: Fri Oct 4 15:28:00 UTC 2019
Modified Files:
src/sys/arch/i386/i386: i386_trap.S locore.S spl.S
Log Message:
Misc reordering, to clarify and reduce the diff against amd64.
To generate a diff of this commit:
cvs rdiff -u -r1.18 -r1
Module Name:src
Committed By: maxv
Date: Fri Oct 4 15:28:00 UTC 2019
Modified Files:
src/sys/arch/i386/i386: i386_trap.S locore.S spl.S
Log Message:
Misc reordering, to clarify and reduce the diff against amd64.
To generate a diff of this commit:
cvs rdiff -u -r1.18 -r1
Module Name:src
Committed By: kamil
Date: Tue Aug 6 02:04:43 UTC 2019
Modified Files:
src/sys/arch/i386/i386: process_machdep.c
Log Message:
Do not dereference user pointer in ptrace_machdep_dorequest()/i386
Always use copyin(9) for reading user memory.
To generate a d
Module Name:src
Committed By: kamil
Date: Tue Aug 6 02:04:43 UTC 2019
Modified Files:
src/sys/arch/i386/i386: process_machdep.c
Log Message:
Do not dereference user pointer in ptrace_machdep_dorequest()/i386
Always use copyin(9) for reading user memory.
To generate a d
Module Name:src
Committed By: mlelstv
Date: Sat Jul 13 17:04:21 UTC 2019
Modified Files:
src/sys/arch/i386/i386: trap.c
Log Message:
Use common code for SMEP/SMAP panic to print more information and
allow debugging.
To generate a diff of this commit:
cvs rdiff -u -r1.301
Module Name:src
Committed By: mlelstv
Date: Sat Jul 13 17:04:21 UTC 2019
Modified Files:
src/sys/arch/i386/i386: trap.c
Log Message:
Use common code for SMEP/SMAP panic to print more information and
allow debugging.
To generate a diff of this commit:
cvs rdiff -u -r1.301
Module Name:src
Committed By: msaitoh
Date: Wed May 29 14:28:37 UTC 2019
Modified Files:
src/sys/arch/i386/i386: trap.c
Log Message:
Use PRIxREGISTER suggested by Kamil.
To generate a diff of this commit:
cvs rdiff -u -r1.300 -r1.301 src/sys/arch/i386/i386/trap.c
Pleas
Module Name:src
Committed By: msaitoh
Date: Wed May 29 14:28:37 UTC 2019
Modified Files:
src/sys/arch/i386/i386: trap.c
Log Message:
Use PRIxREGISTER suggested by Kamil.
To generate a diff of this commit:
cvs rdiff -u -r1.300 -r1.301 src/sys/arch/i386/i386/trap.c
Pleas
Module Name:src
Committed By: maxv
Date: Sun May 19 08:49:08 UTC 2019
Modified Files:
src/sys/arch/i386/i386: compat_16_machdep.c
Log Message:
Remove useless call to fpu_sigreset(), buildcontext() already calls it.
To generate a diff of this commit:
cvs rdiff -u -r1.31 -
Module Name:src
Committed By: maxv
Date: Sun May 19 08:49:08 UTC 2019
Modified Files:
src/sys/arch/i386/i386: compat_16_machdep.c
Log Message:
Remove useless call to fpu_sigreset(), buildcontext() already calls it.
To generate a diff of this commit:
cvs rdiff -u -r1.31 -
Le 06/07/2017 à 22:23, Manuel Bouyer a écrit :
Module Name:src
Committed By: bouyer
Date: Thu Jul 6 20:23:57 UTC 2017
Modified Files:
src/sys/arch/i386/i386: gdt.c
Log Message:
gdt_size is now in bytes, but the HYPERVISOR_set_gdt() expects a number
of entries and has no
On Tue, May 31, 2016 at 11:39:08AM +0200, Joerg Sonnenberger wrote:
> On Mon, May 30, 2016 at 06:58:52PM -0400, Christos Zoulas wrote:
> > Module Name:src
> > Committed By: christos
> > Date: Mon May 30 22:58:52 UTC 2016
> >
> > Modified Files:
> > src/sys/arch/i386
On Mon, May 30, 2016 at 06:58:52PM -0400, Christos Zoulas wrote:
> Module Name: src
> Committed By: christos
> Date: Mon May 30 22:58:52 UTC 2016
>
> Modified Files:
> src/sys/arch/i386/i386: cpu_in_cksum.S
>
> Log Message:
> Handle PIC linking for tests
Except this doesn't work b
On Thu, Mar 06, 2014 at 12:30:25PM +, NONAKA Kimihiro wrote:
> Module Name: src
> Committed By: nonaka
> Date: Thu Mar 6 12:30:25 UTC 2014
>
> Modified Files:
> src/sys/arch/i386/i386: cpufunc.S
>
> Log Message:
> fix to pass collect memory address to xrstor.
Gah ... :-(
FWI
On Mon, Mar 05, 2012 at 08:01:09AM +0530, Cherry G. Mathew wrote:
> On 5 March 2012 02:14, Manuel Bouyer wrote:
> > Module Name: src
> > Committed By: bouyer
> > Date: Sun Mar 4 20:44:17 UTC 2012
> >
> > Modified Files:
> > src/sys/arch/i386/i386: machdep.c
> >
> > Log Messa
On 5 March 2012 02:14, Manuel Bouyer wrote:
> Module Name: src
> Committed By: bouyer
> Date: Sun Mar 4 20:44:17 UTC 2012
>
> Modified Files:
> src/sys/arch/i386/i386: machdep.c
>
> Log Message:
> Don't try to uvm_page_physload() the tmpgdt page: this always fails because
>
On Fri, Jan 20, 2012 at 12:39:44PM +0100, Matthias Drochner wrote:
>
> m...@eterna.com.au said:
> > alloc/free here for whatever is using a lot of memory would be much
> > better than increasing the minimum each LWP requires.
>
> Agreed. In the ppbattach case, it should be sufficient
> to put the
chris...@astron.com said:
> /.*sub.*,%[er]sp/
very nice
> 18648 80494b55:stbi_gif_load_from_memory+0xd
So this can never have worked on x86, with only 12k stack.
best regards
Matthias
--
m...@eterna.com.au said:
> alloc/free here for whatever is using a lot of memory would be much
> better than increasing the minimum each LWP requires.
Agreed. In the ppbattach case, it should be sufficient
to put the devinfo printf into a separate function, so
that it doesn't stack up when called
> dyo...@pobox.com said:
> > > increased stack use lead to stack overflow on amd64
> > > with a deep PCI hierarchy
> > Tell me more about this.
>
> It was sys/dev/pci/pci.c rev.1.141 which triggered it.
> Stack use must already have been tight, and the additional
> device number array was the las
dyo...@pobox.com said:
> > increased stack use lead to stack overflow on amd64
> > with a deep PCI hierarchy
> Tell me more about this.
It was sys/dev/pci/pci.c rev.1.141 which triggered it.
Stack use must already have been tight, and the additional
device number array was the last straw.
The que
On Wed, Jan 18, 2012 at 11:38:39PM +0100, Matthias Drochner wrote:
>
> dyo...@pobox.com said:
> > was setting pba_sub = 255 causing material problems for someone, or
> > are you concerned that lossage will eventually occur on certain
> > server-class machines?
>
> No, this wasn't causing damage.
dyo...@pobox.com said:
> was setting pba_sub = 255 causing material problems for someone, or
> are you concerned that lossage will eventually occur on certain
> server-class machines?
No, this wasn't causing damage. I was tracking another problem which
was incidentally triggered by another of yo
On Wed, Jan 18, 2012 at 09:34:39PM +, Matthias Drochner wrote:
> Module Name: src
> Committed By: drochner
> Date: Wed Jan 18 21:34:38 UTC 2012
>
> Modified Files:
> src/sys/arch/i386/i386: mainbus.c
>
> Log Message:
> revert previous, the assumption "all buses 1 and up must be
"J. Hannken-Illjes" wrote:
> > Module Name:src
> > Committed By: yamt
> > Date: Mon Oct 31 12:42:53 UTC 2011
> >
> > Modified Files:
> > src/sys/arch/i386/i386: dumpsys.c
> >
> > Log Message:
> > dumpsys_seg: don't overwrite the previous mapping
>
> With this cha
hi,
> On Oct 31, 2011, at 1:42 PM, YAMAMOTO Takashi wrote:
>
>> Module Name: src
>> Committed By:yamt
>> Date:Mon Oct 31 12:42:53 UTC 2011
>>
>> Modified Files:
>> src/sys/arch/i386/i386: dumpsys.c
>>
>> Log Message:
>> dumpsys_seg: don't overwrite the previous mapp
On Oct 31, 2011, at 1:42 PM, YAMAMOTO Takashi wrote:
> Module Name: src
> Committed By: yamt
> Date: Mon Oct 31 12:42:53 UTC 2011
>
> Modified Files:
> src/sys/arch/i386/i386: dumpsys.c
>
> Log Message:
> dumpsys_seg: don't overwrite the previous mapping
With this change in plac
On 01/12/2011 05:09 AM, enami tsugutomo wrote:
=?UTF-8?B?R3LDqWdvaXJlIFN1dHJl?= writes:
Assume for instance that the boot-loader left us with:
+--+ ++ +--+
| string table | | kernel | | symbol table |
+--+ ++ +
=?UTF-8?B?R3LDqWdvaXJlIFN1dHJl?= writes:
> Assume for instance that the boot-loader left us with:
>
> +--+ ++ +--+
> | string table | | kernel | | symbol table |
> +--+ ++ +--+
>
> The new addresses computed
On Sun, Oct 31, 2010 at 04:51:19AM +, YAMAMOTO Takashi wrote:
> Module Name: src
> Committed By: yamt
> Date: Sun Oct 31 04:51:19 UTC 2010
>
> Modified Files:
> src/sys/arch/i386/i386: vector.S
>
> Log Message:
> keep interrupts disabled in NMI handler.
> the patch provided by
Module Name:src
Committed By: jym
Date: Mon Feb 22 23:52:17 UTC 2010
Modified Files:
src/sys/arch/i386/i386: genassym.cf
Log Message:
Remove a duplicate entry for PTE_BASE.
While here, introduce PDP_SIZE and PDE_SIZE. They will be used by asm code
to make it more generic
Module Name:src
Committed By: jym
Date: Mon Feb 22 23:52:17 UTC 2010
Modified Files:
src/sys/arch/i386/i386: genassym.cf
Log Message:
Remove a duplicate entry for PTE_BASE.
While here, introduce PDP_SIZE and PDE_SIZE. They will be used by asm code
to make it more generic
Module Name:src
Committed By: darran
Date: Mon Feb 22 06:42:15 UTC 2010
Modified Files:
src/sys/arch/i386/i386: trap.c vector.S
Log Message:
DTrace: missed the opt_dtrace.h include for these.
To generate a diff of this commit:
cvs rdiff -u -r1.254 -r1.255 src/sys/arch/i3
Module Name:src
Committed By: darran
Date: Mon Feb 22 06:42:15 UTC 2010
Modified Files:
src/sys/arch/i386/i386: trap.c vector.S
Log Message:
DTrace: missed the opt_dtrace.h include for these.
To generate a diff of this commit:
cvs rdiff -u -r1.254 -r1.255 src/sys/arch/i3
da...@l8s.co.uk said:
> I presume the panic was in the 'return to user' sequence?
Yes, in the iret.
> Does it now SIGSEGV the program?
Yes, which is a bit strange because this happened before
even the first instruction was fetched, and no user-supplied
data are involved (as opposed to setmconte
On Sun, Feb 14, 2010 at 11:09:55AM +, Matthias Drochner wrote:
> (recent -current doesn't panic on that GPF which seems to be a
> side effect of another change)
I presume the panic was in the 'return to user' sequence?
Does it now SIGSEGV the program?
Actually, since userspace isn't allowed t
Module Name:src
Committed By: drochner
Date: Sun Feb 14 11:09:54 UTC 2010
Modified Files:
src/sys/arch/i386/i386: ibcs2_machdep.c svr4_machdep.c
Log Message:
fix confused CS selector, fixes the panic reported by Mark Davis
per PR port-i386/42787 (the panic happens due to a
Module Name:src
Committed By: jym
Date: Tue Feb 9 23:09:47 UTC 2010
Modified Files:
src/sys/arch/i386/i386: mptramp.S
Log Message:
Use CR0_PE (enable protected mode) instead of hardcoding constant.
To generate a diff of this commit:
cvs rdiff -u -r1.19 -r1.20 src/sys/ar
Module Name:src
Committed By: dsl
Date: Sun Jan 17 22:21:18 UTC 2010
Modified Files:
src/sys/arch/i386/i386: trap.c vector.S
Log Message:
Fix 'fault on load of %gs during retirn to userspace' to look for the
correct instruction bytes.
Take the 'fault on load segment regi
Module Name:src
Committed By: dsl
Date: Sun Jan 10 15:37:36 UTC 2010
Modified Files:
src/sys/arch/i386/i386: trap.c
Log Message:
If we fault on the iret during return to userspace, see if we need to
do a lazy update of %cs to make the stack executable.
If a change is made,
Module Name:src
Committed By: dsl
Date: Sun Jan 10 15:21:36 UTC 2010
Modified Files:
src/sys/arch/i386/i386: trap.c vector.S
Log Message:
If we fault on the 'iret' during return to userpace (eg if %eip is outside
the bounds of %cs) then hack the stack to contain a normal f
Module Name:src
Committed By: christos
Date: Thu Dec 31 16:04:32 UTC 2009
Modified Files:
src/sys/arch/i386/i386: apmbios.c
Log Message:
Fix compilation issue with time_t
To generate a diff of this commit:
cvs rdiff -u -r1.15 -r1.16 src/sys/arch/i386/i386/apmbios.c
Plea
y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote:
> >> Log Message:
> >> Don't call lwp_getpcb() when not KERNEL.
> >
> > Thanks for working this around, however it is not a right fix. With this
> > patch, build.sh release passes:
> >
> > http://www.netbsd.org/~rmind/crash_pcb.diff
>
> Requestin
hi,
> Hello,
>
> David Laight wrote:
>> Module Name: src
>> Committed By:dsl
>> Date:Sat Nov 21 19:59:51 UTC 2009
>>
>> Modified Files:
>> src/sys/arch/i386/i386: db_trace.c
>>
>> Log Message:
>> Don't call lwp_getpcb() when not KERNEL.
>
> Thanks for working this
David Laight wrote:
> > >Thanks for working this around, however it is not a right fix. With this
> > >patch, build.sh release passes:
> > >
> > >http://www.netbsd.org/~rmind/crash_pcb.diff
> > >
> > >It should have been enough to amend the argument of routine exported to
> > >userland. Do not y
On Sun, Nov 22, 2009 at 12:09:33AM +, Christos Zoulas wrote:
> In article <20091121223029.1e0d263b...@mail.netbsd.org>,
> Mindaugas Rasiukevicius wrote:
> >Hello,
> >
> >David Laight wrote:
> >> Module Name: src
> >> Committed By: dsl
> >> Date: Sat Nov 21 19:59:51 UTC
In article <20091121223029.1e0d263b...@mail.netbsd.org>,
Mindaugas Rasiukevicius wrote:
>Hello,
>
>David Laight wrote:
>> Module Name: src
>> Committed By:dsl
>> Date:Sat Nov 21 19:59:51 UTC 2009
>>
>> Modified Files:
>> src/sys/arch/i386/i386: db_trace.c
>>
>> Log
Hello,
David Laight wrote:
> Module Name: src
> Committed By: dsl
> Date: Sat Nov 21 19:59:51 UTC 2009
>
> Modified Files:
> src/sys/arch/i386/i386: db_trace.c
>
> Log Message:
> Don't call lwp_getpcb() when not KERNEL.
Thanks for working this around, however it is not a right fi
David Laight wrote:
> Module Name: src
> Committed By: dsl
> Date: Sat Nov 21 19:59:51 UTC 2009
>
> Modified Files:
> src/sys/arch/i386/i386: db_trace.c
>
> Log Message:
> Don't call lwp_getpcb() when not KERNEL.
This change might be unnecessary after this commit:
---
On Sat, May 09, 2009 at 06:58:46AM +, Andrew Doran wrote:
> > > xen isn't as vulnerable to the LDT/segreg problem as native x86 because
> > > it's not MP and doesn't do kernel preemption. For the time being I guess
> > > it would suffice to #ifdef the 'cli'.
> >
> > That's not enough to make t
On Tue, May 05, 2009 at 11:44:43PM +0200, Manuel Bouyer wrote:
> On Tue, May 05, 2009 at 09:20:02PM +, Andrew Doran wrote:
> > > but the test binary from the PR segfaults:
> > > truc# kdump |less
> > >
> > > 34 0 ktrace EMUL
On Tue, May 05, 2009 at 09:20:02PM +, Andrew Doran wrote:
> > but the test binary from the PR segfaults:
> > truc# kdump |less
> >
> > 34 0 ktrace EMUL "netbsd"
> > 34 0 ktrace RET ktrace 0
> > 34 0 ktrace CA
On Tue, May 05, 2009 at 09:20:02PM +, Andrew Doran wrote:
> > I tried the following code instead:
> > IDTVEC(osyscall)
> > CLI(%eax) # must be first instruction
> > pushfl # set eflags in trap frame
> > popl8(%esp)
> > orl $PSL_I,(%esp)
On Mon, May 04, 2009 at 03:41:16PM +0200, Manuel Bouyer wrote:
> On Mon, May 04, 2009 at 11:47:29AM +, Andrew Doran wrote:
> > Module Name:src
> > Committed By: ad
> > Date: Mon May 4 11:47:29 UTC 2009
> >
> > Modified Files:
> > src/sys/arch/i386/i386: locore
On Mon, May 04, 2009 at 11:47:29AM +, Andrew Doran wrote:
> Module Name: src
> Committed By: ad
> Date: Mon May 4 11:47:29 UTC 2009
>
> Modified Files:
> src/sys/arch/i386/i386: locore.S
>
> Log Message:
> PR kern/41342: BSDi binaries cause panic
>
> XXX Manuel, please have a
On Wed, Apr 01, 2009 at 09:07:57AM +0900, enami tsugutomo wrote:
> > but but but that's clearly stupid! :-)
>
> I feel comfortable while reading code which has the empty line.
> Lacking it irritates me as if I met code like `for (i=0;i<4096;i++)'
> and I tend to lose interest on such code.
I
enami tsugutomo writes:
> David Holland writes:
>
>> On Tue, Mar 31, 2009 at 06:54:19AM +0900, Izumi Tsutsui wrote:
>> > src/share/misc/style says to insert it:
>> > [...]
>> > { /* Insert an empty line if the function has no local variables. */
>>
>> but but but that's clearly stupid! :-)
>
David Holland writes:
> On Tue, Mar 31, 2009 at 06:54:19AM +0900, Izumi Tsutsui wrote:
> > src/share/misc/style says to insert it:
> > [...]
> > { /* Insert an empty line if the function has no local variables. */
>
> but but but that's clearly stupid! :-)
I feel comfortable while reading c
dholland-sourcechan...@netbsd.org wrote:
> On Tue, Mar 31, 2009 at 06:54:19AM +0900, Izumi Tsutsui wrote:
> > src/share/misc/style says to insert it:
> > [...]
> > { /* Insert an empty line if the function has no local variables. */
>
> but but but that's clearly stupid! :-)
The empty line i
On Tue, Mar 31, 2009 at 06:54:19AM +0900, Izumi Tsutsui wrote:
> src/share/misc/style says to insert it:
> [...]
> { /* Insert an empty line if the function has no local variables. */
but but but that's clearly stupid! :-)
i like it.
.mrg.
On Tue, Mar 31, 2009 at 06:54:19AM +0900, Izumi Tsutsui wrote:
> src/share/misc/style says to insert it:
> [...]
> {/* Insert an empty line if the function has no local variables. */
but but but that's clearly stupid! :-)
--
David A. Holland
dholl...@netbsd.org
dyo...@netbsd.org wrote:
> Module Name: src
> Committed By: dyoung
> Date: Mon Mar 30 17:48:22 UTC 2009
>
> Modified Files:
> src/sys/arch/i386/i386: vm_machdep.c
>
> Log Message:
> Cosmetic: reduce differences from amd64/amd64/vm_machdep.c by deleting
> an empty line.
src/share/
84 matches
Mail list logo
