Module Name:src
Committed By: joerg
Date: Mon Oct 28 18:13:40 UTC 2019
Modified Files:
src/sys/arch/macppc/stand/bootxx: bootxx.c
Log Message:
Mark local-only function as static to save space.
To generate a diff of this commit:
cvs rdiff -u -r1.19 -r1.20
Module Name:src
Committed By: joerg
Date: Mon Oct 28 18:13:40 UTC 2019
Modified Files:
src/sys/arch/macppc/stand/bootxx: bootxx.c
Log Message:
Mark local-only function as static to save space.
To generate a diff of this commit:
cvs rdiff -u -r1.19 -r1.20
On 03/03/18 22:06, matthew green wrote:
> we occasionally have to deal with this and either link against
> libgcc or provide them in libkern/libsa. there can be new
> things from newer compilers, etc., when it starts emitting
> new calls it expects in libgcc or other. kernels should not
> be
> BTW, we already have HAVE_LIBGCC and LIBGCC -that defaults exactly to
> ${DESTDIR}/usr/lib/libgcc.a (NB: you need to grep enough too to find
> it (LIB\$ in bsd.prog.mk).
ah good point. (the original code used the bad way, so this
was an old problem already.)
.mrg.
> On 03/03/18 02:06, matthew green wrote:
> > you didn't grep enough :-) eg:
> >
> > dist/gcc/config/rs6000/rs6000.c:prefix = (sel & SAVRES_SAVE) ?
> > "_savegpr_" : "_restgpr_";
> >
> > is the part that matters.
>
> Just so I understand, where does this come into play from the bootxx
On 03/03/18 09:23, Valery Ushakov wrote:
> Please, don't duplicate that line like that, variables were invented
> for a reason... LDADD is probably the right one to use here.
Sorry, uwe :)
I took mrg's recommendation to "putting the old code back for
${HAVE_GCC:U0} > 0 builds" quite literally.
On Sat, Mar 03, 2018 at 03:44:57 +, Sevan Janiyan wrote:
> Like so?
>
>
> Index: sys/arch/macppc/stand/bootxx/Makefile
> ===
> RCS file: /cvsroot/src/sys/arch/macppc/stand/bootxx/Makefile,v
> retrieving revision 1.18
> diff -u
On 03/03/18 02:06, matthew green wrote:
> you didn't grep enough :-) eg:
>
> dist/gcc/config/rs6000/rs6000.c:prefix = (sel & SAVRES_SAVE) ?
> "_savegpr_" : "_restgpr_";
>
> is the part that matters.
Just so I understand, where does this come into play from the bootxx
side, reason I
On 03/03/18 02:06, matthew green wrote:
> you didn't grep enough :-) eg:
Bah! :)
> dist/gcc/config/rs6000/rs6000.c:prefix = (sel & SAVRES_SAVE) ?
> "_savegpr_" : "_restgpr_";
>
> is the part that matters.
>
> i don't know you can easily test it. i would recommend
> putting the old
> I did see that but thought that we'd had a toolchain update since then.
> grepping the source, the only place I see a reference to it is in
> external/gpl3/gcc/dist/libgcc/config/rs6000/crtresxgpr.S:HIDDEN_FUNC(_restgpr_30_x)
> lwz 30,-8(11)
>
On 03/02/18 23:22, Valery Ushakov wrote:
> I wonder if this might be dependendent on compiler options (e.g. on
> sh4 gcc will emit calls to some libgcc functions only for some
> optimization settings).
hmm, do you have some optimisation settings in mind that I should test??
Sevan
On 03/02/18 23:22, Valery Ushakov wrote:
> That was introduced rather recently:
>
> revision 1.17
> date: 2017-07-16 02:26:46 +0300; author: christos;
> branches: 1.17.2;
> Avoid missing _restgpr_30_x
I did see that but thought that we'd had a toolchain update since then.
grepping
On Fri, Mar 02, 2018 at 23:15:25 +, Sevan Janiyan wrote:
> Module Name: src
> Committed By: sevan
> Date: Fri Mar 2 23:15:25 UTC 2018
>
> Modified Files:
> src/sys/arch/macppc/stand/bootxx: Makefile
>
> Log Message:
> Do not pass libgcc.a to linker as it breaks build with
13 matches
Mail list logo
