Re: CVS commit: src/sys/net

2021-12-03 Thread Tobias Nygren
On Mon, 15 Nov 2021 07:07:06 + Shoichi YAMAGUCHI wrote: > Date: Mon Nov 15 07:07:06 UTC 2021 > > Modified Files: > src/sys/net: if_ether.h if_ethersubr.c if_vlan.c > src/sys/net/lagg: if_lagg.c > > Log Message: > introduced APIs to configure VLAN TAG to ethernet devices

Re: CVS commit: src/etc/rc.d

2021-11-30 Thread Martin Husemann
On Tue, Nov 30, 2021 at 10:11:36AM +, Stephen Borrill wrote: > In our products, we have a standard rc.conf and then a series of build > scripts that configure and enable/disable services as required. We can > switch between npf and ipfilter with a one-line change in a settings file, > for

Re: CVS commit: src/etc/rc.d

2021-11-30 Thread Stephen Borrill
On 30/11/2021 09:43, Martin Husemann wrote: On Tue, Nov 30, 2021 at 09:10:35AM +, Stephen Borrill wrote: In rc.conf, npf=YES is sufficient, but you are advocating the setting needs to be duplicated if put into rc.conf.d. I think the confusion starts with the idea of enabling NPF by just

Re: CVS commit: src/etc/rc.d

2021-11-30 Thread Martin Husemann
On Tue, Nov 30, 2021 at 09:10:35AM +, Stephen Borrill wrote: > In rc.conf, npf=YES is sufficient, but you are advocating the setting needs > to be duplicated if put into rc.conf.d. I think the confusion starts with the idea of enabling NPF by just putting the NPF=yes into scripts in

Re: CVS commit: src/etc/rc.d

2021-11-30 Thread Stephen Borrill
On 26/11/2021 17:52, Robert Elz wrote: Date:Fri, 26 Nov 2021 13:11:36 + From:"Stephen Borrill" Message-ID: <20211126131136.63fabf...@cvs.netbsd.org> | Load rc configuration based on rcvar, not name, so that correct settings | in /etc/rc.conf.d are

Re: CVS commit: src/sbin/cgdconfig

2021-11-29 Thread Joerg Sonnenberger
On Sun, Nov 28, 2021 at 07:42:55AM -0800, Jason Thorpe wrote: > > > > On Nov 27, 2021, at 6:01 PM, Christos Zoulas wrote: > > > > Module Name:src > > Committed By: christos > > Date: Sun Nov 28 02:01:30 UTC 2021 > > > > Modified Files: > > src/sbin/cgdconfig:

Re: CVS commit: src/sbin/cgdconfig

2021-11-28 Thread Christos Zoulas
> On Nov 28, 2021, at 11:57 AM, Roland Illig wrote: > > Am 28.11.2021 um 17:37 schrieb Jason Thorpe: >>> On Nov 28, 2021, at 8:05 AM, Christos Zoulas >>> wrote: >>> >>> 1. which compilation flag should we add -pthread to? CFLAGS or >>> COPTS? What about c++? >> >> GCC defines some preprocessor

Re: CVS commit: src/sbin/cgdconfig

2021-11-28 Thread Roland Illig
Am 28.11.2021 um 17:37 schrieb Jason Thorpe: On Nov 28, 2021, at 8:05 AM, Christos Zoulas wrote: 1. which compilation flag should we add -pthread to? CFLAGS or COPTS? What about c++? GCC defines some preprocessor macros in response to -pthread, so … CPPFLAGS? Perhaps a better choice is to

Re: CVS commit: src/sbin/cgdconfig

2021-11-28 Thread Jason Thorpe
> On Nov 28, 2021, at 8:05 AM, Christos Zoulas wrote: > > The change is correct; this is how it is done everywhere else in the tree. > You are right about -pthread doing more than adding -lpthread, but > in that case, the -pthread should be added to CFLAGS/COPTS etc, > not LDADD so that it

Re: CVS commit: src/sbin/cgdconfig

2021-11-28 Thread Christos Zoulas
The change is correct; this is how it is done everywhere else in the tree. You are right about -pthread doing more than adding -lpthread, but in that case, the -pthread should be added to CFLAGS/COPTS etc, not LDADD so that it is effective during the compilation phase too, not just the link

Re: CVS commit: src/sbin/cgdconfig

2021-11-28 Thread Jason Thorpe
> On Nov 27, 2021, at 6:01 PM, Christos Zoulas wrote: > > Module Name: src > Committed By: christos > Date: Sun Nov 28 02:01:30 UTC 2021 > > Modified Files: > src/sbin/cgdconfig: Makefile > > Log Message: > -lpthread to LDADD (fixes lint build) This change is wrong. The

Re: CVS commit: src/sys/dev/tprof

2021-11-26 Thread Nick Hudson
On 26/11/2021 13:24, Christos Zoulas wrote: Module Name:src Committed By: christos Date: Fri Nov 26 13:24:28 UTC 2021 Modified Files: src/sys/dev/tprof: tprof_armv7.c tprof_armv8.c Log Message: declare xc Thanks! Nick

Re: CVS commit: src/etc/rc.d

2021-11-26 Thread Robert Elz
Date:Fri, 26 Nov 2021 13:11:36 + From:"Stephen Borrill" Message-ID: <20211126131136.63fabf...@cvs.netbsd.org> | Load rc configuration based on rcvar, not name, so that correct settings | in /etc/rc.conf.d are loaded. This looks wrong to me (and a pullup

Re: CVS commit: src/sys

2021-11-19 Thread Rin Okuyama
On 2021/11/20 8:46, Rin Okuyama wrote: Enable this quirk for "C600/X79 AHCI". Also add commented out quirk entries for "Bay Trail SATA (AHCI)" and "Mobile AHCI SATA Controller", for which non-reproducible failures worked around by extra delays have been reported. Oops, I meant: "Mobile AHCI

Re: CVS commit: src/bin/echo

2021-11-10 Thread Valery Ushakov
On Thu, Nov 11, 2021 at 05:03:41 +0700, Robert Elz wrote: > Date:Wed, 10 Nov 2021 22:17:05 +0300 > From:Valery Ushakov > Message-ID: > > | > in the sense that simply falling out of main() is exit(0)? > | > | Surprisingly - yes. > > That's appalling, but

Re: CVS commit: src/bin/echo

2021-11-10 Thread Robert Elz
Date:Wed, 10 Nov 2021 22:17:05 +0300 From:Valery Ushakov Message-ID: | > in the sense that simply falling out of main() is exit(0)? | | Surprisingly - yes. That's appalling, but perhaps not surprising. It breaks code which believed what was promised, and did

Re: CVS commit: src/bin/echo

2021-11-10 Thread Valery Ushakov
On Wed, Nov 10, 2021 at 17:35:45 +, Robert Elz wrote: > And second, does C99 really promise: > Remove unnecessary call to exit(0); returning from main is equivalent > since C99. > in the sense that simply falling out of main() is exit(0)? Surprisingly - yes. Derek M. Jones in

Re: CVS commit: src/sys/arch/arm/sa11x0

2021-11-08 Thread Rin Okuyama
On 2021/11/09 8:57, Rin Okuyama wrote: Module Name:src Committed By: rin Date: Mon Nov 8 23:57:23 UTC 2021 Modified Files: src/sys/arch/arm/sa11x0: sa11x0_irq.S Log Message: irq_entry(): Do not clobber fp (= r11), in order not to confuse DDB. (snip) XXX Rewrite

Re: CVS commit: src

2021-11-07 Thread Robert Elz
Date:Sat, 6 Nov 2021 10:40:58 -0700 From:Alistair Crooks Message-ID: | The author of the software made a conscious decision | to make the variable unsigned, sincr the length | would never be less than zero. | | The author then made a default definition

Re: CVS commit: src

2021-11-07 Thread Alistair Crooks
On Fri, 5 Nov 2021 at 16:45, Joerg Sonnenberger wrote: > On Thu, Nov 04, 2021 at 06:17:20PM -0700, Alistair Crooks wrote: > > I think you're misreading the diff - it will only wrap if the minimum > size > > is 0x, which is...ummm...highly unlikely (it's defined to be 0 > > right now, the

Re: CVS commit: src

2021-11-05 Thread Joerg Sonnenberger
On Thu, Nov 04, 2021 at 06:17:20PM -0700, Alistair Crooks wrote: > I think you're misreading the diff - it will only wrap if the minimum size > is 0x, which is...ummm...highly unlikely (it's defined to be 0 > right now, the type is unsigned) I'm not so much worried about the constant, but

Re: CVS commit: src

2021-11-05 Thread Alistair Crooks
I think you're misreading the diff - it will only wrap if the minimum size is 0x, which is...ummm...highly unlikely (it's defined to be 0 right now, the type is unsigned) On Thu, 4 Nov 2021 at 15:56, Joerg Sonnenberger wrote: > On Mon, Nov 01, 2021 at 03:09:59AM +, Alistair G.

Re: CVS commit: src

2021-11-04 Thread Joerg Sonnenberger
On Mon, Nov 01, 2021 at 03:09:59AM +, Alistair G. Crooks wrote: > Module Name: src > Committed By: agc > Date: Mon Nov 1 03:09:59 UTC 2021 > > Modified Files: > src/external/apache2/argon2/dist/phc-winner-argon2/src: argon2.c core.c > src/lib/libcrypt: Makefile > > Log

Re: CVS commit: src

2021-11-04 Thread Rin Okuyama
On 2021/11/01 12:09, Alistair G. Crooks wrote: Module Name:src Committed By: agc Date: Mon Nov 1 03:09:59 UTC 2021 Modified Files: src/external/apache2/argon2/dist/phc-winner-argon2/src: argon2.c core.c src/lib/libcrypt: Makefile Log Message: Remove the

Re: CVS commit: src/sys/arch

2021-10-31 Thread Tobias Nygren
On Sun, 31 Oct 2021 16:23:48 + Nick Hudson wrote: > Modified Files: > src/sys/arch/aarch64/include: cpu.h cpufunc.h db_machdep.h ... > Log Message: > Rework Arm (32bit and 64bit) AP startup so that cpu_hatch doesn't sleep. Hi, I'm afraid this broke the userland build. I think

Re: CVS commit: src/sys/dev/sbus

2021-10-30 Thread Ryo Shimizu
>Module Name: src >Committed By: macallan >Date: Sat Oct 30 05:37:39 UTC 2021 > >Modified Files: > src/sys/dev/sbus: mgx.c mgxreg.h > >Log Message: >actually mmap() the blitter registers when asked to, while there do some >magic number reduction > > >To generate a diff of this

Re: CVS commit: src/usr.sbin/rpcbind

2021-10-30 Thread nia
On Sat, Oct 30, 2021 at 08:25:42PM +0900, Rin Okuyama wrote: > We should not break from infinite loop here, even if svc_fdset_getmax() > fails. Please restore the old behavior. And please be more careful before > making such a non-trivial change. Ah, thank you. I incorrectly assumed that "out"

Re: CVS commit: src/usr.sbin/rpcbind

2021-10-30 Thread Rin Okuyama
On 2021/10/30 20:04, Nia Alarie wrote: This function previously tried to go to a label that doesn't exist. I wonder why GCC didn't catch this before but does now. This is not true. You deleted the label: - if (p == NULL) { -out: - syslog(LOG_ERR, "Cannot

Re: CVS commit: src

2021-10-29 Thread Roland Illig
Am 29.10.2021 um 22:40 schrieb Robert Elz: Date:Fri, 29 Oct 2021 17:50:38 + From:"Roland Illig" Message-ID: <20211029175038.33b08f...@cvs.netbsd.org> | Log Message: | indent: use prev/curr/next to refer to the current token | | The word 'last'

Re: CVS commit: src

2021-10-29 Thread Robert Elz
Date:Fri, 29 Oct 2021 17:50:38 + From:"Roland Illig" Message-ID: <20211029175038.33b08f...@cvs.netbsd.org> | Log Message: | indent: use prev/curr/next to refer to the current token | | The word 'last' just didn't match with 'next'. That depends upon how

Re: CVS commit: src/lib/libc/string

2021-10-29 Thread Joerg Sonnenberger
On Fri, Oct 29, 2021 at 10:11:57AM +, Nia Alarie wrote: > Module Name: src > Committed By: nia > Date: Fri Oct 29 10:11:57 UTC 2021 > > Modified Files: > src/lib/libc/string: wcsdup.c > > Log Message: > wcsdup(3): use reallocarr to catch integer overflow Except that no such

Re: CVS commit: src

2021-10-26 Thread Ryo Shimizu
>> | I don't think per-file profiling is that useful >> >> Nor do I in general. However, doing routine call counting on mcount >> (or anything it calls) would simply be absurd. If you want to >> know how mant times mcount has been called, you simply sum all the other >> counters. (pc

Re: CVS commit: src/sbin/wsconsctl

2021-10-26 Thread Rin Okuyama
Thanks for the quick response! rin On 2021/10/27 2:35, Roland Illig wrote: Am 26.10.2021 um 06:13 schrieb matthew green: Rin Okuyama writes: I don't think this is right thing to be committed. i agree. Thank you for the explanation, I just reverted the commit, resulting in

Re: CVS commit: src

2021-10-26 Thread Joerg Sonnenberger
On Tue, Oct 26, 2021 at 10:48:45PM +0700, Robert Elz wrote: > Date:Tue, 26 Oct 2021 15:37:56 +0200 > From:Joerg Sonnenberger > Message-ID: > > | Personally, I would prefer to just kill -pg support completely, but > | that's a separate discussion. > > Yes, it

Re: CVS commit: src/bin/sh

2021-10-26 Thread Christos Zoulas
In article <20211026000538.893d6f...@cvs.netbsd.org>, Robert Elz wrote: >-=-=-=-=-=- > >+ waspriv = privileged = (uid != geteuid()) || (gid != getegid()); >+ No issetugid()? christos

Re: CVS commit: src/sbin/wsconsctl

2021-10-26 Thread Roland Illig
Am 26.10.2021 um 06:13 schrieb matthew green: > Rin Okuyama writes: >> I don't think this is right thing to be committed. > > i agree. Thank you for the explanation, I just reverted the commit, resulting in sbin/wsconsctl/Makefile 1.16. Roland

Re: CVS commit: src/bin/sh

2021-10-26 Thread Robert Elz
ps: Also, the code is (while refactored a little) essentially the same as the -p code you added in 2015 ... just now avoiding repeatedly calling geteuid() (etc) - the value it returns won't change unless the code does something to change it. kre

Re: CVS commit: src

2021-10-26 Thread Robert Elz
Date:Tue, 26 Oct 2021 15:37:56 +0200 From:Joerg Sonnenberger Message-ID: | Personally, I would prefer to just kill -pg support completely, but | that's a separate discussion. Yes, it is. | I don't think per-file profiling is that useful Nor do I in general.

Re: CVS commit: src/bin/sh

2021-10-26 Thread Robert Elz
Date:Tue, 26 Oct 2021 15:07:23 - (UTC) From:chris...@astron.com (Christos Zoulas) Message-ID: | No issetugid()? No, because I'm not sure I understand that, nor that I believe: A process is tainted if [...] it has changed any of its real, effective or

Re: CVS commit: src

2021-10-26 Thread Joerg Sonnenberger
On Tue, Oct 26, 2021 at 04:00:41AM +0900, Ryo Shimizu wrote: > > >On Mon, Oct 25, 2021 at 07:54:45AM +, Ryo Shimizu wrote: > >> Module Name: src > >> Committed By: ryo > >> Date: Mon Oct 25 07:54:44 UTC 2021 > >> > >> Modified Files: > >>src/share/mk: bsd.README

re: CVS commit: src/sbin/wsconsctl

2021-10-25 Thread matthew green
Rin Okuyama writes: > I don't think this is right thing to be committed. i agree. > By this way, we can add similar LINTFLAGS hacks every when > kernel API is changed. > > Please keep this kinds of hacks within your local repository. > > > Running lint in non-tools mode picked up the header from

Re: CVS commit: src/sbin/wsconsctl

2021-10-25 Thread Rin Okuyama
I don't think this is right thing to be committed. By this way, we can add similar LINTFLAGS hacks every when kernel API is changed. Please keep this kinds of hacks within your local repository. Thanks, rin On 2021/10/11 22:27, Roland Illig wrote: Module Name:src Committed By: rillig

Re: CVS commit: src

2021-10-25 Thread Ryo Shimizu
>On Mon, Oct 25, 2021 at 07:54:45AM +, Ryo Shimizu wrote: >> Module Name: src >> Committed By:ryo >> Date:Mon Oct 25 07:54:44 UTC 2021 >> >> Modified Files: >> src/share/mk: bsd.README bsd.lib.mk >> src/sys/conf: Makefile.kern.inc >>

Re: CVS commit: src

2021-10-25 Thread Joerg Sonnenberger
On Mon, Oct 25, 2021 at 07:54:45AM +, Ryo Shimizu wrote: > Module Name: src > Committed By: ryo > Date: Mon Oct 25 07:54:44 UTC 2021 > > Modified Files: > src/share/mk: bsd.README bsd.lib.mk > src/sys/conf: Makefile.kern.inc > src/sys/lib/libkern: Makefile.libkern >

Re: CVS commit: src/sys/dev/pci

2021-10-21 Thread Jonathan A. Kollasch
On Thu, Oct 21, 2021 at 05:32:28AM +, Shoichi YAMAGUCHI wrote: > Module Name: src > Committed By: yamaguchi > Date: Thu Oct 21 05:32:27 UTC 2021 > > Modified Files: > src/sys/dev/pci: virtio.c virtio_pci.c virtiovar.h > > Log Message: > divide setup routine of virtio

Re: CVS commit: src/sys/dev/pci

2021-10-18 Thread Kengo NAKAHARA
Hi, Thank you for your quick commit! Thanks, On 2021/10/18 17:15, Juergen Hannken-Illjes wrote: Module Name:src Committed By: hannken Date: Mon Oct 18 08:15:00 UTC 2021 Modified Files: src/sys/dev/pci: xmm7360.c Log Message: Use a local static variable to hold

Re: CVS commit: src/sys/arch/x86/x86

2021-10-15 Thread Paul Goyette
hehehe - porn iterators - love it! On Fri, 15 Oct 2021, Jason Thorpe wrote: I demand this change be reverted. (/s) On Oct 15, 2021, at 11:12 AM, Jared D. McNeill wrote: Module Name:src Committed By: jmcneill Date: Fri Oct 15 18:12:48 UTC 2021 Modified Files:

Re: CVS commit: src/sys/arch/x86/x86

2021-10-15 Thread Jason Thorpe
I demand this change be reverted. (/s) > On Oct 15, 2021, at 11:12 AM, Jared D. McNeill wrote: > > Module Name: src > Committed By: jmcneill > Date: Fri Oct 15 18:12:48 UTC 2021 > > Modified Files: > src/sys/arch/x86/x86: tsc.c > > Log Message: > Fix typo in comment:

Re: CVS commit: src/sys/dev/wscons

2021-10-11 Thread nia
On Sun, Oct 10, 2021 at 10:44:03PM +0900, Izumi Tsutsui wrote: > > Module Name:src > > Committed By: nia > > Date: Tue Sep 28 06:14:28 UTC 2021 > > > > Modified Files: > > src/sys/dev/wscons: wsconsio.h wsmouse.c wsmousevar.h > > > > Log Message: > > wsmouse: add

Re: CVS commit: src/sys/arch

2021-10-11 Thread Nick Hudson
On 11/10/2021 08:14, Rin Okuyama wrote: Hi, On 2021/09/23 15:34, Nick Hudson wrote: Module Name:    src Committed By:    skrll Date:    Thu Sep 23 06:34:00 UTC 2021 Modified Files: src/sys/arch/aarch64/aarch64: cpufunc.c src/sys/arch/arm/arm32: cpu.c Log Message: Print the

Re: CVS commit: src/sys/arch

2021-10-11 Thread Rin Okuyama
Thanks for quick response. Committed :) rin On 2021/10/11 16:27, Nick Hudson wrote: On 11/10/2021 08:14, Rin Okuyama wrote: Hi, On 2021/09/23 15:34, Nick Hudson wrote: Module Name:    src Committed By:    skrll Date:    Thu Sep 23 06:34:00 UTC 2021 Modified Files:

Re: CVS commit: src/sys/arch

2021-10-11 Thread Rin Okuyama
Hi, On 2021/09/23 15:34, Nick Hudson wrote: Module Name:src Committed By: skrll Date: Thu Sep 23 06:34:00 UTC 2021 Modified Files: src/sys/arch/aarch64/aarch64: cpufunc.c src/sys/arch/arm/arm32: cpu.c Log Message: Print the cache information in similar formats

Re: CVS commit: src/sys/dev/wscons

2021-10-10 Thread Izumi Tsutsui
> Module Name: src > Committed By: nia > Date: Tue Sep 28 06:14:28 UTC 2021 > > Modified Files: > src/sys/dev/wscons: wsconsio.h wsmouse.c wsmousevar.h > > Log Message: > wsmouse: add support for "precision scrolling" events and (GET|SET)PARAMS Could you please also update

Re: CVS commit: src/bin/sh

2021-10-10 Thread Tom Ivar Helbekkmo
Roland Illig writes: > Anyway, the code in question was more verbose than necessary, so I made > it simpler. I also experimented with replacing the switch with a single > if statement, but that would have become too dense and thus difficult to > decipher. Yes, the code in exec.c looks much

Re: CVS commit: src/bin/sh

2021-10-10 Thread Roland Illig
Am 10.10.2021 um 08:40 schrieb Tom Ivar Helbekkmo: > Roland Illig writes: > >> sh: ignore lint error about 'continue' in 'do while' loop >> >> exec.c(575): error: continue in 'do ... while (0)' loop [323] >> jobs.c(203): error: continue in 'do ... while (0)' loop [323] >> >> It is certainly a

Re: CVS commit: src/bin/sh

2021-10-10 Thread Tom Ivar Helbekkmo
Roland Illig writes: > sh: ignore lint error about 'continue' in 'do while' loop > > exec.c(575): error: continue in 'do ... while (0)' loop [323] > jobs.c(203): error: continue in 'do ... while (0)' loop [323] > > It is certainly a rarely used feature, I saw it the first time today > and I

Re: CVS commit: src/sys/arch/arm/arm

2021-10-07 Thread Rin Okuyama
Oops, forgot to mention: No binary changes. On 2021/10/07 18:58, Rin Okuyama wrote: Module Name:src Committed By: rin Date: Thu Oct 7 09:58:27 UTC 2021 Modified Files: src/sys/arch/arm/arm: cpufunc_asm_armv5_ec.S Log Message: Reduce diff with cpufunc_asm_armv5.S, from

Re: CVS commit: src/sys

2021-10-06 Thread Taylor R Campbell
> Date: Wed, 6 Oct 2021 17:44:22 +0200 > From: Reinoud Zandijk > > Sorry for my ignorance but I thought that the ksyms list was static? ie > read-only? Or is this change to support kernel modules symbols too and thus > need rw access control? The main kernel's symbols don't change, but the

Re: CVS commit: src/sys

2021-10-06 Thread Reinoud Zandijk
On Wed, Sep 15, 2021 at 07:58:20PM +0900, Rin Okuyama wrote: > On 2021/09/11 19:09, Taylor R Campbell wrote: > > Module Name:src > > Committed By: riastradh > > Date: Sat Sep 11 10:09:55 UTC 2021 > > > > Modified Files: > > src/sys/arch/sparc64/sparc64: machdep.c >

Re: CVS commit: src/sys

2021-09-29 Thread Robert Elz
Date:Wed, 29 Sep 2021 08:42:12 -0700 From:Jason Thorpe Message-ID: | Anything that depends on the new return value would have simply been | doing what the socket / fifo code was doing (groveling around in | selinfo internals), so it's not like they're broken

Re: CVS commit: src/sys

2021-09-29 Thread Jason Thorpe
> On Sep 29, 2021, at 8:15 AM, Robert Elz wrote: > >Date:Wed, 29 Sep 2021 05:37:44 -0700 >From:Jason Thorpe >Message-ID: <39db6c46-94bf-4126-811b-466e5293b...@me.com> > > | Not needed in this case. > | No callers that need the return value are in a module. > >

Re: CVS commit: src/sys

2021-09-29 Thread Robert Elz
Date:Wed, 29 Sep 2021 05:37:44 -0700 From:Jason Thorpe Message-ID: <39db6c46-94bf-4126-811b-466e5293b...@me.com> | Not needed in this case. | No callers that need the return value are in a module. The problem with this argument is that it assumes that you know

Re: CVS commit: src/sys

2021-09-29 Thread Jason Thorpe
> On Sep 28, 2021, at 10:58 PM, matthew green wrote: > > "Jason R Thorpe" writes: >> Module Name: src >> Committed By:thorpej >> Date:Wed Sep 29 02:47:22 UTC 2021 >> >> Modified Files: >> src/sys/kern: sys_select.c uipc_socket.c >> src/sys/miscfs/fifofs:

re: CVS commit: src/sys

2021-09-28 Thread matthew green
"Jason R Thorpe" writes: > Module Name: src > Committed By: thorpej > Date: Wed Sep 29 02:47:22 UTC 2021 > > Modified Files: > src/sys/kern: sys_select.c uipc_socket.c > src/sys/miscfs/fifofs: fifo_vnops.c > src/sys/sys: select.h > > Log Message: > - Change

Re: CVS commit: src/sys/arch

2021-09-23 Thread Izumi Tsutsui
> Module Name: src > Committed By: skrll > Date: Thu Sep 23 06:34:00 UTC 2021 > > Modified Files: > src/sys/arch/aarch64/aarch64: cpufunc.c > src/sys/arch/arm/arm32: cpu.c > > Log Message: > Print the cache information in similar formats and arm and aarch64, e.g. : >

Re: CVS commit: src/sys/kern

2021-09-22 Thread Rin Okuyama
On 2021/09/22 14:42, Rin Okuyama wrote: Module Name:src Committed By: rin Date: Wed Sep 22 05:42:19 UTC 2021 Modified Files: src/sys/kern: kern_ksyms.c Log Message: ksymsmmap: Add missing uao_reference(9) call for ks->ks_uobj. Fix failure for savecore(8) and subsequent

re: CVS commit: src/external/gpl3/gcc/dist/gcc/config

2021-09-18 Thread matthew green
"Jared D. McNeill" writes: > Module Name: src > Committed By: jmcneill > Date: Sat Sep 18 10:45:11 UTC 2021 > > Modified Files: > src/external/gpl3/gcc/dist/gcc/config: host-darwin.c > src/external/gpl3/gcc/dist/gcc/config/aarch64: aarch64.h > > Log Message: > Fix build on

Re: CVS commit: src/usr.sbin/acpitools/acpidump

2021-09-16 Thread Rin Okuyama
On 2021/09/15 8:30, Jason Thorpe wrote: On Sep 14, 2021, at 1:34 PM, Roland Illig wrote: When lint runs on the code, it defines the preprocessor macro 'lint' to be 1. Due to that, this name cannot be used as a regular identifier. Perhaps all of the "#ifdef lint" conditions should become

Re: CVS commit: src/sys

2021-09-16 Thread Rin Okuyama
Hi, For alpha, I've observed similar failure with rev 1.104; savecore fails and panic occurs in pagedaemon after that. Thanks, rin # /etc/rc.d/savecore onestart Checking for core dump... savecore: (null): kvm_nlist: bad namelist savecore: (null): _dumpdev not in namelist # dd if=/dev/zero

Re: CVS commit: src/sys

2021-09-15 Thread Rin Okuyama
On 2021/09/15 21:55, Taylor R Campbell wrote: Date: Wed, 15 Sep 2021 19:58:20 +0900 From: Rin Okuyama login: [ 95.5000696] panic: kernel diagnostic assertion "slock != NULL" failed: file "../../../../uvm/uvm_pdaemon.c", line 398 pg 0x8c66bd88 uobj 0x8fa7e400, NULL lock [...] It seems that I

Re: CVS commit: src/sys

2021-09-15 Thread Taylor R Campbell
> Date: Wed, 15 Sep 2021 19:58:20 +0900 > From: Rin Okuyama > > login: [ 95.5000696] panic: kernel diagnostic assertion "slock != NULL" > failed: file "../../../../uvm/uvm_pdaemon.c", line 398 pg 0x8c66bd88 uobj > 0x8fa7e400, NULL lock > [...] > > It seems that I can avoid this panic if > >

Re: CVS commit: src/sys

2021-09-15 Thread Rin Okuyama
Hi, On 2021/09/11 19:09, Taylor R Campbell wrote: Module Name:src Committed By: riastradh Date: Sat Sep 11 10:09:55 UTC 2021 Modified Files: src/sys/arch/sparc64/sparc64: machdep.c src/sys/kern: kern_ksyms.c subr_csan.c subr_msan.c src/sys/sys: ksyms.h

Re: CVS commit: src/usr.sbin/acpitools/acpidump

2021-09-14 Thread Jason Thorpe
> On Sep 14, 2021, at 1:34 PM, Roland Illig wrote: > > When lint runs on the code, it defines the preprocessor macro 'lint' to > be 1. Due to that, this name cannot be used as a regular identifier. Perhaps all of the "#ifdef lint" conditions should become "#ifdef __lint__"? -- thorpej

Re: CVS commit: src/sys/arch/sh3/sh3

2021-09-08 Thread Rin Okuyama
On 2021/09/08 20:47, Izumi Tsutsui wrote: Module Name:src Committed By: rin Date: Wed Sep 8 07:22:56 UTC 2021 Modified Files: src/sys/arch/sh3/sh3: pmap.c Log Message: Redo a part of rev 1.89: - Remove redundant parentheses/braces/comments. - Fix indents. No binary

Re: CVS commit: src/sys/arch/sh3/sh3

2021-09-08 Thread Izumi Tsutsui
> Module Name: src > Committed By: rin > Date: Wed Sep 8 07:22:56 UTC 2021 > > Modified Files: > src/sys/arch/sh3/sh3: pmap.c > > Log Message: > Redo a part of rev 1.89: > > - Remove redundant parentheses/braces/comments. > - Fix indents. > > No binary changes confirmed this

Re: CVS commit: src/crypto/external/bsd/openssh/dist

2021-09-06 Thread Rin Okuyama
On 2021/09/06 23:31, Taylor R Campbell wrote: Date: Mon, 6 Sep 2021 22:32:22 +0900 From: Rin Okuyama On 2021/09/06 22:11, Ryo ONODERA wrote: Module Name:src Committed By: ryoon Date: Mon Sep 6 13:11:34 UTC 2021 Modified Files: src/crypto/external/bsd/openssh/dist:

Re: CVS commit: src/crypto/external/bsd/openssh/dist

2021-09-06 Thread Taylor R Campbell
> Date: Mon, 6 Sep 2021 22:32:22 +0900 > From: Rin Okuyama > > On 2021/09/06 22:11, Ryo ONODERA wrote: > > Module Name:src > > Committed By: ryoon > > Date: Mon Sep 6 13:11:34 UTC 2021 > > > > Modified Files: > > src/crypto/external/bsd/openssh/dist: dns.c > >

Re: CVS commit: src/crypto/external/bsd/openssh/dist

2021-09-06 Thread Ryo ONODERA
Hi, Rin Okuyama writes: > On 2021/09/06 23:11, Ryo ONODERA wrote: >> Hi, >> >> Rin Okuyama writes: >> >>> On 2021/09/06 22:11, Ryo ONODERA wrote: Module Name: src Committed By: ryoon Date: Mon Sep 6 13:11:34 UTC 2021 Modified Files:

Re: CVS commit: src/crypto/external/bsd/openssh/dist

2021-09-06 Thread Rin Okuyama
On 2021/09/06 23:11, Ryo ONODERA wrote: Hi, Rin Okuyama writes: On 2021/09/06 22:11, Ryo ONODERA wrote: Module Name:src Committed By: ryoon Date: Mon Sep 6 13:11:34 UTC 2021 Modified Files: src/crypto/external/bsd/openssh/dist: dns.c Log Message: Make no diff to

Re: CVS commit: src/crypto/external/bsd/openssh/dist

2021-09-06 Thread Ryo ONODERA
Hi, Rin Okuyama writes: > On 2021/09/06 22:11, Ryo ONODERA wrote: >> Module Name: src >> Committed By:ryoon >> Date:Mon Sep 6 13:11:34 UTC 2021 >> >> Modified Files: >> src/crypto/external/bsd/openssh/dist: dns.c >> >> Log Message: >> Make no diff to upstream >>

Re: CVS commit: src/crypto/external/bsd/openssh/dist

2021-09-06 Thread Rin Okuyama
On 2021/09/06 22:11, Ryo ONODERA wrote: Module Name:src Committed By: ryoon Date: Mon Sep 6 13:11:34 UTC 2021 Modified Files: src/crypto/external/bsd/openssh/dist: dns.c Log Message: Make no diff to upstream To generate a diff of this commit: cvs rdiff -u -r1.20

Re: CVS commit: src

2021-08-31 Thread Roland Illig
Am 30.08.2021 um 11:11 schrieb matthew green: > "Roland Illig" writes: >> Module Name: src >> Committed By:rillig >> Date:Sun Aug 29 09:29:32 UTC 2021 >> >> Modified Files: >> src/tests/usr.bin/xlint/lint1: msg_220.c msg_220.exp >> src/usr.bin/xlint/common: lint.h

Re: CVS commit: src/usr.sbin/inetd

2021-08-31 Thread Roland Illig
Am 31.08.2021 um 18:29 schrieb Tobias Nygren: > - SWAP(int, cp->se_type, sep->se_type); > + SWAP(enum service_type, cp->se_type, sep->se_type); Thanks for the note, I just fixed it. I left out the 'enum' since there is a typedef for it. Roland

Re: CVS commit: src/usr.sbin/inetd

2021-08-31 Thread Tobias Nygren
On Mon, 30 Aug 2021 18:21:11 + Roland Illig wrote: > Module Name: src > Committed By: rillig > Date: Mon Aug 30 18:21:11 UTC 2021 > > Modified Files: > src/usr.sbin/inetd: Makefile inetd.c parse_v2.c > > Log Message: > inetd: raise WARNS from 5 to 6 clang complains:

Re: CVS commit: src/sys/arch/evbarm/conf

2021-08-31 Thread Rin Okuyama
Hi, On 2021/08/30 18:20, matthew green wrote: hi. nice work on BE marvell :) Thanks! "Rin Okuyama" writes: Module Name:src Committed By: rin Date: Mon Aug 30 00:12:15 UTC 2021 Modified Files: src/sys/arch/evbarm/conf: MARVELL_NAS Log Message: Enable FFS_EI and

Re: CVS commit: src

2021-08-30 Thread Christos Zoulas
In article , Tom Ivar Helbekkmo wrote: >Christos Zoulas writes: > >> Module Name: src >> Committed By:christos >> Date:Sun Aug 29 09:54:18 UTC 2021 >> >> Modified Files: >> src/distrib/sets/lists/debug: mi >> src/distrib/sets/lists/tests: mi >>

re: CVS commit: src/sys/arch/evbarm/conf

2021-08-30 Thread matthew green
hi. nice work on BE marvell :) "Rin Okuyama" writes: > Module Name: src > Committed By: rin > Date: Mon Aug 30 00:12:15 UTC 2021 > > Modified Files: > src/sys/arch/evbarm/conf: MARVELL_NAS > > Log Message: > Enable FFS_EI and DISKLABEL_EI as this SoC supports both endians now.

re: CVS commit: src

2021-08-30 Thread matthew green
"Roland Illig" writes: > Module Name: src > Committed By: rillig > Date: Sun Aug 29 09:29:32 UTC 2021 > > Modified Files: > src/tests/usr.bin/xlint/lint1: msg_220.c msg_220.exp > src/usr.bin/xlint/common: lint.h > src/usr.bin/xlint/lint1: lex.c > > Log Message: > lint:

Re: CVS commit: src

2021-08-30 Thread Roland Illig
Tom Ivar Helbekkmo wrote: > Christos Zoulas writes: > >> Module Name:  src >> Committed By: christos >> Date:   Sun Aug 29 09:54:18 UTC 2021 >> >> Modified Files: >>   src/distrib/sets/lists/debug: mi >>   src/distrib/sets/lists/tests: mi >>   src/etc/mtree: NetBSD.dist.tests >>  

Re: CVS commit: src

2021-08-30 Thread Tom Ivar Helbekkmo
Christos Zoulas writes: > Module Name: src > Committed By: christos > Date: Sun Aug 29 09:54:18 UTC 2021 > > Modified Files: > src/distrib/sets/lists/debug: mi > src/distrib/sets/lists/tests: mi > src/etc/mtree: NetBSD.dist.tests > src/tests/usr.sbin: Makefile >

Re: CVS commit: src/sys

2021-08-25 Thread Jason Thorpe
> On Aug 24, 2021, at 10:21 PM, matthew green wrote: > >> - For alpha and sparc64, don't define MUTEX_CAS() in terms of their own >> _lock_cas(), which has its own memory barriers; the call sites in >> kern_mutex.c already have the appropriate memory barrier calls. Thus, >> alpha and

re: CVS commit: src/sys

2021-08-24 Thread matthew green
> - For alpha and sparc64, don't define MUTEX_CAS() in terms of their own > _lock_cas(), which has its own memory barriers; the call sites in > kern_mutex.c already have the appropriate memory barrier calls. Thus, > alpha and sparc64 can use default definition. this seems to leave

re: CVS commit: src/external/mit/xorg/server/xorg-server/hw

2021-08-21 Thread matthew green
> XXX: I wonder if each Xorg server extension can be enabled/disabled > per ${MACHINE} basis rather than in MI include/dix-config.h header. i had a look at this, and we could do it but it might require generating a patched eg, xorg-config.h and maybe others, some that are installed, some

Re: CVS commit: src/usr.bin/mkdep

2021-08-20 Thread bch
Hey Roland - friendly question: I saw this error earlier today and threw in a temporary local fix where I pushed the “const” qualifier deeper (into findcc.[ch]) rather than relax it in mk dep.c. You choose the other route. Did you do that because you expect to have that storage r/w, or something

Re: CVS commit: src/usr.bin

2021-08-20 Thread Roland Illig
Am 20.08.2021 um 03:12 schrieb Robert Elz: > Date:Thu, 19 Aug 2021 21:21:04 + > From:"Roland Illig" > Message-ID: <20210819212104.7c965f...@cvs.netbsd.org> > > | mkdep: fix prototype of findcc > > That broke the build. I'm sorry for that. I knew that mkdep and

Re: CVS commit: src/usr.bin

2021-08-19 Thread Robert Elz
Date:Thu, 19 Aug 2021 21:21:04 + From:"Roland Illig" Message-ID: <20210819212104.7c965f...@cvs.netbsd.org> | mkdep: fix prototype of findcc That broke the build. | A function that modifies a string argument must not declare that | argument as 'const char

Re: CVS commit: src/sys/kern

2021-08-18 Thread Michael van Elst
On Tue, Aug 17, 2021 at 11:39:26PM +, Taylor R Campbell wrote: > > > > Log Message: > > skip symbol tables that were unloaded again to avoid EFAULT when reading > > ksyms. > > > > also restore TAILQ_FOREACH idiom. > > This change isn't quite right: Reading past st = ksyms_last_snapshot > in

Re: CVS commit: src/sys/kern

2021-08-17 Thread Taylor R Campbell
> Module Name:src > Committed By: mlelstv > Date: Sun Jul 18 06:57:28 UTC 2021 > > Modified Files: > src/sys/kern: kern_ksyms.c > > Log Message: > skip symbol tables that were unloaded again to avoid EFAULT when reading > ksyms. > > also restore TAILQ_FOREACH idiom.

Re: CVS commit: src/sys/modules/lua

2021-08-08 Thread Rin Okuyama
On 2021/08/09 7:26, Rin Okuyama wrote: - Initialize LIST_HEAD. Hmm, since HEADs are static, this is not necessary. But, it should be a good practice to initialize HEADs always, IMO... Thanks, rin

Re: CVS commit: src/sbin/devpubd/hooks

2021-08-08 Thread Robert Elz
Sorry, no idea what happened with that. And thanks Martin for fixing it. kre

  1   2   3   4   5   6   7   8   9   10   >