Re: CVS commit: src/distrib/atari/floppies
In article <20160918175429.7df3b17f...@rebar.astron.com>, Christos Zoulas <chris...@zoulas.com> wrote: >On Sep 19, 2:03am, tsut...@ceres.dti.ne.jp (Izumi Tsutsui) wrote: >-- Subject: Re: CVS commit: src/distrib/atari/floppies > >| > Module Name: src >| > Committed By: christos >| > Date: Sun Sep 18 16:36:02 UTC 2016 >| > >| > Modified Files: >| >src/distrib/atari/floppies/install: list >| >src/distrib/atari/floppies/prepare: list >| > >| > Log Message: >| > remove more stuff. >| >| src/distrib/atari/floppies/prepare/install.sh requires expr and pwd. > >Ok, pwd is built-in to sh, expr I'll find a way to put back (or convert >to shell built-in arithmetic). Converted to builtins. christos
Re: CVS commit: src/distrib/atari/floppies
On Sep 19, 2:03am, tsut...@ceres.dti.ne.jp (Izumi Tsutsui) wrote: -- Subject: Re: CVS commit: src/distrib/atari/floppies | > Module Name:src | > Committed By: christos | > Date: Sun Sep 18 16:36:02 UTC 2016 | > | > Modified Files: | > src/distrib/atari/floppies/install: list | > src/distrib/atari/floppies/prepare: list | > | > Log Message: | > remove more stuff. | | src/distrib/atari/floppies/prepare/install.sh requires expr and pwd. Ok, pwd is built-in to sh, expr I'll find a way to put back (or convert to shell built-in arithmetic). $ type pwd pwd is a shell builtin christos
Re: CVS commit: src/distrib/atari/floppies
> Module Name: src > Committed By: christos > Date: Sun Sep 18 16:36:02 UTC 2016 > > Modified Files: > src/distrib/atari/floppies/install: list > src/distrib/atari/floppies/prepare: list > > Log Message: > remove more stuff. src/distrib/atari/floppies/prepare/install.sh requires expr and pwd. --- Izumi Tsutsui
Re: CVS commit: src/distrib/atari/floppies/install
On Sun, Apr 26, 2015 at 10:39:00PM +0900, Izumi Tsutsui wrote: Please don't assume all tier II users check auto-build reports even every month. I would expect portmaster at least to check much more often than once a month or at least request notification. Joerg
Re: CVS commit: src/distrib/atari/floppies/install
Izumi Tsutsui tsut...@ceres.dti.ne.jp writes: joerg@ wrote: Please don't commit untested and broken fix. Please file a PR instead if you can't test it. I agree with Christos that leaving the build broken is worse. The alternative band aids are much more involved, too. That shouldn't stop the second point from that list. If you claim leaving the build broken is worse than commiting untested code, you should ask to update our commit guideline first: http://www.netbsd.org/developers/commit-guidelines.html Perhaps we should. The problems are: A broken build is evidence that the prior commits were not tested, and thus need fixing. Objecting to fixing the build without testing should be a far lower priority than objecting to commits that break the build. A broken build, or a build that succeeds but fails to work is a serious problem because it prevents bisecting to find bugs. I've seen this in current/i386 pretty often, less so recently. During a ~week that the build was broken many commits happened, and some of those were trouble, and it was a mess to sort out. So arguably no commits should be allowed at all during a time when the build is broken or there are sudden significant new test failures, other than fixing the build. pgpPVycMH2F2d.pgp Description: PGP signature
Re: CVS commit: src/distrib/atari/floppies/install
On Sun, Apr 26, 2015 at 10:07:32AM -0400, Greg Troxel wrote: Izumi Tsutsui tsut...@ceres.dti.ne.jp writes: joerg@ wrote: Please don't commit untested and broken fix. Please file a PR instead if you can't test it. I agree with Christos that leaving the build broken is worse. The alternative band aids are much more involved, too. That shouldn't stop the second point from that list. If you claim leaving the build broken is worse than commiting untested code, you should ask to update our commit guideline first: http://www.netbsd.org/developers/commit-guidelines.html Perhaps we should. The problems are: A broken build is evidence that the prior commits were not tested, and thus need fixing. Objecting to fixing the build without testing should be a far lower priority than objecting to commits that break the build. The problem here is that the original commit that triggered the overflow can and often enough is perfectly reasonable on all platforms without artifically low size constraints. What is needed to get at least basic regression testing done in an emulator? Joerg
Re: CVS commit: src/distrib/atari/floppies/install
On Apr 26, 10:39pm, tsut...@ceres.dti.ne.jp (Izumi Tsutsui) wrote: -- Subject: Re: CVS commit: src/distrib/atari/floppies/install | christos@ wrote: | | | Please don't commit untested and broken fix. | | Please file a PR instead if you can't test it. | | I can't test, and it is broken already. For months... | Having the build broken is bad, because it means that any changes | after the break are not even compile-tested. | | Please file a PR if you notice any problems. | | I have tested it netbsd-7, but it's unlikey to test -current periodically | before release. | | Again, I was just saying that we should consider moving ports | that people don't seem care about to tier III. | | Please file a PR for poor tier II users. | Please don't assume all tier II users check auto-build reports | even every month. I will do that :-) It is easier than fixing the problem... christos
Re: CVS commit: src/distrib/atari/floppies/install
joerg@ wrote: Please don't commit untested and broken fix. Please file a PR instead if you can't test it. I agree with Christos that leaving the build broken is worse. The alternative band aids are much more involved, too. That shouldn't stop the second point from that list. If you claim leaving the build broken is worse than commiting untested code, you should ask to update our commit guideline first: http://www.netbsd.org/developers/commit-guidelines.html 1. Commit only code you are familiar with. If you are not sure if the code you plan to commit is acceptable (e. g. when taking code that was submitted with a problem report), ask a developer who is familiar with that part of the system for review. : 5. Commit only code that you have tested. Make sure that your code actually works as expected, by compiling and running the code that is affected by your change with your system's tools. --- Izumi Tsutsui
Re: CVS commit: src/distrib/atari/floppies/install
On Sun, Apr 26, 2015 at 10:54:41PM +0900, Izumi Tsutsui wrote: joerg@ wrote: Please don't commit untested and broken fix. Please file a PR instead if you can't test it. I agree with Christos that leaving the build broken is worse. The alternative band aids are much more involved, too. That shouldn't stop the second point from that list. If you claim leaving the build broken is worse than commiting untested code, you should ask to update our commit guideline first: Bumping the size of a floppy is definitely the smaller evil. Can you please try to be reasonable? Joerg
Re: CVS commit: src/distrib/atari/floppies/install
Joerg Sonnenberger jo...@britannica.bec.de writes: On Sun, Apr 26, 2015 at 10:07:32AM -0400, Greg Troxel wrote: A broken build is evidence that the prior commits were not tested, and thus need fixing. Objecting to fixing the build without testing should be a far lower priority than objecting to commits that break the build. The problem here is that the original commit that triggered the overflow can and often enough is perfectly reasonable on all platforms without artifically low size constraints. What is needed to get at least basic regression testing done in an emulator? Fair enough and a good point about emulator testing being really helpful. pgpGjBHUeCXLj.pgp Description: PGP signature
Re: CVS commit: src/distrib/atari/floppies/install
(note I don't even know how long atari build has been broken) This problem often rises when build failure is caused by MI changes without particular annoucements. If someone[tm] can update our autobuild script, it would be great.. - less frequent (weekly or semi-monthly?) builds for tierII ports - proper notification to MD port list on autobuild failure, as i386 does to current-users --- Izumi Tsutsui
Re: CVS commit: src/distrib/atari/floppies/install
joerg@ wrote: Please don't commit untested and broken fix. Please file a PR instead if you can't test it. I agree with Christos that leaving the build broken is worse. The alternative band aids are much more involved, too. That shouldn't stop the second point from that list. If you claim leaving the build broken is worse than commiting untested code, you should ask to update our commit guideline first: Bumping the size of a floppy is definitely the smaller evil. Can you please try to be reasonable? I'm not sure what's your definition of definitely, but bumping the size of a floppy is fatal on atari, as you can see in the first message of this thread. Our commit guideline is quite reasonable: ask a developer who is familiar with that part of the system for review. --- Izumi Tsutsui
Re: CVS commit: src/distrib/atari/floppies/install
christos@ wrote: | Please don't commit untested and broken fix. | Please file a PR instead if you can't test it. I can't test, and it is broken already. For months... Having the build broken is bad, because it means that any changes after the break are not even compile-tested. Please file a PR if you notice any problems. I have tested it netbsd-7, but it's unlikey to test -current periodically before release. Again, I was just saying that we should consider moving ports that people don't seem care about to tier III. Please file a PR for poor tier II users. Please don't assume all tier II users check auto-build reports even every month. --- Izumi Tsutsui
Re: CVS commit: src/distrib/atari/floppies/install
christos@ wrote: | Log Message: | double the size of the image to fix the build | | AFAIK atari doesn't handle to write, load, and mount 1440KB floppy images. | (i.e. no ustarfs support) How do we fix it? Can we add ustarfs support.. No idea. I don't know atari hardware/firmware specification at all except NetBSD sources. (someone who wrote usr/mdec/fdboot might know hint?) It's easier to have smaller binaries (awk?) in distrib/utils? --- Izumi Tsutsui
Re: CVS commit: src/distrib/atari/floppies/install
christos@ wrote: Module Name: src Committed By: christos Date: Sat Apr 25 18:41:55 UTC 2015 Modified Files: src/distrib/atari/floppies/install: Makefile list Log Message: kill sed so we fit on one floppy again. What makes you think it works? http://nxr.netbsd.org/xref/src/distrib/atari/floppies/common/dot.profile?r=1.4#51 --- Izumi Tsutsui
Re: CVS commit: src/distrib/atari/floppies/install
christos@ wrote: Module Name: src Committed By: christos Date: Wed Apr 22 20:21:11 UTC 2015 Modified Files: src/distrib/atari/floppies/install: Makefile Log Message: double the size of the image to fix the build AFAIK atari doesn't handle to write, load, and mount 1440KB floppy images. (i.e. no ustarfs support) --- Izumi Tsutsui
Re: CVS commit: src/distrib/atari/floppies/install
On Apr 26, 2:49am, tsut...@ceres.dti.ne.jp (Izumi Tsutsui) wrote: -- Subject: Re: CVS commit: src/distrib/atari/floppies/install | christos@ wrote: | | | Log Message: | | double the size of the image to fix the build | | | | AFAIK atari doesn't handle to write, load, and mount 1440KB floppy images. | | (i.e. no ustarfs support) | | How do we fix it? Can we add ustarfs support.. | | No idea. | | I don't know atari hardware/firmware specification at all | except NetBSD sources. | (someone who wrote usr/mdec/fdboot might know hint?) | | It's easier to have smaller binaries (awk?) in distrib/utils? Let's see how far we are from fitting... christos
Re: CVS commit: src/distrib/atari/floppies/install
On Apr 26, 2:31am, tsut...@ceres.dti.ne.jp (Izumi Tsutsui) wrote: -- Subject: Re: CVS commit: src/distrib/atari/floppies/install | christos@ wrote: | | Module Name:src | Committed By: christos | Date: Wed Apr 22 20:21:11 UTC 2015 | | Modified Files: | src/distrib/atari/floppies/install: Makefile | | Log Message: | double the size of the image to fix the build | | AFAIK atari doesn't handle to write, load, and mount 1440KB floppy images. | (i.e. no ustarfs support) How do we fix it? Can we add ustarfs support.. christos
Re: CVS commit: src/distrib/atari/floppies/install
christos@ wrote: | It's easier to have smaller binaries (awk?) in distrib/utils? Let's see how far we are from fitting... All thing I know is it works in 7.0_BETA. I just think buildability fix won't help users, as we discussed in the past. http://mail-index.netbsd.org/source-changes-d/2012/08/01/msg005113.html --- Izumi Tsutsui
Re: CVS commit: src/distrib/atari/floppies/install
On Apr 26, 3:55am, tsut...@ceres.dti.ne.jp (Izumi Tsutsui) wrote: -- Subject: Re: CVS commit: src/distrib/atari/floppies/install | christos@ wrote: | | | It's easier to have smaller binaries (awk?) in distrib/utils? | | Let's see how far we are from fitting... | | All thing I know is it works in 7.0_BETA. | | I just think buildability fix won't help users, | as we discussed in the past. | http://mail-index.netbsd.org/source-changes-d/2012/08/01/msg005113.html Well, it does not help being broken for months... I say tier III, since nobody seems to care. Anyway, fixed for now. christos
Re: CVS commit: src/distrib/atari/floppies/install
christos@ wrote: | I just think buildability fix won't help users, | as we discussed in the past. | http://mail-index.netbsd.org/source-changes-d/2012/08/01/msg005113.html Well, it does not help being broken for months... I say tier III, since nobody seems to care. Anyway, fixed for now. You always miss the point. Please don't commit untested and broken fix. Please file a PR instead if you can't test it. What I wrote was: I agree you can blame port masters if they leave their ports broken more than *weeks*. : If you claim port-masters must check buildable state *everyday* against all MI changes without review or announcement, I'll resign from all maintainership. Claiming tier III since nobody seems to care without PR is quite unfair. --- Izumi Tsutsui
re: CVS commit: src/distrib/atari/floppies/common
Izumi Tsutsui writes: Module Name: src Committed By: tsutsui Date: Sun Nov 16 11:54:29 UTC 2014 Modified Files: src/distrib/atari/floppies/common: Makefile.images Log Message: Use -Os -m68020-60 for DBG. It seems to generate smaller objects than -Os. gcc48 with -Os: -rwxr-xr-x 1 tsutsui wheel 1319596 Nov 16 20:50 obj.atari/instbin gcc48 with -Os -m68020-60 -rwxr-xr-x 1 tsutsui wheel 1314516 Nov 16 20:49 obj.atari/instbin This allows ever growing sysinst.fs still fit into 1440KB even with gcc48. Acually we need a real solution (ustarfs based floppies etc.) soon but we can work around at least for NetBSD 7.0. Should be pulled up to netbsd-7 (if NetBSD/m68k 7.0 will switch to gcc48). it might be nice to pull up anyway, so people can choose to use netbsd-7 in their own builds? :-) .mrg.
