Re: CVS commit: src/sys/arch/luna68k/dev

2014-01-02 Thread David Holland
On Thu, Jan 02, 2014 at 01:25:56PM +0900, Izumi Tsutsui wrote: This could lead to problems in the future. I would put it back. How? - it was added by me recently - netbsd-6 doesn't have it - no other serial driver except com(4) has it ISTM that if the field exists, it should

Re: CVS commit: src/sys/arch/luna68k/dev

2014-01-02 Thread David Holland
On Thu, Jan 02, 2014 at 11:11:34AM -0500, Christos Zoulas wrote: | ISTM that if the field exists, it should always be initialized (in all | tty drivers); if it doesn't need to be initialized, it shouldn't | exist... | | The tty code is a mess but someday someone will fix it up.

Re: CVS commit: src/sys/arch/luna68k/dev

2014-01-01 Thread Christos Zoulas
In article 20140102033235.cfeb...@cvs.netbsd.org, Izumi Tsutsui source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By: tsutsui Date: Thu Jan 2 03:32:35 UTC 2014 Modified Files: src/sys/arch/luna68k/dev: siotty.c Log Message: Remove initialization of

Re: CVS commit: src/sys/arch/luna68k/dev

2014-01-01 Thread Christos Zoulas
On Jan 2, 1:25pm, tsut...@ceres.dti.ne.jp (Izumi Tsutsui) wrote: -- Subject: Re: CVS commit: src/sys/arch/luna68k/dev | This could lead to problems in the future. I would put it back. | | - it was added by me recently | - netbsd-6 doesn't have it | - no other serial driver except com(4) has

Re: CVS commit: src/sys/arch/luna68k/dev

2014-01-01 Thread Izumi Tsutsui
christos@ wrote: On Jan 2, 1:25pm, tsut...@ceres.dti.ne.jp (Izumi Tsutsui) wrote: -- Subject: Re: CVS commit: src/sys/arch/luna68k/dev | This could lead to problems in the future. I would put it back. | | - it was added by me recently | - netbsd-6 doesn't have it | - no other

Re: CVS commit: src/sys/arch/luna68k/dev

2014-01-01 Thread Christos Zoulas
On Jan 2, 2:03pm, tsut...@ceres.dti.ne.jp (Izumi Tsutsui) wrote: -- Subject: Re: CVS commit: src/sys/arch/luna68k/dev | Then you shouldn't put it back unless you know how it will be used. I am not putting it back. | There was no explanation why it was needed in related commit logs