Re: CVS commit: src/sys/crypto/rijndael
On May 14, 2011, at 3:59 AM, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Sat May 14 01:59:19 UTC 2011 Modified Files: src/sys/crypto/rijndael: rijndael-api-fst.c Log Message: - don't assume aligned buffers. - little KNF To generate a diff of this commit: cvs rdiff -u -r1.21 -r1.22 src/sys/crypto/rijndael/rijndael-api-fst.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. This breaks in src/regress/sys/crypto/rijndael: # compile rijndael/rijndael-api-fst.o 486--netbsdelf-gcc -O2 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wno-sign-compare -no-traditional -Wa,--fatal-warnings -Werror --sysroot=/work/build/obj/dest.i386 -I/work/build/src/sys -Dpanic(x)=abort() -c src/sys/crypto/rijndael/rijndael-api-fst.c src/sys/crypto/rijndael/rijndael-api-fst.c: In function 'xor16': src/sys/crypto/rijndael/rijndael-api-fst.c:57: error: 'for' loop initial declaration used outside C99 mode -- Jürgen Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)
Re: CVS commit: src/sys/crypto/rijndael
On May 14, 1:02pm, hann...@eis.cs.tu-bs.de (=?iso-8859-1?Q?J=FCrgen_Hannken-Illjes?=) wrote: -- Subject: Re: CVS commit: src/sys/crypto/rijndael | This breaks in src/regress/sys/crypto/rijndael: | | # compile rijndael/rijndael-api-fst.o | 486--netbsdelf-gcc -O2 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wpo= | inter-arith -Wno-sign-compare -no-traditional -Wa,--fatal-warnings -Werror= |--sysroot=3D/work/build/obj/dest.i386 -I/work/build/src/sys -Dpanic(x)= | =3Dabort() -c src/sys/crypto/rijndael/rijndael-api-fst.c | src/sys/crypto/rijndael/rijndael-api-fst.c: In function 'xor16': | src/sys/crypto/rijndael/rijndael-api-fst.c:57: error: 'for' loop initial de= | claration used outside C99 mode Fixed, thanks! christos
Re: CVS commit: src/sys/crypto/rijndael
On 5/14/11 12:27 PM, Julio Merino wrote: Module Name:src Committed By: jmmv Date: Sat May 14 16:27:50 UTC 2011 Modified Files: src/sys/crypto/rijndael: rijndael-api-fst.c Log Message: Declare for-loop control variable outside of the for statement to prevent a warning and therefore fix the build. Ah! I just saw your warns=4 change. I presume my 'fix' goes against it, right?
Re: CVS commit: src/sys/crypto/rijndael
On May 14, 12:29pm, j...@julipedia.org (Julio Merino) wrote: -- Subject: Re: CVS commit: src/sys/crypto/rijndael | Declare for-loop control variable outside of the for statement to prevent | a warning and therefore fix the build. | | Ah! I just saw your warns=4 change. I presume my 'fix' goes against | it, right? Yes, you should revert it. Kernel code is supposed to use c99 features. christos
Re: CVS commit: src/sys/crypto/rijndael
On 5/14/11 12:31 PM, Christos Zoulas wrote: On May 14, 12:29pm, j...@julipedia.org (Julio Merino) wrote: -- Subject: Re: CVS commit: src/sys/crypto/rijndael | Declare for-loop control variable outside of the for statement to prevent | a warning and therefore fix the build. | | Ah! I just saw your warns=4 change. I presume my 'fix' goes against | it, right? Yes, you should revert it. Kernel code is supposed to use c99 features. OK; I'll do a test build before submitting the revert. I just realized that my tree already had your change when I committed this, yet the build still failed.