Re: CVS commit: src/sys/dev/hpc

2018-09-18 Thread Rin Okuyama
On 2018/09/18 23:59, Valery Ushakov wrote: ... Nick confirmed to me on IRC that mips kernel is in directly-mapped kseg0 (like sh3's P1), so I've edited the comment. Thank you! I sent pullup requests for hpckbd.c r1.33 of mine. I'll add your commits r1.34 and 35 for the sake of consistency.

Re: CVS commit: src/sys/dev/hpc

2018-09-18 Thread Valery Ushakov
On Tue, Sep 18, 2018 at 13:35:45 +0300, Valery Ushakov wrote: > On Tue, Sep 18, 2018 at 18:52:34 +0900, Rin Okuyama wrote: > > > On 2018/09/18 18:21, Valery Ushakov wrote: > > > On Tue, Sep 18, 2018 at 12:17:41 +0900, Rin Okuyama wrote: > > > > > > > > @@ -278,8 +279,10 @@

Re: CVS commit: src/sys/dev/hpc

2018-09-18 Thread Valery Ushakov
On Tue, Sep 18, 2018 at 18:52:34 +0900, Rin Okuyama wrote: > On 2018/09/18 18:21, Valery Ushakov wrote: > > On Tue, Sep 18, 2018 at 12:17:41 +0900, Rin Okuyama wrote: > > > > > > @@ -278,8 +279,10 @@ hpckbd_keymap_setup(struct hpckbd_core * > > > > * XXX The way this is done is really

Re: CVS commit: src/sys/dev/hpc

2018-09-18 Thread Rin Okuyama
On 2018/09/18 18:27, Valery Ushakov wrote: On Tue, Sep 18, 2018 at 18:16:05 +0900, Rin Okuyama wrote: Just curious; why comment lines within 80 char column are not allowed for this file? Just cosmetic reasons? 80 chars is "hard" limit, but it's convenient to use less than that if you can so

Re: CVS commit: src/sys/dev/hpc

2018-09-18 Thread Rin Okuyama
On 2018/09/18 18:21, Valery Ushakov wrote: On Tue, Sep 18, 2018 at 12:17:41 +0900, Rin Okuyama wrote: @@ -278,8 +279,10 @@ hpckbd_keymap_setup(struct hpckbd_core * * XXX The way this is done is really wrong. The __UNCONST() * is a hint as to what is wrong. This actually

Re: CVS commit: src/sys/dev/hpc

2018-09-18 Thread Valery Ushakov
On Tue, Sep 18, 2018 at 18:16:05 +0900, Rin Okuyama wrote: > Just curious; why comment lines within 80 char column are not > allowed for this file? Just cosmetic reasons? 80 chars is "hard" limit, but it's convenient to use less than that if you can so that you have extra space for things like

Re: CVS commit: src/sys/dev/hpc

2018-09-18 Thread Valery Ushakov
On Tue, Sep 18, 2018 at 12:17:41 +0900, Rin Okuyama wrote: > > @@ -278,8 +279,10 @@ hpckbd_keymap_setup(struct hpckbd_core * > > * XXX The way this is done is really wrong. The __UNCONST() > > * is a hint as to what is wrong. This actually ends up modifying > > * initialized data

Re: CVS commit: src/sys/dev/hpc

2018-09-18 Thread Rin Okuyama
Hi, Just curious; why comment lines within 80 char column are not allowed for this file? Just cosmetic reasons? Thanks, rin On 2018/09/18 18:09, Valeriy E. Ushakov wrote: Module Name:src Committed By: uwe Date: Tue Sep 18 09:09:26 UTC 2018 Modified Files:

Re: CVS commit: src/sys/dev/hpc

2018-09-18 Thread Rin Okuyama
On 2018/09/18 15:29, matthew green wrote: Rin Okuyama writes: Apply workaround introduced in r1.31 to hpcmips. Sorry, this is r1.32, not r1.31. How can I edit commit log of multiple lines? we don't like to do this except when it's really important, and i think this is not quite so relevant,

re: CVS commit: src/sys/dev/hpc

2018-09-18 Thread matthew green
Rin Okuyama writes: > > Apply workaround introduced in r1.31 to hpcmips. > > Sorry, this is r1.32, not r1.31. How can I edit commit log of multiple lines? we don't like to do this except when it's really important, and i think this is not quite so relevant, since it is now documented on the

Re: CVS commit: src/sys/dev/hpc

2018-09-17 Thread Rin Okuyama
Apply workaround introduced in r1.31 to hpcmips. Sorry, this is r1.32, not r1.31. How can I edit commit log of multiple lines? Thanks, rin On 2018/09/18 11:58, Rin Okuyama wrote: Module Name:src Committed By: rin Date: Tue Sep 18 02:58:10 UTC 2018 Modified Files: