Re: CVS commit: src/sys/external/bsd/drm/dist/shared-core

2014-09-07 Thread Cherry G. Mathew
Hi Matt,

This doesn't fix drm2 i915 breakage. Could you revisit this please, since
it's in external/ ?

Thanks,


On 5 September 2014 15:10, Matt Thomas m...@netbsd.org wrote:

 Module Name:src
 Committed By:   matt
 Date:   Fri Sep  5 09:40:44 UTC 2014

 Modified Files:
 src/sys/external/bsd/drm/dist/shared-core: i915_drv.h
 i915_suspend.c

 Log Message:
 Rename enum pipe to enum pipe so it won't conflcit with struct pipe.


 To generate a diff of this commit:
 cvs rdiff -u -r1.5 -r1.6
 src/sys/external/bsd/drm/dist/shared-core/i915_drv.h
 cvs rdiff -u -r1.6 -r1.7 \
 src/sys/external/bsd/drm/dist/shared-core/i915_suspend.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.




-- 
~~Cherry


Re: CVS commit: src/sys/external/bsd/drm/dist/shared-core

2014-09-06 Thread Matt Thomas

On Sep 6, 2014, at 12:28 PM, Cherry G. Mathew cherry.g.mat...@gmail.com wrote:

 Hi Matt,
 
 This doesn't fix drm2 i915 breakage. Could you revisit this please, since 
 it's in external/ ?
 
 Thanks,
 

If I revert, it still won't build.  So no.

i915 shouldn't be using enum pipe since it conflicts with struct pipe.