Re: CVS commit: src/sys/net

2020-01-28 Thread Kamil Rytarowski
On 29.01.2020 07:40, Jason Thorpe wrote: > >> On Jan 28, 2020, at 10:25 PM, Kamil Rytarowski wrote: >> >> The distribution build breaks for me with: > > Should be fixed with: > > /cvsroot/src/sys/rump/net/lib/libnet/Makefile,v <-- Makefile > new revision: 1.33; previous revision: 1.32 >

Re: CVS commit: src/sys/net

2020-01-28 Thread Jason Thorpe
> On Jan 28, 2020, at 10:25 PM, Kamil Rytarowski wrote: > > The distribution build breaks for me with: Should be fixed with: /cvsroot/src/sys/rump/net/lib/libnet/Makefile,v <-- Makefile new revision: 1.33; previous revision: 1.32 >

Re: CVS commit: src/sys/net

2020-01-28 Thread Kamil Rytarowski
On 29.01.2020 04:16, Jason R Thorpe wrote: > Module Name: src > Committed By: thorpej > Date: Wed Jan 29 03:16:28 UTC 2020 > > Modified Files: > src/sys/net: Makefile files.net if.c if.h > Added Files: > src/sys/net: if_stats.c if_stats.h > > Log Message: > Add support for

Re: CVS commit: src/sys/net

2019-12-04 Thread Masanobu SAITOH
On 2019/12/05 14:29, SAITOH Masanobu wrote: > Module Name: src > Committed By: msaitoh > Date: Thu Dec 5 05:29:28 UTC 2019 > > Modified Files: > src/sys/net: if_media.h > > Log Message: > Fix previous comment change for ifm_media. It was correct. > > The real problem is that

Re: CVS commit: src/sys/net

2019-09-23 Thread Ryota Ozaki
On Mon, Sep 23, 2019 at 4:14 PM Kamil Rytarowski wrote: > > On 23.09.2019 06:53, Rin Okuyama wrote: > > Hi, > > > > On 2019/09/22 18:30, Kamil Rytarowski wrote: > >> On 12.04.2018 06:38, Ryota Ozaki wrote: > >>> Module Name:src > >>> Committed By:ozaki-r > >>> Date:Thu Apr 12

Re: CVS commit: src/sys/net

2019-09-23 Thread Kamil Rytarowski
On 23.09.2019 06:53, Rin Okuyama wrote: > Hi, > > On 2019/09/22 18:30, Kamil Rytarowski wrote: >> On 12.04.2018 06:38, Ryota Ozaki wrote: >>> Module Name:    src >>> Committed By:    ozaki-r >>> Date:    Thu Apr 12 04:38:13 UTC 2018 >>> >>> Modified Files: >>> src/sys/net: if.h route.c

Re: CVS commit: src/sys/net

2019-09-22 Thread Rin Okuyama
Hi, On 2019/09/22 18:30, Kamil Rytarowski wrote: On 12.04.2018 06:38, Ryota Ozaki wrote: Module Name:src Committed By: ozaki-r Date: Thu Apr 12 04:38:13 UTC 2018 Modified Files: src/sys/net: if.h route.c route.h rtsock.c Log Message: Resolve tangled lock dependencies

Re: CVS commit: src/sys/net

2019-09-22 Thread Kamil Rytarowski
On 12.04.2018 06:38, Ryota Ozaki wrote: > Module Name: src > Committed By: ozaki-r > Date: Thu Apr 12 04:38:13 UTC 2018 > > Modified Files: > src/sys/net: if.h route.c route.h rtsock.c > > Log Message: > Resolve tangled lock dependencies in route.c > > This change sweeps

Re: CVS commit: src/sys/net/npf

2019-08-06 Thread Maxime Villard
Le 06/08/2019 à 12:31, Christos Zoulas a écrit : I did not see any messages about it, and the fix is fine until rmind comes up with something better. Yes turns out it was an off-list email It is not nice to have HEAD unusable for 2 weeks now (since July 22nd). Given your second commit, I

Re: CVS commit: src/sys/net/npf

2019-08-06 Thread Christos Zoulas
Yes, rmind asked me to commit the change in private email. christos > On Aug 6, 2019, at 3:59 PM, Maxime Villard wrote: > > Le 06/08/2019 à 12:31, Christos Zoulas a écrit : >> I did not see any messages about it, and the fix is fine until rmind comes >> up with something better. > > Yes

Re: CVS commit: src/sys/net/npf

2019-08-06 Thread Christos Zoulas
I did not see any messages about it, and the fix is fine until rmind comes up with something better. It is not nice to have HEAD unusable for 2 weeks now (since July 22nd). christos > On Aug 6, 2019, at 1:26 PM, Maxime Villard wrote: > > Le 06/08/2019 à 12:25, Christos Zoulas a écrit : >>

Re: CVS commit: src/sys/net/npf

2019-08-06 Thread Maxime Villard
Le 06/08/2019 à 12:25, Christos Zoulas a écrit : Module Name:src Committed By: christos Date: Tue Aug 6 10:25:13 UTC 2019 Modified Files: src/sys/net/npf: npf_conn.c Log Message: Introduce an npf_conn_destroy_idx() that can handle partially constructed conn structures.

Re: CVS commit: src/sys/net

2019-04-15 Thread Christos Zoulas
In article , Ryota Ozaki wrote: >On Tue, Apr 16, 2019 at 5:51 AM Christos Zoulas wrote: >> >> Module Name:src >> Committed By: christos >> Date: Mon Apr 15 20:51:46 UTC 2019 >> >> Modified Files: >> src/sys/net: if.c >> >> Log Message: >> Zero out the ifreq struct for

Re: CVS commit: src/sys/net

2019-04-15 Thread Ryota Ozaki
On Tue, Apr 16, 2019 at 5:51 AM Christos Zoulas wrote: > > Module Name:src > Committed By: christos > Date: Mon Apr 15 20:51:46 UTC 2019 > > Modified Files: > src/sys/net: if.c > > Log Message: > Zero out the ifreq struct for SIOCGIFCONF to avoid up to 127 bytes of stack >

Re: CVS commit: src/sys/net

2019-03-26 Thread Robert Elz
Date:Tue, 26 Mar 2019 00:23:32 + From:"Paul Goyette" Message-ID: <20190326002332.c0241f...@cvs.netbsd.org> | XXX Someone(tm) needs to update MAKEDEV to create the /dev/srtN device | nodes (with device-major 179)! Yes, I know ... That's easy - but as I

re: CVS commit: src/sys/net

2019-02-18 Thread matthew green
"Christos Zoulas" writes: > Module Name: src > Committed By: christos > Date: Mon Feb 18 23:13:14 UTC 2019 > > Modified Files: > src/sys/net: zlib.c > > Log Message: > add fallthrough's i specific avoided changing upstream code where possible by adding the relevant cflags. where

Re: CVS commit: src/sys/net

2018-12-14 Thread Rin Okuyama
Thank you for finding it out. I removed it in accident. rin On 2018/12/14 21:27, Martin Husemann wrote: Module Name:src Committed By: martin Date: Fri Dec 14 12:27:22 UTC 2018 Modified Files: src/sys/net: if_bridge.c Log Message: Need for ip6_statinc() prototype.

Re: CVS commit: src/sys/net

2018-12-13 Thread Jason Thorpe
Panic seems not optimal. A rate limited log message at LOG_ERROR seems better. -- thorpej Sent from my iPhone. > On Dec 13, 2018, at 12:54 PM, Rin Okuyama wrote: > > Module Name:src > Committed By:rin > Date:Thu Dec 13 20:54:50 UTC 2018 > > Modified Files: >src/sys/net:

Re: CVS commit: src/sys/net

2018-07-10 Thread Martin Husemann
On Tue, Jul 10, 2018 at 05:02:27PM +, Christos Zoulas wrote: > Should be pulled up to -8, with the other patch. Already done ;-)

Re: CVS commit: src/sys/net

2018-07-10 Thread Christos Zoulas
In article <20180710110040.e80fcf...@cvs.netbsd.org>, Robert Elz wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: kre >Date: Tue Jul 10 11:00:40 UTC 2018 > >Modified Files: > src/sys/net: if_llatbl.c > >Log Message: >Avoid attempting to call arp related functions if there

Re: CVS commit: src/sys/net/npf

2018-04-08 Thread Maxime Villard
Le 07/04/2018 à 23:28, Christos Zoulas a écrit : In article <20180407090627.20058f...@cvs.netbsd.org>, Maxime Villard wrote: -=-=-=-=-=- Module Name:src Committed By: maxv Date: Sat Apr 7 09:06:27 UTC 2018 Modified Files: src/sys/net/npf:

Re: CVS commit: src/sys/net/npf

2018-04-07 Thread Christos Zoulas
In article <20180407090627.20058f...@cvs.netbsd.org>, Maxime Villard wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: maxv >Date: Sat Apr 7 09:06:27 UTC 2018 > >Modified Files: > src/sys/net/npf: npf_inet.c > >Log Message: >Rewrite

Re: CVS commit: src/sys/net/npf

2018-01-30 Thread Maxime Villard
Le 31/01/2018 à 00:18, Mindaugas Rasiukevicius a écrit : [...] Fix this by using uint32_t. While here, it seems to me there is also a memory overflow: still in npf_cache_ip, npc_hlen may be incremented with a value that goes beyond the mbuf. [...] If the npc_hlen value is beyond the packet

Re: CVS commit: src/sys/net/npf

2018-01-30 Thread Mindaugas Rasiukevicius
"Maxime Villard" wrote: > Module Name: src > Committed By: maxv > Date: Fri Dec 15 21:00:26 UTC 2017 > > Modified Files: > src/sys/net/npf: npf.h > > Log Message: > Fix a vulnerability in NPF, that allows whatever incoming IPv6 packet to > bypass a certain number

Re: CVS commit: src/sys/net

2018-01-19 Thread Maxime Villard
Le 19/01/2018 à 13:31, Takeshi Nakayama a écrit : Module Name:src Committed By: nakayama Date: Fri Jan 19 12:31:28 UTC 2018 Modified Files: src/sys/net: if_ethersubr.c Log Message: Fix inverted logic. To generate a diff of this commit: cvs rdiff -u -r1.256 -r1.257

Re: CVS commit: src/sys/net

2018-01-08 Thread maya
On Tue, Jan 09, 2018 at 01:07:50AM +, m...@netbsd.org wrote: > This is causing PR kern/52914 (on netbsd-8, not current) Copied wrong number kern/52895 it's in -current but also -8

Re: CVS commit: src/sys/net

2017-12-20 Thread Ryota Ozaki
2017/12/18 22:09 "Christos Zoulas" <chris...@zoulas.com>: On Dec 18, 2:42pm, ozak...@netbsd.org (Ryota Ozaki) wrote: -- Subject: Re: CVS commit: src/sys/net | Oh cool. I didn't know that technique. Great, can you undo the change then? I already did it :) ozaki-r Thanks, christos

Re: CVS commit: src/sys/net

2017-12-18 Thread Christos Zoulas
On Dec 18, 2:42pm, ozak...@netbsd.org (Ryota Ozaki) wrote: -- Subject: Re: CVS commit: src/sys/net | Oh cool. I didn't know that technique. Great, can you undo the change then? Thanks, christos

Re: CVS commit: src/sys/net

2017-12-17 Thread Ryota Ozaki
On Thu, Dec 14, 2017 at 10:03 PM, Christos Zoulas <chris...@zoulas.com> wrote: > On Dec 14, 5:42pm, ozak...@netbsd.org (Ryota Ozaki) wrote: > -- Subject: Re: CVS commit: src/sys/net > > | Is there a flag to suppress auto inlining? COPTS=-fno-inline build.sh? > | Anyway n

Re: CVS commit: src/sys/net

2017-12-14 Thread Christos Zoulas
On Dec 14, 5:42pm, ozak...@netbsd.org (Ryota Ozaki) wrote: -- Subject: Re: CVS commit: src/sys/net | Is there a flag to suppress auto inlining? COPTS=-fno-inline build.sh? | Anyway no objection to revert the change that is not quite important | (but makes my life easy). just do: cat <<

Re: CVS commit: src/sys/net

2017-12-14 Thread Ryota Ozaki
On Thu, Dec 14, 2017 at 3:27 PM, Christos Zoulas wrote: > In article <20171214054314.e76edf...@cvs.netbsd.org>, > Ryota Ozaki wrote: >>-=-=-=-=-=- >> >>Module Name: src >>Committed By: ozaki-r >>Date: Thu Dec 14 05:43:14 UTC 2017 >>

Re: CVS commit: src/sys/net

2017-12-13 Thread Christos Zoulas
In article <20171214054314.e76edf...@cvs.netbsd.org>, Ryota Ozaki wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: ozaki-r >Date: Thu Dec 14 05:43:14 UTC 2017 > >Modified Files: > src/sys/net: rtsock.c > >Log Message: >Spinkle __noinline to

Re: CVS commit: src/sys/net

2017-11-21 Thread Masanobu SAITOH
On 2017/11/22 14:40, Robert Elz wrote: Date:Wed, 22 Nov 2017 04:56:52 + From:"SAITOH Masanobu" Message-ID: <20171122045652.2ee75f...@cvs.netbsd.org> | Return EINVAL in vlan_config() when a VLAN ID is 0 or 65535. | The spec states

Re: CVS commit: src/sys/net

2017-11-21 Thread Robert Elz
Date:Wed, 22 Nov 2017 04:56:52 + From:"SAITOH Masanobu" Message-ID: <20171122045652.2ee75f...@cvs.netbsd.org> | Return EINVAL in vlan_config() when a VLAN ID is 0 or 65535. | The spec states 0 and 65535 are reserved. Tags are 12 bigs,

Re: CVS commit: src/sys/net

2017-09-24 Thread Ryota Ozaki
On Fri, Sep 22, 2017 at 5:53 PM, Joerg Sonnenberger wrote: > On Fri, Sep 22, 2017 at 05:05:32AM +, Ryota Ozaki wrote: >> Module Name: src >> Committed By: ozaki-r >> Date: Fri Sep 22 05:05:32 UTC 2017 >> >> Modified Files: >> src/sys/net: route.c >> >> Log

Re: CVS commit: src/sys/net

2017-09-22 Thread Joerg Sonnenberger
On Fri, Sep 22, 2017 at 05:05:32AM +, Ryota Ozaki wrote: > Module Name: src > Committed By: ozaki-r > Date: Fri Sep 22 05:05:32 UTC 2017 > > Modified Files: > src/sys/net: route.c > > Log Message: > Remove the global lock for rtcache > > Thanks to removal of LIST_ENTRY of

Re: CVS commit: src/sys/net

2017-04-05 Thread Ryota Ozaki
On Thu, Apr 6, 2017 at 3:34 AM, Taylor R Campbell wrote: >> Date: Wed, 5 Apr 2017 15:46:38 +0800 (+08) >> From: Paul Goyette >> >> @@ -3385,6 +3428,13 @@ if_mcast_op(ifnet_t *ifp, const unsigned >> { >> int rc; >>

Re: CVS commit: src/sys/net

2017-04-05 Thread Taylor R Campbell
> Date: Wed, 5 Apr 2017 15:46:38 +0800 (+08) > From: Paul Goyette > > @@ -3385,6 +3428,13 @@ if_mcast_op(ifnet_t *ifp, const unsigned > { > int rc; > struct ifreq ifr; > + bool need_unlock = false; > + > + /* XXX if_ioctl_lock may or may not be

Re: CVS commit: src/sys/net

2017-04-05 Thread Paul Goyette
@@ -3385,6 +3428,13 @@ if_mcast_op(ifnet_t *ifp, const unsigned { int rc; struct ifreq ifr; + bool need_unlock = false; + + /* XXX if_ioctl_lock may or may not be held here */ + if (ifp->if_ioctl_lock != NULL && !mutex_owned(ifp->if_ioctl_lock)) { +

Re: CVS commit: src/sys/net

2017-01-26 Thread coypu
oops, I was wrong here, please disregard :-)

Re: CVS commit: src/sys/net

2017-01-26 Thread coypu
On Thu, Jan 26, 2017 at 09:13:19PM +, Nick Hudson wrote: > @@ -803,32 +790,14 @@ tunread(dev_t dev, struct uio *uio, int > goto out; > } > tp->tun_flags |= TUN_RWAIT; > - if (mtsleep((void *)tp,

Re: CVS commit: src/sys/net

2017-01-26 Thread coypu
Hi, On Thu, Jan 26, 2017 at 09:13:19PM +, Nick Hudson wrote: > @@ -534,14 +527,12 @@ tun_output(struct ifnet *ifp, struct mbu > const struct rtentry *rt) > { > struct tun_softc *tp = ifp->if_softc; > - int s; > int error; > #if defined(INET) ||

Re: CVS commit: src/sys/net

2016-06-27 Thread Kengo NAKAHARA
Hi, On 2016/06/27 18:55, Roy Marples wrote: > On 27/06/2016 09:58, Kengo NAKAHARA wrote: >> Module Name: src >> Committed By:knakahara >> Date:Mon Jun 27 08:58:50 UTC 2016 >> >> Modified Files: >> src/sys/net: if.c if.h >> >> Log Message: >> reduce link state changing

Re: CVS commit: src/sys/net

2016-06-27 Thread Roy Marples
On 27/06/2016 09:58, Kengo NAKAHARA wrote: > Module Name: src > Committed By: knakahara > Date: Mon Jun 27 08:58:50 UTC 2016 > > Modified Files: > src/sys/net: if.c if.h > > Log Message: > reduce link state changing softint if it is not required > > ok by ozaki-r@n.o There is a

Re: CVS commit: src/sys/net

2016-04-11 Thread Taylor R Campbell
Date: Mon, 11 Apr 2016 14:33:41 +0900 From: Ryota Ozaki On Mon, Apr 11, 2016 at 12:31 PM, Taylor R Campbell wrote: > Nice, thanks for doing this! Have you tried subjecting it to load, > with options DIAGNOSTIC?

Re: CVS commit: src/sys/net

2016-04-10 Thread Ryota Ozaki
On Mon, Apr 11, 2016 at 12:31 PM, Taylor R Campbell wrote: >Date: Mon, 11 Apr 2016 02:04:14 + >From: Ryota Ozaki > >Module Name:src >Committed By: ozaki-r >Date: Mon Apr 11 02:04:14 UTC 2016

Re: CVS commit: src/sys/net

2016-04-10 Thread Taylor R Campbell
Date: Mon, 11 Apr 2016 02:04:14 + From: Ryota Ozaki Module Name:src Committed By: ozaki-r Date: Mon Apr 11 02:04:14 UTC 2016 Modified Files: src/sys/net: bridgestp.c if_bridge.c if_bridgevar.h Log Message: Use pslist(9)

re: CVS commit: src/sys/net

2016-04-06 Thread matthew green
> And add an assertion of if_addrlen and ll_addr. thanks. i almost did this myself :-)

Re: CVS commit: src/sys/net

2016-02-21 Thread Ryota Ozaki
On Fri, Feb 19, 2016 at 12:16 PM, Roy Marples wrote: > On 18/02/2016 11:29, Ryota Ozaki wrote: >> Okay, I've changed my mind. Let's commit your patch anyway and >> keep an eye on the lossage messages to know how often and how >> many lossage happens. If there are issues, we can

Re: CVS commit: src/sys/net

2016-02-16 Thread Taylor R Campbell
Date: Wed, 17 Feb 2016 15:12:31 +0900 From: Ryota Ozaki On Wed, Feb 17, 2016 at 2:13 PM, Taylor R Campbell wrote: > Note that this queueing takes effect only if the link state changes > multiple times within

Re: CVS commit: src/sys/net

2016-02-16 Thread Ryota Ozaki
On Wed, Feb 17, 2016 at 1:40 PM, Roy Marples wrote: > On 2016-02-17 02:49, Ryota Ozaki wrote: >>> >>> If you don't read the patch, here is the comment I added to the >>> if_link_state_change() function: >>> >>> * Queue a change in the interface link state. >>> * >>> * The queue

Re: CVS commit: src/sys/net

2016-02-16 Thread Taylor R Campbell
Date: Wed, 17 Feb 2016 11:49:48 +0900 From: Ryota Ozaki And the priority provides asymmetric event deliveries; when the state repeats up and down, a down event is delivered if the final state is down while a down event and a up event are delivered if the final

Re: CVS commit: src/sys/net

2016-02-16 Thread Roy Marples
On 2016-02-17 02:49, Ryota Ozaki wrote: If you don't read the patch, here is the comment I added to the if_link_state_change() function: * Queue a change in the interface link state. * * The queue itself is very limited: * no state can be queued more than once * a higher priority state will

Re: CVS commit: src/sys/net

2016-02-16 Thread Ryota Ozaki
On Wed, Feb 17, 2016 at 10:46 AM, Roy Marples wrote: > On Tuesday 16 February 2016 22:20:37 Taylor R Campbell wrote: >> Except for an issue with queueing discussed privately (scheduling a >> softint that is already scheduled won't cause it to run again, so >>

Re: CVS commit: src/sys/net

2016-02-16 Thread Taylor R Campbell
Date: Tue, 16 Feb 2016 13:24:15 + From: Roy Marples I found the time to work on this, here is the patch I've been running for an hour or so upping and downing interfaces. The rule in Roy's patch is that each new state changes kicks out all higher-priority

Re: CVS commit: src/sys/net

2016-02-16 Thread Taylor R Campbell
Date: Tue, 16 Feb 2016 16:30:54 +0900 From: Ryota Ozaki On Tue, Feb 16, 2016 at 6:16 AM, Taylor R Campbell wrote: > void > if_link_state_change(struct ifnet *ifp, int link_state) > { > int s; >

Re: CVS commit: src/sys/net

2016-02-16 Thread Roy Marples
On 16/02/2016 08:38, Roy Marples wrote: > On Tuesday 16 February 2016 13:37:28 you wrote: >>> Oh, I see. We shouldn't drop any events of link state changes. >> >> i don't see any point in keeping a huge series of link changes >> if they can be collapsed into an equivalent sequence. with VMs >>

Re: CVS commit: src/sys/net

2016-02-16 Thread Roy Marples
On 16/02/2016 08:38, Roy Marples wrote: > for (i = 0; i < ifp->if_link_queue_len; i++) { > if (link_state <= ifp->if_link_queue[i]) { > ifp->if_link_queue[i] = link_state; > ifp->if_link_queue_len = i; This should be

Re: CVS commit: src/sys/net

2016-02-16 Thread Roy Marples
On Tuesday 16 February 2016 13:37:28 you wrote: > > Oh, I see. We shouldn't drop any events of link state changes. > > i don't see any point in keeping a huge series of link changes > if they can be collapsed into an equivalent sequence. with VMs > and other user-controlled systems it's possible

Re: CVS commit: src/sys/net

2016-02-15 Thread Ryota Ozaki
On Tue, Feb 16, 2016 at 6:16 AM, Taylor R Campbell wrote: >Date: Mon, 15 Feb 2016 11:06:52 + >From: Roy Marples > >On 15/02/2016 10:32, Ryota Ozaki wrote: >> I think we can fix by returning from

Re: CVS commit: src/sys/net

2016-02-15 Thread Ryota Ozaki
On Tue, Feb 16, 2016 at 11:37 AM, matthew green wrote: >> Oh, I see. We shouldn't drop any events of link state changes. > > i don't see any point in keeping a huge series of link changes > if they can be collapsed into an equivalent sequence. with VMs > and other

re: CVS commit: src/sys/net

2016-02-15 Thread matthew green
> Oh, I see. We shouldn't drop any events of link state changes. i don't see any point in keeping a huge series of link changes if they can be collapsed into an equivalent sequence. with VMs and other user-controlled systems it's possible to flood such a link state checking engine. .mrg.

Re: CVS commit: src/sys/net

2016-02-15 Thread Taylor R Campbell
Date: Mon, 15 Feb 2016 11:06:52 + From: Roy Marples On 15/02/2016 10:32, Ryota Ozaki wrote: > I think we can fix by returning from if_link_state_change_si > if ifp->if_link_state == ifp->if_old_link_state. Is it correct? Then we're not doing what we

Re: CVS commit: src/sys/net

2016-02-15 Thread Martin Husemann
On Mon, Feb 15, 2016 at 11:06:52AM +, Roy Marples wrote: > Can we not extend softint_schedule to take some user data? That way, > each call (which I'm assuming would be sequential) can carry the link > state change in the user data which can then be applied to the interface. Sounds like a

Re: CVS commit: src/sys/net

2016-02-15 Thread Roy Marples
On 15/02/2016 10:32, Ryota Ozaki wrote: > On Mon, Feb 15, 2016 at 6:35 PM, Roy Marples wrote: >> On 15/02/2016 08:08, Ryota Ozaki wrote: >>> Module Name: src >>> Committed By: ozaki-r >>> Date: Mon Feb 15 08:08:04 UTC 2016 >>> >>> Modified Files: >>> src/sys/net:

Re: CVS commit: src/sys/net

2016-01-13 Thread Kengo NAKAHARA
Hi, On 2016/01/13 7:10, David Laight wrote: > On Fri, Dec 11, 2015 at 11:37:29AM +0900, Kengo NAKAHARA wrote: >> # Sorry, I forgot to subscribe source-changes-d ml, I reply as >> # a new mail. >> >> Hi, >> >>> In article <20151210081103.E0FBBFB83%cvs.NetBSD.org@localhost>, >>> Kengo NAKAHARA

Re: CVS commit: src/sys/net

2016-01-12 Thread David Laight
On Fri, Dec 11, 2015 at 11:37:29AM +0900, Kengo NAKAHARA wrote: > # Sorry, I forgot to subscribe source-changes-d ml, I reply as > # a new mail. > > Hi, > > > In article <20151210081103.E0FBBFB83%cvs.NetBSD.org@localhost>, > > Kengo NAKAHARA wrote: >

Re: CVS commit: src/sys/net

2015-12-10 Thread Kengo NAKAHARA
# Sorry, I forgot to subscribe source-changes-d ml, I reply as # a new mail. Hi, > In article <20151210081103.E0FBBFB83%cvs.NetBSD.org@localhost>, > Kengo NAKAHARA wrote: >>-=-=-=-=-=- >> >>Module Name: src >>Committed By: knakahara >>Date: Thu

Re: CVS commit: src/sys/net

2015-12-10 Thread Christos Zoulas
On Dec 11, 11:37am, k-nakah...@iij.ad.jp (Kengo NAKAHARA) wrote: -- Subject: Re: CVS commit: src/sys/net | Hi, | | > In article <20151210081103.E0FBBFB83%cvs.NetBSD.org@localhost>, | > Kengo NAKAHARA <source-changes-d%NetBSD.org@localhost> wrote: | >>-=-=-=-=-=- | >&g

Re: CVS commit: src/sys/net

2015-12-10 Thread Christos Zoulas
In article <20151210081103.e0fbbf...@cvs.netbsd.org>, Kengo NAKAHARA wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: knakahara >Date: Thu Dec 10 08:11:03 UTC 2015 > >Modified Files: > src/sys/net: if_gif.c > >Log Message: >kmem_zalloc(,

Re: CVS commit: src/sys/net

2015-12-10 Thread Greg Troxel
chris...@astron.com (Christos Zoulas) writes: > In article <20151210081103.e0fbbf...@cvs.netbsd.org>, > Kengo NAKAHARA wrote: >>-=-=-=-=-=- >> >>Module Name: src >>Committed By: knakahara >>Date: Thu Dec 10 08:11:03 UTC 2015 >> >>Modified Files: >>

Re: CVS commit: src/sys/net

2015-12-10 Thread Kengo NAKAHARA
Hi, On 2015/12/11 13:00, Christos Zoulas wrote: > On Dec 11, 11:37am, k-nakah...@iij.ad.jp (Kengo NAKAHARA) wrote: > -- Subject: Re: CVS commit: src/sys/net > > | Hi, > | > | > In article <20151210081103.E0FBBFB83%cvs.NetBSD.org@localhost>, > | > Kengo NAKA

Re: CVS commit: src/sys/net

2015-12-10 Thread Christos Zoulas
On Dec 11, 1:25pm, k-nakah...@iij.ad.jp (Kengo NAKAHARA) wrote: -- Subject: Re: CVS commit: src/sys/net | I revert KASSERT in if_gif.c, and I use 'if' instead of KASSERT from now. Thanks. | Thank you for your quickly update! Thanks for bringing this up. I've been meaning to do something

Re: CVS commit: src/sys/net/npf

2015-10-18 Thread Christos Zoulas
In article <20151019002957.b972...@cvs.netbsd.org>, Christos Zoulas wrote: >Log Message: >Fix the code so that it works in all 3 cases: non-modular, modular/builtin, >modular/filesystem. In the non-modular case we initialize through attach. >In the modular/builtin

Re: CVS commit: src/sys/net

2015-10-05 Thread Ryota Ozaki
On Wed, Sep 30, 2015 at 11:15 PM, Christoph Badura wrote: > On Wed, Sep 30, 2015 at 07:12:32AM +, Ryota Ozaki wrote: >> Modified Files: >> src/sys/net: if.h if_llatbl.c if_llatbl.h >> >> Log Message: >> Make GATEWAY (fastforward) work again >> >> With GATEWAY (fastforward),

Re: CVS commit: src/sys/net

2015-09-30 Thread Christoph Badura
On Wed, Sep 30, 2015 at 07:12:32AM +, Ryota Ozaki wrote: > Modified Files: > src/sys/net: if.h if_llatbl.c if_llatbl.h > > Log Message: > Make GATEWAY (fastforward) work again > > With GATEWAY (fastforward), the whole forwarding processing runs in > hardware interrupt context. So we

Re: CVS commit: src/sys/net/if_vlan.c

2015-04-03 Thread Ryota Ozaki
On Wed, Apr 1, 2015 at 5:50 AM, Christoph Badura b...@bsd.de wrote: On Tue, Mar 31, 2015 at 11:09:02AM +0900, Ryota Ozaki wrote: On Tue, Mar 31, 2015 at 1:42 AM, Matt Thomas m...@3am-software.com wrote: It lacks compensating for the fact the CRC has been stripped by the time vlan gets the

Re: CVS commit: src/sys/net/if_vlan.c

2015-03-31 Thread Christoph Badura
On Tue, Mar 31, 2015 at 11:09:02AM +0900, Ryota Ozaki wrote: On Tue, Mar 31, 2015 at 1:42 AM, Matt Thomas m...@3am-software.com wrote: It lacks compensating for the fact the CRC has been stripped by the time vlan gets the packet. # matt@ explained well than me... Note that the issue was

Re: CVS commit: src/sys/net/if_vlan.c

2015-03-30 Thread Christoph Badura
On Sun, Mar 29, 2015 at 01:30:43PM +, Ryota Ozaki wrote: Module Name: src Committed By: ozaki-r Date: Sun Mar 29 13:30:43 UTC 2015 Modified Files: src/sys/net: if_vlan.c Log Message: Correct frame padding length vlan pads a frame with zeros up to 68 bytes

Re: CVS commit: src/sys/net

2014-12-01 Thread Martin Husemann
On Mon, Dec 01, 2014 at 11:54:23AM +0900, Ryota Ozaki wrote: BTW, we may need ATF tests to ring the bell for such regressions. This is a bit tricky to do as we do not expose a sane api to create old binaries from source. It would boil down to copy paste of the old structure definition and some

Re: CVS commit: src/sys/net

2014-12-01 Thread Antti Kantee
On 01/12/14 08:01, Martin Husemann wrote: On Mon, Dec 01, 2014 at 11:54:23AM +0900, Ryota Ozaki wrote: BTW, we may need ATF tests to ring the bell for such regressions. This is a bit tricky to do as we do not expose a sane api to create old binaries from source. It would boil down to copy

Re: CVS commit: src/sys/net

2014-12-01 Thread Ryota Ozaki
On Mon, Dec 1, 2014 at 5:01 PM, Martin Husemann mar...@duskware.de wrote: On Mon, Dec 01, 2014 at 11:54:23AM +0900, Ryota Ozaki wrote: BTW, we may need ATF tests to ring the bell for such regressions. This is a bit tricky to do as we do not expose a sane api to create old binaries from

Re: CVS commit: src/sys/net

2014-12-01 Thread Martin Husemann
On Mon, Dec 01, 2014 at 11:21:17PM +0900, Ryota Ozaki wrote: Hmm, in this case, a test with a new userland binary (7.99.2) and a new kernel (7.99.2) can expose the regression. So I thought we need to add a test that does ioctl(SIOCGIFCONF) (or just run ifconfig with no argument). Oh, I

Re: CVS commit: src/sys/net

2014-12-01 Thread Ryota Ozaki
On Mon, Dec 1, 2014 at 11:28 PM, Martin Husemann mar...@duskware.de wrote: On Mon, Dec 01, 2014 at 11:21:17PM +0900, Ryota Ozaki wrote: Hmm, in this case, a test with a new userland binary (7.99.2) and a new kernel (7.99.2) can expose the regression. So I thought we need to add a test that

Re: CVS commit: src/sys/net

2014-12-01 Thread Christos Zoulas
On Dec 1, 11:21pm, ozak...@netbsd.org (Ryota Ozaki) wrote: -- Subject: Re: CVS commit: src/sys/net | On Mon, Dec 1, 2014 at 5:01 PM, Martin Husemann mar...@duskware.de wrote: | On Mon, Dec 01, 2014 at 11:54:23AM +0900, Ryota Ozaki wrote: | BTW, we may need ATF tests to ring the bell

Re: CVS commit: src/sys/net

2014-12-01 Thread Justin Cormack
On Mon, Dec 1, 2014 at 12:15 PM, Antti Kantee po...@netbsd.org wrote: Antti, Justin, can we separate the rump userland from the rump kernel binaries easily and put them in different sets, and then run the userland from -6 or -7 against the (rump-)kernel from -current? Copying prebuilt

Re: CVS commit: src/sys/net

2014-11-30 Thread Ryota Ozaki
On Mon, Dec 1, 2014 at 9:27 AM, Christos Zoulas chris...@netbsd.org wrote: Module Name:src Committed By: christos Date: Mon Dec 1 00:27:05 UTC 2014 Modified Files: src/sys/net: if.c Log Message: PR/49437: jmcneill: revert broken changes that broke SIOCGIFCONF

Re: CVS commit: src/sys/net

2014-11-27 Thread Matt Thomas
On Nov 26, 2014, at 11:26 PM, Masao Uebayashi uebay...@gmail.com wrote: On Thu, Nov 27, 2014 at 4:20 PM, Matt Thomas m...@3am-software.com wrote: Or completely hide sizeof(struct ifnet) by forcing use of if_alloc(), as struct device did. Doesn't work since struct ifnet is embedded in

Re: CVS commit: src/sys/net

2014-11-27 Thread Masao Uebayashi
I predict that in the near future the network stack will act like a batch manner; instead of moving layers for a single packet, pass a batch of packets to the next layer; each layer processes a batch of packets in a loop and stay longer (than now) holding a relevant context object cached. In such

Re: CVS commit: src/sys/net

2014-11-26 Thread Matt Thomas
On Nov 26, 2014, at 1:38 AM, Ryota Ozaki ozak...@netbsd.org wrote: Module Name: src Committed By: ozaki-r Date: Wed Nov 26 09:38:42 UTC 2014 Modified Files: src/sys/net: if.c if.h Log Message: Change if_slowtimo_ch to a pointer One benefit to do so is to reduce

Re: CVS commit: src/sys/net

2014-11-26 Thread Ryota Ozaki
On Thu, Nov 27, 2014 at 10:30 AM, Matt Thomas m...@3am-software.com wrote: On Nov 26, 2014, at 1:38 AM, Ryota Ozaki ozak...@netbsd.org wrote: Module Name: src Committed By: ozaki-r Date: Wed Nov 26 09:38:42 UTC 2014 Modified Files: src/sys/net: if.c if.h Log Message:

Re: CVS commit: src/sys/net

2014-11-26 Thread Masao Uebayashi
Maybe adding a few spare members, like 5 pointers, to reduce # of bumps ... ?

Re: CVS commit: src/sys/net

2014-11-26 Thread Masao Uebayashi
On Thu, Nov 27, 2014 at 10:51 AM, Masao Uebayashi uebay...@gmail.com wrote: Maybe adding a few spare members, like 5 pointers, to reduce # of bumps ... ? Or completely hide sizeof(struct ifnet) by forcing use of if_alloc(), as struct device did.

Re: CVS commit: src/sys/net

2014-11-26 Thread Ryota Ozaki
On Thu, Nov 27, 2014 at 10:51 AM, Masao Uebayashi uebay...@gmail.com wrote: Maybe adding a few spare members, like 5 pointers, to reduce # of bumps ... ? I thought the version bump is required because a member has been changed (a struct to a pointer). So IIUC the spare members don't help for

Re: CVS commit: src/sys/net

2014-11-26 Thread Ryota Ozaki
On Thu, Nov 27, 2014 at 10:55 AM, Masao Uebayashi uebay...@gmail.com wrote: On Thu, Nov 27, 2014 at 10:51 AM, Masao Uebayashi uebay...@gmail.com wrote: Maybe adding a few spare members, like 5 pointers, to reduce # of bumps ... ? Or completely hide sizeof(struct ifnet) by forcing use of

Re: CVS commit: src/sys/net

2014-11-26 Thread Ryota Ozaki
On Thu, Nov 27, 2014 at 11:39 AM, matthew green m...@eterna.com.au wrote: Ryota Ozaki writes: On Thu, Nov 27, 2014 at 10:51 AM, Masao Uebayashi uebay...@gmail.com wrote: Maybe adding a few spare members, like 5 pointers, to reduce # of bumps ... ? I thought the version bump is required

Re: CVS commit: src/sys/net

2014-11-26 Thread Masao Uebayashi
On Thu, Nov 27, 2014 at 11:39 AM, matthew green m...@eterna.com.au wrote: hiding stuff inside an alloc doesn't really help much when the kernel code needs to access the structure anyway, unless you also hide all accesses to the structure inside functions. Right. And some members, including

Re: CVS commit: src/sys/net

2014-11-26 Thread Matt Thomas
On Nov 26, 2014, at 5:55 PM, Masao Uebayashi uebay...@gmail.com wrote: On Thu, Nov 27, 2014 at 10:51 AM, Masao Uebayashi uebay...@gmail.com wrote: Maybe adding a few spare members, like 5 pointers, to reduce # of bumps ... ? Or completely hide sizeof(struct ifnet) by forcing use of

Re: CVS commit: src/sys/net

2014-11-26 Thread Masao Uebayashi
On Thu, Nov 27, 2014 at 4:20 PM, Matt Thomas m...@3am-software.com wrote: Or completely hide sizeof(struct ifnet) by forcing use of if_alloc(), as struct device did. Doesn't work since struct ifnet is embedded in ethercom/fddicom Right. I mean, I want to make them alloc'ed to improve

Re: CVS commit: src/sys/net

2014-11-20 Thread Alexander Nasonov
Christos Zoulas wrote: In article 20141119210214.GA8310@neva, Alexander Nasonov al...@yandex.ru wrote: I don't think SLJIT_UMOD exists. You need to emit SLJIT_SUB after SLJIT_UDIV. This should be pretty straigthforward. But I don't mind if you make a function call for these quite rare

  1   2   >