Re: CVS commit: src/tests/lib/libc/stdlib
On Sat, Jun 27, 2020 at 10:39:08AM +, m...@netbsd.org wrote: > > Add the default TNF copyright (2005), cf. PR misc/55419. > > I don't think we can generally do this. Can you clarify if you discussed > this with the author in commit messages? Well, the committer is christos, and I doubt he cares. But as noted in the test, this 15 year old code snippet is from another person. Like with many test cases, I suppose it was originally taken/modified from a PR or a mailing list. As I noted in PR misc/55419, the problem is generic. I doubt whether it is even possible to contact all people whose code appears in src/tests. But I guess at least all NetBSD people should add the meta-data if they have code in src/tests. - Jukka
Re: CVS commit: src/tests/lib/libc/stdlib
On Sat, Jun 27, 2020 at 10:19:43AM +, Jukka Ruohonen wrote: > Module Name: src > Committed By: jruoho > Date: Sat Jun 27 10:19:43 UTC 2020 > > Modified Files: > src/tests/lib/libc/stdlib: t_mbtowc.c > > Log Message: > Add the default TNF copyright (2005), cf. PR misc/55419. > > > To generate a diff of this commit: > cvs rdiff -u -r1.1 -r1.2 src/tests/lib/libc/stdlib/t_mbtowc.c > I don't think we can generally do this. Can you clarify if you discussed this with the author in commit messages? Thanks.
Re: CVS commit: src/tests/lib/libc/stdlib
In article <20110715140041.6d97117...@cvs.netbsd.org>, Jukka Ruohonen wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: jruoho >Date: Fri Jul 15 14:00:41 UTC 2011 > >Modified Files: > src/tests/lib/libc/stdlib: Makefile > >Log Message: >Fix wrong linker flag that has always been lurking here. Actually I think it is better to put -pthread in CFLAGS since this is the portable way to get the threaded compiler environment. christos
Re: CVS commit: src/tests/lib/libc/stdlib
On Jun 4, 2011, at 4:35 PM, Adam Hamsik wrote: > > On Jun,Sunday 5 2011, at 12:58 AM, Jukka Ruohonen wrote: > >> On Sat, Jun 04, 2011 at 10:49:49PM +, Adam Hamsik wrote: >>> Module Name:src >>> Committed By: haad >>> Date: Sat Jun 4 22:49:49 UTC 2011 >>> >>> Modified Files: >>> src/tests/lib/libc/stdlib: t_strtol.c >>> >>> Log Message: >>> Fix problem with overflowing constant definition >>> >>> t_strtol.c:95: warning: overflow in implicit constant conversion >> >> Can you note the architecture and explain the overflow so that I can >> learn something? > > Architecture i386 - PAE, also dies on powerpc.
Re: CVS commit: src/tests/lib/libc/stdlib
On Jun,Sunday 5 2011, at 12:58 AM, Jukka Ruohonen wrote: > On Sat, Jun 04, 2011 at 10:49:49PM +, Adam Hamsik wrote: >> Module Name: src >> Committed By:haad >> Date:Sat Jun 4 22:49:49 UTC 2011 >> >> Modified Files: >> src/tests/lib/libc/stdlib: t_strtol.c >> >> Log Message: >> Fix problem with overflowing constant definition >> >> t_strtol.c:95: warning: overflow in implicit constant conversion > > Can you note the architecture and explain the overflow so that I can > learn something? Architecture i386 - PAE, # compile kern/strtoull.o /usr/devel/buildslave/obj/i386/tooldir/bin/i486--netbsdelf-gcc -O2 -Wall -Os -ffreestanding -std=gnu99 -Werror -march=i386 -mtune=i386 --sysroot=/usr/devel/buildslave/obj/i386/destdir.i386 -I/usr/devel/buildslave/full/build/sys/arch/i386/stand/netboot/3c509/../../../../../lib/libkern/arch/i386 --sysroot=/usr/devel/buildslave/obj/i386/destdir.i386 -DSLOW -DSUPPORT_BOOTP -DSUPPORT_DHCP -DSUPPORT_TFTP -DBOOTROM -DRELOC=0x9 -nostdinc -I/usr/devel/buildslave/obj/i386/sys/arch/i386/stand/netboot/3c509 -I/usr/devel/buildslave/full/build/sys/arch/i386/stand/netboot/3c509/../../../../.. -I/usr/devel/buildslave/full/build/sys/arch/i386/stand/netboot/3c509/../../../../../arch/i386/stand/lib -I/usr/devel/buildslave/full/build/sys/arch/i386/stand/netboot/3c509/../../../../../lib/libsa -D_STANDALONE -I/usr/devel/buildslave/full/build/sys/arch/i386/stand/netboot/3c509/../../../../../lib/libkern/../../../common/lib/libc/quad -I/usr/devel/buildslave/full/build/sys/arch/i386/stand/netboot/3c509/../../../../../lib/libkern/../../../common/lib/libc/string -I/usr/devel/buildslave/full/build/sys/arch/i386/stand/netboot/3c509/../../../../../lib/libkern/../../../common/lib/libc/arch/i386/string -I/usr/devel/buildslave/full/build/sys/arch/i386/stand/netboot/3c509/../../../../../lib/libkern/../../../common/lib/libc/quad -I/usr/devel/buildslave/full/build/sys/arch/i386/stand/netboot/3c509/../../../../../lib/libkern/../../../common/lib/libc/string -I/usr/devel/buildslave/full/build/sys/arch/i386/stand/netboot/3c509/../../../../../lib/libkern/../../../common/lib/libc/arch/i386/string -I/usr/devel/buildslave/full/build/sys/arch/i386/stand/netboot/3c509/../../../../../lib/libkern/../../../common/include -c /usr/devel/buildslave/full/build/sys/arch/i386/stand/netboot/3c509/../../../../../lib/libkern/../../../common/lib/libc/stdlib/strtoull.c -o strtoull.o --- dependall-tests --- cc1: warnings being treated as errors /usr/devel/buildslave/full/build/tests/lib/libc/stdlib/t_strtol.c: In function 'atfu_strtol_base_body': /usr/devel/buildslave/full/build/tests/lib/libc/stdlib/t_strtol.c:95: warning: overflow in implicit constant conversion /usr/devel/buildslave/full/build/tests/lib/libc/stdlib/t_strtol.c:96: warning: overflow in implicit constant conversion *** [t_strtol.o] Error code 1 nbmake: stopped in /usr/devel/buildslave/full/build/tests/lib/libc/stdlib 1 error nbmake: stopped in /usr/devel/buildslave/full/build/tests/lib/libc/stdlib Please revert/fix my commit if I did it wrong. But I can compile -current with it. Regards Adam.
Re: CVS commit: src/tests/lib/libc/stdlib
On Sat, Jun 04, 2011 at 10:49:49PM +, Adam Hamsik wrote: > Module Name: src > Committed By: haad > Date: Sat Jun 4 22:49:49 UTC 2011 > > Modified Files: > src/tests/lib/libc/stdlib: t_strtol.c > > Log Message: > Fix problem with overflowing constant definition > > t_strtol.c:95: warning: overflow in implicit constant conversion Can you note the architecture and explain the overflow so that I can learn something? - Jukka.
Re: CVS commit: src/tests/lib/libc/stdlib
On Tue, May 10, 2011 at 11:37:16AM -0700, Cliff Neighbors wrote: > > In file included from > > /home/cliff/netbsd/NetBSD-current/usr/src/tests/lib/libc/s > > tdlib/t_strtod.c:38: > > /home/cliff/netbsd/NetBSD-current/build/evbmips64-eb-20110510/dest/usr/include/f > > env.h:29:2: error: #error "fenv.h is currently not supported for this > > architectu > > re" > > /home/cliff/netbsd/NetBSD-current/build/evbmips64-eb-20110510/dest/usr/include/f > > env.h:35:26: error: machine/fenv.h: No such file or directory > > nbmkdep: compile failed. > > *** [t_strtod.d] Error code 1 > > > > do we need #ifdef Honor_FLT_ROUNDS around that include? Hmm, I guess so. Or #ifndef NO_FENV_H? I am not familiar with the conditional compilation of gdtoa. - Jukka.
Re: CVS commit: src/tests/lib/libc/stdlib
Jukka, #include fenv.h as part of this seems to have caused build.sh to break on arch evbmips64-eb > In file included from > /home/cliff/netbsd/NetBSD-current/usr/src/tests/lib/libc/s > tdlib/t_strtod.c:38: > /home/cliff/netbsd/NetBSD-current/build/evbmips64-eb-20110510/dest/usr/include/f > env.h:29:2: error: #error "fenv.h is currently not supported for this > architectu > re" > /home/cliff/netbsd/NetBSD-current/build/evbmips64-eb-20110510/dest/usr/include/f > env.h:35:26: error: machine/fenv.h: No such file or directory > nbmkdep: compile failed. > *** [t_strtod.d] Error code 1 > do we need #ifdef Honor_FLT_ROUNDS around that include? -cliff- On May 10, 2011, at 8:20 AM, Jukka Ruohonen wrote: > Module Name: src > Committed By: jruoho > Date: Tue May 10 15:20:19 UTC 2011 > > Modified Files: > src/tests/lib/libc/stdlib: t_strtod.c > > Log Message: > Verify that strtod(3) honors the current rounding mode set by fesetround(3). > Passes on amd64. Prompted by a bug in the GNU C library. > > > To generate a diff of this commit: > cvs rdiff -u -r1.7 -r1.8 src/tests/lib/libc/stdlib/t_strtod.c > > Please note that diffs are not public domain; they are subject to the > copyright notices on the relevant files. >
