CVS commit: src/usr.bin/make/unit-tests

2021-02-14 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Feb 15 07:58:19 UTC 2021 Modified Files: src/usr.bin/make/unit-tests: directive-for-escape.exp directive-for-escape.mk Log Message: make: improve comments in test for expansions in .for loops To generate a diff

CVS commit: src/usr.bin/make

2021-02-14 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Feb 15 07:42:35 UTC 2021 Modified Files: src/usr.bin/make: test-variants.sh Log Message: make: fix typo in comment To generate a diff of this commit: cvs rdiff -u -r1.8 -r1.9 src/usr.bin/make/test-variants.sh Please note

CVS commit: src/usr.bin/xlint/lint1

2021-02-14 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Feb 15 07:40:18 UTC 2021 Modified Files: src/usr.bin/xlint/lint1: tree.c Log Message: lint: remove redundant comment That comment was useful when there was no function is_null_pointer. Back then, the code for testing a null

CVS commit: src/usr.bin/xlint/lint1

2021-02-14 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Feb 15 07:36:40 UTC 2021 Modified Files: src/usr.bin/xlint/lint1: tree.c Log Message: lint: extract typeok_colon_pointer from typeok_colon The subtype information is now only accessed if both operands are actually pointers.

CVS commit: src/tests/usr.bin/xlint/lint1

2021-02-14 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Feb 15 07:18:20 UTC 2021 Modified Files: src/tests/usr.bin/xlint/lint1: msg_124.c Log Message: tests/lint: fix comments in test for message 124 To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7

CVS commit: src/tests/lib/libcurses

2021-02-14 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Feb 15 07:06:27 UTC 2021 Modified Files: src/tests/lib/libcurses/director: testlang_conf.l testlang_parse.y src/tests/lib/libcurses/slave: commands.c Log Message: tests/libcurses: fix error handling for non-system

CVS commit: src/usr.bin/make

2021-02-14 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Feb 15 06:46:01 UTC 2021 Modified Files: src/usr.bin/make: var.c Log Message: make: clean up code and comments around ModifyWord In ModifyWords, there is no "passed string" anymore since that function now directly operates

CVS commit: src/sys/netinet

2021-02-14 Thread Kengo NAKAHARA
Module Name:src Committed By: knakahara Date: Mon Feb 15 03:41:01 UTC 2021 Modified Files: src/sys/netinet: ip_flow.c Log Message: Fix build failure for options GATEWAY. To generate a diff of this commit: cvs rdiff -u -r1.83 -r1.84 src/sys/netinet/ip_flow.c Please note

CVS commit: src/sys/sys

2021-02-14 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Mon Feb 15 00:44:09 UTC 2021 Modified Files: src/sys/sys: mbuf.h Log Message: remove _ prefix from args To generate a diff of this commit: cvs rdiff -u -r1.228 -r1.229 src/sys/sys/mbuf.h Please note that diffs are not public

CVS commit: src/usr.bin/make

2021-02-14 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Feb 14 22:48:17 UTC 2021 Modified Files: src/usr.bin/make: var.c Log Message: make: clean up memory management in evaluation of expressions The condition "st->newValue.str != val" in ApplySingleModifier made the memory

CVS commit: src/usr.bin/make

2021-02-14 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Feb 14 21:54:42 UTC 2021 Modified Files: src/usr.bin/make: var.c Log Message: make: reduce redundant code around ModifyWords The result of ModifyWords had been passed to Expr_SetValueOwn in all cases. The last argument to

CVS commit: src/usr.bin/make

2021-02-14 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Feb 14 21:32:58 UTC 2021 Modified Files: src/usr.bin/make: nonints.h Log Message: make: clean up FStr and MFStr memory in cleanup mode To generate a diff of this commit: cvs rdiff -u -r1.202 -r1.203

CVS commit: src/sys

2021-02-14 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Sun Feb 14 20:58:35 UTC 2021 Modified Files: src/sys/net: if_arp.h if_bridge.c src/sys/netinet: icmp_private.h if_arp.c igmp_var.h in_l2tp.c ip_flow.c ip_input.c ip_private.h tcp_input.c tcp_private.h

CVS commit: src/sys/arch/sparc64/doc

2021-02-14 Thread Palle Lyckegaard
Module Name:src Committed By: palle Date: Sun Feb 14 20:30:31 UTC 2021 Modified Files: src/sys/arch/sparc64/doc: TODO Log Message: sun4v: update TODO with status of verified systems(T2000, T5 and qemu) To generate a diff of this commit: cvs rdiff -u -r1.32 -r1.33

CVS commit: src/usr.bin/make

2021-02-14 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Feb 14 20:22:30 UTC 2021 Modified Files: src/usr.bin/make: var.c Log Message: make: print error about failed shell command before overwriting variable Memory management of the value of variable expressions is currently more

CVS commit: src

2021-02-14 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Feb 14 20:16:18 UTC 2021 Modified Files: src/distrib/sets/lists/tests: mi src/usr.bin/make/unit-tests: Makefile varmod-shell.mk Added Files: src/usr.bin/make/unit-tests: varmod-sun-shell.exp varmod-sun-shell.mk

CVS commit: src/sys

2021-02-14 Thread Roy Marples
Module Name:src Committed By: roy Date: Sun Feb 14 19:47:17 UTC 2021 Modified Files: src/sys/net: if_arp.h src/sys/netinet: if_arp.c Log Message: if_arp: Just KASSERT that arphrd is aligned While here improve readability of checking ARP IEEE1394 matches

CVS commit: src/sys/net

2021-02-14 Thread Roy Marples
Module Name:src Committed By: roy Date: Sun Feb 14 19:35:38 UTC 2021 Modified Files: src/sys/net: if_ether.h if_ethersubr.c Log Message: if_ether: revert prior alignment checks Apparently not needed as our drivers ensure this. To generate a diff of this commit: cvs

CVS commit: src/sys/net

2021-02-14 Thread Roy Marples
Module Name:src Committed By: roy Date: Sun Feb 14 19:33:29 UTC 2021 Modified Files: src/sys/net: if_gre.c if_gre.h Log Message: if_gre: Remove alignment checks in favour copying to stack Makes the code a lot simpler, idea from dyoung@ To generate a diff of this

CVS commit: src/usr.bin/make

2021-02-14 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Feb 14 18:59:36 UTC 2021 Modified Files: src/usr.bin/make: var.c Log Message: make: clean up ValidShortVarname The switch statement was hard to read, especially the "break" that needed a comment since it was effectively a

CVS commit: src/usr.bin/make

2021-02-14 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Feb 14 18:55:51 UTC 2021 Modified Files: src/usr.bin/make: var.c Log Message: make: clean up ParseVarnameShort Single-character short variable expressions such as $V neither have a starting character nor an ending character.

CVS commit: src/etc

2021-02-14 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Sun Feb 14 18:45:44 UTC 2021 Modified Files: src/etc: Makefile.params Log Message: Add KERNEL_DIR to /etc/release "Sure, why not" from xtos! To generate a diff of this commit: cvs rdiff -u -r1.21 -r1.22

CVS commit: src/usr.bin/make

2021-02-14 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Feb 14 18:21:31 UTC 2021 Modified Files: src/usr.bin/make: var.c Log Message: make: rename VarExprStatus to ExprStatus It is only used in var.c so there is no need to use a prefix. To generate a diff of this commit: cvs

CVS commit: src/usr.bin/make/unit-tests

2021-02-14 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Feb 14 17:47:33 UTC 2021 Modified Files: src/usr.bin/make/unit-tests: varmod-indirect.mk Log Message: make: add test for indirect ':U' modifier Unlike ':ts' and ':tW', the effects of ':U' are visible even after the modifiers

CVS commit: src/usr.bin/make

2021-02-14 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Feb 14 17:27:25 UTC 2021 Modified Files: src/usr.bin/make: var.c Log Message: make: revert part of previous commit That code was not ready yet. To generate a diff of this commit: cvs rdiff -u -r1.814 -r1.815

CVS commit: src/usr.bin/make

2021-02-14 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Feb 14 17:24:47 UTC 2021 Modified Files: src/usr.bin/make: var.c src/usr.bin/make/unit-tests: varmod-indirect.exp Log Message: make: update line numbers in expected test output The documentation from the previous

CVS commit: src/usr.bin/make/unit-tests

2021-02-14 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Feb 14 17:22:37 UTC 2021 Modified Files: src/usr.bin/make/unit-tests: varmod-indirect.mk Log Message: make: document since when indirect modifiers are supported To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7

CVS commit: src/usr.bin/make/unit-tests

2021-02-14 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Feb 14 16:12:46 UTC 2021 Modified Files: src/usr.bin/make/unit-tests: varmod-indirect.exp varmod-indirect.mk Log Message: make: add more tests for edge cases in evaluating variable expressions As a preparation for

CVS commit: src/sys/dev/pci

2021-02-14 Thread Jonathan A. Kollasch
Module Name:src Committed By: jakllsch Date: Sun Feb 14 14:05:03 UTC 2021 Modified Files: src/sys/dev/pci: if_bnx.c Log Message: if_bnx.c: fix misleading indentation suggested by rillig@ To generate a diff of this commit: cvs rdiff -u -r1.107 -r1.108

CVS commit: src/usr.bin/make

2021-02-14 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Feb 14 13:53:28 UTC 2021 Modified Files: src/usr.bin/make: var.c Log Message: make: add functions for assigning the value of an expression The plan is to have only the "current value" of the expression as a member, not the

CVS commit: src/usr.bin/make

2021-02-14 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Feb 14 13:46:01 UTC 2021 Modified Files: src/usr.bin/make: var.c Log Message: make: rename ApplyModifiersState_Define to Expr_Define The type name ApplyModifiersState was only intended as a working draft, its name is too

CVS commit: src/usr.bin/make

2021-02-14 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Feb 14 12:35:27 UTC 2021 Modified Files: src/usr.bin/make: var.c Log Message: make: condense the code for parsing :S and :C modifiers No functional change. To generate a diff of this commit: cvs rdiff -u -r1.810 -r1.811

CVS commit: src/usr.bin/make

2021-02-14 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Feb 14 12:24:53 UTC 2021 Modified Files: src/usr.bin/make: var.c Log Message: make: rearrange some comments to make them easier to spot To generate a diff of this commit: cvs rdiff -u -r1.809 -r1.810 src/usr.bin/make/var.c

CVS commit: src/usr.bin/make

2021-02-14 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Feb 14 12:16:13 UTC 2021 Modified Files: src/usr.bin/make: var.c Log Message: make: document purpose of stepping back in the parser In ApplyModifier_Assign there was no need to compute the delimiter from st->startc since

CVS commit: src/usr.bin/make/unit-tests

2021-02-14 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Feb 14 12:14:37 UTC 2021 Modified Files: src/usr.bin/make/unit-tests: varmod-assign.mk Log Message: make: add test for ::= modifier enclosed in parentheses To generate a diff of this commit: cvs rdiff -u -r1.9 -r1.10

CVS commit: src/tests/lib/libcurses/tests

2021-02-14 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Feb 14 11:21:37 UTC 2021 Modified Files: src/tests/lib/libcurses/tests: addch Log Message: tests/libcurses: document the history about tab bugs in addch/addstr Verified by installing all versions of libcurses from 2012 to