CVS commit: src/sys/kern

2021-06-12 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Sun Jun 13 03:09:20 UTC 2021 Modified Files: src/sys/kern: subr_hash.c Log Message: need to copyin when reading the hash name from userland To generate a diff of this commit: cvs rdiff -u -r1.9 -r1.10 src/sys/kern/subr_hash.c

CVS commit: src/sys/sys

2021-06-12 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Sun Jun 13 03:07:57 UTC 2021 Modified Files: src/sys/sys: param.h Log Message: bump, something changed and the kernel does not boot with .84 modules. To generate a diff of this commit: cvs rdiff -u -r1.694 -r1.695

CVS commit: src/sys/dev/usb

2021-06-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jun 13 00:13:24 UTC 2021 Modified Files: src/sys/dev/usb: usb_subr.c usbdi.c usbdivar.h Log Message: usb(4): Tighten interface locking and pipe references. - Just use a reference count, not a list of pipes. - Take the

CVS commit: src/sys/dev/usb

2021-06-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jun 13 00:11:57 UTC 2021 Modified Files: src/sys/dev/usb: uhub.c Log Message: uhub(4): Trigger bus exploration after rescanning children. Otherwise, if uhub4 is attached at uhub1, then when we do # drvctl -d

CVS commit: src/sys/kern

2021-06-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jun 13 00:11:46 UTC 2021 Modified Files: src/sys/kern: subr_autoconf.c Log Message: autoconf(9): Sprinkle KASSERT(dev->dv_pending == 0) in dealloc paths. This would have made uhub's config_pending_incr leak more obvious

CVS commit: src/sys/kern

2021-06-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jun 13 00:11:17 UTC 2021 Modified Files: src/sys/kern: subr_autoconf.c Log Message: autoconf(9): Take kernel lock in a few entry points. The arguments to config_attach_pseudo, config_init/fini_component, and

CVS commit: src/sys/dev/usb

2021-06-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Jun 12 15:49:45 UTC 2021 Modified Files: src/sys/dev/usb: usb_subr.c usbdi.c usbdivar.h Log Message: usb(4): Nix unused struct usbd_interface::ui_priv. To generate a diff of this commit: cvs rdiff -u -r1.259 -r1.260

CVS commit: src/sys/dev/usb

2021-06-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Jun 12 15:41:22 UTC 2021 Modified Files: src/sys/dev/usb: usb_subr.c usbdi.c Log Message: usb(4): Make usbd_fill_iface_data atomic. Now either it replaces and frees the old endpoints array, or it leaves everything in

CVS commit: src/sys/dev/usb

2021-06-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Jun 12 15:40:07 UTC 2021 Modified Files: src/sys/dev/usb: usbdi.c Log Message: usb(4): Tweak style in usbd_close_pipe. No functional change intended. To generate a diff of this commit: cvs rdiff -u -r1.212 -r1.213

CVS commit: src/sys/dev/usb

2021-06-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Jun 12 15:39:57 UTC 2021 Modified Files: src/sys/dev/usb: usb_subr.c usbdi.c Log Message: usb(4): Merge logic in usbd_kill_pipe and usbd_close_pipe. usbd_kill_pipe is now just usbd_abort/close_pipe. No functional change

CVS commit: src/sys/dev/usb

2021-06-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Jun 12 15:39:46 UTC 2021 Modified Files: src/sys/dev/usb: usb_subr.c usbdi.c Log Message: usb(4): Fix fix for interface change pipe fix. If there is an interface: - Always put the pipe on the list in usbd_setup_pipe (if

CVS commit: src/sys/dev/usb

2021-06-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Jun 12 15:09:18 UTC 2021 Modified Files: src/sys/dev/usb: usbdi.c Log Message: Revert "usb(4): Fix mistake in previous fix for pipe/interface-change races." Little too fast on the commit trigger there before testing,

CVS commit: src/sys/dev/usb

2021-06-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Jun 12 14:57:53 UTC 2021 Modified Files: src/sys/dev/usb: usbdi.c Log Message: usb(4): Fix mistake in previous fix for pipe/interface-change races. Must block interface changes _before_ we enter usbd_setup_pipe_flags,

CVS commit: src/sys/dev/usb

2021-06-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Jun 12 14:43:27 UTC 2021 Modified Files: src/sys/dev/usb: usb_subr.c usbdi.c usbdivar.h Log Message: usb(4): Fix races between usbd_open_pipe* and usbd_set_interface. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/dev/usb

2021-06-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Jun 12 13:58:06 UTC 2021 Modified Files: src/sys/dev/usb: usb_subr.c usbdi.c usbdivar.h xhci.c Log Message: usb(4): Fix racy endpoint reference counting. Rules: 1. After usbd_setup_pipe*, must usbd_kill_pipe. 2. After

CVS commit: src/sys/dev/usb

2021-06-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Jun 12 13:57:51 UTC 2021 Modified Files: src/sys/dev/usb: usbdi.c Log Message: usb(4): Omit needless lock/unlock cycle in usbd_pipe_close. pipe->up_intrxfer is stable after construction, so no need to hold the lock to

CVS commit: src/sys/dev/usb

2021-06-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Jun 12 13:57:40 UTC 2021 Modified Files: src/sys/dev/usb: usbdi.c Log Message: usb(4): Cancel and wait for async task on closing pipe. XXX usbd_kill_pipe and usbd_close_pipe should not be copypasta; there should be only

CVS commit: src/sys/dev/ic

2021-06-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Jun 12 12:15:54 UTC 2021 Modified Files: src/sys/dev/ic: ath.c Log Message: ath(4): Use config_deactivate; don't abuse autoconf private dv_flags. To generate a diff of this commit: cvs rdiff -u -r1.134 -r1.135

CVS commit: src/sys

2021-06-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Jun 12 12:15:43 UTC 2021 Modified Files: src/sys/dev: ipmi.c src/sys/external/bsd/drm2/i915drm: intelfb.c Log Message: ipmi(4), intelfb(4): Use config_pending_incr/decr. Don't abuse autoconf's private (and

CVS commit: src/sys/kern

2021-06-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Jun 12 12:14:13 UTC 2021 Modified Files: src/sys/kern: subr_autoconf.c Log Message: autoconf(9): Must hold alldevs_lock to iterate dv_list on alldevs. To generate a diff of this commit: cvs rdiff -u -r1.283 -r1.284

CVS commit: src/sys/kern

2021-06-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Jun 12 12:14:03 UTC 2021 Modified Files: src/sys/kern: kern_drvctl.c Log Message: drvctl(4): Hold a deviter while issuing config_detach. Otherwise another concurrent detach -- e.g., from concurrent drvctl or from USB port

CVS commit: src/sys

2021-06-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Jun 12 12:13:51 UTC 2021 Modified Files: src/sys/kern: subr_autoconf.c src/sys/sys: device.h Log Message: autoconf(9): Prevent concurrent attach/detach and detach/detach. - Use config_pending_incr/decr around

CVS commit: src/sys/dev/usb

2021-06-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Jun 12 12:13:23 UTC 2021 Modified Files: src/sys/dev/usb: uhub.c usb_subr.c Log Message: usb(4), uhub(4): Sprinkle usbhist. To generate a diff of this commit: cvs rdiff -u -r1.149 -r1.150 src/sys/dev/usb/uhub.c cvs rdiff

CVS commit: src/sys/dev/usb

2021-06-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Jun 12 12:13:11 UTC 2021 Modified Files: src/sys/dev/usb: uhub.c usb.c usb_subr.c xhci.c Log Message: usb(4): Sprinkle kernel lock assertions. To generate a diff of this commit: cvs rdiff -u -r1.148 -r1.149

CVS commit: src/sys/kern

2021-06-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Jun 12 12:12:11 UTC 2021 Modified Files: src/sys/kern: kern_drvctl.c subr_autoconf.c Log Message: autoconf(9), drvctl(4): Sprinkle kernel lock assertions. To generate a diff of this commit: cvs rdiff -u -r1.46 -r1.47

CVS commit: src/sys/kern

2021-06-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Jun 12 12:11:59 UTC 2021 Modified Files: src/sys/kern: kern_drvctl.c Log Message: drvctl(4): Take the kernel lock around entry into autoconf(9). Can make this finer-grained once the rest of autoconf(9) is in good enough

CVS commit: src/sys/kern

2021-06-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Jun 12 12:11:49 UTC 2021 Modified Files: src/sys/kern: subr_autoconf.c Log Message: autoconf(9): Take kernel lock on various entries into autoconf. Most of autoconf still tacitly assumes the kernel lock is held. To

CVS commit: src/sys/dev/usb

2021-06-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Jun 12 12:11:38 UTC 2021 Modified Files: src/sys/dev/usb: usb.c Log Message: usb(4): usb event thread is not actually MP-safe. Still requires a lot of work in usb(4), uhub(4), and autoconf(9). To generate a diff of this

CVS commit: src/sys/dev/usb

2021-06-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Jun 12 12:11:28 UTC 2021 Modified Files: src/sys/dev/usb: usb_subr.c Log Message: usb(4): Verify dev->ud_subdevs is still there before freeing it. usbd_attachinterfaces may sleep, and if it does, it releases the kernel

CVS commit: src/sys/dev/usb

2021-06-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Jun 12 12:11:11 UTC 2021 Modified Files: src/sys/dev/usb: usb_subr.c Log Message: usb(4): kmem_zalloc(KM_SLEEP) cannot fail; nix error branch. To generate a diff of this commit: cvs rdiff -u -r1.250 -r1.251

CVS commit: src/sys/dev/usb

2021-06-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Jun 12 12:11:01 UTC 2021 Modified Files: src/sys/dev/usb: uhub.c Log Message: uhub(4): Allow only one explore/rescan at a time. Otherwise we might simultaneously attach two autoconf instances of the same device, which