CVS commit: src/sys/netinet

2018-04-12 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Apr 12 07:45:29 UTC 2018 Modified Files: src/sys/netinet: raw_ip.c Log Message: Make 'opts' local to rip_sbappendaddr(). To generate a diff of this commit: cvs rdiff -u -r1.174 -r1.175 src/sys/netinet/raw_ip.c Please note

CVS commit: src/sys/netinet

2018-04-11 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Apr 11 08:29:19 UTC 2018 Modified Files: src/sys/netinet: ip_flow.c Log Message: Remove whitespaces/tabs, and one non-ASCII character. To generate a diff of this commit: cvs rdiff -u -r1.81 -r1.82 src/sys/netinet/ip_flow.c

CVS commit: src/sys/netinet

2018-04-11 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Apr 11 08:11:20 UTC 2018 Modified Files: src/sys/netinet: ip_input.c Log Message: Don't pass IP_ALLOWBROADCAST in ipsec4_input. The flag lands in ipsec_getpolicybyaddr, and only IP_FORWARDING is taken. In fact it would be good

CVS commit: src/sys/netinet

2018-04-11 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Apr 11 07:52:26 UTC 2018 Modified Files: src/sys/netinet: ip_input.c Log Message: Small changes in ip_dooptions: replace bcopy by memcpy, the areas can't overlap. To generate a diff of this commit: cvs rdiff -u -r1.376

CVS commit: src/sys/netinet

2018-04-11 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Apr 11 07:15:12 UTC 2018 Modified Files: src/sys/netinet: ip_reass.c Log Message: Add 'static', like the prototype. To generate a diff of this commit: cvs rdiff -u -r1.14 -r1.15 src/sys/netinet/ip_reass.c Please note that

CVS commit: src/sys/netinet

2018-04-11 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Apr 11 06:26:00 UTC 2018 Modified Files: src/sys/netinet: ip_mroute.c Log Message: Add XXX. To generate a diff of this commit: cvs rdiff -u -r1.156 -r1.157 src/sys/netinet/ip_mroute.c Please note that diffs are not public

CVS commit: src/sys/netinet

2018-04-11 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Apr 11 05:59:43 UTC 2018 Modified Files: src/sys/netinet: ip_mroute.c Log Message: Add XXX. To generate a diff of this commit: cvs rdiff -u -r1.155 -r1.156 src/sys/netinet/ip_mroute.c Please note that diffs are not public

CVS commit: src/sys/netinet

2018-04-10 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Apr 11 05:38:47 UTC 2018 Modified Files: src/sys/netinet: if_arp.c Log Message: Add XXX. To generate a diff of this commit: cvs rdiff -u -r1.272 -r1.273 src/sys/netinet/if_arp.c Please note that diffs are not public domain;

CVS commit: src/sys/netinet

2018-04-10 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Apr 10 08:41:14 UTC 2018 Modified Files: src/sys/netinet: if_arp.c Log Message: Remove unused mbuf argument from arpcreate() and arplookup(). To generate a diff of this commit: cvs rdiff -u -r1.271 -r1.272

CVS commit: src/sys/netinet

2018-04-10 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Apr 10 08:22:35 UTC 2018 Modified Files: src/sys/netinet: igmp.c Log Message: Replace comment by KASSERT. To generate a diff of this commit: cvs rdiff -u -r1.66 -r1.67 src/sys/netinet/igmp.c Please note that diffs are not

CVS commit: src/sys/netinet

2018-04-08 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Sun Apr 8 13:52:22 UTC 2018 Modified Files: src/sys/netinet: in.c Log Message: Protect ip_dad_count with if NARP > 0 to fix compilation To generate a diff of this commit: cvs rdiff -u -r1.227 -r1.228 src/sys/netinet/in.c

CVS commit: src/sys/netinet

2018-04-08 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Apr 8 12:18:06 UTC 2018 Modified Files: src/sys/netinet: ip_var.h tcp_input.c Log Message: Remove the ipre_mlast field and the TRAVERSE macro. The goal was to store in ipre_mlast the last mbuf of the chain, so that m_cat

CVS commit: src/sys/netinet

2018-04-08 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Apr 8 11:50:46 UTC 2018 Modified Files: src/sys/netinet: ip_var.h Log Message: Remove unused field, and sync comment with reality. To generate a diff of this commit: cvs rdiff -u -r1.123 -r1.124 src/sys/netinet/ip_var.h

CVS commit: src/sys/netinet

2018-04-07 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Apr 7 13:48:50 UTC 2018 Modified Files: src/sys/netinet: tcp_fsm.h tcp_usrreq.c Log Message: Remove dead code. To generate a diff of this commit: cvs rdiff -u -r1.15 -r1.16 src/sys/netinet/tcp_fsm.h cvs rdiff -u -r1.217

CVS commit: src/sys/netinet

2018-04-06 Thread Ryota Ozaki
Module Name:src Committed By: ozaki-r Date: Fri Apr 6 16:01:16 UTC 2018 Modified Files: src/sys/netinet: in.c Log Message: Revert the previous two commits as per roy@'s request It broke the ip_dad_count > 0 case unexpectedly. To generate a diff of this commit: cvs

CVS commit: src/sys/netinet

2018-04-06 Thread Ryota Ozaki
Module Name:src Committed By: ozaki-r Date: Fri Apr 6 09:20:29 UTC 2018 Modified Files: src/sys/netinet: in.c Log Message: Don't set IN_IFF_* flags to ia4_flags if DAD is disabled This fix allows that a GARP packet is sent when adding an IP address to an interface with

CVS commit: src/sys/netinet

2018-04-06 Thread Ryota Ozaki
Module Name:src Committed By: ozaki-r Date: Fri Apr 6 09:19:16 UTC 2018 Modified Files: src/sys/netinet: in.c Log Message: Simplify; clear then set flags to ia4_flags (NFCI) To generate a diff of this commit: cvs rdiff -u -r1.223 -r1.224 src/sys/netinet/in.c Please

CVS commit: src/sys/netinet

2018-04-03 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Apr 3 08:46:01 UTC 2018 Modified Files: src/sys/netinet: ip_var.h Log Message: Remove unused fields and outdated comment. To generate a diff of this commit: cvs rdiff -u -r1.122 -r1.123 src/sys/netinet/ip_var.h Please note

CVS commit: src/sys/netinet

2018-04-03 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Apr 3 08:02:34 UTC 2018 Modified Files: src/sys/netinet: tcp_output.c Log Message: bcopy -> memcpy, it's obvious the areas don't overlap. To generate a diff of this commit: cvs rdiff -u -r1.204 -r1.205

CVS commit: src/sys/netinet

2018-04-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Apr 1 12:58:47 UTC 2018 Modified Files: src/sys/netinet: tcp_output.c Log Message: Change the check to be <= instead of <. This fixes one occurrence of an apparently widespread division-by-zero bug in our TCP code: if a user

CVS commit: src/sys/netinet

2018-04-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Apr 1 12:46:50 UTC 2018 Modified Files: src/sys/netinet: tcp_output.c Log Message: Reorder and style, for clarity. To generate a diff of this commit: cvs rdiff -u -r1.202 -r1.203 src/sys/netinet/tcp_output.c Please note

CVS commit: src/sys/netinet

2018-03-30 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Mar 30 08:57:32 UTC 2018 Modified Files: src/sys/netinet: tcp_output.c Log Message: Remove dead code. It was introduced in rev1 (25 years ago), and is irrelevant today. To generate a diff of this commit: cvs rdiff -u -r1.201

CVS commit: src/sys/netinet

2018-03-30 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Mar 30 08:53:51 UTC 2018 Modified Files: src/sys/netinet: tcp_output.c Log Message: Style, use NULL for pointers, use KASSERT, and don't inline huge functions, we want to debug them with DDB (and not just with GPROF). To

CVS commit: src/sys/netinet

2018-03-30 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Mar 30 08:25:06 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Fix the log. mtod never returns NULL, so 'ip' is always non-NULL, and the 'ip6' branch is never taken. As a result we log garbage on IPv6

CVS commit: src/sys/netinet

2018-03-30 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Mar 30 07:11:40 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Use consttime_memequal instead of memcmp, to prevent side channels. This functions returns 1 when the buffers are equal, contrary to memcmp,

CVS commit: src/sys/netinet

2018-03-29 Thread Mindaugas Rasiukevicius
Module Name:src Committed By: rmind Date: Thu Mar 29 21:40:53 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: tcp_urp_drop: fix a bug introduced in 1.390 rev (hi maxv@). To generate a diff of this commit: cvs rdiff -u -r1.400 -r1.401

CVS commit: src/sys/netinet

2018-03-29 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Mar 29 17:46:17 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Reorder/Fix comments to clarify. To generate a diff of this commit: cvs rdiff -u -r1.398 -r1.399 src/sys/netinet/tcp_input.c Please note that

CVS commit: src/sys/netinet

2018-03-29 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Mar 29 17:12:36 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Remove two more 'else' branches. To generate a diff of this commit: cvs rdiff -u -r1.397 -r1.398 src/sys/netinet/tcp_input.c Please note that

CVS commit: src/sys/netinet

2018-03-29 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Mar 29 17:09:00 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Fix memory leak, we may reallocate 'tcp_saveti' after 'findpcb'. It's not a tragic bug, because it happens only on sockets with debug enabled.

CVS commit: src/sys/netinet

2018-03-29 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Mar 29 17:01:46 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Remove 'else', makes it clearer that we leave. To generate a diff of this commit: cvs rdiff -u -r1.395 -r1.396 src/sys/netinet/tcp_input.c

CVS commit: src/sys/netinet

2018-03-29 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Mar 29 16:59:38 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Clarify with KASSERT. To generate a diff of this commit: cvs rdiff -u -r1.394 -r1.395 src/sys/netinet/tcp_input.c Please note that diffs are

CVS commit: src/sys/netinet

2018-03-29 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Mar 29 16:54:59 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Simplify the computation: m->m_pkthdr.len - sizeof(struct tcphdr) - optlen - hlen = m->m_pkthdr.len - (sizeof(struct tcphdr)

CVS commit: src/sys/netinet

2018-03-29 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Mar 29 08:11:41 UTC 2018 Modified Files: src/sys/netinet: tcp_subr.c Log Message: Misc changes; no real functional change. To generate a diff of this commit: cvs rdiff -u -r1.274 -r1.275 src/sys/netinet/tcp_subr.c Please

CVS commit: src/sys/netinet

2018-03-29 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Mar 29 07:46:43 UTC 2018 Modified Files: src/sys/netinet: tcp_congctl.c tcp_debug.c tcp_output.c tcp_sack.c tcp_subr.c tcp_timer.c tcp_usrreq.c Log Message: Remove #ifdef INET. Same as tcp_input.c. Makes the code

CVS commit: src/sys/netinet

2018-03-28 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Mar 28 14:43:55 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Several changes in syn_cache_respond: * Replace idiotic diagnostic check by KASSERT. max_linkhdr+tlen<=MCLBYTES is a widespread assumption.

CVS commit: src/sys/netinet

2018-03-28 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Mar 28 14:30:42 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Remove unused variable. To generate a diff of this commit: cvs rdiff -u -r1.391 -r1.392 src/sys/netinet/tcp_input.c Please note that diffs

CVS commit: src/sys/netinet

2018-03-28 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Mar 28 14:22:16 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c tcp_var.h Log Message: Remove two unused args from syn_cache_get(). To generate a diff of this commit: cvs rdiff -u -r1.390 -r1.391

CVS commit: src/sys/netinet

2018-03-28 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Mar 28 14:16:59 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Dedup: introduce tcp_urp_drop() and use it. To generate a diff of this commit: cvs rdiff -u -r1.389 -r1.390 src/sys/netinet/tcp_input.c

CVS commit: src/sys/netinet

2018-03-28 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Mar 28 13:50:14 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Minor changes: style, improve comments (and put them at the correct place), use NULL for pointers, and add {}s to prevent confusion. To

CVS commit: src/sys/netinet

2018-03-23 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Mar 23 09:30:55 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Remove #ifdef INET. Nobody is doing that in the kernel, and there are even IPv4 places that are not covered here. To generate a diff of this

CVS commit: src/sys/netinet

2018-03-23 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Mar 23 08:57:40 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Improve a bit here and there. Replace bcopy by memcpy/memmove. To generate a diff of this commit: cvs rdiff -u -r1.386 -r1.387

CVS commit: src/sys/netinet

2018-03-22 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Mar 22 21:19:28 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Don't pass a pointer to tcp_reass, otherwise it looks like it can modify tlen while it doesn't. To generate a diff of this commit: cvs rdiff

CVS commit: src/sys/netinet

2018-03-22 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Mar 22 21:10:17 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Rearrange a bit. No real functional change. To generate a diff of this commit: cvs rdiff -u -r1.384 -r1.385 src/sys/netinet/tcp_input.c

CVS commit: src/sys/netinet

2018-03-22 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Mar 22 20:48:38 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Don't call tcp_input_checksum again, it was already called earlier, no need to checksum twice. Then call tcp_fields_to_host a bit earlier, so

CVS commit: src/sys/netinet

2018-03-21 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Mar 21 15:33:25 UTC 2018 Modified Files: src/sys/netinet: ip_carp.c Log Message: Fix an untriggerable memory leak. carp_prepare_ad does not fail, so switch it to void. To generate a diff of this commit: cvs rdiff -u -r1.94

CVS commit: src/sys/netinet

2018-03-10 Thread Pierre Pronchery
Module Name:src Committed By: khorben Date: Sat Mar 10 23:28:13 UTC 2018 Modified Files: src/sys/netinet: tcp_output.c Log Message: Fix spello in a comment To generate a diff of this commit: cvs rdiff -u -r1.198 -r1.199 src/sys/netinet/tcp_output.c Please note that

CVS commit: src/sys/netinet

2018-03-05 Thread Ryota Ozaki
Module Name:src Committed By: ozaki-r Date: Tue Mar 6 07:19:03 UTC 2018 Modified Files: src/sys/netinet: if_arp.c Log Message: Tweak sanity checks Scheduling a timer of static entries is wrong. To generate a diff of this commit: cvs rdiff -u -r1.268 -r1.269

CVS commit: src/sys/netinet

2018-03-01 Thread Roy Marples
Module Name:src Committed By: roy Date: Thu Mar 1 14:40:57 UTC 2018 Modified Files: src/sys/netinet: if_arp.c Log Message: Sprinkle some const. To generate a diff of this commit: cvs rdiff -u -r1.267 -r1.268 src/sys/netinet/if_arp.c Please note that diffs are not

CVS commit: src/sys/netinet

2018-02-28 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Mar 1 06:08:44 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Revert rev1.183 (2003). It was intended as an optimization, but it increases the attack surface: the IPsec policy is not enforced on RST

CVS commit: src/sys/netinet

2018-02-28 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Feb 28 11:10:22 UTC 2018 Modified Files: src/sys/netinet: raw_ip.c Log Message: (just forgot to commit this file, the message was) Remove duplicate IPSEC_STATINC(IPSEC_STAT_IN_POLVIO), ipsec_in_reject already increases it.

CVS commit: src/sys/netinet

2018-02-14 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Wed Feb 14 16:45:24 UTC 2018 Modified Files: src/sys/netinet: raw_ip.c Log Message: join lines where they fit. To generate a diff of this commit: cvs rdiff -u -r1.167 -r1.168 src/sys/netinet/raw_ip.c Please note that diffs

CVS commit: src/sys/netinet

2018-02-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Feb 14 05:24:44 UTC 2018 Modified Files: src/sys/netinet: udp_usrreq.c Log Message: Revert my two last changes in this file. They are apparently causing problems with racoon, I'll investigate this later. To generate a diff of

CVS commit: src/sys/netinet

2018-02-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Feb 13 14:50:28 UTC 2018 Modified Files: src/sys/netinet: if_arp.c Log Message: Mmh. Add a missing check: if ARP was disabled on the interface, don't process ARP packets. Otherwise the kernel will add ARP entries even if

CVS commit: src/sys/netinet

2018-02-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Feb 13 10:47:41 UTC 2018 Modified Files: src/sys/netinet: if_arp.c Log Message: Be tougher: * In arpintr(), don't allow IEEE1394 packets on non-IEEE1394 interfaces. * In revarpinput(), kick IEEE1394 packets right away. They

CVS commit: src/sys/netinet

2018-02-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Feb 13 10:31:01 UTC 2018 Modified Files: src/sys/netinet: if_arp.c Log Message: Same change as rev1.258, but this time in revarpinput: use m_pullup. To generate a diff of this commit: cvs rdiff -u -r1.262 -r1.263

CVS commit: src/sys/netinet

2018-02-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Feb 13 10:20:50 UTC 2018 Modified Files: src/sys/netinet: if_arp.c Log Message: Minor stylistic changes, and use C99 types. To generate a diff of this commit: cvs rdiff -u -r1.261 -r1.262 src/sys/netinet/if_arp.c Please note

CVS commit: src/sys/netinet

2018-02-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Feb 13 10:05:05 UTC 2018 Modified Files: src/sys/netinet: if_arp.c Log Message: Replace dead code by KASSERT. To generate a diff of this commit: cvs rdiff -u -r1.260 -r1.261 src/sys/netinet/if_arp.c Please note that diffs

CVS commit: src/sys/netinet

2018-02-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Feb 13 08:51:38 UTC 2018 Modified Files: src/sys/netinet: if_arp.c Log Message: Don't force ARPHRD_IEEE1394 on IEEE1394 interfaces. If it's not there, then kick the packet. And do this earlier. To generate a diff of this

CVS commit: src/sys/netinet

2018-02-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Feb 13 08:20:12 UTC 2018 Modified Files: src/sys/netinet: if_arp.c Log Message: Use only one label, clearer. To generate a diff of this commit: cvs rdiff -u -r1.258 -r1.259 src/sys/netinet/if_arp.c Please note that diffs are

CVS commit: src/sys/netinet

2018-02-12 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Feb 13 07:51:24 UTC 2018 Modified Files: src/sys/netinet: if_arp.c Log Message: Fix three things in arpintr(): * mtod can't return NULL. * It is wrong to kick the packet if m->m_len < arplen. While this check always

CVS commit: src/sys/netinet

2018-02-12 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Feb 13 07:44:25 UTC 2018 Modified Files: src/sys/netinet: if_arp.c Log Message: Style, no functional change. To generate a diff of this commit: cvs rdiff -u -r1.256 -r1.257 src/sys/netinet/if_arp.c Please note that diffs are

CVS commit: src/sys/netinet

2018-02-12 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Mon Feb 12 18:19:12 UTC 2018 Modified Files: src/sys/netinet: ip_output.c Log Message: Keep a pointer to the interface of the multicast membership, because the multicast element itself might go away in in_delmulti (but the

CVS commit: src/sys/netinet

2018-02-12 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Feb 12 09:31:06 UTC 2018 Modified Files: src/sys/netinet: udp_usrreq.c Log Message: Don't rebase the pointers. 'm' is only allowed to become NULL (which means 'processed'). To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/netinet

2018-02-12 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Feb 12 08:22:27 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c tcp_output.c tcp_var.h Log Message: Remove unused argument from tcp_signature_getsav. To generate a diff of this commit: cvs rdiff -u -r1.378 -r1.379

CVS commit: src/sys/netinet

2018-02-12 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Feb 12 08:13:08 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Add a KASSERT. To generate a diff of this commit: cvs rdiff -u -r1.377 -r1.378 src/sys/netinet/tcp_input.c Please note that diffs are not

CVS commit: src/sys/netinet

2018-02-12 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Feb 12 08:08:28 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c tcp_var.h Log Message: Remove the 'm' argument from syn_cache_respond(); all it does with it is freeing it, so free in the caller instead. To generate a

CVS commit: src/sys/netinet

2018-02-12 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Feb 12 08:03:42 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Remove this multicast check. Multicast packets are already dropped at the beginning of the function. To generate a diff of this commit: cvs

CVS commit: src/sys/netinet

2018-02-10 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 10 08:17:00 UTC 2018 Modified Files: src/sys/netinet: udp_usrreq.c Log Message: If the socket wants a ESP-over-UDP packet, and the packet is incorrect, stop processing it instead of giving it to udp4_sendup. It just doesn't

CVS commit: src/sys/netinet

2018-02-09 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Feb 9 14:06:18 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Style, and move the 'ip_srcroute' call after 'tcp_dooptions', otherwise we're leaking 'ipopts'. (Harmless, since TCP_SIGNATURE is disabled.)

CVS commit: src/sys/netinet

2018-02-09 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Feb 9 08:03:33 UTC 2018 Modified Files: src/sys/netinet: ip_mroute.c Log Message: Style (realign everything correctly), and fix a typo. To generate a diff of this commit: cvs rdiff -u -r1.153 -r1.154

CVS commit: src/sys/netinet

2018-02-08 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Feb 8 20:50:00 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Style, rename a variable, and remove an unreachable case. To generate a diff of this commit: cvs rdiff -u -r1.373 -r1.374

CVS commit: src/sys/netinet

2018-02-08 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Feb 8 20:41:36 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Move the IPv4 multicast check earlier; we want to kick multicast packets all the time, and not just when they are SYNs. The IPv6 multicast

CVS commit: src/sys/netinet

2018-02-08 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Feb 8 20:19:30 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Remove the unused 'multicast' argument from tcp_vtw_input, and remove the now-unused multicast detection code. It couldn't have been correct on

CVS commit: src/sys/netinet

2018-02-08 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Feb 8 20:10:56 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Remove the default case, the beginning of the function already ensures af == AF_INET || af == AF_INET6. To generate a diff of this commit: cvs

CVS commit: src/sys/netinet

2018-02-08 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Feb 8 20:06:21 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Dedup code. To generate a diff of this commit: cvs rdiff -u -r1.369 -r1.370 src/sys/netinet/tcp_input.c Please note that diffs are not public

CVS commit: src/sys/netinet

2018-02-08 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Feb 8 19:38:21 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Style, and remove outdated comments. To generate a diff of this commit: cvs rdiff -u -r1.367 -r1.368 src/sys/netinet/tcp_input.c Please note

CVS commit: src/sys/netinet

2018-02-08 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Feb 8 19:25:48 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Remove this check, it is already done at the beginning of the function. To generate a diff of this commit: cvs rdiff -u -r1.366 -r1.367

CVS commit: src/sys/netinet

2018-02-08 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Feb 8 18:59:00 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Reduce the indentation level of this huge block (without realigning yet, for proofreadability). No functional change. To generate a diff of

CVS commit: src/sys/netinet

2018-02-08 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Feb 8 18:55:11 UTC 2018 Modified Files: src/sys/netinet: tcp_input.c Log Message: Move the SO_DEBUG block earlier, to reduce the indentation level. To generate a diff of this commit: cvs rdiff -u -r1.364 -r1.365

CVS commit: src/sys/netinet

2018-02-08 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Feb 8 10:42:12 UTC 2018 Modified Files: src/sys/netinet: ip_icmp.h Log Message: Use C99 types - in particular, stop using n_time and n_short -, style, and remove prototype of icmp_sysctl (does not exist). No functional change.

CVS commit: src/sys/netinet

2018-02-08 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Feb 8 10:30:30 UTC 2018 Modified Files: src/sys/netinet: udp_var.h Log Message: Style, and remove prototype of udp_sysctl (does not exist). To generate a diff of this commit: cvs rdiff -u -r1.42 -r1.43

CVS commit: src/sys/netinet

2018-02-08 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Feb 8 10:24:46 UTC 2018 Modified Files: src/sys/netinet: udp_usrreq.c Log Message: More style, no functional change. To generate a diff of this commit: cvs rdiff -u -r1.238 -r1.239 src/sys/netinet/udp_usrreq.c Please note

CVS commit: src/sys/netinet

2018-02-08 Thread Ryota Ozaki
Module Name:src Committed By: ozaki-r Date: Thu Feb 8 10:11:38 UTC 2018 Modified Files: src/sys/netinet: in.c Log Message: Don't call lltable_purge_entries from in_if_down if ARP isn't enabled Reported by bouyer@ To generate a diff of this commit: cvs rdiff -u -r1.216

CVS commit: src/sys/netinet

2018-02-08 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Feb 8 10:03:52 UTC 2018 Modified Files: src/sys/netinet: ip_reass.c Log Message: Change the error stat from IP_STAT_BADFRAGS to IP_STAT_TOOLONG. The ping_of_death ATF test expects this counter to get increased. To generate a

CVS commit: src/sys/netinet

2018-02-08 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Feb 8 09:32:02 UTC 2018 Modified Files: src/sys/netinet: ip_icmp.c Log Message: Fix a possible buffer overflow in the IPv4 _ctlinput functions. In _icmp_input we are guaranteeing that the ICMP_ADVLENMIN-byte area starting

CVS commit: src/sys/netinet

2018-02-07 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Feb 8 07:11:20 UTC 2018 Modified Files: src/sys/netinet: udp_usrreq.c Log Message: Style, and remove printfs. To generate a diff of this commit: cvs rdiff -u -r1.237 -r1.238 src/sys/netinet/udp_usrreq.c Please note that

CVS commit: src/sys/netinet

2018-02-07 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Feb 8 06:50:38 UTC 2018 Modified Files: src/sys/netinet: udp_usrreq.c Log Message: Fix three pretty bad mistakes in NAT-T: * If we got a keepalive packet, we need to call m_freem, not m_free. Here the next mbufs in the

CVS commit: src/sys/netinet

2018-02-07 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Feb 7 13:22:42 UTC 2018 Modified Files: src/sys/netinet: ip_mroute.c Log Message: Style and constify. To generate a diff of this commit: cvs rdiff -u -r1.152 -r1.153 src/sys/netinet/ip_mroute.c Please note that diffs are

CVS commit: src/sys/netinet

2018-02-07 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Feb 7 12:15:32 UTC 2018 Modified Files: src/sys/netinet: ip_mroute.c Log Message: More style. No functional change. To generate a diff of this commit: cvs rdiff -u -r1.151 -r1.152 src/sys/netinet/ip_mroute.c Please note

CVS commit: src/sys/netinet

2018-02-07 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Feb 7 12:09:55 UTC 2018 Modified Files: src/sys/netinet: ip_mroute.c Log Message: Remove parentheses in return statements. No functional change. To generate a diff of this commit: cvs rdiff -u -r1.150 -r1.151

CVS commit: src/sys/netinet

2018-02-07 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Feb 7 12:04:50 UTC 2018 Modified Files: src/sys/netinet: ip_mroute.c Log Message: Style and remove unused macros. More to come. To generate a diff of this commit: cvs rdiff -u -r1.149 -r1.150 src/sys/netinet/ip_mroute.c

CVS commit: src/sys/netinet

2018-02-07 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Feb 7 11:42:58 UTC 2018 Modified Files: src/sys/netinet: igmp.c ip_mroute.c ip_mroute.h Log Message: Remove RSVP_ISI, that's mostly dead code. FreeBSD and OpenBSD too removed it; FreeBSD kept some pieces but they are mostly

CVS commit: src/sys/netinet

2018-02-07 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Feb 7 08:12:25 UTC 2018 Modified Files: src/sys/netinet: ip_input.c Log Message: Remove null check on ip, it can't be null. (Confuses code scanners.) To generate a diff of this commit: cvs rdiff -u -r1.373 -r1.374

CVS commit: src/sys/netinet

2018-02-06 Thread matthew green
Module Name:src Committed By: mrg Date: Wed Feb 7 06:21:23 UTC 2018 Modified Files: src/sys/netinet: ip_output.c Log Message: ip_add_membership() has an missing {} issue, but solve it by dropping the "goto out" that would have happened immediately next anyway, ie, should

CVS commit: src/sys/netinet

2018-02-06 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Feb 6 17:08:19 UTC 2018 Modified Files: src/sys/netinet: ip_output.c Log Message: Several changes, mostly cosmetic: * Add a KASSERT in ip_output(), we expect (at least) the IP header to be here. * In ip_fragment(),

CVS commit: src/sys/netinet

2018-02-06 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Feb 6 15:48:02 UTC 2018 Modified Files: src/sys/netinet: ip_reass.c Log Message: Add one more check in ip_reass_packet(): make sure that the end of each fragment does not exceed IP_MAXPACKET. In ip_reass(), we only check the

CVS commit: src/sys/netinet

2018-02-05 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Feb 6 06:36:40 UTC 2018 Modified Files: src/sys/netinet: ip_input.c Log Message: Typos and style a bit, no functional change. To generate a diff of this commit: cvs rdiff -u -r1.372 -r1.373 src/sys/netinet/ip_input.c Please

CVS commit: src/sys/netinet

2018-02-05 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Feb 5 15:23:14 UTC 2018 Modified Files: src/sys/netinet: ip_input.c Log Message: Exterminate IPSENDREDIRECTS and IPMTUDISCTIMEOUT, neither is documented. To generate a diff of this commit: cvs rdiff -u -r1.371 -r1.372

CVS commit: src/sys/netinet

2018-02-05 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Feb 5 14:52:42 UTC 2018 Modified Files: src/sys/netinet: ip_input.c Log Message: Clean up this mess. This is typically the kind of places where we need to seriously cut the bullshit. These things are unreadable, undocumented,

CVS commit: src/sys/netinet

2018-02-05 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Feb 5 14:23:38 UTC 2018 Modified Files: src/sys/netinet: ip_input.c Log Message: Be tougher, and don't allow LSRR+SSRR (RFC7126). To generate a diff of this commit: cvs rdiff -u -r1.368 -r1.369 src/sys/netinet/ip_input.c

<    1   2   3   4   5   6   7   >