CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 12:08:53 UTC 2020 Modified Files: src/usr.bin/make: lst.c lst.h parse.c var.c src/usr.bin/make/unit-tests: include-sub.mk Log Message: make(1): rename type Vector to PtrVector This allows the name Vector to be

CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 15:49:03 UTC 2020 Modified Files: src/usr.bin/make: for.c src/usr.bin/make/unit-tests: directive-for.exp directive-for.mk Log Message: make(1): test funny character in .for variable names To generate a diff

CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 17:58:53 UTC 2020 Modified Files: src/usr.bin/make: hash.c Log Message: make(1): clean up RebuildTable for hash tables The previous code used ++ and -- a lot, it also reused variables a lot for different purposes.

CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 18:12:35 UTC 2020 Modified Files: src/usr.bin/make: hash.c Log Message: make(1): refactor Hash_DeleteTable To generate a diff of this commit: cvs rdiff -u -r1.50 -r1.51 src/usr.bin/make/hash.c Please note that diffs

CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 13:51:56 UTC 2020 Modified Files: src/usr.bin/make: for.c Log Message: make(1): extract SubstVarShort from ForIterate To generate a diff of this commit: cvs rdiff -u -r1.97 -r1.98 src/usr.bin/make/for.c Please note

CVS commit: src/usr.bin/make/unit-tests

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 14:55:23 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: directive-for.exp directive-for.mk Log Message: make(1): add test for escaping parentheses and braces in .for loops To generate a diff of this commit:

CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 15:15:45 UTC 2020 Modified Files: src/usr.bin/make: for.c Log Message: make(1): remove unnecessary type ForVar Now that the escaping information is computed just-in-time, the item of a .for loops is a simple string

CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 13:20:11 UTC 2020 Modified Files: src/usr.bin/make: for.c Log Message: make(1): use Vector instead of strlist_t for expanding .for loops strlist_t combines a string with an unsigned int. This unsigned int had been

CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 16:14:08 UTC 2020 Modified Files: src/usr.bin/make: for.c Log Message: make(1): extract code to see if a directive is a .for or .endfor To generate a diff of this commit: cvs rdiff -u -r1.105 -r1.106

CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 16:15:48 UTC 2020 Modified Files: src/usr.bin/make: for.c src/usr.bin/make/unit-tests: forloop.exp Log Message: make(1): use complete words in error message for .for loop To generate a diff of this commit:

CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 13:06:12 UTC 2020 Modified Files: src/usr.bin/make: lst.c lst.h parse.c var.c Log Message: make(1): replace PtrVector with Vector, which can contain any type To generate a diff of this commit: cvs rdiff -u -r1.89

CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 13:25:19 UTC 2020 Modified Files: src/usr.bin/make: Makefile Makefile.boot Removed Files: src/usr.bin/make: strlist.c strlist.h Log Message: make(1): remove unused strlist_t To generate a diff of this commit:

CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 14:29:13 UTC 2020 Modified Files: src/usr.bin/make: for.c Log Message: make(1): extract GetEscapes from For_Eval To generate a diff of this commit: cvs rdiff -u -r1.98 -r1.99 src/usr.bin/make/for.c Please note that

CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 15:58:04 UTC 2020 Modified Files: src/usr.bin/make: for.c Log Message: make(1): rename local variable in For_Eval To generate a diff of this commit: cvs rdiff -u -r1.104 -r1.105 src/usr.bin/make/for.c Please note

CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 17:12:51 UTC 2020 Modified Files: src/usr.bin/make: suff.c Log Message: make(1): add more details to DEBUG_SRC log To generate a diff of this commit: cvs rdiff -u -r1.223 -r1.224 src/usr.bin/make/suff.c Please note

CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 12:01:33 UTC 2020 Modified Files: src/usr.bin/make: for.c Log Message: make(1): clean up code for handling .for loops To generate a diff of this commit: cvs rdiff -u -r1.94 -r1.95 src/usr.bin/make/for.c Please note

CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 13:31:16 UTC 2020 Modified Files: src/usr.bin/make: lst.h Log Message: make(1): remove obsolete comment from lst.h To generate a diff of this commit: cvs rdiff -u -r1.82 -r1.83 src/usr.bin/make/lst.h Please note

CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 15:26:19 UTC 2020 Modified Files: src/usr.bin/make: for.c Log Message: make(1): use Words instead of Vector for the .for items This makes memory management a bit simpler and also more efficient. To generate a diff

CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 16:18:02 UTC 2020 Modified Files: src/usr.bin/make: for.c Log Message: make(1): clean up comments in .for handling To generate a diff of this commit: cvs rdiff -u -r1.107 -r1.108 src/usr.bin/make/for.c Please note

CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 17:01:05 UTC 2020 Modified Files: src/usr.bin/make: hash.c hash.h var.c Log Message: make(1): reduce amount of string hashing In pkgsrc, running "bmake show-all" in pkgtools/pkglint called the hash function 249130

CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 18:03:59 UTC 2020 Modified Files: src/usr.bin/make: hash.c Log Message: make(1): refactor Hash_InitTable First prepare all the data, then initialize the fields in declaration order. To generate a diff of this

CVS commit: src/usr.bin/make

2020-10-26 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Oct 26 23:19:17 UTC 2020 Modified Files: src/usr.bin/make: job.c Log Message: make(1): use proper enum constants for aborting, instead of 0 To generate a diff of this commit: cvs rdiff -u -r1.291 -r1.292

CVS commit: src/usr.bin/make

2020-10-26 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Oct 26 20:14:27 UTC 2020 Modified Files: src/usr.bin/make: suff.c Log Message: make(1): convert a few strings to const strings in suff.c To generate a diff of this commit: cvs rdiff -u -r1.226 -r1.227

CVS commit: src/usr.bin/make

2020-10-26 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Oct 26 20:11:03 UTC 2020 Modified Files: src/usr.bin/make: job.c Log Message: make(1): fix comments in job.c To generate a diff of this commit: cvs rdiff -u -r1.288 -r1.289 src/usr.bin/make/job.c Please note that diffs are

CVS commit: src/usr.bin/make

2020-10-26 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Oct 26 21:34:10 UTC 2020 Modified Files: src/usr.bin/make: compat.c cond.c job.c job.h main.c make.c make.h parse.c targ.c var.c Log Message: make(1): group the command line options and arguments By having a

CVS commit: src/usr.bin/make

2020-10-26 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Oct 26 22:51:56 UTC 2020 Modified Files: src/usr.bin/make: job.c Log Message: make(1): remove unnecessary double negation in Job_ParseShell To generate a diff of this commit: cvs rdiff -u -r1.290 -r1.291

CVS commit: src/usr.bin/make

2020-10-26 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Oct 26 23:28:53 UTC 2020 Modified Files: src/usr.bin/make: dir.c job.c main.c Log Message: make(1): remove "Results: none" from the documentation of void functions To generate a diff of this commit: cvs rdiff -u -r1.189

CVS commit: src/usr.bin/make

2020-10-27 Thread Roland Illig
Module Name:src Committed By: rillig Date: Wed Oct 28 00:38:38 UTC 2020 Modified Files: src/usr.bin/make: parse.c Log Message: make(1): clean up API comment in parse.c To generate a diff of this commit: cvs rdiff -u -r1.401 -r1.402 src/usr.bin/make/parse.c Please note

CVS commit: src/usr.bin/make

2020-10-27 Thread Roland Illig
Module Name:src Committed By: rillig Date: Wed Oct 28 01:58:37 UTC 2020 Modified Files: src/usr.bin/make: parse.c Log Message: make(1): rename predecessor to order_pred The new name aligns nicely with the GNode field of the same name. To generate a diff of this commit:

CVS commit: src/usr.bin/make

2020-10-27 Thread Roland Illig
Module Name:src Committed By: rillig Date: Wed Oct 28 00:44:39 UTC 2020 Modified Files: src/usr.bin/make: parse.c Log Message: make(1): rename some fields of struct IFile The initial "P_" of these field names didn't match anything else. The documentation was missing the

CVS commit: src/usr.bin/make

2020-10-27 Thread Roland Illig
Module Name:src Committed By: rillig Date: Wed Oct 28 01:47:11 UTC 2020 Modified Files: src/usr.bin/make: parse.c Log Message: make(1): remove unused, undocumented .NOEXPORT To generate a diff of this commit: cvs rdiff -u -r1.404 -r1.405 src/usr.bin/make/parse.c Please

CVS commit: src/usr.bin/make

2020-10-27 Thread Roland Illig
Module Name:src Committed By: rillig Date: Wed Oct 28 01:51:36 UTC 2020 Modified Files: src/usr.bin/make: parse.c Log Message: make(1): sort ParseSpecial alphabetically To generate a diff of this commit: cvs rdiff -u -r1.405 -r1.406 src/usr.bin/make/parse.c Please note

CVS commit: src/usr.bin/make

2020-10-27 Thread Roland Illig
Module Name:src Committed By: rillig Date: Wed Oct 28 03:12:54 UTC 2020 Modified Files: src/usr.bin/make: parse.c Log Message: make(1): merge curFile into includes This makes GetActuallyIncludingFile simpler since it no longer needs the special case for curFile. The

CVS commit: src/usr.bin/make

2020-10-27 Thread Roland Illig
Module Name:src Committed By: rillig Date: Wed Oct 28 01:43:01 UTC 2020 Modified Files: src/usr.bin/make: parse.c Log Message: make(1): rename ParseSpecial enum values consistently The previous naming scheme was inconsistent in that dotError started with a lowercase

CVS commit: src/usr.bin/make

2020-10-27 Thread Roland Illig
Module Name:src Committed By: rillig Date: Wed Oct 28 02:43:16 UTC 2020 Modified Files: src/usr.bin/make: lst.c lst.h Log Message: make(1): inline Vector_Get It is simple enough that it neither bloats the code nor warrants the extra function call. To generate a diff of

CVS commit: src/usr.bin/make

2020-10-27 Thread Roland Illig
Module Name:src Committed By: rillig Date: Wed Oct 28 03:21:25 UTC 2020 Modified Files: src/usr.bin/make: main.c make.h parse.c Log Message: make(1): rename defIncPath to defSysIncPath There are two variables, parseIncPath and sysIncPath, which made the name defIncPath

CVS commit: src/usr.bin/make

2020-10-27 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Oct 27 17:36:17 UTC 2020 Modified Files: src/usr.bin/make: main.c Log Message: make(1): extract InitVarMake from main To generate a diff of this commit: cvs rdiff -u -r1.404 -r1.405 src/usr.bin/make/main.c Please note that

CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 20:09:28 UTC 2020 Modified Files: src/usr.bin/make: job.c Log Message: make(1): inline error message This saves a variable, and since bmake needs to adhere to C90, this variable declaration prevents refactoring the

CVS commit: src/usr.bin/make

2020-10-26 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Oct 26 07:03:47 UTC 2020 Modified Files: src/usr.bin/make: for.c Log Message: make(1): use consistent variable names in for.c To generate a diff of this commit: cvs rdiff -u -r1.108 -r1.109 src/usr.bin/make/for.c Please

CVS commit: src/usr.bin/make

2020-10-26 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Oct 26 07:33:48 UTC 2020 Modified Files: src/usr.bin/make: for.c Log Message: make(1): clean up variable substitution in .for loops The variable name cmd_cp was not really helpful for understanding the code. To generate a

CVS commit: src/usr.bin/make

2020-10-26 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Oct 26 07:37:52 UTC 2020 Modified Files: src/usr.bin/make: for.c Log Message: make(1): remove stray closing brace from comment To generate a diff of this commit: cvs rdiff -u -r1.110 -r1.111 src/usr.bin/make/for.c Please

CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 19:19:07 UTC 2020 Modified Files: src/usr.bin/make: arch.c dir.c hash.c hash.h main.c targ.c var.c Log Message: make(1): rename hash functions to identify the type name This makes it easier to spot mismatches between

CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 20:34:05 UTC 2020 Modified Files: src/usr.bin/make: job.c Log Message: make(1): inline macro STATIC It was a leftover from the remote code, which was removed on 2006-03-11. To generate a diff of this commit: cvs

CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 21:51:49 UTC 2020 Modified Files: src/usr.bin/make: dir.c job.c make.c make.h meta.c suff.c targ.c var.c Log Message: make(1): add GNode_Path to access the path of a GNode To generate a diff of this commit: cvs rdiff

CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 19:57:43 UTC 2020 Modified Files: src/usr.bin/make: job.c Log Message: make(1): clean up API comment in job.c To generate a diff of this commit: cvs rdiff -u -r1.277 -r1.278 src/usr.bin/make/job.c Please note that

CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 22:13:53 UTC 2020 Modified Files: src/usr.bin/make: suff.c src/usr.bin/make/unit-tests: suff-lookup.exp Log Message: make(1): properly terminate debug output with newline Without this, NetBSD's sed adds the

CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 20:15:56 UTC 2020 Modified Files: src/usr.bin/make: job.c Log Message: make(1): reduce indentation in Job_CheckCommands To generate a diff of this commit: cvs rdiff -u -r1.280 -r1.281 src/usr.bin/make/job.c Please

CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 20:14:09 UTC 2020 Modified Files: src/usr.bin/make: job.c Log Message: make(1): split and invert complex condition in Job_CheckCommands To generate a diff of this commit: cvs rdiff -u -r1.279 -r1.280

CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 22:05:00 UTC 2020 Modified Files: src/usr.bin/make: job.c Log Message: make(1): fix typos in job.c comments To generate a diff of this commit: cvs rdiff -u -r1.287 -r1.288 src/usr.bin/make/job.c Please note that

CVS commit: src/usr.bin/make/unit-tests

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 22:04:24 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: sh-dots.exp sh-dots.mk Log Message: make(1): add tests for generating the ... command indirectly To generate a diff of this commit: cvs rdiff -u -r1.3

CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 19:28:44 UTC 2020 Modified Files: src/usr.bin/make: hash.c Log Message: make(1): print hash in debug log with fixed width This way all the keys are nicely aligned in the debug log. To generate a diff of this commit:

CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 20:29:51 UTC 2020 Modified Files: src/usr.bin/make: job.c Log Message: make(1): convert result of JobStart from macros to enum Right now the result is not used by any code. To generate a diff of this commit: cvs

CVS commit: src/usr.bin/make/unit-tests

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 21:31:00 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: deptgt-delete_on_error.exp deptgt-delete_on_error.mk Log Message: make(1): add test for deleting targets using .DELETE_ON_ERROR To generate a

CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 20:19:06 UTC 2020 Modified Files: src/usr.bin/make: job.c Log Message: make(1): invert condition in Job_CheckCommands, reduce indentation To generate a diff of this commit: cvs rdiff -u -r1.281 -r1.282

CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 19:11:31 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): reduce duplicate code in VarFind To generate a diff of this commit: cvs rdiff -u -r1.586 -r1.587 src/usr.bin/make/var.c Please note

CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 20:24:25 UTC 2020 Modified Files: src/usr.bin/make: job.c Log Message: make(1): convert abort reason macros to enum To generate a diff of this commit: cvs rdiff -u -r1.282 -r1.283 src/usr.bin/make/job.c Please note

CVS commit: src/usr.bin/make

2020-10-25 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Oct 25 21:34:52 UTC 2020 Modified Files: src/usr.bin/make: job.c Log Message: make(1): refactor JobDeleteTarget Splitting the many conditions into separate pieces makes the code more understandable. To generate a diff of

CVS commit: src/usr.bin/make

2020-10-27 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Oct 27 06:59:20 UTC 2020 Modified Files: src/usr.bin/make: main.c Log Message: make(1): extract UnlimitFiles from main To generate a diff of this commit: cvs rdiff -u -r1.392 -r1.393 src/usr.bin/make/main.c Please note

CVS commit: src/usr.bin/make

2020-10-27 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Oct 27 06:55:19 UTC 2020 Modified Files: src/usr.bin/make: dir.c Log Message: make(1): rewrap and reword the large comment for directory caching Hashing the directories is not a problem at all, it's the caching that makes

CVS commit: src/usr.bin/make

2020-10-27 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Oct 27 07:03:55 UTC 2020 Modified Files: src/usr.bin/make: main.c make.h Log Message: make(1): move debugVflag to CmdOpts To generate a diff of this commit: cvs rdiff -u -r1.393 -r1.394 src/usr.bin/make/main.c cvs rdiff -u

CVS commit: src/usr.bin/make

2020-10-27 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Oct 27 07:13:03 UTC 2020 Modified Files: src/usr.bin/make: main.c Log Message: make(1): extract CmdOpts_Init from main To generate a diff of this commit: cvs rdiff -u -r1.394 -r1.395 src/usr.bin/make/main.c Please note

CVS commit: src/usr.bin/make

2020-10-27 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Oct 27 07:28:34 UTC 2020 Modified Files: src/usr.bin/make: main.c Log Message: make(1): extract InitDefIncPath from main To generate a diff of this commit: cvs rdiff -u -r1.396 -r1.397 src/usr.bin/make/main.c Please note

CVS commit: src/usr.bin/make

2020-10-27 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Oct 27 07:51:43 UTC 2020 Modified Files: src/usr.bin/make: main.c Log Message: make(1): free the variable names given on the command line These are not aliased anywhere. The opts.makefiles on the other hand may be

CVS commit: src/usr.bin/make

2020-10-27 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Oct 27 08:05:20 UTC 2020 Modified Files: src/usr.bin/make: main.c Log Message: make(1): extract ReadMakefiles from main To generate a diff of this commit: cvs rdiff -u -r1.402 -r1.403 src/usr.bin/make/main.c Please note

CVS commit: src/usr.bin/make

2020-10-27 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Oct 27 07:16:27 UTC 2020 Modified Files: src/usr.bin/make: main.c var.c Log Message: make(1): initialize all CmdOpts fiels To generate a diff of this commit: cvs rdiff -u -r1.395 -r1.396 src/usr.bin/make/main.c cvs rdiff -u

CVS commit: src/usr.bin/make

2020-10-27 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Oct 27 07:34:36 UTC 2020 Modified Files: src/usr.bin/make: main.c Log Message: make(1): extract ReadBuiltinRules from main To generate a diff of this commit: cvs rdiff -u -r1.397 -r1.398 src/usr.bin/make/main.c Please note

CVS commit: src/usr.bin/make

2020-10-27 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Oct 27 07:38:08 UTC 2020 Modified Files: src/usr.bin/make: main.c Log Message: make(1): use constant string for Var_Subst The times where Var_Subst needed a modifiable string are long gone. To generate a diff of this

CVS commit: src/usr.bin/make

2020-10-27 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Oct 27 07:44:43 UTC 2020 Modified Files: src/usr.bin/make: main.c Log Message: make(1): extract InitVpath from main To generate a diff of this commit: cvs rdiff -u -r1.399 -r1.400 src/usr.bin/make/main.c Please note that

CVS commit: src/usr.bin/make

2020-10-27 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Oct 27 08:00:20 UTC 2020 Modified Files: src/usr.bin/make: main.c Log Message: make(1): extract CleanUp from main This makes it a bit easier to spot the main task of the main function, which is the runTargets call. To

CVS commit: src/usr.bin/make

2020-10-22 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Oct 23 04:58:33 UTC 2020 Modified Files: src/usr.bin/make: lst.c lst.h make.c Log Message: make(1): remove Lst_ForEachUntilConcurrent The remaining callers of that function don't modify the list structurally and thus can use

CVS commit: src/usr.bin/make

2020-10-22 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Oct 23 05:18:19 UTC 2020 Modified Files: src/usr.bin/make: job.c Log Message: make(1): remove void pointers from JobPrintCommand To generate a diff of this commit: cvs rdiff -u -r1.268 -r1.269 src/usr.bin/make/job.c Please

CVS commit: src/usr.bin/make

2020-10-22 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Oct 23 05:27:33 UTC 2020 Modified Files: src/usr.bin/make: job.c Log Message: make(1): move handling of the "..." command to JobPrintCommands Over there, the current list node is known and thus doesn't need to be searched

CVS commit: src/usr.bin/make/unit-tests

2020-10-22 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Oct 23 05:44:02 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: varname-make_print_var_on_error.exp varname-make_print_var_on_error.mk Log Message: make(1): add test for MAKE_PRINT_VAR_ON_ERROR To generate

CVS commit: src/usr.bin/make

2020-10-24 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Oct 24 20:29:40 UTC 2020 Modified Files: src/usr.bin/make: main.c make.h Log Message: make(1): convert macros for debug flags into enum To generate a diff of this commit: cvs rdiff -u -r1.387 -r1.388 src/usr.bin/make/main.c

CVS commit: src/usr.bin/make

2020-10-24 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Oct 24 20:51:49 UTC 2020 Modified Files: src/usr.bin/make: buf.c make.h str.c var.c Log Message: make(1): remove macros MIN and MAX These macros typically evaluate one of their arguments twice. Until 2020-08-31, they had

CVS commit: src/usr.bin/make/unit-tests

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 07:08:10 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: modts.exp modts.mk Log Message: make(1): demonstrate inconsistent :ts behavior among modifiers To generate a diff of this commit: cvs rdiff -u -r1.2

CVS commit: src/usr.bin/make

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 09:26:19 UTC 2020 Modified Files: src/usr.bin/make: nonints.h str.c var.c Log Message: make(1): move SysV string matching to var.c This kind of string matching is only used in variable modifiers, and only if this

CVS commit: src/usr.bin/make/unit-tests

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 09:13:22 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: modts.exp modts.mk Log Message: make(1): add more tests for :ts modifier To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4

CVS commit: src/usr.bin/make

2020-07-21 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Jul 21 21:13:24 UTC 2020 Modified Files: src/usr.bin/make: make.h var.c Log Message: make(1): clean up various things in var.c To generate a diff of this commit: cvs rdiff -u -r1.110 -r1.111 src/usr.bin/make/make.h cvs

CVS commit: src/usr.bin/make

2020-07-21 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Jul 21 20:08:44 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): remove unnecessary VarSelectWords_t struct To generate a diff of this commit: cvs rdiff -u -r1.289 -r1.290 src/usr.bin/make/var.c

CVS commit: src/usr.bin/make

2020-07-21 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Jul 21 21:32:55 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): only ask for newline if :Q actually needs it This simple change reduces the binary size of var.o by 96 bytes (Clang, x86_64). Given that

CVS commit: src/usr.bin/make

2020-07-21 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Jul 21 20:56:56 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): use consistent and descriptive names for callback functions To generate a diff of this commit: cvs rdiff -u -r1.290 -r1.291

CVS commit: src/usr.bin/make/unit-tests

2020-07-21 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Jul 21 21:34:41 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: modmisc.exp modmisc.mk Log Message: make(1): add test for :Q and .newline To generate a diff of this commit: cvs rdiff -u -r1.23 -r1.24

CVS commit: src/usr.bin/make

2020-07-21 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Jul 21 23:47:50 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): remove parameter from ModifyWordCallback Most modifiers don't need a variable context, and those that do already get all their parameters

CVS commit: src/usr.bin/make

2020-07-21 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Jul 21 23:22:45 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): make implementation of the :C modifier simpler To generate a diff of this commit: cvs rdiff -u -r1.293 -r1.294 src/usr.bin/make/var.c

CVS commit: src/usr.bin/make/unit-tests

2020-07-21 Thread Roland Illig
Module Name:src Committed By: rillig Date: Tue Jul 21 23:19:46 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: modmisc.exp modmisc.mk Log Message: make(1): add test for :S,,sep The empty string does not match anywhere. In other implementations of string

CVS commit: src/usr.bin/make/unit-tests

2020-07-20 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Jul 20 19:03:26 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: modmisc.exp modmisc.mk Log Message: make(1): add test for nested assignments This test demonstrates that in ApplyModifier_Assign, the call to

CVS commit: src/usr.bin/make

2020-07-20 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Jul 20 19:53:40 UTC 2020 Modified Files: src/usr.bin/make: nonints.h var.c src/usr.bin/make/unit-tests: modmisc.exp Log Message: make(1): fix edge cases with $ at the end of the :@ modifier In both parts of the :@

CVS commit: src/usr.bin/make

2020-07-20 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Jul 20 20:56:39 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): clean up implementation of :[...] and other modifiers To generate a diff of this commit: cvs rdiff -u -r1.287 -r1.288

CVS commit: src/usr.bin/make

2020-07-20 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Jul 20 21:33:13 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): extract :ts modifier into separate function To generate a diff of this commit: cvs rdiff -u -r1.288 -r1.289 src/usr.bin/make/var.c

CVS commit: src/usr.bin/make

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 12:26:17 UTC 2020 Modified Files: src/usr.bin/make: arch.c compat.c cond.c for.c job.c main.c make.c meta.c nonints.h parse.c suff.c var.c Log Message: make(1): rename Varf_Flags to VarEvalFlags In var.c

CVS commit: src/usr.bin/make

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 13:21:56 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): rename flags for :S and :C pattern matching Renaming these flags makes it obvious that VarPattern is used in a few places where it

CVS commit: src/usr.bin/make

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 14:05:39 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): replace ApplyModifiersState field with local variable To generate a diff of this commit: cvs rdiff -u -r1.261 -r1.262

CVS commit: src/usr.bin/make

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 16:22:44 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): remove unused parameter from ParseModifierPart To generate a diff of this commit: cvs rdiff -u -r1.265 -r1.266 src/usr.bin/make/var.c

CVS commit: src/usr.bin/make

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 10:28:44 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): clean up code in var.c * use canonical comparison to zero in more cases * omit unnecessary snprintf for string literal concatenation *

CVS commit: src/usr.bin/make

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 15:47:10 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): eliminate macro from VarGetPattern To generate a diff of this commit: cvs rdiff -u -r1.262 -r1.263 src/usr.bin/make/var.c Please note

CVS commit: src/usr.bin/make

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 12:51:06 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): convert VarFind flags to typed enum To generate a diff of this commit: cvs rdiff -u -r1.259 -r1.260 src/usr.bin/make/var.c Please note

CVS commit: src/usr.bin/make

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 10:38:02 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): clean up handling of :? modifier The VarPattern type had nothing to do with parsing conditions. To generate a diff of this commit: cvs

CVS commit: src/usr.bin/make/unit-tests

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 15:16:22 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: modmisc.exp modmisc.mk Log Message: make(1): add test for stray dollar signs in :@ modifier To generate a diff of this commit: cvs rdiff -u -r1.14 -r1.15

CVS commit: src/usr.bin/make

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 16:08:24 UTC 2020 Modified Files: src/usr.bin/make: var.c src/usr.bin/make/unit-tests: varmod-edge.mk Log Message: make(1): rename VarGetPattern to ParseModifierPart To generate a diff of this commit: cvs

<    5   6   7   8   9   10   11   12   13   14   >