CVS commit: src/sys/ufs/chfs

2021-08-10 Thread Andrius Varanavicius
Module Name:src Committed By: andvar Date: Wed Aug 11 05:17:48 UTC 2021 Modified Files: src/sys/ufs/chfs: media.h Log Message: s/enrty/entry/ To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/sys/ufs/chfs/media.h Please note that diffs are not public

CVS commit: src/sys/ufs/lfs

2021-07-25 Thread Nick Hudson
Module Name:src Committed By: skrll Date: Sun Jul 25 06:10:01 UTC 2021 Modified Files: src/sys/ufs/lfs: ulfs_quota1_subr.c Log Message: #include for COHERENCY_UNIT (and KNF) To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 src/sys/ufs/lfs/ulfs_quota1_subr.c

CVS commit: src/sys/ufs/chfs

2021-07-19 Thread Andrius Varanavicius
Module Name:src Committed By: andvar Date: Mon Jul 19 22:24:55 UTC 2021 Modified Files: src/sys/ufs/chfs: chfs_gc.c Log Message: NFC - if/else blocks start with the same mutex_exit, just move it up. To generate a diff of this commit: cvs rdiff -u -r1.10 -r1.11

CVS commit: src/sys/ufs/chfs

2021-07-19 Thread Andrius Varanavicius
Module Name:src Committed By: andvar Date: Mon Jul 19 21:04:39 UTC 2021 Modified Files: src/sys/ufs/chfs: chfs_build.c chfs_write.c Log Message: Release mutexes in few more places on failure path. Reviewed them in chfs code after fixing PR kern/56242. ok riastradh To

CVS commit: src/sys/ufs/chfs

2021-07-16 Thread Andrius Varanavicius
Module Name:src Committed By: andvar Date: Fri Jul 16 21:18:41 UTC 2021 Modified Files: src/sys/ufs/chfs: chfs_gc.c chfs_scan.c Log Message: Fix incorrect function name, some grammar and typos in comments. Remove trailing tab symbol. No functional change intended. To

CVS commit: src/sys/ufs/chfs

2021-07-15 Thread Andrius Varanavicius
Module Name:src Committed By: andvar Date: Thu Jul 15 22:39:06 UTC 2021 Modified Files: src/sys/ufs/chfs: chfs_readinode.c chfs_scan.c Log Message: Make sure that mutex is released before conditional return statements. Fixes PR kern/56242 ok riastradh To generate a

CVS commit: src/sys/ufs/ffs

2021-07-14 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Wed Jul 14 07:24:14 UTC 2021 Modified Files: src/sys/ufs/ffs: ffs_vnops.c Log Message: Hook up ffsext_strategy to fifos. Pointed out by dholland@ To generate a diff of this commit: cvs rdiff -u -r1.134 -r1.135

CVS commit: src/sys/ufs/chfs

2021-07-05 Thread David A. Holland
Module Name:src Committed By: dholland Date: Mon Jul 5 21:43:56 UTC 2021 Modified Files: src/sys/ufs/chfs: chfs_vnops.c Log Message: whitespace To generate a diff of this commit: cvs rdiff -u -r1.43 -r1.44 src/sys/ufs/chfs/chfs_vnops.c Please note that diffs are not

CVS commit: src/sys/ufs/ufs

2020-12-25 Thread Nia Alarie
Module Name:src Committed By: nia Date: Fri Dec 25 10:00:40 UTC 2020 Modified Files: src/sys/ufs/ufs: ufs_quota1.c Log Message: Avoid potentially accessing an array with an index out of range. Reported-by: syzbot+8832f540234b996bc...@syzkaller.appspotmail.com

CVS commit: src/sys/ufs

2020-09-24 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Thu Sep 24 17:20:53 UTC 2020 Modified Files: src/sys/ufs: files.ufs Log Message: lfs: Include lfs_debug.c only if DEBUG is enabled. To generate a diff of this commit: cvs rdiff -u -r1.48 -r1.49 src/sys/ufs/files.ufs Please

CVS commit: src/sys/ufs/lfs

2020-09-06 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Sep 7 02:28:12 UTC 2020 Modified Files: src/sys/ufs/lfs: lfs_accessors.h Log Message: Suppress -Waddress-of-packed-member just for lfs_accessors.h. We can remove -Wno-error=address-of-packed-member from various makefiles

CVS commit: src/sys/ufs

2020-08-20 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Thu Aug 20 20:28:13 UTC 2020 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c src/sys/ufs/ufs: inode.h ufs_vnops.c Log Message: Don't cache id's for vnodes that have ACLs. ok chs@ To generate a diff of this commit: cvs

CVS commit: src/sys/ufs/lfs

2020-08-13 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Thu Aug 13 17:26:43 UTC 2020 Modified Files: src/sys/ufs/lfs: lfs_segment.c Log Message: Skip unlinked inodes. They no longer matter on disk so we don't need to write anything out for them. To generate a diff of this

CVS commit: src/sys/ufs/lfs

2020-08-03 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Aug 4 03:00:47 UTC 2020 Modified Files: src/sys/ufs/lfs: lfs_vfsops.c Log Message: Mark lfs vnodes with VV_LOCKSWORK, same as ffs. To generate a diff of this commit: cvs rdiff -u -r1.378 -r1.379

CVS commit: src/sys/ufs

2020-07-25 Thread Chuck Silvers
Module Name:src Committed By: chs Date: Sun Jul 26 00:21:24 UTC 2020 Modified Files: src/sys/ufs/ffs: ffs_inode.c src/sys/ufs/ufs: ufs_inode.c Log Message: pull in a bit more FreeBSD code to allow specifying truncation of the regular bmap (IO_NORMAL) independently

CVS commit: src/sys/ufs/ffs

2020-07-25 Thread Chuck Silvers
Module Name:src Committed By: chs Date: Sun Jul 26 00:20:14 UTC 2020 Modified Files: src/sys/ufs/ffs: ffs_alloc.c Log Message: skip the assertions about page-locking when allocating to the extattr bmap, since extattrs do not use the page cache. To generate a diff of

CVS commit: src/sys/ufs/ffs

2020-07-05 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Sun Jul 5 20:37:40 UTC 2020 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: simplify the acl setup, and fix reversed mask in the fs_flags code. To generate a diff of this commit: cvs rdiff -u -r1.370 -r1.371

CVS commit: src/sys/ufs/chfs

2020-05-20 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Wed May 20 17:04:58 UTC 2020 Modified Files: src/sys/ufs/chfs: chfs_vnops.c Log Message: fix accessx confusion (thanks hannken@) To generate a diff of this commit: cvs rdiff -u -r1.39 -r1.40 src/sys/ufs/chfs/chfs_vnops.c

CVS commit: src/sys/ufs/ffs

2020-05-20 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Wed May 20 13:16:30 UTC 2020 Modified Files: src/sys/ufs/ffs: ffs_extattr.c Log Message: remove accmode_t typedef (not needed, breaks llvm) from maxv@ To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6

CVS commit: src/sys/ufs

2020-05-18 Thread Juergen Hannken-Illjes
Module Name:src Committed By: hannken Date: Mon May 18 08:28:44 UTC 2020 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c src/sys/ufs/ufs: ufs_vnops.c Log Message: Assert ufs_strategy() always gets used while current thread holds a fstrans lock. To generate a diff

CVS commit: src/sys/ufs/ffs

2020-05-02 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Sat May 2 22:11:16 UTC 2020 Modified Files: src/sys/ufs/ffs: ffs_extattr.c ffs_inode.c Log Message: Remove the unlock/relock hack by using IO_EXT to indicate that we are already holding the lock. To generate a diff of this

CVS commit: src/sys/ufs/ufs

2020-05-01 Thread Juergen Hannken-Illjes
Module Name:src Committed By: hannken Date: Fri May 1 08:43:37 UTC 2020 Modified Files: src/sys/ufs/ufs: ufs_vfsops.c Log Message: There is no difference between a zero-sized and not yet reclaimed directory vnode and a non-existent vnode. Teach ufs_fhtovp() to treat

CVS commit: src/sys/ufs/ffs

2020-04-21 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Tue Apr 21 15:04:13 UTC 2020 Modified Files: src/sys/ufs/ffs: ffs_subr.c Log Message: use %s/__func__ so that the strings can be shared. To generate a diff of this commit: cvs rdiff -u -r1.51 -r1.52 src/sys/ufs/ffs/ffs_subr.c

CVS commit: src/sys/ufs/ffs

2020-04-20 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Mon Apr 20 18:10:10 UTC 2020 Modified Files: src/sys/ufs/ffs: ffs_extattr.c Log Message: - Allow root to set system attributes, samba does this - Fix locking issue, perhaps we should use our own mutex; does not seem worth it

CVS commit: src/sys/ufs/ufs

2020-04-19 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Mon Apr 20 03:57:02 UTC 2020 Modified Files: src/sys/ufs/ufs: ufs_bmap.c Log Message: handle negative small block numbers for extattr To generate a diff of this commit: cvs rdiff -u -r1.52 -r1.53 src/sys/ufs/ufs/ufs_bmap.c

CVS commit: src/sys/ufs/ffs

2020-04-19 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Sun Apr 19 13:59:13 UTC 2020 Modified Files: src/sys/ufs/ffs: ffs_extattr.c Log Message: - add locking - wrap wapbl around truncating, ffs_extwrite does it on its own. To generate a diff of this commit: cvs rdiff -u -r1.1

CVS commit: src/sys/ufs

2020-04-11 Thread Jaromir Dolecek
Module Name:src Committed By: jdolecek Date: Sat Apr 11 17:43:54 UTC 2020 Modified Files: src/sys/ufs: files.ufs src/sys/ufs/ffs: ffs_wapbl.c src/sys/ufs/ufs: ufs_wapbl.h Removed Files: src/sys/ufs/ufs: ufs_wapbl.c Log Message: remove noncompilable

CVS commit: src/sys/ufs/lfs

2020-03-27 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Sat Mar 28 01:08:43 UTC 2020 Modified Files: src/sys/ufs/lfs: lfs.h Log Message: Comment out some of the CTASSERTS for lint until I fix lint. To generate a diff of this commit: cvs rdiff -u -r1.207 -r1.208

CVS commit: src/sys/ufs/lfs

2020-03-21 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Mar 21 06:11:05 UTC 2020 Modified Files: src/sys/ufs/lfs: lfs.h lfs_accessors.h Log Message: Avoid misaligned access to lfs64 on-disk records in memory. lfs64 directory entries are only 32-bit aligned in order to conserve

CVS commit: src/sys/ufs/lfs

2020-03-21 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Mar 21 06:09:34 UTC 2020 Modified Files: src/sys/ufs/lfs: lfs.h Log Message: CTASSERT lfs on-disk structure sizes. To generate a diff of this commit: cvs rdiff -u -r1.205 -r1.206 src/sys/ufs/lfs/lfs.h Please note that

CVS commit: src/sys/ufs/lfs

2020-03-14 Thread Andrew Doran
Module Name:src Committed By: ad Date: Sat Mar 14 15:35:35 UTC 2020 Modified Files: src/sys/ufs/lfs: lfs_bio.c lfs_vfsops.c Log Message: OR into bp->b_cflags; don't overwrite. To generate a diff of this commit: cvs rdiff -u -r1.146 -r1.147 src/sys/ufs/lfs/lfs_bio.c cvs

CVS commit: src/sys/ufs/ext2fs

2020-03-08 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sun Mar 8 17:38:12 UTC 2020 Modified Files: src/sys/ufs/ext2fs: ext2fs_vnops.c Log Message: Perform bit operations on unsigned integer ext2fs_vnops.c:1002:2, signed integer overflow: 510008 * 4294 cannot be represented in type

CVS commit: src/sys/ufs/ufs

2020-03-07 Thread Chuck Silvers
Module Name:src Committed By: chs Date: Sun Mar 8 00:23:59 UTC 2020 Modified Files: src/sys/ufs/ufs: ufs_dirhash.c Log Message: in ufsdirhash_free(), only examine dh->dh_onlist after taking the dirhashlist lock. if we skip the lock then we might see that dh_onlist is

CVS commit: src/sys/ufs/ufs

2020-02-26 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Feb 26 18:00:12 UTC 2020 Modified Files: src/sys/ufs/ufs: ufs_vnops.c Log Message: Zero out the padding in 'd_namlen', to prevent info leaks. Same logic as ufs_makedirentry(). Found by kMSan: the unzeroed bytes of the

CVS commit: src/sys/ufs/lfs

2020-02-23 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Feb 23 15:23:08 UTC 2020 Modified Files: src/sys/ufs/lfs: lfs_subr.c lfs_vnops.c Log Message: Fix missing by removing the evcnts instead. Just wanted to confirm that a race might happen, and indeed it did. These serve

CVS commit: src/sys/ufs/lfs

2020-02-23 Thread Andrew Doran
Module Name:src Committed By: ad Date: Sun Feb 23 15:09:55 UTC 2020 Modified Files: src/sys/ufs/lfs: lfs_subr.c Log Message: Fix !DIAGNOSTIC compile To generate a diff of this commit: cvs rdiff -u -r1.100 -r1.101 src/sys/ufs/lfs/lfs_subr.c Please note that diffs are

CVS commit: src/sys/ufs/lfs

2020-02-23 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Feb 23 08:49:46 UTC 2020 Modified Files: src/sys/ufs/lfs: lfs_alloc.c lfs_extern.h lfs_vfsops.c Log Message: Dust off the orphan detection code and try to make it work. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/ufs/lfs

2020-02-23 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Feb 23 08:49:34 UTC 2020 Modified Files: src/sys/ufs/lfs: lfs.h lfs_alloc.c Log Message: Teach LFS_ORPHAN_NEXTFREE about lfs64. To generate a diff of this commit: cvs rdiff -u -r1.204 -r1.205 src/sys/ufs/lfs/lfs.h cvs

CVS commit: src/sys/ufs/lfs

2020-02-23 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Feb 23 08:42:53 UTC 2020 Modified Files: src/sys/ufs/lfs: lfs_extern.h lfs_subr.c Log Message: lfs_writer_enter can't fail; keep it simple and don't pretend it can. Assert that mtsleep can't fail either -- it doesn't

CVS commit: src/sys/ufs/lfs

2020-02-23 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Feb 23 08:41:08 UTC 2020 Modified Files: src/sys/ufs/lfs: lfs_rename.c Log Message: Call lfs_orphan in lfs_rename while we're still in the dirop. To generate a diff of this commit: cvs rdiff -u -r1.22 -r1.23

CVS commit: src/sys/ufs/lfs

2020-02-23 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Feb 23 08:40:59 UTC 2020 Modified Files: src/sys/ufs/lfs: lfs_inode.c Log Message: In lfs_update, hold lfs_writer around lfs_vflush. Otherwise, we might do lfs_vflush -> lfs_seglock -> lfs_segwait(SEGM_CKP) ->

CVS commit: src/sys/ufs/lfs

2020-02-23 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Feb 23 08:40:49 UTC 2020 Modified Files: src/sys/ufs/lfs: lfs_vfsops.c Log Message: Initialize/destroy lfs_allclean_wakeup in modcmd, not lfs_mountfs. Fixes reloading lfs.kmod. To generate a diff of this commit: cvs

CVS commit: src/sys/ufs/lfs

2020-02-23 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Feb 23 08:40:08 UTC 2020 Modified Files: src/sys/ufs/lfs: lfs_segment.c lfs_vnops.c Log Message: Change some cheap KDASSERT into KASSERT. To generate a diff of this commit: cvs rdiff -u -r1.283 -r1.284

CVS commit: src/sys/ufs/lfs

2020-02-23 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Feb 23 08:40:19 UTC 2020 Modified Files: src/sys/ufs/lfs: lfs_vnops.c Log Message: Take a reference and fix assertions in lfs_flush_dirops. Fixes panic: KASSERT((ip->i_state & IN_ADIROP) == 0) at lfs_vnops.c:1670

CVS commit: src/sys/ufs/lfs

2020-02-23 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Feb 23 08:40:28 UTC 2020 Modified Files: src/sys/ufs/lfs: lfs_pages.c Log Message: Don't lfs_writer_enter while holding v_interlock. There's no need to lfs_writer_enter at all here, as far as I can see. lfs_flush_fs will

CVS commit: src/sys/ufs/lfs

2020-02-23 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Feb 23 08:40:37 UTC 2020 Modified Files: src/sys/ufs/lfs: lfs_extern.h lfs_segment.c lfs_subr.c Log Message: Break deadlock in PR kern/52301. The lock order is lfs_writer -> lfs_seglock. The problem in 52301 is that

CVS commit: src/sys/ufs/lfs

2020-02-23 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Feb 23 08:39:19 UTC 2020 Modified Files: src/sys/ufs/lfs: lfs_vfsops.c Log Message: Teach lfs to transition ro<->rw. To generate a diff of this commit: cvs rdiff -u -r1.370 -r1.371 src/sys/ufs/lfs/lfs_vfsops.c Please

CVS commit: src/sys/ufs/lfs

2020-02-23 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Feb 23 08:39:48 UTC 2020 Modified Files: src/sys/ufs/lfs: lfs_balloc.c Log Message: Serialize access to the splay tree with lfs_lock. To generate a diff of this commit: cvs rdiff -u -r1.94 -r1.95

CVS commit: src/sys/ufs/lfs

2020-02-23 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Feb 23 08:39:28 UTC 2020 Modified Files: src/sys/ufs/lfs: lfs_bio.c Log Message: Prevent new dirops while we issue lfs_flush_dirops. lfs_flush_dirops assumes (by KASSERT((ip->i_state & IN_ADIROP) == 0)) that vnodes on the

CVS commit: src/sys/ufs/lfs

2020-02-23 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Feb 23 08:39:39 UTC 2020 Modified Files: src/sys/ufs/lfs: lfs_vnops.c Log Message: Assert lfs_writer where I think we can now prove it. To generate a diff of this commit: cvs rdiff -u -r1.326 -r1.327

CVS commit: src/sys/ufs/lfs

2020-02-23 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Feb 23 08:39:09 UTC 2020 Modified Files: src/sys/ufs/lfs: lfs_debug.c Log Message: Just use VOP_BWRITE for lfs_bwrite_log. Hope this doesn't cause trouble with vfs_suspend. To generate a diff of this commit: cvs rdiff

CVS commit: src/sys/ufs/lfs

2020-02-23 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Feb 23 08:38:58 UTC 2020 Modified Files: src/sys/ufs/lfs: lfs_inode.h lfs_subr.c lfs_vnops.c Log Message: Use a marker node to iterate lfs_dchainhd / i_lfs_dchain. I believe elements can be removed while the lock is

CVS commit: src/sys/ufs/lfs

2020-02-22 Thread Andrew Doran
Module Name:src Committed By: ad Date: Sat Feb 22 22:20:47 UTC 2020 Modified Files: src/sys/ufs/lfs: lfs_segment.c Log Message: Make LFS/rump play nice with aiodoned removal. PR kern/55004 (Hundreds of file system tests now fail on real hardware) To generate a diff of

CVS commit: src/sys/ufs/lfs

2020-02-21 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat Feb 22 00:32:09 UTC 2020 Modified Files: src/sys/ufs/lfs: lfs_alloc.c Log Message: Avoid undefined behavior in *_BITMAP_FREE() macros left shift of 1 by 31 places cannot be represented in type 'int' To generate a diff of

CVS commit: src/sys/ufs/ffs

2020-02-18 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Feb 18 17:50:32 UTC 2020 Modified Files: src/sys/ufs/ffs: ffs_alloc.c Log Message: Fix non-DIAGNOSTIC build with UVM_PAGE_TRKOWN. To generate a diff of this commit: cvs rdiff -u -r1.164 -r1.165

CVS commit: src/sys/ufs/lfs

2019-12-20 Thread Andrew Doran
Module Name:src Committed By: ad Date: Fri Dec 20 20:54:48 UTC 2019 Modified Files: src/sys/ufs/lfs: lfs_pages.c Log Message: Fix lfs_putpages() for bsize < nbpg. To generate a diff of this commit: cvs rdiff -u -r1.17 -r1.18 src/sys/ufs/lfs/lfs_pages.c Please note that

CVS commit: src/sys/ufs/lfs

2019-12-08 Thread Andrew Doran
Module Name:src Committed By: ad Date: Sun Dec 8 19:24:26 UTC 2019 Modified Files: src/sys/ufs/lfs: lfs_segment.c Log Message: Avoid thundering herd: cv_broadcast(>b_busy) -> cv_signal(>b_busy) To generate a diff of this commit: cvs rdiff -u -r1.278 -r1.279

CVS commit: src/sys/ufs/ufs

2019-05-05 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Sun May 5 15:07:12 UTC 2019 Modified Files: src/sys/ufs/ufs: dir.h ufs_lookup.c Log Message: Add more comments to explain what we are doing. To generate a diff of this commit: cvs rdiff -u -r1.26 -r1.27 src/sys/ufs/ufs/dir.h

CVS commit: src/sys/ufs/ufs

2019-05-04 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Sun May 5 01:48:53 UTC 2019 Modified Files: src/sys/ufs/ufs: dir.h ufs_lookup.c Log Message: Zero out all the dirent padding not just one byte, to avoid kernel memory disclosure (from

CVS commit: src/sys/ufs/ffs

2019-04-14 Thread Frank Kardel
Module Name:src Committed By: kardel Date: Sun Apr 14 15:55:24 UTC 2019 Modified Files: src/sys/ufs/ffs: ffs_alloc.c Log Message: PR/53990, PR/52380, PR/52102: UFS2 cylinder group inode allocation botch Fix rare allocation botch in ffs_nodealloccg(). Conditions: a)

CVS commit: src/sys/ufs/ufs

2019-02-24 Thread David A. Holland
Module Name:src Committed By: dholland Date: Mon Feb 25 06:00:40 UTC 2019 Modified Files: src/sys/ufs/ufs: ufs_vnops.c Log Message: Revert -r1.244-245 of ufs_vnops.c; they are wrong. Fix the mistake in -r1.243 that made them look like reasonable changes. (this does not

CVS commit: src/sys/ufs/ufs

2019-02-24 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Mon Feb 25 00:51:24 UTC 2019 Modified Files: src/sys/ufs/ufs: ufs_vnops.c Log Message: drop unused To generate a diff of this commit: cvs rdiff -u -r1.244 -r1.245 src/sys/ufs/ufs/ufs_vnops.c Please note that diffs are not

CVS commit: src/sys/ufs/ufs

2019-02-24 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Mon Feb 25 00:11:13 UTC 2019 Modified Files: src/sys/ufs/ufs: ufs_vnops.c Log Message: remove junk assignment. To generate a diff of this commit: cvs rdiff -u -r1.243 -r1.244 src/sys/ufs/ufs/ufs_vnops.c Please note that

CVS commit: src/sys/ufs/ufs

2019-02-24 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sun Feb 24 19:06:40 UTC 2019 Modified Files: src/sys/ufs/ufs: ufs_vnops.c Log Message: Reading a directory may trigger a panic when the buffer is too small. Adjust necessary checks. While here, also check for arithmetic

CVS commit: src/sys/ufs/mfs

2019-02-20 Thread Juergen Hannken-Illjes
Module Name:src Committed By: hannken Date: Wed Feb 20 10:03:56 UTC 2019 Modified Files: src/sys/ufs/mfs: mfs_vnops.c Log Message: Remove superfluous VOP_UNLOCK(), vnode will be unlocked from spec_reclaim(). To generate a diff of this commit: cvs rdiff -u -r1.58 -r1.59

CVS commit: src/sys/ufs/lfs

2019-01-09 Thread Martin Husemann
Module Name:src Committed By: martin Date: Thu Jan 10 06:31:04 UTC 2019 Modified Files: src/sys/ufs/lfs: lfs.h Log Message: Update comment (overlooked in r1.179). >From Jos� Luis Rodr�guez Garc�a in PR kern/53849. To generate a diff of this commit: cvs rdiff -u -r1.203

CVS commit: src/sys/ufs

2018-12-10 Thread Jaromir Dolecek
Module Name:src Committed By: jdolecek Date: Mon Dec 10 20:48:34 UTC 2018 Modified Files: src/sys/ufs/ffs: ffs_alloc.c src/sys/ufs/ufs: ufs_inode.c ufs_readwrite.c ufs_vnops.c ufs_wapbl.h Log Message: put back UFS_WAPBL_JUNLOCK_ASSERT(), the underlying

CVS commit: src/sys/ufs

2018-12-10 Thread Jaromir Dolecek
Module Name:src Committed By: jdolecek Date: Mon Dec 10 19:29:41 UTC 2018 Modified Files: src/sys/ufs/ffs: ffs_alloc.c ffs_inode.c ffs_vfsops.c ffs_wapbl.c src/sys/ufs/ufs: ufs_inode.c ufs_readwrite.c ufs_vnops.c ufs_wapbl.h Log Message: make

CVS commit: src/sys/ufs/lfs

2018-08-11 Thread Zafer Aydogan
Module Name:src Committed By: zafer Date: Sat Aug 11 20:16:21 UTC 2018 Modified Files: src/sys/ufs/lfs: lfs_vnops.c Log Message: In lfs_mkdir fix wrong return path in case of EMLINK which causes a panic. Also, check earlier before setting up dirop. To generate a diff

CVS commit: src/sys/ufs/ffs

2018-07-18 Thread Ryota Ozaki
Module Name:src Committed By: ozaki-r Date: Thu Jul 19 05:09:34 UTC 2018 Modified Files: src/sys/ufs/ffs: ffs_alloc.c Log Message: Avoid using magic numbers for arguments of workqueue_create (NFC) To generate a diff of this commit: cvs rdiff -u -r1.159 -r1.160

CVS commit: src/sys/ufs/ffs

2018-07-18 Thread Valeriy E. Ushakov
Module Name:src Committed By: uwe Date: Wed Jul 18 22:40:56 UTC 2018 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: ffs_superblock_validate - check fs_old_size too. Now I can mount OpenWindows Version 3 CD from 1991. To generate a diff of this commit: cvs

CVS commit: src/sys/ufs/ffs

2018-07-03 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Jul 4 02:02:15 UTC 2018 Modified Files: src/sys/ufs/ffs: ffs_subr.c Log Message: Avoid Undefined Behavior in ffs_clusteracct() Change the type of 'bit' variable from int to unsigned int and use unsigned values consistently.

CVS commit: src/sys/ufs/lfs

2018-06-09 Thread Zafer Aydogan
Module Name:src Committed By: zafer Date: Sat Jun 9 18:48:31 UTC 2018 Modified Files: src/sys/ufs/lfs: lfs_bio.c lfs_segment.c Log Message: Add missing b_cflags and b_oflags. Ok dholland@ Addresses PR kern/42342 by Yoshihiro Nakajima To generate a diff of this commit:

CVS commit: src/sys/ufs/chfs

2018-02-07 Thread Ryota Ozaki
Module Name:src Committed By: ozaki-r Date: Wed Feb 7 08:50:13 UTC 2018 Modified Files: src/sys/ufs/chfs: ebh.c Log Message: Remove unnecessary assertions KASSERT(!rw_lock_held()) just before rw_destroy() is useless because rw_destroy does more strict check and provides

CVS commit: src/sys/ufs/chfs

2018-01-29 Thread Sevan Janiyan
Module Name:src Committed By: sevan Date: Mon Jan 29 15:48:50 UTC 2018 Modified Files: src/sys/ufs/chfs: chfs_pool.c Log Message: Drop commended out include to a hardcoded path in root's home directory. To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3

CVS commit: src/sys/ufs/ffs

2018-01-28 Thread Juergen Hannken-Illjes
Module Name:src Committed By: hannken Date: Sun Jan 28 10:02:01 UTC 2018 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: Prevent use-after-free where genfs_node_destroy() would destroy a lock residing in the just freed inode data. To generate a diff of this

CVS commit: src/sys/ufs/ufs

2018-01-28 Thread Juergen Hannken-Illjes
Module Name:src Committed By: hannken Date: Sun Jan 28 10:01:18 UTC 2018 Modified Files: src/sys/ufs/ufs: ufs_inode.c Log Message: Make sure inode blocks and size are zero when VOP_INACTIVE() finalises a now unlinked inode. Counterpart of the check in ffs_newvnode(). To

CVS commit: src/sys/ufs/ffs

2017-12-07 Thread Chuck Silvers
Module Name:src Committed By: chs Date: Thu Dec 7 21:53:41 UTC 2017 Modified Files: src/sys/ufs/ffs: ffs_alloc.c Log Message: fix the UVM_PAGE_TRKOWN page-locking assertion at the top of ffs_alloc() to work right for multi-threaded processes. To generate a diff of this

CVS commit: src/sys/ufs/ffs

2017-11-15 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Wed Nov 15 21:21:18 UTC 2017 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: PR/52728: Izumi Tsutsui: "mount -u /dev/ /" triggers kernel panic Simplify the control flow of the mount code and make sure that the

CVS commit: src/sys/ufs/chfs

2017-11-14 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Nov 14 22:06:40 UTC 2017 Modified Files: src/sys/ufs/chfs: chfs_vfsops.c Log Message: Fix up chfs_mountfs error branches. To generate a diff of this commit: cvs rdiff -u -r1.16 -r1.17 src/sys/ufs/chfs/chfs_vfsops.c

CVS commit: src/sys/ufs/chfs

2017-11-09 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Thu Nov 9 22:16:39 UTC 2017 Modified Files: src/sys/ufs/chfs: chfs_malloc.c Log Message: use PR_WAITOK everywhere. To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/sys/ufs/chfs/chfs_malloc.c Please note that

CVS commit: src/sys/ufs/ufs

2017-10-25 Thread Jaromir Dolecek
Module Name:src Committed By: jdolecek Date: Wed Oct 25 18:06:01 UTC 2017 Modified Files: src/sys/ufs/ufs: quota2.h Log Message: fix tyop, PR kern/52653 by Edgar Fuss To generate a diff of this commit: cvs rdiff -u -r1.9 -r1.10 src/sys/ufs/ufs/quota2.h Please note that

CVS commit: src/sys/ufs/ffs

2017-08-20 Thread Maya Rashish
Module Name:src Committed By: maya Date: Sun Aug 20 12:51:39 UTC 2017 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: print mode as octal for readability To generate a diff of this commit: cvs rdiff -u -r1.353 -r1.354 src/sys/ufs/ffs/ffs_vfsops.c Please note

CVS commit: src/sys/ufs/ufs

2017-08-20 Thread Maya Rashish
Module Name:src Committed By: maya Date: Sun Aug 20 12:09:06 UTC 2017 Modified Files: src/sys/ufs/ufs: inode.h Log Message: update the comment to the current IFMT/permissions location To generate a diff of this commit: cvs rdiff -u -r1.75 -r1.76 src/sys/ufs/ufs/inode.h

CVS commit: src/sys/ufs/lfs

2017-08-19 Thread Maya Rashish
Module Name:src Committed By: maya Date: Sun Aug 20 05:37:03 UTC 2017 Modified Files: src/sys/ufs/lfs: lfs_vnops.c Log Message: Fix typo in comment To generate a diff of this commit: cvs rdiff -u -r1.320 -r1.321 src/sys/ufs/lfs/lfs_vnops.c Please note that diffs are

CVS commit: src/sys/ufs/lfs

2017-08-19 Thread Maya Rashish
Module Name:src Committed By: maya Date: Sun Aug 20 00:03:12 UTC 2017 Modified Files: src/sys/ufs/lfs: lfs_segment.c Log Message: XXX question our double-flushing of dirops To generate a diff of this commit: cvs rdiff -u -r1.274 -r1.275 src/sys/ufs/lfs/lfs_segment.c

CVS commit: src/sys/ufs/lfs

2017-08-19 Thread Maya Rashish
Module Name:src Committed By: maya Date: Sat Aug 19 14:22:49 UTC 2017 Modified Files: src/sys/ufs/lfs: lfs_pages.c Log Message: Ask some question about the code in a XXX comment To generate a diff of this commit: cvs rdiff -u -r1.14 -r1.15 src/sys/ufs/lfs/lfs_pages.c

CVS commit: src/sys/ufs/lfs

2017-08-19 Thread Maya Rashish
Module Name:src Committed By: maya Date: Sat Aug 19 12:01:08 UTC 2017 Modified Files: src/sys/ufs/lfs: lfs_vnops.c Log Message: Not much point doing anything after a panic call To generate a diff of this commit: cvs rdiff -u -r1.319 -r1.320 src/sys/ufs/lfs/lfs_vnops.c

CVS commit: src/sys/ufs/lfs

2017-08-19 Thread Maya Rashish
Module Name:src Committed By: maya Date: Sat Aug 19 11:27:42 UTC 2017 Modified Files: src/sys/ufs/lfs: lfs_alloc.c lfs_vnops.c Log Message: Consistently use {,UN}MARK_VNODE macros rather than function calls. To generate a diff of this commit: cvs rdiff -u -r1.136

CVS commit: src/sys/ufs/ffs

2017-08-13 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sun Aug 13 21:00:58 UTC 2017 Modified Files: src/sys/ufs/ffs: ffs_alloc.c Log Message: Don't time out the discard work queue here. Either destroying a work queue with pending work items panics or accessing freed resources from

CVS commit: src/sys/ufs

2017-08-07 Thread David A. Holland
Module Name:src Committed By: dholland Date: Mon Aug 7 06:53:49 UTC 2017 Modified Files: src/sys/ufs/lfs: ulfs_vnops.c src/sys/ufs/ufs: ufs_vnops.c Log Message: Tidy up ufs_readdir. First step only; there's plenty more that could be done to improve this code.

CVS commit: src/sys/ufs/lfs

2017-08-04 Thread Maya Rashish
Module Name:src Committed By: maya Date: Fri Aug 4 07:27:42 UTC 2017 Modified Files: src/sys/ufs/lfs: ulfs_vnops.c Log Message: fix buffer overflow/KASSERT when cookies are supplied lfs no longer uses the ffs-style struct direct, use the correct minimum size from

CVS commit: src/sys/ufs/ext2fs

2017-07-30 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 30 14:23:54 UTC 2017 Modified Files: src/sys/ufs/ext2fs: ext2fs_vfsops.c Log Message: kmem_xyz(sizeof(struct foo)) --> kmem_xyz(sizeof(*foo)) No change to amd64 binary. To generate a diff of this commit: cvs rdiff

CVS commit: src/sys/ufs/lfs

2017-07-26 Thread Maya Rashish
Module Name:src Committed By: maya Date: Wed Jul 26 16:42:37 UTC 2017 Modified Files: src/sys/ufs/lfs: lfs.h lfs_extern.h lfs_segment.c lfs_subr.c lfs_syscalls.c lfs_vfsops.c lfs_vnops.c Log Message: change lfs_nextsegsleep and lfs_allclean_wakeup to use

CVS commit: src/sys/ufs/lfs

2017-07-26 Thread Maya Rashish
Module Name:src Committed By: maya Date: Wed Jul 26 15:07:27 UTC 2017 Modified Files: src/sys/ufs/lfs: lfs_segment.c Log Message: Revert r1.272 fix to PR kern/52301, the performance hit is making things unusable. To generate a diff of this commit: cvs rdiff -u -r1.272

CVS commit: src/sys/ufs/lfs

2017-07-26 Thread Maya Rashish
Module Name:src Committed By: maya Date: Wed Jul 26 14:39:00 UTC 2017 Modified Files: src/sys/ufs/lfs: lfs_subr.c Log Message: Deduplicate sanity check that seglock is held on segunlock To generate a diff of this commit: cvs rdiff -u -r1.95 -r1.96

CVS commit: src/sys/ufs/ffs

2017-07-12 Thread Juergen Hannken-Illjes
Module Name:src Committed By: hannken Date: Wed Jul 12 09:30:16 UTC 2017 Modified Files: src/sys/ufs/ffs: ffs_alloc.c Log Message: When initializing more inodes make sure to write them to disk before writing the cylinder group with updated cg_initediblk. To generate a

CVS commit: src/sys/ufs/lfs

2017-06-19 Thread Maya Rashish
Module Name:src Committed By: maya Date: Mon Jun 19 12:09:37 UTC 2017 Modified Files: src/sys/ufs/lfs: lfs_subr.c Log Message: Ifdef out KDASSERT which fires on my machine. To generate a diff of this commit: cvs rdiff -u -r1.94 -r1.95 src/sys/ufs/lfs/lfs_subr.c Please

CVS commit: src/sys/ufs/lfs

2017-06-15 Thread Maya Rashish
Module Name:src Committed By: maya Date: Thu Jun 15 14:37:31 UTC 2017 Modified Files: src/sys/ufs/lfs: lfs_segment.c Log Message: It isn't safe to drain dirops with seglock held, it'll deadlock if there are any dirops. drain before grabbing seglock. lfs_dirops == 0 is

CVS commit: src/sys/ufs/lfs

2017-06-12 Thread Maya Rashish
Module Name:src Committed By: maya Date: Mon Jun 12 15:02:32 UTC 2017 Modified Files: src/sys/ufs/lfs: lfs_segment.c Log Message: Use continue to denote the no-op loop to match netbsd style newline for extra clarity. To generate a diff of this commit: cvs rdiff -u

  1   2   3   4   5   6   7   8   >