CVS commit: src/sys/ufs/ffs

2021-07-14 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Wed Jul 14 07:24:14 UTC 2021 Modified Files: src/sys/ufs/ffs: ffs_vnops.c Log Message: Hook up ffsext_strategy to fifos. Pointed out by dholland@ To generate a diff of this commit: cvs rdiff -u -r1.134 -r1.135

CVS commit: src/sys/ufs/ffs

2020-07-25 Thread Chuck Silvers
Module Name:src Committed By: chs Date: Sun Jul 26 00:20:14 UTC 2020 Modified Files: src/sys/ufs/ffs: ffs_alloc.c Log Message: skip the assertions about page-locking when allocating to the extattr bmap, since extattrs do not use the page cache. To generate a diff of

CVS commit: src/sys/ufs/ffs

2020-07-05 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Sun Jul 5 20:37:40 UTC 2020 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: simplify the acl setup, and fix reversed mask in the fs_flags code. To generate a diff of this commit: cvs rdiff -u -r1.370 -r1.371

CVS commit: src/sys/ufs/ffs

2020-05-20 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Wed May 20 13:16:30 UTC 2020 Modified Files: src/sys/ufs/ffs: ffs_extattr.c Log Message: remove accmode_t typedef (not needed, breaks llvm) from maxv@ To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6

CVS commit: src/sys/ufs/ffs

2020-05-02 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Sat May 2 22:11:16 UTC 2020 Modified Files: src/sys/ufs/ffs: ffs_extattr.c ffs_inode.c Log Message: Remove the unlock/relock hack by using IO_EXT to indicate that we are already holding the lock. To generate a diff of this

CVS commit: src/sys/ufs/ffs

2020-04-21 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Tue Apr 21 15:04:13 UTC 2020 Modified Files: src/sys/ufs/ffs: ffs_subr.c Log Message: use %s/__func__ so that the strings can be shared. To generate a diff of this commit: cvs rdiff -u -r1.51 -r1.52 src/sys/ufs/ffs/ffs_subr.c

CVS commit: src/sys/ufs/ffs

2020-04-20 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Mon Apr 20 18:10:10 UTC 2020 Modified Files: src/sys/ufs/ffs: ffs_extattr.c Log Message: - Allow root to set system attributes, samba does this - Fix locking issue, perhaps we should use our own mutex; does not seem worth it

CVS commit: src/sys/ufs/ffs

2020-04-19 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Sun Apr 19 13:59:13 UTC 2020 Modified Files: src/sys/ufs/ffs: ffs_extattr.c Log Message: - add locking - wrap wapbl around truncating, ffs_extwrite does it on its own. To generate a diff of this commit: cvs rdiff -u -r1.1

CVS commit: src/sys/ufs/ffs

2020-02-18 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Feb 18 17:50:32 UTC 2020 Modified Files: src/sys/ufs/ffs: ffs_alloc.c Log Message: Fix non-DIAGNOSTIC build with UVM_PAGE_TRKOWN. To generate a diff of this commit: cvs rdiff -u -r1.164 -r1.165

CVS commit: src/sys/ufs/ffs

2019-04-14 Thread Frank Kardel
Module Name:src Committed By: kardel Date: Sun Apr 14 15:55:24 UTC 2019 Modified Files: src/sys/ufs/ffs: ffs_alloc.c Log Message: PR/53990, PR/52380, PR/52102: UFS2 cylinder group inode allocation botch Fix rare allocation botch in ffs_nodealloccg(). Conditions: a)

CVS commit: src/sys/ufs/ffs

2018-07-18 Thread Ryota Ozaki
Module Name:src Committed By: ozaki-r Date: Thu Jul 19 05:09:34 UTC 2018 Modified Files: src/sys/ufs/ffs: ffs_alloc.c Log Message: Avoid using magic numbers for arguments of workqueue_create (NFC) To generate a diff of this commit: cvs rdiff -u -r1.159 -r1.160

CVS commit: src/sys/ufs/ffs

2018-07-18 Thread Valeriy E. Ushakov
Module Name:src Committed By: uwe Date: Wed Jul 18 22:40:56 UTC 2018 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: ffs_superblock_validate - check fs_old_size too. Now I can mount OpenWindows Version 3 CD from 1991. To generate a diff of this commit: cvs

CVS commit: src/sys/ufs/ffs

2018-07-03 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Jul 4 02:02:15 UTC 2018 Modified Files: src/sys/ufs/ffs: ffs_subr.c Log Message: Avoid Undefined Behavior in ffs_clusteracct() Change the type of 'bit' variable from int to unsigned int and use unsigned values consistently.

CVS commit: src/sys/ufs/ffs

2018-01-28 Thread Juergen Hannken-Illjes
Module Name:src Committed By: hannken Date: Sun Jan 28 10:02:01 UTC 2018 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: Prevent use-after-free where genfs_node_destroy() would destroy a lock residing in the just freed inode data. To generate a diff of this

CVS commit: src/sys/ufs/ffs

2017-12-07 Thread Chuck Silvers
Module Name:src Committed By: chs Date: Thu Dec 7 21:53:41 UTC 2017 Modified Files: src/sys/ufs/ffs: ffs_alloc.c Log Message: fix the UVM_PAGE_TRKOWN page-locking assertion at the top of ffs_alloc() to work right for multi-threaded processes. To generate a diff of this

CVS commit: src/sys/ufs/ffs

2017-11-15 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Wed Nov 15 21:21:18 UTC 2017 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: PR/52728: Izumi Tsutsui: "mount -u /dev/ /" triggers kernel panic Simplify the control flow of the mount code and make sure that the

CVS commit: src/sys/ufs/ffs

2017-08-20 Thread Maya Rashish
Module Name:src Committed By: maya Date: Sun Aug 20 12:51:39 UTC 2017 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: print mode as octal for readability To generate a diff of this commit: cvs rdiff -u -r1.353 -r1.354 src/sys/ufs/ffs/ffs_vfsops.c Please note

CVS commit: src/sys/ufs/ffs

2017-08-13 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sun Aug 13 21:00:58 UTC 2017 Modified Files: src/sys/ufs/ffs: ffs_alloc.c Log Message: Don't time out the discard work queue here. Either destroying a work queue with pending work items panics or accessing freed resources from

CVS commit: src/sys/ufs/ffs

2017-07-12 Thread Juergen Hannken-Illjes
Module Name:src Committed By: hannken Date: Wed Jul 12 09:30:16 UTC 2017 Modified Files: src/sys/ufs/ffs: ffs_alloc.c Log Message: When initializing more inodes make sure to write them to disk before writing the cylinder group with updated cg_initediblk. To generate a

CVS commit: src/sys/ufs/ffs

2017-05-28 Thread Juergen Hannken-Illjes
Module Name:src Committed By: hannken Date: Sun May 28 16:37:55 UTC 2017 Modified Files: src/sys/ufs/ffs: ffs_wapbl.c Log Message: No need to call vgone() on the just created in file system log vnode, vput() is sufficient. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/ufs/ffs

2017-03-22 Thread Jaromir Dolecek
Module Name:src Committed By: jdolecek Date: Wed Mar 22 21:31:00 UTC 2017 Modified Files: src/sys/ufs/ffs: ffs_wapbl.c Log Message: move the ffs_sync() after wapbl_log_position() call, since that can still create delayed writes with MNT_ASYNC when log is created To

CVS commit: src/sys/ufs/ffs

2017-03-17 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Mar 18 05:29:16 UTC 2017 Modified Files: src/sys/ufs/ffs: ffs_snapshot.c Log Message: #if DIAGNOSTIC panic ---> KASSERT To generate a diff of this commit: cvs rdiff -u -r1.146 -r1.147 src/sys/ufs/ffs/ffs_snapshot.c

CVS commit: src/sys/ufs/ffs

2017-03-17 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Mar 18 05:26:40 UTC 2017 Modified Files: src/sys/ufs/ffs: ffs_inode.c Log Message: #if DIAGNOSTIC panic ---> KASSERT To generate a diff of this commit: cvs rdiff -u -r1.123 -r1.124 src/sys/ufs/ffs/ffs_inode.c Please

CVS commit: src/sys/ufs/ffs

2017-03-17 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Mar 18 05:20:04 UTC 2017 Modified Files: src/sys/ufs/ffs: ffs_alloc.c Log Message: #if DIAGNOSTIC panic ---> KASSERT To generate a diff of this commit: cvs rdiff -u -r1.155 -r1.156 src/sys/ufs/ffs/ffs_alloc.c Please

CVS commit: src/sys/ufs/ffs

2017-03-16 Thread Jaromir Dolecek
Module Name:src Committed By: jdolecek Date: Thu Mar 16 22:09:19 UTC 2017 Modified Files: src/sys/ufs/ffs: ffs_wapbl.c Log Message: need to turn off async during ffs_sync(), otherwise its bwrite() calls are themselves turned to bdwrite(), creating dirty delayed writes

CVS commit: src/sys/ufs/ffs

2017-03-10 Thread Jaromir Dolecek
Module Name:src Committed By: jdolecek Date: Fri Mar 10 22:43:03 UTC 2017 Modified Files: src/sys/ufs/ffs: ffs_wapbl.c Log Message: sync any delayed writes when updating filesystem to log Adresses PR kern/52056 by Martin Husemann, fix helped by Juergen Hannken, thanks

CVS commit: src/sys/ufs/ffs

2017-03-10 Thread Jaromir Dolecek
Module Name:src Committed By: jdolecek Date: Fri Mar 10 20:38:28 UTC 2017 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: slightly rearrange the code for IMNT_WANTRDONLY + MNT_UPDATE case for better readability, no functional change To generate a diff of this

CVS commit: src/sys/ufs/ffs

2017-03-06 Thread Juergen Hannken-Illjes
Module Name:src Committed By: hannken Date: Mon Mar 6 10:12:00 UTC 2017 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: Adapt the test "enable WAPBL on rw mounts only" to the recent change of the protocol to update a mounted file. Should fix PR kern/52031

CVS commit: src/sys/ufs/ffs

2017-03-01 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Thu Mar 2 00:43:40 UTC 2017 Modified Files: src/sys/ufs/ffs: ffs_vnops.c Log Message: ifdef reduction To generate a diff of this commit: cvs rdiff -u -r1.127 -r1.128 src/sys/ufs/ffs/ffs_vnops.c Please note that diffs are

CVS commit: src/sys/ufs/ffs

2017-03-01 Thread Juergen Hannken-Illjes
Module Name:src Committed By: hannken Date: Wed Mar 1 21:55:07 UTC 2017 Modified Files: src/sys/ufs/ffs: ffs_vnops.c Log Message: Make compile again without "options WAPBL". >From John D. Baker via current-users@, slightly modified by me. To generate a diff of this

CVS commit: src/sys/ufs/ffs

2017-03-01 Thread Juergen Hannken-Illjes
Module Name:src Committed By: hannken Date: Wed Mar 1 10:46:43 UTC 2017 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: Bring back read-write to read-only mount update for ffs. To generate a diff of this commit: cvs rdiff -u -r1.347 -r1.348

CVS commit: src/sys/ufs/ffs

2017-02-17 Thread Juergen Hannken-Illjes
Module Name:src Committed By: hannken Date: Fri Feb 17 08:26:41 UTC 2017 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: Flush the log to disk when ffs_sync() gets called with MNT_WAIT. To generate a diff of this commit: cvs rdiff -u -r1.342 -r1.343

CVS commit: src/sys/ufs/ffs

2017-02-08 Thread Robert Elz
Module Name:src Committed By: kre Date: Thu Feb 9 04:37:35 UTC 2017 Modified Files: src/sys/ufs/ffs: ffs_bswap.c ffs_extern.h Log Message: Sprinkle in a pinch of const, not too much, just enough to add a little strength without affecting the overall balance... To

CVS commit: src/sys/ufs/ffs

2016-12-27 Thread Juergen Hannken-Illjes
Module Name:src Committed By: hannken Date: Tue Dec 27 10:54:38 UTC 2016 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: Fix a bug introduced with Rev. 1.294: use LK_NOWAIT when called with MNT_LAZY. To generate a diff of this commit: cvs rdiff -u -r1.341

CVS commit: src/sys/ufs/ffs

2016-11-11 Thread Juergen Hannken-Illjes
Module Name:src Committed By: hannken Date: Fri Nov 11 10:50:16 UTC 2016 Modified Files: src/sys/ufs/ffs: ffs_inode.c Log Message: Fix a "slight tweak" from Rev. 1.121: bap1/bap2 must be valid before using BAP_ASSIGN(). Prevents NULL pointer dereference when "lastbn >=

CVS commit: src/sys/ufs/ffs

2016-11-10 Thread Jaromir Dolecek
Module Name:src Committed By: jdolecek Date: Thu Nov 10 22:19:23 UTC 2016 Modified Files: src/sys/ufs/ffs: ffs_wapbl.c Log Message: disable discard when log is enabled to preserve log consistency promise PR kern/50725 To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/ufs/ffs

2016-11-10 Thread Jaromir Dolecek
Module Name:src Committed By: jdolecek Date: Thu Nov 10 19:10:05 UTC 2016 Modified Files: src/sys/ufs/ffs: ffs_inode.c Log Message: ffs_indirtrunc(): for !wapbl, restore rev 1.117 behavior of writing the zeroed (indirect) block before freeing the referenced blocks; it's

CVS commit: src/sys/ufs/ffs

2016-11-07 Thread Jaromir Dolecek
Module Name:src Committed By: jdolecek Date: Mon Nov 7 21:14:23 UTC 2016 Modified Files: src/sys/ufs/ffs: ffs_inode.c Log Message: fix broken test for partial truncate, introduced in rev 1.118 PR kern/51601 kern/51602 To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/ufs/ffs

2016-11-07 Thread Jaromir Dolecek
Module Name:src Committed By: jdolecek Date: Mon Nov 7 21:05:38 UTC 2016 Modified Files: src/sys/ufs/ffs: ffs_inode.c Log Message: reduce diff vs 1.117, no functional change To generate a diff of this commit: cvs rdiff -u -r1.118 -r1.119 src/sys/ufs/ffs/ffs_inode.c

CVS commit: src/sys/ufs/ffs

2016-10-30 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Sun Oct 30 15:01:46 UTC 2016 Modified Files: src/sys/ufs/ffs: ffs_alloc.c Log Message: Tidy up panic messages, no functional change. To generate a diff of this commit: cvs rdiff -u -r1.153 -r1.154 src/sys/ufs/ffs/ffs_alloc.c

CVS commit: src/sys/ufs/ffs

2016-10-21 Thread Jaromir Dolecek
Module Name:src Committed By: jdolecek Date: Fri Oct 21 19:28:03 UTC 2016 Modified Files: src/sys/ufs/ffs: ffs_snapshot.c Log Message: revert 1.141 - the second ffs_truncate() can't really fail requested by hannken@ To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/ufs/ffs

2016-10-20 Thread Jaromir Dolecek
Module Name:src Committed By: jdolecek Date: Thu Oct 20 20:17:46 UTC 2016 Modified Files: src/sys/ufs/ffs: ffs_snapshot.c Log Message: allow also the snapshot_setup()'s call to ffs_truncate() fail, the code should simply reuse the file blocks in that case; also make sure

CVS commit: src/sys/ufs/ffs

2016-10-20 Thread Jaromir Dolecek
Module Name:src Committed By: jdolecek Date: Thu Oct 20 19:31:32 UTC 2016 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: add assertion to ensure ffs_cgupdate() is always called from within a WAPBL transaction (if logging is on) To generate a diff of this

CVS commit: src/sys/ufs/ffs

2016-10-02 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Sun Oct 2 19:02:57 UTC 2016 Modified Files: src/sys/ufs/ffs: ffs_wapbl.c Log Message: use __func__ and print the filesystem we are printing the message for. To generate a diff of this commit: cvs rdiff -u -r1.34 -r1.35

CVS commit: src/sys/ufs/ffs

2016-10-01 Thread Jaromir Dolecek
Module Name:src Committed By: jdolecek Date: Sat Oct 1 13:06:20 UTC 2016 Modified Files: src/sys/ufs/ffs: ffs_wapbl.c Log Message: wapbl_remove_log(): add missing break; harmless, fallthrough just printed extra debug message To generate a diff of this commit: cvs rdiff

CVS commit: src/sys/ufs/ffs

2016-09-25 Thread Jaromir Dolecek
Module Name:src Committed By: jdolecek Date: Sun Sep 25 17:14:59 UTC 2016 Modified Files: src/sys/ufs/ffs: ffs_alloc.c Log Message: adjust ffs_realloccg() so that the logic about allocating full contiguous block for future fragment expansion doesn't need to

CVS commit: src/sys/ufs/ffs

2016-09-25 Thread Jaromir Dolecek
Module Name:src Committed By: jdolecek Date: Sun Sep 25 11:45:39 UTC 2016 Modified Files: src/sys/ufs/ffs: ffs_balloc.c Log Message: fix typo in #ifdef notyet part To generate a diff of this commit: cvs rdiff -u -r1.61 -r1.62 src/sys/ufs/ffs/ffs_balloc.c Please note

CVS commit: src/sys/ufs/ffs

2016-09-24 Thread Jaromir Dolecek
Module Name:src Committed By: jdolecek Date: Sat Sep 24 21:00:54 UTC 2016 Modified Files: src/sys/ufs/ffs: ffs_wapbl.c Log Message: fix swapped KASSERT() To generate a diff of this commit: cvs rdiff -u -r1.31 -r1.32 src/sys/ufs/ffs/ffs_wapbl.c Please note that diffs

CVS commit: src/sys/ufs/ffs

2016-09-24 Thread Jaromir Dolecek
Module Name:src Committed By: jdolecek Date: Sat Sep 24 20:59:51 UTC 2016 Modified Files: src/sys/ufs/ffs: ffs_wapbl.c Log Message: i/o optimization for wapbl flush - only sync superblock and cgs when they were actually changed To generate a diff of this commit: cvs

CVS commit: src/sys/ufs/ffs

2016-06-19 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Sun Jun 19 22:41:31 UTC 2016 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: Relax the dup alloc tests to not include the on-disk data for ffsv2, since nothing checks that the lazy-initialized inodes are correct and

CVS commit: src/sys/ufs/ffs

2016-05-07 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat May 7 11:59:09 UTC 2016 Modified Files: src/sys/ufs/ffs: ffs_subr.c Log Message: uaf To generate a diff of this commit: cvs rdiff -u -r1.48 -r1.49 src/sys/ufs/ffs/ffs_subr.c Please note that diffs are not public domain;

CVS commit: src/sys/ufs/ffs

2015-12-23 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Wed Dec 23 23:31:28 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: We need to check if the inode is initialized for ffsv2 when we translate a filehandle to a vnode. This can come from nfs and it could be

CVS commit: src/sys/ufs/ffs

2015-11-14 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Sun Nov 15 01:39:23 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: If file system ffs is built with WAPBL defined, make sure that the module depends on the wapbl module. No impact to users of built-in ffs

CVS commit: src/sys/ufs/ffs

2015-10-22 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Oct 22 11:31:31 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: Fix PR 50070. From hannken@. To generate a diff of this commit: cvs rdiff -u -r1.335 -r1.336 src/sys/ufs/ffs/ffs_vfsops.c Please note that

CVS commit: src/sys/ufs/ffs

2015-08-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Wed Aug 12 14:52:35 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_alloc.c Log Message: Need wapbl transaction around ffs_blkfree_cg. Fixes wapbl+discard. To generate a diff of this commit: cvs rdiff -u -r1.150 -r1.151

CVS commit: src/sys/ufs/ffs

2015-08-08 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sat Aug 8 08:18:52 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_alloc.c Log Message: don't crash when printing error messages when there are no credentials. don't abuse the printed uid to log the inode number. The

CVS commit: src/sys/ufs/ffs

2015-06-28 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Jun 28 10:04:32 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_snapshot.c Log Message: Small fixes. ok hannken@ To generate a diff of this commit: cvs rdiff -u -r1.139 -r1.140 src/sys/ufs/ffs/ffs_snapshot.c Please note that

CVS commit: src/sys/ufs/ffs

2015-05-23 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat May 23 16:59:13 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: Add a missing goto. (was here before my changes) ok christos@ To generate a diff of this commit: cvs rdiff -u -r1.333 -r1.334

CVS commit: src/sys/ufs/ffs

2015-05-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Wed May 20 18:19:09 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_bswap.c Log Message: Don't (harmlessly) overrun di_db array; copy di_ib separately. Noted by Coverity, CID 974635. While here, simplify size calculation for

CVS commit: src/sys/ufs/ffs

2015-05-20 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Wed May 20 18:21:17 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_bswap.c Log Message: memcpy di_extb/db/ib separately. Noted by Coverity, CID 974636. To generate a diff of this commit: cvs rdiff -u -r1.38 -r1.39

CVS commit: src/sys/ufs/ffs

2015-05-19 Thread Martin Husemann
Module Name:src Committed By: martin Date: Tue May 19 06:44:42 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: Cosmetics: fix netbsd.org spelling To generate a diff of this commit: cvs rdiff -u -r1.332 -r1.333 src/sys/ufs/ffs/ffs_vfsops.c Please

CVS commit: src/sys/ufs/ffs

2015-05-18 Thread Martin Husemann
Module Name:src Committed By: martin Date: Mon May 18 08:07:30 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: Make the recently added fs_cgsize test less strict, as it prevents existing installs from booting. Catch the common case and warn about it,

CVS commit: src/sys/ufs/ffs

2015-04-26 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Apr 26 06:19:36 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: ffs_superblock_validate(): check the size of cylinder groups. To generate a diff of this commit: cvs rdiff -u -r1.329 -r1.330

CVS commit: src/sys/ufs/ffs

2015-04-22 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Apr 22 07:27:09 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: Instead of duplicating code, create ffs_is_appleufs(): returns 1 if the device is an AppleUFS FS, 0 otherwise. This changes the behavior a

CVS commit: src/sys/ufs/ffs

2015-04-04 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Apr 4 06:00:12 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: ffs_superblock_validate(): ensure fs_ncg!=0 and fs_maxbpg!=0 to prevent several divisions by zero. To generate a diff of this commit: cvs

CVS commit: src/sys/ufs/ffs

2015-03-15 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Mar 15 09:21:01 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: ffs_reload(): fix a bug that prevents Big Endian FSes from being reloaded. 'newfs' should be tagged as FS_SWAPPED, not 'fs'. Was here before

CVS commit: src/sys/ufs/ffs

2015-03-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Mar 14 19:52:54 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: ffs_superblock_validate(): ensure fs_ipg and fs_fpg are != 0. Otherwise division by zero in several places. To generate a diff of this

CVS commit: src/sys/ufs/ffs

2015-03-10 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Mar 10 12:59:32 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: ffs_superblock_validate(): check the number of inodes per block. Otherwise a malformed value could panic the system. To generate a diff of

CVS commit: src/sys/ufs/ffs

2015-03-03 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Mar 3 17:56:51 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: ffs_reload(): release 'bp' earlier To generate a diff of this commit: cvs rdiff -u -r1.320 -r1.321 src/sys/ufs/ffs/ffs_vfsops.c Please note

CVS commit: src/sys/ufs/ffs

2015-03-03 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Mar 3 17:46:39 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: ffs_reload(): the current implementation blindly guesses critical fields of the superblock didn't change. Add checks to ensure they didn't

CVS commit: src/sys/ufs/ffs

2015-02-23 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Feb 23 13:38:54 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: Small changes: - instead of always calling DPRINTF with __func__, put __func__ directly in the macro - ffs_mountfs(): rename fsblockloc -

CVS commit: src/sys/ufs/ffs

2015-02-22 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Feb 22 14:12:48 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_quota2.c Log Message: KNF, and simplify a bit. No functional change To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/sys/ufs/ffs/ffs_quota2.c

CVS commit: src/sys/ufs/ffs

2015-02-22 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Feb 22 14:22:34 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: ffs_superblock_validate(): sanitize fs_fragshift, fs_bmask and fs_fmask. To generate a diff of this commit: cvs rdiff -u -r1.317 -r1.318

CVS commit: src/sys/ufs/ffs

2015-02-20 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Feb 20 17:10:17 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: Style, and fix a DPRINTF No functional change To generate a diff of this commit: cvs rdiff -u -r1.316 -r1.317 src/sys/ufs/ffs/ffs_vfsops.c

CVS commit: src/sys/ufs/ffs

2015-02-15 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Feb 15 11:04:44 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_appleufs.c Log Message: Revert a change in my previous commit that broke the checksum calculation. Noted by dholland@ To generate a diff of this commit: cvs rdiff

CVS commit: src/sys/ufs/ffs

2015-02-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 14 10:21:29 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: ffs_superblock_validate(): compute fs_bshift and fs_fshift, and ensure they are consistent with what is indicated in the superblock. This

CVS commit: src/sys/ufs/ffs

2015-02-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 14 09:55:53 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: In fact, we need to sanitize the superblock *after* swapping it. Therefore, move the swap code inside the loop. 'fs-fs_sbsize' is swapped

CVS commit: src/sys/ufs/ffs

2015-02-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 14 13:43:28 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: ffs_superblock_validate(): when checking the number of frag blocks, also make sure it matches fs-fs_frag. This also prevents an infinite loop

CVS commit: src/sys/ufs/ffs

2015-02-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 14 08:07:39 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_appleufs.c Log Message: ffs_appleufs_validate(): - remove superfluous printfs - ensure ul_namelen!=0, otherwise the kernel accesses ul_name[-1] and overwrites

CVS commit: src/sys/ufs/ffs

2015-02-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 14 09:00:12 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: ffs_superblock_validate(): sanitize the number of frag blocks. To generate a diff of this commit: cvs rdiff -u -r1.312 -r1.313

CVS commit: src/sys/ufs/ffs

2015-02-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 14 09:06:11 UTC 2015 Modified Files: src/sys/ufs/ffs: fs.h Log Message: Two typos: - preferrably - preferably - overriden - overridden No functional change. To generate a diff of this commit: cvs rdiff -u -r1.65 -r1.66

CVS commit: src/sys/ufs/ffs

2015-02-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Feb 13 15:28:56 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: Make this a bit more readable. No functional change. To generate a diff of this commit: cvs rdiff -u -r1.305 -r1.306

CVS commit: src/sys/ufs/ffs

2015-02-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Feb 13 17:13:20 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: ffs_superblock_validate(): ensure fs-fs_cssize!=0, otherwise the kernel panics with kmem_alloc(0). To generate a diff of this commit: cvs

CVS commit: src/sys/ufs/ffs

2015-02-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Feb 13 15:52:29 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: Add a new function: ffs_superblock_validate(). And add a new check to ensure fs_size!=0; otherwise the kernel panics with a division by zero.

CVS commit: src/sys/ufs/ffs

2015-02-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Feb 13 16:59:53 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: Add some checks in ffs_superblock_validate(): - fs_bsize MINBSIZE - !powerof2(fs_bsize) - !powerof2(fs-fs_fsize) - fs_bsize fs-fs_fsize

CVS commit: src/sys/ufs/ffs

2015-02-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 14 07:11:34 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: ffs_reload(): call ffs_superblock_validate() with the new superblock. To generate a diff of this commit: cvs rdiff -u -r1.309 -r1.310

CVS commit: src/sys/ufs/ffs

2015-02-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 14 07:20:11 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: Style. No functional change. To generate a diff of this commit: cvs rdiff -u -r1.310 -r1.311 src/sys/ufs/ffs/ffs_vfsops.c Please note that

CVS commit: src/sys/ufs/ffs

2015-02-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 14 07:41:40 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: Currently, in ffs_reload(), we don't handle the possibility that the superblock location may have changed. But that implies that we don't

CVS commit: src/sys/ufs/ffs

2015-02-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 14 07:56:31 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_appleufs.c Log Message: KNF. No functional change. To generate a diff of this commit: cvs rdiff -u -r1.12 -r1.13 src/sys/ufs/ffs/ffs_appleufs.c Please note that

CVS commit: src/sys/ufs/ffs

2015-01-15 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Fri Jan 16 03:57:52 UTC 2015 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: PR/39371: Tobias Nygren: Don't fail mounting root if WAPBL log is corrupt. Patch from Sergio L. Pascual. XXX: pullup-7 To generate a diff

CVS commit: src/sys/ufs/ffs

2014-12-13 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Sun Dec 14 00:36:07 UTC 2014 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: - Add debugging for mount... - Merge some error returns - Check more errors To generate a diff of this commit: cvs rdiff -u -r1.302

CVS commit: src/sys/ufs/ffs

2014-12-13 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Sun Dec 14 01:13:57 UTC 2014 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: Restore apple ufs error handling. To generate a diff of this commit: cvs rdiff -u -r1.303 -r1.304 src/sys/ufs/ffs/ffs_vfsops.c Please

CVS commit: src/sys/ufs/ffs

2014-10-30 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Oct 30 17:13:41 UTC 2014 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: Limit the superblock size to SBLOCKSIZE, not MAXBSIZE. Otherwise memcpy will read beyond the allocated buffer. Discussed a bit on tech-kern@.

CVS commit: src/sys/ufs/ffs

2014-10-24 Thread Nicolas Joly
Module Name:src Committed By: njoly Date: Fri Oct 24 13:18:51 UTC 2014 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: One semicolon is enough. To generate a diff of this commit: cvs rdiff -u -r1.299 -r1.300 src/sys/ufs/ffs/ffs_vfsops.c Please note that

CVS commit: src/sys/ufs/ffs

2014-09-08 Thread Joerg Sonnenberger
Module Name:src Committed By: joerg Date: Mon Sep 8 20:52:37 UTC 2014 Modified Files: src/sys/ufs/ffs: ffs_alloc.c Log Message: Prefer cprng_fast32 over random. A good distribution even in the lower bits beat any minor performance advantage randomo(9) might have,

CVS commit: src/sys/ufs/ffs

2014-09-05 Thread Matt Thomas
Module Name:src Committed By: matt Date: Fri Sep 5 06:10:08 UTC 2014 Modified Files: src/sys/ufs/ffs: ffs_snapshot.c Log Message: Don't nest structure definitions. To generate a diff of this commit: cvs rdiff -u -r1.136 -r1.137 src/sys/ufs/ffs/ffs_snapshot.c Please

CVS commit: src/sys/ufs/ffs

2014-07-25 Thread David A. Holland
Module Name:src Committed By: dholland Date: Fri Jul 25 08:24:31 UTC 2014 Modified Files: src/sys/ufs/ffs: ffs_alloc.c Log Message: Switch the FFS code for discarding free blocks to use VOP_FDISCARD. To generate a diff of this commit: cvs rdiff -u -r1.145 -r1.146

CVS commit: src/sys/ufs/ffs

2014-07-11 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Fri Jul 11 16:17:29 UTC 2014 Modified Files: src/sys/ufs/ffs: ffs_wapbl.c Log Message: move the flag setting higher to avoid KASSERT (dholland) To generate a diff of this commit: cvs rdiff -u -r1.27 -r1.28

CVS commit: src/sys/ufs/ffs

2014-07-10 Thread David A. Holland
Module Name:src Committed By: dholland Date: Thu Jul 10 06:02:40 UTC 2014 Modified Files: src/sys/ufs/ffs: ffs_snapshot.c Log Message: Use an explicit compare to 0 for an immediate error result, not !. Using ! is perfectly clear on variables like error or result, but

CVS commit: src/sys/ufs/ffs

2014-07-10 Thread David A. Holland
Module Name:src Committed By: dholland Date: Thu Jul 10 06:27:15 UTC 2014 Modified Files: src/sys/ufs/ffs: ffs_wapbl.c Log Message: Fix unchecked UFS_WAPBL_BEGIN. Coverity 975226. Unfortunately it looks like all we can do on error here is printf. To generate a diff of

  1   2   >