CVS commit: src/tests/usr.bin/make

2020-06-08 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Jun 8 19:50:11 UTC 2020 Modified Files: src/tests/usr.bin/make: t_make.sh Log Message: usr.bin/make: fix test failure The two files include-sub.mk and include-subsub.mk were never intended to be test cases on their own. The

CVS commit: src/usr.bin/make

2020-06-13 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Jun 13 07:30:02 UTC 2020 Modified Files: src/usr.bin/make: str.c Log Message: usr.bin/make: fix typo in comment To generate a diff of this commit: cvs rdiff -u -r1.42 -r1.43 src/usr.bin/make/str.c Please note that diffs are

CVS commit: src/usr.bin/make

2020-06-13 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Jun 13 07:36:07 UTC 2020 Modified Files: src/usr.bin/make: str.c Log Message: usr.bin/make: consistently use ++ for incrementing pointers To generate a diff of this commit: cvs rdiff -u -r1.43 -r1.44 src/usr.bin/make/str.c

CVS commit: src/usr.bin/make

2020-06-13 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Jun 13 07:49:00 UTC 2020 Modified Files: src/usr.bin/make: str.c Log Message: usr.bin/make: remove redundant parentheses around return To generate a diff of this commit: cvs rdiff -u -r1.44 -r1.45 src/usr.bin/make/str.c Ple

CVS commit: src/usr.bin/make

2020-06-13 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Jun 13 21:16:27 UTC 2020 Modified Files: src/usr.bin/make: str.c src/usr.bin/make/unit-tests: modmatch.mk Log Message: usr.bin/make: make Str_Match faster for repeated asterisks Conceptually related to https://en.wiki

CVS commit: src/usr.bin/make

2020-06-14 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jun 14 23:13:21 UTC 2020 Modified Files: src/usr.bin/make: str.c src/usr.bin/make/unit-tests: modmatch.mk Log Message: usr.bin/make: revert performance improvement That change might be the cause of a build failure for

CVS commit: src/usr.bin/make

2020-06-15 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Jun 15 14:46:28 UTC 2020 Modified Files: src/usr.bin/make: str.c src/usr.bin/make/unit-tests: modmatch.mk Log Message: make(1): fix performance problem in specially crafted :M modifier This fix was previously suspecte

CVS commit: src

2020-06-28 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jun 28 09:42:41 UTC 2020 Modified Files: src/distrib/sets/lists/tests: mi src/usr.bin/make/unit-tests: Makefile Added Files: src/usr.bin/make/unit-tests: cond-short.exp cond-short.mk Log Message: make(1): demon

CVS commit: src/usr.bin/make

2020-06-28 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jun 28 11:06:27 UTC 2020 Modified Files: src/usr.bin/make: cond.c src/usr.bin/make/unit-tests: cond-short.exp cond-short.mk Log Message: make(1): fix evaluation of unreachable conditions Since 2015-10-11, make had eva

CVS commit: src/usr.bin/make/unit-tests

2020-07-02 Thread Roland Illig
Module Name:src Committed By: rillig Date: Thu Jul 2 09:44:51 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: varmisc.mk Log Message: make(1): document the actual cause for "recursive variable" That wrong error message had nothing to do with the .for loop, it was o

CVS commit: src/usr.bin/make/unit-tests

2020-07-02 Thread Roland Illig
Module Name:src Committed By: rillig Date: Thu Jul 2 10:36:58 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: cond-short.exp cond-short.mk Log Message: make(1): demonstrate another unnecessary condition evaluation To generate a diff of this commit: cvs rdiff -u -r

CVS commit: src/usr.bin/make

2020-07-02 Thread Roland Illig
Module Name:src Committed By: rillig Date: Thu Jul 2 12:34:30 UTC 2020 Modified Files: src/usr.bin/make: var.c src/usr.bin/make/unit-tests: cond-short.exp Log Message: make(1): fix edge case for evaluating unnecessary conditions To generate a diff of this commit

CVS commit: src/usr.bin/make/unit-tests

2020-07-02 Thread Roland Illig
Module Name:src Committed By: rillig Date: Thu Jul 2 12:37:18 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: cond-short.exp cond-short.mk Log Message: make(1): demonstrate another unintended variable evaluation To generate a diff of this commit: cvs rdiff -u -r1.

CVS commit: src/usr.bin/make

2020-07-02 Thread Roland Illig
Module Name:src Committed By: rillig Date: Thu Jul 2 13:04:09 UTC 2020 Modified Files: src/usr.bin/make: var.c src/usr.bin/make/unit-tests: cond-short.exp cond-short.mk Log Message: make(1): fix unnecessary evaluation of :M and :N modifiers To generate a diff of

CVS commit: src/usr.bin/make

2020-07-02 Thread Roland Illig
Module Name:src Committed By: rillig Date: Thu Jul 2 15:14:38 UTC 2020 Modified Files: src/usr.bin/make: make.h nonints.h var.c Log Message: make(1): add more type safety for enums There are several types of flags for variables, and these cannot be mixed. To prevent acc

CVS commit: src/usr.bin/make

2020-07-02 Thread Roland Illig
Module Name:src Committed By: rillig Date: Thu Jul 2 15:26:21 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): use enum instead of #define for VarPattern flags To generate a diff of this commit: cvs rdiff -u -r1.228 -r1.229 src/usr.bin/make/var.c

CVS commit: src/usr.bin/make

2020-07-02 Thread Roland Illig
Module Name:src Committed By: rillig Date: Thu Jul 2 15:47:39 UTC 2020 Modified Files: src/usr.bin/make: arch.c compat.c job.c main.c make.c meta.c nonints.h parse.c suff.c var.c Log Message: make(1): remove useless parameter from Var_Set The enum correspondi

CVS commit: src/usr.bin/make

2020-07-02 Thread Roland Illig
Module Name:src Committed By: rillig Date: Thu Jul 2 16:14:50 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): clean up code in var.c - remove redundant parentheses in return statements - add missing space after comma - remove some redundant parenth

CVS commit: src/usr.bin/make/unit-tests

2020-07-02 Thread Roland Illig
Module Name:src Committed By: rillig Date: Thu Jul 2 16:37:56 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: cond-short.exp cond-short.mk Log Message: make(1): demonstrate some more cases for unintended evaluation To generate a diff of this commit: cvs rdiff -u -

CVS commit: src/usr.bin/make

2020-07-02 Thread Roland Illig
Module Name:src Committed By: rillig Date: Thu Jul 2 16:46:57 UTC 2020 Modified Files: src/usr.bin/make: var.c src/usr.bin/make/unit-tests: cond-short.exp Log Message: make(1): fix unnecessary evaluation for :S :C := modifiers To generate a diff of this commit:

CVS commit: src/usr.bin/make

2020-07-02 Thread Roland Illig
Module Name:src Committed By: rillig Date: Thu Jul 2 16:52:34 UTC 2020 Modified Files: src/usr.bin/make: var.c src/usr.bin/make/unit-tests: cond-short.exp Log Message: make(1): fix unnecessary evaluation of variables in :@var@ modifier To generate a diff of this

CVS commit: src/games/cgram

2020-07-02 Thread Roland Illig
Module Name:src Committed By: rillig Date: Thu Jul 2 19:11:01 UTC 2020 Modified Files: src/games/cgram: cgram.c Log Message: cgram(6): use standard cursor keys, use standard shuffle algorithm The previous shuffle algorithm asked for 100 random numbers, on average. The ne

CVS commit: src/usr.bin/make

2020-07-02 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 3 06:25:23 UTC 2020 Modified Files: src/usr.bin/make: str.c Log Message: make(1): clean up documentation of Str_Match To generate a diff of this commit: cvs rdiff -u -r1.48 -r1.49 src/usr.bin/make/str.c Please note tha

CVS commit: src/usr.bin/make

2020-07-02 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 3 06:30:02 UTC 2020 Modified Files: src/usr.bin/make: str.c Log Message: make(1): clean up Str_Match - removed unnecessary parentheses - uniform test for end of string To generate a diff of this commit: cvs rdiff -u -r

CVS commit: src/usr.bin/make

2020-07-03 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 3 07:40:13 UTC 2020 Modified Files: src/usr.bin/make: nonints.h str.c Log Message: make(1): refactor Str_Match - use shorter variable names to avoid line breaks - eliminate c2 variable - change return type to Boolean T

CVS commit: src/usr.bin/make

2020-07-03 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 3 08:02:56 UTC 2020 Modified Files: src/usr.bin/make: arch.c buf.c compat.c cond.c dir.c hash.c job.c main.c make.c make_malloc.c meta.c parse.c suff.c targ.c util.c var.c Log Message: make(1): rem

CVS commit: src/usr.bin/make

2020-07-03 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 3 08:13:23 UTC 2020 Modified Files: src/usr.bin/make: compat.c cond.c dir.c for.c job.c job.h main.c make.c meta.c meta.h parse.c trace.c util.c var.c Log Message: make(1): remove trailing whitespace To gene

CVS commit: src/usr.bin/make/lst.lib

2020-07-03 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 3 08:37:57 UTC 2020 Modified Files: src/usr.bin/make/lst.lib: lstAppend.c lstAtEnd.c lstAtFront.c lstClose.c lstConcat.c lstDatum.c lstDeQueue.c lstDupl.c lstEnQueue.c lstFind.c lstFindFrom.c lstFir

CVS commit: src/usr.bin/make

2020-07-03 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 3 14:14:04 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): refactor ApplyModifiers Previously, ApplyModifiers was 1200 lines long and pretty complicated. Now each of the complicated modifiers has i

CVS commit: src/usr.bin/make

2020-07-03 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 3 14:59:17 UTC 2020 Modified Files: src/usr.bin/make: var.c src/usr.bin/make/unit-tests: modmisc.exp modmisc.mk Log Message: make(1): add missing test for the :H and :T modifiers To generate a diff of this commi

CVS commit: src/usr.bin/make/unit-tests

2020-07-03 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 3 15:22:35 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: modmisc.exp modmisc.mk Log Message: make(1): add test for :H and :T modifiers with several words To generate a diff of this commit: cvs rdiff -u -r1.2 -r1

CVS commit: src/usr.bin/make

2020-07-03 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 3 15:24:31 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): clean up code for the :H and :T modifiers To generate a diff of this commit: cvs rdiff -u -r1.237 -r1.238 src/usr.bin/make/var.c Please

CVS commit: src/usr.bin/make/unit-tests

2020-07-03 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 3 15:33:01 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: modmisc.exp modmisc.mk Log Message: make(1): add more tests for :H, :T and :E modifiers To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 src/us

CVS commit: src/usr.bin/make/unit-tests

2020-07-03 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 3 15:41:37 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: modmisc.exp modmisc.mk Log Message: make(1): add test for :R modifier To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/usr.bin/make/unit-te

CVS commit: src/usr.bin/make

2020-07-03 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 3 15:42:43 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): make code for the :E and :R modifiers simpler To generate a diff of this commit: cvs rdiff -u -r1.238 -r1.239 src/usr.bin/make/var.c Ple

CVS commit: src/usr.bin/make

2020-07-03 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 3 17:00:48 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): fix indentation and alignment To generate a diff of this commit: cvs rdiff -u -r1.239 -r1.240 src/usr.bin/make/var.c Please note that di

CVS commit: src/usr.bin/make

2020-07-03 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 3 17:03:09 UTC 2020 Modified Files: src/usr.bin/make: hash.c hash.h var.c Log Message: make(1): add Hash_ForEach to avoid duplicate code To generate a diff of this commit: cvs rdiff -u -r1.21 -r1.22 src/usr.bin/make/has

CVS commit: src/usr.bin/make

2020-07-03 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 3 17:48:47 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): fix indentation in var.c Fixing the indentation manually is a tedious task. indent(1) was no help since it has several bugs and is not fl

CVS commit: src/usr.bin/make

2020-07-03 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 3 18:41:50 UTC 2020 Modified Files: src/usr.bin/make: var.c src/usr.bin/make/unit-tests: modmisc.exp modmisc.mk Log Message: make(1): fix bug in :E modifier, introduced in r1.239 today That case was not covered b

CVS commit: src/usr.bin/make/unit-tests

2020-07-03 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 3 19:21:11 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: modmisc.exp Log Message: make(1): add expected test result for modmisc To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7 src/usr.bin/make/unit-t

CVS commit: src/usr.bin/make/unit-tests

2020-07-03 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 3 19:29:25 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: sysv.exp sysv.mk Log Message: make(1): add another test for the SysV :%=% modifier To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 src/usr.bin

CVS commit: src/usr.bin/make

2020-07-03 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 3 22:10:42 UTC 2020 Modified Files: src/usr.bin/make: var.c src/usr.bin/make/unit-tests: modmisc.exp modmisc.mk Log Message: make(1): clean up documentation, small refactorings for variables - document the callba

CVS commit: src/usr.bin/make

2020-07-03 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 3 22:34:22 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): refactor ApplyModifier_SysV to have less indentation To generate a diff of this commit: cvs rdiff -u -r1.244 -r1.245 src/usr.bin/make/var

CVS commit: src/usr.bin/make

2020-07-03 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 3 22:40:55 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): reduce line length in var.c To generate a diff of this commit: cvs rdiff -u -r1.245 -r1.246 src/usr.bin/make/var.c Please note that diff

CVS commit: src/usr.bin/make/unit-tests

2020-07-04 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Jul 4 09:21:30 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: modmisc.exp modmisc.mk Log Message: make(1): add tests for the :S and :C modifiers To generate a diff of this commit: cvs rdiff -u -r1.8 -r1.9 src/usr.bin

CVS commit: src/usr.bin/make

2020-07-04 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Jul 4 10:19:39 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): remove unnecessary forward declarations To generate a diff of this commit: cvs rdiff -u -r1.247 -r1.248 src/usr.bin/make/var.c Please no

CVS commit: src/usr.bin/make

2020-07-04 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Jul 4 10:35:30 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): remove unnecessary forward declarations, fix indentation To generate a diff of this commit: cvs rdiff -u -r1.248 -r1.249 src/usr.bin/make

CVS commit: src/usr.bin/make

2020-07-04 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Jul 4 10:46:32 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): fix documentation of Var_Subst, clean up other documentation To generate a diff of this commit: cvs rdiff -u -r1.249 -r1.250 src/usr.bin/

CVS commit: src/usr.bin/make

2020-07-04 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Jul 4 10:49:09 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): remove unnecessary _t suffix from VarLoop type To generate a diff of this commit: cvs rdiff -u -r1.250 -r1.251 src/usr.bin/make/var.c Pl

CVS commit: src/usr.bin/make

2020-07-04 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Jul 4 15:44:07 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): fix :hash modifier on 16-bit platforms On platforms where int has only 16 bits the shifts would have been in 16-bit arithmetic, which woul

CVS commit: src/usr.bin/make/unit-tests

2020-07-04 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Jul 4 16:15:21 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: modmisc.exp modmisc.mk Log Message: make(1): add test for an obscure edge case of using the :@ modifier To generate a diff of this commit: cvs rdiff -u -r

CVS commit: src/usr.bin/make

2020-07-04 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Jul 4 16:30:47 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): constify VarModify parameter Since var.c r1.238 and r1.239, the callbacks for the :H :T :E :R modifiers don't modify the word anymore, and

CVS commit: src/usr.bin/make

2020-07-04 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Jul 4 17:10:34 UTC 2020 Modified Files: src/usr.bin/make: var.c src/usr.bin/make/unit-tests: modmisc.exp modmisc.mk Log Message: make(1): add debugging output for :@ modifier The inner working of the :@ modifier is q

CVS commit: src/usr.bin/make

2020-07-04 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Jul 4 17:41:04 UTC 2020 Modified Files: src/usr.bin/make: var.c src/usr.bin/make/unit-tests: modmisc.exp modmisc.mk Log Message: make(1): expand the test for variable expansion in the :@ modifier To generate a diff

CVS commit: src/usr.bin/make/unit-tests

2020-07-04 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Jul 4 18:54:18 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: modmisc.exp modmisc.mk Log Message: make(1): add tests for dollar characters in modifiers To generate a diff of this commit: cvs rdiff -u -r1.12 -r1.13 sr

CVS commit: src/usr.bin/make/unit-tests

2020-07-04 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Jul 4 21:04:25 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: Makefile Log Message: make(1): improve documentation about adding new tests To generate a diff of this commit: cvs rdiff -u -r1.59 -r1.60 src/usr.bin/make

CVS commit: src/usr.bin/make/unit-tests

2020-07-04 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Jul 4 22:01:10 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: Makefile varshell.exp Log Message: make(1): add post-processing for tests By defining SED_CMDS.${test}, a test can do additional post-processing on its out

CVS commit: src/usr.bin/make/unit-tests

2020-07-04 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Jul 4 22:17:09 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: Makefile modmisc.exp Log Message: make(1): ignore system-specific error message from regcomp in test NetBSD 8 has: repetition-operator operand invalid Ubun

CVS commit: src/usr.bin/make/unit-tests

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 07:08:10 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: modts.exp modts.mk Log Message: make(1): demonstrate inconsistent :ts behavior among modifiers To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3

CVS commit: src/usr.bin/make/unit-tests

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 09:13:22 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: modts.exp modts.mk Log Message: make(1): add more tests for :ts modifier To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 src/usr.bin/make/unit

CVS commit: src/usr.bin/make

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 09:26:19 UTC 2020 Modified Files: src/usr.bin/make: nonints.h str.c var.c Log Message: make(1): move SysV string matching to var.c This kind of string matching is only used in variable modifiers, and only if this featu

CVS commit: src/usr.bin/make

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 10:28:44 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): clean up code in var.c * use canonical comparison to zero in more cases * omit unnecessary snprintf for string literal concatenation * omi

CVS commit: src/usr.bin/make

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 10:38:02 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): clean up handling of :? modifier The VarPattern type had nothing to do with parsing conditions. To generate a diff of this commit: cvs r

CVS commit: src/usr.bin/make

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 12:26:17 UTC 2020 Modified Files: src/usr.bin/make: arch.c compat.c cond.c for.c job.c main.c make.c meta.c nonints.h parse.c suff.c var.c Log Message: make(1): rename Varf_Flags to VarEvalFlags In var.c th

CVS commit: src/usr.bin/make

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 12:35:30 UTC 2020 Modified Files: src/usr.bin/make: cond.c main.c meta.c Log Message: make(1): clean up unnecessary snprintf and multi-line function calls To generate a diff of this commit: cvs rdiff -u -r1.80 -r1.81

CVS commit: src/usr.bin/make

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 12:51:06 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): convert VarFind flags to typed enum To generate a diff of this commit: cvs rdiff -u -r1.259 -r1.260 src/usr.bin/make/var.c Please note t

CVS commit: src/usr.bin/make

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 13:21:56 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): rename flags for :S and :C pattern matching Renaming these flags makes it obvious that VarPattern is used in a few places where it doesn't

CVS commit: src/usr.bin/make

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 14:05:39 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): replace ApplyModifiersState field with local variable To generate a diff of this commit: cvs rdiff -u -r1.261 -r1.262 src/usr.bin/make/va

CVS commit: src/usr.bin/make/unit-tests

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 14:23:02 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: sysv.exp sysv.mk Log Message: make(1): add test for ampersand in SysV substitution modifier To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 sr

CVS commit: src/usr.bin/make/unit-tests

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 15:16:22 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: modmisc.exp modmisc.mk Log Message: make(1): add test for stray dollar signs in :@ modifier To generate a diff of this commit: cvs rdiff -u -r1.14 -r1.15

CVS commit: src/usr.bin/make

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 15:47:10 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): eliminate macro from VarGetPattern To generate a diff of this commit: cvs rdiff -u -r1.262 -r1.263 src/usr.bin/make/var.c Please note th

CVS commit: src/usr.bin/make

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 15:51:51 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): eliminate unused local variables To generate a diff of this commit: cvs rdiff -u -r1.263 -r1.264 src/usr.bin/make/var.c Please note that

CVS commit: src/usr.bin/make

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 16:08:24 UTC 2020 Modified Files: src/usr.bin/make: var.c src/usr.bin/make/unit-tests: varmod-edge.mk Log Message: make(1): rename VarGetPattern to ParseModifierPart To generate a diff of this commit: cvs rdif

CVS commit: src/usr.bin/make

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 16:22:44 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): remove unused parameter from ParseModifierPart To generate a diff of this commit: cvs rdiff -u -r1.265 -r1.266 src/usr.bin/make/var.c Pl

CVS commit: src/usr.bin/make

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 16:48:48 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): clean up VarLoop structure To generate a diff of this commit: cvs rdiff -u -r1.266 -r1.267 src/usr.bin/make/var.c Please note that diffs

CVS commit: src/usr.bin/make/unit-tests

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 17:24:22 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: modmisc.exp modmisc.mk Log Message: make(1): demonstrate off-by-one bug in :C modifier To generate a diff of this commit: cvs rdiff -u -r1.15 -r1.16 src/u

CVS commit: src/usr.bin/make

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 17:40:30 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): rename ApplyModifiersState.flags to eflags There are just too many variables called "flags" in this file, and their constants must not acc

CVS commit: src/usr.bin/make

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 17:43:36 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): remove redundant loop control variable To generate a diff of this commit: cvs rdiff -u -r1.268 -r1.269 src/usr.bin/make/var.c Please not

CVS commit: src/usr.bin/make

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 18:35:54 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): fix double free introduced this morning in r1.258 To generate a diff of this commit: cvs rdiff -u -r1.269 -r1.270 src/usr.bin/make/var.c

CVS commit: src/usr.bin/make

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 19:27:08 UTC 2020 Modified Files: src/usr.bin/make: var.c src/usr.bin/make/unit-tests: modmisc.exp Log Message: make(1): fix off-by-one error in :C modifier Previously this off-by-one error had invoked undefine

CVS commit: src/usr.bin/make/unit-tests

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 19:36:20 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: modmisc.exp modmisc.mk Log Message: make(1): add tests for maximum number of capturing groups in :C To generate a diff of this commit: cvs rdiff -u -r1.17

CVS commit: src/usr.bin/make/unit-tests

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 20:37:57 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: varmisc.mk Log Message: make(1): fix date in comment in unit test To generate a diff of this commit: cvs rdiff -u -r1.10 -r1.11 src/usr.bin/make/unit-test

CVS commit: src/usr.bin/make/unit-tests

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 20:49:45 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: modmisc.exp modmisc.mk Log Message: make(1): add tests for the ::= modifiers To generate a diff of this commit: cvs rdiff -u -r1.18 -r1.19 src/usr.bin/mak

CVS commit: src/usr.bin/make

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 20:56:34 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): flatten ApplyModifier_Assign To generate a diff of this commit: cvs rdiff -u -r1.271 -r1.272 src/usr.bin/make/var.c Please note that dif

CVS commit: src/usr.bin/make/unit-tests

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 21:03:55 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: cond-short.mk Log Message: make(1): add test for assignment operators in conditions To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/usr.bi

CVS commit: src/usr.bin/make

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 21:10:35 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): remove wrong VarPattern from ApplyModifier_Assign To generate a diff of this commit: cvs rdiff -u -r1.272 -r1.273 src/usr.bin/make/var.c

CVS commit: src/usr.bin/make

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 21:14:56 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): remove wrong VarPattern from ApplyModifier_Exclam To generate a diff of this commit: cvs rdiff -u -r1.273 -r1.274 src/usr.bin/make/var.c

CVS commit: src/usr.bin/make

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 21:30:50 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): don't call VarSubstitute unnecessarily To generate a diff of this commit: cvs rdiff -u -r1.274 -r1.275 src/usr.bin/make/var.c Please not

CVS commit: src/usr.bin/make

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 22:04:28 UTC 2020 Modified Files: src/usr.bin/make: var.c src/usr.bin/make/unit-tests: sysv.exp sysv.mk Log Message: make(1): make ampersand in ${VAR:from=to&} an ordinary character In SysV substitutions, wildc

CVS commit: src/usr.bin/make

2020-07-19 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Jul 19 22:22:01 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): remove unnecessary UNCONST To generate a diff of this commit: cvs rdiff -u -r1.276 -r1.277 src/usr.bin/make/var.c Please note that diffs

CVS commit: src/usr.bin/make

2020-07-20 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Jul 20 14:50:41 UTC 2020 Modified Files: src/usr.bin/make: parse.c var.c src/usr.bin/make/unit-tests: modmisc.exp Log Message: make(1): make modifier handling simpler Implementing a modifier such as :S or :M should no

CVS commit: src/usr.bin/make

2020-07-20 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Jul 20 15:10:35 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): make implementation of the :S modifier simpler To generate a diff of this commit: cvs rdiff -u -r1.278 -r1.279 src/usr.bin/make/var.c Pl

CVS commit: src/usr.bin/make

2020-07-20 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Jul 20 15:15:32 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): fix undefined behavior in :S modifier The expression word + wordLen - leftLen had resulted in an out-of-bounds pointer before. Luckily th

CVS commit: src/usr.bin/make

2020-07-20 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Jul 20 15:44:12 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): fix type of VarPattern.lhsLen and rhsLen String length is measured in size_t, not int. To generate a diff of this commit: cvs rdiff -u -

CVS commit: src/usr.bin/make

2020-07-20 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Jul 20 15:48:50 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): prefer memcmp over strncmp To generate a diff of this commit: cvs rdiff -u -r1.281 -r1.282 src/usr.bin/make/var.c Please note that diffs

CVS commit: src/usr.bin/make

2020-07-20 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Jul 20 16:12:52 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): move documentation for assignment modifiers To generate a diff of this commit: cvs rdiff -u -r1.282 -r1.283 src/usr.bin/make/var.c Pleas

CVS commit: src/usr.bin/make/unit-tests

2020-07-20 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Jul 20 16:12:02 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: modmisc.exp modmisc.mk Log Message: make(1): add test for :tu modifier with spaces To generate a diff of this commit: cvs rdiff -u -r1.20 -r1.21 src/usr.b

CVS commit: src/usr.bin/make/unit-tests

2020-07-20 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Jul 20 16:27:55 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: sysv.exp sysv.mk Log Message: make(1): demonstrate obscure edge case in SysV modifier To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7 src/usr.

CVS commit: src/usr.bin/make

2020-07-20 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Jul 20 16:32:14 UTC 2020 Modified Files: src/usr.bin/make: var.c src/usr.bin/make/unit-tests: sysv.exp Log Message: make(1): fix obscure edge case for ${VAR:e$=x} The characters "$=" do not occur in either src or pkgs

CVS commit: src/usr.bin/make

2020-07-20 Thread Roland Illig
Module Name:src Committed By: rillig Date: Mon Jul 20 16:55:10 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): make conditions work without pattern flags The "pattern flag" VARP_NOSUBST was used to prevent evaluating irrelevant conditions. Omitting

  1   2   3   4   5   6   7   8   9   10   >