Re: [SoX-devel] sox src/coreaudio device name truncation fix

2016-06-15 Thread Eric Wong
gqrxzy8...@ftml.net wrote: Thanks. Pushed to the "pu" (potential updates) branch of git://80x24.org/sox https://80x24.org/sox.git/patch?id=bf2afa54a7dec > PS: Changing from using the deprecated CoreAudio interfaces would be a > larger change... Mans and I are just keeping the lights on until

Re: [SoX-devel] sox src/coreaudio device name truncation fix

2016-06-15 Thread gqrxzy8974
> Seems reasonable. Can you test this? > (or provide at least provide a documentation reference). The AudioDeviceGetProperty function is documented in the CoreAudio header file AudioHardwareDeprecated.h and it is very clear that property_size needs to be the size of the receiving area on the cal

Re: [SoX-devel] sox src/coreaudio device name truncation fix

2016-06-15 Thread Eric Wong
gqrxzy8...@ftml.net wrote: > I haven't tested this but it appears the code: > > https://sourceforge.net/p/sox/code/ci/master/tree/src/coreaudio.c#l154 > char name[256]; > status = > AudioDeviceGetProperty(devices[i],0,false,kAudioDevicePropertyDeviceName,&prope

[SoX-devel] sox src/coreaudio device name truncation fix

2016-06-14 Thread gqrxzy8974
I haven't tested this but it appears the code: https://sourceforge.net/p/sox/code/ci/master/tree/src/coreaudio.c#l154 char name[256]; status = AudioDeviceGetProperty(devices[i],0,false,kAudioDevicePropertyDeviceName,&property_size,&name); Needs to have