Re: [Spacewalk-devel] Query question regarding system.listLatestUpgradeablePackages

2014-02-20 Thread Michael Mraka
Jeremy D Davis wrote: % Attached you will find the patch as per the documentation % https://fedorahosted.org/spacewalk/wiki/GitGuide . Sorry about all the % emails and not following documentation. ... % Hello Spacewalk Developers, % % After asking the last question I decided to go ahead and make

Re: [Spacewalk-devel] [PATCH] Refeactored cookie parsing code to better handle malformed cookies

2014-02-20 Thread Michael Mraka
Michael Dorman wrote: % We recently discovered an issue where requests for any pxt page would % generate 500 errors. Traced it back to this submitted bug: % https://bugzilla.redhat.com/show_bug.cgi?id=723372 % % Apache2::Cookie-fetch dies if there is a malformed cookie sent by the % browser. In

Re: [Spacewalk-devel] [PATCH] Refeactored cookie parsing code to better handle malformed cookies

2014-02-20 Thread Michael Dorman
Fair enough. I will take a look and see if I can address that. If not, this is really not that critical since most people are unlikely to hit this problem, anyway. On 2/20/14 5:19 AM, Michael Mraka michael.mr...@redhat.com wrote: Michael Dorman wrote: % We recently discovered an issue where

Re: [Spacewalk-devel] Query question regarding system.listLatestUpgradeablePackages

2014-02-20 Thread Jeremy D Davis
Hello Michael, Thank you for looking at this and improving it further. I have pulled the latest patches into my branch and rebuilt the packages for both java and schema. I then performed an update of these new packages and performed a schema update on the DB but it seems the new arch ID for

Re: [Spacewalk-devel] Query question regarding system.listLatestUpgradeablePackages

2014-02-20 Thread Jeremy D Davis
Michael, I was able to get it working by manually changing the rhnServerOutdatedPackages.sql to include the arch in the select and then remove the table from Spacewalk and run the query. Once I got that fixed I was able to test the queries you updated. It seem in my environment

Re: [Spacewalk-devel] [PATCH] Refeactored cookie parsing code to better handle malformed cookies

2014-02-20 Thread Michael Dorman
Ok, here's an updated patch. The $req-jar call results in undef if there are no cookies at all, which it was not checking for. Thanks, Mike On 2/20/14 7:48 AM, Michael Dorman mdor...@godaddy.com wrote: Fair enough. I will take a look and see if I can address that. If not, this is really not