Re: [Spacewalk-devel] [PATCH] Refeactored cookie parsing code to better handle malformed cookies

2014-02-20 Thread Michael Dorman
Ok, here's an updated patch. The $req->jar call results in undef if there are no cookies at all, which it was not checking for. Thanks, Mike On 2/20/14 7:48 AM, "Michael Dorman" wrote: >Fair enough. I will take a look and see if I can address that. If not, >this is really not that critical

Re: [Spacewalk-devel] [PATCH] Refeactored cookie parsing code to better handle malformed cookies

2014-02-20 Thread Michael Dorman
Fair enough. I will take a look and see if I can address that. If not, this is really not that critical since most people are unlikely to hit this problem, anyway. On 2/20/14 5:19 AM, "Michael Mraka" wrote: >Michael Dorman wrote: >% We recently discovered an issue where requests for any pxt p

Re: [Spacewalk-devel] [PATCH] Refeactored cookie parsing code to better handle malformed cookies

2014-02-20 Thread Michael Mraka
Michael Dorman wrote: % We recently discovered an issue where requests for any pxt page would % generate 500 errors. Traced it back to this submitted bug: % https://bugzilla.redhat.com/show_bug.cgi?id=723372 % % Apache2::Cookie->fetch dies if there is a malformed cookie sent by the % browser. In

[Spacewalk-devel] [PATCH] Refeactored cookie parsing code to better handle malformed cookies

2014-02-13 Thread Michael Dorman
We recently discovered an issue where requests for any pxt page would generate 500 errors. Traced it back to this submitted bug: https://bugzilla.redhat.com/show_bug.cgi?id=723372 Apache2::Cookie->fetch dies if there is a malformed cookie sent by the browser. In our case, it was a wildcard co