Re: [Spacewalk-devel] [PATCH] UserFactoryTest: avoid failure if there are no users

2013-09-06 Thread Grant Gainey
Hey Silvio, - Original Message - > On 08/28/2013 07:42 PM, Grant Gainey wrote: > > Fixing the tests to be more explicit and less reliant on "typical setups" > > is, at least in my opinion, always a good thing. > > I am glad to hear that, as at the moment that's exactly what I am doing! >

Re: [Spacewalk-devel] [PATCH] UserFactoryTest: avoid failure if there are no users

2013-08-28 Thread Silvio Moioli
On 08/28/2013 07:42 PM, Grant Gainey wrote: > Fixing the tests to be more explicit and less reliant on "typical setups" is, > at least in my opinion, always a good thing. I am glad to hear that, as at the moment that's exactly what I am doing! I attach three patches that go just in that directio

Re: [Spacewalk-devel] [PATCH] UserFactoryTest: avoid failure if there are no users

2013-08-28 Thread Grant Gainey
- Original Message - > Hello, > We are currently in the process of overhauling our test infrastructure > downstream, and among other things we are trying to run upstream Java > unit tests in order to spot regressions. > > We noticed that some of the tests, for example > UserFactoryTest.t

[Spacewalk-devel] [PATCH] UserFactoryTest: avoid failure if there are no users

2013-08-27 Thread Silvio Moioli
Hello, We are currently in the process of overhauling our test infrastructure downstream, and among other things we are trying to run upstream Java unit tests in order to spot regressions. We noticed that some of the tests, for example UserFactoryTest.testSatelliteHasUsers() or ChannelTest.testIsP