Re: [Spacewalk-devel] [PATCH] Validate proxy format on general config page

2012-09-18 Thread Johannes Renner
On 09/14/2012 02:32 PM, Tomas Lestach wrote: [...] Hi Johannes, the patch look good. However looking at [1] I see the code is licensed under the Apache License, Version 2.0. I'm afraid this version isn't compatible with the Spacewalk's GPLv2. Or is it? Cliff? I reworked the code

Re: [Spacewalk-devel] [PATCH] Validate proxy format on general config page

2012-09-14 Thread Johannes Renner
On 09/12/2012 05:51 PM, Tomas Lestach wrote: [...] Anyway, please, suppose Spacewalk is IPv6 ready, so if you allow IPv4 addresses, please allow IPv6 addresses as well. In case it turns out something doesn't work as expected, we'd face the issue. I'll be happy to commit your patch, when it

Re: [Spacewalk-devel] [PATCH] Validate proxy format on general config page

2012-09-14 Thread Tomas Lestach
On Friday 14 of September 2012 11:36:40 Johannes Renner wrote: On 09/12/2012 05:51 PM, Tomas Lestach wrote: [...] Anyway, please, suppose Spacewalk is IPv6 ready, so if you allow IPv4 addresses, please allow IPv6 addresses as well. In case it turns out something doesn't work as expected,

Re: [Spacewalk-devel] [PATCH] Validate proxy format on general config page

2012-09-11 Thread Tomas Lestach
On Monday 10 of September 2012 11:36:49 Johannes Renner wrote: Hey, Here is a patch for adding some validation to the HTTP proxy field on the general config page (https://hostname/rhn/admin/config/GeneralConfig.do). This validator will allow FQDN or FQDN:port only, while a simple hostname

[Spacewalk-devel] [PATCH] Validate proxy format on general config page

2012-09-10 Thread Johannes Renner
Hey, Here is a patch for adding some validation to the HTTP proxy field on the general config page (https://hostname/rhn/admin/config/GeneralConfig.do). This validator will allow FQDN or FQDN:port only, while a simple hostname will not pass. IPv4 addresses will pass, but IPv6 won't. Feel free