Re: [Spacewalk-devel] erratas and the client plugin package action

2011-10-19 Thread Simon Lukasik
On 10/18/2011 08:43 PM, Miroslav Suchy wrote: Dne 18.10.2011 17:56, Ionuț Arțăriși napsal(a): Cool. So can you apply the patch that I attached to my previous email? Ahh, I did not notice it first time - sorry. Applied. Thanks. Mirek This is going to break Debian client. When something

Re: [Spacewalk-devel] erratas and the client plugin package action

2011-10-19 Thread Miroslav Suchý
On 10/19/2011 09:45 AM, Simon Lukasik wrote: This is going to break Debian client. When something is moved from the rhn-client-tools to yum-rhn-plugin, it should be moved to apt-spacewalk as well. We use errata actions in Debian? -- Miroslav Suchy Red Hat Satellite Engineering

Re: [Spacewalk-devel] erratas and the client plugin package action

2011-10-18 Thread Ionuț Arțăriși
On 05/13/2011 02:27 PM, Miroslav Suchý wrote: On 05/13/2011 02:22 PM, Duncan Mac-Vicar P. wrote: Would it make more sense for errata.py to be in the yum-rhn-plugin? It fine with me. yum-rhn-plugin and rhn-client-tools require each other (on rhel/fedora) anyway. So yes, it can be moved to

Re: [Spacewalk-devel] erratas and the client plugin package action

2011-10-18 Thread Miroslav Suchý
On 10/18/2011 04:53 PM, Ionuț Arțăriși wrote: Can we still move errata.py to yum-rhn-plugin? We've gone with the second option until now, but this would make packaging cleaner. Still no objections. -- Miroslav Suchy Red Hat Satellite Engineering

Re: [Spacewalk-devel] erratas and the client plugin package action

2011-10-18 Thread Ionuț Arțăriși
On 10/18/2011 05:17 PM, Miroslav Suchý wrote: On 10/18/2011 04:53 PM, Ionuț Arțăriși wrote: Can we still move errata.py to yum-rhn-plugin? We've gone with the second option until now, but this would make packaging cleaner. Still no objections. Cool. So can you apply the patch that I attached

Re: [Spacewalk-devel] erratas and the client plugin package action

2011-10-17 Thread Ionuț Arțăriși
On 06/01/2011 10:31 AM, Jan Pazdziora wrote: I looked a bit more into rhnSQL and I found two more helpers in rhnSQL.sql_lib. It looks like a good place for adding the bind_list function. You patch is now in Spacewalk master, 49df1fa935453bbb3fa027d31859b44dfec6c32d. I just polished a couple of

Re: [Spacewalk-devel] erratas and the client plugin package action

2011-10-17 Thread Jan Pazdziora
On Mon, Oct 17, 2011 at 04:05:46PM +0200, Ionuț Arțăriși wrote: The whole point of this patch for us was so that we could install suse patches with the special zypper way. In order for that to happen we need to first check if the server supports this new API command, so we need a new

Re: [Spacewalk-devel] erratas and the client plugin package action

2011-10-17 Thread Ionuț Arțăriși
On 10/17/2011 04:19 PM, Jan Pazdziora wrote: On Mon, Oct 17, 2011 at 04:05:46PM +0200, Ionuț Arțăriși wrote: The whole point of this patch for us was so that we could install suse patches with the special zypper way. In order for that to happen we need to first check if the server supports

Re: [Spacewalk-devel] erratas and the client plugin package action

2011-05-19 Thread Ionuț Arțăriși
On 05/18/2011 05:05 PM, Jan Pazdziora wrote: On Wed, May 18, 2011 at 02:38:54PM +0200, Ionuț Arțăriși wrote: On 05/18/2011 01:14 PM, Jan Pazdziora wrote: ... Nack. This is SQL-injection-prone. You have to use bind parameters or sanitize the input properly. Thanks, I have fixed the SQL issue.

Re: [Spacewalk-devel] erratas and the client plugin package action

2011-05-18 Thread Ionuț Arțăriși
On 05/18/2011 01:14 PM, Jan Pazdziora wrote: ... Nack. This is SQL-injection-prone. You have to use bind parameters or sanitize the input properly. Thanks, I have fixed the SQL issue. Besides, if you allow the list of errata id's to be passed in, which would lead to multiple erratas to be

Re: [Spacewalk-devel] erratas and the client plugin package action

2011-05-18 Thread Duncan Mac-Vicar P.
On 05/18/2011 02:38 PM, Ionuț Arțăriși wrote: On 05/18/2011 01:14 PM, Jan Pazdziora wrote: ... Nack. This is SQL-injection-prone. You have to use bind parameters or sanitize the input properly. Thanks, I have fixed the SQL issue. Besides, if you allow the list of errata id's to be passed

Re: [Spacewalk-devel] erratas and the client plugin package action

2011-05-18 Thread Miroslav Suchý
On 05/18/2011 03:22 PM, Duncan Mac-Vicar P. wrote: On 05/18/2011 02:38 PM, Ionuț Arțăriși wrote: On 05/18/2011 01:14 PM, Jan Pazdziora wrote: ... Nack. This is SQL-injection-prone. You have to use bind parameters or sanitize the input properly. Thanks, I have fixed the SQL issue. Besides,

Re: [Spacewalk-devel] erratas and the client plugin package action

2011-05-18 Thread Jan Pazdziora
On Wed, May 18, 2011 at 02:38:54PM +0200, Ionuț Arțăriși wrote: On 05/18/2011 01:14 PM, Jan Pazdziora wrote: ... Nack. This is SQL-injection-prone. You have to use bind parameters or sanitize the input properly. Thanks, I have fixed the SQL issue. It's still somewhat missing in your patch.

Re: [Spacewalk-devel] erratas and the client plugin package action

2011-05-17 Thread Ionuț Arțăriși
On 05/12/2011 03:26 PM, Duncan Mac-Vicar P. wrote: I would like to have the name of the errata so that the client solver can figure the right packages to install (we have the errata in the repo metadata as well). But right now it looks like the package list is sent down. Is there any way to

Re: [Spacewalk-devel] erratas and the client plugin package action

2011-05-17 Thread Miroslav Suchý
On 05/17/2011 02:17 PM, Ionuț Arțăriși wrote: Is there any way to get the errata names at all right now? No, there is not. You are correct. Since errata.update only receives a list of errata ids, how could we get the names from the server in order to send them to zypper? I looked around

Re: [Spacewalk-devel] erratas and the client plugin package action

2011-05-16 Thread Jan Pazdziora
On Fri, May 13, 2011 at 02:27:42PM +0200, Miroslav Suchý wrote: On 05/13/2011 02:22 PM, Duncan Mac-Vicar P. wrote: Would it make more sense for errata.py to be in the yum-rhn-plugin? It fine with me. yum-rhn-plugin and rhn-client-tools require each other (on rhel/fedora) anyway. Is that

Re: [Spacewalk-devel] erratas and the client plugin package action

2011-05-16 Thread Miroslav Suchy
Dne 16.5.2011 14:13, Jan Pazdziora napsal(a): On Fri, May 13, 2011 at 02:27:42PM +0200, Miroslav Suchý wrote: On 05/13/2011 02:22 PM, Duncan Mac-Vicar P. wrote: Would it make more sense for errata.py to be in the yum-rhn-plugin? It fine with me. yum-rhn-plugin and rhn-client-tools require

Re: [Spacewalk-devel] erratas and the client plugin package action

2011-05-13 Thread Miroslav Suchý
On 05/12/2011 03:26 PM, Duncan Mac-Vicar P. wrote: Hi, When I install an errata and the client fetch a job, which results in rhn/actions/package.py update(pkglist) action being called. Is the name of the errata lost? at which point does this happen? (job API, rhnsd, package.py action)?

Re: [Spacewalk-devel] erratas and the client plugin package action

2011-05-13 Thread Duncan Mac-Vicar P.
On 05/13/2011 10:02 AM, Miroslav Suchý wrote: If you go through SDC - software - errata - and you choose one. It should result in: errata.update actions. Which is picked up by: client/rhel/rhn-client-tools/src/actions/errata.py The transformation from errata to package list is there:

Re: [Spacewalk-devel] erratas and the client plugin package action

2011-05-13 Thread Miroslav Suchý
On 05/13/2011 02:22 PM, Duncan Mac-Vicar P. wrote: Would it make more sense for errata.py to be in the yum-rhn-plugin? It fine with me. yum-rhn-plugin and rhn-client-tools require each other (on rhel/fedora) anyway. So yes, it can be moved to yum-rhn-plugin. For *SUSE I think we will have to