Re: [Spacewalk-devel] [PATCH] SystemManagerTest: missing super.setUp() call added
Sorry, I did not check Grant's latest commits. Please ignore this patch. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] SUSE/AutoYaST Support
on Friday 11 March 2011 Uwe Gansert wrote: > > Patch attached. > btw, the attached patch replaced the old: 0001-added-support-for-SUSE-autoinstallation.patch Sorry if I confused you. I did not mention that in my previous mail -- ciao, Uwe Gansert Uwe Gansert SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) Business: http://www.suse.de/~ug ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] avoid link-jars task when executing make-eclipse-project
On 17 May, 2013, at 15:32, Grant Gainey wrote: > Good idea! However, I'd like to not change the existing default behavior. > What do think about the attached patch instead? It is perfectly OK to me, please merge it. Thank you very much, Silvio ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Proposal to remove filesystem dependencies from ConfigTest
On 11/06/2013 04:23 PM, Tomas Lestach wrote: > I am sorry, it took me so long to reply. No problem. > Honestly, we do not really like the proposed patch, > but on the other hand we didn't come with anything better. :-) Oh, I see :-) Anyway if you ever come up with a better idea I am always open to hear it and patch the code again! Have a nice day, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] perl List port to new css/markup
On 06/01/14 17:13, Michael Mraka wrote: > I've reviewed your patch and found couple of issues: Attached patch with all mentioned issues corrected. > It's a legacy code and I'm afraid no current spacewalk developer knows > correct answer. Ok, I will need to check if this causes some list to be incorrectly styled. -- Duncan Mac-Vicar P. - http://www.suse.com/ SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) Maxfeldstraße 5, 90409 Nürnberg, Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] change jabberd default password
On 10.08.2012 14:25, Milan Zazrivec wrote: From jabberd's post install script: ah okay, our jabberd package has no post-script like that. Are you aware of any scenario when this wouldn't be happenning? Or to put my question differently -- what is the motivation behind this patch? I did not know your jabberd package has such a post-script. I don't think you need the patch then. -- ciao, Uwe Gansert SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer Home: http://www.suse.de/~ug - Blog: http://suse.gansert.net ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] PATCH - Addesd "cobbler import" support for SUSE
on Tuesday 05 April 2011 Cliff Perry wrote: > Spacewalk uses upstream cobbler versions and does not keep a local > copy/branch. As such, this patch, which to me looks to be all cobbler > should be sent to cobbler-devel list. *ups* sorry, that was my actual intention. I wanted to send it to cobbler-devel of course. Sorry for the noise -- ciao, Uwe Gansert Uwe Gansert SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) Business: http://www.suse.de/~ug ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] ISE when changing user details on /rhn/users/UserDetails.do?uid=2
On 10/17/2013 04:17 PM, Tomáš Kašpárek wrote: > Hello, > > I've merged contents of bootstrap-css branch with current Spacewalk master, > built it and applied. > I've noticed that changing user details as admin produces ISE. > > Sending you patch which fixes the problem Thank you very much for the hint and the patch! Applied as 8ad61979b5c9b1b2a7e7d5fa954699b32909e7f3. Regards, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] rhn.manager tests: do not assume an Org admin exists
On 09/09/2013 09:34 PM, Grant Gainey wrote: > I modified the patch somewhat - [...] > Thanks for your contribution! I agree with your changes and confirm it works perfectly throughout our test suite as well. Thanks a lot for all review and commit work so far, we will be back with some more patches as soon as we are done running tests from the frontend package. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Hide the 'delete note' link on creation of system notes
On 03/01/2011 02:29 PM, Jan Pazdziora wrote: > By the way: will you be submitting the patch for the "Has Signed > Metadata" feature as well? Yes, this one is also going to be submitted, but unfortunately I can't tell you exactly when. The problem is that this is currently not a single patch, but rather a set of patches that will need to be collected and aggregated first. So, as soon as we have done that and tested it against the master branch it will also be submitted here. Greetings, Johannes -- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] SUSE/AutoYaST Support
on Thursday 10 March 2011 Jan Pazdziora wrote: > By the way, do you guys use the Spacewalk nightly yum repos as > a way of quickly checking what got to upstream, or do you use > git only? we only use the git so far -- ciao, Uwe Gansert Uwe Gansert SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) Business: http://www.suse.de/~ug ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Date/Time picker
On 02/06/2014 11:12 AM, Duncan Mac-Vicar P. wrote: > See attached patches. [...] On a slightly unrelated note, I have just noticed the current date picker allows incorrect dates to be picked, such as February 31. In the SSM errata scheduling page, among other things, such values cause a NPE. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Deployment of images built with SUSE Studio
On 05/18/2012 02:45 PM, Miroslav Suchy wrote: > In patch 0001 - schema db - you are missing upgrades for table > suseCredentialsType. > > And upgrades for table suseCredentials differs from clean install. Oh yeah, sorry, I forgot to revise the upgrade files. I can come up with another patch fixing that, or maybe rather with a new version of 0001. But in which way it differs from clean install in this case? Also at what index those files should start, looks like you are currently at 0047-rhnOrgQuota.sql? Regards, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] WebUI HTTP proxy validator doesn't check for special characters
On 11/14/2012 04:21 PM, Tomas Lestach wrote: > On Wednesday 14 of November 2012 15:06:44 Johannes Renner wrote: >> Hello, >> >> I just extended the HostPortValidator class to check proxy hostnames against >> a regex defining a valid character set. It should allow letters (all >> languages), numbers, '.' and '-', but no whitespace or any special >> characters. >> >> See my attached patch. >> >> Greetings, >> Johannes > > Applied as: ebc61c00 > I just needed to commit 2 checkstyle fixes. :-) Ah, sorry, I forgot to check (the style). Thanks for pushing the commits! -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Deployment of images built with SUSE Studio
On 15.05.2012 13:25, Miroslav Suchy wrote: The Python code was revised by Uwe, see patch 0002 and 0003. print filePath ^^ This probably omitted from some debugging. you are right of course. That line slipped in accidently from a debugging session and can be removed. -- ciao, Uwe Gansert SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer Home: http://www.suse.de/~ug - Blog: http://suse.gansert.net ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] avoid relying on types returned by Hibernate
On 07/01/2013 01:12 PM, Tomas Lestach wrote: > Could you point me to the appropriate bugzilla? I'd like to check the > reproducer. Unfortunately our Bugzilla component is closed for outside view at the moment, and the bug only affected SUSE-specific code. If you need any further details, just let me know. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] SystemManagerTest: missing super.setUp() call added
See attached patch.
Regards,
--
Silvio Moioli
SUSE LINUX Products GmbH
Maxfeldstraße 5, 90409 Nürnberg Germany
>From 8377a9ba5f349a661f49a7f0ad9c393f7745f0fc Mon Sep 17 00:00:00 2001
From: Silvio Moioli
Date: Thu, 5 Sep 2013 09:11:37 +0200
Subject: [PATCH] SystemManagerTest: missing super.setUp() call added
---
.../src/com/redhat/rhn/manager/ssm/test/SsmOperationManagerTest.java | 1 +
1 file changed, 1 insertion(+)
diff --git a/java/code/src/com/redhat/rhn/manager/ssm/test/SsmOperationManagerTest.java b/java/code/src/com/redhat/rhn/manager/ssm/test/SsmOperationManagerTest.java
index 014c696..f6509c1 100644
--- a/java/code/src/com/redhat/rhn/manager/ssm/test/SsmOperationManagerTest.java
+++ b/java/code/src/com/redhat/rhn/manager/ssm/test/SsmOperationManagerTest.java
@@ -42,6 +42,7 @@ public class SsmOperationManagerTest extends RhnBaseTestCase {
private String serverSetLabel;
protected void setUp() throws Exception {
+super.setUp();
ssmUser = UserTestUtils.findNewUser("ssmuser", "ssmorg");
serverSetLabel = populateRhnSet();
}
--
1.8.1.4
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] MonitoringManagerTest: missing super.setUp() call added
See attached patch.
Regards,
--
Silvio Moioli
SUSE LINUX Products GmbH
Maxfeldstraße 5, 90409 Nürnberg Germany
>From 5865f906d561acb613addd31fa7e6b9e4e05e8af Mon Sep 17 00:00:00 2001
From: Silvio Moioli
Date: Wed, 4 Sep 2013 11:58:10 +0200
Subject: [PATCH] MonitoringManagerTest: missing super.setUp() call added
---
.../com/redhat/rhn/manager/monitoring/test/MonitoringManagerTest.java| 1 +
1 file changed, 1 insertion(+)
diff --git a/java/code/src/com/redhat/rhn/manager/monitoring/test/MonitoringManagerTest.java b/java/code/src/com/redhat/rhn/manager/monitoring/test/MonitoringManagerTest.java
index ec22ce8..4a90e8f 100644
--- a/java/code/src/com/redhat/rhn/manager/monitoring/test/MonitoringManagerTest.java
+++ b/java/code/src/com/redhat/rhn/manager/monitoring/test/MonitoringManagerTest.java
@@ -75,6 +75,7 @@ public class MonitoringManagerTest extends RhnBaseTestCase {
* {@inheritDoc}
*/
public void setUp() throws Exception {
+super.setUp();
user = UserTestUtils.findNewUser("testUser",
"testOrg" + this.getClass().getSimpleName());
if (ConfigDefaults.get().isMonitoringBackend()) {
--
1.8.1.4
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] updateinfo to Errata import in spacewalk-repo-sync
Hi, Am Mittwoch, 9. März 2011, 11:29:45 schrieb Jan Pazdziora: > On Mon, Mar 07, 2011 at 02:28:48PM +0100, Michael Calmer wrote: [...] > when running git am, I get the following whitespace-related warnings. > Could you please polish the patch to get rid of them? Sure, I will work on all the issues as soon as time permits. May take some days. -- Regards, Michael Calmer -- Michael Calmer SUSE LINUX Products GmbH, Maxfeldstr. 5, D-90409 Nuernberg T: +49 (0) 911 74053 0 F: +49 (0) 911 74053575 - e-mail: michael.cal...@suse.com -- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Kickstartable channels should contain the anaconda package
On 22/03/13 14:55, Michael Calmer wrote: Hi, please do not apply these patches. I found out, that it is not correct. It removes the channels at more places than needed. It would still be interesting to create a discussion around how to define a "kickstartable channel". -- Duncan Mac-Vicar P. - http://www.suse.com/ SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) Maxfeldstraße 5, 90409 Nürnberg, Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] SSH Push Feature Proposal
On 24/04/13 14:38, Johannes Renner wrote: >> Can the logic you propose to be put to taskomatic be put to >> osa-dispatcher, to throttle the number of clients which get "invited" >> to rhn_check? Doesn't osad work by having the clients connect via XMPP _to_ the server? -- Duncan Mac-Vicar P. - http://www.suse.com/ SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) Maxfeldstraße 5, 90409 Nürnberg, Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Patch proposal: try-wrapping XMLRPC serialization code
On 10/01/2013 10:58 PM, Grant Gainey wrote: > I decided there *had to* be a better way to do this - and I found one! Great! > More Eyes would be great. Actually, Taskomatic classes were left out (probably overlooked). I added them in commit c29e22. Apart from that, changes look good and also all tests pass tests here as well. Thanks a lot! -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] fix display of static snippets
On 01.12.2011 17:08, Jan Pazdziora wrote:
the read only snippets in the web ui need HTML/XML escaping.
Especially AutoYaST XML snippets tend to be displayed wrong in the
UI without escaping
Shouldn't we rather do this in the .jsp?
you mean
in the jsp?
patch attached
--
ciao, Uwe Gansert
SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg)
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer
Home: http://www.suse.de/~ug - Blog: http://suse.gansert.net
diff --git a/java/code/webapp/WEB-INF/pages/kickstart/cobbler/snippetview.jsp b/java/code/webapp/WEB-INF/pages/kickstart/cobbler/snippetview.jsp
index c10c393..abe3293 100644
--- a/java/code/webapp/WEB-INF/pages/kickstart/cobbler/snippetview.jsp
+++ b/java/code/webapp/WEB-INF/pages/kickstart/cobbler/snippetview.jsp
@@ -54,7 +54,7 @@
- ${data}
+ ""
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] avoid link-jars task when executing make-eclipse-project
Hi, I noticed that the make-eclipse-project Ant task in build.xml depends on link-jars, which as far as I understand should not be needed. This could result in errors when a developer wants to produce the Eclipse project files even if he/she doesn't have all dependencies set up correctly (eg. because they are available, but in other locations). I attached a simple patch that removes the dependency. Regards, Silvio Moioli >From 541498264598781c2c8656bf03abe63a8bc04277 Mon Sep 17 00:00:00 2001 From: Silvio Moioli Date: Tue, 7 May 2013 09:50:52 +0200 Subject: [PATCH] Removed an unnecessary task dependency Avoids an error in make-eclipse-project when the developer does not have JPackage dependencies installed. --- java/build.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/java/build.xml b/java/build.xml index 1431394..948d243 100644 --- a/java/build.xml +++ b/java/build.xml @@ -62,8 +62,8 @@ - + -- 1.8.1.4 ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Patch synchronization issue
On 08/21/2013 01:57 PM, Tomas Lestach wrote: > Does this mean the reproducer is wrong? Shall I take two packages of same > name, arch and evr? xulrunner-devel-17.0.5-1.el6_4-x86_64 and > xulrunner-devel-17.0.5-1.el6_4-x86_64 (let's say signed with another gpg key)? Exactly - the problem arises when both a new package in an updated errata and a package already present in a less recent, cloned errata have identical (name, evr, arch). I apologize for my first explanation and examples not being clear enough. > Actually it should not be possible to change the content of RHEL channels, > so if you found a way how, please, let me know. In our case, the vendor simply changed a patch, adding packages. Custom channels/patches could also run in the same issue. Thanks, regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] SystemEntitlementsSetupActionTest: do not assume Org has virtualization entitlement
SystemEntitlementsSetupActionTest was failing in our environment, as the
tested Org missed a virtualization entitlement.
The proposed attached patch fixes the problem.
Regards,
--
Silvio Moioli
SUSE LINUX Products GmbH
Maxfeldstraße 5, 90409 Nürnberg Germany
>From ae8640bdd4d15e16efdcb2fce7790fc676ab3f8a Mon Sep 17 00:00:00 2001
From: Silvio Moioli
Date: Tue, 10 Sep 2013 13:18:03 +0200
Subject: [PATCH 10/22] SystemEntitlementsSetupActionTest: do not assume Org
has virtualization entitlement
---
.../systems/entitlements/test/SystemEntitlementsSetupActionTest.java | 1 +
1 file changed, 1 insertion(+)
diff --git a/java/code/src/com/redhat/rhn/frontend/action/systems/entitlements/test/SystemEntitlementsSetupActionTest.java b/java/code/src/com/redhat/rhn/frontend/action/systems/entitlements/test/SystemEntitlementsSetupActionTest.java
index 8a8a7df..91b991e 100644
--- a/java/code/src/com/redhat/rhn/frontend/action/systems/entitlements/test/SystemEntitlementsSetupActionTest.java
+++ b/java/code/src/com/redhat/rhn/frontend/action/systems/entitlements/test/SystemEntitlementsSetupActionTest.java
@@ -52,6 +52,7 @@ public class SystemEntitlementsSetupActionTest extends RhnMockStrutsTestCase {
setRequestPathInfo("/systems/SystemEntitlements");
UserTestUtils.addManagement(user.getOrg());
UserTestUtils.addMonitoring(user.getOrg());
+UserTestUtils.addVirtualization(user.getOrg());
}
/**
*
--
1.8.1.4
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Fix navigation for the default snippets page
On 11/05/2013 03:00 PM, Stephen Herr wrote: > Heh, fair enough. Committed as fd207afe0ae8a9415d96fca52167f2302df8f466. > Thanks! Thank you. At last, this patch puts the same icon that is used on the other kickstart pages. Regards, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer >From c3d4d35e6606e625eaf01719d41ef498741b8d2a Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Wed, 6 Nov 2013 10:04:12 +0100 Subject: [PATCH] Use kickstart icon on the snippets page --- java/code/webapp/WEB-INF/pages/kickstart/cobbler/snippets.jsp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/java/code/webapp/WEB-INF/pages/kickstart/cobbler/snippets.jsp b/java/code/webapp/WEB-INF/pages/kickstart/cobbler/snippets.jsp index 7a09412..ab3aa12 100644 --- a/java/code/webapp/WEB-INF/pages/kickstart/cobbler/snippets.jsp +++ b/java/code/webapp/WEB-INF/pages/kickstart/cobbler/snippets.jsp @@ -6,7 +6,7 @@ - -- 1.8.1.4 ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] NPE when scheduling a package (install/remove/upgrade) action + remote command
On 09/12/2011 01:20 PM, Miroslav Suchý wrote: > On 09/08/2011 03:02 PM, Johannes Renner wrote: >> If it can be reproduced, I will open a bug on bugzilla.redhat.com. > > I could not reproduce it on my Spacewalk 1.5 Thanks and sorry, this seems to be a known bug that is already fixed: https://bugzilla.redhat.com/show_bug.cgi?id=691849 Thanks anyways, Johannes -- SUSE LINUX Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Script contents not properly displayed
On 08/14/2012 03:36 PM, Stephen Herr wrote: > Johannes, > > Could you ensure in /usr/share/pgsql/postgresql.conf that bytea_output = > 'escape', and if not see if > that corrects your problem? > > -Stephen Thanks, setting this option fixes the problem on the postgres 9.1 database we are using. We also set standard_conforming_strings = 'off', do you think it makes still sense in combination with bytea_output = 'escape'? Thanks, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk
On 01/07/2014 10:54 AM, Michael Mraka wrote: > Maximilian Meister wrote: > % Hi everybody, > % ... > > Hello Maximilian, > > Is the spacewalk-pwstrength.js a copy of jquery.pwstrength.bootstrap > (i.e. third party stuff) or your own implementation of it? Currently it's basically a copy of third party code (with AFAIK some custom modifications he made) plus a "$(document).ready()" handler so that there is eventually only one single javascript file being referenced from the markup. Regards, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Date/Time picker
Thanks for the review and fixes!. Most of it looks good except for the self-closing tag as Silvio explained. There are other changes that I would like to understand: - The css part where you override some styles (and use !important, which basically means SUSE Manager can't override it again in its css) - setting of the input size to 15 -- Duncan Mac-Vicar P. - http://www.suse.com/ SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) Maxfeldstraße 5, 90409 Nürnberg, Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] xen distro inherits kernel options
On 11.07.2012 13:30, Uwe Gansert wrote:
Here is a simple patch that copies the kopts to the xen distro.
sorry, there is a check missing in the patch if there is a xen distro at
all.
This patch checks that.
--
ciao, Uwe Gansert
SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg)
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer
Home: http://www.suse.de/~ug - Blog: http://suse.gansert.net
listening to: "Crack It" by THYX
diff --git a/java/code/src/com/redhat/rhn/manager/kickstart/tree/BaseTreeEditOperation.java b/java/code/src/com/redhat/rhn/manager/kickstart/tree/BaseTreeEditOperation.java
index 7fee82e..048c679 100644
--- a/java/code/src/com/redhat/rhn/manager/kickstart/tree/BaseTreeEditOperation.java
+++ b/java/code/src/com/redhat/rhn/manager/kickstart/tree/BaseTreeEditOperation.java
@@ -95,11 +95,18 @@ public abstract class BaseTreeEditOperation extends BasePersistOperation {
Distro distro = Distro.lookupById(CobblerXMLRPCHelper.getConnection(
this.getUser()), tree.getCobblerId());
+Distro xen_distro = Distro.lookupById(CobblerXMLRPCHelper.getConnection(
+ this.getUser()), tree.getCobblerXenId());
Map kOpts = distro.getKernelOptions();
distro.setKernelOptions(getKernelOptions());
distro.setKernelPostOptions(getPostKernelOptions());
distro.save();
+if (xen_distro != null) {
+ xen_distro.setKernelOptions(getKernelOptions());
+ xen_distro.setKernelPostOptions(getPostKernelOptions());
+ xen_distro.save();
+}
}
catch (XmlRpcException xe) {
HibernateFactory.rollbackTransaction();
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] SUSE/AutoYaST Support
on Thursday 10 March 2011 Jan Pazdziora wrote: > we hit the > > You are not authorized to access bug #674344. > > for bnc#674344 here. > > As the patch is trivial, I'm leaning towards dropping the bnc number > from the commit message, so that you don't have to go through the > trouble of creating Red Hat bugzilla for three line code addition. > > Is that OKay? yes, of course that's okay > Or do you expect the bnc#674344 to go public any > time soon, so we should wait and commit with the bnc#674344 in the > commit message? I hope we have that public in the future but I would not suggest to wait for it. It's okay to simply drop the bnc# -- ciao, Uwe Gansert Uwe Gansert SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) Business: http://www.suse.de/~ug ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] Patch synchronization issue
Hello,
We recently stumbled upon an issue with patch synchronization, which
turned out to be a bug in Hibernate handling of Package objects, which
in turn was caused by a strange definition of hashCode() in that class.
Steps to reproduce the problem and a proposed patch follow.
Reproducing the problem:
- clone a channel (eg. RHEL x86_64 Server 6);
- update the original channel so that some of the patches are updated,
and in particular, so that at least one patch gets some new packages
added. Furthermore, at least one of those added packages should have a
(name, arch, EVR) triple that is already present among the original
patch's (name, arch, EVR) triples. An example is CL-SA-2013:0696, that
adds multiple packages for xulrunner-devel-17.0.5-1.el6_4-x86_64 and
xulrunner-devel-17.0.5-1.el6_4-i686;
- pick such a patch and attempt to sync it ("Channels" -> "Manage
Software Channels" -> -> "Patches" -> "Sync"
-> select your patch -> "Sync Patches" -> "Confirm");
- those packages which were added to the patch with a (name, arch, EVR)
triple already in the patch will NOT be added to the updated (synced) patch.
Cause:
Among other things, ErrataFactory.syncErrataDetails() will copy packages
from the original patch to the cloned patch with the line
Justin Sherrill 2008
a85006389d436719240b49f8eea37f7550edf974
--
Silvio Moioli
SUSE LINUX Products GmbH
Maxfeldstraße 5, 90409 Nürnberg Germany
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] "All relevant errata" as "All Errata"
On 03/02/2012 04:06 PM, Tomas Lestach wrote: There's one more thing confusing for me, when we're in the errata area. I mean following two pages https:///rhn/errata/Overview.do https:///rhn/errata/RelevantErrata.do display the same errata content. We might want to drop one of them. Ok, I have a patch that gets rid of errata/Overview.do. I need to rebase for master. -- Duncan Mac-Vicar P. - http://www.suse.com/ SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) Maxfeldstraße 5, 90409 Nürnberg, Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] editarea and apache 2.4
On 13/02/14 10:10, Michael Mraka wrote: > Duncan Mac-Vicar P. wrote: > Hello Duncan, > > Thanks for the patch. Currently we focus on Spacewalk 2.1 release so we will > take a look on it after the release. Makes sense. I plan to push it for our release. If you see something totally wrong with it, it would be nice to know now, even if it is not applied for 2.1. I am fine with doing more corrections after the release but I would like to avoid something completely different. Duncan ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] Fix indentation on user preferences page
Hello,
the small patch in the attachment fixes the indentation on the user
preferences page (https:///rhn/account/UserPreferences.do).
More specifically this should indent the checkboxes in the "Overview
Start Page" section, just to make it look more similar to the other
subsections.
Thanks and regards,
Johannes
--
SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg)
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer
>From b687d7444374ca60fdc6a8387e70013e3acb8f12 Mon Sep 17 00:00:00 2001
From: Johannes Renner
Date: Fri, 12 Jul 2013 11:33:30 +0200
Subject: [PATCH] Fix indentation on user preferences page
---
java/code/webapp/WEB-INF/pages/common/fragments/user/preferences.jspf | 2 ++
1 file changed, 2 insertions(+)
diff --git a/java/code/webapp/WEB-INF/pages/common/fragments/user/preferences.jspf b/java/code/webapp/WEB-INF/pages/common/fragments/user/preferences.jspf
index 0d5a099..a1bcddb 100644
--- a/java/code/webapp/WEB-INF/pages/common/fragments/user/preferences.jspf
+++ b/java/code/webapp/WEB-INF/pages/common/fragments/user/preferences.jspf
@@ -21,11 +21,13 @@
+
${item.label}
+
--
1.8.1.4
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] Fix javascript "Uncaught TypeError"
Hello, I really don't know how this could have been working before, but the attached patch to the javascript code should fix the behavior that is described in the comment and it also fixes the error that can be seen in the js console. This can be tested with: https:///rhn/users/CreateUser.do Just check the "Use PAM..." checkbox and submit the form. PAM authentication needs to be enabled via rhn.conf first, though. Thanks, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer >From 1b4a6174d0c716a3d06cc55d08081d4ca2ebf202 Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Tue, 27 Aug 2013 12:19:48 +0200 Subject: [PATCH] Fix javascript "Uncaught TypeError" --- java/code/webapp/WEB-INF/pages/user/create/usercreate.jsp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/java/code/webapp/WEB-INF/pages/user/create/usercreate.jsp b/java/code/webapp/WEB-INF/pages/user/create/usercreate.jsp index 0838b4b..a192084 100644 --- a/java/code/webapp/WEB-INF/pages/user/create/usercreate.jsp +++ b/java/code/webapp/WEB-INF/pages/user/create/usercreate.jsp @@ -149,7 +149,7 @@ --%>
[Spacewalk-devel] [PATCH] UserManagerTest: don't rely on hardcoded default time zone
UserManagerTest relied on a default "America/New_York" time zone, I
removed the hardcoded string replacing it with
UserFactory.getDefaultTimeZone().
See attached patch.
Regards,
--
Silvio Moioli
SUSE LINUX Products GmbH
Maxfeldstraße 5, 90409 Nürnberg Germany
>From 6b807ef7be31c1e4fc2a08a77cf8944a634234ee Mon Sep 17 00:00:00 2001
From: Silvio Moioli
Date: Thu, 5 Sep 2013 15:16:40 +0200
Subject: [PATCH] UserManagerTest: don't rely on hardcoded default time zone
---
java/code/src/com/redhat/rhn/manager/user/test/UserManagerTest.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/java/code/src/com/redhat/rhn/manager/user/test/UserManagerTest.java b/java/code/src/com/redhat/rhn/manager/user/test/UserManagerTest.java
index 6fccbca..6b35881 100644
--- a/java/code/src/com/redhat/rhn/manager/user/test/UserManagerTest.java
+++ b/java/code/src/com/redhat/rhn/manager/user/test/UserManagerTest.java
@@ -383,8 +383,8 @@ public class UserManagerTest extends RhnBaseTestCase {
public void testGetTimeZoneDefault() {
RhnTimeZone tz = UserManager.getDefaultTimeZone();
assertNotNull(tz);
-assertTrue(tz.getTimeZone().getRawOffset() ==
-UserFactory.getTimeZone("America/New_York").getTimeZone().getRawOffset());
+assertTrue(tz.getTimeZone().getRawOffset() == UserFactory.getDefaultTimeZone()
+.getTimeZone().getRawOffset());
}
public void testLookupTimeZoneAll() {
--
1.8.1.4
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] DownloadActionTest: do not assume file to be downloaded exists
See attached patch.
Regards,
--
Silvio Moioli
SUSE LINUX Products GmbH
Maxfeldstraße 5, 90409 Nürnberg Germany
>From 67eef48cbd7a10d9451501ade7d6df9c01a6f430 Mon Sep 17 00:00:00 2001
From: Silvio Moioli
Date: Mon, 9 Sep 2013 08:25:23 +0200
Subject: [PATCH 04/22] DownloadActionTest: do not assume file to be downloaded
exists
---
.../redhat/rhn/frontend/action/common/test/DownloadActionTest.java| 4
1 file changed, 4 insertions(+)
diff --git a/java/code/src/com/redhat/rhn/frontend/action/common/test/DownloadActionTest.java b/java/code/src/com/redhat/rhn/frontend/action/common/test/DownloadActionTest.java
index 8961f24..cdc767d 100644
--- a/java/code/src/com/redhat/rhn/frontend/action/common/test/DownloadActionTest.java
+++ b/java/code/src/com/redhat/rhn/frontend/action/common/test/DownloadActionTest.java
@@ -28,6 +28,8 @@ import com.redhat.rhn.testing.TestUtils;
import java.io.File;
import java.util.Map;
+import org.apache.commons.io.FileUtils;
+
/**
* TinyUrlActionTest
* @version $Rev$
@@ -121,6 +123,8 @@ public class DownloadActionTest extends RhnMockStrutsTestCase {
fileName);
TestUtils.saveAndFlush(p);
+FileUtils.touch(new File("/tmp/Server/" + fileName));
+
KickstartSession ksession =
KickstartSessionTest.createKickstartSession(ksdata, user);
ksession.setKstree(tree);
--
1.8.1.4
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] MethodsSetupActionTest: do not assume that method command exists
See attached patch.
Regards,
--
Silvio Moioli
SUSE LINUX Products GmbH
Maxfeldstraße 5, 90409 Nürnberg Germany
>From d49e62923f34a64e5c2caac619d751d9e6010ac4 Mon Sep 17 00:00:00 2001
From: Silvio Moioli
Date: Mon, 9 Sep 2013 10:56:06 +0200
Subject: [PATCH 05/22] MethodsSetupActionTest: do not assume that methods
exist
---
.../action/monitoring/notification/test/MethodsSetupActionTest.java | 5 +
1 file changed, 5 insertions(+)
diff --git a/java/code/src/com/redhat/rhn/frontend/action/monitoring/notification/test/MethodsSetupActionTest.java b/java/code/src/com/redhat/rhn/frontend/action/monitoring/notification/test/MethodsSetupActionTest.java
index bb06c9e..92bfc22 100644
--- a/java/code/src/com/redhat/rhn/frontend/action/monitoring/notification/test/MethodsSetupActionTest.java
+++ b/java/code/src/com/redhat/rhn/frontend/action/monitoring/notification/test/MethodsSetupActionTest.java
@@ -15,6 +15,7 @@
package com.redhat.rhn.frontend.action.monitoring.notification.test;
import com.redhat.rhn.common.db.datasource.DataResult;
+import com.redhat.rhn.domain.monitoring.notification.test.MethodTest;
import com.redhat.rhn.frontend.action.monitoring.notification.MethodsSetupAction;
import com.redhat.rhn.frontend.dto.monitoring.MethodDto;
import com.redhat.rhn.frontend.struts.RequestContext;
@@ -37,6 +38,10 @@ public class MethodsSetupActionTest extends RhnBaseTestCase {
sah.getRequest().setupAddParameter("newset", (String)null);
sah.getRequest().setupAddParameter("returnvisit", (String) null);
sah.getRequest().setupAddParameter("submitted", "false");
+
+// ensure a Method exists
+MethodTest.createTestMethodCommand(sah.getUser());
+
sah.executeAction();
// Remove if not a List SetupAction
--
1.8.1.4
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Fix query to determine available config channels in SSM
On 12/05/2011 06:53 PM, Michael Mraka wrote: > Hi Johannes, > > although Tomas commited your patch neither original version nor yours > are correct. > > a) Select from rhnSet was not restricted to user so it might interfere > with other users SSM servers. > > b) Two servers in SSM and three channels: > server1 subscribed to config1 and config2 > server2 is subscribed only to config1 > (no server subscribed to config3) > query returns only config3 while it should have return config2, config3. > > So I went ahead and rewrote queries completely, please check whether > they work for you. (Commits a0ac26914ef0c80202dc0d707966ec34f523053e and > d50e60bc201b11c7b23c7f7eb06f6a58ee593fb0) Yes, that's right, thanks for the investigation. I tested your new queries and they seem to do the right thing now, finally. Thank you, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [Patch] fix size of kernel_options field for autoinstallation
Hi, the field in the web UI for the kernel_options is limited to 64 characters. In practice that's not needed. The attached patch solves that by increasing it to 1024 -- ciao, Uwe Gansert SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer Home: http://www.suse.de/~ug - Blog: http://suse.gansert.net listening to: "Snuff Machinery 2007" by Sitd commit a1c929ae44fd80b6cd77d5bf55286873df11dc11 Author: Uwe Gansert Date: Mon Jul 18 13:48:52 2011 +0200 changed kernel-params field to 1024 chars in size (bnc#698166) diff --git a/java/code/webapp/WEB-INF/pages/common/fragments/kickstart/advanced/details.jspf b/java/code/webapp/WEB-INF/pages/common/fragments/kickstart/advanced/details.jspf index be94c2b..7e2e5c8 100644 --- a/java/code/webapp/WEB-INF/pages/common/fragments/kickstart/advanced/details.jspf +++ b/java/code/webapp/WEB-INF/pages/common/fragments/kickstart/advanced/details.jspf @@ -56,12 +56,12 @@ - + - + ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [Patch] fix size of kernel_options field for autoinstallation
On 25.04.2012 16:24, Tomas Lestach wrote: - I believe cobbler cannot handle more than 255 long kernel options I'm not aware of such a limit and a quick test showed that at least 320 chars work :) - the change is done on one place only , what about the other occurences, f.e. java/code/webapp/WEB-INF/pages/kickstart/kickstartdetails.jsp ? that's already on 1024 in your git since 2009 -- ciao, Uwe Gansert SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer Home: http://www.suse.de/~ug - Blog: http://suse.gansert.net listening to: "Lucid" by God Module ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] build rhnpush on openSUSE
Hi,
here is the patch to build rhnpush on openSUSE.
0009-build-rhnpush-on-SUSE.patch:
- only some specfile modifications
--
Regards,
Michael Calmer
--
Michael Calmer
SUSE LINUX Products GmbH, Maxfeldstr. 5, D-90409 Nuernberg
T: +49 (0) 911 74053 0
F: +49 (0) 911 74053575 - e-mail: michael.cal...@suse.com
--
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
From ae5b4c241c5937c0560f7cca3b190e4b1b32e00f Mon Sep 17 00:00:00 2001
From: Michael Calmer
Date: Mon, 4 Apr 2011 16:26:21 +0200
Subject: [PATCH 09/17] build rhnpush on SUSE
- modify the specfile
---
client/tools/rhnpush/rhnpush.spec |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/client/tools/rhnpush/rhnpush.spec b/client/tools/rhnpush/rhnpush.spec
index 43f0008..b81784e 100644
--- a/client/tools/rhnpush/rhnpush.spec
+++ b/client/tools/rhnpush/rhnpush.spec
@@ -19,6 +19,7 @@ Requires: up2date
Requires: rhn-client-tools
%endif
BuildRequires: docbook-utils, gettext
+BuildRequires: python-devel
Summary: Package uploader for the Red Hat Network Satellite Server
@@ -46,6 +47,8 @@ rm -rf $RPM_BUILD_ROOT
%files
%defattr(-,root,root)
+%dir %{rhnroot}
+%dir %{_sysconfdir}/sysconfig/rhn
%dir %{rhnroot}/rhnpush
%{rhnroot}/rhnpush/*
%attr(755,root,root) %{_bindir}/rhnpush
--
1.7.3.4
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] Synchronization to Software Profiles
Hello, I fixed a subtle bug in the spacewalk web UI that caused the scheduling of a system's synchronization to a software profile to not work anymore. The patch in the attachment should fix the problem. For reproducing the problem first go to Systems and select a system. Then go to Software -> Packages -> Profiles, create a profile, compare to it and try to sync. Thank you, Johannes -- SUSE LINUX Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) >From 405d0933e065f94db7f648bbc2a91fdc173fdff0 Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Fri, 29 Jul 2011 14:59:57 +0200 Subject: [PATCH] Fix software rollback to profiles --- .../details/packages/profiles/syncprofile.jsp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/java/code/webapp/WEB-INF/pages/systems/details/packages/profiles/syncprofile.jsp b/java/code/webapp/WEB-INF/pages/systems/details/packages/profiles/syncprofile.jsp index 359667b..5f891b9 100644 --- a/java/code/webapp/WEB-INF/pages/systems/details/packages/profiles/syncprofile.jsp +++ b/java/code/webapp/WEB-INF/pages/systems/details/packages/profiles/syncprofile.jsp @@ -72,7 +72,7 @@ -" + -- 1.7.3.4 ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] fix for wrong transaction name
Hi,
please have a look at the attached patch. I think this was a copy and paste
bug, or is there a reason, why a transaction with a different name is rolled
back than started?
--
Regards
Michael Calmer
--
Michael Calmer
SUSE LINUX Products GmbH, Maxfeldstr. 5, D-90409 Nuernberg
T: +49 (0) 911 74053 0
F: +49 (0) 911 74053575 - e-mail: michael.cal...@suse.com
--
SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer
HRB 16746 (AG Nürnberg)
From 6a1fcba3370deb52c6e12c1cdc08b75c7a1b7ede Mon Sep 17 00:00:00 2001
From: Michael Calmer
Date: Tue, 5 Jun 2012 11:47:33 +0200
Subject: [PATCH] fix wrong transaction name in unsubscribe_channels
---
backend/server/rhnChannel.py |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/backend/server/rhnChannel.py b/backend/server/rhnChannel.py
index 2c9aad7..a48bbf2 100644
--- a/backend/server/rhnChannel.py
+++ b/backend/server/rhnChannel.py
@@ -1846,7 +1846,7 @@ def unsubscribe_channels(server_id, channels):
for channel in child_channels + base_channels:
ret = unsubscribe_sql(server_id, channel["id"], 0)
if not ret:
-rhnSQL.rollback("unsub_all_channels")
+rhnSQL.rollback("unsub_channels")
raise rhnFault(36, "Could not unsubscribe server %s "\
"from channel %s" % (server_id, channel["label"]))
--
1.7.3.4
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] UpdateErrataCacheCommand: log an error when orgId is incorrect
See attached patch.
Previously a NPE would be generated, but since the stack trace is not
very useful as it can only go back until run(), it only polluted test
outputs. I think that logging the error makes more sense in this case.
Regards,
--
Silvio Moioli
SUSE LINUX Products GmbH
Maxfeldstraße 5, 90409 Nürnberg Germany
>From 5a061de30a4c26acb841a65cfe8314f712b9f967 Mon Sep 17 00:00:00 2001
From: Silvio Moioli
Date: Wed, 4 Sep 2013 13:34:31 +0200
Subject: [PATCH] UpdateErrataCacheCommand: log an error when orgId is
incorrect
---
.../redhat/rhn/manager/errata/cache/UpdateErrataCacheCommand.java| 5 +
1 file changed, 5 insertions(+)
diff --git a/java/code/src/com/redhat/rhn/manager/errata/cache/UpdateErrataCacheCommand.java b/java/code/src/com/redhat/rhn/manager/errata/cache/UpdateErrataCacheCommand.java
index 1697aad..0b2612b 100644
--- a/java/code/src/com/redhat/rhn/manager/errata/cache/UpdateErrataCacheCommand.java
+++ b/java/code/src/com/redhat/rhn/manager/errata/cache/UpdateErrataCacheCommand.java
@@ -68,6 +68,11 @@ public class UpdateErrataCacheCommand extends BaseTransactionCommand {
Org org = OrgFactory.lookupById(orgId);
+if (org == null) {
+log.error("Org with id " + orgId + " was not found");
+return;
+}
+
int count = ErrataCacheManager.countServersInQueue(org);
if (log.isDebugEnabled()) {
--
1.8.1.4
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] AuthFilterTest: mocked request object updated
AuthFilterTest was failing in our setup, apparently because the mocked
request object was missing some methods that were added after the test
itself was written. I added those methods and now it passes.
See attached patch.
Regards,
--
Silvio Moioli
SUSE LINUX Products GmbH
Maxfeldstraße 5, 90409 Nürnberg Germany
>From 50ee6b949de7574f92ed87862ad35f8d6b4c7be5 Mon Sep 17 00:00:00 2001
From: Silvio Moioli
Date: Tue, 10 Sep 2013 16:53:47 +0200
Subject: [PATCH 12/22] AuthFilterTest: mocked request object updated
---
.../src/com/redhat/rhn/frontend/servlets/test/AuthFilterTest.java | 6 ++
1 file changed, 6 insertions(+)
diff --git a/java/code/src/com/redhat/rhn/frontend/servlets/test/AuthFilterTest.java b/java/code/src/com/redhat/rhn/frontend/servlets/test/AuthFilterTest.java
index 84e26e6..b33cfd0 100644
--- a/java/code/src/com/redhat/rhn/frontend/servlets/test/AuthFilterTest.java
+++ b/java/code/src/com/redhat/rhn/frontend/servlets/test/AuthFilterTest.java
@@ -88,6 +88,12 @@ public class AuthFilterTest extends MockObjectTestCase {
mockRequest.stubs().method("getMethod")
.will(returnValue(new String("GET")));
+mockRequest.stubs().method("getAttribute").with(eq("session"))
+.will(returnValue(null));
+mockRequest.stubs().method("setAttribute").withAnyArguments();
+mockRequest.stubs().method("getCookies")
+.will(returnValue(null));
+
filter.setAuthenticationService((AuthenticationService)mockAuthService.proxy());
}
--
1.8.1.4
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] VirtualGuestsActionTest: do not rely on query string parameter ordering
Hi,
The attached patch relaxes an assertion condition not to require a
certain query string parameter order, which was in fact not respected in
our test environment.
Regards,
--
Silvio Moioli
SUSE LINUX Products GmbH
Maxfeldstraße 5, 90409 Nürnberg Germany
>From e029423a883b311509addc1cc25508640dae7ae5 Mon Sep 17 00:00:00 2001
From: Silvio Moioli
Date: Wed, 11 Sep 2013 13:55:09 +0200
Subject: [PATCH 16/22] VirtualGuestsActionTest: do not rely on query string
parameter ordering
---
.../action/systems/virtualization/test/VirtualGuestsActionTest.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/java/code/src/com/redhat/rhn/frontend/action/systems/virtualization/test/VirtualGuestsActionTest.java b/java/code/src/com/redhat/rhn/frontend/action/systems/virtualization/test/VirtualGuestsActionTest.java
index 1626d7e..4533b03 100644
--- a/java/code/src/com/redhat/rhn/frontend/action/systems/virtualization/test/VirtualGuestsActionTest.java
+++ b/java/code/src/com/redhat/rhn/frontend/action/systems/virtualization/test/VirtualGuestsActionTest.java
@@ -99,7 +99,7 @@ public class VirtualGuestsActionTest extends RhnPostMockStrutsTestCase {
requestParams);
verifyNoActionMessages();
-assertTrue(getActualForward().endsWith("actionName=delete"));
+assertTrue(getActualForward().contains("actionName=delete"));
assertTrue(getActualForward().indexOf("guestSettingValue") <= 0);
// Test some of the base list buttons
--
1.8.1.4
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] ActivationKeyHandlerTest: expect correct exceptions
ActivationKeyHandlerTest expected InvalidEntitlementException where
actually FaultException gets thrown. I updated the testcase.
See attached patch.
Regards,
--
Silvio Moioli
SUSE LINUX Products GmbH
Maxfeldstraße 5, 90409 Nürnberg Germany
>From 72b582c013959eb7efc45c57b05c76e7ff4bb654 Mon Sep 17 00:00:00 2001
From: Silvio Moioli
Date: Tue, 10 Sep 2013 17:09:03 +0200
Subject: [PATCH 13/22] ActivationKeyHandlerTest: expect correct exceptions
---
.../frontend/xmlrpc/activationkey/test/ActivationKeyHandlerTest.java | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/java/code/src/com/redhat/rhn/frontend/xmlrpc/activationkey/test/ActivationKeyHandlerTest.java b/java/code/src/com/redhat/rhn/frontend/xmlrpc/activationkey/test/ActivationKeyHandlerTest.java
index 4c72908..d663666 100644
--- a/java/code/src/com/redhat/rhn/frontend/xmlrpc/activationkey/test/ActivationKeyHandlerTest.java
+++ b/java/code/src/com/redhat/rhn/frontend/xmlrpc/activationkey/test/ActivationKeyHandlerTest.java
@@ -41,7 +41,6 @@ import com.redhat.rhn.domain.token.ActivationKey;
import com.redhat.rhn.domain.token.TokenPackage;
import com.redhat.rhn.domain.token.test.ActivationKeyTest;
import com.redhat.rhn.frontend.xmlrpc.InvalidChannelException;
-import com.redhat.rhn.frontend.xmlrpc.InvalidEntitlementException;
import com.redhat.rhn.frontend.xmlrpc.MissingEntitlementException;
import com.redhat.rhn.frontend.xmlrpc.activationkey.ActivationKeyHandler;
import com.redhat.rhn.frontend.xmlrpc.serializer.ActivationKeySerializer;
@@ -174,7 +173,7 @@ public class ActivationKeyHandlerTest extends BaseHandlerTestCase {
new Integer(0), badEntitlements, Boolean.FALSE);
fail();
}
-catch (InvalidEntitlementException iee) {
+catch (FaultException fe) {
// expected
}
}
@@ -187,7 +186,7 @@ public class ActivationKeyHandlerTest extends BaseHandlerTestCase {
new Integer(0), badEntitlements, Boolean.FALSE);
fail();
}
-catch (InvalidEntitlementException iee) {
+catch (FaultException fe) {
// expected
}
}
--
1.8.1.4
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] KickstartScriptActionTest: missing parameters added
Apparently some form parameters were missing and the test failed, at
least in our environment.
See attached patch.
Regards,
--
Silvio Moioli
SUSE LINUX Products GmbH
Maxfeldstraße 5, 90409 Nürnberg Germany
>From ee35bec77661fbe7c2a19f81f24ee2295732 Mon Sep 17 00:00:00 2001
From: Silvio Moioli
Date: Fri, 6 Sep 2013 16:09:34 +0200
Subject: [PATCH 03/22] KickstartScriptActionTest: missing parameters added
---
.../frontend/action/kickstart/test/KickstartScriptActionTest.java| 5 +
1 file changed, 5 insertions(+)
diff --git a/java/code/src/com/redhat/rhn/frontend/action/kickstart/test/KickstartScriptActionTest.java b/java/code/src/com/redhat/rhn/frontend/action/kickstart/test/KickstartScriptActionTest.java
index 0847893..c962ad3 100644
--- a/java/code/src/com/redhat/rhn/frontend/action/kickstart/test/KickstartScriptActionTest.java
+++ b/java/code/src/com/redhat/rhn/frontend/action/kickstart/test/KickstartScriptActionTest.java
@@ -89,6 +89,9 @@ public class KickstartScriptActionTest extends BaseKickstartEditTestCase {
KickstartScript.TYPE_POST);
addRequestParameter(KickstartScriptCreateAction.SUBMITTED,
Boolean.TRUE.toString());
+addRequestParameter(KickstartScriptCreateAction.SCRIPTNAME,
+RandomStringUtils.randomAscii(20));
+
setRequestPathInfo("/kickstart/KickstartScriptCreate");
actionPerform();
String[] keys = {"kickstart.script.success"};
@@ -127,6 +130,8 @@ public class KickstartScriptActionTest extends BaseKickstartEditTestCase {
KickstartScript.TYPE_POST);
addRequestParameter(KickstartScriptCreateAction.SUBMITTED,
Boolean.TRUE.toString());
+addRequestParameter(KickstartScriptCreateAction.SCRIPTNAME,
+RandomStringUtils.randomAscii(20));
KickstartScript kss = ksdata.getScripts().iterator().next();
addRequestParameter(RequestContext.KICKSTART_SCRIPT_ID, kss.getId().toString());
setRequestPathInfo("/kickstart/KickstartScriptEdit");
--
1.8.1.4
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk
On 01/08/2014 02:34 PM, Michael Mraka wrote: As it's new feature in spacewalk I'd vote for using current latest version of pwstrength-bootstrap. Okay, I'll work out a new patch with the latest version in the following days. I understand it. In such cases where we need to modify upstream sources we put upstream package spec to spec-tree/ and create patches to it. This let's us easily keep our modifications and re-apply it on new upstream versions whenever wee need. See e.g. spec-tree/stringtree-json in spacewalk.git. I see. I'll also try to provide a spec file plus a patch to use for the sources then. Isn't https://github.com/ablanco/jquery.pwstrength.bootstrap/blob/master/dist/pwstrength-bootstrap-1.0.2.js all we need to distribute? Yes you are right, this is the one to use. -- -- Mit freundlichen Grüßen, Maximilian Meister SLE Systems Management SUSE LINUX Products GmbH Maxfeldstr. 5 D-90409 Nuremberg, Germany http://www.suse.com GF: Jeff Hawn, Jennifer Guild, Felix Imendoerffer, HRB 21284 (AG Nuremberg) ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] fix display of static snippets
On 01.12.2011 13:54, Jan Pazdziora wrote: On Thu, Dec 01, 2011 at 01:44:25PM +0100, Uwe Gansert wrote: the read only snippets in the web ui need HTML/XML escaping. Especially AutoYaST XML snippets tend to be displayed wrong in the UI without escaping Shouldn't we rather do this in the .jsp? you mean in the jsp? That should work too I guess. I just had the impression all "work" is done in the java files and so I did it directly there. jsp is fine with me -- ciao, Uwe Gansert SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer Home: http://www.suse.de/~ug - Blog: http://suse.gansert.net ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] UpdateErrataCacheCommand: log an error when orgId is incorrect
On 09/09/2013 10:03 AM, Tomas Lestach wrote: > So, what is the motivation of this change? > (The only scenario I can imagine is, that the errata cache event will be > queued and its organization gets deleted before the background errata cache > action gets executed.) I think that is exactly the case, as we see many such NPEs in the unit tests' standard output. AFAIU this happens since BaseTestCaseWithUser sets up and deletes a new Org for every testsuite, so any pending operation on the errata cache can fail depending on timing. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Things that needs to be dobne before next release.
On 09/01/14 13:26, Matej Kollar wrote: > Major things that we currently consider release blockers for 2.1 > from UI point of view are: > > * Things from [1] > * Date picker > * Human readable dates For this one, I was blocked by the perl list, for which I just sent a second patch. If anyone has cycles, it would be good to check that the list is styled correctly for the other list sub-types. > * Confirm pages > * Bare-metal systems management -- Duncan Mac-Vicar P. - http://www.suse.com/ SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) Maxfeldstraße 5, 90409 Nürnberg, Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] support for weak dependencies
Hi, Am Mittwoch, 9. März 2011, 11:11:08 schrieb Jan Pazdziora: > On Mon, Mar 07, 2011 at 01:24:54PM +0100, Michael Calmer wrote: > > Hello, [...] > Michael, > > when I apply the patches to Spacewalk nightly and try rhnpush (of > openSUSE rpm or Spacewalk rpm), > I get the following traceback: [...] > Could you please investigate? Do you need list of rpms I have > installed or something? rpm upstream has not yet enabled the suggests and enhances flags. This is the reason, why it failes if you use rpm from Fedora/RedHat. SUSE has a patch in rpm which enables these flags. I need to try to use the integers for the RPMTAG_* values directly. I send a new patchset as soon I have implemented and tested it. -- Regards, Michael Calmer -- Michael Calmer SUSE LINUX Products GmbH, Maxfeldstr. 5, D-90409 Nuernberg T: +49 (0) 911 74053 0 F: +49 (0) 911 74053575 - e-mail: michael.cal...@suse.com -- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] small fix for spacewalk-backend
Hi, and now the last one :-) I found a small issue in spacewalk-backend, where the locale files are installed in duplicate buildroot environment. In backend/po/Makefile, localedir is defined as $(PREFIX)/usr/share/locale and in the install section files are installed to $(PREFIX)/$(localedir) . -- Regards, Michael Calmer -- Michael Calmer SUSE LINUX Products GmbH, Maxfeldstr. 5, D-90409 Nuernberg T: +49 (0) 911 74053 0 F: +49 (0) 911 74053575 - e-mail: michael.cal...@suse.com -- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) From 20cb8563e6e1359aae1b97109cdb8bb51f418b74 Mon Sep 17 00:00:00 2001 From: Michael Calmer Date: Fri, 8 Apr 2011 10:33:32 +0200 Subject: [PATCH 15/17] remove duplicate PREFIX for locale installation --- backend/po/Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/backend/po/Makefile b/backend/po/Makefile index 728e908..f5c3c82 100644 --- a/backend/po/Makefile +++ b/backend/po/Makefile @@ -4,7 +4,7 @@ TOP = .. SUBDIR = locale -localedir = $(PREFIX)/usr/share/locale +localedir = /usr/share/locale include $(TOP)/Makefile.defs -- 1.7.3.4 ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] fix display of static snippets
Hi,
the read only snippets in the web ui need HTML/XML escaping.
Especially AutoYaST XML snippets tend to be displayed wrong in the UI
without escaping
Patch attached
--
ciao, Uwe Gansert
SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg)
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer
Home: http://www.suse.de/~ug - Blog: http://suse.gansert.net
diff --git a/java/code/src/com/redhat/rhn/domain/kickstart/cobbler/CobblerSnippet.java b/java/code/src/com/redhat/rhn/domain/kickstart/cobbler/CobblerSnippet.java
index fbb44b6..3d93642 100644
--- a/java/code/src/com/redhat/rhn/domain/kickstart/cobbler/CobblerSnippet.java
+++ b/java/code/src/com/redhat/rhn/domain/kickstart/cobbler/CobblerSnippet.java
@@ -196,10 +196,22 @@ public class CobblerSnippet implements Comparable {
* @return String to get
*/
public String getContents() {
+ String result = null;
+
if (path.exists()) {
-return FileUtils.readStringFromFile(path.getAbsolutePath());
+ result = FileUtils.readStringFromFile(path.getAbsolutePath());
+ if (!isEditable()) {
+ /*
+ * HTML escape Snippets
+ * only needed for the read-only display in the web ui
+ */
+ result = result.replace("&", "&");
+ result = result.replace("<", "<");
+ result = result.replace(">", ">");
+
+ }
}
-return null;
+return result;
}
/**
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Bug about cloned channels and errata
On 03/08/2012 04:04 PM, Tomas Lestach wrote: >> So, AFAICS the rhnServerNeededCache table is there for caching which errata >> need to be applied to a system together with the respective package ids. So >> I don't really see how it makes sense to insert rows in there with errata >> id == null. > > The reason is that importing errata packages into the Spacewalk server isn't > the only option, how to populate you channels. > You may push packages into your Spacewalk server using rhnpush or you may get > a package into your channel from another channel. > In these cases those packages may be valid updates for your servers, however > they're not associated with any errata. > For these cases errata_id is null. > > Regards, > Tomas Well, in this case everything is probably fine as it is right now and we don't need to patch anything. Thanks, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Avoid a possible concurrency issue on RhnSet update
On 09/05/2013 02:26 AM, Jan Pazdziora wrote: > Please note that this will not work -- the fact that you check content > of some table in your session and your transaction and based on that > run the insert operation does not mean that the other session cannot > do exactly the same, both will find the record not there, and you will > get the ORA-1 anyway. Good point: actually I was thinking about that statement being the only one in its transaction, but that's actually not the case. I think I will do as Thomas suggested, handling exceptions better in order to be as safe as possible when ignoring them, yet accepting failures in this specific case. I will be back with a patch as soon as I have tested it. Thanks for the discussion by the way, as problems in this topic are traditionally difficult to handle! Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Less compiler package to use
On 10/22/2013 01:05 PM, Tomáš Kašpárek wrote:
> Hello Johannes,
>
> I've discovered issue in 12ce0476ba547fade1cbe3819e77fd560de7fdb0 which
> causes RPM build errors
> during build time.
>
> RPM build errors:
> File not found:
> /root/rpmbuild/BUILDROOT/spacewalk-branding-2.1.5-1.git.233.e7a7524.el6.x86_64/var/www/html/css
> File not found by glob:
> /root/rpmbuild/BUILDROOT/spacewalk-branding-2.1.5-1.git.233.e7a7524.el6.x86_64/var/www/html/css/*
>
> cp -pR css %{buildroot}/%{_var}/www/html/ copied whole css directory to
> /%{_var}/www/html efectively
> making it /%{_var}/www/html/css.
>
> cp -p css/*.css %{buildroot}/%{_var}/www/html/ takes matched files and copies
> them into
> /%{_var}/www/html/ throwing away the fact they were placed in css directory.
>
> Sending you patch which fixes the problem.
Ah yes, I see. Thank you very much for testing it! I applied your patch and
hope that
the package builds and works fine apart from that.
Thanks,
Johannes
--
SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg)
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] Fix the Java package of DeleteGroupAction class
Hello, here is another micropatch fixing up a recent commit in master. The Java package needs to correspond with the filesystem path in any case. Thanks, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer >From 8e0a0192c54255e50a760887e1349d55492ab813 Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Wed, 18 Dec 2013 14:57:00 +0100 Subject: [PATCH] Fix the java package of DeleteGroupAction class --- .../src/com/redhat/rhn/frontend/action/groups/DeleteGroupAction.java| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/java/code/src/com/redhat/rhn/frontend/action/groups/DeleteGroupAction.java b/java/code/src/com/redhat/rhn/frontend/action/groups/DeleteGroupAction.java index 1bbc4ad..41161c4 100644 --- a/java/code/src/com/redhat/rhn/frontend/action/groups/DeleteGroupAction.java +++ b/java/code/src/com/redhat/rhn/frontend/action/groups/DeleteGroupAction.java @@ -12,7 +12,7 @@ * granted to use or replicate Red Hat trademarks that are incorporated * in this software or its documentation. */ -package com.redhat.rhn.frontend.action.token; +package com.redhat.rhn.frontend.action.groups; import com.redhat.rhn.domain.server.ManagedServerGroup; import com.redhat.rhn.frontend.struts.RequestContext; -- 1.8.1.4 ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Adding a password placeholder check when editing a user.
On 01/29/2014 01:19 PM, Maximilian Meister wrote: Hi Michael, I have tried this in my first attempt, but the html:password struts tag doesn't accept the attribute "placeholder="**". to reformulate my statement a bit, the html:password struts tag doesn't know any placeholder attribute. See: http://struts.apache.org/release/1.3.x/struts-taglib/tlddoc/html/password.html org.apache.jasper.JasperException: /WEB-INF/pages/common/fragments/user/edit_user_table_rows.jspf (line: 51, column: 12) Attribute placeholder invalid for tag password according to TLD What do you suggest? -- -- Mit freundlichen Grüßen, Maximilian Meister Systems Management Department SUSE LINUX Products GmbH Maxfeldstr. 5 D-90409 Nuremberg, Germany http://www.suse.com GF: Jeff Hawn, Jennifer Guild, Felix Imendoerffer, HRB 21284 (AG Nuremberg) ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] build spacewalk-remote-utils on openSUSE
Hi,
here is the patch to build spacewalk-remote-utils on openSUSE.
0012-build-spacewalk-remote-utils-on-SUSE.patch
- adding only one little dir to the filelist of the specfile
--
Regards,
Michael Calmer
--
Michael Calmer
SUSE LINUX Products GmbH, Maxfeldstr. 5, D-90409 Nuernberg
T: +49 (0) 911 74053 0
F: +49 (0) 911 74053575 - e-mail: michael.cal...@suse.com
--
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
From be0b18e181d32a2d20a586f1f07304d73ee3ad01 Mon Sep 17 00:00:00 2001
From: Michael Calmer
Date: Tue, 5 Apr 2011 11:00:52 +0200
Subject: [PATCH 12/17] build spacewalk-remote-utils on SUSE
- modify the specfile
---
.../spacewalk-remote-utils.spec|1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/client/tools/spacewalk-remote-utils/spacewalk-remote-utils.spec b/client/tools/spacewalk-remote-utils/spacewalk-remote-utils.spec
index 1057a89..451038b 100644
--- a/client/tools/spacewalk-remote-utils/spacewalk-remote-utils.spec
+++ b/client/tools/spacewalk-remote-utils/spacewalk-remote-utils.spec
@@ -45,6 +45,7 @@ docbook2man ./spacewalk-create-channel/doc/spacewalk-create-channel.sgml -o ./sp
%files
%defattr(-,root,root,-)
+%dir %{_datadir}/rhn
%{_bindir}/spacewalk-create-channel
#%{python_sitelib}/spacecmd/
%{_datadir}/rhn/channel-data/
--
1.7.3.4
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] Add missing string "systems.details.virt.actions.scheduled"
Hi,
The string mentioned in subject was apparently removed accidentally with
423cfc6: removing unused strings in StringResources
and has not been added back (to the *english* file) with
2605ec2: backported translation changes from zanata
It's still referenced from VirtualGuestsConfirmAction.java though, so the
attached patch puts it back in place.
Regards,
Johannes
--
SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg)
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer
>From d1a7f3acdecb7dbd988f0da5237c08d2cc2809f2 Mon Sep 17 00:00:00 2001
From: Johannes Renner
Date: Tue, 16 Apr 2013 15:03:41 +0200
Subject: [PATCH] Add missing string systems.details.virt.actions.scheduled
---
.../com/redhat/rhn/frontend/strings/java/StringResource_en_US.xml | 6 ++
1 file changed, 6 insertions(+)
diff --git a/java/code/src/com/redhat/rhn/frontend/strings/java/StringResource_en_US.xml b/java/code/src/com/redhat/rhn/frontend/strings/java/StringResource_en_US.xml
index b17baa9..7489b56 100644
--- a/java/code/src/com/redhat/rhn/frontend/strings/java/StringResource_en_US.xml
+++ b/java/code/src/com/redhat/rhn/frontend/strings/java/StringResource_en_US.xml
@@ -,6 +,12 @@ Follow this url to see the full list of inactive systems:
/rhn/system/details/virtualization/VirtualGuestsConfirm.do
+
+Scheduled {0} actions.
+
+ /rhn/system/details/virtualization/VirtualGuestsConfirm.do
+
+
No virtual systems deleted.
--
1.8.1.4
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] SUSE Studio API will stop working via unencrypted HTTP
Hello,
The SUSE Studio API will no longer process requests via unencrypted HTTP after
Jan 2014, see here:
http://blog.susestudio.com/2013/12/coming-soon-https-only-on-suse-studio.html
Therefore attached is a patch to change the default endpoint to use SSL.
Thank you,
Johannes
--
SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg)
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer
>From f523f1d0188c4094888513026478435db169ce3c Mon Sep 17 00:00:00 2001
From: Johannes Renner
Date: Wed, 22 Jan 2014 10:41:08 +0100
Subject: [PATCH] SUSE Studio API will stop working via unencrypted HTTP
---
.../com/redhat/rhn/frontend/action/user/UserCredentialsEditAction.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/java/code/src/com/redhat/rhn/frontend/action/user/UserCredentialsEditAction.java b/java/code/src/com/redhat/rhn/frontend/action/user/UserCredentialsEditAction.java
index 66efc89..72395f3 100644
--- a/java/code/src/com/redhat/rhn/frontend/action/user/UserCredentialsEditAction.java
+++ b/java/code/src/com/redhat/rhn/frontend/action/user/UserCredentialsEditAction.java
@@ -40,7 +40,7 @@ public class UserCredentialsEditAction extends RhnAction {
private static final String PARAM_USER = "studio_user";
private static final String PARAM_KEY = "studio_key";
private static final String PARAM_URL = "studio_url";
-private static final String DEFAULT_URL = "http://susestudio.com";;
+private static final String DEFAULT_URL = "https://susestudio.com";;
/** {@inheritDoc} */
@Override
--
1.8.4
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Query not elaborated?
Hi, Am Montag, 6. August 2012, 17:59:12 schrieb Tomas Lestach: > Hello Johannes, > > On Friday 03 of August 2012 12:44:11 Johannes Renner wrote: > > Hi, [...] > > So I am coming up with two patch proposals, since I am not really sure > > about how we are intended to solve the problem: > > > > - The first patch fixes it by calling elaborate() manually once > > I wouldn't call the elaborate method manually. Since the mechanism has > worked till now, I'd rather revert my original commit. > > spacewalk.git: 43fbb66782bebe62e5aa323bc5edf70276d2609b > > > - The second patch is a more generic fix and calls elaborate() in > > BaseManager.java even if PageControl is null > > What is the bug you try to fix with the 2nd patch? Could you describe the > misbehavior on a concrete page? Johannes is on vacation this week. I think he will answer as soon as he is back. I am not a java expert, but if I remember correctly we set a breakpoint in the elaborator and this was never reached. So our question was, if there is something wrong with the concept and the elaborator is never executed in this kind of usage. -- Regards Michael Calmer -- Michael Calmer SUSE LINUX Products GmbH, Maxfeldstr. 5, D-90409 Nuernberg T: +49 (0) 911 74053 0 F: +49 (0) 911 74053575 - e-mail: michael.cal...@suse.com -- SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer HRB 16746 (AG Nürnberg) ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Deployment of images built with SUSE Studio
On 05/18/2012 05:11 PM, Miroslav Suchy wrote: > In WebUI patch please do s/SUSE Manager/@@PRODUCT_NAME@@/ Sure, I will do that for the next version of the patches. Sorry for that. > When I enter credentials for Suse studio they are not validated. Can you > later add some code to do > some validation? I.e. do tome test connection and warn if it do not work? Yes, I already planned to add a button for testing the credentials later on. Probably not for this first release we are doing now, though. > I still have to test the client part. Thanks for the feedback so far. We will wait until you tested the client part, since you might come up with more feedback. -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] SSH Push Feature Proposal
On 24/04/13 14:38, Johannes Renner wrote: >> Frankly, the first scenario does not sound that interesting to me. >> Access to and from DMZ is typically closed from/to all other networks >> as well and only opened in a very targeted fashion. The IT of that >> organization would still need to allow access _to_ the DMZ to sshd >> ports on those machines. You can always have Spacewalk Proxy in If you put a system in a public cloud with ssh access and want to manage it from your internal Spacewalk server you are already in that scenario. -- Duncan Mac-Vicar P. - http://www.suse.com/ SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) Maxfeldstraße 5, 90409 Nürnberg, Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk
On 12/20/2013 05:15 PM, R P Herrold wrote: > This seems to pull in new dependencies, doesn't it? This merely adds some new Javascript files - that is standard practice in Spacewalk AFAIU, since packaging rules for Web resources in Fedora are still in draft and the Spacewalk community has not decided to adopt them yet: https://fedoraproject.org/wiki/JavaScript_libraries_packaging_guideline_draft > Also, how would this interact with non-local > authentication interfaces such as LDAP? It won't. This is just a client-side (in-browser, Javascript) clue to the user. All it does is giving basic suggestions on how to improve a password, it does not enforce any rule. Mandatory password complexity checks and the whole authentication code path is left untouched. HTH, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Date/Time picker
On 02/14/2014 03:16 PM, Michael Mraka wrote: > ">" should likely be "/>" otherwise it produce opening tags not self > closed tags. Actually in HTML5 void tags do not need the slash (it is optional). http://www.w3.org/TR/html-markup/syntax.html#void-element "self-closing" as a definition does not exist anymore in HTML5, except for SVG and MathML elements! We also recently started a discussion about this same topic and decided to stick to a coding standard rule to avoid confusion - namely not using those optional slashes in new code. I hope you are also fine with that. I was supposed to start a discussion with you in the next days, but this was faster :-) Thanks, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Synchronization to Software Profiles
On 07/29/2011 04:33 PM, Cliff Perry wrote: > On 07/29/2011 09:55 AM, Johannes Renner wrote: >> Hello, >> >> I fixed a subtle bug in the spacewalk web UI that caused the scheduling >> of a system's synchronization to a software profile to not work anymore. >> The patch in the attachment should fix the problem. > > Good catch. Do you know if there is a bugzilla (Satellite or Spacewalk or > Manager) which reported > this issue? > > Thanks, > Cliff I do not know about a bugzilla item on the redhat bugzilla and I couldn't find any during a quick search. There is one on the bugzilla at novell, but this is unfortunately not open to the public. Shall I create one on redhat.bugzilla.com? Greetings, Johannes >> >> For reproducing the problem first go to Systems and select a system. Then >> go to Software -> Packages -> Profiles, create a profile, compare to it >> and try to sync. >> >> Thank you, >> Johannes -- SUSE LINUX Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] xen distro inherits kernel options
Hi,
I noticed that the XEN distro which is automatically created if
possible, when you add a kickstartable tree, does not inherit the
kernel/post-kernel parameters from the original distro.
So the user has no chance to change the kopts for that distro, except
with the cobbler CLI.
Here is a simple patch that copies the kopts to the xen distro.
--
ciao, Uwe Gansert
SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg)
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer
Home: http://www.suse.de/~ug - Blog: http://suse.gansert.net
listening to: "No Voices" by THYX
diff --git a/java/code/src/com/redhat/rhn/manager/kickstart/tree/BaseTreeEditOperation.java b/java/code/src/com/redhat/rhn/manager/kickstart/tree/BaseTreeEditOperation.java
index 7fee82e..a2c1b10 100644
--- a/java/code/src/com/redhat/rhn/manager/kickstart/tree/BaseTreeEditOperation.java
+++ b/java/code/src/com/redhat/rhn/manager/kickstart/tree/BaseTreeEditOperation.java
@@ -95,11 +95,16 @@ public abstract class BaseTreeEditOperation extends BasePersistOperation {
Distro distro = Distro.lookupById(CobblerXMLRPCHelper.getConnection(
this.getUser()), tree.getCobblerId());
+Distro xen_distro = Distro.lookupById(CobblerXMLRPCHelper.getConnection(
+ this.getUser()), tree.getCobblerXenId());
Map kOpts = distro.getKernelOptions();
distro.setKernelOptions(getKernelOptions());
distro.setKernelPostOptions(getPostKernelOptions());
distro.save();
+xen_distro.setKernelOptions(getKernelOptions());
+xen_distro.setKernelPostOptions(getPostKernelOptions());
+xen_distro.save();
}
catch (XmlRpcException xe) {
HibernateFactory.rollbackTransaction();
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Use braces for accessing composite types in PG
On 10/31/2012 05:00 PM, Tomas Lestach wrote: > On Wednesday 31 of October 2012 14:38:49 Johannes Renner wrote: >> Hey, >> >> Ok, here is the patch to make the rewritten query work with PG as well (API >> call 'system.listLatestUpgradablePackages'). It's actually a follow up to >> this commit: >> >> 4823565b2e634bc73010d366ff82c432630bca85 >> > > Committed as: 594781171402e28f85cdcb9fe7e838e35288a505 > >> It was strange though when testing it: for most of my systems it returned >> really quick (with 0 results though), but I also had one system, where the >> query did not return at all, even after 1 hour! You might want to do some >> additional performance testing here. There was nothing special about this >> specific host though, it was even subscribed to a base channel only.. > > Can you still reproduce it with that system? I could reproduce it until I cherry-picked your most recent fix from master: 1168f61a9d16b42b533a21513c8538529862e745 The fixed query now runs reasonably fast and delivers results immediately for that specific system. So I'd consider this issue as fixed. Thanks, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Naming of cloned errata
On 03/07/2012 11:57 AM, Johannes Renner wrote: > On 03/06/2012 05:42 PM, Johannes Renner wrote: >> Hey, >> >> I want to propose a change concerning the names of cloned errata. >> Currently, names of cloned errata are generated like this: >> >> String clonedAdvisoryName = "CL" + published.getAdvisoryName().substring(3); >> String clonedAdvisory = "CL" + published.getAdvisory().substring(3); >> >> The reason for doing it like this might have been a small sized field in the >> database, but AFAIK we already upstreamed a patch to enlarge the respective >> field. Since cloned errata currently end up with rather strange names, I >> would like to propose to do the naming like this instead: >> >> String clonedAdvisoryName = "CL-" + published.getAdvisoryName(); >> String clonedAdvisory = "CL-" + published.getAdvisory(); >> >> Even the classification used for the Red Hat patches (E, S and B) gets lost >> when removing the first 3 characters, since names start with RH(E|S|B). So >> please tell me if I am missing any reason to keep the old naming scheme. >> >> Attached please find my proposed patch for spacewalk master. > > Of course this algorithm is duplicated in the perl parts of Spacewalk ;-) > Patch is attached. Just reactivating/raising this thread on the list since there is no comments yet, and I'm curious if you will accept the proposed changes or not. Thanks, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] build rhn-custom-info on openSUSE
Hi,
here is the patch to build rhn-custom-info on openSUSE.
0008-build-rhn-custom-info-on-SUSE.patch:
- only some specfile modifications
--
Regards,
Michael Calmer
--
Michael Calmer
SUSE LINUX Products GmbH, Maxfeldstr. 5, D-90409 Nuernberg
T: +49 (0) 911 74053 0
F: +49 (0) 911 74053575 - e-mail: michael.cal...@suse.com
--
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
From f6aab93e04de6dbcb18bc27b2b75cc1f8b0cb1a7 Mon Sep 17 00:00:00 2001
From: Michael Calmer
Date: Mon, 4 Apr 2011 16:13:39 +0200
Subject: [PATCH 08/17] build rhn-custom-info on SUSE
- modify the specfile
---
client/tools/rhncustominfo/rhn-custom-info.spec |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/client/tools/rhncustominfo/rhn-custom-info.spec b/client/tools/rhncustominfo/rhn-custom-info.spec
index e6adbf5..f1638e5 100644
--- a/client/tools/rhncustominfo/rhn-custom-info.spec
+++ b/client/tools/rhncustominfo/rhn-custom-info.spec
@@ -21,8 +21,12 @@ Requires: rhnlib
%if 0%{?rhel} >= 5 || 0%{?fedora} >= 1
Requires: yum-rhn-plugin
%else
+%if 0%{?suse_version}
+Requires: zypp-plugin-spacewalk
+%else
Requires: up2date
%endif
+%endif
%description
Allows for the setting and listing of custom key/value pairs for
@@ -46,6 +50,7 @@ rm -rf $RPM_BUILD_ROOT
%files
%defattr(-,root,root,-)
+%dir %{_datadir}/rhn
%{_bindir}/rhn-custom-info
%dir %{_datadir}/rhn/custominfo
%{_datadir}/rhn/custominfo/rhn-custom-info.py*
--
1.7.3.4
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] CVEs missing in the security patches listing (on Oracle 11)
Hey,
apparently the method getColumnLabel() of class ResultSetMetaData returns the
column
label in uppercase with Oracle 11 (using ojdbc5.jar). Therefore an
equals("cve") in
SecurityErrataOverview.java is not sufficient anymore and leads to an empty
"CVEs"
column in the listing of relevant security errata:
https:///rhn/errata/RelevantSecurityErrata.do
The attached patch fixes the problem by replacing equals with
equalsIgnoreCase().
Regards,
Johannes
--
SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg)
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer
>From dd9bf777412f470c7a8fee58408b495036f0d55b Mon Sep 17 00:00:00 2001
From: Johannes Renner
Date: Fri, 17 Aug 2012 12:06:49 +0200
Subject: [PATCH] Fix missing CVEs in patches listing with Oracle 11
---
.../rhn/frontend/dto/SecurityErrataOverview.java |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/java/code/src/com/redhat/rhn/frontend/dto/SecurityErrataOverview.java b/java/code/src/com/redhat/rhn/frontend/dto/SecurityErrataOverview.java
index 070d561..62a0db1 100644
--- a/java/code/src/com/redhat/rhn/frontend/dto/SecurityErrataOverview.java
+++ b/java/code/src/com/redhat/rhn/frontend/dto/SecurityErrataOverview.java
@@ -52,7 +52,7 @@ public class SecurityErrataOverview extends ErrataOverview
// expected errata_cves_elab returns 2 columns
if (columnCount < 3) {
for (int i = 1; i <= columnCount; i++) {
-if (meta.getColumnLabel(i).equals("cve")) {
+if (meta.getColumnLabel(i).equalsIgnoreCase("cve")) {
String cve = rs.getString("cve");
if (cve != null) {
addCve(cve);
--
1.7.7
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Timezone problem with DB timestamps
On 02/15/2013 09:55 AM, Tomas Lestach wrote: > On Wednesday 13 of February 2013 11:04:46 Johannes Renner wrote: >> On 08/01/2012 06:04 PM, Tomas Lestach wrote: >>> Hello Johannes, >>> >>> I somehow misread the javadoc you linked in your original e-mail. >>> I made some quick tests and applied your original patch. :-) >>> >>> spacewalk.git: 3bc5907dd0f669fb391701188055102433d65e9f >> >> It looks like we might have to rollback the above commit: >> >> We got a bugreport stating that the schedule tab shows all scheduled >> action times in GMT, no matter what timezone the user has configured. >> We could reproduce this only on Oracle based installations though, >> apparently the GMT conversion in the above commit does not really >> work when using the Postgres JDBC driver.. >> >> Attached is a patch rolling back the above commit, but fixing the >> package build times by interpreting them as GMT. These are written >> to the DB as GMT, as you can see here: >> >> /backend/server/importlib/headerSource.py (line 59) >> >> ... >> # A UNIX timestamp >> val = gmtime(val) >> ... >> >> Regards, >> Johannes > > Hello Johannes, > > I committed your patch as: d4bdf37b4c666435047a86907955e8d9b7dd6369 > Additionally I fixed the checkstyle issues. Thanks, and sorry for that checkstyle issue. Regards, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] Fix ISE when UUID and host ID is null
Hello,
I found an error navigating to:
https:///rhn/systems/VirtualSystemsList.do
In my setup there is only one registered system that does not have a UUID and
also
the virtual host system is unknown to the Spacewalk server in this case:
- current.getUuid() == null
- current.getHostSystemId() == null
So I think we should not actually do
"current.setSystemId(current.getHostSystemId());"
here. The attached patch fixes the problem for me (in [1]) and also makes sense
IMO.
Thank you and regards,
Johannes
[1] VirtualSystemsListSetupAction.java
--
SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg)
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer
>From 1e0f80e4b6f43ade890dd3dae2a71bb4544dff01 Mon Sep 17 00:00:00 2001
From: Johannes Renner
Date: Fri, 19 Jul 2013 13:39:51 +0200
Subject: [PATCH] Fix ISE when UUID and host ID is null
---
.../rhn/frontend/action/systems/VirtualSystemsListSetupAction.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/java/code/src/com/redhat/rhn/frontend/action/systems/VirtualSystemsListSetupAction.java b/java/code/src/com/redhat/rhn/frontend/action/systems/VirtualSystemsListSetupAction.java
index b6252ad..5e8a0fe 100644
--- a/java/code/src/com/redhat/rhn/frontend/action/systems/VirtualSystemsListSetupAction.java
+++ b/java/code/src/com/redhat/rhn/frontend/action/systems/VirtualSystemsListSetupAction.java
@@ -63,7 +63,7 @@ public class VirtualSystemsListSetupAction extends BaseSystemListSetupAction {
if (current.isFakeNode()) {
continue;
}
-else if (current.getUuid() == null) {
+else if (current.getUuid() == null && current.getHostSystemId() != null) {
current.setSystemId(current.getHostSystemId());
}
else {
--
1.8.1.4
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] Fix html not being escaped in package information
Hello,
here is another small bugfix patch fixing HTML not being properly escaped
in package description on this page:
https:///rhn/software/packages/Details.do?pid=
Found that with a package where there was an email address in "<...>"
notation that didn't show up.
Thanks and regards,
Johannes
--
SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg)
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer
>From 63be1b2d99b4a594e3cd198565ea5a13197aae87 Mon Sep 17 00:00:00 2001
From: Johannes Renner
Date: Mon, 5 Aug 2013 15:42:53 +0200
Subject: [PATCH] Fix HTML not being escaped in package information
---
.../redhat/rhn/frontend/action/rhnpackage/PackageDetailsAction.java | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/java/code/src/com/redhat/rhn/frontend/action/rhnpackage/PackageDetailsAction.java b/java/code/src/com/redhat/rhn/frontend/action/rhnpackage/PackageDetailsAction.java
index b94830c..cf9f7f8 100644
--- a/java/code/src/com/redhat/rhn/frontend/action/rhnpackage/PackageDetailsAction.java
+++ b/java/code/src/com/redhat/rhn/frontend/action/rhnpackage/PackageDetailsAction.java
@@ -30,6 +30,7 @@ import com.redhat.rhn.frontend.xmlrpc.NoSuchPackageException;
import com.redhat.rhn.manager.download.DownloadManager;
import com.redhat.rhn.manager.rhnpackage.PackageManager;
+import org.apache.commons.lang.StringEscapeUtils;
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionForward;
import org.apache.struts.action.ActionMapping;
@@ -125,8 +126,8 @@ public class PackageDetailsAction extends RhnAction {
request.setAttribute("pack", pkg);
// description can be null.
if (pkg.getDescription() != null) {
-request.setAttribute("description",
-pkg.getDescription().replace("\n", "\n"));
+String description = StringEscapeUtils.escapeHtml(pkg.getDescription());
+request.setAttribute("description", description.replace("\n", "\n"));
}
else {
request.setAttribute("description",
--
1.8.1.4
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] SystemHandlerTest: do not rely on hardcoded sequence ids
SystemHandlerTest was failing in our environment and, AFAIU, it expects
that the underlying database will always return 1 as the id of a
persisted test object. This is normally not the case, as the value is
taken from a sequence and there is no code to ensure it is reset before
the test, so I simply relaxed that condition accordingly.
See attached patch.
Regards,
--
Silvio Moioli
SUSE LINUX Products GmbH
Maxfeldstraße 5, 90409 Nürnberg Germany
>From ec1b4e81c7e82005293bb50623aa6bef8bdcc92c Mon Sep 17 00:00:00 2001
From: Silvio Moioli
Date: Wed, 11 Sep 2013 15:00:56 +0200
Subject: [PATCH 20/22] SystemHandlerTest: do not rely on hardcoded sequence
ids
---
.../com/redhat/rhn/frontend/xmlrpc/system/test/SystemHandlerTest.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/java/code/src/com/redhat/rhn/frontend/xmlrpc/system/test/SystemHandlerTest.java b/java/code/src/com/redhat/rhn/frontend/xmlrpc/system/test/SystemHandlerTest.java
index 2bdf677..e885711 100644
--- a/java/code/src/com/redhat/rhn/frontend/xmlrpc/system/test/SystemHandlerTest.java
+++ b/java/code/src/com/redhat/rhn/frontend/xmlrpc/system/test/SystemHandlerTest.java
@@ -1858,7 +1858,7 @@ public class SystemHandlerTest extends BaseHandlerTestCase {
Long returnInt = handler.scheduleReboot(adminKey,
new Integer(testServer.getId().intValue()), new Date());
-assertEquals(returnInt, new Integer(1));
+assertNotNull(returnInt);
dr = ActionManager.recentlyScheduledActions(admin, null, 30);
assertEquals(1, dr.size() - preScheduleSize);
--
1.8.1.4
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] License of spacewalk-branding needs to be changed
Hello,
The license of the spacewalk-branding package needs to be changed since from
now on
the following css frameworks, fonts and icons will be included with the package:
- Twitter Bootstrap (Apache-2.0)
- Font Awesome (MIT and OFL-1.1)
- Roboto Font (Apache-2.0)
See this bug for tracking the issue:
https://bugzilla.redhat.com/show_bug.cgi?id=1033062
Please see also the attached patch changing the license using the spdx specs
[1].
Regards,
Johannes
[1] http://spdx.org/licenses/
--
SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg)
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer
>From 633c050f3a068aa8a52a217c5f6ea55cd15a3937 Mon Sep 17 00:00:00 2001
From: Johannes Renner
Date: Thu, 21 Nov 2013 15:00:27 +0100
Subject: [PATCH] Fix the "License" of spacewalk-branding package
---
branding/spacewalk-branding.spec | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/branding/spacewalk-branding.spec b/branding/spacewalk-branding.spec
index 5194fdd..d4646f1 100644
--- a/branding/spacewalk-branding.spec
+++ b/branding/spacewalk-branding.spec
@@ -28,7 +28,7 @@ Release:1%{?dist}
Summary:Spacewalk branding data
Group: Applications/Internet
-License:GPLv2
+License:Apache-2.0 and GPL-2.0 and MIT and OFL-1.1
URL:https://fedorahosted.org/spacewalk/
Source0:https://fedorahosted.org/releases/s/p/spacewalk/%{name}-%{version}.tar.gz
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
--
1.8.1.4
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Twitter Bootstrap: Standardizing the CSS framework?
On 26/07/13 09:05, Tomas Lestach wrote: > Hello Duncan, > > I wasn't able to apply your patch. > Could you send your patch rebased on latest master? Or at least write me > against what commit I shall apply it. > It seems that java/code/webapp/WEB-INF/includes/header.jsp version against > that > the patch is done, was never in Spacewalk. > > Please create your patch using: git format-patch The patch is against SUSE Manager, as I mentioned it is a quick port of the basics. I sent it mostly so that you get an idea of what is touched. I will try to make a patch against master if you really want to "see" it. > Btw. do you plan to apply the bootstrap framework to perl pages as they are? Well, if we apply it, we will need to fix everything otherwise we will not be able to release ourselves. What I am not sure is how clean the initial commit to master can be, as there will be always stuff that will need fixing and lot of eyes stabilizing it. We have a bunch of perl pages already ported to Java as part of a feature we are doing, but I guess there is still more Perl around. Another possible workaround would be to use LESS features to auto-fix incomplete ports. We can have a compat.css with the original styles defined using LESS mixins. -- Duncan Mac-Vicar P. - http://www.suse.com/ SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) Maxfeldstraße 5, 90409 Nürnberg, Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] build rhn-client-tools on openSUSE
Hi, Am Donnerstag, 14. April 2011, 11:05:09 schrieb Miroslav Suchý: > On 04/14/2011 10:27 AM, Michael Calmer wrote: [...] > > When do you need to know the project name for > > the announcement? > > It will be nice if you can provide me with url and project name soon > (read as tomorrow, or at Monday) and you can build the packages later > there. I will let you know at least one day before release. I have created systemsmanagement:spacewalk:1.4 project in OBS The repository URL is: for openSUSE 11.4 (i586 and x86_64): http://download.opensuse.org/repositories/systemsmanagement:/spacewalk:/1.4/openSUSE_11.4/ for openSUSE Factory(i586 and x86_64): http://download.opensuse.org/repositories/systemsmanagement:/spacewalk:/1.4/openSUSE_Factory/ -- Regards, Michael Calmer -- Michael Calmer SUSE LINUX Products GmbH, Maxfeldstr. 5, D-90409 Nuernberg T: +49 (0) 911 74053 0 F: +49 (0) 911 74053575 - e-mail: michael.cal...@suse.com -- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] some patches for monitoring on postgres and pylint findings
Hi, Am Dienstag, 29. November 2011, 08:29:03 schrieb Jan Pazdziora: > On Mon, Nov 28, 2011 at 06:07:27PM +0100, Miroslav Suchy wrote: > > Dne 28.11.2011 17:33, Michael Calmer napsal(a): > > >Hi, [...] > I any case, the fix was not correct. You do *not* want to put > single-space strings there if you hit the vn_* constraint, you should > put in null (undef in Perl), not ' '. See > > https://fedorahosted.org/spacewalk/wiki/PostgreSQLPortingGuide#empty_string_null right, undef is better > I hopefully fixed it with commit > > 6fe5acfe48abd7e07ef2f87da7422a6bf13dbd23 But you should write "undef" and not "under" :-) -- Regards Michael Calmer -- Michael Calmer SUSE LINUX Products GmbH, Maxfeldstr. 5, D-90409 Nuernberg T: +49 (0) 911 74053 0 F: +49 (0) 911 74053575 - e-mail: michael.cal...@suse.com -- SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer HRB 16746 (AG Nürnberg) signature.asc Description: This is a digitally signed message part. ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] rhn-prefix check when creating new channel
Hi Astronauts The create channel page does a check for a prefix rhn-*. As we replaced some errror messages "Redhat" with a configurable vendor string we now get the error message as "SUSE channels creation need admin privileges" (or something like that) We are discussing how to remove that check in the best "upstream-friendly" way possible: - remove the restriction completely (btw, the regex is duplicated, I guess CreateChannelCommand could use the one in NewChannelHelper instead) - Allow to disable the check - Or its generic version: make it a "vendor restriction" and the regex configurable What do you think? In any case we need to get rid of the check, we are trying to avoid a patch in our tree that would live forever. cheers -- Duncan Mac-Vicar P. - http://www.suse.com/ SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) Maxfeldstraße 5, 90409 Nürnberg, Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] rhn-prefix check when creating new channel
On 03/02/2012 04:20 PM, Miroslav Suchý wrote: On 03/02/2012 02:57 PM, Duncan Mac-Vicar P. wrote: As we replaced some errror messages "Redhat" with a configurable vendor string we now get the error message as Did I miss this patch? - Or its generic version: make it a "vendor restriction" and the regex configurable Hmm, this one sounds best to me. For channel validation there seems to be a bunch of duplicated code: NewChannelHelper and CreateChannelCommand both perform very similar validations. If I make the regexp "rhn" independent, configurable and switchable/optional it would be easier if the validations are refactored in one place. I think the right place for the validations is the helper, and the command class should consume the validations from the helper. Is that fine? Duncan ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Bootstrap image feature
On 02.08.2012 11:15, Jan Pazdziora wrote:
* inventing a new architecture "bootstrap-linux" that automatically
gets the new entitlement during registration.
Could you please explain some more why new architecture is needed?
Won't we actually need to know what architecture (the physical one)
the machine is?
I wanted to clean up the patch today and noticed, that we still need the
architecture.
The architecture is directly connected to the new bootstrap-entitlement
in the database via rhnServerServerGroupArchCompat table:
insert into rhnServerServerGroupArchCompat ( server_arch_id,
server_group_type)
values (lookup_server_arch('bootstrap-linux'),
lookup_sg_type('bootstrap_entitled'));
insert into rhnServerServerGroupArchCompat ( server_arch_id,
server_group_type)
values (lookup_server_arch('bootstrap-linux'),
lookup_sg_type('provisioning_entitled'));
if a machine registers with that arch, it'll get the
bootstrap-entitlement automatically.
Please correct me if I'm wrong or misunderstood something but I'm
afraid, we still need the arch.
--
ciao, Uwe Gansert
SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg)
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer
Home: http://www.suse.de/~ug - Blog: http://suse.gansert.net
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] SSH Push Feature Proposal
On 30/04/13 16:25, Jan Pazdziora wrote: > On Tue, Apr 30, 2013 at 04:08:54PM +0200, Duncan Mac-Vicar P. wrote: >> On 24/04/13 14:38, Johannes Renner wrote: Can the logic you propose to be put to taskomatic be put to osa-dispatcher, to throttle the number of clients which get "invited" to rhn_check? >> >> Doesn't osad work by having the clients connect via XMPP _to_ the server? > > Sure. But they just connect and then wait for osa-dispatcher to tell > them to run rhn_check. > I understand. I am just trying to highlight that osad solves the problem of "real-time", while ssh push is to solve the problem of a non accessible Spacewalk server, from the host systems. -- Duncan Mac-Vicar P. - http://www.suse.com/ SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) Maxfeldstraße 5, 90409 Nürnberg, Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk
On 01/07/2014 12:04 PM, Michael Mraka wrote: Is it possible to keep original pwstrength-bootstrap*.js unmodified and put modification to the separate .js (call modified functions from the page and call original functions from them)? Hi Michael, I end up with 2 separate .js files now. First one is the original sources, packaged and patched through the spec file in spec-tree. Second one is a caller .js with the document.ready handler and some custom functions. Question is now do I need to package the second .js as well? Or can i simply add it to the git tree in web/html/javascript? -- -- Mit freundlichen Grüßen, Maximilian Meister Systems Management Department SUSE LINUX Products GmbH Maxfeldstr. 5 D-90409 Nuremberg, Germany http://www.suse.com GF: Jeff Hawn, Jennifer Guild, Felix Imendoerffer, HRB 21284 (AG Nuremberg) ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] On picking a standard on HTML5 void tags
On 18/02/14 14:10, Michael Mraka wrote: > Using self-closed tags for void elements as well as using end tags even > in situations where they can be omitted in HTML5 is common agreement > among whole team. They improve readability - you immediately know what > was intentional and what a mistake. > > As for patch rejection - no, most likely the other way round :). I am fine with using self-closing tags as long as everyone is aware that using it in a non-void tag will create bad markup and understand that the browser will just remove the /'s. It happened with already, which is wrong and invalid) In HTML5 is expanded to . Not to as in XHTML. -- Duncan Mac-Vicar P. - http://www.suse.com/ SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) Maxfeldstraße 5, 90409 Nürnberg, Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Hide the 'delete note' link on creation of system notes
On 03/01/2011 02:31 PM, Jan Pazdziora wrote: On Tue, Mar 01, 2011 at 11:26:57AM +0100, Johannes Renner wrote: > From ea324e8b7b6907f24d010b7b4439bc1e00e8f8bf Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Thu, 17 Feb 2011 11:20:52 +0100 Subject: [PATCH] do not show delete link on creation of notes (bnc#672090) One note here -- we really like the bugzillas to be public when they are referenced in the git commits. Is the bnc#672090 going to be flipped to public eventually? I think we need to define a policy here (for my team) on how to upstream those bugs. After talking to Cliff I realized some bugs are also handled internally (customers) at bugzilla.redhat.com, and they are copied. Should we do the same?: open a public bug in bugzilla.redhat.com product "Spacewalk" copying the one from our internal bugzilla? I can also find a way to make some bugs public, but then those would be in Novell's bugzilla. -- Duncan Mac-Vicar P. - Novell® Making IT Work As One™ SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg) ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] Patch proposal: try-wrapping XMLRPC serialization code
Hi, We had a downstream bug that boiled down to an uncaught exception in XMLRPC serialization code (a class implementing XmlRpcCustomSerializer). AFAIU at the moment any uncaught exception from by the serialize() is basically ignored, "digested" by the redstone library and not added to any log or error output, making it quite hard to find out issues. I would like to add some code to add some exception details to the error log. You can easily reproduce the bug on basically any Spacewalk version by adding a line like this: throw new NullPointerException(); to ServerSerializer.serialize(), then calling via API any XMLRPC method that returns a server. Proposed solution would be to try-wrap all serialize() methods in the application, which is the only way I can think of to handle those exceptions in Spacewalk code, since this problem really stems from redstone. Creating a superclass is unfortunately not an option because the serialize() method signature can change. Any feedback or better idea is welcome. In case this is really the only viable solution, would you accept such a patch? Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] build spacewalk-remote-utils on openSUSE
Hi,
Am Freitag, 8. April 2011, 15:14:25 schrieb Michael Calmer:
> Hi,
>
> here is the patch to build spacewalk-remote-utils on openSUSE.
>
> 0012-build-spacewalk-remote-utils-on-SUSE.patch
> - adding only one little dir to the filelist of the specfile
Attached is a new version of this patch. It now buildrequires rhn-client-tools
to get the directories.
--
MFG
Michael Calmer
--
Michael Calmer
SUSE LINUX Products GmbH, Maxfeldstr. 5, D-90409 Nuernberg
T: +49 (0) 911 74053 0
F: +49 (0) 911 74053575 - e-mail: michael.cal...@suse.com
--
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
From 960aada71c92b06445868e62ef76b34f94df4ad7 Mon Sep 17 00:00:00 2001
From: Michael Calmer
Date: Fri, 15 Apr 2011 11:57:15 +0200
Subject: [PATCH 11/13] build spacewalk-remote-utils on SUSE
- BuildRequires rhn-client-tools to provide directories
for filelist check in OBS
---
.../spacewalk-remote-utils.spec|4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/client/tools/spacewalk-remote-utils/spacewalk-remote-utils.spec b/client/tools/spacewalk-remote-utils/spacewalk-remote-utils.spec
index 8b0f770..cb76ac9 100644
--- a/client/tools/spacewalk-remote-utils/spacewalk-remote-utils.spec
+++ b/client/tools/spacewalk-remote-utils/spacewalk-remote-utils.spec
@@ -18,6 +18,10 @@ BuildArch: noarch
Requires:rhnlib >= 2.5.38
BuildRequires: python-devel
BuildRequires: docbook-utils
+%if 0%{?suse_version}
+# provide directories for filelist check in OBS
+BuildRequires: rhn-client-tools
+%endif
%description
Utilities to interact with a RHN Satellite or Spacewalk server remotely over XMLRPC.
--
1.7.3.4
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] Password with less than minlength characters accepted
Hello,
There seems to be a bug in the Spacewalk Java code that allows a user
to set whatever password regardless of any errors (e.g. length <
minlength), as long as the desired and confirm password are equal. It
is even possible to set a user's password to the empty string, which
results in not being able to login anymore after sign out! Attached is
a patch that fixes the problem.
Greetings,
Johannes Renner
--
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
>From 57bac09f19795e5fc4c21514da4ac20bef9cc79d Mon Sep 17 00:00:00 2001
From: Johannes Renner
Date: Tue, 18 Jan 2011 15:58:23 +0100
Subject: [PATCH] Password with less than minlength characters accepted
---
.../frontend/action/user/UserEditActionHelper.java | 11 ++-
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/java/code/src/com/redhat/rhn/frontend/action/user/UserEditActionHelper.java b/java/code/src/com/redhat/rhn/frontend/action/user/UserEditActionHelper.java
index 79529b4..68f6ce0 100644
--- a/java/code/src/com/redhat/rhn/frontend/action/user/UserEditActionHelper.java
+++ b/java/code/src/com/redhat/rhn/frontend/action/user/UserEditActionHelper.java
@@ -45,12 +45,13 @@ public abstract class UserEditActionHelper extends RhnAction {
form.get(UserActionHelper.DESIRED_PASS))) {
String pw = (String)form.get(UserActionHelper.DESIRED_PASS);
String conf = (String)form.get(UserActionHelper.DESIRED_PASS_CONFIRM);
-if (pw.equals(conf)) {
-targetUser.setPassword(pw);
-}
-else {
+if (!pw.equals(conf)) {
errors.add(ActionMessages.GLOBAL_MESSAGE,
- new ActionMessage("error.password_mismatch"));
+new ActionMessage("error.password_mismatch"));
+}
+else if (errors.isEmpty()) {
+//Set the password only if there are no errors at all
+targetUser.setPassword(pw);
}
}
--
1.7.1
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] Error message when successfully toggling user roles
Hey,
Here is a (very) small thing I stumbled upon: There is an error message
sent to the client even in case of success while toggling administrator
roles of single users. Please see the attached patch for a fix to send
a success message instead. There is further no bugzilla item about this,
since it was probably never an issue..
(The URI of the respective page is /rhn/admin/multiorg/Users.do)
Greetings,
Johannes
--
SUSE LINUX Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg)
>From 9138ab493776b334005c8ab63f635284b913da6e Mon Sep 17 00:00:00 2001
From: Johannes Renner
Date: Tue, 6 Sep 2011 10:03:55 +0200
Subject: [PATCH] Do not send error message in case of success
---
.../frontend/action/multiorg/SatAdminAction.java |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/java/code/src/com/redhat/rhn/frontend/action/multiorg/SatAdminAction.java b/java/code/src/com/redhat/rhn/frontend/action/multiorg/SatAdminAction.java
index 479a7ad..3fe048c 100644
--- a/java/code/src/com/redhat/rhn/frontend/action/multiorg/SatAdminAction.java
+++ b/java/code/src/com/redhat/rhn/frontend/action/multiorg/SatAdminAction.java
@@ -76,12 +76,12 @@ public class SatAdminAction extends RhnAction {
// check role and toggle
if (u.hasRole(RoleFactory.SAT_ADMIN)) {
u.removeRole(RoleFactory.SAT_ADMIN);
-createErrorMessage(request, "user.satadmin.remove",
+createSuccessMessage(request, "user.satadmin.remove",
u.getLogin());
}
else {
u.addRole(RoleFactory.SAT_ADMIN);
-createErrorMessage(request, "user.satadmin.add",
+createSuccessMessage(request, "user.satadmin.add",
u.getLogin());
}
--
1.7.3.4
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] fixing dead links in list
Hi,
I found a page with links to not existing pages.
Overview => Subscription Management => Software Channel Entitlements =>
click on a number in "Systems Subscribed" column
You see a page with a list of all Systems which uses this entitlement, but
if you click on the Errata or Package Number you end up in a not existing
page.
The attached patch should bring you to the java pages.
--
Regards
Michael Calmer
--
Michael Calmer
SUSE LINUX Products GmbH, Maxfeldstr. 5, D-90409 Nuernberg
T: +49 (0) 911 74053 0
F: +49 (0) 911 74053575 - e-mail: michael.cal...@suse.com
--
SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer
HRB 16746 (AG Nürnberg)
From d247d08ec753d7eac5ba38f8fe8bc472c4161974 Mon Sep 17 00:00:00 2001
From: Michael Calmer
Date: Fri, 13 Apr 2012 16:13:28 +0200
Subject: [PATCH] change links to existing pages
---
web/html/network/systems/system_list |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/web/html/network/systems/system_list b/web/html/network/systems/system_list
index 2e36da1..368cb9f 100644
--- a/web/html/network/systems/system_list
+++ b/web/html/network/systems/system_list
@@ -30,10 +30,10 @@
-/network/systems/details/errata_list.pxt?sid={column:id}
+/rhn/systems/details/ErrataList.do?sid={column:id}
-/network/systems/details/packages/upgrade.pxt?sid={column:id}
+/rhn/systems/details/packages/UpgradableList.do?sid={column:id}
/rhn/systems/details/Overview.do?sid={column:id}
--
1.7.3.4
signature.asc
Description: This is a digitally signed message part.
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Kickstartable channels should contain the anaconda package
On 03/13/2013 05:33 PM, Johannes Renner wrote:
> attached is a patch that should take care that only kickstartable channels
> are actually
> returned by the getKickstartableChannels() method in the ChannelFactory class.
Argh, this fixes ConcurrentModificationException, sorry!
--
SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg)
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer
>From acaadc6ee2a54f2e803f33ff5d401559b2e35359 Mon Sep 17 00:00:00 2001
From: Johannes Renner
Date: Thu, 14 Mar 2013 17:52:15 +0100
Subject: [PATCH] Prevent from concurrent modification
---
.../code/src/com/redhat/rhn/domain/channel/ChannelFactory.java |8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/java/code/src/com/redhat/rhn/domain/channel/ChannelFactory.java b/java/code/src/com/redhat/rhn/domain/channel/ChannelFactory.java
index 5509f2b..f60cfb4 100644
--- a/java/code/src/com/redhat/rhn/domain/channel/ChannelFactory.java
+++ b/java/code/src/com/redhat/rhn/domain/channel/ChannelFactory.java
@@ -35,6 +35,7 @@ import org.hibernate.criterion.CriteriaSpecification;
import org.hibernate.criterion.Projections;
import org.hibernate.criterion.Restrictions;
+import java.util.ArrayList;
import java.util.Collection;
import java.util.Collections;
import java.util.HashMap;
@@ -631,6 +632,7 @@ public class ChannelFactory extends HibernateFactory {
* @return List of Channel objects
*/
public static List getKickstartableChannels(Org org) {
+List ret = new ArrayList();
Map params = new HashMap();
params.put("org_id", org.getId());
List channels = singleton.listObjectsByNamedQuery(
@@ -639,11 +641,11 @@ public class ChannelFactory extends HibernateFactory {
for (Channel c : channels) {
List packages = ChannelManager.listLatestPackagesEqual(c.getId(),
ConfigDefaults.DEFAULT_ANACONDA_PACKAGE_NAME);
-if (packages.size() <= 0) {
-channels.remove(c);
+if (packages.size() > 0) {
+ret.add(c);
}
}
-return channels;
+return ret;
}
/**
--
1.7.10.4
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] ConfigureSatelliteCommandTest: do not rely on HashMap key ordering
I noticed that ConfigureSatelliteCommandTest makes an assertion that
depends on a HashMap key ordering, it was changed it to a SortedMap to
guarantee repeatability.
See attached patch.
Regards,
--
Silvio Moioli
SUSE LINUX Products GmbH
Maxfeldstraße 5, 90409 Nürnberg Germany
>From 005e216a8cba6ace617750dfb09dc170fbd60ac9 Mon Sep 17 00:00:00 2001
From: Silvio Moioli
Date: Fri, 6 Sep 2013 08:23:06 +0200
Subject: [PATCH] ConfigureSatelliteCommandTest: do not rely on HashMap key
ordering
---
.../rhn/manager/satellite/test/ConfigureSatelliteCommandTest.java | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/java/code/src/com/redhat/rhn/manager/satellite/test/ConfigureSatelliteCommandTest.java b/java/code/src/com/redhat/rhn/manager/satellite/test/ConfigureSatelliteCommandTest.java
index 28904d0..95e5cb9 100644
--- a/java/code/src/com/redhat/rhn/manager/satellite/test/ConfigureSatelliteCommandTest.java
+++ b/java/code/src/com/redhat/rhn/manager/satellite/test/ConfigureSatelliteCommandTest.java
@@ -28,10 +28,10 @@ import com.redhat.rhn.manager.satellite.Executor;
import com.redhat.rhn.testing.BaseTestCaseWithUser;
import com.redhat.rhn.testing.TestUtils;
-import java.util.HashMap;
import java.util.Iterator;
import java.util.List;
import java.util.Map;
+import java.util.TreeMap;
/**
* ConfigureSatelliteCommandTest - test for ConfigureSatelliteCommand
@@ -73,7 +73,7 @@ public class ConfigureSatelliteCommandTest extends BaseTestCaseWithUser {
assertTrue(cmd.getKeysToBeUpdated().contains(TEST_CONFIG_STRING));
assertTrue(cmd.getKeysToBeUpdated().contains(TEST_CONFIG_NULL));
-Map optionMap = new HashMap();
+Map optionMap = new TreeMap();
Iterator i = cmd.getKeysToBeUpdated().iterator();
while (i.hasNext()) {
String key = (String) i.next();
@@ -82,7 +82,7 @@ public class ConfigureSatelliteCommandTest extends BaseTestCaseWithUser {
String[] cmdargs = cmd.getCommandArguments(Config.getDefaultConfigFilePath(),
optionMap);
-assertEquals("--option=test.null_config.config_sat_test=", cmdargs[5]);
+assertEquals("--option=test.null_config.config_sat_test=", cmdargs[4]);
assertEquals(9, cmdargs.length);
assertNull(cmd.storeConfiguration());
assertTrue(cmd.getKeysToBeUpdated().size() == 0);
--
1.8.1.4
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
