[Spacewalk-devel] [PATCH 2/6] Python db tests: moved connection settings to dedicated file

2013-10-04 Thread Flavio Castelli
Moved PostgreSQL connection settings into a dedicated configuration file. This makes easier to use different connection parameters since it's no longer needed to change the python source code. --- backend/test/db_settings.ini| 5 + backend/test/runtests-postgresql.py | 12

[Spacewalk-devel] [PATCH 3/6] Python pgsql driver: handled ProgrammingError exceptions

2013-10-04 Thread Flavio Castelli
Handled psycopg2.ProgramminError exceptions inside of the python pgsql driver. Raise them as sql_base.SQLStatementPrepareError. This is commit fixes the 'test_statement_prepare_error' test. --- backend/server/rhnSQL/driver_postgresql.py | 2 ++ 1 file changed, 2 insertions(+) diff --git

[Spacewalk-devel] [PATCH 1/6] Fixed script which runs python PostgreSQL tests

2013-10-04 Thread Flavio Castelli
The script which starts the python PostgreSQL tests was broken because it didn't find some required resources, plus it looked for files/directories which are no longer available. --- backend/test/runtests-postgresql.py | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

[Spacewalk-devel] [PATCHES] Some work on the python PostgreSQL tests

2013-10-04 Thread Flavio Castelli
Hello, the following patches make possible to run all the python tests interacting with PostgreSQL. Right now all the tests are passing. Most of the changes are trivial, except for patch #5 which could break something; you can find all the details inside of the patch itself. I didn't look into

[Spacewalk-devel] [PATCH 5/6] Python: fixed UserDictCase behaviour when key is not found

2013-10-04 Thread Flavio Castelli
The `UserDictCase` class is a dictionary with case insensitive keys. Since it's inherited from `UserDict` it can be passed to method/functions expecting a classic python dictionary. Unfortunately `UserDictCase` behaved in a different way when the specified key was not found: rather than raising a

[Spacewalk-devel] [PATCH 4/6] Fixed errors inside of the python pgsql test suite.

2013-10-04 Thread Flavio Castelli
Wrapped the 'test_statement_prepare_error' test inside of a transaction, that leaves the database in a clean state after the `rhnSQL.SQLStatementPrepareError` exception is raised. --- backend/test/non-unit/server/rhnSQL/dbtests.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

Re: [Spacewalk-devel] [PATCHES] Some work on the python PostgreSQL tests

2013-10-04 Thread Michael Mraka
Flavio Castelli wrote: % Hello, the following patches make possible to run all the python tests % interacting with PostgreSQL. Right now all the tests are passing. % % Most of the changes are trivial, except for patch #5 which could break % something; you can find all the details inside of the

Re: [Spacewalk-devel] [PATCH] Adding fallback support for numeric UID/GID if lookup fails and username/groupname is numeric.

2013-10-04 Thread Michael Mraka
% From: Nick Piacentine npi...@mars.asu.edu % % --- % client/tools/rhncfg/config_common/transactions.py | 8 % 1 file changed, 8 insertions(+) Hello Nick, I've reviewed your patch and commited it (with some minor changes). Thanks for your contribution. -- Michael Mráka Satellite

Re: [Spacewalk-devel] reboot a single system is broken in master

2013-10-04 Thread Cliff Perry
On 23/09/13 06:20, Tomáš Kašpárek wrote: On 09/20/2013 04:21 PM, Michael Calmer wrote: Hi, Just to let you know: just saw, that reboot a single system in master is currently broken. I get a 4.4 not found because /network/systems/details/reboot_confirm.pxt page was removed. It was deleted by